[INFO] fetching crate syncz 0.1.8... [INFO] linting syncz-0.1.8 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate syncz 0.1.8 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate syncz 0.1.8 [INFO] finished tweaking crates.io crate syncz 0.1.8 [INFO] tweaked toml for crates.io crate syncz 0.1.8 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate syncz 0.1.8 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate syncz 0.1.8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1702beb776e13ed6e31fce12c55c6b606935d2fe80ff41d2c4b2b68810534c83 [INFO] running `Command { std: "docker" "start" "-a" "1702beb776e13ed6e31fce12c55c6b606935d2fe80ff41d2c4b2b68810534c83", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1702beb776e13ed6e31fce12c55c6b606935d2fe80ff41d2c4b2b68810534c83", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1702beb776e13ed6e31fce12c55c6b606935d2fe80ff41d2c4b2b68810534c83", kill_on_drop: false }` [INFO] [stdout] 1702beb776e13ed6e31fce12c55c6b606935d2fe80ff41d2c4b2b68810534c83 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7c56a5f72bbddd568aca4a8bba48f625e9a399677a8f03b81e6dfb30b226d44f [INFO] running `Command { std: "docker" "start" "-a" "7c56a5f72bbddd568aca4a8bba48f625e9a399677a8f03b81e6dfb30b226d44f", kill_on_drop: false }` [INFO] [stderr] Compiling portable-atomic v1.12.0 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking notify-types v2.0.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking shell-words v1.1.1 [INFO] [stderr] Checking inotify v0.11.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking notify v8.2.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking syncz v0.1.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | self.push || (!self.push && !self.pull) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 85 - self.push || (!self.push && !self.pull) [INFO] [stdout] 85 + !(!self.push && self.pull) [INFO] [stdout] | [INFO] [stdout] 85 - self.push || (!self.push && !self.pull) [INFO] [stdout] 85 + self.push || !self.pull [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | self.pull || (!self.push && !self.pull) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 89 - self.pull || (!self.push && !self.pull) [INFO] [stdout] 89 + !(!self.pull && self.push) [INFO] [stdout] | [INFO] [stdout] 89 - self.pull || (!self.push && !self.pull) [INFO] [stdout] 89 + self.pull || !self.push [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/main.rs:188:31 [INFO] [stdout] | [INFO] [stdout] 188 | while let Ok(_) = rx.try_recv() {} [INFO] [stdout] | ----------^^^^^---------------- help: try: `while rx.try_recv().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> src/main.rs:209:28 [INFO] [stdout] | [INFO] [stdout] 209 | let mut expanded = PathBuf::from(home); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `home` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/main.rs:308:36 [INFO] [stdout] | [INFO] [stdout] 308 | let remote_parent = if is_file { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 309 | | parent_of_remote(remote_path) [INFO] [stdout] 310 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/main.rs:310:12 [INFO] [stdout] | [INFO] [stdout] 310 | } else { [INFO] [stdout] | ____________^ [INFO] [stdout] 311 | | parent_of_remote(remote_path) [INFO] [stdout] 312 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `flatten()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/main.rs:504:36 [INFO] [stdout] | [INFO] [stdout] 504 | for line in reader.lines().flatten() { [INFO] [stdout] | ^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/main.rs:504:21 [INFO] [stdout] | [INFO] [stdout] 504 | for line in reader.lines().flatten() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] = note: `#[warn(clippy::lines_filter_map_ok)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `flatten()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/main.rs:526:36 [INFO] [stdout] | [INFO] [stdout] 526 | for line in reader.lines().flatten() { [INFO] [stdout] | ^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/main.rs:526:21 [INFO] [stdout] | [INFO] [stdout] 526 | for line in reader.lines().flatten() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | self.push || (!self.push && !self.pull) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 85 - self.push || (!self.push && !self.pull) [INFO] [stdout] 85 + !(!self.push && self.pull) [INFO] [stdout] | [INFO] [stdout] 85 - self.push || (!self.push && !self.pull) [INFO] [stdout] 85 + self.push || !self.pull [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | self.pull || (!self.push && !self.pull) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 89 - self.pull || (!self.push && !self.pull) [INFO] [stdout] 89 + !(!self.pull && self.push) [INFO] [stdout] | [INFO] [stdout] 89 - self.pull || (!self.push && !self.pull) [INFO] [stdout] 89 + self.pull || !self.push [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/main.rs:188:31 [INFO] [stdout] | [INFO] [stdout] 188 | while let Ok(_) = rx.try_recv() {} [INFO] [stdout] | ----------^^^^^---------------- help: try: `while rx.try_recv().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> src/main.rs:209:28 [INFO] [stdout] | [INFO] [stdout] 209 | let mut expanded = PathBuf::from(home); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `home` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/main.rs:308:36 [INFO] [stdout] | [INFO] [stdout] 308 | let remote_parent = if is_file { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 309 | | parent_of_remote(remote_path) [INFO] [stdout] 310 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/main.rs:310:12 [INFO] [stdout] | [INFO] [stdout] 310 | } else { [INFO] [stdout] | ____________^ [INFO] [stdout] 311 | | parent_of_remote(remote_path) [INFO] [stdout] 312 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `flatten()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/main.rs:504:36 [INFO] [stdout] | [INFO] [stdout] 504 | for line in reader.lines().flatten() { [INFO] [stdout] | ^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/main.rs:504:21 [INFO] [stdout] | [INFO] [stdout] 504 | for line in reader.lines().flatten() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] = note: `#[warn(clippy::lines_filter_map_ok)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `flatten()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/main.rs:526:36 [INFO] [stdout] | [INFO] [stdout] 526 | for line in reader.lines().flatten() { [INFO] [stdout] | ^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/main.rs:526:21 [INFO] [stdout] | [INFO] [stdout] 526 | for line in reader.lines().flatten() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.84s [INFO] running `Command { std: "docker" "inspect" "7c56a5f72bbddd568aca4a8bba48f625e9a399677a8f03b81e6dfb30b226d44f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c56a5f72bbddd568aca4a8bba48f625e9a399677a8f03b81e6dfb30b226d44f", kill_on_drop: false }` [INFO] [stdout] 7c56a5f72bbddd568aca4a8bba48f625e9a399677a8f03b81e6dfb30b226d44f