[INFO] fetching crate substudy 0.5.2... [INFO] linting substudy-0.5.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate substudy 0.5.2 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate substudy 0.5.2 [INFO] finished tweaking crates.io crate substudy 0.5.2 [INFO] tweaked toml for crates.io crate substudy 0.5.2 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate substudy 0.5.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate substudy 0.5.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded paragraph-breaker v0.4.4 [INFO] [stderr] Downloaded peg-runtime v0.8.2 [INFO] [stderr] Downloaded polonius-the-crab v0.2.1 [INFO] [stderr] Downloaded nougat v0.2.4 [INFO] [stderr] Downloaded lending-iterator v0.1.7 [INFO] [stderr] Downloaded pest_derive v2.7.8 [INFO] [stderr] Downloaded cli_test_dir v0.1.8 [INFO] [stderr] Downloaded never-say-never v6.6.666 [INFO] [stderr] Downloaded env_logger v0.11.3 [INFO] [stderr] Downloaded async-openai v0.19.0 [INFO] [stderr] Downloaded pest_generator v2.7.8 [INFO] [stderr] Downloaded macro_rules_attribute v0.1.3 [INFO] [stderr] Downloaded macro_rules_attribute-proc_macro v0.1.3 [INFO] [stderr] Downloaded pest v2.7.8 [INFO] [stderr] Downloaded handlebars v5.1.0 [INFO] [stderr] Downloaded peg v0.8.2 [INFO] [stderr] Downloaded nougat-proc_macros v0.2.4 [INFO] [stderr] Downloaded peg-macros v0.8.2 [INFO] [stderr] Downloaded h2 v0.3.24 [INFO] [stderr] Downloaded ext-trait v1.0.1 [INFO] [stderr] Downloaded extension-traits v1.0.1 [INFO] [stderr] Downloaded num-complex v0.4.5 [INFO] [stderr] Downloaded ordered-float v4.2.0 [INFO] [stderr] Downloaded lending-iterator-proc_macros v0.1.7 [INFO] [stderr] Downloaded chardet v0.2.4 [INFO] [stderr] Downloaded pest_meta v2.7.8 [INFO] [stderr] Downloaded reqwest v0.11.26 [INFO] [stderr] Downloaded ext-trait-proc_macros v1.0.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6aa4b69103e7715afcc3fee0080b5e1f30684b62ab8c0c563f4c23d2574b1dde [INFO] running `Command { std: "docker" "start" "-a" "6aa4b69103e7715afcc3fee0080b5e1f30684b62ab8c0c563f4c23d2574b1dde", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6aa4b69103e7715afcc3fee0080b5e1f30684b62ab8c0c563f4c23d2574b1dde", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6aa4b69103e7715afcc3fee0080b5e1f30684b62ab8c0c563f4c23d2574b1dde", kill_on_drop: false }` [INFO] [stdout] 6aa4b69103e7715afcc3fee0080b5e1f30684b62ab8c0c563f4c23d2574b1dde [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bb804784192d15a03fc2eda8d29e1c01497532efa4154549296b7daad736504f [INFO] running `Command { std: "docker" "start" "-a" "bb804784192d15a03fc2eda8d29e1c01497532efa4154549296b7daad736504f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling rustls v0.21.10 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling macro_rules_attribute-proc_macro v0.1.3 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Compiling peg-runtime v0.8.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Compiling peg-macros v0.8.2 [INFO] [stderr] Checking macro_rules_attribute v0.1.3 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking indexmap v2.2.5 [INFO] [stderr] Checking never-say-never v6.6.666 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking polonius-the-crab v0.2.1 [INFO] [stderr] Checking whatlang v0.16.4 [INFO] [stderr] Checking paragraph-breaker v0.4.4 [INFO] [stderr] Checking chardet v0.2.4 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking cli_test_dir v0.1.8 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking eventsource-stream v0.2.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking ordered-float v4.2.0 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking num-iter v0.1.44 [INFO] [stderr] Checking peg v0.8.2 [INFO] [stderr] Checking num-rational v0.4.1 [INFO] [stderr] Checking num v0.4.1 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking async-convert v1.0.0 [INFO] [stderr] Compiling pest v2.7.8 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling ext-trait-proc_macros v1.0.1 [INFO] [stderr] Compiling nougat-proc_macros v0.2.4 [INFO] [stderr] Compiling lending-iterator-proc_macros v0.1.7 [INFO] [stderr] Checking ext-trait v1.0.1 [INFO] [stderr] Checking clap v4.5.2 [INFO] [stderr] Checking extension-traits v1.0.1 [INFO] [stderr] Checking nougat v0.2.4 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling pest_meta v2.7.8 [INFO] [stderr] Checking lending-iterator v0.1.7 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling derive_builder_core v0.12.0 [INFO] [stderr] Compiling pest_generator v2.7.8 [INFO] [stderr] Compiling derive_builder_macro v0.12.0 [INFO] [stderr] Checking derive_builder v0.12.0 [INFO] [stderr] Compiling pest_derive v2.7.8 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking backoff v0.4.0 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking h2 v0.3.24 [INFO] [stderr] Checking serde_json v1.0.114 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking handlebars v5.1.0 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking reqwest v0.11.26 [INFO] [stderr] Checking reqwest-eventsource v0.4.0 [INFO] [stderr] Checking async-openai v0.19.0 [INFO] [stderr] Checking substudy v0.5.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/align.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 227 | lines: lines, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `lines` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/align.rs:231:18 [INFO] [stdout] | [INFO] [stdout] 231 | static STYLE1B: &'static str = ""; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/align.rs:232:18 [INFO] [stdout] | [INFO] [stdout] 232 | static STYLE1E: &'static str = ""; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/align.rs:233:18 [INFO] [stdout] | [INFO] [stdout] 233 | static STYLE2B: &'static str = ""; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/align.rs:234:18 [INFO] [stdout] | [INFO] [stdout] 234 | static STYLE2E: &'static str = ""; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/clean.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | lines: lines, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `lines` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/contexts.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | prev: prev, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `prev` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/exporter.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | subtitles: subtitles, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subtitles` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/exporter.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | language: language, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/exporter.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | video: video, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `video` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/exporter.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | foreign: foreign, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `foreign` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/exporter.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | native: native, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `native` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/exporter.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 107 | file_stem: file_stem, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_stem` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/exporter.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | dir: dir, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/review.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | foreign_lang: foreign_lang, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `foreign_lang` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/review.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | index: index, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/review.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | image_path: image_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/review.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | audio_path: audio_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `audio_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/merge.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | lines: lines, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `lines` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/time.rs:73:17 [INFO] [stdout] | [INFO] [stdout] 73 | begin: begin, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `begin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/time.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | end: end, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/video.rs:281:13 [INFO] [stdout] | [INFO] [stdout] 281 | metadata: metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:45:28 [INFO] [stdout] | [INFO] [stdout] 45 | Subtitle { index: index, period: p, lines: l } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/align.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 227 | lines: lines, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `lines` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/align.rs:231:18 [INFO] [stdout] | [INFO] [stdout] 231 | static STYLE1B: &'static str = ""; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/align.rs:232:18 [INFO] [stdout] | [INFO] [stdout] 232 | static STYLE1E: &'static str = ""; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/align.rs:233:18 [INFO] [stdout] | [INFO] [stdout] 233 | static STYLE2B: &'static str = ""; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/align.rs:234:18 [INFO] [stdout] | [INFO] [stdout] 234 | static STYLE2E: &'static str = ""; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/clean.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | lines: lines, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `lines` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/contexts.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | prev: prev, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `prev` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/exporter.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | subtitles: subtitles, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subtitles` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/exporter.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | language: language, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/exporter.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | video: video, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `video` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/exporter.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | foreign: foreign, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `foreign` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/exporter.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | native: native, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `native` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/exporter.rs:107:13 [INFO] [stdout] | [INFO] [stdout] 107 | file_stem: file_stem, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_stem` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/exporter.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | dir: dir, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/review.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | foreign_lang: foreign_lang, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `foreign_lang` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/review.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | index: index, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/review.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | image_path: image_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `image_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/export/review.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | audio_path: audio_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `audio_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/merge.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | lines: lines, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `lines` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/time.rs:73:17 [INFO] [stdout] | [INFO] [stdout] 73 | begin: begin, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `begin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/time.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | end: end, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `end` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/video.rs:281:13 [INFO] [stdout] | [INFO] [stdout] 281 | metadata: metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:45:28 [INFO] [stdout] | [INFO] [stdout] 45 | Subtitle { index: index, period: p, lines: l } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/video.rs:86:21 [INFO] [stdout] | [INFO] [stdout] 86 | pub struct Fraction(Ratio); [INFO] [stdout] | -------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `Fraction` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/align.rs:89:8 [INFO] [stdout] | [INFO] [stdout] 89 | if !(i < items.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(i >= items.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/align.rs:159:42 [INFO] [stdout] | [INFO] [stdout] 159 | let srt_es = SubtitleFile::from_path(&path_es).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `path_es` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/align.rs:161:42 [INFO] [stdout] | [INFO] [stdout] 161 | let srt_en = SubtitleFile::from_path(&path_en).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `path_en` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/align.rs:189:15 [INFO] [stdout] | [INFO] [stdout] 189 | .map(|&(ref indices1, ref indices2)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 189 - .map(|&(ref indices1, ref indices2)| { [INFO] [stdout] 189 + .map(|(indices1, indices2)| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/align.rs:190:27 [INFO] [stdout] | [INFO] [stdout] 190 | (merge(file1, &indices1), merge(file2, &indices2)) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `indices1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/align.rs:190:52 [INFO] [stdout] | [INFO] [stdout] 190 | (merge(file1, &indices1), merge(file2, &indices2)) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `indices2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/align.rs:202:14 [INFO] [stdout] | [INFO] [stdout] 202 | Some(ref file2) => align_files(file1, file2), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 202 - Some(ref file2) => align_files(file1, file2), [INFO] [stdout] 202 + Some(file2) => align_files(file1, file2), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/align.rs:220:44 [INFO] [stdout] | [INFO] [stdout] 220 | let cleaned = strip_formatting(&l); [INFO] [stdout] | ^^ help: change this to: `l` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/align.rs:240:21 [INFO] [stdout] | [INFO] [stdout] 240 | .map(|pair| match pair { [INFO] [stdout] | _____________________^ [INFO] [stdout] 241 | | &(None, None) => panic!("Shouldn't have empty alignment pair!"), [INFO] [stdout] 242 | | &(Some(ref sub), None) => clone_as(sub, STYLE1B, STYLE1E), [INFO] [stdout] 243 | | &(None, Some(ref sub)) => clone_as(sub, STYLE2B, STYLE2E), [INFO] [stdout] ... | [INFO] [stdout] 252 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 240 ~ .map(|pair| match *pair { [INFO] [stdout] 241 ~ (None, None) => panic!("Shouldn't have empty alignment pair!"), [INFO] [stdout] 242 ~ (Some(ref sub), None) => clone_as(sub, STYLE1B, STYLE1E), [INFO] [stdout] 243 ~ (None, Some(ref sub)) => clone_as(sub, STYLE2B, STYLE2E), [INFO] [stdout] 244 ~ (Some(ref sub1), Some(ref sub2)) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/align.rs:293:42 [INFO] [stdout] | [INFO] [stdout] 293 | let srt_es = SubtitleFile::from_path(&path_es).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `path_es` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/align.rs:295:42 [INFO] [stdout] | [INFO] [stdout] 295 | let srt_en = SubtitleFile::from_path(&path_en).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `path_en` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/align.rs:297:44 [INFO] [stdout] | [INFO] [stdout] 297 | let expected = SubtitleFile::from_path(&path_combined).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `path_combined` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/clean.rs:16:28 [INFO] [stdout] | [INFO] [stdout] 16 | formatting.replace_all(&line, "") [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/clean.rs:42:29 [INFO] [stdout] | [INFO] [stdout] 42 | .map(|l| clean_line(&l)) [INFO] [stdout] | ^^ help: change this to: `l` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/clean.rs:43:21 [INFO] [stdout] | [INFO] [stdout] 43 | .filter(|l| l.len() > 0) [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!l.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/clean.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 46 | if lines.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lines.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/contexts.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 49 | curr: f(&self.curr), [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.curr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/contexts.rs:55:6 [INFO] [stdout] | [INFO] [stdout] 55 | impl<'a, T: Clone> Context<&'a T> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 55 - impl<'a, T: Clone> Context<&'a T> { [INFO] [stdout] 55 + impl Context<&T> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/contexts.rs:128:6 [INFO] [stdout] | [INFO] [stdout] 128 | impl<'a, T> ItemsInContextExt for &'a [T] { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 128 - impl<'a, T> ItemsInContextExt for &'a [T] { [INFO] [stdout] 128 + impl ItemsInContextExt for &[T] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/contexts.rs:146:20 [INFO] [stdout] | [INFO] [stdout] 146 | slice: &self, [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/export/csv.rs:67:23 [INFO] [stdout] | [INFO] [stdout] 67 | .filter(|&&(ref f, _)| f.is_some()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 67 - .filter(|&&(ref f, _)| f.is_some()) [INFO] [stdout] 67 + .filter(|&(f, _)| f.is_some()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/export/csv.rs:78:36 [INFO] [stdout] | [INFO] [stdout] 78 | let foreign = ctx.map(|&(ref f, _)| f).flatten(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 78 - let foreign = ctx.map(|&(ref f, _)| f).flatten(); [INFO] [stdout] 78 + let foreign = ctx.map(|(f, _)| f).flatten(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/export/csv.rs:79:35 [INFO] [stdout] | [INFO] [stdout] 79 | let native = ctx.map(|&(_, ref n)| n).flatten(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 79 - let native = ctx.map(|&(_, ref n)| n).flatten(); [INFO] [stdout] 79 + let native = ctx.map(|(_, n)| n).flatten(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/export/exporter.rs:84:43 [INFO] [stdout] | [INFO] [stdout] 84 | let native = native_subtitles.map(|subs| LanguageResources::new(subs)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `LanguageResources::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/export/review.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | let (i, &(ref foreign, ref native)) = sub; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 41 - let (i, &(ref foreign, ref native)) = sub; [INFO] [stdout] 41 + let (i, (foreign, native)) = sub; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/export/review.rs:69:51 [INFO] [stdout] | [INFO] [stdout] 69 | handlebars.register_template_string("review", template.to_owned())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `template` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/export/tracks.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | result.push_str("…"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('…')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/export/tracks.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | prev.text.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `prev.text.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/import/whisper.rs:113:43 [INFO] [stdout] | [INFO] [stdout] 113 | let normalized = NON_WORD.replace_all(&text, "").to_string(); [INFO] [stdout] | ^^^^^ help: change this to: `text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/import/whisper.rs:189:36 [INFO] [stdout] | [INFO] [stdout] 189 | segment_indices.extend(repeat(segment_idx).take(diff_words.len())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(segment_idx, diff_words.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/import/whisper.rs:314:25 [INFO] [stdout] | [INFO] [stdout] 314 | .filter_map(|word| normalize_word_text_for_diff(word)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `normalize_word_text_for_diff` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/import/whisper.rs:313:20 [INFO] [stdout] | [INFO] [stdout] 313 | .split(&segment) [INFO] [stdout] | ^^^^^^^^ help: change this to: `segment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/import/whisper.rs:490:14 [INFO] [stdout] | [INFO] [stdout] 490 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/merge.rs:18:37 [INFO] [stdout] | [INFO] [stdout] 18 | for word in space.split(&line) { [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/merge.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | if line.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/merge.rs:29:27 [INFO] [stdout] | [INFO] [stdout] 29 | line.push_str(&word); [INFO] [stdout] | ^^^^^ help: change this to: `word` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/merge.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | line.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `line.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/merge.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 32 | line.push_str(&word); [INFO] [stdout] | ^^^^^ help: change this to: `word` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/merge.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 43 | if line.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/segment.rs:144:23 [INFO] [stdout] | [INFO] [stdout] 144 | let end_idx = bp.index as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `bp.index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/services/oai/translate.rs:92:8 [INFO] [stdout] | [INFO] [stdout] 92 | if current_chunk.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!current_chunk.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `resp.choices.get(0)` [INFO] [stdout] --> src/services/oai/mod.rs:112:18 [INFO] [stdout] | [INFO] [stdout] 112 | let choice = resp.choices.get(0).ok_or_else(|| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `resp.choices.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `tool_calls.get(0)` [INFO] [stdout] --> src/services/oai/mod.rs:119:21 [INFO] [stdout] | [INFO] [stdout] 119 | let tool_call = tool_calls [INFO] [stdout] | _____________________^ [INFO] [stdout] 120 | | .get(0) [INFO] [stdout] | |_______________^ help: try: `tool_calls.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `srt::Subtitle` [INFO] [stdout] --> src/srt.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | / pub fn to_string(&self) -> String { [INFO] [stdout] 42 | | format!( [INFO] [stdout] 43 | | "{}\n{} --> {}\n{}\n", [INFO] [stdout] 44 | | self.index, [INFO] [stdout] ... | [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `srt::Subtitle` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/srt.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | / pub fn from_str(data: &str) -> Result { [INFO] [stdout] ... | [INFO] [stdout] 72 | | .context("could not parse subtitles")?) [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/srt.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | / Ok(grammar::subtitle_file(data.trim_start_matches("\u{FEFF}")) [INFO] [stdout] 72 | | .context("could not parse subtitles")?) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 71 ~ grammar::subtitle_file(data.trim_start_matches("\u{FEFF}")) [INFO] [stdout] 72 ~ .context("could not parse subtitles") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/srt.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | / Ok(SubtitleFile::from_str(&data) [INFO] [stdout] 85 | | .with_context(|| format!("could not parse {}", path.display()))?) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 84 ~ SubtitleFile::from_str(&data) [INFO] [stdout] 85 ~ .with_context(|| format!("could not parse {}", path.display())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/srt.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | Ok(clean_subtitle_file(&raw)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 91 - Ok(clean_subtitle_file(&raw)?) [INFO] [stdout] 91 + clean_subtitle_file(&raw) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `srt::SubtitleFile` [INFO] [stdout] --> src/srt.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | / pub fn to_string(&self) -> String { [INFO] [stdout] 96 | | let subs: Vec = self.subtitles.iter().map(|s| s.to_string()).collect(); [INFO] [stdout] ... | [INFO] [stdout] 102 | | format!("\u{FEFF}{}", subs.join("\n")) [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `srt::SubtitleFile` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/srt.rs:131:43 [INFO] [stdout] | [INFO] [stdout] 131 | let srt = SubtitleFile::from_path(&path).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/srt.rs:195:46 [INFO] [stdout] | [INFO] [stdout] 195 | let srt_es = SubtitleFile::from_path(&path_es).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `path_es` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/srt.rs:199:46 [INFO] [stdout] | [INFO] [stdout] 199 | let srt_en = SubtitleFile::from_path(&path_en).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `path_en` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/video.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | / match self { [INFO] [stdout] 179 | | &ExtractionSpec::Image(time) => time, [INFO] [stdout] 180 | | &ExtractionSpec::Audio(_, period, _) => period.begin(), [INFO] [stdout] 181 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 178 ~ match *self { [INFO] [stdout] 179 ~ ExtractionSpec::Image(time) => time, [INFO] [stdout] 180 ~ ExtractionSpec::Audio(_, period, _) => period.begin(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/video.rs:200:9 [INFO] [stdout] | [INFO] [stdout] 200 | / match self { [INFO] [stdout] 201 | | &ExtractionSpec::Image(time) => { [INFO] [stdout] 202 | | let scale_filter = [INFO] [stdout] 203 | | format!("scale=iw*min(1\\,min({}/iw\\,{}/ih)):-1", 240, 160); [INFO] [stdout] ... | [INFO] [stdout] 223 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 200 ~ match *self { [INFO] [stdout] 201 ~ ExtractionSpec::Image(time) => { [INFO] [stdout] 202 | let scale_filter = [INFO] [stdout] ... [INFO] [stdout] 212 | } [INFO] [stdout] 213 ~ ExtractionSpec::Audio(stream, period, ref metadata) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/clean.rs:14:31 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn strip_formatting(line: &str) -> Cow { [INFO] [stdout] | ^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 14 | pub fn strip_formatting(line: &str) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/contexts.rs:125:25 [INFO] [stdout] | [INFO] [stdout] 125 | fn items_in_context(&self) -> ItemsInContext; [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 125 | fn items_in_context(&self) -> ItemsInContext<'_, Self::Item>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/contexts.rs:131:25 [INFO] [stdout] | [INFO] [stdout] 131 | fn items_in_context(&self) -> ItemsInContext { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 131 | fn items_in_context(&self) -> ItemsInContext<'_, Self::Item> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/contexts.rs:144:25 [INFO] [stdout] | [INFO] [stdout] 144 | fn items_in_context(&self) -> ItemsInContext { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 144 | fn items_in_context(&self) -> ItemsInContext<'_, Self::Item> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/segment.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 43 | fn new(word: &str) -> WordInfo { [INFO] [stdout] | ^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 43 | fn new(word: &str) -> WordInfo<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/video.rs:86:21 [INFO] [stdout] | [INFO] [stdout] 86 | pub struct Fraction(Ratio); [INFO] [stdout] | -------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `Fraction` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/align.rs:89:8 [INFO] [stdout] | [INFO] [stdout] 89 | if !(i < items.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(i >= items.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/align.rs:189:15 [INFO] [stdout] | [INFO] [stdout] 189 | .map(|&(ref indices1, ref indices2)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 189 - .map(|&(ref indices1, ref indices2)| { [INFO] [stdout] 189 + .map(|(indices1, indices2)| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/align.rs:190:27 [INFO] [stdout] | [INFO] [stdout] 190 | (merge(file1, &indices1), merge(file2, &indices2)) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `indices1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/align.rs:190:52 [INFO] [stdout] | [INFO] [stdout] 190 | (merge(file1, &indices1), merge(file2, &indices2)) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `indices2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern creates a reference to a reference [INFO] [stdout] --> src/align.rs:202:14 [INFO] [stdout] | [INFO] [stdout] 202 | Some(ref file2) => align_files(file1, file2), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 202 - Some(ref file2) => align_files(file1, file2), [INFO] [stdout] 202 + Some(file2) => align_files(file1, file2), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/align.rs:220:44 [INFO] [stdout] | [INFO] [stdout] 220 | let cleaned = strip_formatting(&l); [INFO] [stdout] | ^^ help: change this to: `l` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/align.rs:240:21 [INFO] [stdout] | [INFO] [stdout] 240 | .map(|pair| match pair { [INFO] [stdout] | _____________________^ [INFO] [stdout] 241 | | &(None, None) => panic!("Shouldn't have empty alignment pair!"), [INFO] [stdout] 242 | | &(Some(ref sub), None) => clone_as(sub, STYLE1B, STYLE1E), [INFO] [stdout] 243 | | &(None, Some(ref sub)) => clone_as(sub, STYLE2B, STYLE2E), [INFO] [stdout] ... | [INFO] [stdout] 252 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 240 ~ .map(|pair| match *pair { [INFO] [stdout] 241 ~ (None, None) => panic!("Shouldn't have empty alignment pair!"), [INFO] [stdout] 242 ~ (Some(ref sub), None) => clone_as(sub, STYLE1B, STYLE1E), [INFO] [stdout] 243 ~ (None, Some(ref sub)) => clone_as(sub, STYLE2B, STYLE2E), [INFO] [stdout] 244 ~ (Some(ref sub1), Some(ref sub2)) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/clean.rs:16:28 [INFO] [stdout] | [INFO] [stdout] 16 | formatting.replace_all(&line, "") [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/clean.rs:42:29 [INFO] [stdout] | [INFO] [stdout] 42 | .map(|l| clean_line(&l)) [INFO] [stdout] | ^^ help: change this to: `l` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/clean.rs:43:21 [INFO] [stdout] | [INFO] [stdout] 43 | .filter(|l| l.len() > 0) [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!l.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/clean.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 46 | if lines.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lines.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/contexts.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 49 | curr: f(&self.curr), [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.curr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/contexts.rs:55:6 [INFO] [stdout] | [INFO] [stdout] 55 | impl<'a, T: Clone> Context<&'a T> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 55 - impl<'a, T: Clone> Context<&'a T> { [INFO] [stdout] 55 + impl Context<&T> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/contexts.rs:128:6 [INFO] [stdout] | [INFO] [stdout] 128 | impl<'a, T> ItemsInContextExt for &'a [T] { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 128 - impl<'a, T> ItemsInContextExt for &'a [T] { [INFO] [stdout] 128 + impl ItemsInContextExt for &[T] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/contexts.rs:146:20 [INFO] [stdout] | [INFO] [stdout] 146 | slice: &self, [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/export/csv.rs:67:23 [INFO] [stdout] | [INFO] [stdout] 67 | .filter(|&&(ref f, _)| f.is_some()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 67 - .filter(|&&(ref f, _)| f.is_some()) [INFO] [stdout] 67 + .filter(|&(f, _)| f.is_some()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/export/csv.rs:78:36 [INFO] [stdout] | [INFO] [stdout] 78 | let foreign = ctx.map(|&(ref f, _)| f).flatten(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 78 - let foreign = ctx.map(|&(ref f, _)| f).flatten(); [INFO] [stdout] 78 + let foreign = ctx.map(|(f, _)| f).flatten(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/export/csv.rs:79:35 [INFO] [stdout] | [INFO] [stdout] 79 | let native = ctx.map(|&(_, ref n)| n).flatten(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 79 - let native = ctx.map(|&(_, ref n)| n).flatten(); [INFO] [stdout] 79 + let native = ctx.map(|(_, n)| n).flatten(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/export/exporter.rs:84:43 [INFO] [stdout] | [INFO] [stdout] 84 | let native = native_subtitles.map(|subs| LanguageResources::new(subs)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `LanguageResources::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/export/review.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | let (i, &(ref foreign, ref native)) = sub; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 41 - let (i, &(ref foreign, ref native)) = sub; [INFO] [stdout] 41 + let (i, (foreign, native)) = sub; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/export/review.rs:69:51 [INFO] [stdout] | [INFO] [stdout] 69 | handlebars.register_template_string("review", template.to_owned())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `template` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/export/tracks.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | result.push_str("…"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('…')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/export/tracks.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | prev.text.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `prev.text.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/import/whisper.rs:113:43 [INFO] [stdout] | [INFO] [stdout] 113 | let normalized = NON_WORD.replace_all(&text, "").to_string(); [INFO] [stdout] | ^^^^^ help: change this to: `text` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/import/whisper.rs:189:36 [INFO] [stdout] | [INFO] [stdout] 189 | segment_indices.extend(repeat(segment_idx).take(diff_words.len())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(segment_idx, diff_words.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/import/whisper.rs:314:25 [INFO] [stdout] | [INFO] [stdout] 314 | .filter_map(|word| normalize_word_text_for_diff(word)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `normalize_word_text_for_diff` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/import/whisper.rs:313:20 [INFO] [stdout] | [INFO] [stdout] 313 | .split(&segment) [INFO] [stdout] | ^^^^^^^^ help: change this to: `segment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/import/whisper.rs:490:14 [INFO] [stdout] | [INFO] [stdout] 490 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/merge.rs:18:37 [INFO] [stdout] | [INFO] [stdout] 18 | for word in space.split(&line) { [INFO] [stdout] | ^^^^^ help: change this to: `line` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/merge.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | if line.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/merge.rs:29:27 [INFO] [stdout] | [INFO] [stdout] 29 | line.push_str(&word); [INFO] [stdout] | ^^^^^ help: change this to: `word` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/merge.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | line.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `line.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/merge.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 32 | line.push_str(&word); [INFO] [stdout] | ^^^^^ help: change this to: `word` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/merge.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 43 | if line.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/segment.rs:144:23 [INFO] [stdout] | [INFO] [stdout] 144 | let end_idx = bp.index as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `bp.index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/services/oai/translate.rs:92:8 [INFO] [stdout] | [INFO] [stdout] 92 | if current_chunk.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!current_chunk.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `resp.choices.get(0)` [INFO] [stdout] --> src/services/oai/mod.rs:112:18 [INFO] [stdout] | [INFO] [stdout] 112 | let choice = resp.choices.get(0).ok_or_else(|| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `resp.choices.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `tool_calls.get(0)` [INFO] [stdout] --> src/services/oai/mod.rs:119:21 [INFO] [stdout] | [INFO] [stdout] 119 | let tool_call = tool_calls [INFO] [stdout] | _____________________^ [INFO] [stdout] 120 | | .get(0) [INFO] [stdout] | |_______________^ help: try: `tool_calls.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `srt::Subtitle` [INFO] [stdout] --> src/srt.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | / pub fn to_string(&self) -> String { [INFO] [stdout] 42 | | format!( [INFO] [stdout] 43 | | "{}\n{} --> {}\n{}\n", [INFO] [stdout] 44 | | self.index, [INFO] [stdout] ... | [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `srt::Subtitle` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/srt.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | / pub fn from_str(data: &str) -> Result { [INFO] [stdout] ... | [INFO] [stdout] 72 | | .context("could not parse subtitles")?) [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/srt.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | / Ok(grammar::subtitle_file(data.trim_start_matches("\u{FEFF}")) [INFO] [stdout] 72 | | .context("could not parse subtitles")?) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 71 ~ grammar::subtitle_file(data.trim_start_matches("\u{FEFF}")) [INFO] [stdout] 72 ~ .context("could not parse subtitles") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/srt.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | / Ok(SubtitleFile::from_str(&data) [INFO] [stdout] 85 | | .with_context(|| format!("could not parse {}", path.display()))?) [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 84 ~ SubtitleFile::from_str(&data) [INFO] [stdout] 85 ~ .with_context(|| format!("could not parse {}", path.display())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/srt.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | Ok(clean_subtitle_file(&raw)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 91 - Ok(clean_subtitle_file(&raw)?) [INFO] [stdout] 91 + clean_subtitle_file(&raw) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `srt::SubtitleFile` [INFO] [stdout] --> src/srt.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 95 | / pub fn to_string(&self) -> String { [INFO] [stdout] 96 | | let subs: Vec = self.subtitles.iter().map(|s| s.to_string()).collect(); [INFO] [stdout] ... | [INFO] [stdout] 102 | | format!("\u{FEFF}{}", subs.join("\n")) [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `srt::SubtitleFile` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/video.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | / match self { [INFO] [stdout] 179 | | &ExtractionSpec::Image(time) => time, [INFO] [stdout] 180 | | &ExtractionSpec::Audio(_, period, _) => period.begin(), [INFO] [stdout] 181 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 178 ~ match *self { [INFO] [stdout] 179 ~ ExtractionSpec::Image(time) => time, [INFO] [stdout] 180 ~ ExtractionSpec::Audio(_, period, _) => period.begin(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/video.rs:200:9 [INFO] [stdout] | [INFO] [stdout] 200 | / match self { [INFO] [stdout] 201 | | &ExtractionSpec::Image(time) => { [INFO] [stdout] 202 | | let scale_filter = [INFO] [stdout] 203 | | format!("scale=iw*min(1\\,min({}/iw\\,{}/ih)):-1", 240, 160); [INFO] [stdout] ... | [INFO] [stdout] 223 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 200 ~ match *self { [INFO] [stdout] 201 ~ ExtractionSpec::Image(time) => { [INFO] [stdout] 202 | let scale_filter = [INFO] [stdout] ... [INFO] [stdout] 212 | } [INFO] [stdout] 213 ~ ExtractionSpec::Audio(stream, period, ref metadata) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/clean.rs:14:31 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn strip_formatting(line: &str) -> Cow { [INFO] [stdout] | ^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 14 | pub fn strip_formatting(line: &str) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/contexts.rs:125:25 [INFO] [stdout] | [INFO] [stdout] 125 | fn items_in_context(&self) -> ItemsInContext; [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 125 | fn items_in_context(&self) -> ItemsInContext<'_, Self::Item>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/contexts.rs:131:25 [INFO] [stdout] | [INFO] [stdout] 131 | fn items_in_context(&self) -> ItemsInContext { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 131 | fn items_in_context(&self) -> ItemsInContext<'_, Self::Item> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/contexts.rs:144:25 [INFO] [stdout] | [INFO] [stdout] 144 | fn items_in_context(&self) -> ItemsInContext { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 144 | fn items_in_context(&self) -> ItemsInContext<'_, Self::Item> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/segment.rs:43:18 [INFO] [stdout] | [INFO] [stdout] 43 | fn new(word: &str) -> WordInfo { [INFO] [stdout] | ^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 43 | fn new(word: &str) -> WordInfo<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/tests.rs:68:15 [INFO] [stdout] | [INFO] [stdout] 68 | .args(&["export", "csv"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `["export", "csv"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/tests.rs:85:15 [INFO] [stdout] | [INFO] [stdout] 85 | .args(&["export", "review"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["export", "review"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/tests.rs:102:15 [INFO] [stdout] | [INFO] [stdout] 102 | .args(&["export", "tracks"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["export", "tracks"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/tests.rs:117:15 [INFO] [stdout] | [INFO] [stdout] 117 | .args(&["list", "tracks"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `["list", "tracks"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/substudy.rs:122:52 [INFO] [stdout] | [INFO] [stdout] 122 | ExportFormat::Csv { ref video, .. } => &video, [INFO] [stdout] | ^^^^^^ help: change this to: `video` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/substudy.rs:123:55 [INFO] [stdout] | [INFO] [stdout] 123 | ExportFormat::Review { ref video, .. } => &video, [INFO] [stdout] | ^^^^^^ help: change this to: `video` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/substudy.rs:124:55 [INFO] [stdout] | [INFO] [stdout] 124 | ExportFormat::Tracks { ref video, .. } => &video, [INFO] [stdout] | ^^^^^^ help: change this to: `video` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/substudy.rs:133:18 [INFO] [stdout] | [INFO] [stdout] 133 | } => &foreign_subs, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `foreign_subs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/substudy.rs:136:18 [INFO] [stdout] | [INFO] [stdout] 136 | } => &foreign_subs, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `foreign_subs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/substudy.rs:139:18 [INFO] [stdout] | [INFO] [stdout] 139 | } => &foreign_subs, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `foreign_subs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/substudy.rs:122:52 [INFO] [stdout] | [INFO] [stdout] 122 | ExportFormat::Csv { ref video, .. } => &video, [INFO] [stdout] | ^^^^^^ help: change this to: `video` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/substudy.rs:123:55 [INFO] [stdout] | [INFO] [stdout] 123 | ExportFormat::Review { ref video, .. } => &video, [INFO] [stdout] | ^^^^^^ help: change this to: `video` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/substudy.rs:124:55 [INFO] [stdout] | [INFO] [stdout] 124 | ExportFormat::Tracks { ref video, .. } => &video, [INFO] [stdout] | ^^^^^^ help: change this to: `video` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/substudy.rs:133:18 [INFO] [stdout] | [INFO] [stdout] 133 | } => &foreign_subs, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `foreign_subs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/substudy.rs:136:18 [INFO] [stdout] | [INFO] [stdout] 136 | } => &foreign_subs, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `foreign_subs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/substudy.rs:139:18 [INFO] [stdout] | [INFO] [stdout] 139 | } => &foreign_subs, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `foreign_subs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 34.48s [INFO] running `Command { std: "docker" "inspect" "bb804784192d15a03fc2eda8d29e1c01497532efa4154549296b7daad736504f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb804784192d15a03fc2eda8d29e1c01497532efa4154549296b7daad736504f", kill_on_drop: false }` [INFO] [stdout] bb804784192d15a03fc2eda8d29e1c01497532efa4154549296b7daad736504f