[INFO] fetching crate structre_proc_macros 0.2.0... [INFO] linting structre_proc_macros-0.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate structre_proc_macros 0.2.0 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate structre_proc_macros 0.2.0 [INFO] finished tweaking crates.io crate structre_proc_macros 0.2.0 [INFO] tweaked toml for crates.io crate structre_proc_macros 0.2.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate structre_proc_macros 0.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 96 packages to latest compatible versions [INFO] [stderr] Adding genemichaels-lib v0.5.11 (available: v0.8.5) [INFO] [stderr] Adding litrs v0.4.2 (available: v1.0.0) [INFO] [stderr] Adding markdown v1.0.0-alpha.21 (available: v1.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded loga v0.5.4 [INFO] [stderr] Downloaded genemichaels-lib v0.5.11 [INFO] [stderr] Downloaded cargo-manifest v0.15.2 [INFO] [stderr] Downloaded flowcontrol v0.2.3 [INFO] [stderr] Downloaded markdown v1.0.0-alpha.21 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2f06de9435f84b89219f5831327791c9ae10dd47a9beb4dd9309b1c7e58aad51 [INFO] running `Command { std: "docker" "start" "-a" "2f06de9435f84b89219f5831327791c9ae10dd47a9beb4dd9309b1c7e58aad51", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2f06de9435f84b89219f5831327791c9ae10dd47a9beb4dd9309b1c7e58aad51", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f06de9435f84b89219f5831327791c9ae10dd47a9beb4dd9309b1c7e58aad51", kill_on_drop: false }` [INFO] [stdout] 2f06de9435f84b89219f5831327791c9ae10dd47a9beb4dd9309b1c7e58aad51 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8a14a83f90a1c529e23d59346f8971a94d34f9cb99cb618ef9ad387da04570f3 [INFO] running `Command { std: "docker" "start" "-a" "8a14a83f90a1c529e23d59346f8971a94d34f9cb99cb618ef9ad387da04570f3", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Checking equivalent v1.0.2 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking winnow v0.7.15 [INFO] [stderr] Checking unicode-width v0.2.2 [INFO] [stderr] Checking proc-macro2 v1.0.106 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Checking libc v0.2.183 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking num-traits v0.2.19 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking unicode-linebreak v0.1.5 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Checking smawk v0.3.2 [INFO] [stderr] Checking unicode-id v0.3.6 [INFO] [stderr] Checking flowcontrol v0.2.3 [INFO] [stderr] Checking markdown v1.0.0-alpha.21 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking quote v1.0.45 [INFO] [stderr] Checking litrs v0.4.2 [INFO] [stderr] Checking terminal_size v0.4.3 [INFO] [stderr] Checking textwrap v0.16.2 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking loga v0.5.4 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking structre_proc_macros v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> mod.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | typetype: typetype, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `typetype` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | / return SimpleSimpleType { [INFO] [stdout] 202 | | span: ty.span(), [INFO] [stdout] 203 | | type_: ty_tokens, [INFO] [stdout] 204 | | typetype: typetype, [INFO] [stdout] 205 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 201 ~ SimpleSimpleType { [INFO] [stdout] 202 + span: ty.span(), [INFO] [stdout] 203 + type_: ty_tokens, [INFO] [stdout] 204 + typetype: typetype, [INFO] [stdout] 205 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> mod.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | let typetype; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `typetype` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 117 ~ [INFO] [stdout] 118 ~ let typetype = match ty_tokens.to_string().as_str() { [INFO] [stdout] 119 | "u8" | [INFO] [stdout] ... [INFO] [stdout] 194 | "NonZero" => { [INFO] [stdout] 195 ~ SimpleSimpleTypeType::FromStr [INFO] [stdout] 196 | }, [INFO] [stdout] 197 | _ => { [INFO] [stdout] 198 ~ SimpleSimpleTypeType::TryFrom [INFO] [stdout] 199 | }, [INFO] [stdout] 200 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:256:5 [INFO] [stdout] | [INFO] [stdout] 256 | return Err(syn::Error::new(ty.span(), "This type does not support parsing from regex")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 256 - return Err(syn::Error::new(ty.span(), "This type does not support parsing from regex")); [INFO] [stdout] 256 + Err(syn::Error::new(ty.span(), "This type does not support parsing from regex")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> mod.rs:239:20 [INFO] [stdout] | [INFO] [stdout] 239 | return Ok(simple_type(&t.elem)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 239 - return Ok(simple_type(&t.elem)?); [INFO] [stdout] 239 + return simple_type(&t.elem); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> mod.rs:242:20 [INFO] [stdout] | [INFO] [stdout] 242 | return Ok(simple_type(&t.elem)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 242 - return Ok(simple_type(&t.elem)?); [INFO] [stdout] 242 + return simple_type(&t.elem); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:263:13 [INFO] [stdout] | [INFO] [stdout] 263 | / return quote!( [INFO] [stdout] 264 | | < #p as std:: convert:: TryFrom <& #str_lifetime str >>:: try_from( [INFO] [stdout] 265 | | #cap [INFO] [stdout] 266 | | ).map_err(| e | structre:: Error:: Field { [INFO] [stdout] ... | [INFO] [stdout] 269 | | }) ? [INFO] [stdout] 270 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 ~ quote!( [INFO] [stdout] 264 + < #p as std:: convert:: TryFrom <& #str_lifetime str >>:: try_from( [INFO] [stdout] 265 + #cap [INFO] [stdout] 266 + ).map_err(| e | structre:: Error:: Field { [INFO] [stdout] 267 + field: #path, [INFO] [stdout] 268 + error: e.to_string() [INFO] [stdout] 269 + }) ? [INFO] [stdout] 270 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:273:13 [INFO] [stdout] | [INFO] [stdout] 273 | / return quote!(< #p as std:: str:: FromStr >:: from_str(#cap).map_err(| e | structre:: Error:: Field { [INFO] [stdout] 274 | | field: #path, [INFO] [stdout] 275 | | error: e.to_string() [INFO] [stdout] 276 | | }) ?); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 273 ~ quote!(< #p as std:: str:: FromStr >:: from_str(#cap).map_err(| e | structre:: Error:: Field { [INFO] [stdout] 274 + field: #path, [INFO] [stdout] 275 + error: e.to_string() [INFO] [stdout] 276 ~ }) ?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:344:5 [INFO] [stdout] | [INFO] [stdout] 344 | return Ok(quote!(#(#field_tokens,) *)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 344 - return Ok(quote!(#(#field_tokens,) *)); [INFO] [stdout] 344 + Ok(quote!(#(#field_tokens,) *)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> mod.rs:319:38 [INFO] [stdout] | [INFO] [stdout] 319 | &mut p.iter().map(|x| x).cloned(), [INFO] [stdout] | ^^^^^^^^^^^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:399:5 [INFO] [stdout] | [INFO] [stdout] 399 | return Ok(quote!(#(#out,) *)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 399 - return Ok(quote!(#(#out,) *)); [INFO] [stdout] 399 + Ok(quote!(#(#out,) *)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:458:5 [INFO] [stdout] | [INFO] [stdout] 458 | return Ok(quote!(return Ok(#ident #out);)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 458 - return Ok(quote!(return Ok(#ident #out);)); [INFO] [stdout] 458 + Ok(quote!(return Ok(#ident #out);)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:690:5 [INFO] [stdout] | [INFO] [stdout] 690 | / return Ok(quote!{ [INFO] [stdout] 691 | | #(#code_variants) * unreachable !(); [INFO] [stdout] 692 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 690 ~ Ok(quote!{ [INFO] [stdout] 691 + #(#code_variants) * unreachable !(); [INFO] [stdout] 692 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> mod.rs:468:25 [INFO] [stdout] | [INFO] [stdout] 468 | fn find_re_variants<'a>(re: &'a ReAst) -> Result>, String> { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 468 - fn find_re_variants<'a>(re: &'a ReAst) -> Result>, String> { [INFO] [stdout] 468 + fn find_re_variants(re: &ReAst) -> Result>, String> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:472:21 [INFO] [stdout] | [INFO] [stdout] 472 | return Err(format!("Reptition with regex alternates isn't supported: `{}`", re)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 472 - return Err(format!("Reptition with regex alternates isn't supported: `{}`", re)); [INFO] [stdout] 472 + Err(format!("Reptition with regex alternates isn't supported: `{}`", re)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:474:21 [INFO] [stdout] | [INFO] [stdout] 474 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 474 - return Ok(None); [INFO] [stdout] 474 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:480:25 [INFO] [stdout] | [INFO] [stdout] 480 | / ... return Err( [INFO] [stdout] 481 | | ... format!( [INFO] [stdout] 482 | | ... "All capturing groups must occur within alternates in an enum, but found a capturing group above an enum: `{}`", [INFO] [stdout] 483 | | ... re [INFO] [stdout] 484 | | ... ), [INFO] [stdout] 485 | | ... ); [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 480 ~ Err( [INFO] [stdout] 481 + format!( [INFO] [stdout] 482 + "All capturing groups must occur within alternates in an enum, but found a capturing group above an enum: `{}`", [INFO] [stdout] 483 + re [INFO] [stdout] 484 + ), [INFO] [stdout] 485 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:488:25 [INFO] [stdout] | [INFO] [stdout] 488 | return find_re_variants(&x.ast); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 488 - return find_re_variants(&x.ast); [INFO] [stdout] 488 + find_re_variants(&x.ast) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:508:17 [INFO] [stdout] | [INFO] [stdout] 508 | return Ok(found); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 508 - return Ok(found); [INFO] [stdout] 508 + Ok(found) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:511:17 [INFO] [stdout] | [INFO] [stdout] 511 | return Ok(Some(&x.asts)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 511 - return Ok(Some(&x.asts)); [INFO] [stdout] 511 + Ok(Some(&x.asts)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:513:32 [INFO] [stdout] | [INFO] [stdout] 513 | ReAst::Empty(_) => return Ok(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 513 - ReAst::Empty(_) => return Ok(None), [INFO] [stdout] 513 + ReAst::Empty(_) => Ok(None), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:514:32 [INFO] [stdout] | [INFO] [stdout] 514 | ReAst::Flags(_) => return Ok(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 514 - ReAst::Flags(_) => return Ok(None), [INFO] [stdout] 514 + ReAst::Flags(_) => Ok(None), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:515:34 [INFO] [stdout] | [INFO] [stdout] 515 | ReAst::Literal(_) => return Ok(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 515 - ReAst::Literal(_) => return Ok(None), [INFO] [stdout] 515 + ReAst::Literal(_) => Ok(None), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:516:30 [INFO] [stdout] | [INFO] [stdout] 516 | ReAst::Dot(_) => return Ok(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 516 - ReAst::Dot(_) => return Ok(None), [INFO] [stdout] 516 + ReAst::Dot(_) => Ok(None), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:517:36 [INFO] [stdout] | [INFO] [stdout] 517 | ReAst::Assertion(_) => return Ok(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 517 - ReAst::Assertion(_) => return Ok(None), [INFO] [stdout] 517 + ReAst::Assertion(_) => Ok(None), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: sub-expression diverges [INFO] [stdout] --> mod.rs:575:25 [INFO] [stdout] | [INFO] [stdout] 575 | / superif!({ [INFO] [stdout] 576 | | for f in &fields.named { [INFO] [stdout] 577 | | if f.ident.as_ref().unwrap().to_string() == key && [INFO] [stdout] ... | [INFO] [stdout] 595 | | break 'matched_enum_variant; [INFO] [stdout] 596 | | }); [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stdout] = note: `#[warn(clippy::diverging_sub_expression)]` on by default [INFO] [stdout] = note: this warning originates in the macro `$crate::superif` which comes from the expansion of the macro `superif` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> mod.rs:577:36 [INFO] [stdout] | [INFO] [stdout] 577 | ... if f.ident.as_ref().unwrap().to_string() == key && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*f.ident.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: sub-expression diverges [INFO] [stdout] --> mod.rs:599:25 [INFO] [stdout] | [INFO] [stdout] 599 | / superif!({ [INFO] [stdout] 600 | | if fields.unnamed.len() == 1 { [INFO] [stdout] 601 | | let root = simple_type(&fields.unnamed.get(0).unwrap().ty)?; [INFO] [stdout] 602 | | let mut at = &root; [INFO] [stdout] ... | [INFO] [stdout] 646 | | break 'matched_enum_variant; [INFO] [stdout] 647 | | }); [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stdout] = note: this warning originates in the macro `$crate::superif` which comes from the expansion of the macro `superif` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `t.get(0)` [INFO] [stdout] --> mod.rs:608:54 [INFO] [stdout] | [INFO] [stdout] 608 | ... at = t.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: try: `t.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> mod.rs:614:55 [INFO] [stdout] | [INFO] [stdout] 614 | ... if key == variant_ident.to_string() { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: try: `*variant_ident == key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> mod.rs:695:33 [INFO] [stdout] | [INFO] [stdout] 695 | fn parse_re(regex_raw: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `regex_syntax::ast::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:696:5 [INFO] [stdout] | [INFO] [stdout] 696 | return regex_syntax::ast::parse::Parser::new().parse(regex_raw); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 696 - return regex_syntax::ast::parse::Parser::new().parse(regex_raw); [INFO] [stdout] 696 + regex_syntax::ast::parse::Parser::new().parse(regex_raw) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> mod.rs:711:12 [INFO] [stdout] | [INFO] [stdout] 711 | if !ast.generics.lt_token.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ast.generics.lt_token.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:761:5 [INFO] [stdout] | [INFO] [stdout] 761 | return Ok(TokenStream::from_iter(out)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 761 - return Ok(TokenStream::from_iter(out)); [INFO] [stdout] 761 + Ok(TokenStream::from_iter(out)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> mod.rs:701:5 [INFO] [stdout] | [INFO] [stdout] 701 | let type_generics; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `type_generics` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 701 ~ [INFO] [stdout] 702 ~ let type_generics = if ast.generics.lt_token.is_some() { [INFO] [stdout] 703 ~ ast.generics.to_token_stream() [INFO] [stdout] 704 | } else { [INFO] [stdout] 705 ~ quote!() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: sub-expression diverges [INFO] [stdout] --> mod.rs:710:5 [INFO] [stdout] | [INFO] [stdout] 710 | / superif!({ [INFO] [stdout] 711 | | if !ast.generics.lt_token.is_some() { [INFO] [stdout] 712 | | break 'no_lifetime; [INFO] [stdout] 713 | | }; [INFO] [stdout] ... | [INFO] [stdout] 723 | | impl_generics = quote!(< #str_lifetime >); [INFO] [stdout] 724 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stdout] = note: this warning originates in the macro `$crate::superif` which comes from the expansion of the macro `superif` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> mod.rs:725:5 [INFO] [stdout] | [INFO] [stdout] 725 | let root; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `root` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 725 ~ [INFO] [stdout] 726 ~ let root = match &ast.data { [INFO] [stdout] 727 | syn::Data::Struct(d) => { [INFO] [stdout] 728 ~ gen_struct(&str_lifetime, &re, &ast.ident, d)? [INFO] [stdout] 729 | }, [INFO] [stdout] 730 | syn::Data::Enum(d) => { [INFO] [stdout] 731 ~ gen_enum(&str_lifetime, &re, &ast.ident, d)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:788:13 [INFO] [stdout] | [INFO] [stdout] 788 | return t.into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 788 - return t.into(); [INFO] [stdout] 788 + t.into() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:791:13 [INFO] [stdout] | [INFO] [stdout] 791 | return e.into_compile_error().into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 791 - return e.into_compile_error().into(); [INFO] [stdout] 791 + e.into_compile_error().into() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:785:9 [INFO] [stdout] | [INFO] [stdout] 785 | return Ok(gen_root(regex_span, ®ex_raw, ast)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 785 - return Ok(gen_root(regex_span, ®ex_raw, ast)?); [INFO] [stdout] 785 + Ok(gen_root(regex_span, ®ex_raw, ast)?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> mod.rs:785:16 [INFO] [stdout] | [INFO] [stdout] 785 | return Ok(gen_root(regex_span, ®ex_raw, ast)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 785 - return Ok(gen_root(regex_span, ®ex_raw, ast)?); [INFO] [stdout] 785 + return gen_root(regex_span, ®ex_raw, ast); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling derive_more v0.99.20 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking cargo-manifest v0.15.2 [INFO] [stderr] Checking genemichaels-lib v0.5.11 [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> mod.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | typetype: typetype, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `typetype` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | / return SimpleSimpleType { [INFO] [stdout] 202 | | span: ty.span(), [INFO] [stdout] 203 | | type_: ty_tokens, [INFO] [stdout] 204 | | typetype: typetype, [INFO] [stdout] 205 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 201 ~ SimpleSimpleType { [INFO] [stdout] 202 + span: ty.span(), [INFO] [stdout] 203 + type_: ty_tokens, [INFO] [stdout] 204 + typetype: typetype, [INFO] [stdout] 205 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> mod.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | let typetype; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `typetype` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 117 ~ [INFO] [stdout] 118 ~ let typetype = match ty_tokens.to_string().as_str() { [INFO] [stdout] 119 | "u8" | [INFO] [stdout] ... [INFO] [stdout] 194 | "NonZero" => { [INFO] [stdout] 195 ~ SimpleSimpleTypeType::FromStr [INFO] [stdout] 196 | }, [INFO] [stdout] 197 | _ => { [INFO] [stdout] 198 ~ SimpleSimpleTypeType::TryFrom [INFO] [stdout] 199 | }, [INFO] [stdout] 200 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:256:5 [INFO] [stdout] | [INFO] [stdout] 256 | return Err(syn::Error::new(ty.span(), "This type does not support parsing from regex")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 256 - return Err(syn::Error::new(ty.span(), "This type does not support parsing from regex")); [INFO] [stdout] 256 + Err(syn::Error::new(ty.span(), "This type does not support parsing from regex")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> mod.rs:239:20 [INFO] [stdout] | [INFO] [stdout] 239 | return Ok(simple_type(&t.elem)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 239 - return Ok(simple_type(&t.elem)?); [INFO] [stdout] 239 + return simple_type(&t.elem); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> mod.rs:242:20 [INFO] [stdout] | [INFO] [stdout] 242 | return Ok(simple_type(&t.elem)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 242 - return Ok(simple_type(&t.elem)?); [INFO] [stdout] 242 + return simple_type(&t.elem); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:263:13 [INFO] [stdout] | [INFO] [stdout] 263 | / return quote!( [INFO] [stdout] 264 | | < #p as std:: convert:: TryFrom <& #str_lifetime str >>:: try_from( [INFO] [stdout] 265 | | #cap [INFO] [stdout] 266 | | ).map_err(| e | structre:: Error:: Field { [INFO] [stdout] ... | [INFO] [stdout] 269 | | }) ? [INFO] [stdout] 270 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 ~ quote!( [INFO] [stdout] 264 + < #p as std:: convert:: TryFrom <& #str_lifetime str >>:: try_from( [INFO] [stdout] 265 + #cap [INFO] [stdout] 266 + ).map_err(| e | structre:: Error:: Field { [INFO] [stdout] 267 + field: #path, [INFO] [stdout] 268 + error: e.to_string() [INFO] [stdout] 269 + }) ? [INFO] [stdout] 270 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:273:13 [INFO] [stdout] | [INFO] [stdout] 273 | / return quote!(< #p as std:: str:: FromStr >:: from_str(#cap).map_err(| e | structre:: Error:: Field { [INFO] [stdout] 274 | | field: #path, [INFO] [stdout] 275 | | error: e.to_string() [INFO] [stdout] 276 | | }) ?); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 273 ~ quote!(< #p as std:: str:: FromStr >:: from_str(#cap).map_err(| e | structre:: Error:: Field { [INFO] [stdout] 274 + field: #path, [INFO] [stdout] 275 + error: e.to_string() [INFO] [stdout] 276 ~ }) ?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:344:5 [INFO] [stdout] | [INFO] [stdout] 344 | return Ok(quote!(#(#field_tokens,) *)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 344 - return Ok(quote!(#(#field_tokens,) *)); [INFO] [stdout] 344 + Ok(quote!(#(#field_tokens,) *)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> mod.rs:319:38 [INFO] [stdout] | [INFO] [stdout] 319 | &mut p.iter().map(|x| x).cloned(), [INFO] [stdout] | ^^^^^^^^^^^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:399:5 [INFO] [stdout] | [INFO] [stdout] 399 | return Ok(quote!(#(#out,) *)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 399 - return Ok(quote!(#(#out,) *)); [INFO] [stdout] 399 + Ok(quote!(#(#out,) *)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:458:5 [INFO] [stdout] | [INFO] [stdout] 458 | return Ok(quote!(return Ok(#ident #out);)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 458 - return Ok(quote!(return Ok(#ident #out);)); [INFO] [stdout] 458 + Ok(quote!(return Ok(#ident #out);)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:690:5 [INFO] [stdout] | [INFO] [stdout] 690 | / return Ok(quote!{ [INFO] [stdout] 691 | | #(#code_variants) * unreachable !(); [INFO] [stdout] 692 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 690 ~ Ok(quote!{ [INFO] [stdout] 691 + #(#code_variants) * unreachable !(); [INFO] [stdout] 692 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> mod.rs:468:25 [INFO] [stdout] | [INFO] [stdout] 468 | fn find_re_variants<'a>(re: &'a ReAst) -> Result>, String> { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 468 - fn find_re_variants<'a>(re: &'a ReAst) -> Result>, String> { [INFO] [stdout] 468 + fn find_re_variants(re: &ReAst) -> Result>, String> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:472:21 [INFO] [stdout] | [INFO] [stdout] 472 | return Err(format!("Reptition with regex alternates isn't supported: `{}`", re)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 472 - return Err(format!("Reptition with regex alternates isn't supported: `{}`", re)); [INFO] [stdout] 472 + Err(format!("Reptition with regex alternates isn't supported: `{}`", re)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:474:21 [INFO] [stdout] | [INFO] [stdout] 474 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 474 - return Ok(None); [INFO] [stdout] 474 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:480:25 [INFO] [stdout] | [INFO] [stdout] 480 | / ... return Err( [INFO] [stdout] 481 | | ... format!( [INFO] [stdout] 482 | | ... "All capturing groups must occur within alternates in an enum, but found a capturing group above an enum: `{}`", [INFO] [stdout] 483 | | ... re [INFO] [stdout] 484 | | ... ), [INFO] [stdout] 485 | | ... ); [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 480 ~ Err( [INFO] [stdout] 481 + format!( [INFO] [stdout] 482 + "All capturing groups must occur within alternates in an enum, but found a capturing group above an enum: `{}`", [INFO] [stdout] 483 + re [INFO] [stdout] 484 + ), [INFO] [stdout] 485 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:488:25 [INFO] [stdout] | [INFO] [stdout] 488 | return find_re_variants(&x.ast); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 488 - return find_re_variants(&x.ast); [INFO] [stdout] 488 + find_re_variants(&x.ast) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:508:17 [INFO] [stdout] | [INFO] [stdout] 508 | return Ok(found); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 508 - return Ok(found); [INFO] [stdout] 508 + Ok(found) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:511:17 [INFO] [stdout] | [INFO] [stdout] 511 | return Ok(Some(&x.asts)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 511 - return Ok(Some(&x.asts)); [INFO] [stdout] 511 + Ok(Some(&x.asts)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:513:32 [INFO] [stdout] | [INFO] [stdout] 513 | ReAst::Empty(_) => return Ok(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 513 - ReAst::Empty(_) => return Ok(None), [INFO] [stdout] 513 + ReAst::Empty(_) => Ok(None), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:514:32 [INFO] [stdout] | [INFO] [stdout] 514 | ReAst::Flags(_) => return Ok(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 514 - ReAst::Flags(_) => return Ok(None), [INFO] [stdout] 514 + ReAst::Flags(_) => Ok(None), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:515:34 [INFO] [stdout] | [INFO] [stdout] 515 | ReAst::Literal(_) => return Ok(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 515 - ReAst::Literal(_) => return Ok(None), [INFO] [stdout] 515 + ReAst::Literal(_) => Ok(None), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:516:30 [INFO] [stdout] | [INFO] [stdout] 516 | ReAst::Dot(_) => return Ok(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 516 - ReAst::Dot(_) => return Ok(None), [INFO] [stdout] 516 + ReAst::Dot(_) => Ok(None), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:517:36 [INFO] [stdout] | [INFO] [stdout] 517 | ReAst::Assertion(_) => return Ok(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 517 - ReAst::Assertion(_) => return Ok(None), [INFO] [stdout] 517 + ReAst::Assertion(_) => Ok(None), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: sub-expression diverges [INFO] [stdout] --> mod.rs:575:25 [INFO] [stdout] | [INFO] [stdout] 575 | / superif!({ [INFO] [stdout] 576 | | for f in &fields.named { [INFO] [stdout] 577 | | if f.ident.as_ref().unwrap().to_string() == key && [INFO] [stdout] ... | [INFO] [stdout] 595 | | break 'matched_enum_variant; [INFO] [stdout] 596 | | }); [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stdout] = note: `#[warn(clippy::diverging_sub_expression)]` on by default [INFO] [stdout] = note: this warning originates in the macro `$crate::superif` which comes from the expansion of the macro `superif` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> mod.rs:577:36 [INFO] [stdout] | [INFO] [stdout] 577 | ... if f.ident.as_ref().unwrap().to_string() == key && [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*f.ident.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: sub-expression diverges [INFO] [stdout] --> mod.rs:599:25 [INFO] [stdout] | [INFO] [stdout] 599 | / superif!({ [INFO] [stdout] 600 | | if fields.unnamed.len() == 1 { [INFO] [stdout] 601 | | let root = simple_type(&fields.unnamed.get(0).unwrap().ty)?; [INFO] [stdout] 602 | | let mut at = &root; [INFO] [stdout] ... | [INFO] [stdout] 646 | | break 'matched_enum_variant; [INFO] [stdout] 647 | | }); [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stdout] = note: this warning originates in the macro `$crate::superif` which comes from the expansion of the macro `superif` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `t.get(0)` [INFO] [stdout] --> mod.rs:608:54 [INFO] [stdout] | [INFO] [stdout] 608 | ... at = t.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: try: `t.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> mod.rs:614:55 [INFO] [stdout] | [INFO] [stdout] 614 | ... if key == variant_ident.to_string() { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: try: `*variant_ident == key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> mod.rs:695:33 [INFO] [stdout] | [INFO] [stdout] 695 | fn parse_re(regex_raw: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `regex_syntax::ast::Error`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:696:5 [INFO] [stdout] | [INFO] [stdout] 696 | return regex_syntax::ast::parse::Parser::new().parse(regex_raw); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 696 - return regex_syntax::ast::parse::Parser::new().parse(regex_raw); [INFO] [stdout] 696 + regex_syntax::ast::parse::Parser::new().parse(regex_raw) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> mod.rs:711:12 [INFO] [stdout] | [INFO] [stdout] 711 | if !ast.generics.lt_token.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ast.generics.lt_token.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:761:5 [INFO] [stdout] | [INFO] [stdout] 761 | return Ok(TokenStream::from_iter(out)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 761 - return Ok(TokenStream::from_iter(out)); [INFO] [stdout] 761 + Ok(TokenStream::from_iter(out)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> mod.rs:701:5 [INFO] [stdout] | [INFO] [stdout] 701 | let type_generics; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `type_generics` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 701 ~ [INFO] [stdout] 702 ~ let type_generics = if ast.generics.lt_token.is_some() { [INFO] [stdout] 703 ~ ast.generics.to_token_stream() [INFO] [stdout] 704 | } else { [INFO] [stdout] 705 ~ quote!() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: sub-expression diverges [INFO] [stdout] --> mod.rs:710:5 [INFO] [stdout] | [INFO] [stdout] 710 | / superif!({ [INFO] [stdout] 711 | | if !ast.generics.lt_token.is_some() { [INFO] [stdout] 712 | | break 'no_lifetime; [INFO] [stdout] 713 | | }; [INFO] [stdout] ... | [INFO] [stdout] 723 | | impl_generics = quote!(< #str_lifetime >); [INFO] [stdout] 724 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stdout] = note: this warning originates in the macro `$crate::superif` which comes from the expansion of the macro `superif` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> mod.rs:725:5 [INFO] [stdout] | [INFO] [stdout] 725 | let root; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `root` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 725 ~ [INFO] [stdout] 726 ~ let root = match &ast.data { [INFO] [stdout] 727 | syn::Data::Struct(d) => { [INFO] [stdout] 728 ~ gen_struct(&str_lifetime, &re, &ast.ident, d)? [INFO] [stdout] 729 | }, [INFO] [stdout] 730 | syn::Data::Enum(d) => { [INFO] [stdout] 731 ~ gen_enum(&str_lifetime, &re, &ast.ident, d)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:788:13 [INFO] [stdout] | [INFO] [stdout] 788 | return t.into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 788 - return t.into(); [INFO] [stdout] 788 + t.into() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:791:13 [INFO] [stdout] | [INFO] [stdout] 791 | return e.into_compile_error().into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 791 - return e.into_compile_error().into(); [INFO] [stdout] 791 + e.into_compile_error().into() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:785:9 [INFO] [stdout] | [INFO] [stdout] 785 | return Ok(gen_root(regex_span, ®ex_raw, ast)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 785 - return Ok(gen_root(regex_span, ®ex_raw, ast)?); [INFO] [stdout] 785 + Ok(gen_root(regex_span, ®ex_raw, ast)?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> mod.rs:785:16 [INFO] [stdout] | [INFO] [stdout] 785 | return Ok(gen_root(regex_span, ®ex_raw, ast)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 785 - return Ok(gen_root(regex_span, ®ex_raw, ast)?); [INFO] [stdout] 785 + return gen_root(regex_span, ®ex_raw, ast); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:818:26 [INFO] [stdout] | [INFO] [stdout] 818 | Ok(s) => return s.rendered, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 818 - Ok(s) => return s.rendered, [INFO] [stdout] 818 + Ok(s) => s.rendered, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> mod.rs:819:27 [INFO] [stdout] | [INFO] [stdout] 819 | Err(_) => return t.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 819 - Err(_) => return t.to_string(), [INFO] [stdout] 819 + Err(_) => t.to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.73s [INFO] running `Command { std: "docker" "inspect" "8a14a83f90a1c529e23d59346f8971a94d34f9cb99cb618ef9ad387da04570f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a14a83f90a1c529e23d59346f8971a94d34f9cb99cb618ef9ad387da04570f3", kill_on_drop: false }` [INFO] [stdout] 8a14a83f90a1c529e23d59346f8971a94d34f9cb99cb618ef9ad387da04570f3