[INFO] fetching crate stringdex 0.0.6... [INFO] linting stringdex-0.0.6 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate stringdex 0.0.6 into /workspace/builds/worker-6-tc1/source [INFO] removed /workspace/builds/worker-6-tc1/source/rust-toolchain.toml [INFO] started tweaking crates.io crate stringdex 0.0.6 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate stringdex 0.0.6 [INFO] tweaked toml for crates.io crate stringdex 0.0.6 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate stringdex 0.0.6 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate stringdex 0.0.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded winapi-util v0.1.10 [INFO] [stderr] Downloaded clap_builder v4.5.50 [INFO] [stderr] Downloaded serde_json v1.0.143 [INFO] [stderr] Downloaded codspeed-criterion-compat-walltime v4.1.0 [INFO] [stderr] Downloaded clap v4.5.50 [INFO] [stderr] Downloaded cc v1.2.34 [INFO] [stderr] Downloaded codspeed v4.1.0 [INFO] [stderr] Downloaded codspeed-criterion-compat v4.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3b9f1ee3d27c338d718ad0bb59ca954e9bfe7c2fff0e75cea369dda682f680f6 [INFO] running `Command { std: "docker" "start" "-a" "3b9f1ee3d27c338d718ad0bb59ca954e9bfe7c2fff0e75cea369dda682f680f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3b9f1ee3d27c338d718ad0bb59ca954e9bfe7c2fff0e75cea369dda682f680f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b9f1ee3d27c338d718ad0bb59ca954e9bfe7c2fff0e75cea369dda682f680f6", kill_on_drop: false }` [INFO] [stdout] 3b9f1ee3d27c338d718ad0bb59ca954e9bfe7c2fff0e75cea369dda682f680f6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dbf656d8fa74ab6854823bb6d77126882d4317aa46497b70942063dbf5eb9da0 [INFO] running `Command { std: "docker" "start" "-a" "dbf656d8fa74ab6854823bb6d77126882d4317aa46497b70942063dbf5eb9da0", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Compiling zerocopy v0.8.27 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling cc v1.2.34 [INFO] [stderr] Compiling serde_json v1.0.143 [INFO] [stderr] Checking regex-syntax v0.8.6 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking clap_lex v0.7.6 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking clap_builder v4.5.50 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking statrs v0.18.0 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Compiling codspeed-criterion-compat v4.1.0 [INFO] [stderr] Compiling mutants v0.0.3 [INFO] [stderr] Compiling psm v0.1.26 [INFO] [stderr] Compiling codspeed v4.1.0 [INFO] [stderr] Compiling stacker v0.1.21 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking is-terminal v0.4.16 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking clap v4.5.50 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking stringdex v0.0.6 (/opt/rustwide/workdir) [INFO] [stderr] Checking regex-automata v0.4.10 [INFO] [stdout] warning: enum `TinySet` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/internals/data_structures.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this bound is already specified as the supertrait of `DoubleEndedIterator` [INFO] [stdout] --> src/internals/tree/mod.rs:195:15 [INFO] [stdout] | [INFO] [stdout] 195 | ) -> impl Iterator + DoubleEndedIterator + ExactSizeIterator + Clone { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls [INFO] [stdout] = note: `#[warn(clippy::implied_bounds_in_impls)]` on by default [INFO] [stdout] help: try removing this bound [INFO] [stdout] | [INFO] [stdout] 195 - ) -> impl Iterator + DoubleEndedIterator + ExactSizeIterator + Clone { [INFO] [stdout] 195 + ) -> impl DoubleEndedIterator + ExactSizeIterator + Clone { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this bound is already specified as the supertrait of `DoubleEndedIterator` [INFO] [stdout] --> src/internals/tree/mod.rs:206:15 [INFO] [stdout] | [INFO] [stdout] 206 | ) -> impl Iterator + DoubleEndedIterator + ExactSizeIterator + Clone { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls [INFO] [stdout] help: try removing this bound [INFO] [stdout] | [INFO] [stdout] 206 - ) -> impl Iterator + DoubleEndedIterator + ExactSizeIterator + Clone { [INFO] [stdout] 206 + ) -> impl DoubleEndedIterator + ExactSizeIterator + Clone { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this bound is already specified as the supertrait of `DoubleEndedIterator` [INFO] [stdout] --> src/internals/tree/mod.rs:211:15 [INFO] [stdout] | [INFO] [stdout] 211 | ) -> impl Iterator + DoubleEndedIterator + ExactSizeIterator + Clone { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls [INFO] [stdout] help: try removing this bound [INFO] [stdout] | [INFO] [stdout] 211 - ) -> impl Iterator + DoubleEndedIterator + ExactSizeIterator + Clone { [INFO] [stdout] 211 + ) -> impl DoubleEndedIterator + ExactSizeIterator + Clone { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this bound is already specified as the supertrait of `ExactSizeIterator` [INFO] [stdout] --> src/internals/mod.rs:262:24 [INFO] [stdout] | [INFO] [stdout] 262 | fn new(edges: impl Iterator + ExactSizeIterator + Clone) -> NodeEdgeRepr { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls [INFO] [stdout] help: try removing this bound [INFO] [stdout] | [INFO] [stdout] 262 - fn new(edges: impl Iterator + ExactSizeIterator + Clone) -> NodeEdgeRepr { [INFO] [stdout] 262 + fn new(edges: impl ExactSizeIterator + Clone) -> NodeEdgeRepr { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this bound is already specified as the supertrait of `ExactSizeIterator` [INFO] [stdout] --> src/internals/mod.rs:265:29 [INFO] [stdout] | [INFO] [stdout] 265 | mut edges: impl Iterator + ExactSizeIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls [INFO] [stdout] help: try removing this bound [INFO] [stdout] | [INFO] [stdout] 265 - mut edges: impl Iterator + ExactSizeIterator, [INFO] [stdout] 265 + mut edges: impl ExactSizeIterator, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this bound is already specified as the supertrait of `ExactSizeIterator` [INFO] [stdout] --> src/internals/mod.rs:273:25 [INFO] [stdout] | [INFO] [stdout] 273 | edges: impl Iterator + ExactSizeIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls [INFO] [stdout] help: try removing this bound [INFO] [stdout] | [INFO] [stdout] 273 - edges: impl Iterator + ExactSizeIterator, [INFO] [stdout] 273 + edges: impl ExactSizeIterator, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/internals/mod.rs:901:25 [INFO] [stdout] | [INFO] [stdout] 901 | / (root_child_nodeid_lower >= 0xFFFF_0000 && child_is_large) [INFO] [stdout] ... | [INFO] [stdout] 905 | | || (child_node_suffixes_only != current_node_suffixes_only && child_is_large) [INFO] [stdout] | |_____________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 901 - (root_child_nodeid_lower >= 0xFFFF_0000 && child_is_large) [INFO] [stdout] 902 - // 2. Suffix-only subtrees are always unbundled from prefix-bearing nodes. [INFO] [stdout] 903 - // This reduces the amount of data that levenshtein matching, which ignores suffix-only subtrees, [INFO] [stdout] 904 - // winds up pulling down. [INFO] [stdout] 905 - || (child_node_suffixes_only != current_node_suffixes_only && child_is_large) [INFO] [stdout] 901 + !(!child_is_large || root_child_nodeid_lower < 0xFFFF_0000 && child_node_suffixes_only == current_node_suffixes_only) [INFO] [stdout] | [INFO] [stdout] 901 - (root_child_nodeid_lower >= 0xFFFF_0000 && child_is_large) [INFO] [stdout] 902 - // 2. Suffix-only subtrees are always unbundled from prefix-bearing nodes. [INFO] [stdout] 903 - // This reduces the amount of data that levenshtein matching, which ignores suffix-only subtrees, [INFO] [stdout] 904 - // winds up pulling down. [INFO] [stdout] 905 - || (child_node_suffixes_only != current_node_suffixes_only && child_is_large) [INFO] [stdout] 901 + (child_node_suffixes_only != current_node_suffixes_only || root_child_nodeid_lower >= 0xFFFF_0000) && child_is_large [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/internals/mod.rs:718:5 [INFO] [stdout] | [INFO] [stdout] 718 | / fn generate_node_with_bundled_children( [INFO] [stdout] 719 | | tree: &SearchTree, [INFO] [stdout] 720 | | node: usize, [INFO] [stdout] 721 | | disambig_level: usize, [INFO] [stdout] ... | [INFO] [stdout] 728 | | outbuf: &mut Vec, [INFO] [stdout] 729 | | ) -> Result { [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/internals/mod.rs:831:37 [INFO] [stdout] | [INFO] [stdout] 831 | let &[ch] = &child_data[..] && [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use the original value instead: `child_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/internals/mod.rs:1012:45 [INFO] [stdout] | [INFO] [stdout] 1012 | / ... if !is_stack_compressed || !child_is_stack_compressed || compression_bitmap != child_compression_bitmap { [INFO] [stdout] ... | [INFO] [stdout] 1017 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1011 ~ ) [INFO] [stdout] 1012 ~ if (!is_stack_compressed || !child_is_stack_compressed || compression_bitmap != child_compression_bitmap) => { [INFO] [stdout] 1013 | // if these nodes have different structure, [INFO] [stdout] ... [INFO] [stdout] 1016 | break; [INFO] [stdout] 1017 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/internals/mod.rs:1526:5 [INFO] [stdout] | [INFO] [stdout] 1526 | / fn generate_node( [INFO] [stdout] 1527 | | might_have_prefix_child_nodeids: &[u64], [INFO] [stdout] 1528 | | might_have_prefix_child_keys: &[u8], [INFO] [stdout] 1529 | | suffix_only_child_nodeids: &[u64], [INFO] [stdout] ... | [INFO] [stdout] 1534 | | outbuf: &mut Vec, [INFO] [stdout] 1535 | | ) -> (u64, Range) { [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/internals/mod.rs:1648:37 [INFO] [stdout] | [INFO] [stdout] 1648 | / ... run_lengths[current_run >> 1] = [INFO] [stdout] 1649 | | ... run_lengths[current_run >> 1] << 4; [INFO] [stdout] | |____________________________________________________________^ help: replace it with: `run_lengths[current_run >> 1] <<= 4` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/internals/mod.rs:1655:29 [INFO] [stdout] | [INFO] [stdout] 1655 | ... run_lengths[current_run >> 1] = run_lengths[current_run >> 1] << 4; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `run_lengths[current_run >> 1] <<= 4` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/internals/mod.rs:2175:16 [INFO] [stdout] | [INFO] [stdout] 2175 | if c >= 48 && c <= 63 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `(48..=63).contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking regex v1.11.2 [INFO] [stderr] Compiling zerocopy-derive v0.8.27 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking codspeed-criterion-compat-walltime v4.1.0 [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> benches/base64.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | write_base64_to_bytes(&data, &mut encoded); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 10 | let _ = write_base64_to_bytes(&data, &mut encoded); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `TinySet` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/internals/data_structures.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this bound is already specified as the supertrait of `DoubleEndedIterator` [INFO] [stdout] --> src/internals/tree/mod.rs:195:15 [INFO] [stdout] | [INFO] [stdout] 195 | ) -> impl Iterator + DoubleEndedIterator + ExactSizeIterator + Clone { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls [INFO] [stdout] = note: `#[warn(clippy::implied_bounds_in_impls)]` on by default [INFO] [stdout] help: try removing this bound [INFO] [stdout] | [INFO] [stdout] 195 - ) -> impl Iterator + DoubleEndedIterator + ExactSizeIterator + Clone { [INFO] [stdout] 195 + ) -> impl DoubleEndedIterator + ExactSizeIterator + Clone { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this bound is already specified as the supertrait of `DoubleEndedIterator` [INFO] [stdout] --> src/internals/tree/mod.rs:206:15 [INFO] [stdout] | [INFO] [stdout] 206 | ) -> impl Iterator + DoubleEndedIterator + ExactSizeIterator + Clone { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls [INFO] [stdout] help: try removing this bound [INFO] [stdout] | [INFO] [stdout] 206 - ) -> impl Iterator + DoubleEndedIterator + ExactSizeIterator + Clone { [INFO] [stdout] 206 + ) -> impl DoubleEndedIterator + ExactSizeIterator + Clone { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this bound is already specified as the supertrait of `DoubleEndedIterator` [INFO] [stdout] --> src/internals/tree/mod.rs:211:15 [INFO] [stdout] | [INFO] [stdout] 211 | ) -> impl Iterator + DoubleEndedIterator + ExactSizeIterator + Clone { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls [INFO] [stdout] help: try removing this bound [INFO] [stdout] | [INFO] [stdout] 211 - ) -> impl Iterator + DoubleEndedIterator + ExactSizeIterator + Clone { [INFO] [stdout] 211 + ) -> impl DoubleEndedIterator + ExactSizeIterator + Clone { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/internals/tree/tests.rs:346:18 [INFO] [stdout] | [INFO] [stdout] 346 | v.extend([&b"ab"[..], b"c"].into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 346 - v.extend([&b"ab"[..], b"c"].into_iter()); [INFO] [stdout] 346 + v.extend([&b"ab"[..], b"c"]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this bound is already specified as the supertrait of `ExactSizeIterator` [INFO] [stdout] --> src/internals/mod.rs:262:24 [INFO] [stdout] | [INFO] [stdout] 262 | fn new(edges: impl Iterator + ExactSizeIterator + Clone) -> NodeEdgeRepr { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls [INFO] [stdout] help: try removing this bound [INFO] [stdout] | [INFO] [stdout] 262 - fn new(edges: impl Iterator + ExactSizeIterator + Clone) -> NodeEdgeRepr { [INFO] [stdout] 262 + fn new(edges: impl ExactSizeIterator + Clone) -> NodeEdgeRepr { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this bound is already specified as the supertrait of `ExactSizeIterator` [INFO] [stdout] --> src/internals/mod.rs:265:29 [INFO] [stdout] | [INFO] [stdout] 265 | mut edges: impl Iterator + ExactSizeIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls [INFO] [stdout] help: try removing this bound [INFO] [stdout] | [INFO] [stdout] 265 - mut edges: impl Iterator + ExactSizeIterator, [INFO] [stdout] 265 + mut edges: impl ExactSizeIterator, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this bound is already specified as the supertrait of `ExactSizeIterator` [INFO] [stdout] --> src/internals/mod.rs:273:25 [INFO] [stdout] | [INFO] [stdout] 273 | edges: impl Iterator + ExactSizeIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls [INFO] [stdout] help: try removing this bound [INFO] [stdout] | [INFO] [stdout] 273 - edges: impl Iterator + ExactSizeIterator, [INFO] [stdout] 273 + edges: impl ExactSizeIterator, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/internals/mod.rs:901:25 [INFO] [stdout] | [INFO] [stdout] 901 | / (root_child_nodeid_lower >= 0xFFFF_0000 && child_is_large) [INFO] [stdout] ... | [INFO] [stdout] 905 | | || (child_node_suffixes_only != current_node_suffixes_only && child_is_large) [INFO] [stdout] | |_____________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 901 - (root_child_nodeid_lower >= 0xFFFF_0000 && child_is_large) [INFO] [stdout] 902 - // 2. Suffix-only subtrees are always unbundled from prefix-bearing nodes. [INFO] [stdout] 903 - // This reduces the amount of data that levenshtein matching, which ignores suffix-only subtrees, [INFO] [stdout] 904 - // winds up pulling down. [INFO] [stdout] 905 - || (child_node_suffixes_only != current_node_suffixes_only && child_is_large) [INFO] [stdout] 901 + !(!child_is_large || root_child_nodeid_lower < 0xFFFF_0000 && child_node_suffixes_only == current_node_suffixes_only) [INFO] [stdout] | [INFO] [stdout] 901 - (root_child_nodeid_lower >= 0xFFFF_0000 && child_is_large) [INFO] [stdout] 902 - // 2. Suffix-only subtrees are always unbundled from prefix-bearing nodes. [INFO] [stdout] 903 - // This reduces the amount of data that levenshtein matching, which ignores suffix-only subtrees, [INFO] [stdout] 904 - // winds up pulling down. [INFO] [stdout] 905 - || (child_node_suffixes_only != current_node_suffixes_only && child_is_large) [INFO] [stdout] 901 + (child_node_suffixes_only != current_node_suffixes_only || root_child_nodeid_lower >= 0xFFFF_0000) && child_is_large [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/internals/mod.rs:718:5 [INFO] [stdout] | [INFO] [stdout] 718 | / fn generate_node_with_bundled_children( [INFO] [stdout] 719 | | tree: &SearchTree, [INFO] [stdout] 720 | | node: usize, [INFO] [stdout] 721 | | disambig_level: usize, [INFO] [stdout] ... | [INFO] [stdout] 728 | | outbuf: &mut Vec, [INFO] [stdout] 729 | | ) -> Result { [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant slicing of the whole range [INFO] [stdout] --> src/internals/mod.rs:831:37 [INFO] [stdout] | [INFO] [stdout] 831 | let &[ch] = &child_data[..] && [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use the original value instead: `child_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_slicing [INFO] [stdout] = note: `#[warn(clippy::redundant_slicing)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/internals/mod.rs:1012:45 [INFO] [stdout] | [INFO] [stdout] 1012 | / ... if !is_stack_compressed || !child_is_stack_compressed || compression_bitmap != child_compression_bitmap { [INFO] [stdout] ... | [INFO] [stdout] 1017 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1011 ~ ) [INFO] [stdout] 1012 ~ if (!is_stack_compressed || !child_is_stack_compressed || compression_bitmap != child_compression_bitmap) => { [INFO] [stdout] 1013 | // if these nodes have different structure, [INFO] [stdout] ... [INFO] [stdout] 1016 | break; [INFO] [stdout] 1017 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/internals/mod.rs:1526:5 [INFO] [stdout] | [INFO] [stdout] 1526 | / fn generate_node( [INFO] [stdout] 1527 | | might_have_prefix_child_nodeids: &[u64], [INFO] [stdout] 1528 | | might_have_prefix_child_keys: &[u8], [INFO] [stdout] 1529 | | suffix_only_child_nodeids: &[u64], [INFO] [stdout] ... | [INFO] [stdout] 1534 | | outbuf: &mut Vec, [INFO] [stdout] 1535 | | ) -> (u64, Range) { [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/internals/mod.rs:1648:37 [INFO] [stdout] | [INFO] [stdout] 1648 | / ... run_lengths[current_run >> 1] = [INFO] [stdout] 1649 | | ... run_lengths[current_run >> 1] << 4; [INFO] [stdout] | |____________________________________________________________^ help: replace it with: `run_lengths[current_run >> 1] <<= 4` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/internals/mod.rs:1655:29 [INFO] [stdout] | [INFO] [stdout] 1655 | ... run_lengths[current_run >> 1] = run_lengths[current_run >> 1] << 4; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `run_lengths[current_run >> 1] <<= 4` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/internals/mod.rs:2175:16 [INFO] [stdout] | [INFO] [stdout] 2175 | if c >= 48 && c <= 63 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `(48..=63).contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/internals/tests.rs:680:9 [INFO] [stdout] | [INFO] [stdout] 680 | strings_to_insert.push(b"\0"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![b"\0";SIZE]` [INFO] [stdout] = help: or `strings_to_insert.extend(std::iter::repeat_n(b"\0", SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 31.24s [INFO] running `Command { std: "docker" "inspect" "dbf656d8fa74ab6854823bb6d77126882d4317aa46497b70942063dbf5eb9da0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dbf656d8fa74ab6854823bb6d77126882d4317aa46497b70942063dbf5eb9da0", kill_on_drop: false }` [INFO] [stdout] dbf656d8fa74ab6854823bb6d77126882d4317aa46497b70942063dbf5eb9da0