[INFO] fetching crate strfmt 0.2.5... [INFO] linting strfmt-0.2.5 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate strfmt 0.2.5 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate strfmt 0.2.5 [INFO] finished tweaking crates.io crate strfmt 0.2.5 [INFO] tweaked toml for crates.io crate strfmt 0.2.5 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate strfmt 0.2.5 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate strfmt 0.2.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f65b71ef09b8b7a74b47b13f49617412fc1c58782d7b05d1002a102a6d9e175b [INFO] running `Command { std: "docker" "start" "-a" "f65b71ef09b8b7a74b47b13f49617412fc1c58782d7b05d1002a102a6d9e175b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f65b71ef09b8b7a74b47b13f49617412fc1c58782d7b05d1002a102a6d9e175b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f65b71ef09b8b7a74b47b13f49617412fc1c58782d7b05d1002a102a6d9e175b", kill_on_drop: false }` [INFO] [stdout] f65b71ef09b8b7a74b47b13f49617412fc1c58782d7b05d1002a102a6d9e175b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7371bc0f7d53f73b88e0312da919b73565a9048f8264716153b98f8853fccfc8 [INFO] running `Command { std: "docker" "start" "-a" "7371bc0f7d53f73b88e0312da919b73565a9048f8264716153b98f8853fccfc8", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking strfmt v0.2.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/formatter.rs:118:8 [INFO] [stdout] | [INFO] [stdout] 118 | if end - pos >= 1 + fake_fill.len_utf8() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `end - pos > fake_fill.len_utf8()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/formatter.rs:303:13 [INFO] [stdout] | [INFO] [stdout] 303 | buff: buff, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `buff` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `c @ _` pattern can be written as just `c` [INFO] [stdout] --> src/tests/strfmt.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | c @ _ => panic!("error code {} DNE", c), [INFO] [stdout] | ^^^^^ help: try: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stdout] --> src/formatter.rs:118:8 [INFO] [stdout] | [INFO] [stdout] 118 | if end - pos >= 1 + fake_fill.len_utf8() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `end - pos > fake_fill.len_utf8()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stdout] = note: `#[warn(clippy::int_plus_one)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/formatter.rs:303:13 [INFO] [stdout] | [INFO] [stdout] 303 | buff: buff, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `buff` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/fmtstr.rs:75:14 [INFO] [stdout] | [INFO] [stdout] 75 | if !(self.ty() == None || self.ty() == Some('s')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `self.ty().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/formatter.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / match c { [INFO] [stdout] 26 | | '=' | '<' | '^' | '>' => true, [INFO] [stdout] 27 | | _ => false, [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 25 - match c { [INFO] [stdout] 26 - '=' | '<' | '^' | '>' => true, [INFO] [stdout] 27 - _ => false, [INFO] [stdout] 28 - } [INFO] [stdout] 25 + matches!(c, '=' | '<' | '^' | '>') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/formatter.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | / match c { [INFO] [stdout] 33 | | ' ' | '-' | '+' => true, [INFO] [stdout] 34 | | _ => false, [INFO] [stdout] 35 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 32 - match c { [INFO] [stdout] 33 - ' ' | '-' | '+' => true, [INFO] [stdout] 34 - _ => false, [INFO] [stdout] 35 - } [INFO] [stdout] 32 + matches!(c, ' ' | '-' | '+') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/formatter.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | / match c { [INFO] [stdout] 40 | | 'b' | 'o' | 'x' | 'X' | 'e' | 'E' | 'f' | 'F' | '%' | 's' | '?' => true, [INFO] [stdout] 41 | | _ => false, [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 39 - match c { [INFO] [stdout] 40 - 'b' | 'o' | 'x' | 'X' | 'e' | 'E' | 'f' | 'F' | '%' | 's' | '?' => true, [INFO] [stdout] 41 - _ => false, [INFO] [stdout] 42 - } [INFO] [stdout] 39 + matches!(c, 'b' | 'o' | 'x' | 'X' | 'e' | 'E' | 'f' | 'F' | '%' | 's' | '?') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/formatter.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | / match str::from_utf8_unchecked(intstr).parse::() { [INFO] [stdout] 64 | | Ok(v) => Some(v), [INFO] [stdout] 65 | | Err(_) => None, [INFO] [stdout] 66 | | } [INFO] [stdout] | |_____________^ help: replace with: `str::from_utf8_unchecked(intstr).parse::().ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/formatter.rs:145:58 [INFO] [stdout] | [INFO] [stdout] 145 | if !fill_specified && end - pos >= 1 && rest[pos] == '0' as u8 { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'0'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/formatter.rs:389:24 [INFO] [stdout] | [INFO] [stdout] 389 | Some(c) => match c { [INFO] [stdout] | ________________________^ [INFO] [stdout] 390 | | 'b' | 'o' | 'x' | 'X' => true, [INFO] [stdout] 391 | | _ => false, [INFO] [stdout] 392 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 389 - Some(c) => match c { [INFO] [stdout] 390 - 'b' | 'o' | 'x' | 'X' => true, [INFO] [stdout] 391 - _ => false, [INFO] [stdout] 392 - }, [INFO] [stdout] 389 + Some(c) => matches!(c, 'b' | 'o' | 'x' | 'X'), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/formatter.rs:402:24 [INFO] [stdout] | [INFO] [stdout] 402 | Some(c) => match c { [INFO] [stdout] | ________________________^ [INFO] [stdout] 403 | | 'f' | 'e' | 'E' => true, [INFO] [stdout] 404 | | _ => false, [INFO] [stdout] 405 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 402 - Some(c) => match c { [INFO] [stdout] 403 - 'f' | 'e' | 'E' => true, [INFO] [stdout] 404 - _ => false, [INFO] [stdout] 405 - }, [INFO] [stdout] 402 + Some(c) => matches!(c, 'f' | 'e' | 'E'), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/types.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / match *self { [INFO] [stdout] 26 | | Sign::Unspecified => false, [INFO] [stdout] 27 | | _ => true, [INFO] [stdout] 28 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 25 - match *self { [INFO] [stdout] 26 - Sign::Unspecified => false, [INFO] [stdout] 27 - _ => true, [INFO] [stdout] 28 - } [INFO] [stdout] 25 + !matches!(*self, Sign::Unspecified) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:53:15 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn strfmt<'a, K, T: DisplayStr>(fmtstr: &str, vars: &HashMap) -> Result [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:81:23 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn strfmt_display<'a, K, T: fmt::Display>(fmtstr: &str, vars: &HashMap) -> Result [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/fmtstr.rs:75:14 [INFO] [stdout] | [INFO] [stdout] 75 | if !(self.ty() == None || self.ty() == Some('s')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `self.ty().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/formatter.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / match c { [INFO] [stdout] 26 | | '=' | '<' | '^' | '>' => true, [INFO] [stdout] 27 | | _ => false, [INFO] [stdout] 28 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 25 - match c { [INFO] [stdout] 26 - '=' | '<' | '^' | '>' => true, [INFO] [stdout] 27 - _ => false, [INFO] [stdout] 28 - } [INFO] [stdout] 25 + matches!(c, '=' | '<' | '^' | '>') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/formatter.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | / match c { [INFO] [stdout] 33 | | ' ' | '-' | '+' => true, [INFO] [stdout] 34 | | _ => false, [INFO] [stdout] 35 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 32 - match c { [INFO] [stdout] 33 - ' ' | '-' | '+' => true, [INFO] [stdout] 34 - _ => false, [INFO] [stdout] 35 - } [INFO] [stdout] 32 + matches!(c, ' ' | '-' | '+') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/formatter.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | / match c { [INFO] [stdout] 40 | | 'b' | 'o' | 'x' | 'X' | 'e' | 'E' | 'f' | 'F' | '%' | 's' | '?' => true, [INFO] [stdout] 41 | | _ => false, [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 39 - match c { [INFO] [stdout] 40 - 'b' | 'o' | 'x' | 'X' | 'e' | 'E' | 'f' | 'F' | '%' | 's' | '?' => true, [INFO] [stdout] 41 - _ => false, [INFO] [stdout] 42 - } [INFO] [stdout] 39 + matches!(c, 'b' | 'o' | 'x' | 'X' | 'e' | 'E' | 'f' | 'F' | '%' | 's' | '?') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/formatter.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | / match str::from_utf8_unchecked(intstr).parse::() { [INFO] [stdout] 64 | | Ok(v) => Some(v), [INFO] [stdout] 65 | | Err(_) => None, [INFO] [stdout] 66 | | } [INFO] [stdout] | |_____________^ help: replace with: `str::from_utf8_unchecked(intstr).parse::().ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/formatter.rs:145:58 [INFO] [stdout] | [INFO] [stdout] 145 | if !fill_specified && end - pos >= 1 && rest[pos] == '0' as u8 { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'0'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/formatter.rs:389:24 [INFO] [stdout] | [INFO] [stdout] 389 | Some(c) => match c { [INFO] [stdout] | ________________________^ [INFO] [stdout] 390 | | 'b' | 'o' | 'x' | 'X' => true, [INFO] [stdout] 391 | | _ => false, [INFO] [stdout] 392 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 389 - Some(c) => match c { [INFO] [stdout] 390 - 'b' | 'o' | 'x' | 'X' => true, [INFO] [stdout] 391 - _ => false, [INFO] [stdout] 392 - }, [INFO] [stdout] 389 + Some(c) => matches!(c, 'b' | 'o' | 'x' | 'X'), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/formatter.rs:402:24 [INFO] [stdout] | [INFO] [stdout] 402 | Some(c) => match c { [INFO] [stdout] | ________________________^ [INFO] [stdout] 403 | | 'f' | 'e' | 'E' => true, [INFO] [stdout] 404 | | _ => false, [INFO] [stdout] 405 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 402 - Some(c) => match c { [INFO] [stdout] 403 - 'f' | 'e' | 'E' => true, [INFO] [stdout] 404 - _ => false, [INFO] [stdout] 405 - }, [INFO] [stdout] 402 + Some(c) => matches!(c, 'f' | 'e' | 'E'), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/fmt.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | assert_eq!(f.alternate(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 13 - assert_eq!(f.alternate(), false); [INFO] [stdout] 13 + assert!(!f.alternate()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/fmt.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | assert_eq!(f.thousands(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 15 - assert_eq!(f.thousands(), false); [INFO] [stdout] 15 + assert!(!f.thousands()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tests/strfmt.rs:36:23 [INFO] [stdout] | [INFO] [stdout] 36 | failure = !(expected == result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(expected != result)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/tests/strfmt.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/types.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / match *self { [INFO] [stdout] 26 | | Sign::Unspecified => false, [INFO] [stdout] 27 | | _ => true, [INFO] [stdout] 28 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 25 - match *self { [INFO] [stdout] 26 - Sign::Unspecified => false, [INFO] [stdout] 27 - _ => true, [INFO] [stdout] 28 - } [INFO] [stdout] 25 + !matches!(*self, Sign::Unspecified) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:53:15 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn strfmt<'a, K, T: DisplayStr>(fmtstr: &str, vars: &HashMap) -> Result [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:81:23 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn strfmt_display<'a, K, T: fmt::Display>(fmtstr: &str, vars: &HashMap) -> Result [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.56s [INFO] running `Command { std: "docker" "inspect" "7371bc0f7d53f73b88e0312da919b73565a9048f8264716153b98f8853fccfc8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7371bc0f7d53f73b88e0312da919b73565a9048f8264716153b98f8853fccfc8", kill_on_drop: false }` [INFO] [stdout] 7371bc0f7d53f73b88e0312da919b73565a9048f8264716153b98f8853fccfc8