[INFO] fetching crate streaming_algorithms 0.3.3... [INFO] linting streaming_algorithms-0.3.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate streaming_algorithms 0.3.3 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate streaming_algorithms 0.3.3 [INFO] finished tweaking crates.io crate streaming_algorithms 0.3.3 [INFO] tweaked toml for crates.io crate streaming_algorithms 0.3.3 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate streaming_algorithms 0.3.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate streaming_algorithms 0.3.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded xxhash-rust v0.8.15 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bdbcb38723d83429183500dc3e58f53966be32fa792e25ca767c3b6dea643b45 [INFO] running `Command { std: "docker" "start" "-a" "bdbcb38723d83429183500dc3e58f53966be32fa792e25ca767c3b6dea643b45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bdbcb38723d83429183500dc3e58f53966be32fa792e25ca767c3b6dea643b45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bdbcb38723d83429183500dc3e58f53966be32fa792e25ca767c3b6dea643b45", kill_on_drop: false }` [INFO] [stdout] bdbcb38723d83429183500dc3e58f53966be32fa792e25ca767c3b6dea643b45 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fcea5798b6effa0a553fb3017b16fbda2a4202977215847c4b2aad626405f3f6 [INFO] running `Command { std: "docker" "start" "-a" "fcea5798b6effa0a553fb3017b16fbda2a4202977215847c4b2aad626405f3f6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Checking xxhash-rust v0.8.15 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_pcg v0.2.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking streaming_algorithms v0.3.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/count_min.rs:75:14 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn push(&mut self, key: &Q, value: &V) -> C [INFO] [stdout] | ^ [INFO] [stdout] 76 | where [INFO] [stdout] 77 | Q: Hash, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/count_min.rs:120:22 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn union_assign(&mut self, key: &Q, value: &C) [INFO] [stdout] | ^ [INFO] [stdout] 121 | where [INFO] [stdout] 122 | Q: Hash, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/count_min.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn get(&self, key: &Q) -> C [INFO] [stdout] | ^ [INFO] [stdout] 136 | where [INFO] [stdout] 137 | Q: Hash, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/count_min.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 189 | fn offsets(&self, key: &Q) -> impl Iterator [INFO] [stdout] | ^ [INFO] [stdout] 190 | where [INFO] [stdout] 191 | Q: Hash, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/count_min.rs:199:11 [INFO] [stdout] | [INFO] [stdout] 199 | fn hashes(key: &Q) -> impl Iterator [INFO] [stdout] | ^ [INFO] [stdout] 200 | where [INFO] [stdout] 201 | Q: Hash, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/count_min.rs:75:14 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn push(&mut self, key: &Q, value: &V) -> C [INFO] [stdout] | ^ [INFO] [stdout] 76 | where [INFO] [stdout] 77 | Q: Hash, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/count_min.rs:120:22 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn union_assign(&mut self, key: &Q, value: &C) [INFO] [stdout] | ^ [INFO] [stdout] 121 | where [INFO] [stdout] 122 | Q: Hash, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/count_min.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn get(&self, key: &Q) -> C [INFO] [stdout] | ^ [INFO] [stdout] 136 | where [INFO] [stdout] 137 | Q: Hash, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/count_min.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 189 | fn offsets(&self, key: &Q) -> impl Iterator [INFO] [stdout] | ^ [INFO] [stdout] 190 | where [INFO] [stdout] 191 | Q: Hash, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/count_min.rs:199:11 [INFO] [stdout] | [INFO] [stdout] 199 | fn hashes(key: &Q) -> impl Iterator [INFO] [stdout] | ^ [INFO] [stdout] 200 | where [INFO] [stdout] 201 | Q: Hash, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[ignore]` without reason [INFO] [stdout] --> src/count_min.rs:244:2 [INFO] [stdout] | [INFO] [stdout] 244 | #[ignore] // release mode stops panic [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: add a reason with `= ".."` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignore_without_reason [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:37:2 [INFO] [stdout] | [INFO] [stdout] 37 | clippy::pedantic [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(clippy::ignore_without_reason)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: #[should_panic] attribute without a reason [INFO] [stdout] --> src/count_min.rs:246:2 [INFO] [stdout] | [INFO] [stdout] 246 | #[should_panic] [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider specifying the expected panic: `#[should_panic(expected = /* panic message */)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_panic_without_expect [INFO] [stdout] = note: `#[warn(clippy::should_panic_without_expect)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/distinct.rs:621:6 [INFO] [stdout] | [INFO] [stdout] 621 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[ignore]` without reason [INFO] [stdout] --> src/top.rs:367:2 [INFO] [stdout] | [INFO] [stdout] 367 | #[ignore] // takes too long on CI [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: add a reason with `= ".."` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignore_without_reason [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for function which may panic missing `# Panics` section [INFO] [stdout] --> src/count_min.rs:75:2 [INFO] [stdout] | [INFO] [stdout] 75 | / pub fn push(&mut self, key: &Q, value: &V) -> C [INFO] [stdout] 76 | | where [INFO] [stdout] 77 | | Q: Hash, [INFO] [stdout] 78 | | K: Borrow, [INFO] [stdout] 79 | | C: for<'a> ops::AddAssign<&'a V> + IntersectPlusUnionIsPlus, [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] note: first possible panic found here [INFO] [stdout] --> src/count_min.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | let mut lowest = C::intersect( [INFO] [stdout] | ______________________________^ [INFO] [stdout] 90 | | self.offsets [INFO] [stdout] 91 | | .iter() [INFO] [stdout] 92 | | .enumerate() [INFO] [stdout] ... | [INFO] [stdout] 95 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:37:2 [INFO] [stdout] | [INFO] [stdout] 37 | clippy::pedantic [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(clippy::missing_panics_doc)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/count_min.rs:126:3 [INFO] [stdout] | [INFO] [stdout] 126 | / self.counters [INFO] [stdout] 127 | | .iter_mut() [INFO] [stdout] 128 | | .zip(offsets) [INFO] [stdout] 129 | | .for_each(|(counters, offset)| { [INFO] [stdout] 130 | | counters[offset].union_assign(value); [INFO] [stdout] 131 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] = note: `#[warn(clippy::semicolon_if_nothing_returned)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: add a `;` here [INFO] [stdout] | [INFO] [stdout] 126 | self.counters [INFO] [stdout] ... [INFO] [stdout] 130 | counters[offset].union_assign(value); [INFO] [stdout] 131 ~ }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for function which may panic missing `# Panics` section [INFO] [stdout] --> src/count_min.rs:135:2 [INFO] [stdout] | [INFO] [stdout] 135 | / pub fn get(&self, key: &Q) -> C [INFO] [stdout] 136 | | where [INFO] [stdout] 137 | | Q: Hash, [INFO] [stdout] 138 | | K: Borrow, [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] note: first possible panic found here [INFO] [stdout] --> src/count_min.rs:140:3 [INFO] [stdout] | [INFO] [stdout] 140 | / C::intersect( [INFO] [stdout] 141 | | self.counters [INFO] [stdout] 142 | | .iter() [INFO] [stdout] 143 | | .zip(self.offsets(key)) [INFO] [stdout] ... | [INFO] [stdout] 146 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/count_min.rs:160:3 [INFO] [stdout] | [INFO] [stdout] 160 | / self.counters [INFO] [stdout] 161 | | .iter_mut() [INFO] [stdout] 162 | | .flat_map(|x| x.iter_mut()) [INFO] [stdout] 163 | | .for_each(|counter| { [INFO] [stdout] 164 | | *counter = C::new(config); [INFO] [stdout] 165 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] help: add a `;` here [INFO] [stdout] | [INFO] [stdout] 160 | self.counters [INFO] [stdout] ... [INFO] [stdout] 164 | *counter = C::new(config); [INFO] [stdout] 165 ~ }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for function which may panic missing `# Panics` section [INFO] [stdout] --> src/count_min.rs:75:2 [INFO] [stdout] | [INFO] [stdout] 75 | / pub fn push(&mut self, key: &Q, value: &V) -> C [INFO] [stdout] 76 | | where [INFO] [stdout] 77 | | Q: Hash, [INFO] [stdout] 78 | | K: Borrow, [INFO] [stdout] 79 | | C: for<'a> ops::AddAssign<&'a V> + IntersectPlusUnionIsPlus, [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] note: first possible panic found here [INFO] [stdout] --> src/count_min.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | let mut lowest = C::intersect( [INFO] [stdout] | ______________________________^ [INFO] [stdout] 90 | | self.offsets [INFO] [stdout] 91 | | .iter() [INFO] [stdout] 92 | | .enumerate() [INFO] [stdout] ... | [INFO] [stdout] 95 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc [INFO] [stdout] = note: `#[warn(clippy::missing_panics_doc)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/count_min.rs:126:3 [INFO] [stdout] | [INFO] [stdout] 126 | / self.counters [INFO] [stdout] 127 | | .iter_mut() [INFO] [stdout] 128 | | .zip(offsets) [INFO] [stdout] 129 | | .for_each(|(counters, offset)| { [INFO] [stdout] 130 | | counters[offset].union_assign(value); [INFO] [stdout] 131 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] = note: `#[warn(clippy::semicolon_if_nothing_returned)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: add a `;` here [INFO] [stdout] | [INFO] [stdout] 126 | self.counters [INFO] [stdout] ... [INFO] [stdout] 130 | counters[offset].union_assign(value); [INFO] [stdout] 131 ~ }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for function which may panic missing `# Panics` section [INFO] [stdout] --> src/count_min.rs:135:2 [INFO] [stdout] | [INFO] [stdout] 135 | / pub fn get(&self, key: &Q) -> C [INFO] [stdout] 136 | | where [INFO] [stdout] 137 | | Q: Hash, [INFO] [stdout] 138 | | K: Borrow, [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] note: first possible panic found here [INFO] [stdout] --> src/count_min.rs:140:3 [INFO] [stdout] | [INFO] [stdout] 140 | / C::intersect( [INFO] [stdout] 141 | | self.counters [INFO] [stdout] 142 | | .iter() [INFO] [stdout] 143 | | .zip(self.offsets(key)) [INFO] [stdout] ... | [INFO] [stdout] 146 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/count_min.rs:160:3 [INFO] [stdout] | [INFO] [stdout] 160 | / self.counters [INFO] [stdout] 161 | | .iter_mut() [INFO] [stdout] 162 | | .flat_map(|x| x.iter_mut()) [INFO] [stdout] 163 | | .for_each(|counter| { [INFO] [stdout] 164 | | *counter = C::new(config); [INFO] [stdout] 165 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] help: add a `;` here [INFO] [stdout] | [INFO] [stdout] 160 | self.counters [INFO] [stdout] ... [INFO] [stdout] 164 | *counter = C::new(config); [INFO] [stdout] 165 ~ }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/distinct.rs:84:1 [INFO] [stdout] | [INFO] [stdout] 84 | / impl PartialOrd for HyperLogLogMagnitude { [INFO] [stdout] 85 | | #[inline(always)] [INFO] [stdout] 86 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 87 | | self.0.len().partial_cmp(&other.0.len()) [INFO] [stdout] 88 | | } [INFO] [stdout] 89 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 86 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 87 - self.0.len().partial_cmp(&other.0.len()) [INFO] [stdout] 88 - } [INFO] [stdout] 86 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/distinct.rs:118:3 [INFO] [stdout] | [INFO] [stdout] 118 | self.0.union_assign(&rhs.0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.0.union_assign(&rhs.0);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/distinct.rs:123:3 [INFO] [stdout] | [INFO] [stdout] 123 | self.0.add_assign(rhs) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.0.add_assign(rhs);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/distinct.rs:128:3 [INFO] [stdout] | [INFO] [stdout] 128 | self.0.add_assign(&rhs.0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.0.add_assign(&rhs.0);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for function which may panic missing `# Panics` section [INFO] [stdout] --> src/distinct.rs:157:2 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn new(error_rate: f64) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: first possible panic found here [INFO] [stdout] --> src/distinct.rs:158:3 [INFO] [stdout] | [INFO] [stdout] 158 | assert!(0.0 < error_rate && error_rate < 1.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/distinct.rs:161:3 [INFO] [stdout] | [INFO] [stdout] 161 | / assert!( [INFO] [stdout] 162 | | (4..=16).contains(&p), [INFO] [stdout] 163 | | "computed p={} from error_rate is outside supported range [4,16]", [INFO] [stdout] 164 | | p [INFO] [stdout] 165 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] = note: `#[warn(clippy::uninlined_format_args)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for function which may panic missing `# Panics` section [INFO] [stdout] --> src/distinct.rs:170:2 [INFO] [stdout] | [INFO] [stdout] 170 | pub fn with_p(p: u8) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: first possible panic found here [INFO] [stdout] --> src/distinct.rs:172:3 [INFO] [stdout] | [INFO] [stdout] 172 | / assert!( [INFO] [stdout] 173 | | (4..=16).contains(&p), [INFO] [stdout] 174 | | "p out of supported range for bias/threshold tables (have 4..=16)" [INFO] [stdout] 175 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting `usize` to `f64` may cause a loss of precision (`usize` can be up to 64 bits wide depending on the target architecture, but `f64`'s mantissa is only 52 bits wide) [INFO] [stdout] --> src/distinct.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | sum: m as f64, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_precision_loss [INFO] [stdout] = note: `#[warn(clippy::cast_precision_loss)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for function which may panic missing `# Panics` section [INFO] [stdout] --> src/distinct.rs:202:2 [INFO] [stdout] | [INFO] [stdout] 202 | pub fn push(&mut self, value: &V) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: first possible panic found here [INFO] [stdout] --> src/distinct.rs:211:25 [INFO] [stdout] | [INFO] [stdout] 211 | let mjr = &mut self.m[usize::try_from(j).unwrap()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: boolean to int conversion using if [INFO] [stdout] --> src/distinct.rs:214:16 [INFO] [stdout] | [INFO] [stdout] 214 | self.zero -= if old == 0 { 1 } else { 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with from: `usize::from(old == 0)` [INFO] [stdout] | [INFO] [stdout] = note: `(old == 0) as usize` or `(old == 0).into()` can also be valid options [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_to_int_with_if [INFO] [stdout] = note: `#[warn(clippy::bool_to_int_with_if)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting `u64` to `usize` may truncate the value on targets with 32-bit wide pointers [INFO] [stdout] --> src/distinct.rs:224:17 [INFO] [stdout] | [INFO] [stdout] 224 | let j = (x & ((self.m.len() as u64) - 1)) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ... [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation [INFO] [stdout] = note: `#[warn(clippy::cast_possible_truncation)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: ... or use `try_from` and handle the error accordingly [INFO] [stdout] | [INFO] [stdout] 224 - let j = (x & ((self.m.len() as u64) - 1)) as usize; [INFO] [stdout] 224 + let j = usize::try_from(x & ((self.m.len() as u64) - 1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casts from `u8` to `u64` can be expressed infallibly using `From` [INFO] [stdout] --> src/distinct.rs:237:58 [INFO] [stdout] | [INFO] [stdout] 237 | self.sum -= f64::from_bits(u64::MAX.wrapping_sub(old as u64) << 54 >> 2) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: an `as` cast can become silently lossy if the types change in the future [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stdout] = note: `#[warn(clippy::cast_lossless)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: use `u64::from` instead [INFO] [stdout] | [INFO] [stdout] 237 - self.sum -= f64::from_bits(u64::MAX.wrapping_sub(old as u64) << 54 >> 2) [INFO] [stdout] 237 + self.sum -= f64::from_bits(u64::MAX.wrapping_sub(u64::from(old)) << 54 >> 2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casts from `u8` to `u64` can be expressed infallibly using `From` [INFO] [stdout] --> src/distinct.rs:238:57 [INFO] [stdout] | [INFO] [stdout] 238 | - f64::from_bits(u64::MAX.wrapping_sub(new as u64) << 54 >> 2); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: an `as` cast can become silently lossy if the types change in the future [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stdout] help: use `u64::from` instead [INFO] [stdout] | [INFO] [stdout] 238 - - f64::from_bits(u64::MAX.wrapping_sub(new as u64) << 54 >> 2); [INFO] [stdout] 238 + - f64::from_bits(u64::MAX.wrapping_sub(u64::from(new)) << 54 >> 2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for function which may panic missing `# Panics` section [INFO] [stdout] --> src/distinct.rs:263:2 [INFO] [stdout] | [INFO] [stdout] 263 | pub fn union(&mut self, src: &Self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: first possible panic found here [INFO] [stdout] --> src/distinct.rs:264:3 [INFO] [stdout] | [INFO] [stdout] 264 | assert_eq!(src.alpha, self.alpha); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: boolean to int conversion using if [INFO] [stdout] --> src/distinct.rs:284:13 [INFO] [stdout] | [INFO] [stdout] 284 | zero += if *to == 0 { 1 } else { 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with from: `usize::from(*to == 0)` [INFO] [stdout] | [INFO] [stdout] = note: `(*to == 0) as usize` or `(*to == 0).into()` can also be valid options [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_to_int_with_if [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for function which may panic missing `# Panics` section [INFO] [stdout] --> src/distinct.rs:293:2 [INFO] [stdout] | [INFO] [stdout] 293 | pub fn intersect(&mut self, src: &Self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: first possible panic found here [INFO] [stdout] --> src/distinct.rs:294:3 [INFO] [stdout] | [INFO] [stdout] 294 | assert_eq!(src.alpha, self.alpha); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: boolean to int conversion using if [INFO] [stdout] --> src/distinct.rs:314:13 [INFO] [stdout] | [INFO] [stdout] 314 | zero += if *to == 0 { 1 } else { 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with from: `usize::from(*to == 0)` [INFO] [stdout] | [INFO] [stdout] = note: `(*to == 0) as usize` or `(*to == 0).into()` can also be valid options [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_to_int_with_if [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/distinct.rs:335:11 [INFO] [stdout] | [INFO] [stdout] 335 | assert!(4 <= p && p <= 16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `(4..=16).contains(&p)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> src/distinct.rs:420:17 [INFO] [stdout] | [INFO] [stdout] 420 | let mut min = if index > 6 { index - 6 } else { 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index.saturating_sub(6)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/distinct.rs:500:3 [INFO] [stdout] | [INFO] [stdout] 500 | self.union(rhs) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: add a `;` here: `self.union(rhs);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/distinct.rs:508:3 [INFO] [stdout] | [INFO] [stdout] 508 | self.push(rhs) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: add a `;` here: `self.push(rhs);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/distinct.rs:516:3 [INFO] [stdout] | [INFO] [stdout] 516 | self.union(rhs) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: add a `;` here: `self.union(rhs);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/linked_list.rs:6:6 [INFO] [stdout] | [INFO] [stdout] 6 | impl<'a> LinkedListIndex<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `#[warn(clippy::elidable_lifetime_names)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 6 - impl<'a> LinkedListIndex<'a> { [INFO] [stdout] 6 + impl LinkedListIndex<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | iter::once((usize::max_value(), 1, None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 24 - iter::once((usize::max_value(), 1, None)) [INFO] [stdout] 24 + iter::once((usize::MAX, 1, None)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:26:33 [INFO] [stdout] | [INFO] [stdout] 26 | .chain(iter::once((cap - 2, usize::max_value(), None))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 26 - .chain(iter::once((cap - 2, usize::max_value(), None))) [INFO] [stdout] 26 + .chain(iter::once((cap - 2, usize::MAX, None))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 30 | .map(|_| (usize::max_value(), usize::max_value(), None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 30 - .map(|_| (usize::max_value(), usize::max_value(), None)) [INFO] [stdout] 30 + .map(|_| (usize::MAX, usize::max_value(), None)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:30:35 [INFO] [stdout] | [INFO] [stdout] 30 | .map(|_| (usize::max_value(), usize::max_value(), None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 30 - .map(|_| (usize::max_value(), usize::max_value(), None)) [INFO] [stdout] 30 + .map(|_| (usize::max_value(), usize::MAX, None)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:36:10 [INFO] [stdout] | [INFO] [stdout] 36 | head: usize::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 36 - head: usize::max_value(), [INFO] [stdout] 36 + head: usize::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:37:10 [INFO] [stdout] | [INFO] [stdout] 37 | tail: usize::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 37 - tail: usize::max_value(), [INFO] [stdout] 37 + tail: usize::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/linked_list.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | assert!(!self.vec[cur].2.is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.vec[cur].2.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:51:17 [INFO] [stdout] | [INFO] [stdout] 51 | while cur != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 51 - while cur != usize::max_value() { [INFO] [stdout] 51 + while cur != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:54:16 [INFO] [stdout] | [INFO] [stdout] 54 | if next != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 54 - if next != usize::max_value() { [INFO] [stdout] 54 + if next != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 67 | while cur != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 67 - while cur != usize::max_value() { [INFO] [stdout] 67 + while cur != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:70:16 [INFO] [stdout] | [INFO] [stdout] 70 | if next != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 70 - if next != usize::max_value() { [INFO] [stdout] 70 + if next != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:82:20 [INFO] [stdout] | [INFO] [stdout] 82 | assert_ne!(free, usize::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 82 - assert_ne!(free, usize::max_value()); [INFO] [stdout] 82 + assert_ne!(free, usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:84:19 [INFO] [stdout] | [INFO] [stdout] 84 | if self.free != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 84 - if self.free != usize::max_value() { [INFO] [stdout] 84 + if self.free != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:85:28 [INFO] [stdout] | [INFO] [stdout] 85 | self.vec[self.free].0 = usize::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 85 - self.vec[self.free].0 = usize::max_value(); [INFO] [stdout] 85 + self.vec[self.free].0 = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:91:19 [INFO] [stdout] | [INFO] [stdout] 91 | if self.free != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 91 - if self.free != usize::max_value() { [INFO] [stdout] 91 + if self.free != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:94:21 [INFO] [stdout] | [INFO] [stdout] 94 | self.vec[idx].0 = usize::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 94 - self.vec[idx].0 = usize::max_value(); [INFO] [stdout] 94 + self.vec[idx].0 = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:100:19 [INFO] [stdout] | [INFO] [stdout] 100 | if self.head != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 100 - if self.head != usize::max_value() { [INFO] [stdout] 100 + if self.head != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:108:19 [INFO] [stdout] | [INFO] [stdout] 108 | if self.tail != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 108 - if self.tail != usize::max_value() { [INFO] [stdout] 108 + if self.tail != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:124:31 [INFO] [stdout] | [INFO] [stdout] 124 | self.vec[idx] = (self.tail, usize::max_value(), Some(t)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 124 - self.vec[idx] = (self.tail, usize::max_value(), Some(t)); [INFO] [stdout] 124 + self.vec[idx] = (self.tail, usize::MAX, Some(t)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:125:19 [INFO] [stdout] | [INFO] [stdout] 125 | if self.tail != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 125 - if self.tail != usize::max_value() { [INFO] [stdout] 125 + if self.tail != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:137:20 [INFO] [stdout] | [INFO] [stdout] 137 | self.vec[idx] = (usize::max_value(), self.head, Some(t)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 137 - self.vec[idx] = (usize::max_value(), self.head, Some(t)); [INFO] [stdout] 137 + self.vec[idx] = (usize::MAX, self.head, Some(t)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:138:19 [INFO] [stdout] | [INFO] [stdout] 138 | if self.head != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 138 - if self.head != usize::max_value() { [INFO] [stdout] 138 + if self.head != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:153:19 [INFO] [stdout] | [INFO] [stdout] 153 | if self.tail != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 153 - if self.tail != usize::max_value() { [INFO] [stdout] 153 + if self.tail != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:154:28 [INFO] [stdout] | [INFO] [stdout] 154 | self.vec[self.tail].1 = usize::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 154 - self.vec[self.tail].1 = usize::max_value(); [INFO] [stdout] 154 + self.vec[self.tail].1 = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:156:16 [INFO] [stdout] | [INFO] [stdout] 156 | self.head = usize::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 156 - self.head = usize::max_value(); [INFO] [stdout] 156 + self.head = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:168:19 [INFO] [stdout] | [INFO] [stdout] 168 | if self.head != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 168 - if self.head != usize::max_value() { [INFO] [stdout] 168 + if self.head != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:169:28 [INFO] [stdout] | [INFO] [stdout] 169 | self.vec[self.head].0 = usize::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 169 - self.vec[self.head].0 = usize::max_value(); [INFO] [stdout] 169 + self.vec[self.head].0 = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:171:16 [INFO] [stdout] | [INFO] [stdout] 171 | self.tail = usize::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 171 - self.tail = usize::max_value(); [INFO] [stdout] 171 + self.tail = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:183:14 [INFO] [stdout] | [INFO] [stdout] 183 | if next != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 183 - if next != usize::max_value() { [INFO] [stdout] 183 + if next != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:197:14 [INFO] [stdout] | [INFO] [stdout] 197 | if prev != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 197 - if prev != usize::max_value() { [INFO] [stdout] 197 + if prev != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:209:14 [INFO] [stdout] | [INFO] [stdout] 209 | if prev != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 209 - if prev != usize::max_value() { [INFO] [stdout] 209 + if prev != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:214:14 [INFO] [stdout] | [INFO] [stdout] 214 | if next != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 214 - if next != usize::max_value() { [INFO] [stdout] 214 + if next != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:229:14 [INFO] [stdout] | [INFO] [stdout] 229 | if prev != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 229 - if prev != usize::max_value() { [INFO] [stdout] 229 + if prev != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:234:14 [INFO] [stdout] | [INFO] [stdout] 234 | if next != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 234 - if next != usize::max_value() { [INFO] [stdout] 234 + if next != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:244:15 [INFO] [stdout] | [INFO] [stdout] 244 | if next2 != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 244 - if next2 != usize::max_value() { [INFO] [stdout] 244 + if next2 != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/distinct.rs:84:1 [INFO] [stdout] | [INFO] [stdout] 84 | / impl PartialOrd for HyperLogLogMagnitude { [INFO] [stdout] 85 | | #[inline(always)] [INFO] [stdout] 86 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 87 | | self.0.len().partial_cmp(&other.0.len()) [INFO] [stdout] 88 | | } [INFO] [stdout] 89 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 86 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 87 - self.0.len().partial_cmp(&other.0.len()) [INFO] [stdout] 88 - } [INFO] [stdout] 86 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:255:14 [INFO] [stdout] | [INFO] [stdout] 255 | if prev != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 255 - if prev != usize::max_value() { [INFO] [stdout] 255 + if prev != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:260:14 [INFO] [stdout] | [INFO] [stdout] 260 | if next != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 260 - if next != usize::max_value() { [INFO] [stdout] 260 + if next != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:270:15 [INFO] [stdout] | [INFO] [stdout] 270 | if prev2 != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 270 - if prev2 != usize::max_value() { [INFO] [stdout] 270 + if prev2 != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/distinct.rs:118:3 [INFO] [stdout] | [INFO] [stdout] 118 | self.0.union_assign(&rhs.0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.0.union_assign(&rhs.0);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/distinct.rs:123:3 [INFO] [stdout] | [INFO] [stdout] 123 | self.0.add_assign(rhs) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.0.add_assign(rhs);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/distinct.rs:128:3 [INFO] [stdout] | [INFO] [stdout] 128 | self.0.add_assign(&rhs.0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.0.add_assign(&rhs.0);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:280:23 [INFO] [stdout] | [INFO] [stdout] 280 | assert_ne!(index.0, usize::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 280 - assert_ne!(index.0, usize::max_value()); [INFO] [stdout] 280 + assert_ne!(index.0, usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:285:23 [INFO] [stdout] | [INFO] [stdout] 285 | assert_ne!(index.0, usize::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 285 - assert_ne!(index.0, usize::max_value()); [INFO] [stdout] 285 + assert_ne!(index.0, usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/linked_list.rs:293:6 [INFO] [stdout] | [INFO] [stdout] 293 | impl<'a, T> ops::Index> for LinkedList { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 293 - impl<'a, T> ops::Index> for LinkedList { [INFO] [stdout] 293 + impl ops::Index> for LinkedList { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/linked_list.rs:300:6 [INFO] [stdout] | [INFO] [stdout] 300 | impl<'a, T> ops::IndexMut> for LinkedList { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 300 - impl<'a, T> ops::IndexMut> for LinkedList { [INFO] [stdout] 300 + impl ops::IndexMut> for LinkedList { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/ordered_linked_list.rs:8:6 [INFO] [stdout] | [INFO] [stdout] 8 | impl<'a> OrderedLinkedListIndex<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 8 - impl<'a> OrderedLinkedListIndex<'a> { [INFO] [stdout] 8 + impl OrderedLinkedListIndex<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for function which may panic missing `# Panics` section [INFO] [stdout] --> src/distinct.rs:157:2 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn new(error_rate: f64) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: first possible panic found here [INFO] [stdout] --> src/distinct.rs:158:3 [INFO] [stdout] | [INFO] [stdout] 158 | assert!(0.0 < error_rate && error_rate < 1.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/distinct.rs:161:3 [INFO] [stdout] | [INFO] [stdout] 161 | / assert!( [INFO] [stdout] 162 | | (4..=16).contains(&p), [INFO] [stdout] 163 | | "computed p={} from error_rate is outside supported range [4,16]", [INFO] [stdout] 164 | | p [INFO] [stdout] 165 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] = note: `#[warn(clippy::uninlined_format_args)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/ordered_linked_list.rs:167:3 [INFO] [stdout] | [INFO] [stdout] 167 | self.0.increment(&mut index.0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.0.increment(&mut index.0);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for function which may panic missing `# Panics` section [INFO] [stdout] --> src/distinct.rs:170:2 [INFO] [stdout] | [INFO] [stdout] 170 | pub fn with_p(p: u8) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: first possible panic found here [INFO] [stdout] --> src/distinct.rs:172:3 [INFO] [stdout] | [INFO] [stdout] 172 | / assert!( [INFO] [stdout] 173 | | (4..=16).contains(&p), [INFO] [stdout] 174 | | "p out of supported range for bias/threshold tables (have 4..=16)" [INFO] [stdout] 175 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting `usize` to `f64` may cause a loss of precision (`usize` can be up to 64 bits wide depending on the target architecture, but `f64`'s mantissa is only 52 bits wide) [INFO] [stdout] --> src/distinct.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | sum: m as f64, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_precision_loss [INFO] [stdout] = note: `#[warn(clippy::cast_precision_loss)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for function which may panic missing `# Panics` section [INFO] [stdout] --> src/distinct.rs:202:2 [INFO] [stdout] | [INFO] [stdout] 202 | pub fn push(&mut self, value: &V) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: first possible panic found here [INFO] [stdout] --> src/distinct.rs:211:25 [INFO] [stdout] | [INFO] [stdout] 211 | let mjr = &mut self.m[usize::try_from(j).unwrap()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/ordered_linked_list.rs:171:3 [INFO] [stdout] | [INFO] [stdout] 171 | self.0.decrement(&mut index.0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.0.decrement(&mut index.0);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: boolean to int conversion using if [INFO] [stdout] --> src/distinct.rs:214:16 [INFO] [stdout] | [INFO] [stdout] 214 | self.zero -= if old == 0 { 1 } else { 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with from: `usize::from(old == 0)` [INFO] [stdout] | [INFO] [stdout] = note: `(old == 0) as usize` or `(old == 0).into()` can also be valid options [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_to_int_with_if [INFO] [stdout] = note: `#[warn(clippy::bool_to_int_with_if)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/ordered_linked_list.rs:174:3 [INFO] [stdout] | [INFO] [stdout] 174 | self.0.clear() [INFO] [stdout] | ^^^^^^^^^^^^^^ help: add a `;` here: `self.0.clear();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/ordered_linked_list.rs:183:6 [INFO] [stdout] | [INFO] [stdout] 183 | impl<'a, T: Ord> ops::Index> for OrderedLinkedList { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 183 - impl<'a, T: Ord> ops::Index> for OrderedLinkedList { [INFO] [stdout] 183 + impl ops::Index> for OrderedLinkedList { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting `u64` to `usize` may truncate the value on targets with 32-bit wide pointers [INFO] [stdout] --> src/distinct.rs:224:17 [INFO] [stdout] | [INFO] [stdout] 224 | let j = (x & ((self.m.len() as u64) - 1)) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: if this is intentional allow the lint with `#[allow(clippy::cast_possible_truncation)]` ... [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_possible_truncation [INFO] [stdout] = note: `#[warn(clippy::cast_possible_truncation)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: ... or use `try_from` and handle the error accordingly [INFO] [stdout] | [INFO] [stdout] 224 - let j = (x & ((self.m.len() as u64) - 1)) as usize; [INFO] [stdout] 224 + let j = usize::try_from(x & ((self.m.len() as u64) - 1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casts from `u8` to `u64` can be expressed infallibly using `From` [INFO] [stdout] --> src/distinct.rs:237:58 [INFO] [stdout] | [INFO] [stdout] 237 | self.sum -= f64::from_bits(u64::MAX.wrapping_sub(old as u64) << 54 >> 2) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: an `as` cast can become silently lossy if the types change in the future [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stdout] = note: `#[warn(clippy::cast_lossless)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: use `u64::from` instead [INFO] [stdout] | [INFO] [stdout] 237 - self.sum -= f64::from_bits(u64::MAX.wrapping_sub(old as u64) << 54 >> 2) [INFO] [stdout] 237 + self.sum -= f64::from_bits(u64::MAX.wrapping_sub(u64::from(old)) << 54 >> 2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/ordered_linked_list.rs:210:6 [INFO] [stdout] | [INFO] [stdout] 210 | impl<'a, T: Ord> Clone for OrderedLinkedListIter<'a, T> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 210 - impl<'a, T: Ord> Clone for OrderedLinkedListIter<'a, T> { [INFO] [stdout] 210 + impl Clone for OrderedLinkedListIter<'_, T> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casts from `u8` to `u64` can be expressed infallibly using `From` [INFO] [stdout] --> src/distinct.rs:238:57 [INFO] [stdout] | [INFO] [stdout] 238 | - f64::from_bits(u64::MAX.wrapping_sub(new as u64) << 54 >> 2); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: an `as` cast can become silently lossy if the types change in the future [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stdout] help: use `u64::from` instead [INFO] [stdout] | [INFO] [stdout] 238 - - f64::from_bits(u64::MAX.wrapping_sub(new as u64) << 54 >> 2); [INFO] [stdout] 238 + - f64::from_bits(u64::MAX.wrapping_sub(u64::from(new)) << 54 >> 2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for function which may panic missing `# Panics` section [INFO] [stdout] --> src/distinct.rs:263:2 [INFO] [stdout] | [INFO] [stdout] 263 | pub fn union(&mut self, src: &Self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: first possible panic found here [INFO] [stdout] --> src/distinct.rs:264:3 [INFO] [stdout] | [INFO] [stdout] 264 | assert_eq!(src.alpha, self.alpha); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: boolean to int conversion using if [INFO] [stdout] --> src/distinct.rs:284:13 [INFO] [stdout] | [INFO] [stdout] 284 | zero += if *to == 0 { 1 } else { 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with from: `usize::from(*to == 0)` [INFO] [stdout] | [INFO] [stdout] = note: `(*to == 0) as usize` or `(*to == 0).into()` can also be valid options [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_to_int_with_if [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for function which may panic missing `# Panics` section [INFO] [stdout] --> src/distinct.rs:293:2 [INFO] [stdout] | [INFO] [stdout] 293 | pub fn intersect(&mut self, src: &Self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: first possible panic found here [INFO] [stdout] --> src/distinct.rs:294:3 [INFO] [stdout] | [INFO] [stdout] 294 | assert_eq!(src.alpha, self.alpha); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: boolean to int conversion using if [INFO] [stdout] --> src/distinct.rs:314:13 [INFO] [stdout] | [INFO] [stdout] 314 | zero += if *to == 0 { 1 } else { 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with from: `usize::from(*to == 0)` [INFO] [stdout] | [INFO] [stdout] = note: `(*to == 0) as usize` or `(*to == 0).into()` can also be valid options [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_to_int_with_if [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/distinct.rs:335:11 [INFO] [stdout] | [INFO] [stdout] 335 | assert!(4 <= p && p <= 16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `(4..=16).contains(&p)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> src/distinct.rs:420:17 [INFO] [stdout] | [INFO] [stdout] 420 | let mut min = if index > 6 { index - 6 } else { 0 }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index.saturating_sub(6)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for function which may panic missing `# Panics` section [INFO] [stdout] --> src/sample.rs:15:2 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(total: usize, samples: usize) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: first possible panic found here [INFO] [stdout] --> src/sample.rs:16:3 [INFO] [stdout] | [INFO] [stdout] 16 | assert!(total >= samples); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/distinct.rs:500:3 [INFO] [stdout] | [INFO] [stdout] 500 | self.union(rhs) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: add a `;` here: `self.union(rhs);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/distinct.rs:508:3 [INFO] [stdout] | [INFO] [stdout] 508 | self.push(rhs) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: add a `;` here: `self.push(rhs);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/distinct.rs:516:3 [INFO] [stdout] | [INFO] [stdout] 516 | self.union(rhs) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: add a `;` here: `self.union(rhs);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/linked_list.rs:6:6 [INFO] [stdout] | [INFO] [stdout] 6 | impl<'a> LinkedListIndex<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] = note: `#[warn(clippy::elidable_lifetime_names)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 6 - impl<'a> LinkedListIndex<'a> { [INFO] [stdout] 6 + impl LinkedListIndex<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/top.rs:64:7 [INFO] [stdout] | [INFO] [stdout] 64 | for &Node(_, ref count) in self.list.iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 64 - for &Node(_, ref count) in self.list.iter() { [INFO] [stdout] 64 + for Node(_, count) in self.list.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for function which may panic missing `# Panics` section [INFO] [stdout] --> src/top.rs:74:2 [INFO] [stdout] | [INFO] [stdout] 74 | / pub fn push(&mut self, item: A, value: &V) [INFO] [stdout] 75 | | where [INFO] [stdout] 76 | | C: for<'a> ops::AddAssign<&'a V> + IntersectPlusUnionIsPlus, [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] note: first possible panic found here [INFO] [stdout] --> src/top.rs:95:27 [INFO] [stdout] | [INFO] [stdout] 95 | if score > self.list[self.list.tail().unwrap()].1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:24:16 [INFO] [stdout] | [INFO] [stdout] 24 | iter::once((usize::max_value(), 1, None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 24 - iter::once((usize::max_value(), 1, None)) [INFO] [stdout] 24 + iter::once((usize::MAX, 1, None)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:26:33 [INFO] [stdout] | [INFO] [stdout] 26 | .chain(iter::once((cap - 2, usize::max_value(), None))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 26 - .chain(iter::once((cap - 2, usize::max_value(), None))) [INFO] [stdout] 26 + .chain(iter::once((cap - 2, usize::MAX, None))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 30 | .map(|_| (usize::max_value(), usize::max_value(), None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 30 - .map(|_| (usize::max_value(), usize::max_value(), None)) [INFO] [stdout] 30 + .map(|_| (usize::MAX, usize::max_value(), None)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:30:35 [INFO] [stdout] | [INFO] [stdout] 30 | .map(|_| (usize::max_value(), usize::max_value(), None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 30 - .map(|_| (usize::max_value(), usize::max_value(), None)) [INFO] [stdout] 30 + .map(|_| (usize::max_value(), usize::MAX, None)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:36:10 [INFO] [stdout] | [INFO] [stdout] 36 | head: usize::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 36 - head: usize::max_value(), [INFO] [stdout] 36 + head: usize::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `iter` method without an `IntoIterator` impl for `&Top` [INFO] [stdout] --> src/top.rs:115:2 [INFO] [stdout] | [INFO] [stdout] 115 | / pub fn iter(&self) -> TopIter<'_, A, C> { [INFO] [stdout] 116 | | TopIter { [INFO] [stdout] 117 | | list_iter: self.list.iter(), [INFO] [stdout] 118 | | } [INFO] [stdout] 119 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_without_into_iter [INFO] [stdout] = note: `#[warn(clippy::iter_without_into_iter)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: consider implementing `IntoIterator` for `&Top` [INFO] [stdout] | [INFO] [stdout] 46 + [INFO] [stdout] 47 + impl IntoIterator for &Top { [INFO] [stdout] 48 + type Item = (&A, &C); [INFO] [stdout] 49 + type IntoIter = top::TopIter<'_, A, C>; [INFO] [stdout] 50 + fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] 51 + self.iter() [INFO] [stdout] 52 + } [INFO] [stdout] 53 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:37:10 [INFO] [stdout] | [INFO] [stdout] 37 | tail: usize::max_value(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 37 - tail: usize::max_value(), [INFO] [stdout] 37 + tail: usize::MAX, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/linked_list.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | assert!(!self.vec[cur].2.is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.vec[cur].2.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:51:17 [INFO] [stdout] | [INFO] [stdout] 51 | while cur != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 51 - while cur != usize::max_value() { [INFO] [stdout] 51 + while cur != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:54:16 [INFO] [stdout] | [INFO] [stdout] 54 | if next != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 54 - if next != usize::max_value() { [INFO] [stdout] 54 + if next != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 67 | while cur != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 67 - while cur != usize::max_value() { [INFO] [stdout] 67 + while cur != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:70:16 [INFO] [stdout] | [INFO] [stdout] 70 | if next != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 70 - if next != usize::max_value() { [INFO] [stdout] 70 + if next != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:82:20 [INFO] [stdout] | [INFO] [stdout] 82 | assert_ne!(free, usize::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 82 - assert_ne!(free, usize::max_value()); [INFO] [stdout] 82 + assert_ne!(free, usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:84:19 [INFO] [stdout] | [INFO] [stdout] 84 | if self.free != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 84 - if self.free != usize::max_value() { [INFO] [stdout] 84 + if self.free != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:85:28 [INFO] [stdout] | [INFO] [stdout] 85 | self.vec[self.free].0 = usize::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 85 - self.vec[self.free].0 = usize::max_value(); [INFO] [stdout] 85 + self.vec[self.free].0 = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:91:19 [INFO] [stdout] | [INFO] [stdout] 91 | if self.free != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 91 - if self.free != usize::max_value() { [INFO] [stdout] 91 + if self.free != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:94:21 [INFO] [stdout] | [INFO] [stdout] 94 | self.vec[idx].0 = usize::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 94 - self.vec[idx].0 = usize::max_value(); [INFO] [stdout] 94 + self.vec[idx].0 = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:100:19 [INFO] [stdout] | [INFO] [stdout] 100 | if self.head != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 100 - if self.head != usize::max_value() { [INFO] [stdout] 100 + if self.head != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:108:19 [INFO] [stdout] | [INFO] [stdout] 108 | if self.tail != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 108 - if self.tail != usize::max_value() { [INFO] [stdout] 108 + if self.tail != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:124:31 [INFO] [stdout] | [INFO] [stdout] 124 | self.vec[idx] = (self.tail, usize::max_value(), Some(t)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 124 - self.vec[idx] = (self.tail, usize::max_value(), Some(t)); [INFO] [stdout] 124 + self.vec[idx] = (self.tail, usize::MAX, Some(t)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:125:19 [INFO] [stdout] | [INFO] [stdout] 125 | if self.tail != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 125 - if self.tail != usize::max_value() { [INFO] [stdout] 125 + if self.tail != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:137:20 [INFO] [stdout] | [INFO] [stdout] 137 | self.vec[idx] = (usize::max_value(), self.head, Some(t)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 137 - self.vec[idx] = (usize::max_value(), self.head, Some(t)); [INFO] [stdout] 137 + self.vec[idx] = (usize::MAX, self.head, Some(t)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:138:19 [INFO] [stdout] | [INFO] [stdout] 138 | if self.head != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 138 - if self.head != usize::max_value() { [INFO] [stdout] 138 + if self.head != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `cloned` where `copied` could be used instead [INFO] [stdout] --> src/traits.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 49 | iter.cloned().min() [INFO] [stdout] | ^^^^^^ help: try: `copied` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied [INFO] [stdout] = note: `#[warn(clippy::cloned_instead_of_copied)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `cloned` where `copied` could be used instead [INFO] [stdout] --> src/traits.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 57 | iter.cloned().min() [INFO] [stdout] | ^^^^^^ help: try: `copied` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `cloned` where `copied` could be used instead [INFO] [stdout] --> src/traits.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | iter.cloned().min() [INFO] [stdout] | ^^^^^^ help: try: `copied` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `cloned` where `copied` could be used instead [INFO] [stdout] --> src/traits.rs:73:8 [INFO] [stdout] | [INFO] [stdout] 73 | iter.cloned().min() [INFO] [stdout] | ^^^^^^ help: try: `copied` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:153:19 [INFO] [stdout] | [INFO] [stdout] 153 | if self.tail != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 153 - if self.tail != usize::max_value() { [INFO] [stdout] 153 + if self.tail != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:154:28 [INFO] [stdout] | [INFO] [stdout] 154 | self.vec[self.tail].1 = usize::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 154 - self.vec[self.tail].1 = usize::max_value(); [INFO] [stdout] 154 + self.vec[self.tail].1 = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `cloned` where `copied` could be used instead [INFO] [stdout] --> src/traits.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 81 | iter.cloned().min() [INFO] [stdout] | ^^^^^^ help: try: `copied` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:156:16 [INFO] [stdout] | [INFO] [stdout] 156 | self.head = usize::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 156 - self.head = usize::max_value(); [INFO] [stdout] 156 + self.head = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:168:19 [INFO] [stdout] | [INFO] [stdout] 168 | if self.head != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 168 - if self.head != usize::max_value() { [INFO] [stdout] 168 + if self.head != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:169:28 [INFO] [stdout] | [INFO] [stdout] 169 | self.vec[self.head].0 = usize::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 169 - self.vec[self.head].0 = usize::max_value(); [INFO] [stdout] 169 + self.vec[self.head].0 = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:76:39 [INFO] [stdout] | [INFO] [stdout] 76 | assert!(a.is_sign_positive() && a <= usize::max_value() as f64 && a.fract() == 0.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 76 - assert!(a.is_sign_positive() && a <= usize::max_value() as f64 && a.fract() == 0.0); [INFO] [stdout] 76 + assert!(a.is_sign_positive() && a <= usize::MAX as f64 && a.fract() == 0.0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:171:16 [INFO] [stdout] | [INFO] [stdout] 171 | self.tail = usize::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 171 - self.tail = usize::max_value(); [INFO] [stdout] 171 + self.tail = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:86:49 [INFO] [stdout] | [INFO] [stdout] 86 | assert!(a.is_sign_positive() && a <= f64::from(u8::max_value()) && a.fract() == 0.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 86 - assert!(a.is_sign_positive() && a <= f64::from(u8::max_value()) && a.fract() == 0.0); [INFO] [stdout] 86 + assert!(a.is_sign_positive() && a <= f64::from(u8::MAX) && a.fract() == 0.0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:183:14 [INFO] [stdout] | [INFO] [stdout] 183 | if next != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 183 - if next != usize::max_value() { [INFO] [stdout] 183 + if next != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:197:14 [INFO] [stdout] | [INFO] [stdout] 197 | if prev != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 197 - if prev != usize::max_value() { [INFO] [stdout] 197 + if prev != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:209:14 [INFO] [stdout] | [INFO] [stdout] 209 | if prev != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 209 - if prev != usize::max_value() { [INFO] [stdout] 209 + if prev != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:214:14 [INFO] [stdout] | [INFO] [stdout] 214 | if next != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 214 - if next != usize::max_value() { [INFO] [stdout] 214 + if next != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:229:14 [INFO] [stdout] | [INFO] [stdout] 229 | if prev != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 229 - if prev != usize::max_value() { [INFO] [stdout] 229 + if prev != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:234:14 [INFO] [stdout] | [INFO] [stdout] 234 | if next != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 234 - if next != usize::max_value() { [INFO] [stdout] 234 + if next != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:244:15 [INFO] [stdout] | [INFO] [stdout] 244 | if next2 != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 244 - if next2 != usize::max_value() { [INFO] [stdout] 244 + if next2 != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:255:14 [INFO] [stdout] | [INFO] [stdout] 255 | if prev != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 255 - if prev != usize::max_value() { [INFO] [stdout] 255 + if prev != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:260:14 [INFO] [stdout] | [INFO] [stdout] 260 | if next != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 260 - if next != usize::max_value() { [INFO] [stdout] 260 + if next != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:270:15 [INFO] [stdout] | [INFO] [stdout] 270 | if prev2 != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 270 - if prev2 != usize::max_value() { [INFO] [stdout] 270 + if prev2 != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:280:23 [INFO] [stdout] | [INFO] [stdout] 280 | assert_ne!(index.0, usize::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 280 - assert_ne!(index.0, usize::max_value()); [INFO] [stdout] 280 + assert_ne!(index.0, usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/linked_list.rs:285:23 [INFO] [stdout] | [INFO] [stdout] 285 | assert_ne!(index.0, usize::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 285 - assert_ne!(index.0, usize::max_value()); [INFO] [stdout] 285 + assert_ne!(index.0, usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/linked_list.rs:293:6 [INFO] [stdout] | [INFO] [stdout] 293 | impl<'a, T> ops::Index> for LinkedList { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 293 - impl<'a, T> ops::Index> for LinkedList { [INFO] [stdout] 293 + impl ops::Index> for LinkedList { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/linked_list.rs:300:6 [INFO] [stdout] | [INFO] [stdout] 300 | impl<'a, T> ops::IndexMut> for LinkedList { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 300 - impl<'a, T> ops::IndexMut> for LinkedList { [INFO] [stdout] 300 + impl ops::IndexMut> for LinkedList { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/ordered_linked_list.rs:8:6 [INFO] [stdout] | [INFO] [stdout] 8 | impl<'a> OrderedLinkedListIndex<'a> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 8 - impl<'a> OrderedLinkedListIndex<'a> { [INFO] [stdout] 8 + impl OrderedLinkedListIndex<'_> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/ordered_linked_list.rs:167:3 [INFO] [stdout] | [INFO] [stdout] 167 | self.0.increment(&mut index.0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.0.increment(&mut index.0);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/ordered_linked_list.rs:171:3 [INFO] [stdout] | [INFO] [stdout] 171 | self.0.decrement(&mut index.0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.0.decrement(&mut index.0);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/ordered_linked_list.rs:174:3 [INFO] [stdout] | [INFO] [stdout] 174 | self.0.clear() [INFO] [stdout] | ^^^^^^^^^^^^^^ help: add a `;` here: `self.0.clear();` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/ordered_linked_list.rs:183:6 [INFO] [stdout] | [INFO] [stdout] 183 | impl<'a, T: Ord> ops::Index> for OrderedLinkedList { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 183 - impl<'a, T: Ord> ops::Index> for OrderedLinkedList { [INFO] [stdout] 183 + impl ops::Index> for OrderedLinkedList { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/ordered_linked_list.rs:210:6 [INFO] [stdout] | [INFO] [stdout] 210 | impl<'a, T: Ord> Clone for OrderedLinkedListIter<'a, T> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 210 - impl<'a, T: Ord> Clone for OrderedLinkedListIter<'a, T> { [INFO] [stdout] 210 + impl Clone for OrderedLinkedListIter<'_, T> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for function which may panic missing `# Panics` section [INFO] [stdout] --> src/sample.rs:15:2 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(total: usize, samples: usize) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: first possible panic found here [INFO] [stdout] --> src/sample.rs:16:3 [INFO] [stdout] | [INFO] [stdout] 16 | assert!(total >= samples); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/sample.rs:241:3 [INFO] [stdout] | [INFO] [stdout] 241 | println!("{:#?}", hash); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 241 - println!("{:#?}", hash); [INFO] [stdout] 241 + println!("{hash:#?}"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/sample.rs:257:3 [INFO] [stdout] | [INFO] [stdout] 257 | println!("{:#?}", hash); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 257 - println!("{:#?}", hash); [INFO] [stdout] 257 + println!("{hash:#?}"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/top.rs:64:7 [INFO] [stdout] | [INFO] [stdout] 64 | for &Node(_, ref count) in self.list.iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 64 - for &Node(_, ref count) in self.list.iter() { [INFO] [stdout] 64 + for Node(_, count) in self.list.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for function which may panic missing `# Panics` section [INFO] [stdout] --> src/top.rs:74:2 [INFO] [stdout] | [INFO] [stdout] 74 | / pub fn push(&mut self, item: A, value: &V) [INFO] [stdout] 75 | | where [INFO] [stdout] 76 | | C: for<'a> ops::AddAssign<&'a V> + IntersectPlusUnionIsPlus, [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] note: first possible panic found here [INFO] [stdout] --> src/top.rs:95:27 [INFO] [stdout] | [INFO] [stdout] 95 | if score > self.list[self.list.tail().unwrap()].1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_panics_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `iter` method without an `IntoIterator` impl for `&Top` [INFO] [stdout] --> src/top.rs:115:2 [INFO] [stdout] | [INFO] [stdout] 115 | / pub fn iter(&self) -> TopIter<'_, A, C> { [INFO] [stdout] 116 | | TopIter { [INFO] [stdout] 117 | | list_iter: self.list.iter(), [INFO] [stdout] 118 | | } [INFO] [stdout] 119 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_without_into_iter [INFO] [stdout] = note: `#[warn(clippy::iter_without_into_iter)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: consider implementing `IntoIterator` for `&Top` [INFO] [stdout] | [INFO] [stdout] 46 + [INFO] [stdout] 47 + impl IntoIterator for &Top { [INFO] [stdout] 48 + type Item = (&A, &C); [INFO] [stdout] 49 + type IntoIter = top::TopIter<'_, A, C>; [INFO] [stdout] 50 + fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] 51 + self.iter() [INFO] [stdout] 52 + } [INFO] [stdout] 53 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/top.rs:268:18 [INFO] [stdout] | [INFO] [stdout] 268 | (true, _) => format!("a{}", c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 268 - (true, _) => format!("a{}", c), [INFO] [stdout] 268 + (true, _) => format!("a{c}"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/top.rs:269:22 [INFO] [stdout] | [INFO] [stdout] 269 | (false, true) => format!("b{}", c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 269 - (false, true) => format!("b{}", c), [INFO] [stdout] 269 + (false, true) => format!("b{c}"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/top.rs:270:23 [INFO] [stdout] | [INFO] [stdout] 270 | (false, false) => format!("c{}", c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 270 - (false, false) => format!("c{}", c), [INFO] [stdout] 270 + (false, false) => format!("c{c}"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/top.rs:275:3 [INFO] [stdout] | [INFO] [stdout] 275 | println!("{:#?}", top); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 275 - println!("{:#?}", top); [INFO] [stdout] 275 + println!("{top:#?}"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/top.rs:278:3 [INFO] [stdout] | [INFO] [stdout] 278 | println!("{:#?}", x); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 278 - println!("{:#?}", x); [INFO] [stdout] 278 + println!("{x:#?}"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HLL` contains a capitalized acronym [INFO] [stdout] --> src/top.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 283 | struct HLL(HyperLogLog); [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Hll` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/top.rs:290:2 [INFO] [stdout] | [INFO] [stdout] 290 | / impl PartialOrd for HLL { [INFO] [stdout] 291 | | #[inline(always)] [INFO] [stdout] 292 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 293 | | self.0.len().partial_cmp(&other.0.len()) [INFO] [stdout] 294 | | } [INFO] [stdout] 295 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 292 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 293 - self.0.len().partial_cmp(&other.0.len()) [INFO] [stdout] 294 - } [INFO] [stdout] 292 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/top.rs:324:4 [INFO] [stdout] | [INFO] [stdout] 324 | self.0.union_assign(&rhs.0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.0.union_assign(&rhs.0);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider adding a `;` to the last statement for consistent formatting [INFO] [stdout] --> src/top.rs:329:4 [INFO] [stdout] | [INFO] [stdout] 329 | self.0.add_assign(rhs) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.0.add_assign(rhs);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/top.rs:351:19 [INFO] [stdout] | [INFO] [stdout] 351 | (true, _) => (format!("a{}", c), format!("{}", rng.gen_range(0, 500))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 351 - (true, _) => (format!("a{}", c), format!("{}", rng.gen_range(0, 500))), [INFO] [stdout] 351 + (true, _) => (format!("a{c}"), format!("{}", rng.gen_range(0, 500))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/top.rs:352:23 [INFO] [stdout] | [INFO] [stdout] 352 | (false, true) => (format!("b{}", c), format!("{}", rng.gen_range(0, 200))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 352 - (false, true) => (format!("b{}", c), format!("{}", rng.gen_range(0, 200))), [INFO] [stdout] 352 + (false, true) => (format!("b{c}"), format!("{}", rng.gen_range(0, 200))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/top.rs:353:24 [INFO] [stdout] | [INFO] [stdout] 353 | (false, false) => (format!("c{}", c), format!("{}", rng.gen_range(0, 200))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 353 - (false, false) => (format!("c{}", c), format!("{}", rng.gen_range(0, 200))), [INFO] [stdout] 353 + (false, false) => (format!("c{c}"), format!("{}", rng.gen_range(0, 200))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/top.rs:361:3 [INFO] [stdout] | [INFO] [stdout] 361 | println!("{:#?}", top); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 361 - println!("{:#?}", top); [INFO] [stdout] 361 + println!("{top:#?}"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/top.rs:380:19 [INFO] [stdout] | [INFO] [stdout] 380 | (true, _) => (format!("a{}", c), format!("{}", rng.gen_range(0, 500))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 380 - (true, _) => (format!("a{}", c), format!("{}", rng.gen_range(0, 500))), [INFO] [stdout] 380 + (true, _) => (format!("a{c}"), format!("{}", rng.gen_range(0, 500))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/top.rs:381:23 [INFO] [stdout] | [INFO] [stdout] 381 | (false, true) => (format!("b{}", c), format!("{}", rng.gen_range(0, 200))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 381 - (false, true) => (format!("b{}", c), format!("{}", rng.gen_range(0, 200))), [INFO] [stdout] 381 + (false, true) => (format!("b{c}"), format!("{}", rng.gen_range(0, 200))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/top.rs:382:24 [INFO] [stdout] | [INFO] [stdout] 382 | (false, false) => (format!("c{}", c), format!("{}", rng.gen_range(0, 200))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 382 - (false, false) => (format!("c{}", c), format!("{}", rng.gen_range(0, 200))), [INFO] [stdout] 382 + (false, false) => (format!("c{c}"), format!("{}", rng.gen_range(0, 200))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `cloned` where `copied` could be used instead [INFO] [stdout] --> src/traits.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 49 | iter.cloned().min() [INFO] [stdout] | ^^^^^^ help: try: `copied` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied [INFO] [stdout] = note: `#[warn(clippy::cloned_instead_of_copied)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `cloned` where `copied` could be used instead [INFO] [stdout] --> src/traits.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 57 | iter.cloned().min() [INFO] [stdout] | ^^^^^^ help: try: `copied` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `cloned` where `copied` could be used instead [INFO] [stdout] --> src/traits.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | iter.cloned().min() [INFO] [stdout] | ^^^^^^ help: try: `copied` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `cloned` where `copied` could be used instead [INFO] [stdout] --> src/traits.rs:73:8 [INFO] [stdout] | [INFO] [stdout] 73 | iter.cloned().min() [INFO] [stdout] | ^^^^^^ help: try: `copied` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `cloned` where `copied` could be used instead [INFO] [stdout] --> src/traits.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 81 | iter.cloned().min() [INFO] [stdout] | ^^^^^^ help: try: `copied` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:76:39 [INFO] [stdout] | [INFO] [stdout] 76 | assert!(a.is_sign_positive() && a <= usize::max_value() as f64 && a.fract() == 0.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 76 - assert!(a.is_sign_positive() && a <= usize::max_value() as f64 && a.fract() == 0.0); [INFO] [stdout] 76 + assert!(a.is_sign_positive() && a <= usize::MAX as f64 && a.fract() == 0.0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/lib.rs:86:49 [INFO] [stdout] | [INFO] [stdout] 86 | assert!(a.is_sign_positive() && a <= f64::from(u8::max_value()) && a.fract() == 0.0); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 86 - assert!(a.is_sign_positive() && a <= f64::from(u8::max_value()) && a.fract() == 0.0); [INFO] [stdout] 86 + assert!(a.is_sign_positive() && a <= f64::from(u8::MAX) && a.fract() == 0.0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.53s [INFO] running `Command { std: "docker" "inspect" "fcea5798b6effa0a553fb3017b16fbda2a4202977215847c4b2aad626405f3f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fcea5798b6effa0a553fb3017b16fbda2a4202977215847c4b2aad626405f3f6", kill_on_drop: false }` [INFO] [stdout] fcea5798b6effa0a553fb3017b16fbda2a4202977215847c4b2aad626405f3f6