[INFO] fetching crate strafe-plot 0.1.1... [INFO] linting strafe-plot-0.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate strafe-plot 0.1.1 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate strafe-plot 0.1.1 [INFO] finished tweaking crates.io crate strafe-plot 0.1.1 [INFO] tweaked toml for crates.io crate strafe-plot 0.1.1 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate strafe-plot 0.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 291 packages to latest compatible versions [INFO] [stderr] Adding nalgebra v0.32.6 (available: v0.34.1) [INFO] [stderr] Adding polars v0.38.3 (available: v0.53.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded polars-error v0.38.3 [INFO] [stderr] Downloaded multiversion-macros v0.7.4 [INFO] [stderr] Downloaded planus v0.3.1 [INFO] [stderr] Downloaded strafe-error v0.1.1 [INFO] [stderr] Downloaded nonstdfloat v0.1.1 [INFO] [stderr] Downloaded fast-float v0.2.0 [INFO] [stderr] Downloaded strafe-distribution v0.1.1 [INFO] [stderr] Downloaded r2rs-base v0.1.1 [INFO] [stderr] Downloaded strafe-consts v0.1.1 [INFO] [stderr] Downloaded polars-utils v0.38.3 [INFO] [stderr] Downloaded plotters-bitmap v0.3.7 [INFO] [stderr] Downloaded strafe-tests v0.1.1 [INFO] [stderr] Downloaded polars-plan v0.38.3 [INFO] [stderr] Downloaded sqlparser v0.39.0 [INFO] [stderr] Downloaded r2rs-mass v0.1.1 [INFO] [stderr] Downloaded r2rs-rfit v0.1.1 [INFO] [stderr] Downloaded polars-lazy v0.38.3 [INFO] [stderr] Downloaded chrono-tz v0.8.6 [INFO] [stderr] Downloaded polars v0.38.3 [INFO] [stderr] Downloaded multiversion v0.7.4 [INFO] [stderr] Downloaded r2rs-nmath v0.1.1 [INFO] [stderr] Downloaded strafe-testing v0.1.1 [INFO] [stderr] Downloaded strafe-trait v0.1.1 [INFO] [stderr] Downloaded parquet-format-safe v0.2.4 [INFO] [stderr] Downloaded polars-sql v0.38.3 [INFO] [stderr] Downloaded polars-time v0.38.3 [INFO] [stderr] Downloaded polars-pipe v0.38.3 [INFO] [stderr] Downloaded polars-arrow-format v0.1.0 [INFO] [stderr] Downloaded strafe-type v0.1.1 [INFO] [stderr] Downloaded hexf v0.2.1 [INFO] [stderr] Downloaded polars-core v0.38.3 [INFO] [stderr] Downloaded foreign_vec v0.1.0 [INFO] [stderr] Downloaded polars-row v0.38.3 [INFO] [stderr] Downloaded polars-parquet v0.38.3 [INFO] [stderr] Downloaded r2rs-stats v0.1.1 [INFO] [stderr] Downloaded polars-ops v0.38.3 [INFO] [stderr] Downloaded polars-arrow v0.38.3 [INFO] [stderr] Downloaded polars-io v0.38.3 [INFO] [stderr] Downloaded polars-compute v0.38.3 [INFO] [stderr] Downloaded target-features v0.1.6 [INFO] [stderr] Downloaded itoap v1.0.1 [INFO] [stderr] Downloaded numfmt v1.2.0 [INFO] [stderr] Downloaded atoi_simd v0.15.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ed28f17dd31fc3c3c1855d84f3a2d8ba89bd30d6a690cbebdbc46c66d7cacfa6 [INFO] running `Command { std: "docker" "start" "-a" "ed28f17dd31fc3c3c1855d84f3a2d8ba89bd30d6a690cbebdbc46c66d7cacfa6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ed28f17dd31fc3c3c1855d84f3a2d8ba89bd30d6a690cbebdbc46c66d7cacfa6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed28f17dd31fc3c3c1855d84f3a2d8ba89bd30d6a690cbebdbc46c66d7cacfa6", kill_on_drop: false }` [INFO] [stdout] ed28f17dd31fc3c3c1855d84f3a2d8ba89bd30d6a690cbebdbc46c66d7cacfa6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 54e583b1c32e270e3acc464512f9e8316167e3a09dd35d9c4bd24717fb489220 [INFO] running `Command { std: "docker" "start" "-a" "54e583b1c32e270e3acc464512f9e8316167e3a09dd35d9c4bd24717fb489220", kill_on_drop: false }` [INFO] [stderr] Compiling target-features v0.1.6 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking array-init-cursor v0.2.1 [INFO] [stderr] Compiling smartstring v1.0.1 [INFO] [stderr] Compiling polars-utils v0.38.3 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Compiling polars-arrow v0.38.3 [INFO] [stderr] Checking raw-cpuid v11.6.0 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking fast-float v0.2.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking atoi_simd v0.15.6 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Checking planus v0.3.1 [INFO] [stderr] Checking streaming-iterator v0.1.9 [INFO] [stderr] Checking ethnum v1.5.2 [INFO] [stderr] Checking foreign_vec v0.1.0 [INFO] [stderr] Compiling litrs v1.0.0 [INFO] [stderr] Compiling polars-compute v0.38.3 [INFO] [stderr] Compiling polars-core v0.38.3 [INFO] [stderr] Compiling polars-ops v0.38.3 [INFO] [stderr] Checking argminmax v0.6.3 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking streaming-decompression v0.1.2 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking memmap2 v0.7.1 [INFO] [stderr] Compiling polars v0.38.3 [INFO] [stderr] Checking parquet-format-safe v0.2.4 [INFO] [stderr] Compiling nalgebra-macros v0.2.2 [INFO] [stderr] Compiling document-features v0.2.12 [INFO] [stderr] Checking numfmt v1.2.0 [INFO] [stderr] Checking strafe-error v0.1.1 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking now v0.1.3 [INFO] [stderr] Compiling hexf-parse v0.2.1 [INFO] [stderr] Checking strafe-consts v0.1.1 [INFO] [stderr] Compiling pathfinder_simd v0.5.5 [INFO] [stderr] Compiling freetype-sys v0.20.1 [INFO] [stderr] Compiling yeslogic-fontconfig-sys v6.0.0 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking dlib v0.5.3 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Compiling font-kit v0.14.3 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking float-ord v0.3.2 [INFO] [stderr] Checking ttf-parser v0.20.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking gif v0.12.0 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking pathfinder_geometry v0.5.1 [INFO] [stderr] Checking safe_arch v0.7.4 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking comfy-table v7.2.2 [INFO] [stderr] Checking wide v0.7.33 [INFO] [stderr] Checking polars-arrow-format v0.1.0 [INFO] [stderr] Checking nonstdfloat v0.1.1 [INFO] [stderr] Checking plotters-bitmap v0.3.7 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking simba v0.8.1 [INFO] [stderr] Compiling multiversion-macros v0.7.4 [INFO] [stderr] Compiling hexf v0.2.1 [INFO] [stderr] Checking polars-error v0.38.3 [INFO] [stderr] Checking multiversion v0.7.4 [INFO] [stderr] Checking nalgebra v0.32.6 [INFO] [stderr] Checking polars-row v0.38.3 [INFO] [stderr] Checking polars-parquet v0.38.3 [INFO] [stderr] Checking polars-time v0.38.3 [INFO] [stderr] Checking polars-io v0.38.3 [INFO] [stderr] Checking strafe-type v0.1.1 [INFO] [stderr] Checking strafe-trait v0.1.1 [INFO] [stderr] Checking r2rs-nmath v0.1.1 [INFO] [stderr] Checking r2rs-base v0.1.1 [INFO] [stderr] Checking strafe-testing v0.1.1 [INFO] [stderr] Checking strafe-distribution v0.1.1 [INFO] [stderr] Checking r2rs-stats v0.1.1 [INFO] [stderr] Checking r2rs-mass v0.1.1 [INFO] [stderr] Checking r2rs-rfit v0.1.1 [INFO] [stderr] Checking strafe-tests v0.1.1 [INFO] [stderr] Checking strafe-plot v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/chart.rs:24:40 [INFO] [stdout] | [INFO] [stdout] 24 | let mut builder = ChartBuilder::on(&root); [INFO] [stdout] | ^^^^^ help: change this to: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/linear_model.rs:74:26 [INFO] [stdout] | [INFO] [stdout] 74 | Ok(x.into_iter().zip(y.into_iter()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 74 - Ok(x.into_iter().zip(y.into_iter()).collect()) [INFO] [stdout] 74 + Ok(x.into_iter().zip(y).collect()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/linear_model.rs:84:6 [INFO] [stdout] | [INFO] [stdout] 84 | ) -> Result>, Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/linear_model.rs:246:51 [INFO] [stdout] | [INFO] [stdout] 246 | let indices = get_xy_sort_indices(&x, &y); [INFO] [stdout] | ^^ help: change this to: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/linear_model.rs:246:55 [INFO] [stdout] | [INFO] [stdout] 246 | let indices = get_xy_sort_indices(&x, &y); [INFO] [stdout] | ^^ help: change this to: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/linear_model.rs:247:33 [INFO] [stdout] | [INFO] [stdout] 247 | sort_by_indices(&mut x, &indices); [INFO] [stdout] | ^^^^^^ help: change this to: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/linear_model.rs:249:33 [INFO] [stdout] | [INFO] [stdout] 249 | sort_by_indices(&mut y, &indices); [INFO] [stdout] | ^^^^^^ help: change this to: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/plot.rs:114:13 [INFO] [stdout] | [INFO] [stdout] 114 | &root, [INFO] [stdout] | ^^^^^ help: change this to: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/plottable/confidence_interval.rs:69:58 [INFO] [stdout] | [INFO] [stdout] 69 | let coords = draw_cis(&xs, &lower_ys, &upper_ys, &drawing_coords)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `drawing_coords` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/plottable/horizontal_line.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | &drawing_coords, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `drawing_coords` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/chart.rs:24:40 [INFO] [stdout] | [INFO] [stdout] 24 | let mut builder = ChartBuilder::on(&root); [INFO] [stdout] | ^^^^^ help: change this to: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/plottable/line.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | &drawing_coords, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `drawing_coords` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/plottable/points.rs:69:44 [INFO] [stdout] | [INFO] [stdout] 69 | let coords = draw_points(&xs, &ys, &drawing_coords)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `drawing_coords` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/plottable/vertical_line.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | &drawing_coords, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `drawing_coords` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/plottable/mod.rs:20:16 [INFO] [stdout] | [INFO] [stdout] 20 | pub lines: Vec<(Vec<(f64, f64)>, u32, RGBColor, Option)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/plottable/mod.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | pub points: Vec<(Vec<(f64, f64)>, u32, RGBColor, Option)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/plottable/mod.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 22 | pub polygons: Vec<(Vec<(f64, f64)>, RGBColor, Option)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/plottable/mod.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | / impl Default for PlottableValues { [INFO] [stdout] 26 | | fn default() -> Self { [INFO] [stdout] 27 | | Self { [INFO] [stdout] 28 | | lines: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 33 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 19 + #[derive(Default)] [INFO] [stdout] 20 | pub struct PlottableValues { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/stem_leaf.rs:165:16 [INFO] [stdout] | [INFO] [stdout] 165 | if !(i < n) { [INFO] [stdout] | ^^^^^^^^ help: try: `(i >= n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/linear_model.rs:74:26 [INFO] [stdout] | [INFO] [stdout] 74 | Ok(x.into_iter().zip(y.into_iter()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 74 - Ok(x.into_iter().zip(y.into_iter()).collect()) [INFO] [stdout] 74 + Ok(x.into_iter().zip(y).collect()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/stem_leaf.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | lo = lo - mu; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `lo -= mu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/linear_model.rs:84:6 [INFO] [stdout] | [INFO] [stdout] 84 | ) -> Result>, Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/linear_model.rs:246:51 [INFO] [stdout] | [INFO] [stdout] 246 | let indices = get_xy_sort_indices(&x, &y); [INFO] [stdout] | ^^ help: change this to: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/linear_model.rs:246:55 [INFO] [stdout] | [INFO] [stdout] 246 | let indices = get_xy_sort_indices(&x, &y); [INFO] [stdout] | ^^ help: change this to: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/linear_model.rs:247:33 [INFO] [stdout] | [INFO] [stdout] 247 | sort_by_indices(&mut x, &indices); [INFO] [stdout] | ^^^^^^ help: change this to: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/linear_model.rs:249:33 [INFO] [stdout] | [INFO] [stdout] 249 | sort_by_indices(&mut y, &indices); [INFO] [stdout] | ^^^^^^ help: change this to: `y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/plot.rs:114:13 [INFO] [stdout] | [INFO] [stdout] 114 | &root, [INFO] [stdout] | ^^^^^ help: change this to: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/plottable/confidence_interval.rs:69:58 [INFO] [stdout] | [INFO] [stdout] 69 | let coords = draw_cis(&xs, &lower_ys, &upper_ys, &drawing_coords)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `drawing_coords` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/plottable/horizontal_line.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | &drawing_coords, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `drawing_coords` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/plottable/line.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | &drawing_coords, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `drawing_coords` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/plottable/points.rs:69:44 [INFO] [stdout] | [INFO] [stdout] 69 | let coords = draw_points(&xs, &ys, &drawing_coords)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `drawing_coords` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/plottable/vertical_line.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | &drawing_coords, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `drawing_coords` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/plottable/mod.rs:20:16 [INFO] [stdout] | [INFO] [stdout] 20 | pub lines: Vec<(Vec<(f64, f64)>, u32, RGBColor, Option)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/plottable/mod.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | pub points: Vec<(Vec<(f64, f64)>, u32, RGBColor, Option)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/plottable/mod.rs:22:19 [INFO] [stdout] | [INFO] [stdout] 22 | pub polygons: Vec<(Vec<(f64, f64)>, RGBColor, Option)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/plottable/mod.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | / impl Default for PlottableValues { [INFO] [stdout] 26 | | fn default() -> Self { [INFO] [stdout] 27 | | Self { [INFO] [stdout] 28 | | lines: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 33 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 19 + #[derive(Default)] [INFO] [stdout] 20 | pub struct PlottableValues { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/stem_leaf.rs:165:16 [INFO] [stdout] | [INFO] [stdout] 165 | if !(i < n) { [INFO] [stdout] | ^^^^^^^^ help: try: `(i >= n)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/stem_leaf.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | lo = lo - mu; [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `lo -= mu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 36.25s [INFO] running `Command { std: "docker" "inspect" "54e583b1c32e270e3acc464512f9e8316167e3a09dd35d9c4bd24717fb489220", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54e583b1c32e270e3acc464512f9e8316167e3a09dd35d9c4bd24717fb489220", kill_on_drop: false }` [INFO] [stdout] 54e583b1c32e270e3acc464512f9e8316167e3a09dd35d9c4bd24717fb489220