[INFO] fetching crate str-concat 0.2.0...
[INFO] linting str-concat-0.2.0 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate str-concat 0.2.0 into /workspace/builds/worker-4-tc1/source
[INFO] started tweaking crates.io crate str-concat 0.2.0
[INFO] finished tweaking crates.io crate str-concat 0.2.0
[INFO] tweaked toml for crates.io crate str-concat 0.2.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate str-concat 0.2.0 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 37eab790d5a660100de9d973bf633a99952fae147659a46207532017c9a995eb
[INFO] running `Command { std: "docker" "start" "-a" "37eab790d5a660100de9d973bf633a99952fae147659a46207532017c9a995eb", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "37eab790d5a660100de9d973bf633a99952fae147659a46207532017c9a995eb", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "37eab790d5a660100de9d973bf633a99952fae147659a46207532017c9a995eb", kill_on_drop: false }`
[INFO] [stdout] 37eab790d5a660100de9d973bf633a99952fae147659a46207532017c9a995eb
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] c1efec26e04e371dbd988017af9f4f132079eb50ef38c31163655c09811185c1
[INFO] running `Command { std: "docker" "start" "-a" "c1efec26e04e371dbd988017af9f4f132079eb50ef38c31163655c09811185c1", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]     Checking str-concat v0.2.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:165:8
[INFO] [stdout]     |
[INFO] [stdout] 165 |     if !(new_len <= max_len) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^ help: try: `(new_len > max_len)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of a legacy numeric method
[INFO] [stdout]    --> src/lib.rs:142:19
[INFO] [stdout]     |
[INFO] [stdout] 142 |     let max_len = isize::max_value() as usize / mem::size_of::<T>();
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout]     = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
[INFO] [stdout] help: use the associated constant instead
[INFO] [stdout]     |
[INFO] [stdout] 142 -     let max_len = isize::max_value() as usize / mem::size_of::<T>();
[INFO] [stdout] 142 +     let max_len = isize::MAX as usize / mem::size_of::<T>();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stdout]    --> src/lib.rs:154:8
[INFO] [stdout]     |
[INFO] [stdout] 154 |     if a_ptr.offset(a_len as isize) != b_ptr {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stdout]     = note: `#[warn(clippy::ptr_offset_with_cast)]` on by default
[INFO] [stdout] help: use `add` instead
[INFO] [stdout]     |
[INFO] [stdout] 154 -     if a_ptr.offset(a_len as isize) != b_ptr {
[INFO] [stdout] 154 +     if a_ptr.add(a_len) != b_ptr {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual slice size calculation
[INFO] [stdout]    --> src/lib.rs:272:29
[INFO] [stdout]     |
[INFO] [stdout] 272 |     let a_end_ptr = a_ptr + a.len() * mem::size_of::<T>();
[INFO] [stdout]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `core::mem::size_of_val(a)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation
[INFO] [stdout]     = note: `#[warn(clippy::manual_slice_size_calculation)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:165:8
[INFO] [stdout]     |
[INFO] [stdout] 165 |     if !(new_len <= max_len) {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^ help: try: `(new_len > max_len)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of a legacy numeric method
[INFO] [stdout]    --> src/lib.rs:142:19
[INFO] [stdout]     |
[INFO] [stdout] 142 |     let max_len = isize::max_value() as usize / mem::size_of::<T>();
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
[INFO] [stdout]     = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
[INFO] [stdout] help: use the associated constant instead
[INFO] [stdout]     |
[INFO] [stdout] 142 -     let max_len = isize::max_value() as usize / mem::size_of::<T>();
[INFO] [stdout] 142 +     let max_len = isize::MAX as usize / mem::size_of::<T>();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of `offset` with a `usize` casted to an `isize`
[INFO] [stdout]    --> src/lib.rs:154:8
[INFO] [stdout]     |
[INFO] [stdout] 154 |     if a_ptr.offset(a_len as isize) != b_ptr {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast
[INFO] [stdout]     = note: `#[warn(clippy::ptr_offset_with_cast)]` on by default
[INFO] [stdout] help: use `add` instead
[INFO] [stdout]     |
[INFO] [stdout] 154 -     if a_ptr.offset(a_len as isize) != b_ptr {
[INFO] [stdout] 154 +     if a_ptr.add(a_len) != b_ptr {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual slice size calculation
[INFO] [stdout]    --> src/lib.rs:272:29
[INFO] [stdout]     |
[INFO] [stdout] 272 |     let a_end_ptr = a_ptr + a.len() * mem::size_of::<T>();
[INFO] [stdout]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `core::mem::size_of_val(a)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation
[INFO] [stdout]     = note: `#[warn(clippy::manual_slice_size_calculation)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.18s
[INFO] running `Command { std: "docker" "inspect" "c1efec26e04e371dbd988017af9f4f132079eb50ef38c31163655c09811185c1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "c1efec26e04e371dbd988017af9f4f132079eb50ef38c31163655c09811185c1", kill_on_drop: false }`
[INFO] [stdout] c1efec26e04e371dbd988017af9f4f132079eb50ef38c31163655c09811185c1