[INFO] fetching crate stout 0.2.0... [INFO] linting stout-0.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate stout 0.2.0 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate stout 0.2.0 [INFO] finished tweaking crates.io crate stout 0.2.0 [INFO] tweaked toml for crates.io crate stout 0.2.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate stout 0.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate stout 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded stout-cask v0.2.0 [INFO] [stderr] Downloaded zerocopy v0.8.34 [INFO] [stderr] Downloaded stout-install v0.2.0 [INFO] [stderr] Downloaded stout-audit v0.2.0 [INFO] [stderr] Downloaded stout-fetch v0.2.0 [INFO] [stderr] Downloaded stout-state v0.2.0 [INFO] [stderr] Downloaded stout-mirror v0.2.0 [INFO] [stderr] Downloaded stout-resolve v0.2.0 [INFO] [stderr] Downloaded stout-index v0.2.0 [INFO] [stderr] Downloaded zerocopy-derive v0.8.34 [INFO] [stderr] Downloaded stout-bundle v0.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7d9c817d69254fc66d01c76d9a3c5b6cf28c341f30059b582c21517c893d3a0e [INFO] running `Command { std: "docker" "start" "-a" "7d9c817d69254fc66d01c76d9a3c5b6cf28c341f30059b582c21517c893d3a0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7d9c817d69254fc66d01c76d9a3c5b6cf28c341f30059b582c21517c893d3a0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d9c817d69254fc66d01c76d9a3c5b6cf28c341f30059b582c21517c893d3a0e", kill_on_drop: false }` [INFO] [stdout] 7d9c817d69254fc66d01c76d9a3c5b6cf28c341f30059b582c21517c893d3a0e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a9aa36f48852e65621ddf3fda5a7886b67be8373bc0530fb2cf7a25deb377a09 [INFO] running `Command { std: "docker" "start" "-a" "a9aa36f48852e65621ddf3fda5a7886b67be8373bc0530fb2cf7a25deb377a09", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.2.54 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking flate2 v1.1.8 [INFO] [stderr] Compiling zerocopy v0.8.34 [INFO] [stderr] Checking compression-core v0.4.31 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking webpki-roots v1.0.5 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Checking curve25519-dalek v4.1.3 [INFO] [stderr] Compiling utf8parse v0.2.2 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling colorchoice v1.0.4 [INFO] [stderr] Compiling anstyle-parse v0.2.7 [INFO] [stderr] Compiling is_terminal_polyfill v1.70.2 [INFO] [stderr] Compiling anstyle-query v1.1.5 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Compiling anstyle v1.0.13 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Compiling clap_lex v0.7.7 [INFO] [stderr] Checking xattr v1.6.1 [INFO] [stderr] Checking filetime v0.2.27 [INFO] [stderr] Compiling roff v0.2.2 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Compiling anstream v0.6.21 [INFO] [stderr] Checking tar v0.4.44 [INFO] [stderr] Checking compression-codecs v0.4.36 [INFO] [stderr] Checking http-range-header v0.4.2 [INFO] [stderr] Checking clap_builder v4.5.54 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Checking clap v4.5.54 [INFO] [stderr] Checking clap_complete v4.5.65 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking axum-core v0.4.5 [INFO] [stderr] Compiling clap_mangen v0.2.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Compiling stout v0.2.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> build.rs:533:14 [INFO] [stdout] | [INFO] [stdout] 533 | .expect(&format!("Failed to render man page for {}", name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to render man page for {}", name))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> build.rs:535:14 [INFO] [stdout] | [INFO] [stdout] 535 | .expect(&format!("Failed to write stout-{}.1", name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to write stout-{}.1", name))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking async-compression v0.4.37 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking tower-http v0.5.2 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking axum v0.7.9 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking stout-fetch v0.2.0 [INFO] [stderr] Checking rusqlite v0.32.1 [INFO] [stderr] Checking stout-index v0.2.0 [INFO] [stderr] Checking stout-state v0.2.0 [INFO] [stderr] Checking stout-resolve v0.2.0 [INFO] [stderr] Checking stout-audit v0.2.0 [INFO] [stderr] Checking stout-install v0.2.0 [INFO] [stderr] Checking stout-mirror v0.2.0 [INFO] [stderr] Checking stout-cask v0.2.0 [INFO] [stderr] Checking stout-bundle v0.2.0 [INFO] [stdout] warning: unused import: `HashMap` [INFO] [stdout] --> src/cli/deps.rs:9:24 [INFO] [stdout] | [INFO] [stdout] 9 | use std::collections::{HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bail` [INFO] [stdout] --> src/cli/history.rs:3:14 [INFO] [stdout] | [INFO] [stdout] 3 | use anyhow::{bail, Result}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HashMap` [INFO] [stdout] --> src/cli/deps.rs:9:24 [INFO] [stdout] | [INFO] [stdout] 9 | use std::collections::{HashMap, HashSet}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `MirrorClientConfig` and `MirrorClient` [INFO] [stdout] --> src/cli/mirror.rs:7:51 [INFO] [stdout] | [INFO] [stdout] 7 | create_mirror, detect_platform, serve_mirror, MirrorClient, MirrorClientConfig, MirrorConfig, [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bail` [INFO] [stdout] --> src/cli/history.rs:3:14 [INFO] [stdout] | [INFO] [stdout] 3 | use anyhow::{bail, Result}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bail` [INFO] [stdout] --> src/cli/pin.rs:3:14 [INFO] [stdout] | [INFO] [stdout] 3 | use anyhow::{bail, Result}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Database` and `IndexSync` [INFO] [stdout] --> src/cli/rollback.rs:4:19 [INFO] [stdout] | [INFO] [stdout] 4 | use stout_index::{Database, IndexSync}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `MirrorClientConfig` and `MirrorClient` [INFO] [stdout] --> src/cli/mirror.rs:7:51 [INFO] [stdout] | [INFO] [stdout] 7 | create_mirror, detect_platform, serve_mirror, MirrorClient, MirrorClientConfig, MirrorConfig, [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bail` [INFO] [stdout] --> src/cli/pin.rs:3:14 [INFO] [stdout] | [INFO] [stdout] 3 | use anyhow::{bail, Result}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Database` and `IndexSync` [INFO] [stdout] --> src/cli/rollback.rs:4:19 [INFO] [stdout] | [INFO] [stdout] 4 | use stout_index::{Database, IndexSync}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Context` [INFO] [stdout] --> src/cli/tap.rs:3:20 [INFO] [stdout] | [INFO] [stdout] 3 | use anyhow::{bail, Context, Result}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Config` [INFO] [stdout] --> src/cli/tap.rs:4:19 [INFO] [stdout] | [INFO] [stdout] 4 | use stout_state::{Config, Paths, Tap, TapManager}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `remove_package` [INFO] [stdout] --> src/cli/uninstall.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use stout_install::{remove_package, unlink_package}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `IndexSync` [INFO] [stdout] --> src/cli/why.rs:4:29 [INFO] [stdout] | [INFO] [stdout] 4 | use stout_index::{Database, IndexSync}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Context` [INFO] [stdout] --> src/cli/tap.rs:3:20 [INFO] [stdout] | [INFO] [stdout] 3 | use anyhow::{bail, Context, Result}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Config` [INFO] [stdout] --> src/cli/tap.rs:4:19 [INFO] [stdout] | [INFO] [stdout] 4 | use stout_state::{Config, Paths, Tap, TapManager}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `remove_package` [INFO] [stdout] --> src/cli/uninstall.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | use stout_install::{remove_package, unlink_package}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `IndexSync` [INFO] [stdout] --> src/cli/why.rs:4:29 [INFO] [stdout] | [INFO] [stdout] 4 | use stout_index::{Database, IndexSync}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cli/bundle.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | let mut installed_formulas = InstalledPackages::load(&paths)?; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cli/bundle.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | let mut installed_formulas = InstalledPackages::load(&paths)?; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `printed` is assigned to, but never used [INFO] [stdout] --> src/cli/audit.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | let mut printed = 0; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_printed` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `printed` is never read [INFO] [stdout] --> src/cli/audit.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | printed += 1; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `version` [INFO] [stdout] --> src/cli/create.rs:305:5 [INFO] [stdout] | [INFO] [stdout] 305 | version: &str, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_version` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/cli/history.rs:167:16 [INFO] [stdout] | [INFO] [stdout] 167 | fn print_entry(name: &str, entry: &stout_state::HistoryEntry) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `db` [INFO] [stdout] --> src/cli/info.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | db: &Database, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_db` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `paths` [INFO] [stdout] --> src/cli/info.rs:175:5 [INFO] [stdout] | [INFO] [stdout] 175 | paths: &Paths, [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_paths` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `printed` is assigned to, but never used [INFO] [stdout] --> src/cli/audit.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | let mut printed = 0; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_printed` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `printed` is never read [INFO] [stdout] --> src/cli/audit.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | printed += 1; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/cli/rollback.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | let config = Config::load(&paths)?; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `homebrew_dir` [INFO] [stdout] --> src/cli/services.rs:322:9 [INFO] [stdout] | [INFO] [stdout] 322 | let homebrew_dir = install_path.join("homebrew.mxcl.*.plist"); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_homebrew_dir` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/cli/services.rs:364:23 [INFO] [stdout] | [INFO] [stdout] 364 | fn get_service_status(name: &str) -> ServiceStatus { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `line` [INFO] [stdout] --> src/cli/test.rs:226:33 [INFO] [stdout] | [INFO] [stdout] 226 | if let Some(line) = stdout.lines().next() { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_line` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/cli/why.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | let config = Config::load(&paths)?; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `version` [INFO] [stdout] --> src/cli/create.rs:305:5 [INFO] [stdout] | [INFO] [stdout] 305 | version: &str, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_version` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/cli/history.rs:167:16 [INFO] [stdout] | [INFO] [stdout] 167 | fn print_entry(name: &str, entry: &stout_state::HistoryEntry) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `db` [INFO] [stdout] --> src/cli/info.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | db: &Database, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_db` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `paths` [INFO] [stdout] --> src/cli/info.rs:175:5 [INFO] [stdout] | [INFO] [stdout] 175 | paths: &Paths, [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_paths` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `record_event` is never used [INFO] [stdout] --> src/cli/analytics.rs:136:14 [INFO] [stdout] | [INFO] [stdout] 136 | pub async fn record_event(event_type: &str, data: &str) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Stopped` and `Error` are never constructed [INFO] [stdout] --> src/cli/services.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 59 | enum ServiceStatus { [INFO] [stdout] | ------------- variants in this enum [INFO] [stdout] 60 | Running, [INFO] [stdout] 61 | Stopped, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 62 | Error, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ServiceStatus` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `success` is never used [INFO] [stdout] --> src/output.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn success() -> Style { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `error` is never used [INFO] [stdout] --> src/output.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn error() -> Style { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `warning` is never used [INFO] [stdout] --> src/output.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn warning() -> Style { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `info` is never used [INFO] [stdout] --> src/output.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn info() -> Style { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `muted` is never used [INFO] [stdout] --> src/output.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn muted() -> Style { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `package` is never used [INFO] [stdout] --> src/output.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn package(name: &str) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `version` is never used [INFO] [stdout] --> src/output.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn version(ver: &str) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `fatal` is never used [INFO] [stdout] --> src/output.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn fatal(msg: &str) -> ! { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/cli/bundle.rs:137:37 [INFO] [stdout] | [INFO] [stdout] 137 | async fn run_install(brewfile_path: &PathBuf, args: InstallArgs) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 137 - async fn run_install(brewfile_path: &PathBuf, args: InstallArgs) -> Result<()> { [INFO] [stdout] 137 + async fn run_install(brewfile_path: &Path, args: InstallArgs) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/cli/rollback.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | let config = Config::load(&paths)?; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/cli/bundle.rs:367:35 [INFO] [stdout] | [INFO] [stdout] 367 | async fn run_check(brewfile_path: &PathBuf, args: CheckArgs) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 367 - async fn run_check(brewfile_path: &PathBuf, args: CheckArgs) -> Result<()> { [INFO] [stdout] 367 + async fn run_check(brewfile_path: &Path, args: CheckArgs) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cli/bundle.rs:400:5 [INFO] [stdout] | [INFO] [stdout] 400 | / if args.verbose || !missing_formulas.is_empty() { [INFO] [stdout] 401 | | if !missing_formulas.is_empty() { [INFO] [stdout] 402 | | println!("{}:", style("Missing formulas").yellow()); [INFO] [stdout] 403 | | for name in &missing_formulas { [INFO] [stdout] ... | [INFO] [stdout] 407 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 400 ~ if (args.verbose || !missing_formulas.is_empty()) { [INFO] [stdout] 401 ~ && !missing_formulas.is_empty() { [INFO] [stdout] 402 | println!("{}:", style("Missing formulas").yellow()); [INFO] [stdout] ... [INFO] [stdout] 405 | } [INFO] [stdout] 406 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cli/bundle.rs:409:5 [INFO] [stdout] | [INFO] [stdout] 409 | / if args.verbose || !missing_casks.is_empty() { [INFO] [stdout] 410 | | if !missing_casks.is_empty() { [INFO] [stdout] 411 | | println!("{}:", style("Missing casks").yellow()); [INFO] [stdout] 412 | | for name in &missing_casks { [INFO] [stdout] ... | [INFO] [stdout] 416 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 409 ~ if (args.verbose || !missing_casks.is_empty()) { [INFO] [stdout] 410 ~ && !missing_casks.is_empty() { [INFO] [stdout] 411 | println!("{}:", style("Missing casks").yellow()); [INFO] [stdout] ... [INFO] [stdout] 414 | } [INFO] [stdout] 415 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/cli/bundle.rs:429:34 [INFO] [stdout] | [INFO] [stdout] 429 | async fn run_list(brewfile_path: &PathBuf, args: ListArgs) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 429 - async fn run_list(brewfile_path: &PathBuf, args: ListArgs) -> Result<()> { [INFO] [stdout] 429 + async fn run_list(brewfile_path: &Path, args: ListArgs) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cli/bundle.rs:440:5 [INFO] [stdout] | [INFO] [stdout] 440 | / if show_all || filter_type == Some("tap") { [INFO] [stdout] 441 | | if !brewfile.taps.is_empty() { [INFO] [stdout] 442 | | println!("{}:", style("Taps").bold()); [INFO] [stdout] 443 | | for tap in &brewfile.taps { [INFO] [stdout] ... | [INFO] [stdout] 448 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 440 ~ if (show_all || filter_type == Some("tap")) { [INFO] [stdout] 441 ~ && !brewfile.taps.is_empty() { [INFO] [stdout] 442 | println!("{}:", style("Taps").bold()); [INFO] [stdout] ... [INFO] [stdout] 446 | println!(); [INFO] [stdout] 447 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cli/bundle.rs:450:5 [INFO] [stdout] | [INFO] [stdout] 450 | / if show_all || filter_type == Some("brew") { [INFO] [stdout] 451 | | if !brewfile.brews.is_empty() { [INFO] [stdout] 452 | | println!("{}:", style("Formulas").bold()); [INFO] [stdout] 453 | | for brew in &brewfile.brews { [INFO] [stdout] ... | [INFO] [stdout] 458 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 450 ~ if (show_all || filter_type == Some("brew")) { [INFO] [stdout] 451 ~ && !brewfile.brews.is_empty() { [INFO] [stdout] 452 | println!("{}:", style("Formulas").bold()); [INFO] [stdout] ... [INFO] [stdout] 456 | println!(); [INFO] [stdout] 457 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cli/bundle.rs:460:5 [INFO] [stdout] | [INFO] [stdout] 460 | / if show_all || filter_type == Some("cask") { [INFO] [stdout] 461 | | if !brewfile.casks.is_empty() { [INFO] [stdout] 462 | | println!("{}:", style("Casks").bold()); [INFO] [stdout] 463 | | for cask in &brewfile.casks { [INFO] [stdout] ... | [INFO] [stdout] 468 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 460 ~ if (show_all || filter_type == Some("cask")) { [INFO] [stdout] 461 ~ && !brewfile.casks.is_empty() { [INFO] [stdout] 462 | println!("{}:", style("Casks").bold()); [INFO] [stdout] ... [INFO] [stdout] 466 | println!(); [INFO] [stdout] 467 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cli/bundle.rs:470:5 [INFO] [stdout] | [INFO] [stdout] 470 | / if show_all || filter_type == Some("mas") { [INFO] [stdout] 471 | | if !brewfile.mas.is_empty() { [INFO] [stdout] 472 | | println!("{}:", style("Mac App Store").bold()); [INFO] [stdout] 473 | | for mas in &brewfile.mas { [INFO] [stdout] ... | [INFO] [stdout] 478 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 470 ~ if (show_all || filter_type == Some("mas")) { [INFO] [stdout] 471 ~ && !brewfile.mas.is_empty() { [INFO] [stdout] 472 | println!("{}:", style("Mac App Store").bold()); [INFO] [stdout] ... [INFO] [stdout] 476 | println!(); [INFO] [stdout] 477 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/cli/bundle.rs:483:37 [INFO] [stdout] | [INFO] [stdout] 483 | async fn run_cleanup(brewfile_path: &PathBuf, args: CleanupArgs) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 483 - async fn run_cleanup(brewfile_path: &PathBuf, args: CleanupArgs) -> Result<()> { [INFO] [stdout] 483 + async fn run_cleanup(brewfile_path: &Path, args: CleanupArgs) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `homebrew_dir` [INFO] [stdout] --> src/cli/services.rs:322:9 [INFO] [stdout] | [INFO] [stdout] 322 | let homebrew_dir = install_path.join("homebrew.mxcl.*.plist"); [INFO] [stdout] | ^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_homebrew_dir` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/cli/services.rs:364:23 [INFO] [stdout] | [INFO] [stdout] 364 | fn get_service_status(name: &str) -> ServiceStatus { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `line` [INFO] [stdout] --> src/cli/test.rs:226:33 [INFO] [stdout] | [INFO] [stdout] 226 | if let Some(line) = stdout.lines().next() { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_line` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/config.rs:19:22 [INFO] [stdout] | [INFO] [stdout] 19 | println!(" {}", "https://github.com/neul-labs/stout"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 - println!(" {}", "https://github.com/neul-labs/stout"); [INFO] [stdout] 19 + println!(" https://github.com/neul-labs/stout"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/config.rs:94:49 [INFO] [stdout] | [INFO] [stdout] 94 | println!(" {} {}", style("✓").green(), "Unsigned indexes blocked"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 94 - println!(" {} {}", style("✓").green(), "Unsigned indexes blocked"); [INFO] [stdout] 94 + println!(" {} Unsigned indexes blocked", style("✓").green()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/cli/create.rs:214:46 [INFO] [stdout] | [INFO] [stdout] 214 | let name = if let Some(idx) = name.rfind(|c: char| c == '-' || c == '_') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['-', '_']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `config` [INFO] [stdout] --> src/cli/why.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | let config = Config::load(&paths)?; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_config` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/cli/create.rs:383:37 [INFO] [stdout] | [INFO] [stdout] 383 | } else if url.ends_with(".zip") { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 384 | | "app" [INFO] [stdout] 385 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/cli/create.rs:385:12 [INFO] [stdout] | [INFO] [stdout] 385 | } else { [INFO] [stdout] | ____________^ [INFO] [stdout] 386 | | "app" [INFO] [stdout] 387 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/cli/create.rs:433:16 [INFO] [stdout] | [INFO] [stdout] 433 | name.split(|c| c == '-' || c == '_') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['-', '_']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/cli/deps.rs:257:62 [INFO] [stdout] | [INFO] [stdout] 257 | let subdeps: Vec = formula.runtime_deps().iter().cloned().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/cli/deps.rs:340:66 [INFO] [stdout] | [INFO] [stdout] 340 | let subdeps: Vec = formula.runtime_deps().iter().cloned().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/cli/deps.rs:376:66 [INFO] [stdout] | [INFO] [stdout] 376 | let subdeps: Vec = formula.runtime_deps().iter().cloned().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/history.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | "" [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 194 ~ " {} {} {} {}", [INFO] [stdout] 195 | style(&entry.timestamp).dim(), [INFO] [stdout] 196 | action_style, [INFO] [stdout] 197 | style(&version_str).white().bold(), [INFO] [stdout] 198 ~ style(&from_str).dim() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/info.rs:226:36 [INFO] [stdout] | [INFO] [stdout] 226 | println!(" {} {} {}", "├──", dep, style("(formula)").dim()); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 226 - println!(" {} {} {}", "├──", dep, style("(formula)").dim()); [INFO] [stdout] 226 + println!(" ├── {} {}", dep, style("(formula)").dim()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Stopped` and `Error` are never constructed [INFO] [stdout] --> src/cli/services.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 59 | enum ServiceStatus { [INFO] [stdout] | ------------- variants in this enum [INFO] [stdout] 60 | Running, [INFO] [stdout] 61 | Stopped, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 62 | Error, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ServiceStatus` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `success` is never used [INFO] [stdout] --> src/output.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn success() -> Style { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `error` is never used [INFO] [stdout] --> src/output.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn error() -> Style { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `warning` is never used [INFO] [stdout] --> src/output.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn warning() -> Style { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `info` is never used [INFO] [stdout] --> src/output.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn info() -> Style { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `muted` is never used [INFO] [stdout] --> src/output.rs:26:8 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn muted() -> Style { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `package` is never used [INFO] [stdout] --> src/output.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn package(name: &str) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `version` is never used [INFO] [stdout] --> src/output.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn version(ver: &str) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `fatal` is never used [INFO] [stdout] --> src/output.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn fatal(msg: &str) -> ! { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/cli/mirror.rs:224:1 [INFO] [stdout] | [INFO] [stdout] 224 | / async fn run_create( [INFO] [stdout] 225 | | output: PathBuf, [INFO] [stdout] 226 | | packages: Vec, [INFO] [stdout] 227 | | all_installed: bool, [INFO] [stdout] ... | [INFO] [stdout] 234 | | dry_run: bool, [INFO] [stdout] 235 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/cli/mirror.rs:486:41 [INFO] [stdout] | [INFO] [stdout] 486 | let latest = db.get_formula(*name)?; [INFO] [stdout] | ^^^^^ help: try: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli/prefix.rs:95:19 [INFO] [stdout] | [INFO] [stdout] 95 | } else if !path.read_dir()?.next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `path.read_dir()?.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/cli/bundle.rs:137:37 [INFO] [stdout] | [INFO] [stdout] 137 | async fn run_install(brewfile_path: &PathBuf, args: InstallArgs) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 137 - async fn run_install(brewfile_path: &PathBuf, args: InstallArgs) -> Result<()> { [INFO] [stdout] 137 + async fn run_install(brewfile_path: &Path, args: InstallArgs) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/cli/bundle.rs:367:35 [INFO] [stdout] | [INFO] [stdout] 367 | async fn run_check(brewfile_path: &PathBuf, args: CheckArgs) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 367 - async fn run_check(brewfile_path: &PathBuf, args: CheckArgs) -> Result<()> { [INFO] [stdout] 367 + async fn run_check(brewfile_path: &Path, args: CheckArgs) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cli/bundle.rs:400:5 [INFO] [stdout] | [INFO] [stdout] 400 | / if args.verbose || !missing_formulas.is_empty() { [INFO] [stdout] 401 | | if !missing_formulas.is_empty() { [INFO] [stdout] 402 | | println!("{}:", style("Missing formulas").yellow()); [INFO] [stdout] 403 | | for name in &missing_formulas { [INFO] [stdout] ... | [INFO] [stdout] 407 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 400 ~ if (args.verbose || !missing_formulas.is_empty()) { [INFO] [stdout] 401 ~ && !missing_formulas.is_empty() { [INFO] [stdout] 402 | println!("{}:", style("Missing formulas").yellow()); [INFO] [stdout] ... [INFO] [stdout] 405 | } [INFO] [stdout] 406 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cli/bundle.rs:409:5 [INFO] [stdout] | [INFO] [stdout] 409 | / if args.verbose || !missing_casks.is_empty() { [INFO] [stdout] 410 | | if !missing_casks.is_empty() { [INFO] [stdout] 411 | | println!("{}:", style("Missing casks").yellow()); [INFO] [stdout] 412 | | for name in &missing_casks { [INFO] [stdout] ... | [INFO] [stdout] 416 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 409 ~ if (args.verbose || !missing_casks.is_empty()) { [INFO] [stdout] 410 ~ && !missing_casks.is_empty() { [INFO] [stdout] 411 | println!("{}:", style("Missing casks").yellow()); [INFO] [stdout] ... [INFO] [stdout] 414 | } [INFO] [stdout] 415 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/cli/bundle.rs:429:34 [INFO] [stdout] | [INFO] [stdout] 429 | async fn run_list(brewfile_path: &PathBuf, args: ListArgs) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 429 - async fn run_list(brewfile_path: &PathBuf, args: ListArgs) -> Result<()> { [INFO] [stdout] 429 + async fn run_list(brewfile_path: &Path, args: ListArgs) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cli/bundle.rs:440:5 [INFO] [stdout] | [INFO] [stdout] 440 | / if show_all || filter_type == Some("tap") { [INFO] [stdout] 441 | | if !brewfile.taps.is_empty() { [INFO] [stdout] 442 | | println!("{}:", style("Taps").bold()); [INFO] [stdout] 443 | | for tap in &brewfile.taps { [INFO] [stdout] ... | [INFO] [stdout] 448 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 440 ~ if (show_all || filter_type == Some("tap")) { [INFO] [stdout] 441 ~ && !brewfile.taps.is_empty() { [INFO] [stdout] 442 | println!("{}:", style("Taps").bold()); [INFO] [stdout] ... [INFO] [stdout] 446 | println!(); [INFO] [stdout] 447 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cli/bundle.rs:450:5 [INFO] [stdout] | [INFO] [stdout] 450 | / if show_all || filter_type == Some("brew") { [INFO] [stdout] 451 | | if !brewfile.brews.is_empty() { [INFO] [stdout] 452 | | println!("{}:", style("Formulas").bold()); [INFO] [stdout] 453 | | for brew in &brewfile.brews { [INFO] [stdout] ... | [INFO] [stdout] 458 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 450 ~ if (show_all || filter_type == Some("brew")) { [INFO] [stdout] 451 ~ && !brewfile.brews.is_empty() { [INFO] [stdout] 452 | println!("{}:", style("Formulas").bold()); [INFO] [stdout] ... [INFO] [stdout] 456 | println!(); [INFO] [stdout] 457 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cli/bundle.rs:460:5 [INFO] [stdout] | [INFO] [stdout] 460 | / if show_all || filter_type == Some("cask") { [INFO] [stdout] 461 | | if !brewfile.casks.is_empty() { [INFO] [stdout] 462 | | println!("{}:", style("Casks").bold()); [INFO] [stdout] 463 | | for cask in &brewfile.casks { [INFO] [stdout] ... | [INFO] [stdout] 468 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 460 ~ if (show_all || filter_type == Some("cask")) { [INFO] [stdout] 461 ~ && !brewfile.casks.is_empty() { [INFO] [stdout] 462 | println!("{}:", style("Casks").bold()); [INFO] [stdout] ... [INFO] [stdout] 466 | println!(); [INFO] [stdout] 467 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cli/bundle.rs:470:5 [INFO] [stdout] | [INFO] [stdout] 470 | / if show_all || filter_type == Some("mas") { [INFO] [stdout] 471 | | if !brewfile.mas.is_empty() { [INFO] [stdout] 472 | | println!("{}:", style("Mac App Store").bold()); [INFO] [stdout] 473 | | for mas in &brewfile.mas { [INFO] [stdout] ... | [INFO] [stdout] 478 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 470 ~ if (show_all || filter_type == Some("mas")) { [INFO] [stdout] 471 ~ && !brewfile.mas.is_empty() { [INFO] [stdout] 472 | println!("{}:", style("Mac App Store").bold()); [INFO] [stdout] ... [INFO] [stdout] 476 | println!(); [INFO] [stdout] 477 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/cli/bundle.rs:483:37 [INFO] [stdout] | [INFO] [stdout] 483 | async fn run_cleanup(brewfile_path: &PathBuf, args: CleanupArgs) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 483 - async fn run_cleanup(brewfile_path: &PathBuf, args: CleanupArgs) -> Result<()> { [INFO] [stdout] 483 + async fn run_cleanup(brewfile_path: &Path, args: CleanupArgs) -> Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/services.rs:294:60 [INFO] [stdout] | [INFO] [stdout] 294 | println!(" {}: {}", style("Service files").dim(), "none"); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 294 - println!(" {}: {}", style("Service files").dim(), "none"); [INFO] [stdout] 294 + println!(" {}: none", style("Service files").dim()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/cli/services.rs:351:26 [INFO] [stdout] | [INFO] [stdout] 351 | let suffix = &pattern[1..]; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/cli/services.rs:350:9 [INFO] [stdout] | [INFO] [stdout] 350 | if pattern.starts_with('*') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 350 ~ if let Some(suffix) = pattern.strip_prefix('*') { [INFO] [stdout] 351 ~ if name.ends_with(suffix) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/config.rs:19:22 [INFO] [stdout] | [INFO] [stdout] 19 | println!(" {}", "https://github.com/neul-labs/stout"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 - println!(" {}", "https://github.com/neul-labs/stout"); [INFO] [stdout] 19 + println!(" https://github.com/neul-labs/stout"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/config.rs:94:49 [INFO] [stdout] | [INFO] [stdout] 94 | println!(" {} {}", style("✓").green(), "Unsigned indexes blocked"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 94 - println!(" {} {}", style("✓").green(), "Unsigned indexes blocked"); [INFO] [stdout] 94 + println!(" {} Unsigned indexes blocked", style("✓").green()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `result` after checking its variant with `is_ok` [INFO] [stdout] --> src/cli/test.rs:144:29 [INFO] [stdout] | [INFO] [stdout] 127 | if result.is_ok() { [INFO] [stdout] | ----------------- help: try: `if let Err() = result` [INFO] [stdout] ... [INFO] [stdout] 144 | result.unwrap_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/cli/create.rs:214:46 [INFO] [stdout] | [INFO] [stdout] 214 | let name = if let Some(idx) = name.rfind(|c: char| c == '-' || c == '_') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['-', '_']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/cli/create.rs:383:37 [INFO] [stdout] | [INFO] [stdout] 383 | } else if url.ends_with(".zip") { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 384 | | "app" [INFO] [stdout] 385 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/cli/create.rs:385:12 [INFO] [stdout] | [INFO] [stdout] 385 | } else { [INFO] [stdout] | ____________^ [INFO] [stdout] 386 | | "app" [INFO] [stdout] 387 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/cli/create.rs:433:16 [INFO] [stdout] | [INFO] [stdout] 433 | name.split(|c| c == '-' || c == '_') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['-', '_']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/cli/deps.rs:257:62 [INFO] [stdout] | [INFO] [stdout] 257 | let subdeps: Vec = formula.runtime_deps().iter().cloned().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] = note: `#[warn(clippy::iter_cloned_collect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/cli/deps.rs:340:66 [INFO] [stdout] | [INFO] [stdout] 340 | let subdeps: Vec = formula.runtime_deps().iter().cloned().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `iter().cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stdout] --> src/cli/deps.rs:376:66 [INFO] [stdout] | [INFO] [stdout] 376 | let subdeps: Vec = formula.runtime_deps().iter().cloned().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.to_vec()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/history.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | "" [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 194 ~ " {} {} {} {}", [INFO] [stdout] 195 | style(&entry.timestamp).dim(), [INFO] [stdout] 196 | action_style, [INFO] [stdout] 197 | style(&version_str).white().bold(), [INFO] [stdout] 198 ~ style(&from_str).dim() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/info.rs:226:36 [INFO] [stdout] | [INFO] [stdout] 226 | println!(" {} {} {}", "├──", dep, style("(formula)").dim()); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 226 - println!(" {} {} {}", "├──", dep, style("(formula)").dim()); [INFO] [stdout] 226 + println!(" ├── {} {}", dep, style("(formula)").dim()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/cli/mirror.rs:224:1 [INFO] [stdout] | [INFO] [stdout] 224 | / async fn run_create( [INFO] [stdout] 225 | | output: PathBuf, [INFO] [stdout] 226 | | packages: Vec, [INFO] [stdout] 227 | | all_installed: bool, [INFO] [stdout] ... | [INFO] [stdout] 234 | | dry_run: bool, [INFO] [stdout] 235 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/cli/mirror.rs:486:41 [INFO] [stdout] | [INFO] [stdout] 486 | let latest = db.get_formula(*name)?; [INFO] [stdout] | ^^^^^ help: try: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli/prefix.rs:95:19 [INFO] [stdout] | [INFO] [stdout] 95 | } else if !path.read_dir()?.next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `path.read_dir()?.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/cli/services.rs:294:60 [INFO] [stdout] | [INFO] [stdout] 294 | println!(" {}: {}", style("Service files").dim(), "none"); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 294 - println!(" {}: {}", style("Service files").dim(), "none"); [INFO] [stdout] 294 + println!(" {}: none", style("Service files").dim()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/cli/services.rs:351:26 [INFO] [stdout] | [INFO] [stdout] 351 | let suffix = &pattern[1..]; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/cli/services.rs:350:9 [INFO] [stdout] | [INFO] [stdout] 350 | if pattern.starts_with('*') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 350 ~ if let Some(suffix) = pattern.strip_prefix('*') { [INFO] [stdout] 351 ~ if name.ends_with(suffix) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `result` after checking its variant with `is_ok` [INFO] [stdout] --> src/cli/test.rs:144:29 [INFO] [stdout] | [INFO] [stdout] 127 | if result.is_ok() { [INFO] [stdout] | ----------------- help: try: `if let Err() = result` [INFO] [stdout] ... [INFO] [stdout] 144 | result.unwrap_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 40.40s [INFO] running `Command { std: "docker" "inspect" "a9aa36f48852e65621ddf3fda5a7886b67be8373bc0530fb2cf7a25deb377a09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9aa36f48852e65621ddf3fda5a7886b67be8373bc0530fb2cf7a25deb377a09", kill_on_drop: false }` [INFO] [stdout] a9aa36f48852e65621ddf3fda5a7886b67be8373bc0530fb2cf7a25deb377a09