[INFO] fetching crate stourney 0.1.15... [INFO] linting stourney-0.1.15 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate stourney 0.1.15 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate stourney 0.1.15 [INFO] finished tweaking crates.io crate stourney 0.1.15 [INFO] tweaked toml for crates.io crate stourney 0.1.15 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate stourney 0.1.15 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate stourney 0.1.15 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tungstenite v0.21.0 [INFO] [stderr] Downloaded tokio-tungstenite v0.21.0 [INFO] [stderr] Downloaded splendor_arena v0.1.17 [INFO] [stderr] Downloaded clap-verbosity-flag v2.2.1 [INFO] [stderr] Downloaded cached_proc_macro_types v0.1.1 [INFO] [stderr] Downloaded derive v1.0.0 [INFO] [stderr] Downloaded cached_proc_macro v0.19.1 [INFO] [stderr] Downloaded dialoguer v0.11.0 [INFO] [stderr] Downloaded cached v0.48.1 [INFO] [stderr] Downloaded serde_derive v1.0.209 [INFO] [stderr] Downloaded serde v1.0.209 [INFO] [stderr] Downloaded warp v0.3.7 [INFO] [stderr] Downloaded cc v1.1.15 [INFO] [stderr] Downloaded syn v2.0.76 [INFO] [stderr] Downloaded object v0.36.4 [INFO] [stderr] Downloaded serde_json v1.0.127 [INFO] [stderr] Downloaded tokio v1.40.0 [INFO] [stderr] Downloaded cpufeatures v0.2.13 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a52345d8fc86d575750b80b7d00f90b17217b0ad7652e120fae1d9d7b0323cf1 [INFO] running `Command { std: "docker" "start" "-a" "a52345d8fc86d575750b80b7d00f90b17217b0ad7652e120fae1d9d7b0323cf1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a52345d8fc86d575750b80b7d00f90b17217b0ad7652e120fae1d9d7b0323cf1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a52345d8fc86d575750b80b7d00f90b17217b0ad7652e120fae1d9d7b0323cf1", kill_on_drop: false }` [INFO] [stdout] a52345d8fc86d575750b80b7d00f90b17217b0ad7652e120fae1d9d7b0323cf1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f1970b38b31c979637004d4514dbf6c1ed1ef333f92e705b4da92ac816afa436 [INFO] running `Command { std: "docker" "start" "-a" "f1970b38b31c979637004d4514dbf6c1ed1ef333f92e705b4da92ac816afa436", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking headers v0.3.9 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking cached_proc_macro_types v0.1.1 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking derive v1.0.0 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling cached_proc_macro v0.19.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking cached v0.48.1 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Checking clap-verbosity-flag v2.2.1 [INFO] [stderr] Checking tungstenite v0.24.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking tokio-tungstenite v0.24.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking confy v0.6.1 [INFO] [stderr] Checking warp v0.3.7 [INFO] [stderr] Checking splendor_arena v0.1.17 [INFO] [stderr] Checking stourney v0.1.15 (/opt/rustwide/workdir) [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/config.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 102 | let cfg = cfg.expect("[-] Failed to load config file"); [INFO] [stdout] | ------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 103 | cfg [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 102 ~ [INFO] [stdout] 103 ~ cfg.expect("[-] Failed to load config file") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dialogue.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return selection == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return selection == 0; [INFO] [stdout] 17 + selection == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dialogue.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return selections[selection]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return selections[selection]; [INFO] [stdout] 30 + selections[selection] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dialogue.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | return paths[selection].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return paths[selection].clone(); [INFO] [stdout] 57 + paths[selection].clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dialogue.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | return paths[selection].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return paths[selection].clone(); [INFO] [stdout] 86 + paths[selection].clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/subcommands.rs:29:24 [INFO] [stdout] | [INFO] [stdout] 29 | fs::create_dir(&directory).expect("[-] Failed to create directory"); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/subcommands.rs:35:41 [INFO] [stdout] | [INFO] [stdout] 35 | let dir_contents = fs::read_dir(&directory).expect("[-] Failed to read directory contents"); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/subcommands.rs:38:36 [INFO] [stdout] | [INFO] [stdout] 38 | fs::remove_dir_all(&directory).expect("[-] Failed to remove directory"); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/subcommands.rs:48:30 [INFO] [stdout] | [INFO] [stdout] 48 | if utils::create_project(&directory) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/subcommands.rs:50:32 [INFO] [stdout] | [INFO] [stdout] 50 | config::add_to_recents(&directory); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/subcommands.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/subcommands.rs:84:21 [INFO] [stdout] | [INFO] [stdout] 84 | fn setup_arena() -> Result<(ArenaBuilder, Vec<(Option, String)>), ()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 37 | if !command_result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `command_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 49 | if !command_result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `command_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 71 | if !command_result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `command_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return true; [INFO] [stdout] 113 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:146:5 [INFO] [stdout] | [INFO] [stdout] 146 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 146 - return true; [INFO] [stdout] 146 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/config.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 102 | let cfg = cfg.expect("[-] Failed to load config file"); [INFO] [stdout] | ------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 103 | cfg [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 102 ~ [INFO] [stdout] 103 ~ cfg.expect("[-] Failed to load config file") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 176 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 176 - return true; [INFO] [stdout] 176 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:187:8 [INFO] [stdout] | [INFO] [stdout] 187 | if !command_result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `command_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:198:8 [INFO] [stdout] | [INFO] [stdout] 198 | if !command_result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `command_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dialogue.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return selection == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return selection == 0; [INFO] [stdout] 17 + selection == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dialogue.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return selections[selection]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return selections[selection]; [INFO] [stdout] 30 + selections[selection] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dialogue.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | return paths[selection].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return paths[selection].clone(); [INFO] [stdout] 57 + paths[selection].clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dialogue.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | return paths[selection].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return paths[selection].clone(); [INFO] [stdout] 86 + paths[selection].clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/subcommands.rs:29:24 [INFO] [stdout] | [INFO] [stdout] 29 | fs::create_dir(&directory).expect("[-] Failed to create directory"); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/subcommands.rs:35:41 [INFO] [stdout] | [INFO] [stdout] 35 | let dir_contents = fs::read_dir(&directory).expect("[-] Failed to read directory contents"); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/subcommands.rs:38:36 [INFO] [stdout] | [INFO] [stdout] 38 | fs::remove_dir_all(&directory).expect("[-] Failed to remove directory"); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/subcommands.rs:48:30 [INFO] [stdout] | [INFO] [stdout] 48 | if utils::create_project(&directory) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/subcommands.rs:50:32 [INFO] [stdout] | [INFO] [stdout] 50 | config::add_to_recents(&directory); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/subcommands.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/subcommands.rs:84:21 [INFO] [stdout] | [INFO] [stdout] 84 | fn setup_arena() -> Result<(ArenaBuilder, Vec<(Option, String)>), ()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/utils.rs:334:23 [INFO] [stdout] | [INFO] [stdout] 334 | .find(|entry| entry.path().extension().map_or(false, |ext| ext == "whl")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 334 - .find(|entry| entry.path().extension().map_or(false, |ext| ext == "whl")) [INFO] [stdout] 334 + .find(|entry| entry.path().extension().is_some_and(|ext| ext == "whl")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:351:14 [INFO] [stdout] | [INFO] [stdout] 351 | .arg(&whl_file) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `whl_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/utils.rs:366:5 [INFO] [stdout] | [INFO] [stdout] 366 | /// TODO: clean up .git? [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 366 | /// TODO: clean up .git? [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:380:20 [INFO] [stdout] | [INFO] [stdout] 380 | if !clone_repo(&arena_lib, STOURNEY_ARENA_REPO_URL) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `arena_lib` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:383:32 [INFO] [stdout] | [INFO] [stdout] 383 | if !copy_example(&example, &project_directory) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `project_directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:389:19 [INFO] [stdout] | [INFO] [stdout] 389 | maturin_build(&project_directory); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `project_directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:455:5 [INFO] [stdout] | [INFO] [stdout] 455 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 455 - return true; [INFO] [stdout] 455 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 37 | if !command_result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `command_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 49 | if !command_result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `command_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 71 | if !command_result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `command_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 113 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 113 - return true; [INFO] [stdout] 113 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/utils.rs:537:5 [INFO] [stdout] | [INFO] [stdout] 536 | let binary_path = relative_to_full_path(binary_path); [INFO] [stdout] | ----------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 537 | binary_path [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 536 ~ [INFO] [stdout] 537 ~ relative_to_full_path(binary_path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/utils.rs:547:5 [INFO] [stdout] | [INFO] [stdout] 546 | let static_files = relative_to_full_path(static_files); [INFO] [stdout] | ------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 547 | static_files [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 546 ~ [INFO] [stdout] 547 ~ relative_to_full_path(static_files) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:554:5 [INFO] [stdout] | [INFO] [stdout] 554 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 554 - return false; [INFO] [stdout] 554 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:146:5 [INFO] [stdout] | [INFO] [stdout] 146 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 146 - return true; [INFO] [stdout] 146 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 176 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 176 - return true; [INFO] [stdout] 176 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:187:8 [INFO] [stdout] | [INFO] [stdout] 187 | if !command_result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `command_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:198:8 [INFO] [stdout] | [INFO] [stdout] 198 | if !command_result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `command_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:674:59 [INFO] [stdout] | [INFO] [stdout] 674 | pub fn spawn_clients(url : &str, port : u16, client_ids : &Vec, binaries : &Vec<(Option, String)>){ [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 674 - pub fn spawn_clients(url : &str, port : u16, client_ids : &Vec, binaries : &Vec<(Option, String)>){ [INFO] [stdout] 674 + pub fn spawn_clients(url : &str, port : u16, client_ids : &[String], binaries : &Vec<(Option, String)>){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:674:84 [INFO] [stdout] | [INFO] [stdout] 674 | pub fn spawn_clients(url : &str, port : u16, client_ids : &Vec, binaries : &Vec<(Option, String)>){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 674 - pub fn spawn_clients(url : &str, port : u16, client_ids : &Vec, binaries : &Vec<(Option, String)>){ [INFO] [stdout] 674 + pub fn spawn_clients(url : &str, port : u16, client_ids : &Vec, binaries : &[(Option, String)]){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/utils.rs:691:13 [INFO] [stdout] | [INFO] [stdout] 691 | process.expect("[-] Failed to launch python client"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- help: try: `.wait()` [INFO] [stdout] | [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/utils.rs:701:13 [INFO] [stdout] | [INFO] [stdout] 701 | process.expect("[-] Failed to launch rust client"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- help: try: `.wait()` [INFO] [stdout] | [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/utils.rs:334:23 [INFO] [stdout] | [INFO] [stdout] 334 | .find(|entry| entry.path().extension().map_or(false, |ext| ext == "whl")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 334 - .find(|entry| entry.path().extension().map_or(false, |ext| ext == "whl")) [INFO] [stdout] 334 + .find(|entry| entry.path().extension().is_some_and(|ext| ext == "whl")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:351:14 [INFO] [stdout] | [INFO] [stdout] 351 | .arg(&whl_file) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `whl_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/utils.rs:366:5 [INFO] [stdout] | [INFO] [stdout] 366 | /// TODO: clean up .git? [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 366 | /// TODO: clean up .git? [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:380:20 [INFO] [stdout] | [INFO] [stdout] 380 | if !clone_repo(&arena_lib, STOURNEY_ARENA_REPO_URL) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `arena_lib` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:383:32 [INFO] [stdout] | [INFO] [stdout] 383 | if !copy_example(&example, &project_directory) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `project_directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:389:19 [INFO] [stdout] | [INFO] [stdout] 389 | maturin_build(&project_directory); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `project_directory` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:455:5 [INFO] [stdout] | [INFO] [stdout] 455 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 455 - return true; [INFO] [stdout] 455 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/utils.rs:537:5 [INFO] [stdout] | [INFO] [stdout] 536 | let binary_path = relative_to_full_path(binary_path); [INFO] [stdout] | ----------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 537 | binary_path [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 536 ~ [INFO] [stdout] 537 ~ relative_to_full_path(binary_path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/utils.rs:547:5 [INFO] [stdout] | [INFO] [stdout] 546 | let static_files = relative_to_full_path(static_files); [INFO] [stdout] | ------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 547 | static_files [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 546 ~ [INFO] [stdout] 547 ~ relative_to_full_path(static_files) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:554:5 [INFO] [stdout] | [INFO] [stdout] 554 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 554 - return false; [INFO] [stdout] 554 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:674:59 [INFO] [stdout] | [INFO] [stdout] 674 | pub fn spawn_clients(url : &str, port : u16, client_ids : &Vec, binaries : &Vec<(Option, String)>){ [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 674 - pub fn spawn_clients(url : &str, port : u16, client_ids : &Vec, binaries : &Vec<(Option, String)>){ [INFO] [stdout] 674 + pub fn spawn_clients(url : &str, port : u16, client_ids : &[String], binaries : &Vec<(Option, String)>){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:674:84 [INFO] [stdout] | [INFO] [stdout] 674 | pub fn spawn_clients(url : &str, port : u16, client_ids : &Vec, binaries : &Vec<(Option, String)>){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 674 - pub fn spawn_clients(url : &str, port : u16, client_ids : &Vec, binaries : &Vec<(Option, String)>){ [INFO] [stdout] 674 + pub fn spawn_clients(url : &str, port : u16, client_ids : &Vec, binaries : &[(Option, String)]){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/utils.rs:691:13 [INFO] [stdout] | [INFO] [stdout] 691 | process.expect("[-] Failed to launch python client"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- help: try: `.wait()` [INFO] [stdout] | [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/utils.rs:701:13 [INFO] [stdout] | [INFO] [stdout] 701 | process.expect("[-] Failed to launch rust client"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- help: try: `.wait()` [INFO] [stdout] | [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 15s [INFO] running `Command { std: "docker" "inspect" "f1970b38b31c979637004d4514dbf6c1ed1ef333f92e705b4da92ac816afa436", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1970b38b31c979637004d4514dbf6c1ed1ef333f92e705b4da92ac816afa436", kill_on_drop: false }` [INFO] [stdout] f1970b38b31c979637004d4514dbf6c1ed1ef333f92e705b4da92ac816afa436