[INFO] fetching crate stdweb-internal-macros 0.2.9... [INFO] linting stdweb-internal-macros-0.2.9 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate stdweb-internal-macros 0.2.9 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate stdweb-internal-macros 0.2.9 [INFO] finished tweaking crates.io crate stdweb-internal-macros 0.2.9 [INFO] tweaked toml for crates.io crate stdweb-internal-macros 0.2.9 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate stdweb-internal-macros 0.2.9 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 15 packages to latest compatible versions [INFO] [stderr] Adding sha1 v0.6.1 (available: v0.10.6) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.117) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7a31820ec7763fb26976327a235a73f70a7beaa7891432105511b37826c50ad2 [INFO] running `Command { std: "docker" "start" "-a" "7a31820ec7763fb26976327a235a73f70a7beaa7891432105511b37826c50ad2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7a31820ec7763fb26976327a235a73f70a7beaa7891432105511b37826c50ad2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a31820ec7763fb26976327a235a73f70a7beaa7891432105511b37826c50ad2", kill_on_drop: false }` [INFO] [stdout] 7a31820ec7763fb26976327a235a73f70a7beaa7891432105511b37826c50ad2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 87c3ec61e9caa118abbd00fffea54c652979d25a7b46174e88221c72e18c94a1 [INFO] running `Command { std: "docker" "start" "-a" "87c3ec61e9caa118abbd00fffea54c652979d25a7b46174e88221c72e18c94a1", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking serde_core v1.0.228 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Checking base-x v0.2.11 [INFO] [stderr] Checking sha1 v0.6.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking stdweb-internal-macros v0.2.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/macro_js_export.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | const ENCODING_BASE: &'static [u8] = b"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"; [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/macro_js_export.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | const ENCODING_BASE: &'static [u8] = b"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"; [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/js_stringify.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | Block( syn::Block ) [INFO] [stdout] | ----- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 10 - Block( syn::Block ) [INFO] [stdout] 10 + Block( () ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range` [INFO] [stdout] --> src/utils.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | (0..count).into_iter().map( |nth| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/macro_js_export.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | / match ty { [INFO] [stdout] 50 | | &syn::Type::Reference( ref ty ) => { [INFO] [stdout] 51 | | assert!( ty.mutability.is_none(), "`mut` bindings are not supported" ); [INFO] [stdout] 52 | | match *ty.elem { [INFO] [stdout] ... | [INFO] [stdout] 75 | | _ => ExportType::Unknown( ty.clone() ) [INFO] [stdout] 76 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 49 ~ match *ty { [INFO] [stdout] 50 ~ syn::Type::Reference( ref ty ) => { [INFO] [stdout] 51 | assert!( ty.mutability.is_none(), "`mut` bindings are not supported" ); [INFO] [stdout] ... [INFO] [stdout] 61 | }, [INFO] [stdout] 62 ~ syn::Type::Path( ref path ) => { [INFO] [stdout] 63 | let name = match match_shallow_path( &path.path ) { [INFO] [stdout] ... [INFO] [stdout] 73 | }, [INFO] [stdout] 74 ~ syn::Type::Tuple( ref tuple ) if tuple.elems.is_empty() => ExportType::Unit, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/macro_js_export.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | &syn::Type::Reference( ref ty ) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 50 - &syn::Type::Reference( ref ty ) => { [INFO] [stdout] 50 + syn::Type::Reference( ty ) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/macro_js_export.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | &syn::Type::Path( ref path ) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 62 - &syn::Type::Path( ref path ) => { [INFO] [stdout] 62 + syn::Type::Path( path ) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/macro_js_export.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | &syn::Type::Tuple( ref tuple ) if tuple.elems.is_empty() => ExportType::Unit, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 74 - &syn::Type::Tuple( ref tuple ) if tuple.elems.is_empty() => ExportType::Unit, [INFO] [stdout] 74 + syn::Type::Tuple( tuple ) if tuple.elems.is_empty() => ExportType::Unit, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stdout] --> src/macro_js_export.rs:272:21 [INFO] [stdout] | [INFO] [stdout] 272 | let return_ty = match &decl.output { [INFO] [stdout] | _____________________^ [INFO] [stdout] 273 | | &syn::ReturnType::Default => ExportType::Unit, [INFO] [stdout] 274 | | &syn::ReturnType::Type( _, ref ty ) => match_type( ty ) [INFO] [stdout] 275 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 272 ~ let return_ty = match decl.output { [INFO] [stdout] 273 ~ syn::ReturnType::Default => ExportType::Unit, [INFO] [stdout] 274 ~ syn::ReturnType::Type( _, ref ty ) => match_type( ty ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/macro_js_export.rs:274:9 [INFO] [stdout] | [INFO] [stdout] 274 | &syn::ReturnType::Type( _, ref ty ) => match_type( ty ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 274 - &syn::ReturnType::Type( _, ref ty ) => match_type( ty ) [INFO] [stdout] 274 + syn::ReturnType::Type( _, ty ) => match_type( ty ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/macro_async_test.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / match return_type { [INFO] [stdout] 10 | | &syn::ReturnType::Default => true, [INFO] [stdout] 11 | | &syn::ReturnType::Type( _, ref ty ) => { [INFO] [stdout] 12 | | match **ty { [INFO] [stdout] ... | [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 9 ~ match *return_type { [INFO] [stdout] 10 ~ syn::ReturnType::Default => true, [INFO] [stdout] 11 ~ syn::ReturnType::Type( _, ref ty ) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/macro_async_test.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | &syn::ReturnType::Type( _, ref ty ) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 11 - &syn::ReturnType::Type( _, ref ty ) => { [INFO] [stdout] 11 + syn::ReturnType::Type( _, ty ) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/macro_async_test.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | / match **ty { [INFO] [stdout] 13 | | syn::Type::Tuple( ref tuple ) if tuple.elems.is_empty() => true, [INFO] [stdout] 14 | | _ => false [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 12 - match **ty { [INFO] [stdout] 13 - syn::Type::Tuple( ref tuple ) if tuple.elems.is_empty() => true, [INFO] [stdout] 14 - _ => false [INFO] [stdout] 15 - } [INFO] [stdout] 12 + matches!(**ty, syn::Type::Tuple( ref tuple ) if tuple.elems.is_empty()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/macro_async_test.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | / enum TestKind { [INFO] [stdout] 21 | | / Simple { [INFO] [stdout] 22 | | | callback_ident: syn::Ident [INFO] [stdout] 23 | | | }, [INFO] [stdout] | | |_____- the second-largest variant contains at least 24 bytes [INFO] [stdout] 24 | | / Fallible { [INFO] [stdout] 25 | | | callback_ident: syn::Ident, [INFO] [stdout] 26 | | | result_ty: syn::Type [INFO] [stdout] 27 | | | }, [INFO] [stdout] | | |_____- the largest variant contains at least 288 bytes [INFO] [stdout] 28 | | Synchronous [INFO] [stdout] 29 | | } [INFO] [stdout] | |___^ the entire enum is at least 288 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 26 - result_ty: syn::Type [INFO] [stdout] 26 + result_ty: Box [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/macro_async_test.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | if !bound.path.leading_colon.is_none() || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bound.path.leading_colon.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/macro_async_test.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | / enum Kind { [INFO] [stdout] 73 | | Simple, [INFO] [stdout] | | ------ the second-largest variant carries no data at all [INFO] [stdout] 74 | |/ Fallible { [INFO] [stdout] 75 | || result_ty: syn::Type [INFO] [stdout] 76 | || } [INFO] [stdout] | ||_________- the largest variant contains at least 264 bytes [INFO] [stdout] 77 | | } [INFO] [stdout] | |______^ the entire enum is at least 264 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 75 - result_ty: syn::Type [INFO] [stdout] 75 + result_ty: Box [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/macro_async_test.rs:191:5 [INFO] [stdout] | [INFO] [stdout] 191 | let inner; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `inner` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 191 ~ [INFO] [stdout] 192 ~ let inner = match test_kind { [INFO] [stdout] 193 | TestKind::Simple { callback_ident } => { [INFO] [stdout] ... [INFO] [stdout] 204 | [INFO] [stdout] 205 ~ quote! { [INFO] [stdout] 206 | #prelude [INFO] [stdout] 207 | #block [INFO] [stdout] 208 ~ } [INFO] [stdout] 209 | }, [INFO] [stdout] ... [INFO] [stdout] 227 | [INFO] [stdout] 228 ~ quote! { [INFO] [stdout] 229 | #prelude [INFO] [stdout] 230 | #block [INFO] [stdout] 231 ~ } [INFO] [stdout] 232 | }, [INFO] [stdout] 233 | TestKind::Synchronous => { [INFO] [stdout] 234 ~ quote! { [INFO] [stdout] 235 | (move || { [INFO] [stdout] ... [INFO] [stdout] 243 | } [INFO] [stdout] 244 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/macro_js.rs:16:46 [INFO] [stdout] | [INFO] [stdout] 16 | let inner_no_return = outer_no_return || snippet.code( 0 ).contains( "return" ) == false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!snippet.code( 0 ).contains( "return" )` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/macro_js.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | let call_args: Vec< _ >; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `call_args` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 38 ~ [INFO] [stdout] 39 ~ let call_args: Vec< _ > = if inner_no_return && !outer_no_return { [INFO] [stdout] 40 ~ arg_names.into_iter().skip( 1 ).collect() [INFO] [stdout] 41 | } else { [INFO] [stdout] 42 ~ arg_names.into_iter().collect() [INFO] [stdout] 43 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/js_stringify.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | / match chunk { [INFO] [stdout] 46 | | Chunk::Block( .. ) => true, [INFO] [stdout] 47 | | _ => false [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 45 - match chunk { [INFO] [stdout] 46 - Chunk::Block( .. ) => true, [INFO] [stdout] 47 - _ => false [INFO] [stdout] 48 - } [INFO] [stdout] 45 + matches!(chunk, Chunk::Block( .. )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/js_stringify.rs:58:11 [INFO] [stdout] | [INFO] [stdout] 58 | ).fold( 0, |sum, len| sum + len ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sum::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/js_stringify.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | Block( syn::Block ) [INFO] [stdout] | ----- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 10 - Block( syn::Block ) [INFO] [stdout] 10 + Block( () ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range` [INFO] [stdout] --> src/utils.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | (0..count).into_iter().map( |nth| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/macro_js_export.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | / match ty { [INFO] [stdout] 50 | | &syn::Type::Reference( ref ty ) => { [INFO] [stdout] 51 | | assert!( ty.mutability.is_none(), "`mut` bindings are not supported" ); [INFO] [stdout] 52 | | match *ty.elem { [INFO] [stdout] ... | [INFO] [stdout] 75 | | _ => ExportType::Unknown( ty.clone() ) [INFO] [stdout] 76 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 49 ~ match *ty { [INFO] [stdout] 50 ~ syn::Type::Reference( ref ty ) => { [INFO] [stdout] 51 | assert!( ty.mutability.is_none(), "`mut` bindings are not supported" ); [INFO] [stdout] ... [INFO] [stdout] 61 | }, [INFO] [stdout] 62 ~ syn::Type::Path( ref path ) => { [INFO] [stdout] 63 | let name = match match_shallow_path( &path.path ) { [INFO] [stdout] ... [INFO] [stdout] 73 | }, [INFO] [stdout] 74 ~ syn::Type::Tuple( ref tuple ) if tuple.elems.is_empty() => ExportType::Unit, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/macro_js_export.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | &syn::Type::Reference( ref ty ) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 50 - &syn::Type::Reference( ref ty ) => { [INFO] [stdout] 50 + syn::Type::Reference( ty ) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/macro_js_export.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | &syn::Type::Path( ref path ) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 62 - &syn::Type::Path( ref path ) => { [INFO] [stdout] 62 + syn::Type::Path( path ) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/macro_js_export.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | &syn::Type::Tuple( ref tuple ) if tuple.elems.is_empty() => ExportType::Unit, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 74 - &syn::Type::Tuple( ref tuple ) if tuple.elems.is_empty() => ExportType::Unit, [INFO] [stdout] 74 + syn::Type::Tuple( tuple ) if tuple.elems.is_empty() => ExportType::Unit, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stdout] --> src/macro_js_export.rs:272:21 [INFO] [stdout] | [INFO] [stdout] 272 | let return_ty = match &decl.output { [INFO] [stdout] | _____________________^ [INFO] [stdout] 273 | | &syn::ReturnType::Default => ExportType::Unit, [INFO] [stdout] 274 | | &syn::ReturnType::Type( _, ref ty ) => match_type( ty ) [INFO] [stdout] 275 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 272 ~ let return_ty = match decl.output { [INFO] [stdout] 273 ~ syn::ReturnType::Default => ExportType::Unit, [INFO] [stdout] 274 ~ syn::ReturnType::Type( _, ref ty ) => match_type( ty ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/macro_js_export.rs:274:9 [INFO] [stdout] | [INFO] [stdout] 274 | &syn::ReturnType::Type( _, ref ty ) => match_type( ty ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 274 - &syn::ReturnType::Type( _, ref ty ) => match_type( ty ) [INFO] [stdout] 274 + syn::ReturnType::Type( _, ty ) => match_type( ty ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/macro_async_test.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / match return_type { [INFO] [stdout] 10 | | &syn::ReturnType::Default => true, [INFO] [stdout] 11 | | &syn::ReturnType::Type( _, ref ty ) => { [INFO] [stdout] 12 | | match **ty { [INFO] [stdout] ... | [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 9 ~ match *return_type { [INFO] [stdout] 10 ~ syn::ReturnType::Default => true, [INFO] [stdout] 11 ~ syn::ReturnType::Type( _, ref ty ) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a tuple pattern where every element takes a reference [INFO] [stdout] --> src/macro_async_test.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | &syn::ReturnType::Type( _, ref ty ) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 11 - &syn::ReturnType::Type( _, ref ty ) => { [INFO] [stdout] 11 + syn::ReturnType::Type( _, ty ) => { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/macro_async_test.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | / match **ty { [INFO] [stdout] 13 | | syn::Type::Tuple( ref tuple ) if tuple.elems.is_empty() => true, [INFO] [stdout] 14 | | _ => false [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 12 - match **ty { [INFO] [stdout] 13 - syn::Type::Tuple( ref tuple ) if tuple.elems.is_empty() => true, [INFO] [stdout] 14 - _ => false [INFO] [stdout] 15 - } [INFO] [stdout] 12 + matches!(**ty, syn::Type::Tuple( ref tuple ) if tuple.elems.is_empty()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/macro_async_test.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | / enum TestKind { [INFO] [stdout] 21 | | / Simple { [INFO] [stdout] 22 | | | callback_ident: syn::Ident [INFO] [stdout] 23 | | | }, [INFO] [stdout] | | |_____- the second-largest variant contains at least 24 bytes [INFO] [stdout] 24 | | / Fallible { [INFO] [stdout] 25 | | | callback_ident: syn::Ident, [INFO] [stdout] 26 | | | result_ty: syn::Type [INFO] [stdout] 27 | | | }, [INFO] [stdout] | | |_____- the largest variant contains at least 288 bytes [INFO] [stdout] 28 | | Synchronous [INFO] [stdout] 29 | | } [INFO] [stdout] | |___^ the entire enum is at least 288 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 26 - result_ty: syn::Type [INFO] [stdout] 26 + result_ty: Box [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/macro_async_test.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | if !bound.path.leading_colon.is_none() || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bound.path.leading_colon.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/macro_async_test.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | / enum Kind { [INFO] [stdout] 73 | | Simple, [INFO] [stdout] | | ------ the second-largest variant carries no data at all [INFO] [stdout] 74 | |/ Fallible { [INFO] [stdout] 75 | || result_ty: syn::Type [INFO] [stdout] 76 | || } [INFO] [stdout] | ||_________- the largest variant contains at least 264 bytes [INFO] [stdout] 77 | | } [INFO] [stdout] | |______^ the entire enum is at least 264 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 75 - result_ty: syn::Type [INFO] [stdout] 75 + result_ty: Box [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/macro_async_test.rs:191:5 [INFO] [stdout] | [INFO] [stdout] 191 | let inner; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `inner` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 191 ~ [INFO] [stdout] 192 ~ let inner = match test_kind { [INFO] [stdout] 193 | TestKind::Simple { callback_ident } => { [INFO] [stdout] ... [INFO] [stdout] 204 | [INFO] [stdout] 205 ~ quote! { [INFO] [stdout] 206 | #prelude [INFO] [stdout] 207 | #block [INFO] [stdout] 208 ~ } [INFO] [stdout] 209 | }, [INFO] [stdout] ... [INFO] [stdout] 227 | [INFO] [stdout] 228 ~ quote! { [INFO] [stdout] 229 | #prelude [INFO] [stdout] 230 | #block [INFO] [stdout] 231 ~ } [INFO] [stdout] 232 | }, [INFO] [stdout] 233 | TestKind::Synchronous => { [INFO] [stdout] 234 ~ quote! { [INFO] [stdout] 235 | (move || { [INFO] [stdout] ... [INFO] [stdout] 243 | } [INFO] [stdout] 244 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/macro_js.rs:16:46 [INFO] [stdout] | [INFO] [stdout] 16 | let inner_no_return = outer_no_return || snippet.code( 0 ).contains( "return" ) == false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!snippet.code( 0 ).contains( "return" )` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/macro_js.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | let call_args: Vec< _ >; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `call_args` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 38 ~ [INFO] [stdout] 39 ~ let call_args: Vec< _ > = if inner_no_return && !outer_no_return { [INFO] [stdout] 40 ~ arg_names.into_iter().skip( 1 ).collect() [INFO] [stdout] 41 | } else { [INFO] [stdout] 42 ~ arg_names.into_iter().collect() [INFO] [stdout] 43 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/js_stringify.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | / match chunk { [INFO] [stdout] 46 | | Chunk::Block( .. ) => true, [INFO] [stdout] 47 | | _ => false [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 45 - match chunk { [INFO] [stdout] 46 - Chunk::Block( .. ) => true, [INFO] [stdout] 47 - _ => false [INFO] [stdout] 48 - } [INFO] [stdout] 45 + matches!(chunk, Chunk::Block( .. )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/js_stringify.rs:58:11 [INFO] [stdout] | [INFO] [stdout] 58 | ).fold( 0, |sum, len| sum + len ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sum::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.04s [INFO] running `Command { std: "docker" "inspect" "87c3ec61e9caa118abbd00fffea54c652979d25a7b46174e88221c72e18c94a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87c3ec61e9caa118abbd00fffea54c652979d25a7b46174e88221c72e18c94a1", kill_on_drop: false }` [INFO] [stdout] 87c3ec61e9caa118abbd00fffea54c652979d25a7b46174e88221c72e18c94a1