[INFO] fetching crate statue 0.3.1... [INFO] linting statue-0.3.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate statue 0.3.1 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate statue 0.3.1 [INFO] finished tweaking crates.io crate statue 0.3.1 [INFO] tweaked toml for crates.io crate statue 0.3.1 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate statue 0.3.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 1 package to latest compatible version [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tl v0.7.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3ad5cc59fd0cab8462e143c3ce2588cc488db7be488f5fab4fe454b25a87b416 [INFO] running `Command { std: "docker" "start" "-a" "3ad5cc59fd0cab8462e143c3ce2588cc488db7be488f5fab4fe454b25a87b416", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3ad5cc59fd0cab8462e143c3ce2588cc488db7be488f5fab4fe454b25a87b416", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ad5cc59fd0cab8462e143c3ce2588cc488db7be488f5fab4fe454b25a87b416", kill_on_drop: false }` [INFO] [stdout] 3ad5cc59fd0cab8462e143c3ce2588cc488db7be488f5fab4fe454b25a87b416 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b2ffe61eb55fb19481e81cd3a4ed85620a3c8869e16eb184f8af8003ea0ff965 [INFO] running `Command { std: "docker" "start" "-a" "b2ffe61eb55fb19481e81cd3a4ed85620a3c8869e16eb184f8af8003ea0ff965", kill_on_drop: false }` [INFO] [stderr] Checking tl v0.7.8 [INFO] [stderr] Checking statue v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/args/mod.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use tl; [INFO] [stdout] | ^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/args/mod.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use tl; [INFO] [stdout] | ^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `map_err` is never used [INFO] [stdout] --> src/util.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub(crate) trait ResultLike { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] 2 | fn map U>(self, f: F) -> Result; [INFO] [stdout] 3 | fn map_err E>(self, f: F) -> Result; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/args/mod.rs:14:20 [INFO] [stdout] | [INFO] [stdout] 14 | fn to_absolute(self) -> PathBuf { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Html` [INFO] [stdout] --> src/elements.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | / pub(crate) enum ElementKind { [INFO] [stdout] 9 | | HtmlElement, [INFO] [stdout] 10 | | HtmlDialogElement, [INFO] [stdout] 11 | | HtmlDivElement, [INFO] [stdout] ... | [INFO] [stdout] 16 | | HtmlInputElement, [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/parse/args_impl.rs:68:25 [INFO] [stdout] | [INFO] [stdout] 68 | let selectors = match SelQueryBraceGroupParser::parse(iter) { [INFO] [stdout] | _________________________^ [INFO] [stdout] 69 | | Ok(selectors) => selectors, [INFO] [stdout] 70 | | Err(e) => return Err(e.into()), [INFO] [stdout] 71 | | }; [INFO] [stdout] | |_________^ help: try instead: `SelQueryBraceGroupParser::parse(iter)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parse/comma_seped_parser.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 16 | if !(comma.as_char() == ',') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(comma.as_char() != ',')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/parse/comma_seped_parser.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | let Some(comma) = iter.next() else { return None }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `let comma = iter.next()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/parse/expl_kind_sel_query_impl.rs:30:50 [INFO] [stdout] | [INFO] [stdout] 30 | let AnonSelQuery { kind, syn, ret_ty } = match AnonSelQuery::parse(iter) { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 31 | | Ok(selector) => selector, [INFO] [stdout] 32 | | Err(e) => return Err(e.into()), [INFO] [stdout] 33 | | }; [INFO] [stdout] | |_________^ help: try instead: `AnonSelQuery::parse(iter)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/parse/option_combinator.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | InnerError(T::Error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Expected` [INFO] [stdout] --> src/parse/opts_parser.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / pub(crate) enum Error { [INFO] [stdout] 8 | | OptsArgExpected, [INFO] [stdout] 9 | | ColonExpected, [INFO] [stdout] 10 | | BraceGroupExpected, [INFO] [stdout] ... | [INFO] [stdout] 14 | | DocumentRetTyArgExpected, [INFO] [stdout] 15 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parse/opts_parser.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | if !(colon.as_char() == ':') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(colon.as_char() != ':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parse/opts_parser.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 48 | if !(colon.as_char() == ':') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(colon.as_char() != ':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parse/opts_parser.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 55 | if !(comma.as_char() == ',') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(comma.as_char() != ',')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parse/opts_parser.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 65 | if !(colon.as_char() == ':') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(colon.as_char() != ':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/sel_queries/multi_sel_queries.rs:17:77 [INFO] [stdout] | [INFO] [stdout] 17 | let mut query_res_iter = dom.query_selector(syn.0.as_str()).expect( [INFO] [stdout] | _____________________________________________________________________________^ [INFO] [stdout] 18 | | format!( [INFO] [stdout] 19 | | "Failed to create an iterator over results of query for \"{:?}\" selector.", [INFO] [stdout] 20 | | syn.0.as_bytes() [INFO] [stdout] 21 | | ) [INFO] [stdout] 22 | | .as_str(), [INFO] [stdout] 23 | | ); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 17 ~ let mut query_res_iter = dom.query_selector(syn.0.as_str()).unwrap_or_else(|| panic!("Failed to create an iterator over results of query for \"{:?}\" selector.", [INFO] [stdout] 18 ~ syn.0.as_bytes())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/sel_queries/multi_sel_queries.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | / loop { [INFO] [stdout] 31 | | match query_res_iter.next() { [INFO] [stdout] 32 | | Some(handle) => { [INFO] [stdout] 33 | | let node = handle.get(parser).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 40 | | } [INFO] [stdout] | |_________________^ help: try: `while let Some(handle) = query_res_iter.next() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sel_queries/mod.rs:49:48 [INFO] [stdout] | [INFO] [stdout] 49 | let single = self.single.into_elements(&dom); [INFO] [stdout] | ^^^^ help: change this to: `dom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sel_queries/mod.rs:50:49 [INFO] [stdout] | [INFO] [stdout] 50 | let multiple = self.multi.into_elements(&dom); [INFO] [stdout] | ^^^^ help: change this to: `dom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `map_err` is never used [INFO] [stdout] --> src/util.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub(crate) trait ResultLike { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] 2 | fn map U>(self, f: F) -> Result; [INFO] [stdout] 3 | fn map_err E>(self, f: F) -> Result; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/args/mod.rs:14:20 [INFO] [stdout] | [INFO] [stdout] 14 | fn to_absolute(self) -> PathBuf { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Html` [INFO] [stdout] --> src/elements.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | / pub(crate) enum ElementKind { [INFO] [stdout] 9 | | HtmlElement, [INFO] [stdout] 10 | | HtmlDialogElement, [INFO] [stdout] 11 | | HtmlDivElement, [INFO] [stdout] ... | [INFO] [stdout] 16 | | HtmlInputElement, [INFO] [stdout] 17 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/parse/args_impl.rs:68:25 [INFO] [stdout] | [INFO] [stdout] 68 | let selectors = match SelQueryBraceGroupParser::parse(iter) { [INFO] [stdout] | _________________________^ [INFO] [stdout] 69 | | Ok(selectors) => selectors, [INFO] [stdout] 70 | | Err(e) => return Err(e.into()), [INFO] [stdout] 71 | | }; [INFO] [stdout] | |_________^ help: try instead: `SelQueryBraceGroupParser::parse(iter)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parse/comma_seped_parser.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 16 | if !(comma.as_char() == ',') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(comma.as_char() != ',')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/parse/comma_seped_parser.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | let Some(comma) = iter.next() else { return None }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `let comma = iter.next()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/parse/expl_kind_sel_query_impl.rs:30:50 [INFO] [stdout] | [INFO] [stdout] 30 | let AnonSelQuery { kind, syn, ret_ty } = match AnonSelQuery::parse(iter) { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 31 | | Ok(selector) => selector, [INFO] [stdout] 32 | | Err(e) => return Err(e.into()), [INFO] [stdout] 33 | | }; [INFO] [stdout] | |_________^ help: try instead: `AnonSelQuery::parse(iter)?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/parse/option_combinator.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | InnerError(T::Error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Expected` [INFO] [stdout] --> src/parse/opts_parser.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / pub(crate) enum Error { [INFO] [stdout] 8 | | OptsArgExpected, [INFO] [stdout] 9 | | ColonExpected, [INFO] [stdout] 10 | | BraceGroupExpected, [INFO] [stdout] ... | [INFO] [stdout] 14 | | DocumentRetTyArgExpected, [INFO] [stdout] 15 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parse/opts_parser.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | if !(colon.as_char() == ':') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(colon.as_char() != ':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parse/opts_parser.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 48 | if !(colon.as_char() == ':') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(colon.as_char() != ':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parse/opts_parser.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 55 | if !(comma.as_char() == ',') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(comma.as_char() != ',')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parse/opts_parser.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 65 | if !(colon.as_char() == ':') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(colon.as_char() != ':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/sel_queries/multi_sel_queries.rs:17:77 [INFO] [stdout] | [INFO] [stdout] 17 | let mut query_res_iter = dom.query_selector(syn.0.as_str()).expect( [INFO] [stdout] | _____________________________________________________________________________^ [INFO] [stdout] 18 | | format!( [INFO] [stdout] 19 | | "Failed to create an iterator over results of query for \"{:?}\" selector.", [INFO] [stdout] 20 | | syn.0.as_bytes() [INFO] [stdout] 21 | | ) [INFO] [stdout] 22 | | .as_str(), [INFO] [stdout] 23 | | ); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 17 ~ let mut query_res_iter = dom.query_selector(syn.0.as_str()).unwrap_or_else(|| panic!("Failed to create an iterator over results of query for \"{:?}\" selector.", [INFO] [stdout] 18 ~ syn.0.as_bytes())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/sel_queries/multi_sel_queries.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | / loop { [INFO] [stdout] 31 | | match query_res_iter.next() { [INFO] [stdout] 32 | | Some(handle) => { [INFO] [stdout] 33 | | let node = handle.get(parser).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 40 | | } [INFO] [stdout] | |_________________^ help: try: `while let Some(handle) = query_res_iter.next() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sel_queries/mod.rs:49:48 [INFO] [stdout] | [INFO] [stdout] 49 | let single = self.single.into_elements(&dom); [INFO] [stdout] | ^^^^ help: change this to: `dom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sel_queries/mod.rs:50:49 [INFO] [stdout] | [INFO] [stdout] 50 | let multiple = self.multi.into_elements(&dom); [INFO] [stdout] | ^^^^ help: change this to: `dom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.85s [INFO] running `Command { std: "docker" "inspect" "b2ffe61eb55fb19481e81cd3a4ed85620a3c8869e16eb184f8af8003ea0ff965", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b2ffe61eb55fb19481e81cd3a4ed85620a3c8869e16eb184f8af8003ea0ff965", kill_on_drop: false }` [INFO] [stdout] b2ffe61eb55fb19481e81cd3a4ed85620a3c8869e16eb184f8af8003ea0ff965