[INFO] fetching crate static-compress 0.3.3... [INFO] linting static-compress-0.3.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate static-compress 0.3.3 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate static-compress 0.3.3 [INFO] finished tweaking crates.io crate static-compress 0.3.3 [INFO] tweaked toml for crates.io crate static-compress 0.3.3 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate static-compress 0.3.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate static-compress 0.3.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pretty-bytes v0.2.2 [INFO] [stderr] Downloaded crc32fast v1.3.0 [INFO] [stderr] Downloaded chan v0.1.23 [INFO] [stderr] Downloaded zopfli v0.5.0 [INFO] [stderr] Downloaded backtrace v0.3.63 [INFO] [stderr] Downloaded stderr v0.8.0 [INFO] [stderr] Downloaded separator v0.4.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8c1b0860f55f4a7c2c86dfd621b89684ae8baf1b48ba2ff948f340750147a784 [INFO] running `Command { std: "docker" "start" "-a" "8c1b0860f55f4a7c2c86dfd621b89684ae8baf1b48ba2ff948f340750147a784", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8c1b0860f55f4a7c2c86dfd621b89684ae8baf1b48ba2ff948f340750147a784", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c1b0860f55f4a7c2c86dfd621b89684ae8baf1b48ba2ff948f340750147a784", kill_on_drop: false }` [INFO] [stdout] 8c1b0860f55f4a7c2c86dfd621b89684ae8baf1b48ba2ff948f340750147a784 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1ad1cbde4958a5dffe0a2bb1329e005ca90946566c4d6a63107e241f12bcfdf1 [INFO] running `Command { std: "docker" "start" "-a" "1ad1cbde4958a5dffe0a2bb1329e005ca90946566c4d6a63107e241f12bcfdf1", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Checking gimli v0.26.1 [INFO] [stderr] Compiling crc32fast v1.3.0 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Checking crc-catalog v1.1.1 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking encode_unicode v0.3.6 [INFO] [stderr] Checking typed-arena v2.0.1 [INFO] [stderr] Checking crc v2.1.0 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking zopfli v0.5.0 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Checking pretty-bytes v0.2.2 [INFO] [stderr] Checking stderr v0.8.0 [INFO] [stderr] Checking filetime v0.2.15 [INFO] [stderr] Checking separator v0.4.1 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Compiling brotli-sys v0.3.2 [INFO] [stderr] Compiling backtrace v0.3.63 [INFO] [stderr] Checking chan v0.1.23 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking object v0.27.1 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking clap v3.0.10 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Checking globset v0.4.8 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Checking static-compress v0.3.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `has_error_description_deprecated` [INFO] [stdout] --> src/errors.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / error_chain! { [INFO] [stdout] 2 | | errors { [INFO] [stdout] 3 | | InvalidParameterValue(pname: &'static str) { [INFO] [stdout] 4 | | description("An invalid value was supplied for a command line argument.") [INFO] [stdout] ... | [INFO] [stdout] 15 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `impl_error_chain_processed` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the macro `impl_error_chain_processed` may come from an old version of the `error_chain` crate, try updating your dependency with `cargo update -p error_chain` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `has_error_description_deprecated` [INFO] [stdout] --> src/errors.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / error_chain! { [INFO] [stdout] 2 | | errors { [INFO] [stdout] 3 | | InvalidParameterValue(pname: &'static str) { [INFO] [stdout] 4 | | description("An invalid value was supplied for a command line argument.") [INFO] [stdout] ... | [INFO] [stdout] 15 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = note: using a cfg inside a macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `impl_error_chain_processed` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = help: the macro `impl_error_chain_processed` may come from an old version of the `error_chain` crate, try updating your dependency with `cargo update -p error_chain` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lists.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | pub const COMP_EXTS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lists.rs:1:33 [INFO] [stdout] | [INFO] [stdout] 1 | pub const COMP_EXTS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lists.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | pub const COMP_EXTS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/lists.rs:1:33 [INFO] [stdout] | [INFO] [stdout] 1 | pub const COMP_EXTS: &'static [&'static str] = &[ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | compressor: compressor, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compressor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | compressor: compressor, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compressor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/compression.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | / match self { [INFO] [stdout] 15 | | &CompressionAlgorithm::Brotli => "br", [INFO] [stdout] 16 | | &CompressionAlgorithm::GZip => "gz", [INFO] [stdout] 17 | | &CompressionAlgorithm::WebP => "webp", [INFO] [stdout] 18 | | &CompressionAlgorithm::Zopfli => "gz", [INFO] [stdout] 19 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 14 ~ match *self { [INFO] [stdout] 15 ~ CompressionAlgorithm::Brotli => "br", [INFO] [stdout] 16 ~ CompressionAlgorithm::GZip => "gz", [INFO] [stdout] 17 ~ CompressionAlgorithm::WebP => "webp", [INFO] [stdout] 18 ~ CompressionAlgorithm::Zopfli => "gz", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/compression.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / match self { [INFO] [stdout] 26 | | &CompressionAlgorithm::GZip => gzip_compress(src, dst, quality), [INFO] [stdout] 27 | | &CompressionAlgorithm::Brotli => brotli_compress(src, dst, quality), [INFO] [stdout] 28 | | &CompressionAlgorithm::WebP => webp_compress(src, dst, quality), [INFO] [stdout] ... | [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 25 ~ match *self { [INFO] [stdout] 26 ~ CompressionAlgorithm::GZip => gzip_compress(src, dst, quality), [INFO] [stdout] 27 ~ CompressionAlgorithm::Brotli => brotli_compress(src, dst, quality), [INFO] [stdout] 28 ~ CompressionAlgorithm::WebP => webp_compress(src, dst, quality), [INFO] [stdout] 29 ~ CompressionAlgorithm::Zopfli => zopfli_compress(src, dst, quality), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `zopfli::compress` doesn't need a mutable reference [INFO] [stdout] --> src/compression.rs:95:74 [INFO] [stdout] | [INFO] [stdout] 95 | zopfli::compress(&zopfli::Options::default(), &zopfli::Format::Gzip, &mut src_data, &mut dst)?; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 95 - zopfli::compress(&zopfli::Options::default(), &zopfli::Format::Gzip, &mut src_data, &mut dst)?; [INFO] [stdout] 95 + zopfli::compress(&zopfli::Options::default(), &zopfli::Format::Gzip, &src_data, &mut dst)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/structs.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return Ok(r); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return Ok(r); [INFO] [stdout] 32 + Ok(r) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/structs.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | return self.total_compressed as f32 / self.total_uncompressed as f32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return self.total_compressed as f32 / self.total_uncompressed as f32; [INFO] [stdout] 87 + self.total_compressed as f32 / self.total_uncompressed as f32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/structs.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | return self.total_compressed_now as f32 / self.total_uncompressed_now as f32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return self.total_compressed_now as f32 / self.total_uncompressed_now as f32; [INFO] [stdout] 91 + self.total_compressed_now as f32 / self.total_uncompressed_now as f32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/structs.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | writeln!(f, "")?; [INFO] [stdout] | ^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/compression.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | / match self { [INFO] [stdout] 15 | | &CompressionAlgorithm::Brotli => "br", [INFO] [stdout] 16 | | &CompressionAlgorithm::GZip => "gz", [INFO] [stdout] 17 | | &CompressionAlgorithm::WebP => "webp", [INFO] [stdout] 18 | | &CompressionAlgorithm::Zopfli => "gz", [INFO] [stdout] 19 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 14 ~ match *self { [INFO] [stdout] 15 ~ CompressionAlgorithm::Brotli => "br", [INFO] [stdout] 16 ~ CompressionAlgorithm::GZip => "gz", [INFO] [stdout] 17 ~ CompressionAlgorithm::WebP => "webp", [INFO] [stdout] 18 ~ CompressionAlgorithm::Zopfli => "gz", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/compression.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / match self { [INFO] [stdout] 26 | | &CompressionAlgorithm::GZip => gzip_compress(src, dst, quality), [INFO] [stdout] 27 | | &CompressionAlgorithm::Brotli => brotli_compress(src, dst, quality), [INFO] [stdout] 28 | | &CompressionAlgorithm::WebP => webp_compress(src, dst, quality), [INFO] [stdout] ... | [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 25 ~ match *self { [INFO] [stdout] 26 ~ CompressionAlgorithm::GZip => gzip_compress(src, dst, quality), [INFO] [stdout] 27 ~ CompressionAlgorithm::Brotli => brotli_compress(src, dst, quality), [INFO] [stdout] 28 ~ CompressionAlgorithm::WebP => webp_compress(src, dst, quality), [INFO] [stdout] 29 ~ CompressionAlgorithm::Zopfli => zopfli_compress(src, dst, quality), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/main.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | fn get_parameter<'a, T>(matches: &clap::ArgMatches, name: &'static str, default_value: T) -> Result [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `zopfli::compress` doesn't need a mutable reference [INFO] [stdout] --> src/compression.rs:95:74 [INFO] [stdout] | [INFO] [stdout] 95 | zopfli::compress(&zopfli::Options::default(), &zopfli::Format::Gzip, &mut src_data, &mut dst)?; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 95 - zopfli::compress(&zopfli::Options::default(), &zopfli::Format::Gzip, &mut src_data, &mut dst)?; [INFO] [stdout] 95 + zopfli::compress(&zopfli::Options::default(), &zopfli::Format::Gzip, &src_data, &mut dst)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/structs.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return Ok(r); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return Ok(r); [INFO] [stdout] 32 + Ok(r) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/main.rs:143:18 [INFO] [stdout] | [INFO] [stdout] 143 | fn start_workers<'a>(params: &Arc) -> (chan::Sender, mpsc::Receiver, chan::WaitGroup) { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/structs.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | return self.total_compressed as f32 / self.total_uncompressed as f32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return self.total_compressed as f32 / self.total_uncompressed as f32; [INFO] [stdout] 87 + self.total_compressed as f32 / self.total_uncompressed as f32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/structs.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | return self.total_compressed_now as f32 / self.total_uncompressed_now as f32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return self.total_compressed_now as f32 / self.total_uncompressed_now as f32; [INFO] [stdout] 91 + self.total_compressed_now as f32 / self.total_uncompressed_now as f32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/structs.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | writeln!(f, "")?; [INFO] [stdout] | ^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:258:8 [INFO] [stdout] | [INFO] [stdout] 258 | if !stats_tx.send(local_stats).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `stats_tx.send(local_stats).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/main.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | / loop { [INFO] [stdout] 205 | | let src = match rx.recv() { [INFO] [stdout] 206 | | Some(task) => task, [INFO] [stdout] 207 | | None => break, //no more tasks [INFO] [stdout] ... | [INFO] [stdout] 256 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 204 ~ while let Some(task) = rx.recv() { [INFO] [stdout] 205 + let src = task; [INFO] [stdout] 206 + .. [INFO] [stdout] 207 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map_err` over `inspect_err` [INFO] [stdout] --> src/main.rs:246:18 [INFO] [stdout] | [INFO] [stdout] 246 | .map_err(|e| { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] = note: `#[warn(clippy::manual_inspect)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 246 ~ .inspect_err(|e| { [INFO] [stdout] 247 | //try deleting the invalid destination file, but don't care if we can't [INFO] [stdout] 248 ~ std::fs::remove_file(dst).unwrap_or_default(); //return the same error [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:245:19 [INFO] [stdout] | [INFO] [stdout] 245 | }(&mut local_stats) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `local_stats` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/main.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | fn get_parameter<'a, T>(matches: &clap::ArgMatches, name: &'static str, default_value: T) -> Result [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:290:5 [INFO] [stdout] | [INFO] [stdout] 290 | return Ok(r); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 290 - return Ok(r); [INFO] [stdout] 290 + Ok(r) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:285:35 [INFO] [stdout] | [INFO] [stdout] 285 | str_search(COMP_EXTS, &ext, false).is_ok() [INFO] [stdout] | ^^^^ help: change this to: `ext` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:294:25 [INFO] [stdout] | [INFO] [stdout] 294 | fn fix_filters(filters: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 294 - fn fix_filters(filters: &mut Vec) { [INFO] [stdout] 294 + fn fix_filters(filters: &mut [String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `filters` [INFO] [stdout] --> src/main.rs:295:14 [INFO] [stdout] | [INFO] [stdout] 295 | for i in 0..filters.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 295 - for i in 0..filters.len() { [INFO] [stdout] 295 + for in &mut filters { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/main.rs:298:17 [INFO] [stdout] | [INFO] [stdout] 298 | let ref path = filters[i]; [INFO] [stdout] | ----^^^^^^^^-------------- help: try: `let path = &filters[i];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] = note: `#[warn(clippy::toplevel_ref_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/main.rs:143:18 [INFO] [stdout] | [INFO] [stdout] 143 | fn start_workers<'a>(params: &Arc) -> (chan::Sender, mpsc::Receiver, chan::WaitGroup) { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `char` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:329:45 [INFO] [stdout] | [INFO] [stdout] 329 | c => { last_char = Some(c.clone()); true } [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:258:8 [INFO] [stdout] | [INFO] [stdout] 258 | if !stats_tx.send(local_stats).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `stats_tx.send(local_stats).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/main.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | / loop { [INFO] [stdout] 205 | | let src = match rx.recv() { [INFO] [stdout] 206 | | Some(task) => task, [INFO] [stdout] 207 | | None => break, //no more tasks [INFO] [stdout] ... | [INFO] [stdout] 256 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 204 ~ while let Some(task) = rx.recv() { [INFO] [stdout] 205 + let src = task; [INFO] [stdout] 206 + .. [INFO] [stdout] 207 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map_err` over `inspect_err` [INFO] [stdout] --> src/main.rs:246:18 [INFO] [stdout] | [INFO] [stdout] 246 | .map_err(|e| { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] = note: `#[warn(clippy::manual_inspect)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 246 ~ .inspect_err(|e| { [INFO] [stdout] 247 | //try deleting the invalid destination file, but don't care if we can't [INFO] [stdout] 248 ~ std::fs::remove_file(dst).unwrap_or_default(); //return the same error [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> src/main.rs:363:29 [INFO] [stdout] | [INFO] [stdout] 363 | let dir = match PathBuf::from(dir).parent() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:245:19 [INFO] [stdout] | [INFO] [stdout] 245 | }(&mut local_stats) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `local_stats` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:290:5 [INFO] [stdout] | [INFO] [stdout] 290 | return Ok(r); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 290 - return Ok(r); [INFO] [stdout] 290 + Ok(r) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:285:35 [INFO] [stdout] | [INFO] [stdout] 285 | str_search(COMP_EXTS, &ext, false).is_ok() [INFO] [stdout] | ^^^^ help: change this to: `ext` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:294:25 [INFO] [stdout] | [INFO] [stdout] 294 | fn fix_filters(filters: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 294 - fn fix_filters(filters: &mut Vec) { [INFO] [stdout] 294 + fn fix_filters(filters: &mut [String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `filters` [INFO] [stdout] --> src/main.rs:295:14 [INFO] [stdout] | [INFO] [stdout] 295 | for i in 0..filters.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 295 - for i in 0..filters.len() { [INFO] [stdout] 295 + for in &mut filters { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/main.rs:298:17 [INFO] [stdout] | [INFO] [stdout] 298 | let ref path = filters[i]; [INFO] [stdout] | ----^^^^^^^^-------------- help: try: `let path = &filters[i];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] = note: `#[warn(clippy::toplevel_ref_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `char` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:329:45 [INFO] [stdout] | [INFO] [stdout] 329 | c => { last_char = Some(c.clone()); true } [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> src/main.rs:363:29 [INFO] [stdout] | [INFO] [stdout] 363 | let dir = match PathBuf::from(dir).parent() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.82s [INFO] running `Command { std: "docker" "inspect" "1ad1cbde4958a5dffe0a2bb1329e005ca90946566c4d6a63107e241f12bcfdf1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ad1cbde4958a5dffe0a2bb1329e005ca90946566c4d6a63107e241f12bcfdf1", kill_on_drop: false }` [INFO] [stdout] 1ad1cbde4958a5dffe0a2bb1329e005ca90946566c4d6a63107e241f12bcfdf1