[INFO] fetching crate statemachine-macro 0.1.1... [INFO] linting statemachine-macro-0.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate statemachine-macro 0.1.1 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate statemachine-macro 0.1.1 [INFO] finished tweaking crates.io crate statemachine-macro 0.1.1 [INFO] tweaked toml for crates.io crate statemachine-macro 0.1.1 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate statemachine-macro 0.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.117) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ebfde1a862bbad49223008b51094c31f2f08012597ef507a1e0923519620a499 [INFO] running `Command { std: "docker" "start" "-a" "ebfde1a862bbad49223008b51094c31f2f08012597ef507a1e0923519620a499", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ebfde1a862bbad49223008b51094c31f2f08012597ef507a1e0923519620a499", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ebfde1a862bbad49223008b51094c31f2f08012597ef507a1e0923519620a499", kill_on_drop: false }` [INFO] [stdout] ebfde1a862bbad49223008b51094c31f2f08012597ef507a1e0923519620a499 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4d26c7e662aff3c1e0cc14e390932b32c32d89cf57a0e2757dcd87e90823aafd [INFO] running `Command { std: "docker" "start" "-a" "4d26c7e662aff3c1e0cc14e390932b32c32d89cf57a0e2757dcd87e90823aafd", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking statemachine-macro v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:79:1 [INFO] [stdout] | [INFO] [stdout] 79 | use proc_macro; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:79:1 [INFO] [stdout] | [INFO] [stdout] 79 | use proc_macro; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/model/state.rs:29:68 [INFO] [stdout] | [INFO] [stdout] 29 | let sym_idents: Vec = (0..sym_types.len()).map(|x| Self::get_type_ident(x)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Self::get_type_ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/model/state.rs:51:28 [INFO] [stdout] | [INFO] [stdout] 51 | let inner = if let Some(_) = &self.loop_trigger { [INFO] [stdout] | -------^^^^^^^--------------------- help: try: `if self.loop_trigger.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/model/state.rs:140:20 [INFO] [stdout] | [INFO] [stdout] 140 | if !self.enter_trigger.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.enter_trigger.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/model/state.rs:147:20 [INFO] [stdout] | [INFO] [stdout] 147 | if !self.leave_trigger.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.leave_trigger.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/model/state.rs:154:20 [INFO] [stdout] | [INFO] [stdout] 154 | if !self.loop_trigger.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.loop_trigger.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `panic!` args [INFO] [stdout] --> src/model/state.rs:141:78 [INFO] [stdout] | [INFO] [stdout] 141 | panic!("State {} already has an enter trigger", self.name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `panic!` args [INFO] [stdout] --> src/model/state.rs:148:77 [INFO] [stdout] | [INFO] [stdout] 148 | panic!("State {} already has a leave trigger", self.name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `panic!` args [INFO] [stdout] --> src/model/state.rs:155:76 [INFO] [stdout] | [INFO] [stdout] 155 | panic!("State {} already has a loop trigger", self.name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/model/state.rs:29:68 [INFO] [stdout] | [INFO] [stdout] 29 | let sym_idents: Vec = (0..sym_types.len()).map(|x| Self::get_type_ident(x)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Self::get_type_ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/model/state.rs:51:28 [INFO] [stdout] | [INFO] [stdout] 51 | let inner = if let Some(_) = &self.loop_trigger { [INFO] [stdout] | -------^^^^^^^--------------------- help: try: `if self.loop_trigger.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/model/state.rs:140:20 [INFO] [stdout] | [INFO] [stdout] 140 | if !self.enter_trigger.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.enter_trigger.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/model/state.rs:147:20 [INFO] [stdout] | [INFO] [stdout] 147 | if !self.leave_trigger.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.leave_trigger.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/model/state.rs:154:20 [INFO] [stdout] | [INFO] [stdout] 154 | if !self.loop_trigger.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.loop_trigger.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `panic!` args [INFO] [stdout] --> src/model/state.rs:141:78 [INFO] [stdout] | [INFO] [stdout] 141 | panic!("State {} already has an enter trigger", self.name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/model/transition.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / pub enum RawTransition { [INFO] [stdout] 10 | | CatchAll(syn::Expr), [INFO] [stdout] | | ------------------- the second-largest variant contains at least 248 bytes [INFO] [stdout] 11 | | CatchType(syn::Type, syn::Pat, syn::Expr) [INFO] [stdout] | | ----------------------------------------- the largest variant contains at least 648 bytes [INFO] [stdout] 12 | | } [INFO] [stdout] | |_^ the entire enum is at least 648 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 11 - CatchType(syn::Type, syn::Pat, syn::Expr) [INFO] [stdout] 11 + CatchType(Box, syn::Pat, syn::Expr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `panic!` args [INFO] [stdout] --> src/model/state.rs:148:77 [INFO] [stdout] | [INFO] [stdout] 148 | panic!("State {} already has a leave trigger", self.name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `panic!` args [INFO] [stdout] --> src/model/state.rs:155:76 [INFO] [stdout] | [INFO] [stdout] 155 | panic!("State {} already has a loop trigger", self.name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/model/transition.rs:41:31 [INFO] [stdout] | [INFO] [stdout] 41 | fn find_type_ident(types: &Vec, ty: &syn::Type) -> syn::Ident { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 41 - fn find_type_ident(types: &Vec, ty: &syn::Type) -> syn::Ident { [INFO] [stdout] 41 + fn find_type_ident(types: &[syn::Type], ty: &syn::Type) -> syn::Ident { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/model/transition.rs:79:39 [INFO] [stdout] | [INFO] [stdout] 79 | guard = Self::parse_guard(&buf)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/model/transition.rs:87:39 [INFO] [stdout] | [INFO] [stdout] 87 | guard = Self::parse_guard(&buf)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `panic!` args [INFO] [stdout] --> src/util.rs:6:68 [INFO] [stdout] | [INFO] [stdout] 6 | panic!("Expected `{}` keyword, got `{}`", expected, keyword.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/model/transition.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / pub enum RawTransition { [INFO] [stdout] 10 | | CatchAll(syn::Expr), [INFO] [stdout] | | ------------------- the second-largest variant contains at least 248 bytes [INFO] [stdout] 11 | | CatchType(syn::Type, syn::Pat, syn::Expr) [INFO] [stdout] | | ----------------------------------------- the largest variant contains at least 648 bytes [INFO] [stdout] 12 | | } [INFO] [stdout] | |_^ the entire enum is at least 648 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 11 - CatchType(syn::Type, syn::Pat, syn::Expr) [INFO] [stdout] 11 + CatchType(Box, syn::Pat, syn::Expr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/model/transition.rs:41:31 [INFO] [stdout] | [INFO] [stdout] 41 | fn find_type_ident(types: &Vec, ty: &syn::Type) -> syn::Ident { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 41 - fn find_type_ident(types: &Vec, ty: &syn::Type) -> syn::Ident { [INFO] [stdout] 41 + fn find_type_ident(types: &[syn::Type], ty: &syn::Type) -> syn::Ident { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/model/transition.rs:79:39 [INFO] [stdout] | [INFO] [stdout] 79 | guard = Self::parse_guard(&buf)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/model/transition.rs:87:39 [INFO] [stdout] | [INFO] [stdout] 87 | guard = Self::parse_guard(&buf)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `panic!` args [INFO] [stdout] --> src/util.rs:6:68 [INFO] [stdout] | [INFO] [stdout] 6 | panic!("Expected `{}` keyword, got `{}`", expected, keyword.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/lib.rs:79:1 [INFO] [stdout] | [INFO] [stdout] 79 | use proc_macro; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/model/state.rs:29:68 [INFO] [stdout] | [INFO] [stdout] 29 | let sym_idents: Vec = (0..sym_types.len()).map(|x| Self::get_type_ident(x)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Self::get_type_ident` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/model/state.rs:51:28 [INFO] [stdout] | [INFO] [stdout] 51 | let inner = if let Some(_) = &self.loop_trigger { [INFO] [stdout] | -------^^^^^^^--------------------- help: try: `if self.loop_trigger.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/model/state.rs:140:20 [INFO] [stdout] | [INFO] [stdout] 140 | if !self.enter_trigger.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.enter_trigger.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/model/state.rs:147:20 [INFO] [stdout] | [INFO] [stdout] 147 | if !self.leave_trigger.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.leave_trigger.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/model/state.rs:154:20 [INFO] [stdout] | [INFO] [stdout] 154 | if !self.loop_trigger.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.loop_trigger.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `panic!` args [INFO] [stdout] --> src/model/state.rs:141:78 [INFO] [stdout] | [INFO] [stdout] 141 | panic!("State {} already has an enter trigger", self.name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `panic!` args [INFO] [stdout] --> src/model/state.rs:148:77 [INFO] [stdout] | [INFO] [stdout] 148 | panic!("State {} already has a leave trigger", self.name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `panic!` args [INFO] [stdout] --> src/model/state.rs:155:76 [INFO] [stdout] | [INFO] [stdout] 155 | panic!("State {} already has a loop trigger", self.name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/model/transition.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / pub enum RawTransition { [INFO] [stdout] 10 | | CatchAll(syn::Expr), [INFO] [stdout] | | ------------------- the second-largest variant contains at least 248 bytes [INFO] [stdout] 11 | | CatchType(syn::Type, syn::Pat, syn::Expr) [INFO] [stdout] | | ----------------------------------------- the largest variant contains at least 648 bytes [INFO] [stdout] 12 | | } [INFO] [stdout] | |_^ the entire enum is at least 648 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 11 - CatchType(syn::Type, syn::Pat, syn::Expr) [INFO] [stdout] 11 + CatchType(Box, syn::Pat, syn::Expr) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/model/transition.rs:41:31 [INFO] [stdout] | [INFO] [stdout] 41 | fn find_type_ident(types: &Vec, ty: &syn::Type) -> syn::Ident { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 41 - fn find_type_ident(types: &Vec, ty: &syn::Type) -> syn::Ident { [INFO] [stdout] 41 + fn find_type_ident(types: &[syn::Type], ty: &syn::Type) -> syn::Ident { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/model/transition.rs:79:39 [INFO] [stdout] | [INFO] [stdout] 79 | guard = Self::parse_guard(&buf)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/model/transition.rs:87:39 [INFO] [stdout] | [INFO] [stdout] 87 | guard = Self::parse_guard(&buf)?; [INFO] [stdout] | ^^^^ help: change this to: `buf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `panic!` args [INFO] [stdout] --> src/util.rs:6:68 [INFO] [stdout] | [INFO] [stdout] 6 | panic!("Expected `{}` keyword, got `{}`", expected, keyword.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: sub-expression diverges [INFO] [stdout] --> tests/guards.rs:10:30 [INFO] [stdout] | [INFO] [stdout] 10 | char match 'g' => if panic!("oh wait!") Start, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression [INFO] [stdout] = note: `#[warn(clippy::diverging_sub_expression)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.69s [INFO] running `Command { std: "docker" "inspect" "4d26c7e662aff3c1e0cc14e390932b32c32d89cf57a0e2757dcd87e90823aafd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d26c7e662aff3c1e0cc14e390932b32c32d89cf57a0e2757dcd87e90823aafd", kill_on_drop: false }` [INFO] [stdout] 4d26c7e662aff3c1e0cc14e390932b32c32d89cf57a0e2757dcd87e90823aafd