[INFO] fetching crate ssearch 0.2.0... [INFO] linting ssearch-0.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ssearch 0.2.0 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate ssearch 0.2.0 [INFO] finished tweaking crates.io crate ssearch 0.2.0 [INFO] tweaked toml for crates.io crate ssearch 0.2.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ssearch 0.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 83 packages to latest compatible versions [INFO] [stderr] Adding clap v2.34.0 (available: v4.6.0) [INFO] [stderr] Adding dirs v2.0.2 (available: v6.0.0) [INFO] [stderr] Adding opener v0.4.1 (available: v0.8.4) [INFO] [stderr] Adding prettytable-rs v0.8.0 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded dirs v2.0.2 [INFO] [stderr] Downloaded prettytable-rs v0.8.0 [INFO] [stderr] Downloaded opener v0.4.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d4c80775c6c6eb47e3bc90c2c94b6d599cb41efbfafa9dc44b9fb04dd3b15a7b [INFO] running `Command { std: "docker" "start" "-a" "d4c80775c6c6eb47e3bc90c2c94b6d599cb41efbfafa9dc44b9fb04dd3b15a7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d4c80775c6c6eb47e3bc90c2c94b6d599cb41efbfafa9dc44b9fb04dd3b15a7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4c80775c6c6eb47e3bc90c2c94b6d599cb41efbfafa9dc44b9fb04dd3b15a7b", kill_on_drop: false }` [INFO] [stdout] d4c80775c6c6eb47e3bc90c2c94b6d599cb41efbfafa9dc44b9fb04dd3b15a7b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 113cc0d035df16ebd2a9b827be0ae4487f027fe705b992dbb5b5c0272cac0034 [INFO] running `Command { std: "docker" "start" "-a" "113cc0d035df16ebd2a9b827be0ae4487f027fe705b992dbb5b5c0272cac0034", kill_on_drop: false }` [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking encode_unicode v0.3.6 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking opener v0.4.1 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking ssearch v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use opener; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | use opener; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/search.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/persistence.rs:1:104 [INFO] [stdout] | [INFO] [stdout] 1 | ...::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/search.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use serde_json; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/persistence.rs:1:104 [INFO] [stdout] | [INFO] [stdout] 1 | ...::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";... [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stdout] --> src/search.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | fn ne(&self, other: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stdout] = note: `#[warn(clippy::partialeq_ne_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | return self.keyword == other.keyword; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return self.keyword == other.keyword; [INFO] [stdout] 22 + self.keyword == other.keyword [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return self.keyword != other.keyword; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return self.keyword != other.keyword; [INFO] [stdout] 26 + self.keyword != other.keyword [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return serde_json::from_str(s.as_str()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return serde_json::from_str(s.as_str()).unwrap(); [INFO] [stdout] 33 + serde_json::from_str(s.as_str()).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/search.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | / let mut searches = Vec::new(); [INFO] [stdout] 46 | | searches.push(Search::new("https://www.youtube.com/results?search_query=", "Youtube", "yt")); [INFO] [stdout] 47 | | searches.push(Search::new("https://medium.com/search?q=", "Medium", "md")); [INFO] [stdout] 48 | | searches.push(Search::new("https://stackoverflow.com/search?q=", "StackOverflow", "so")); [INFO] [stdout] ... | [INFO] [stdout] 51 | | searches.push(Search::new("https://www.duckduckgo.com/?q=", "Duck Duck Go", "dd")); [INFO] [stdout] 52 | | searches.push(Search::new( "https://www.bing.com/search?q=", "Bing", "bi")); [INFO] [stdout] | |____________________________________________________________________________________^ help: consider using the `vec![]` macro: `let searches = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | return map; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return map; [INFO] [stdout] 69 + map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/search.rs:64:35 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn convert_to_map(vector: &Vec) -> HashMap<&String, &String> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 64 - pub fn convert_to_map(vector: &Vec) -> HashMap<&String, &String> { [INFO] [stdout] 64 + pub fn convert_to_map(vector: &[Self]) -> HashMap<&String, &String> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | return map; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return map; [INFO] [stdout] 77 + map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/search.rs:72:40 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn map_keyword_to_self(vector: &Vec) -> HashMap<&String, &Search> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 72 - pub fn map_keyword_to_self(vector: &Vec) -> HashMap<&String, &Search> { [INFO] [stdout] 72 + pub fn map_keyword_to_self(vector: &[Self]) -> HashMap<&String, &Search> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/search.rs:75:36 [INFO] [stdout] | [INFO] [stdout] 75 | map.insert(&x.keyword, &x); [INFO] [stdout] | ^^ help: change this to: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stdout] --> src/search.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | fn ne(&self, other: &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stdout] = note: `#[warn(clippy::partialeq_ne_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | return self.keyword == other.keyword; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return self.keyword == other.keyword; [INFO] [stdout] 22 + self.keyword == other.keyword [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_ok` [INFO] [stdout] --> src/persistence.rs:1:1235 [INFO] [stdout] | [INFO] [stdout] 1 | ..._writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created... [INFO] [stdout] | ----------------- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: try: `if let Ok() = result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return self.keyword != other.keyword; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return self.keyword != other.keyword; [INFO] [stdout] 26 + self.keyword != other.keyword [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return serde_json::from_str(s.as_str()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return serde_json::from_str(s.as_str()).unwrap(); [INFO] [stdout] 33 + serde_json::from_str(s.as_str()).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/persistence.rs:1:1317 [INFO] [stdout] | [INFO] [stdout] 1 | ...rn PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ le... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1 - use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] 1 + use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ PersistenceResult::Error␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/persistence.rs:1:1537 [INFO] [stdout] | [INFO] [stdout] 1 | ...er(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool ... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1 - use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] 1 + use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ serde_json::from_value(read).unwrap()␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/search.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | / let mut searches = Vec::new(); [INFO] [stdout] 46 | | searches.push(Search::new("https://www.youtube.com/results?search_query=", "Youtube", "yt")); [INFO] [stdout] 47 | | searches.push(Search::new("https://medium.com/search?q=", "Medium", "md")); [INFO] [stdout] 48 | | searches.push(Search::new("https://stackoverflow.com/search?q=", "StackOverflow", "so")); [INFO] [stdout] ... | [INFO] [stdout] 51 | | searches.push(Search::new("https://www.duckduckgo.com/?q=", "Duck Duck Go", "dd")); [INFO] [stdout] 52 | | searches.push(Search::new( "https://www.bing.com/search?q=", "Bing", "bi")); [INFO] [stdout] | |____________________________________________________________________________________^ help: consider using the `vec![]` macro: `let searches = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | return map; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return map; [INFO] [stdout] 69 + map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/search.rs:64:35 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn convert_to_map(vector: &Vec) -> HashMap<&String, &String> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 64 - pub fn convert_to_map(vector: &Vec) -> HashMap<&String, &String> { [INFO] [stdout] 64 + pub fn convert_to_map(vector: &[Self]) -> HashMap<&String, &String> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/search.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | return map; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return map; [INFO] [stdout] 77 + map [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/search.rs:72:40 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn map_keyword_to_self(vector: &Vec) -> HashMap<&String, &Search> { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 72 - pub fn map_keyword_to_self(vector: &Vec) -> HashMap<&String, &Search> { [INFO] [stdout] 72 + pub fn map_keyword_to_self(vector: &[Self]) -> HashMap<&String, &Search> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/persistence.rs:1:1634 [INFO] [stdout] | [INFO] [stdout] 1 | ...lready_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) ... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1 - use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] 1 + use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ Path::exists(get_location().as_path().parent().unwrap())␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/persistence.rs:1:2088 [INFO] [stdout] | [INFO] [stdout] 1 | ...sedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> Persistence... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1 - use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] 1 + use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ PersistenceResult::Created␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/search.rs:75:36 [INFO] [stdout] | [INFO] [stdout] 75 | map.insert(&x.keyword, &x); [INFO] [stdout] | ^^ help: change this to: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/persistence.rs:1:2496 [INFO] [stdout] | [INFO] [stdout] 1 | ...sedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1 - use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] 1 + use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ PersistenceResult::Deleted␍ }␍}␍ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_ok` [INFO] [stdout] --> src/persistence.rs:1:1235 [INFO] [stdout] | [INFO] [stdout] 1 | ..._writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created... [INFO] [stdout] | ----------------- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: try: `if let Ok() = result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:91:56 [INFO] [stdout] | [INFO] [stdout] 91 | (!matches.as_ref().unwrap().args.is_empty() || !matches.as_ref().unwrap().subcommand.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `matches.as_ref().unwrap().subcommand.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | if searches.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `searches.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `searches` [INFO] [stdout] --> src/main.rs:68:14 [INFO] [stdout] | [INFO] [stdout] 68 | for i in 0..searches.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 68 - for i in 0..searches.len() { [INFO] [stdout] 68 + for in &searches { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/persistence.rs:1:1317 [INFO] [stdout] | [INFO] [stdout] 1 | ...rn PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ le... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1 - use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] 1 + use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ PersistenceResult::Error␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/persistence.rs:1:1537 [INFO] [stdout] | [INFO] [stdout] 1 | ...er(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool ... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1 - use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] 1 + use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ serde_json::from_value(read).unwrap()␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:101:31 [INFO] [stdout] | [INFO] [stdout] 101 | if Url::parse(&url) == Err(UrlError::RelativeUrlWithoutBase) { [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/persistence.rs:1:1634 [INFO] [stdout] | [INFO] [stdout] 1 | ...lready_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) ... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1 - use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] 1 + use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ Path::exists(get_location().as_path().parent().unwrap())␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/persistence.rs:1:2088 [INFO] [stdout] | [INFO] [stdout] 1 | ...sedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> Persistence... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1 - use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] 1 + use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ PersistenceResult::Created␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/persistence.rs:1:2496 [INFO] [stdout] | [INFO] [stdout] 1 | ...sedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1 - use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] 1 + use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ PersistenceResult::Deleted␍ }␍}␍ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/main.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | / match matched_keyword { [INFO] [stdout] 133 | | _ => { [INFO] [stdout] 134 | | let search_keyword = get_first_keyword(&matched_keyword); [INFO] [stdout] 135 | | let query_to_be_searched: Vec<&str> = [INFO] [stdout] ... | [INFO] [stdout] 140 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 132 ~ { [INFO] [stdout] 133 + let search_keyword = get_first_keyword(&matched_keyword); [INFO] [stdout] 134 + let query_to_be_searched: Vec<&str> = [INFO] [stdout] 135 + (&matched_keyword).values_of(&search_keyword).unwrap().collect(); [INFO] [stdout] 136 + let link = build_search_query_link(&search_keyword, &query_to_be_searched.join(" "), searches); [INFO] [stdout] 137 + launch_browser(&link); [INFO] [stdout] 138 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:134:56 [INFO] [stdout] | [INFO] [stdout] 134 | let search_keyword = get_first_keyword(&matched_keyword); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `matched_keyword` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:136:21 [INFO] [stdout] | [INFO] [stdout] 136 | (&matched_keyword).values_of(&search_keyword).unwrap().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `matched_keyword` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:91:56 [INFO] [stdout] | [INFO] [stdout] 91 | (!matches.as_ref().unwrap().args.is_empty() || !matches.as_ref().unwrap().subcommand.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `matches.as_ref().unwrap().subcommand.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | if searches.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `searches.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `searches` [INFO] [stdout] --> src/main.rs:68:14 [INFO] [stdout] | [INFO] [stdout] 68 | for i in 0..searches.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 68 - for i in 0..searches.len() { [INFO] [stdout] 68 + for in &searches { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:101:31 [INFO] [stdout] | [INFO] [stdout] 101 | if Url::parse(&url) == Err(UrlError::RelativeUrlWithoutBase) { [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | String::from(matches.args.keys().take(1).map(|s| &**s).collect::>().join(",")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `matches.args.keys().take(1).map(|s| &**s).collect::>().join(",")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:155:5 [INFO] [stdout] | [INFO] [stdout] 155 | return FileBasedSearchPersistence::load(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 155 - return FileBasedSearchPersistence::load(); [INFO] [stdout] 155 + FileBasedSearchPersistence::load() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:162:5 [INFO] [stdout] | [INFO] [stdout] 162 | return link; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 - return link; [INFO] [stdout] 162 + link [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:158:51 [INFO] [stdout] | [INFO] [stdout] 158 | fn build_search_query_link(input: &String, query: &String, searches: Vec) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 158 - fn build_search_query_link(input: &String, query: &String, searches: Vec) -> String { [INFO] [stdout] 158 + fn build_search_query_link(input: &String, query: &str, searches: Vec) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:180:25 [INFO] [stdout] | [INFO] [stdout] 180 | fn launch_browser(link: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 180 ~ fn launch_browser(link: &str) { [INFO] [stdout] 181 ~ opener::open(link); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/main.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | / match matched_keyword { [INFO] [stdout] 133 | | _ => { [INFO] [stdout] 134 | | let search_keyword = get_first_keyword(&matched_keyword); [INFO] [stdout] 135 | | let query_to_be_searched: Vec<&str> = [INFO] [stdout] ... | [INFO] [stdout] 140 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 132 ~ { [INFO] [stdout] 133 + let search_keyword = get_first_keyword(&matched_keyword); [INFO] [stdout] 134 + let query_to_be_searched: Vec<&str> = [INFO] [stdout] 135 + (&matched_keyword).values_of(&search_keyword).unwrap().collect(); [INFO] [stdout] 136 + let link = build_search_query_link(&search_keyword, &query_to_be_searched.join(" "), searches); [INFO] [stdout] 137 + launch_browser(&link); [INFO] [stdout] 138 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:134:56 [INFO] [stdout] | [INFO] [stdout] 134 | let search_keyword = get_first_keyword(&matched_keyword); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `matched_keyword` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:136:21 [INFO] [stdout] | [INFO] [stdout] 136 | (&matched_keyword).values_of(&search_keyword).unwrap().collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `matched_keyword` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | String::from(matches.args.keys().take(1).map(|s| &**s).collect::>().join(",")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `matches.args.keys().take(1).map(|s| &**s).collect::>().join(",")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:155:5 [INFO] [stdout] | [INFO] [stdout] 155 | return FileBasedSearchPersistence::load(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 155 - return FileBasedSearchPersistence::load(); [INFO] [stdout] 155 + FileBasedSearchPersistence::load() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:162:5 [INFO] [stdout] | [INFO] [stdout] 162 | return link; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 - return link; [INFO] [stdout] 162 + link [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:158:51 [INFO] [stdout] | [INFO] [stdout] 158 | fn build_search_query_link(input: &String, query: &String, searches: Vec) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 158 - fn build_search_query_link(input: &String, query: &String, searches: Vec) -> String { [INFO] [stdout] 158 + fn build_search_query_link(input: &String, query: &str, searches: Vec) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:180:25 [INFO] [stdout] | [INFO] [stdout] 180 | fn launch_browser(link: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 180 ~ fn launch_browser(link: &str) { [INFO] [stdout] 181 ~ opener::open(link); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:181:5 [INFO] [stdout] | [INFO] [stdout] 181 | opener::open(link.as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 181 | let _ = opener::open(link.as_str()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/persistence.rs:1:804 [INFO] [stdout] | [INFO] [stdout] 1 | ...ch]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::ne... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1 | use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ let _ = fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/main.rs:181:5 [INFO] [stdout] | [INFO] [stdout] 181 | opener::open(link.as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 181 | let _ = opener::open(link.as_str()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/persistence.rs:1:804 [INFO] [stdout] | [INFO] [stdout] 1 | ...ch]) -> PersistenceResult {␍ fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::ne... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1 | use std::fs::{File, OpenOptions};␍use std::fs;␍use std::io::BufReader;␍use std::path::{Path, PathBuf};␍use serde_json;␍␍use crate::search::Search;␍␍static FILE_NAME: &str = "ssearch.json";␍␍fn get_location() -> Box {␍ Box::new(dirs::home_dir().unwrap().join(".ssearch").join(FILE_NAME))␍}␍␍pub trait Persistence {␍ fn write(t: &[T]) -> PersistenceResult;␍ fn load() -> Vec;␍ fn is_already_exits() -> bool;␍ fn update(t: Search) -> PersistenceResult;␍ fn remove(kw: String) -> PersistenceResult;␍}␍␍pub struct FileBasedSearchPersistence;␍␍#[derive(PartialEq)]␍pub enum PersistenceResult {␍ Created,␍ Updated,␍ Deleted,␍ Error,␍ Nothing,␍}␍␍impl Persistence for FileBasedSearchPersistence {␍ fn write(t: &[Search]) -> PersistenceResult {␍ let _ = fs::create_dir(get_location().as_path().parent().unwrap());␍ let file = OpenOptions::new()␍ .create(true)␍ .read(true)␍ .write(true)␍ .truncate(true)␍ .open(get_location().as_path());␍ if file.is_err() {␍ return PersistenceResult::Error;␍ }␍ let result = serde_json::to_writer(&file.unwrap(), t);␍ if result.is_ok() {␍ result.unwrap();␍ return PersistenceResult::Created;␍ }␍ return PersistenceResult::Error;␍ }␍␍ fn load() -> Vec {␍ let file = File::open(get_location().as_path()).unwrap();␍ let read = serde_json::from_reader(BufReader::new(file)).unwrap();␍ return serde_json::from_value(read).unwrap();␍ }␍␍ fn is_already_exits() -> bool {␍ return Path::exists(get_location().as_path().parent().unwrap());␍ }␍␍ fn update(t: Search) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| *x != t);␍ if contents.len() < original_size {␍ return PersistenceResult::Updated;␍ }␍ contents.push(t);␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Created;␍ }␍␍ fn remove(kw: String) -> PersistenceResult {␍ let mut contents = FileBasedSearchPersistence::load();␍ let original_size = contents.len();␍ contents.retain(|x| x.keyword != kw);␍ if original_size == contents.len() {␍ return PersistenceResult::Nothing;␍ }␍ FileBasedSearchPersistence::write(&contents);␍ return PersistenceResult::Deleted;␍ }␍}␍ [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.12s [INFO] running `Command { std: "docker" "inspect" "113cc0d035df16ebd2a9b827be0ae4487f027fe705b992dbb5b5c0272cac0034", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "113cc0d035df16ebd2a9b827be0ae4487f027fe705b992dbb5b5c0272cac0034", kill_on_drop: false }` [INFO] [stdout] 113cc0d035df16ebd2a9b827be0ae4487f027fe705b992dbb5b5c0272cac0034