[INFO] fetching crate ssd1322 0.3.0... [INFO] linting ssd1322-0.3.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ssd1322 0.3.0 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate ssd1322 0.3.0 [INFO] finished tweaking crates.io crate ssd1322 0.3.0 [INFO] tweaked toml for crates.io crate ssd1322 0.3.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ssd1322 0.3.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] [stderr] Adding embedded-hal v0.2.7 (available: v1.0.0) [INFO] [stderr] Adding itertools v0.7.11 (available: v0.14.0) [INFO] [stderr] Adding nb v0.1.3 (available: v1.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3b61c2df4a8d203d812bcb28b8a45191a9bb95e38ce23a28515aef1385373118 [INFO] running `Command { std: "docker" "start" "-a" "3b61c2df4a8d203d812bcb28b8a45191a9bb95e38ce23a28515aef1385373118", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3b61c2df4a8d203d812bcb28b8a45191a9bb95e38ce23a28515aef1385373118", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b61c2df4a8d203d812bcb28b8a45191a9bb95e38ce23a28515aef1385373118", kill_on_drop: false }` [INFO] [stdout] 3b61c2df4a8d203d812bcb28b8a45191a9bb95e38ce23a28515aef1385373118 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8f5b49b39693c5c97fe599d47222c3547335092b240066a5e30caa341f4048ed [INFO] running `Command { std: "docker" "start" "-a" "8f5b49b39693c5c97fe599d47222c3547335092b240066a5e30caa341f4048ed", kill_on_drop: false }` [INFO] [stderr] Checking nb v0.1.3 [INFO] [stderr] Checking itertools v0.7.11 [INFO] [stderr] Checking embedded-hal v0.2.7 [INFO] [stderr] Checking ssd1322 v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/mod.rs:212:9 [INFO] [stdout] | [INFO] [stdout] 212 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] = note: `#[warn(clippy::deprecated_cfg_attr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/mod.rs:238:9 [INFO] [stdout] | [INFO] [stdout] 238 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/mod.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 264 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/mod.rs:212:9 [INFO] [stdout] | [INFO] [stdout] 212 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] = note: `#[warn(clippy::deprecated_cfg_attr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/mod.rs:238:9 [INFO] [stdout] | [INFO] [stdout] 238 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/mod.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 264 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:195:9 [INFO] [stdout] | [INFO] [stdout] 195 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:250:9 [INFO] [stdout] | [INFO] [stdout] 250 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:275:9 [INFO] [stdout] | [INFO] [stdout] 275 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 292 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:313:9 [INFO] [stdout] | [INFO] [stdout] 313 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:334:9 [INFO] [stdout] | [INFO] [stdout] 334 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:347:9 [INFO] [stdout] | [INFO] [stdout] 347 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/region.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/region.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/region.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 191 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/region.rs:213:9 [INFO] [stdout] | [INFO] [stdout] 213 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:195:9 [INFO] [stdout] | [INFO] [stdout] 195 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:250:9 [INFO] [stdout] | [INFO] [stdout] 250 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:275:9 [INFO] [stdout] | [INFO] [stdout] 275 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 292 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:313:9 [INFO] [stdout] | [INFO] [stdout] 313 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:334:9 [INFO] [stdout] | [INFO] [stdout] 334 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/overscanned_region.rs:347:9 [INFO] [stdout] | [INFO] [stdout] 347 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/region.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/region.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/region.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 191 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes [INFO] [stdout] --> src/display/region.rs:213:9 [INFO] [stdout] | [INFO] [stdout] 213 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | com_scan_direction: com_scan_direction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `com_scan_direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 61 | com_layout: com_layout, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `com_layout` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/display/overscanned_region.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | viewable_region: viewable_region, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `viewable_region` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/display/overscanned_region.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | upper_left: upper_left, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `upper_left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/display/overscanned_region.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | lower_right: lower_right, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lower_right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/display/overscanned_region.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | viewable_pixel_cols: viewable_pixel_cols, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `viewable_pixel_cols` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/display/region.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | iface: iface, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `iface` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/display/mod.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | iface: iface, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `iface` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/display/mod.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | display_size: display_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `display_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/display/mod.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | display_offset: display_offset, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `display_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/interface.rs:62:20 [INFO] [stdout] | [INFO] [stdout] 62 | Self { spi: spi, dc: dc } [INFO] [stdout] | ^^^^^^^^ help: replace it with: `spi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/interface.rs:62:30 [INFO] [stdout] | [INFO] [stdout] 62 | Self { spi: spi, dc: dc } [INFO] [stdout] | ^^^^^^ help: replace it with: `dc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:60:17 [INFO] [stdout] | [INFO] [stdout] 60 | com_scan_direction: com_scan_direction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `com_scan_direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 61 | com_layout: com_layout, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `com_layout` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/display/overscanned_region.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | viewable_region: viewable_region, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `viewable_region` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/display/overscanned_region.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | upper_left: upper_left, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `upper_left` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/display/overscanned_region.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | lower_right: lower_right, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lower_right` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/display/overscanned_region.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | viewable_pixel_cols: viewable_pixel_cols, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `viewable_pixel_cols` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/display/region.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | iface: iface, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `iface` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/display/mod.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | iface: iface, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `iface` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/display/mod.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | display_size: display_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `display_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/display/mod.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | display_offset: display_offset, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `display_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/interface.rs:62:20 [INFO] [stdout] | [INFO] [stdout] 62 | Self { spi: spi, dc: dc } [INFO] [stdout] | ^^^^^^^^ help: replace it with: `spi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/interface.rs:62:30 [INFO] [stdout] | [INFO] [stdout] 62 | Self { spi: spi, dc: dc } [INFO] [stdout] | ^^^^^^ help: replace it with: `dc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/command.rs:395:22 [INFO] [stdout] | [INFO] [stdout] 395 | .map_err(|e| CommandError::InterfaceError(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `CommandError::InterfaceError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/command.rs:396:12 [INFO] [stdout] | [INFO] [stdout] 396 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/command.rs:401:26 [INFO] [stdout] | [INFO] [stdout] 401 | .map_err(|e| CommandError::InterfaceError(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `CommandError::InterfaceError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/command.rs:436:22 [INFO] [stdout] | [INFO] [stdout] 436 | .map_err(|e| CommandError::InterfaceError(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `CommandError::InterfaceError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/command.rs:437:12 [INFO] [stdout] | [INFO] [stdout] 437 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/command.rs:442:26 [INFO] [stdout] | [INFO] [stdout] 442 | .map_err(|e| CommandError::InterfaceError(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `CommandError::InterfaceError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | || display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] 62 | | || display_size.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 63 | | || display_offset.0 + display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] 64 | | || display_offset.1 + display_size.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 65 | | || display_size.0.rem_euclid(4) != 0 [INFO] [stdout] 66 | | || display_offset.0.rem_euclid(4) != 0 [INFO] [stdout] | |__________________________________________________^ help: try: `display_size.0 > NUM_PIXEL_COLS as i16 || display_size.1 > NUM_PIXEL_ROWS as i16 || display_offset.0 + display_size.0 > NUM_PIXEL_COLS as i16 || display_offset.1 + display_size.1 > NUM_PIXEL_ROWS as i16 || display_size.0.rem_euclid(4) != 0 || display_offset.0.rem_euclid(4) != 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | || display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] 62 | | || display_size.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 63 | | || display_offset.0 + display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] 64 | | || display_offset.1 + display_size.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 65 | | || display_size.0.rem_euclid(4) != 0 [INFO] [stdout] | |________________________________________________^ help: try: `display_size.0 > NUM_PIXEL_COLS as i16 || display_size.1 > NUM_PIXEL_ROWS as i16 || display_offset.0 + display_size.0 > NUM_PIXEL_COLS as i16 || display_offset.1 + display_size.1 > NUM_PIXEL_ROWS as i16 || display_size.0.rem_euclid(4) != 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | || display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] 62 | | || display_size.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 63 | | || display_offset.0 + display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] 64 | | || display_offset.1 + display_size.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] | |________________________________________________________________________^ help: try: `display_size.0 > NUM_PIXEL_COLS as i16 || display_size.1 > NUM_PIXEL_ROWS as i16 || display_offset.0 + display_size.0 > NUM_PIXEL_COLS as i16 || display_offset.1 + display_size.1 > NUM_PIXEL_ROWS as i16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | || display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] 62 | | || display_size.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 63 | | || display_offset.0 + display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] | |________________________________________________________________________^ help: try: `display_size.0 > NUM_PIXEL_COLS as i16 || display_size.1 > NUM_PIXEL_ROWS as i16 || display_offset.0 + display_size.0 > NUM_PIXEL_COLS as i16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | || display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] 62 | | || display_size.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] | |_____________________________________________________^ help: try: `display_size.0 > NUM_PIXEL_COLS as i16 || display_size.1 > NUM_PIXEL_ROWS as i16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | || display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] | |_____________________________________________________^ help: try: `display_size.0 > NUM_PIXEL_COLS as i16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | || upper_left.0 > self.display_size.0 [INFO] [stdout] 148 | | || lower_right.0 > self.display_size.0 [INFO] [stdout] 149 | | || upper_left.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 150 | | || lower_right.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 151 | | || upper_left.0 >= lower_right.0 [INFO] [stdout] 152 | | || upper_left.1 >= lower_right.1 [INFO] [stdout] | |____________________________________________^ help: try: `upper_left.0 > self.display_size.0 || lower_right.0 > self.display_size.0 || upper_left.1 > NUM_PIXEL_ROWS as i16 || lower_right.1 > NUM_PIXEL_ROWS as i16 || upper_left.0 >= lower_right.0 || upper_left.1 >= lower_right.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | || upper_left.0 > self.display_size.0 [INFO] [stdout] 148 | | || lower_right.0 > self.display_size.0 [INFO] [stdout] 149 | | || upper_left.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 150 | | || lower_right.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 151 | | || upper_left.0 >= lower_right.0 [INFO] [stdout] | |____________________________________________^ help: try: `upper_left.0 > self.display_size.0 || lower_right.0 > self.display_size.0 || upper_left.1 > NUM_PIXEL_ROWS as i16 || lower_right.1 > NUM_PIXEL_ROWS as i16 || upper_left.0 >= lower_right.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | || upper_left.0 > self.display_size.0 [INFO] [stdout] 148 | | || lower_right.0 > self.display_size.0 [INFO] [stdout] 149 | | || upper_left.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 150 | | || lower_right.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] | |____________________________________________________^ help: try: `upper_left.0 > self.display_size.0 || lower_right.0 > self.display_size.0 || upper_left.1 > NUM_PIXEL_ROWS as i16 || lower_right.1 > NUM_PIXEL_ROWS as i16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | || upper_left.0 > self.display_size.0 [INFO] [stdout] 148 | | || lower_right.0 > self.display_size.0 [INFO] [stdout] 149 | | || upper_left.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] | |___________________________________________________^ help: try: `upper_left.0 > self.display_size.0 || lower_right.0 > self.display_size.0 || upper_left.1 > NUM_PIXEL_ROWS as i16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | || upper_left.0 > self.display_size.0 [INFO] [stdout] 148 | | || lower_right.0 > self.display_size.0 [INFO] [stdout] | |__________________________________________________^ help: try: `upper_left.0 > self.display_size.0 || lower_right.0 > self.display_size.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | || upper_left.0 > self.display_size.0 [INFO] [stdout] | |_________________________________________________^ help: try: `upper_left.0 > self.display_size.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 182 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 183 | | || upper_left.0 >= lower_right.0 [INFO] [stdout] 184 | | || upper_left.1 >= lower_right.1 [INFO] [stdout] 185 | | || upper_left.0.rem_euclid(4) != 0 [INFO] [stdout] 186 | | || lower_right.0.rem_euclid(4) != 0 [INFO] [stdout] | |_______________________________________________^ help: try: `upper_left.0 >= lower_right.0 || upper_left.1 >= lower_right.1 || upper_left.0.rem_euclid(4) != 0 || lower_right.0.rem_euclid(4) != 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 182 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 183 | | || upper_left.0 >= lower_right.0 [INFO] [stdout] 184 | | || upper_left.1 >= lower_right.1 [INFO] [stdout] 185 | | || upper_left.0.rem_euclid(4) != 0 [INFO] [stdout] | |______________________________________________^ help: try: `upper_left.0 >= lower_right.0 || upper_left.1 >= lower_right.1 || upper_left.0.rem_euclid(4) != 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 182 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 183 | | || upper_left.0 >= lower_right.0 [INFO] [stdout] 184 | | || upper_left.1 >= lower_right.1 [INFO] [stdout] | |____________________________________________^ help: try: `upper_left.0 >= lower_right.0 || upper_left.1 >= lower_right.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 182 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 183 | | || upper_left.0 >= lower_right.0 [INFO] [stdout] | |____________________________________________^ help: try: `upper_left.0 >= lower_right.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/interface.rs:80:23 [INFO] [stdout] | [INFO] [stdout] 80 | while let Ok(_) = self.spi.read() { [INFO] [stdout] | ----------^^^^^------------------ help: try: `while self.spi.read().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/interface.rs:95:42 [INFO] [stdout] | [INFO] [stdout] 95 | nb::block!(self.spi.send(word.clone())).map_err(Self::Error::from_spi)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*word` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/command.rs:395:22 [INFO] [stdout] | [INFO] [stdout] 395 | .map_err(|e| CommandError::InterfaceError(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `CommandError::InterfaceError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/command.rs:396:12 [INFO] [stdout] | [INFO] [stdout] 396 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/command.rs:401:26 [INFO] [stdout] | [INFO] [stdout] 401 | .map_err(|e| CommandError::InterfaceError(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `CommandError::InterfaceError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/command.rs:436:22 [INFO] [stdout] | [INFO] [stdout] 436 | .map_err(|e| CommandError::InterfaceError(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `CommandError::InterfaceError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/command.rs:437:12 [INFO] [stdout] | [INFO] [stdout] 437 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/command.rs:442:26 [INFO] [stdout] | [INFO] [stdout] 442 | .map_err(|e| CommandError::InterfaceError(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `CommandError::InterfaceError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | || display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] 62 | | || display_size.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 63 | | || display_offset.0 + display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] 64 | | || display_offset.1 + display_size.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 65 | | || display_size.0.rem_euclid(4) != 0 [INFO] [stdout] 66 | | || display_offset.0.rem_euclid(4) != 0 [INFO] [stdout] | |__________________________________________________^ help: try: `display_size.0 > NUM_PIXEL_COLS as i16 || display_size.1 > NUM_PIXEL_ROWS as i16 || display_offset.0 + display_size.0 > NUM_PIXEL_COLS as i16 || display_offset.1 + display_size.1 > NUM_PIXEL_ROWS as i16 || display_size.0.rem_euclid(4) != 0 || display_offset.0.rem_euclid(4) != 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | || display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] 62 | | || display_size.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 63 | | || display_offset.0 + display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] 64 | | || display_offset.1 + display_size.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 65 | | || display_size.0.rem_euclid(4) != 0 [INFO] [stdout] | |________________________________________________^ help: try: `display_size.0 > NUM_PIXEL_COLS as i16 || display_size.1 > NUM_PIXEL_ROWS as i16 || display_offset.0 + display_size.0 > NUM_PIXEL_COLS as i16 || display_offset.1 + display_size.1 > NUM_PIXEL_ROWS as i16 || display_size.0.rem_euclid(4) != 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | || display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] 62 | | || display_size.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 63 | | || display_offset.0 + display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] 64 | | || display_offset.1 + display_size.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] | |________________________________________________________________________^ help: try: `display_size.0 > NUM_PIXEL_COLS as i16 || display_size.1 > NUM_PIXEL_ROWS as i16 || display_offset.0 + display_size.0 > NUM_PIXEL_COLS as i16 || display_offset.1 + display_size.1 > NUM_PIXEL_ROWS as i16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | || display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] 62 | | || display_size.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 63 | | || display_offset.0 + display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] | |________________________________________________________________________^ help: try: `display_size.0 > NUM_PIXEL_COLS as i16 || display_size.1 > NUM_PIXEL_ROWS as i16 || display_offset.0 + display_size.0 > NUM_PIXEL_COLS as i16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | || display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] 62 | | || display_size.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] | |_____________________________________________________^ help: try: `display_size.0 > NUM_PIXEL_COLS as i16 || display_size.1 > NUM_PIXEL_ROWS as i16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 61 | | || display_size.0 > NUM_PIXEL_COLS as i16 [INFO] [stdout] | |_____________________________________________________^ help: try: `display_size.0 > NUM_PIXEL_COLS as i16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | || upper_left.0 > self.display_size.0 [INFO] [stdout] 148 | | || lower_right.0 > self.display_size.0 [INFO] [stdout] 149 | | || upper_left.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 150 | | || lower_right.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 151 | | || upper_left.0 >= lower_right.0 [INFO] [stdout] 152 | | || upper_left.1 >= lower_right.1 [INFO] [stdout] | |____________________________________________^ help: try: `upper_left.0 > self.display_size.0 || lower_right.0 > self.display_size.0 || upper_left.1 > NUM_PIXEL_ROWS as i16 || lower_right.1 > NUM_PIXEL_ROWS as i16 || upper_left.0 >= lower_right.0 || upper_left.1 >= lower_right.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | || upper_left.0 > self.display_size.0 [INFO] [stdout] 148 | | || lower_right.0 > self.display_size.0 [INFO] [stdout] 149 | | || upper_left.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 150 | | || lower_right.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 151 | | || upper_left.0 >= lower_right.0 [INFO] [stdout] | |____________________________________________^ help: try: `upper_left.0 > self.display_size.0 || lower_right.0 > self.display_size.0 || upper_left.1 > NUM_PIXEL_ROWS as i16 || lower_right.1 > NUM_PIXEL_ROWS as i16 || upper_left.0 >= lower_right.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | || upper_left.0 > self.display_size.0 [INFO] [stdout] 148 | | || lower_right.0 > self.display_size.0 [INFO] [stdout] 149 | | || upper_left.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] 150 | | || lower_right.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] | |____________________________________________________^ help: try: `upper_left.0 > self.display_size.0 || lower_right.0 > self.display_size.0 || upper_left.1 > NUM_PIXEL_ROWS as i16 || lower_right.1 > NUM_PIXEL_ROWS as i16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | || upper_left.0 > self.display_size.0 [INFO] [stdout] 148 | | || lower_right.0 > self.display_size.0 [INFO] [stdout] 149 | | || upper_left.1 > NUM_PIXEL_ROWS as i16 [INFO] [stdout] | |___________________________________________________^ help: try: `upper_left.0 > self.display_size.0 || lower_right.0 > self.display_size.0 || upper_left.1 > NUM_PIXEL_ROWS as i16` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | || upper_left.0 > self.display_size.0 [INFO] [stdout] 148 | | || lower_right.0 > self.display_size.0 [INFO] [stdout] | |__________________________________________________^ help: try: `upper_left.0 > self.display_size.0 || lower_right.0 > self.display_size.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | || upper_left.0 > self.display_size.0 [INFO] [stdout] | |_________________________________________________^ help: try: `upper_left.0 > self.display_size.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 182 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 183 | | || upper_left.0 >= lower_right.0 [INFO] [stdout] 184 | | || upper_left.1 >= lower_right.1 [INFO] [stdout] 185 | | || upper_left.0.rem_euclid(4) != 0 [INFO] [stdout] 186 | | || lower_right.0.rem_euclid(4) != 0 [INFO] [stdout] | |_______________________________________________^ help: try: `upper_left.0 >= lower_right.0 || upper_left.1 >= lower_right.1 || upper_left.0.rem_euclid(4) != 0 || lower_right.0.rem_euclid(4) != 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 182 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 183 | | || upper_left.0 >= lower_right.0 [INFO] [stdout] 184 | | || upper_left.1 >= lower_right.1 [INFO] [stdout] 185 | | || upper_left.0.rem_euclid(4) != 0 [INFO] [stdout] | |______________________________________________^ help: try: `upper_left.0 >= lower_right.0 || upper_left.1 >= lower_right.1 || upper_left.0.rem_euclid(4) != 0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 182 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 183 | | || upper_left.0 >= lower_right.0 [INFO] [stdout] 184 | | || upper_left.1 >= lower_right.1 [INFO] [stdout] | |____________________________________________^ help: try: `upper_left.0 >= lower_right.0 || upper_left.1 >= lower_right.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/display/mod.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 182 | if false [INFO] [stdout] | ____________^ [INFO] [stdout] 183 | | || upper_left.0 >= lower_right.0 [INFO] [stdout] | |____________________________________________^ help: try: `upper_left.0 >= lower_right.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/interface.rs:80:23 [INFO] [stdout] | [INFO] [stdout] 80 | while let Ok(_) = self.spi.read() { [INFO] [stdout] | ----------^^^^^------------------ help: try: `while self.spi.read().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/interface.rs:95:42 [INFO] [stdout] | [INFO] [stdout] 95 | nb::block!(self.spi.send(word.clone())).map_err(Self::Error::from_spi)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*word` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TestSpyInterface` [INFO] [stdout] --> src/interface.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | / pub fn new() -> Self { [INFO] [stdout] 138 | | TestSpyInterface { [INFO] [stdout] 139 | | sent: Rc::new(RefCell::new(Vec::new())), [INFO] [stdout] 140 | | } [INFO] [stdout] 141 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 136 ~ impl Default for TestSpyInterface { [INFO] [stdout] 137 + fn default() -> Self { [INFO] [stdout] 138 + Self::new() [INFO] [stdout] 139 + } [INFO] [stdout] 140 + } [INFO] [stdout] 141 + [INFO] [stdout] 142 ~ impl TestSpyInterface { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/interface.rs:149:16 [INFO] [stdout] | [INFO] [stdout] 149 | if data.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.06s [INFO] running `Command { std: "docker" "inspect" "8f5b49b39693c5c97fe599d47222c3547335092b240066a5e30caa341f4048ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f5b49b39693c5c97fe599d47222c3547335092b240066a5e30caa341f4048ed", kill_on_drop: false }` [INFO] [stdout] 8f5b49b39693c5c97fe599d47222c3547335092b240066a5e30caa341f4048ed