[INFO] fetching crate ss-graph-rs 0.1.8... [INFO] linting ss-graph-rs-0.1.8 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ss-graph-rs 0.1.8 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate ss-graph-rs 0.1.8 [INFO] finished tweaking crates.io crate ss-graph-rs 0.1.8 [INFO] tweaked toml for crates.io crate ss-graph-rs 0.1.8 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ss-graph-rs 0.1.8 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4fe1496c2d6326bc19a1613901bbfd4ebfb39b730579e0bdf1ac12b5b6332a95 [INFO] running `Command { std: "docker" "start" "-a" "4fe1496c2d6326bc19a1613901bbfd4ebfb39b730579e0bdf1ac12b5b6332a95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4fe1496c2d6326bc19a1613901bbfd4ebfb39b730579e0bdf1ac12b5b6332a95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4fe1496c2d6326bc19a1613901bbfd4ebfb39b730579e0bdf1ac12b5b6332a95", kill_on_drop: false }` [INFO] [stdout] 4fe1496c2d6326bc19a1613901bbfd4ebfb39b730579e0bdf1ac12b5b6332a95 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 22c8baae90ef5e073ef806ad80f9a6f882114d7bea00d75c666b009fb2b81478 [INFO] running `Command { std: "docker" "start" "-a" "22c8baae90ef5e073ef806ad80f9a6f882114d7bea00d75c666b009fb2b81478", kill_on_drop: false }` [INFO] [stderr] Checking ss-graph-rs v0.1.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/graph.rs:27:14 [INFO] [stdout] | [INFO] [stdout] 27 | .or_insert(HashSet::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/graph.rs:33:18 [INFO] [stdout] | [INFO] [stdout] 33 | .or_insert(HashSet::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/graph.rs:155:17 [INFO] [stdout] | [INFO] [stdout] 155 | assert!(!graph.adjacency_list.get(&2).is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `graph.adjacency_list.get(&2).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&2).is_some()` [INFO] [stdout] --> src/graph.rs:150:38 [INFO] [stdout] | [INFO] [stdout] 150 | assert!(graph.adjacency_list.get(&2).is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&2).is_some()` [INFO] [stdout] --> src/graph.rs:155:39 [INFO] [stdout] | [INFO] [stdout] 155 | assert!(!graph.adjacency_list.get(&2).is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/graph.rs:203:17 [INFO] [stdout] | [INFO] [stdout] 203 | assert!(!graph.adjacency_list.get(&"Node2".to_string()).is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `graph.adjacency_list.get(&"Node2".to_string()).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/graph.rs:187:18 [INFO] [stdout] | [INFO] [stdout] 187 | .get(&"Node1".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `"Node1"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/graph.rs:192:18 [INFO] [stdout] | [INFO] [stdout] 192 | .get(&"Node2".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `"Node2"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/graph.rs:200:18 [INFO] [stdout] | [INFO] [stdout] 200 | .get(&"Node1".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `"Node1"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(&"Node2".to_string()).is_some()` [INFO] [stdout] --> src/graph.rs:203:39 [INFO] [stdout] | [INFO] [stdout] 203 | assert!(!graph.adjacency_list.get(&"Node2".to_string()).is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contains_key(&"Node2".to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/graph.rs:203:43 [INFO] [stdout] | [INFO] [stdout] 203 | assert!(!graph.adjacency_list.get(&"Node2".to_string()).is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `"Node2"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/graph.rs:27:14 [INFO] [stdout] | [INFO] [stdout] 27 | .or_insert(HashSet::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/graph.rs:33:18 [INFO] [stdout] | [INFO] [stdout] 33 | .or_insert(HashSet::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.23s [INFO] running `Command { std: "docker" "inspect" "22c8baae90ef5e073ef806ad80f9a6f882114d7bea00d75c666b009fb2b81478", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "22c8baae90ef5e073ef806ad80f9a6f882114d7bea00d75c666b009fb2b81478", kill_on_drop: false }` [INFO] [stdout] 22c8baae90ef5e073ef806ad80f9a6f882114d7bea00d75c666b009fb2b81478