[INFO] fetching crate spire-workload 1.3.1... [INFO] linting spire-workload-1.3.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate spire-workload 1.3.1 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate spire-workload 1.3.1 [INFO] finished tweaking crates.io crate spire-workload 1.3.1 [INFO] tweaked toml for crates.io crate spire-workload 1.3.1 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate spire-workload 1.3.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate spire-workload 1.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rusticata-macros v3.2.0 [INFO] [stderr] Downloaded der-oid-macro v0.4.0 [INFO] [stderr] Downloaded quote v1.0.17 [INFO] [stderr] Downloaded tonic-build v0.7.2 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.79 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.79 [INFO] [stderr] Downloaded jsonwebtoken v7.2.0 [INFO] [stderr] Downloaded async-stream-impl v0.3.3 [INFO] [stderr] Downloaded yasna v0.4.0 [INFO] [stderr] Downloaded serde_test v1.0.136 [INFO] [stderr] Downloaded anyhow v1.0.56 [INFO] [stderr] Downloaded arc-swap v1.5.0 [INFO] [stderr] Downloaded tower-http v0.3.3 [INFO] [stderr] Downloaded axum v0.5.4 [INFO] [stderr] Downloaded tokio-util v0.7.1 [INFO] [stderr] Downloaded h2 v0.3.12 [INFO] [stderr] Downloaded tower v0.4.12 [INFO] [stderr] Downloaded tracing-core v0.1.23 [INFO] [stderr] Downloaded wasm-bindgen v0.2.79 [INFO] [stderr] Downloaded rustls v0.20.4 [INFO] [stderr] Downloaded syn v1.0.90 [INFO] [stderr] Downloaded js-sys v0.3.56 [INFO] [stderr] Downloaded tonic v0.7.2 [INFO] [stderr] Downloaded pin-project v1.0.10 [INFO] [stderr] Downloaded mio v0.8.2 [INFO] [stderr] Downloaded tracing v0.1.32 [INFO] [stderr] Downloaded log v0.4.16 [INFO] [stderr] Downloaded rcgen v0.8.14 [INFO] [stderr] Downloaded parking_lot v0.12.0 [INFO] [stderr] Downloaded x509-parser v0.9.2 [INFO] [stderr] Downloaded prost v0.10.4 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.79 [INFO] [stderr] Downloaded matchit v0.5.0 [INFO] [stderr] Downloaded tokio-rustls v0.23.3 [INFO] [stderr] Downloaded libc v0.2.121 [INFO] [stderr] Downloaded pin-project-internal v1.0.10 [INFO] [stderr] Downloaded tokio v1.17.0 [INFO] [stderr] Downloaded redox_syscall v0.2.12 [INFO] [stderr] Downloaded windows_aarch64_msvc v0.32.0 [INFO] [stderr] Downloaded windows_x86_64_msvc v0.32.0 [INFO] [stderr] Downloaded web-sys v0.3.56 [INFO] [stderr] Downloaded oid-registry v0.1.5 [INFO] [stderr] Downloaded windows_i686_msvc v0.32.0 [INFO] [stderr] Downloaded windows_x86_64_gnu v0.32.0 [INFO] [stderr] Downloaded windows_i686_gnu v0.32.0 [INFO] [stderr] Downloaded tokio-stream v0.1.8 [INFO] [stderr] Downloaded prost-derive v0.10.1 [INFO] [stderr] Downloaded prost-types v0.10.1 [INFO] [stderr] Downloaded lock_api v0.4.6 [INFO] [stderr] Downloaded smallvec v1.8.0 [INFO] [stderr] Downloaded parking_lot_core v0.9.1 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.79 [INFO] [stderr] Downloaded async-stream v0.3.3 [INFO] [stderr] Downloaded axum-core v0.2.3 [INFO] [stderr] Downloaded httparse v1.6.0 [INFO] [stderr] Downloaded der-parser v5.1.2 [INFO] [stderr] Downloaded prost-build v0.10.4 [INFO] [stderr] Downloaded prettyplease v0.1.18 [INFO] [stderr] Downloaded windows-sys v0.32.0 [INFO] [stderr] Downloaded openssl-src v111.18.0+1.1.1n [INFO] [stderr] Downloaded tracing-attributes v0.1.20 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 175a50ae9d3b8ca75c268b3d0722de9de2f273ee61475090d55bb93261ee1642 [INFO] running `Command { std: "docker" "start" "-a" "175a50ae9d3b8ca75c268b3d0722de9de2f273ee61475090d55bb93261ee1642", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "175a50ae9d3b8ca75c268b3d0722de9de2f273ee61475090d55bb93261ee1642", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "175a50ae9d3b8ca75c268b3d0722de9de2f273ee61475090d55bb93261ee1642", kill_on_drop: false }` [INFO] [stdout] 175a50ae9d3b8ca75c268b3d0722de9de2f273ee61475090d55bb93261ee1642 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 234d3622858d6d3102bf969eaa9a6a2c162b267f05eae8abb3fb63cd4dc671f8 [INFO] running `Command { std: "docker" "start" "-a" "234d3622858d6d3102bf969eaa9a6a2c162b267f05eae8abb3fb63cd4dc671f8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.90 [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling parking_lot_core v0.9.1 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Checking lock_api v0.4.6 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling anyhow v1.0.56 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking tracing-core v0.1.23 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling itertools v0.10.3 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling nom v6.1.2 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking http v0.2.6 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Compiling radium v0.5.3 [INFO] [stderr] Compiling quote v1.0.17 [INFO] [stderr] Compiling cmake v0.1.48 [INFO] [stderr] Compiling arrayvec v0.5.2 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Compiling which v4.2.5 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling static_assertions v1.1.0 [INFO] [stderr] Compiling ryu v1.0.9 [INFO] [stderr] Compiling funty v1.1.0 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Compiling tap v1.0.1 [INFO] [stderr] Compiling wyz v0.2.0 [INFO] [stderr] Compiling httparse v1.6.0 [INFO] [stderr] Checking bitvec v0.19.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling prost-build v0.10.4 [INFO] [stderr] Compiling aho-corasick v0.7.18 [INFO] [stderr] Compiling openssl-src v111.18.0+1.1.1n [INFO] [stderr] Compiling regex-syntax v0.6.27 [INFO] [stderr] Checking http-body v0.4.4 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Compiling remove_dir_all v0.5.3 [INFO] [stderr] Compiling prettyplease v0.1.18 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Compiling fastrand v1.7.0 [INFO] [stderr] Compiling async-trait v0.1.53 [INFO] [stderr] Compiling petgraph v0.6.2 [INFO] [stderr] Compiling tempfile v3.3.0 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling openssl-sys v0.9.72 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling rustls v0.20.4 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling multimap v0.8.3 [INFO] [stderr] Checking tower-layer v0.3.1 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Compiling rustversion v1.0.6 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Checking http-range-header v0.3.0 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling oid-registry v0.1.5 [INFO] [stderr] Checking matchit v0.5.0 [INFO] [stderr] Checking sync_wrapper v0.1.1 [INFO] [stderr] Compiling regex v1.6.0 [INFO] [stderr] Compiling openssl v0.10.38 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rustls-pemfile v1.0.1 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Compiling serde_test v1.0.136 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking data-encoding v2.3.2 [INFO] [stderr] Checking yasna v0.4.0 [INFO] [stderr] Checking pem v1.0.2 [INFO] [stderr] Checking arc-swap v1.5.0 [INFO] [stderr] Checking rcgen v0.8.14 [INFO] [stderr] Checking simple_asn1 v0.4.1 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking pem v0.8.3 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking rusticata-macros v3.2.0 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling futures-macro v0.3.21 [INFO] [stderr] Compiling tracing-attributes v0.1.20 [INFO] [stderr] Compiling prost-derive v0.10.1 [INFO] [stderr] Compiling pin-project-internal v1.0.10 [INFO] [stderr] Compiling async-stream-impl v0.3.3 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking async-stream v0.3.3 [INFO] [stderr] Checking pin-project v1.0.10 [INFO] [stderr] Checking tracing v0.1.32 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Compiling prost v0.10.4 [INFO] [stderr] Compiling der-oid-macro v0.4.0 [INFO] [stderr] Compiling prost-types v0.10.1 [INFO] [stderr] Checking der-parser v5.1.2 [INFO] [stderr] Checking x509-parser v0.9.2 [INFO] [stderr] Compiling tonic-build v0.7.2 [INFO] [stderr] Compiling spire-workload v1.3.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking tokio-util v0.6.9 [INFO] [stderr] Checking tokio-util v0.7.1 [INFO] [stderr] Checking axum-core v0.2.3 [INFO] [stderr] Checking tokio-io-timeout v1.2.0 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Checking tokio-rustls v0.23.3 [INFO] [stderr] Checking tokio-stream v0.1.8 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking tower v0.4.12 [INFO] [stderr] Checking h2 v0.3.12 [INFO] [stderr] Checking tower-http v0.3.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking jsonwebtoken v7.2.0 [INFO] [stderr] Checking hyper v0.14.18 [INFO] [stderr] Checking hyper-timeout v0.4.1 [INFO] [stderr] Checking axum v0.5.4 [INFO] [stderr] Checking tonic v0.7.2 [INFO] [stdout] warning: use of deprecated associated function `tonic::metadata::MetadataValue::::from_str`: Use TryFrom or FromStr instead [INFO] [stdout] --> src/spire.rs:38:46 [INFO] [stdout] | [INFO] [stdout] 38 | tonic::metadata::AsciiMetadataValue::from_str("true")?, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `tonic::metadata::MetadataValue::::from_str`: Use TryFrom or FromStr instead [INFO] [stdout] --> src/spire.rs:49:46 [INFO] [stdout] | [INFO] [stdout] 49 | tonic::metadata::AsciiMetadataValue::from_str("true")?, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `tonic::metadata::MetadataValue::::from_str`: Use TryFrom or FromStr instead [INFO] [stdout] --> src/spire.rs:38:46 [INFO] [stdout] | [INFO] [stdout] 38 | tonic::metadata::AsciiMetadataValue::from_str("true")?, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `tonic::metadata::MetadataValue::::from_str`: Use TryFrom or FromStr instead [INFO] [stdout] --> src/spire.rs:49:46 [INFO] [stdout] | [INFO] [stdout] 49 | tonic::metadata::AsciiMetadataValue::from_str("true")?, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/jwt.rs:167:36 [INFO] [stdout] | [INFO] [stdout] 167 | if token_data.claims.exp < now as usize { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `now` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/jwt.rs:168:40 [INFO] [stdout] | [INFO] [stdout] 168 | if token_data.claims.exp < (now - 86400) as usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(now - 86400)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/spiffe.rs:30:34 [INFO] [stdout] | [INFO] [stdout] 30 | serializer.serialize_str(&*str_value) [INFO] [stdout] | ^^^^^^^^^^^ help: try: `&str_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/spiffe.rs:37:34 [INFO] [stdout] | [INFO] [stdout] 37 | serializer.serialize_str(&*str_value) [INFO] [stdout] | ^^^^^^^^^^^ help: try: `&str_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/spire.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | global_identities.iter().cloned().flatten().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | help: try: `.flatten().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] = note: `#[warn(clippy::iter_overeager_cloned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/spire.rs:145:33 [INFO] [stdout] | [INFO] [stdout] 145 | .store(Arc::new(global_crls.iter().cloned().flatten().collect())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | help: try: `.flatten().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/spire.rs:171:17 [INFO] [stdout] | [INFO] [stdout] 171 | global_jwt_bundles.iter().cloned().flatten().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | help: try: `.flatten().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/verifier.rs:86:50 [INFO] [stdout] | [INFO] [stdout] 86 | self.resolve_cert_key().map(|x| Arc::new((&*x).clone())) [INFO] [stdout] | ^^^^^ help: change this to: `(*x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/verifier.rs:96:50 [INFO] [stdout] | [INFO] [stdout] 96 | self.resolve_cert_key().map(|x| Arc::new((&*x).clone())) [INFO] [stdout] | ^^^^^ help: change this to: `(*x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/verifier.rs:138:26 [INFO] [stdout] | [INFO] [stdout] 138 | pki::prepare(&*roots, &raw_roots_bundle, end_entity, intermediates)?; [INFO] [stdout] | ^^^^^^^ help: try: `&roots` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/verifier.rs:194:26 [INFO] [stdout] | [INFO] [stdout] 194 | pki::prepare(&*roots, &raw_roots_bundle, end_entity, intermediates)?; [INFO] [stdout] | ^^^^^^^ help: try: `&roots` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/lib.rs:86:1 [INFO] [stdout] | [INFO] [stdout] 86 | / impl PartialOrd for CrlEntry { [INFO] [stdout] 87 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 88 | | self.0 .0.partial_cmp(&other.0 .0) [INFO] [stdout] 89 | | } [INFO] [stdout] 90 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 87 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 88 - self.0 .0.partial_cmp(&other.0 .0) [INFO] [stdout] 89 - } [INFO] [stdout] 87 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> examples/verify_jwt.rs:23:43 [INFO] [stdout] | [INFO] [stdout] 23 | match bundle.verify_spiffe_id(args.get(0).unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/jwt.rs:167:36 [INFO] [stdout] | [INFO] [stdout] 167 | if token_data.claims.exp < now as usize { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `now` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/jwt.rs:168:40 [INFO] [stdout] | [INFO] [stdout] 168 | if token_data.claims.exp < (now - 86400) as usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(now - 86400)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/spiffe.rs:30:34 [INFO] [stdout] | [INFO] [stdout] 30 | serializer.serialize_str(&*str_value) [INFO] [stdout] | ^^^^^^^^^^^ help: try: `&str_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/spiffe.rs:37:34 [INFO] [stdout] | [INFO] [stdout] 37 | serializer.serialize_str(&*str_value) [INFO] [stdout] | ^^^^^^^^^^^ help: try: `&str_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> examples/dump.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | / &*svid [INFO] [stdout] 66 | | .get_components() [INFO] [stdout] 67 | | .iter() [INFO] [stdout] 68 | | .map(|(name, value)| format!("{}:{}", name, value)) [INFO] [stdout] 69 | | .collect::>() [INFO] [stdout] 70 | | .join("~"), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 65 ~ &svid [INFO] [stdout] 66 + .get_components() [INFO] [stdout] 67 + .iter() [INFO] [stdout] 68 + .map(|(name, value)| format!("{}:{}", name, value)) [INFO] [stdout] 69 + .collect::>() [INFO] [stdout] 70 ~ .join("~"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/spiffe.rs:463:33 [INFO] [stdout] | [INFO] [stdout] 463 | let trust_domain = vec!['a' as u8; 255]; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'a'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/spiffe.rs:468:33 [INFO] [stdout] | [INFO] [stdout] 468 | let trust_domain = vec!['a' as u8; 256]; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'a'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/spiffe.rs:478:33 [INFO] [stdout] | [INFO] [stdout] 478 | let trust_domain = vec!['x' as u8; 37]; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'x'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> examples/dump.rs:88:29 [INFO] [stdout] | [INFO] [stdout] 88 | url::Url::parse(&*t) [INFO] [stdout] | ^^^ help: try: `&t` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/spiffe.rs:480:24 [INFO] [stdout] | [INFO] [stdout] 480 | let key = vec!['a' as u8; 1000]; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'a'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/spiffe.rs:482:26 [INFO] [stdout] | [INFO] [stdout] 482 | let value = vec!['b' as u8; 1000]; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'b'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/spiffe.rs:487:26 [INFO] [stdout] | [INFO] [stdout] 487 | let value = vec!['b' as u8; 1001]; [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'b'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/spiffe.rs:599:17 [INFO] [stdout] | [INFO] [stdout] 599 | assert!(!set_spiffe_separator("!").is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `set_spiffe_separator("!").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/spire.rs:136:17 [INFO] [stdout] | [INFO] [stdout] 136 | global_identities.iter().cloned().flatten().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | help: try: `.flatten().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] = note: `#[warn(clippy::iter_overeager_cloned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/spire.rs:145:33 [INFO] [stdout] | [INFO] [stdout] 145 | .store(Arc::new(global_crls.iter().cloned().flatten().collect())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | help: try: `.flatten().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessarily eager cloning of iterator items [INFO] [stdout] --> src/spire.rs:171:17 [INFO] [stdout] | [INFO] [stdout] 171 | global_jwt_bundles.iter().cloned().flatten().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^------------------- [INFO] [stdout] | | [INFO] [stdout] | help: try: `.flatten().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/verifier.rs:86:50 [INFO] [stdout] | [INFO] [stdout] 86 | self.resolve_cert_key().map(|x| Arc::new((&*x).clone())) [INFO] [stdout] | ^^^^^ help: change this to: `(*x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/verifier.rs:96:50 [INFO] [stdout] | [INFO] [stdout] 96 | self.resolve_cert_key().map(|x| Arc::new((&*x).clone())) [INFO] [stdout] | ^^^^^ help: change this to: `(*x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/verifier.rs:138:26 [INFO] [stdout] | [INFO] [stdout] 138 | pki::prepare(&*roots, &raw_roots_bundle, end_entity, intermediates)?; [INFO] [stdout] | ^^^^^^^ help: try: `&roots` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/verifier.rs:194:26 [INFO] [stdout] | [INFO] [stdout] 194 | pki::prepare(&*roots, &raw_roots_bundle, end_entity, intermediates)?; [INFO] [stdout] | ^^^^^^^ help: try: `&roots` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SocketAddr` which implements the `Copy` trait [INFO] [stdout] --> src/verifier.rs:318:42 [INFO] [stdout] | [INFO] [stdout] 318 | let listener = TcpListener::bind(addr.clone()).await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SocketAddr` which implements the `Copy` trait [INFO] [stdout] --> src/verifier.rs:351:45 [INFO] [stdout] | [INFO] [stdout] 351 | let stream = TcpStream::connect(addr.clone()).await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SocketAddr` which implements the `Copy` trait [INFO] [stdout] --> src/verifier.rs:363:45 [INFO] [stdout] | [INFO] [stdout] 363 | let stream = TcpStream::connect(addr.clone()).await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SocketAddr` which implements the `Copy` trait [INFO] [stdout] --> src/verifier.rs:375:45 [INFO] [stdout] | [INFO] [stdout] 375 | let stream = TcpStream::connect(addr.clone()).await.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `addr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/lib.rs:86:1 [INFO] [stdout] | [INFO] [stdout] 86 | / impl PartialOrd for CrlEntry { [INFO] [stdout] 87 | | fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 88 | | self.0 .0.partial_cmp(&other.0 .0) [INFO] [stdout] 89 | | } [INFO] [stdout] 90 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 87 - fn partial_cmp(&self, other: &Self) -> Option { [INFO] [stdout] 88 - self.0 .0.partial_cmp(&other.0 .0) [INFO] [stdout] 89 - } [INFO] [stdout] 87 + fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 52s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nom v6.1.2 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "234d3622858d6d3102bf969eaa9a6a2c162b267f05eae8abb3fb63cd4dc671f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "234d3622858d6d3102bf969eaa9a6a2c162b267f05eae8abb3fb63cd4dc671f8", kill_on_drop: false }` [INFO] [stdout] 234d3622858d6d3102bf969eaa9a6a2c162b267f05eae8abb3fb63cd4dc671f8