[INFO] fetching crate sounding-bufkit 0.19.0... [INFO] linting sounding-bufkit-0.19.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate sounding-bufkit 0.19.0 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate sounding-bufkit 0.19.0 [INFO] finished tweaking crates.io crate sounding-bufkit 0.19.0 [INFO] tweaked toml for crates.io crate sounding-bufkit 0.19.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate sounding-bufkit 0.19.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate sounding-bufkit 0.19.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded sounding-analysis v0.20.0 [INFO] [stderr] Downloaded optional v0.5.0 [INFO] [stderr] Downloaded metfor v0.10.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 909df61ecacefd8c20f0073d1a1863f26982b10cbf0437c9a366abe9aec0a8f8 [INFO] running `Command { std: "docker" "start" "-a" "909df61ecacefd8c20f0073d1a1863f26982b10cbf0437c9a366abe9aec0a8f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "909df61ecacefd8c20f0073d1a1863f26982b10cbf0437c9a366abe9aec0a8f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "909df61ecacefd8c20f0073d1a1863f26982b10cbf0437c9a366abe9aec0a8f8", kill_on_drop: false }` [INFO] [stdout] 909df61ecacefd8c20f0073d1a1863f26982b10cbf0437c9a366abe9aec0a8f8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 296c048795393570cff2cc469a3e8c1231799cb681eaa02e68d4d1e84aac67f3 [INFO] running `Command { std: "docker" "start" "-a" "296c048795393570cff2cc469a3e8c1231799cb681eaa02e68d4d1e84aac67f3", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.115 [INFO] [stderr] Checking optional v0.5.0 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking metfor v0.10.0 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Checking sounding-analysis v0.20.0 [INFO] [stderr] Checking sounding-bufkit v0.19.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/bufkit_data/surface.rs:55:32 [INFO] [stdout] | [INFO] [stdout] 55 | let cols_text = header.trim().split_whitespace(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/bufkit_data/surface.rs:198:26 [INFO] [stdout] | [INFO] [stdout] 198 | station_num: ::std::i32::MIN, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 198 - station_num: ::std::i32::MIN, [INFO] [stdout] 198 + station_num: i32::MIN, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NONE` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:233:5 [INFO] [stdout] | [INFO] [stdout] 233 | NONE, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `None` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STN` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:234:5 [INFO] [stdout] | [INFO] [stdout] 234 | STN, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Stn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VALIDTIME` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:235:5 [INFO] [stdout] | [INFO] [stdout] 235 | VALIDTIME, [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Validtime` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PMSL` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:236:5 [INFO] [stdout] | [INFO] [stdout] 236 | PMSL, // Mean sea level pressure [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Pmsl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PRES` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:237:5 [INFO] [stdout] | [INFO] [stdout] 237 | PRES, // Station pressure [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Pres` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LCLD` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | LCLD, // Low cloud amount [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Lcld` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MCLD` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:239:5 [INFO] [stdout] | [INFO] [stdout] 239 | MCLD, // Mid-level cloud amount [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Mcld` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HCLD` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:240:5 [INFO] [stdout] | [INFO] [stdout] 240 | HCLD, // High cloud amount [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Hcld` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `UWND` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:241:5 [INFO] [stdout] | [INFO] [stdout] 241 | UWND, // U-component of the wind [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Uwnd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VWND` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 242 | VWND, // V-component of the wind [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Vwnd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SKTC` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:245:5 [INFO] [stdout] | [INFO] [stdout] 245 | SKTC, // Skin temperature [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Sktc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SNFL` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:247:5 [INFO] [stdout] | [INFO] [stdout] 247 | SNFL, // 1-hour snow fall kg/m^2 [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Snfl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SNRA` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:251:5 [INFO] [stdout] | [INFO] [stdout] 251 | SNRA, // Snow ratio from explicit cloud scheme (percent) [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Snra` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WXTS` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:252:5 [INFO] [stdout] | [INFO] [stdout] 252 | WXTS, // Snow weather type [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Wxts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WXTP` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 253 | WXTP, // Ice pellets weather type [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Wxtp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WXTZ` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:254:5 [INFO] [stdout] | [INFO] [stdout] 254 | WXTZ, // Freezing rain weather type, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Wxtz` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WXTR` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:255:5 [INFO] [stdout] | [INFO] [stdout] 255 | WXTR, // Rain weather type, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Wxtr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `USTM` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:256:5 [INFO] [stdout] | [INFO] [stdout] 256 | USTM, // USTM - U-component of storm motion (m/s) [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Ustm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VSTM` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:257:5 [INFO] [stdout] | [INFO] [stdout] 257 | VSTM, // VSTM - V-component of storm motion (m/s) [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Vstm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HLCY` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:258:5 [INFO] [stdout] | [INFO] [stdout] 258 | HLCY, // HLCY - Storm relative helicity (m**2/s**2) [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Hlcy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WSYM` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:259:5 [INFO] [stdout] | [INFO] [stdout] 259 | WSYM, // WSYM - Weather type symbol number [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Wsym` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VSBK` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:260:5 [INFO] [stdout] | [INFO] [stdout] 260 | VSBK, // VSBK - Visibility (km) [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Vsbk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/bufkit_data/surface_section.rs:22:49 [INFO] [stdout] | [INFO] [stdout] 22 | if previous_char.is_whitespace() && c.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:41:32 [INFO] [stdout] | [INFO] [stdout] 41 | let cols_text = header.trim().split_whitespace(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:87:29 [INFO] [stdout] | [INFO] [stdout] 87 | let values = values.trim().split_whitespace(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:111:18 [INFO] [stdout] | [INFO] [stdout] 111 | .zip(speed.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 111 - .zip(speed.into_iter()) [INFO] [stdout] 111 + .zip(speed) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NONE` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | NONE, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `None` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PRES` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 129 | PRES, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Pres` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TMPC` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | TMPC, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Tmpc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TMWC` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | TMWC, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Tmwc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DWPC` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 132 | DWPC, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Dwpc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `THTE` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 133 | THTE, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Thte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DRCT` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | DRCT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Drct` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SKNT` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:135:5 [INFO] [stdout] | [INFO] [stdout] 135 | SKNT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Sknt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OMEG` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | OMEG, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Omeg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CFRL` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 137 | CFRL, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Cfrl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HGHT` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:138:5 [INFO] [stdout] | [INFO] [stdout] 138 | HGHT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Hght` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:141:1 [INFO] [stdout] | [INFO] [stdout] 141 | / impl Default for ColName { [INFO] [stdout] 142 | | fn default() -> ColName { [INFO] [stdout] 143 | | ColName::NONE [INFO] [stdout] 144 | | } [INFO] [stdout] 145 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 127 + #[derive(Default)] [INFO] [stdout] 128 | enum ColName { [INFO] [stdout] 129 ~ #[default] [INFO] [stdout] 130 ~ NONE, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/bufkit_data/upper_air/station_info.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | |c| char::is_alphanumeric(c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `char::is_alphanumeric` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bufkit_data.rs:144:69 [INFO] [stdout] | [INFO] [stdout] 144 | return Some(combine::combine_data(next_ua, next_sd, &self.source_name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `self.source_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'b [INFO] [stdout] --> src/parse_util.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn parse_kv<'a, 'b, FS, FE>( [INFO] [stdout] | ^^ [INFO] [stdout] 37 | src: &'a str, [INFO] [stdout] 38 | key: &'b str, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 36 ~ pub fn parse_kv<'a, FS, FE>( [INFO] [stdout] 37 | src: &'a str, [INFO] [stdout] 38 ~ key: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/parse_util.rs:53:20 [INFO] [stdout] | [INFO] [stdout] 53 | let tail_idx = head.find(end_val).or_else(|| Some(head.len())).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `or` instead [INFO] [stdout] | [INFO] [stdout] 53 - let tail_idx = head.find(end_val).or_else(|| Some(head.len())).unwrap(); [INFO] [stdout] 53 + let tail_idx = head.find(end_val).or(Some(head.len())).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'b [INFO] [stdout] --> src/parse_util.rs:111:22 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn parse_f64<'a, 'b>( [INFO] [stdout] | ^^ [INFO] [stdout] 112 | src: &'a str, [INFO] [stdout] 113 | key: &'b str, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 111 ~ pub fn parse_f64<'a>( [INFO] [stdout] 112 | src: &'a str, [INFO] [stdout] 113 ~ key: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'b [INFO] [stdout] --> src/parse_util.rs:151:22 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn parse_i32<'a, 'b>(src: &'a str, key: &'b str) -> Result<(i32, &'a str), Box> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 151 - pub fn parse_i32<'a, 'b>(src: &'a str, key: &'b str) -> Result<(i32, &'a str), Box> { [INFO] [stdout] 151 + pub fn parse_i32<'a>(src: &'a str, key: &str) -> Result<(i32, &'a str), Box> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/bufkit_data/surface.rs:55:32 [INFO] [stdout] | [INFO] [stdout] 55 | let cols_text = header.trim().split_whitespace(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/bufkit_data/surface.rs:198:26 [INFO] [stdout] | [INFO] [stdout] 198 | station_num: ::std::i32::MIN, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 198 - station_num: ::std::i32::MIN, [INFO] [stdout] 198 + station_num: i32::MIN, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NONE` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:233:5 [INFO] [stdout] | [INFO] [stdout] 233 | NONE, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `None` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STN` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:234:5 [INFO] [stdout] | [INFO] [stdout] 234 | STN, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Stn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VALIDTIME` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:235:5 [INFO] [stdout] | [INFO] [stdout] 235 | VALIDTIME, [INFO] [stdout] | ^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Validtime` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PMSL` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:236:5 [INFO] [stdout] | [INFO] [stdout] 236 | PMSL, // Mean sea level pressure [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Pmsl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PRES` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:237:5 [INFO] [stdout] | [INFO] [stdout] 237 | PRES, // Station pressure [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Pres` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LCLD` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:238:5 [INFO] [stdout] | [INFO] [stdout] 238 | LCLD, // Low cloud amount [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Lcld` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MCLD` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:239:5 [INFO] [stdout] | [INFO] [stdout] 239 | MCLD, // Mid-level cloud amount [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Mcld` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HCLD` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:240:5 [INFO] [stdout] | [INFO] [stdout] 240 | HCLD, // High cloud amount [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Hcld` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `UWND` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:241:5 [INFO] [stdout] | [INFO] [stdout] 241 | UWND, // U-component of the wind [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Uwnd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VWND` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:242:5 [INFO] [stdout] | [INFO] [stdout] 242 | VWND, // V-component of the wind [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Vwnd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SKTC` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:245:5 [INFO] [stdout] | [INFO] [stdout] 245 | SKTC, // Skin temperature [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Sktc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SNFL` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:247:5 [INFO] [stdout] | [INFO] [stdout] 247 | SNFL, // 1-hour snow fall kg/m^2 [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Snfl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SNRA` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:251:5 [INFO] [stdout] | [INFO] [stdout] 251 | SNRA, // Snow ratio from explicit cloud scheme (percent) [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Snra` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WXTS` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:252:5 [INFO] [stdout] | [INFO] [stdout] 252 | WXTS, // Snow weather type [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Wxts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WXTP` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:253:5 [INFO] [stdout] | [INFO] [stdout] 253 | WXTP, // Ice pellets weather type [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Wxtp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WXTZ` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:254:5 [INFO] [stdout] | [INFO] [stdout] 254 | WXTZ, // Freezing rain weather type, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Wxtz` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WXTR` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:255:5 [INFO] [stdout] | [INFO] [stdout] 255 | WXTR, // Rain weather type, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Wxtr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `USTM` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:256:5 [INFO] [stdout] | [INFO] [stdout] 256 | USTM, // USTM - U-component of storm motion (m/s) [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Ustm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VSTM` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:257:5 [INFO] [stdout] | [INFO] [stdout] 257 | VSTM, // VSTM - V-component of storm motion (m/s) [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Vstm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HLCY` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:258:5 [INFO] [stdout] | [INFO] [stdout] 258 | HLCY, // HLCY - Storm relative helicity (m**2/s**2) [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Hlcy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WSYM` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:259:5 [INFO] [stdout] | [INFO] [stdout] 259 | WSYM, // WSYM - Weather type symbol number [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Wsym` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `VSBK` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/surface.rs:260:5 [INFO] [stdout] | [INFO] [stdout] 260 | VSBK, // VSBK - Visibility (km) [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Vsbk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/bufkit_data/surface.rs:327:13 [INFO] [stdout] | [INFO] [stdout] 327 | let col_name: SfcColName; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `col_name` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 327 ~ [INFO] [stdout] 328 ~ let col_name: SfcColName = match i { [INFO] [stdout] 329 ~ 0 => STN, [INFO] [stdout] 330 ~ 1 => VALIDTIME, [INFO] [stdout] 331 ~ 2 => PMSL, [INFO] [stdout] 332 ~ 3 => PRES, [INFO] [stdout] 333 ~ 4 => SKTC, [INFO] [stdout] 334 ~ 5 => STC1, [INFO] [stdout] 335 ~ 10 => LCLD, [INFO] [stdout] 336 ~ 11 => MCLD, [INFO] [stdout] 337 ~ 12 => HCLD, [INFO] [stdout] 338 ~ 13 => UWND, [INFO] [stdout] 339 ~ 14 => VWND, [INFO] [stdout] 340 ~ 15 => T2MS, [INFO] [stdout] 341 ~ 17 => WXTS, [INFO] [stdout] 342 ~ 18 => WXTP, [INFO] [stdout] 343 ~ 19 => WXTZ, [INFO] [stdout] 344 ~ 20 => WXTR, [INFO] [stdout] 345 ~ 22 => TD2M, [INFO] [stdout] 346 ~ _ => NONE, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/bufkit_data/surface.rs:361:13 [INFO] [stdout] | [INFO] [stdout] 361 | let col_name: SfcColName; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `col_name` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 361 ~ [INFO] [stdout] 362 ~ let col_name: SfcColName = match i { [INFO] [stdout] 363 ~ 0 => STN, [INFO] [stdout] 364 ~ 1 => VALIDTIME, [INFO] [stdout] 365 ~ 2 => PMSL, [INFO] [stdout] 366 ~ 3 => PRES, [INFO] [stdout] 367 ~ 4 => SKTC, [INFO] [stdout] 368 ~ 5 => STC1, [INFO] [stdout] 369 ~ 6 => SNFL, [INFO] [stdout] 370 | [INFO] [stdout] 371 ~ 8 => P01M, [INFO] [stdout] 372 ~ 9 => C01M, [INFO] [stdout] 373 ~ 10 => STC2, [INFO] [stdout] 374 ~ 11 => LCLD, [INFO] [stdout] 375 ~ 12 => MCLD, [INFO] [stdout] 376 ~ 13 => HCLD, [INFO] [stdout] 377 ~ 14 => SNRA, [INFO] [stdout] 378 ~ 15 => UWND, [INFO] [stdout] 379 ~ 16 => VWND, [INFO] [stdout] 380 | [INFO] [stdout] 381 ~ 19 => T2MS, [INFO] [stdout] 382 | [INFO] [stdout] 383 ~ 21 => WXTS, [INFO] [stdout] 384 ~ 22 => WXTP, [INFO] [stdout] 385 ~ 23 => WXTZ, [INFO] [stdout] 386 ~ 24 => WXTR, [INFO] [stdout] 387 ~ 25 => USTM, [INFO] [stdout] 388 ~ 26 => VSTM, [INFO] [stdout] 389 ~ 27 => HLCY, [INFO] [stdout] 390 | [INFO] [stdout] 391 ~ 29 => WSYM, [INFO] [stdout] 392 | [INFO] [stdout] 393 ~ 31 => VSBK, [INFO] [stdout] 394 ~ 32 => TD2M, [INFO] [stdout] 395 | [INFO] [stdout] 396 ~ _ => NONE, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/bufkit_data/surface_section.rs:22:49 [INFO] [stdout] | [INFO] [stdout] 22 | if previous_char.is_whitespace() && c.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bufkit_data/surface_section.rs:343:17 [INFO] [stdout] | [INFO] [stdout] 343 | assert!(!surface_section.validate_section().is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `surface_section.validate_section().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bufkit_data/upper_air/indexes.rs:90:34 [INFO] [stdout] | [INFO] [stdout] 90 | let indexes = Indexes::parse(&test_data); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `test_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bufkit_data/upper_air/indexes.rs:129:34 [INFO] [stdout] | [INFO] [stdout] 129 | let indexes = Indexes::parse(&test_data); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `test_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:41:32 [INFO] [stdout] | [INFO] [stdout] 41 | let cols_text = header.trim().split_whitespace(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:87:29 [INFO] [stdout] | [INFO] [stdout] 87 | let values = values.trim().split_whitespace(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:111:18 [INFO] [stdout] | [INFO] [stdout] 111 | .zip(speed.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 111 - .zip(speed.into_iter()) [INFO] [stdout] 111 + .zip(speed) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NONE` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | NONE, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `None` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PRES` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 129 | PRES, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Pres` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TMPC` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | TMPC, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Tmpc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TMWC` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | TMWC, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Tmwc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DWPC` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 132 | DWPC, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Dwpc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `THTE` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 133 | THTE, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Thte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DRCT` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | DRCT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Drct` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SKNT` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:135:5 [INFO] [stdout] | [INFO] [stdout] 135 | SKNT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Sknt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OMEG` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | OMEG, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Omeg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CFRL` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 137 | CFRL, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Cfrl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HGHT` contains a capitalized acronym [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:138:5 [INFO] [stdout] | [INFO] [stdout] 138 | HGHT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Hght` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/bufkit_data/upper_air/profile.rs:141:1 [INFO] [stdout] | [INFO] [stdout] 141 | / impl Default for ColName { [INFO] [stdout] 142 | | fn default() -> ColName { [INFO] [stdout] 143 | | ColName::NONE [INFO] [stdout] 144 | | } [INFO] [stdout] 145 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 127 + #[derive(Default)] [INFO] [stdout] 128 | enum ColName { [INFO] [stdout] 129 ~ #[default] [INFO] [stdout] 130 ~ NONE, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/bufkit_data/upper_air/station_info.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | |c| char::is_alphanumeric(c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `char::is_alphanumeric` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bufkit_data/upper_air/station_info.rs:96:33 [INFO] [stdout] | [INFO] [stdout] 96 | let si = StationInfo::parse(&test_data); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `test_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bufkit_data/upper_air/station_info.rs:120:33 [INFO] [stdout] | [INFO] [stdout] 120 | let si = StationInfo::parse(&test_data); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `test_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bufkit_data/upper_air_section.rs:2225:17 [INFO] [stdout] | [INFO] [stdout] 2225 | assert!(!sounding.validate_section().is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sounding.validate_section().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bufkit_data/upper_air_section.rs:2228:17 [INFO] [stdout] | [INFO] [stdout] 2228 | assert!(!sounding.validate_section().is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sounding.validate_section().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bufkit_data.rs:144:69 [INFO] [stdout] | [INFO] [stdout] 144 | return Some(combine::combine_data(next_ua, next_sd, &self.source_name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `self.source_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'b [INFO] [stdout] --> src/parse_util.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn parse_kv<'a, 'b, FS, FE>( [INFO] [stdout] | ^^ [INFO] [stdout] 37 | src: &'a str, [INFO] [stdout] 38 | key: &'b str, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 36 ~ pub fn parse_kv<'a, FS, FE>( [INFO] [stdout] 37 | src: &'a str, [INFO] [stdout] 38 ~ key: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/parse_util.rs:53:20 [INFO] [stdout] | [INFO] [stdout] 53 | let tail_idx = head.find(end_val).or_else(|| Some(head.len())).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `or` instead [INFO] [stdout] | [INFO] [stdout] 53 - let tail_idx = head.find(end_val).or_else(|| Some(head.len())).unwrap(); [INFO] [stdout] 53 + let tail_idx = head.find(end_val).or(Some(head.len())).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parse_util.rs:68:18 [INFO] [stdout] | [INFO] [stdout] 68 | |c| char::is_alphanumeric(c), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `char::is_alphanumeric` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/parse_util.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | assert!(false, "There was an error parsing."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/parse_util.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | assert!(false, "There was an error parsing."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/parse_util.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | assert!(false, "There was an error parsing."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/parse_util.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | assert!(false, "There was an error parsing the very last element."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'b [INFO] [stdout] --> src/parse_util.rs:111:22 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn parse_f64<'a, 'b>( [INFO] [stdout] | ^^ [INFO] [stdout] 112 | src: &'a str, [INFO] [stdout] 113 | key: &'b str, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 111 ~ pub fn parse_f64<'a>( [INFO] [stdout] 112 | src: &'a str, [INFO] [stdout] 113 ~ key: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/parse_util.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | assert!(false, "There was an error parsing."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/parse_util.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | assert!(false, "There was an error parsing."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'b [INFO] [stdout] --> src/parse_util.rs:151:22 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn parse_i32<'a, 'b>(src: &'a str, key: &'b str) -> Result<(i32, &'a str), Box> { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 151 - pub fn parse_i32<'a, 'b>(src: &'a str, key: &'b str) -> Result<(i32, &'a str), Box> { [INFO] [stdout] 151 + pub fn parse_i32<'a>(src: &'a str, key: &str) -> Result<(i32, &'a str), Box> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/parse_util.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | assert!(false, "There was an error parsing."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/parse_util.rs:183:9 [INFO] [stdout] | [INFO] [stdout] 183 | assert!(false, "There was an error parsing."); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.54s [INFO] running `Command { std: "docker" "inspect" "296c048795393570cff2cc469a3e8c1231799cb681eaa02e68d4d1e84aac67f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "296c048795393570cff2cc469a3e8c1231799cb681eaa02e68d4d1e84aac67f3", kill_on_drop: false }` [INFO] [stdout] 296c048795393570cff2cc469a3e8c1231799cb681eaa02e68d4d1e84aac67f3