[INFO] fetching crate sortrs 0.0.5... [INFO] linting sortrs-0.0.5 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate sortrs 0.0.5 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate sortrs 0.0.5 [INFO] finished tweaking crates.io crate sortrs 0.0.5 [INFO] tweaked toml for crates.io crate sortrs 0.0.5 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate sortrs 0.0.5 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] [stderr] Adding num v0.1.43 (available: v0.4.3) [INFO] [stderr] Adding rand v0.3.23 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded num v0.1.43 [INFO] [stderr] Downloaded num-rational v0.1.43 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4eb7a5c8156e728eee6cdca483094f6fd5889f3eded3f257d8148e85a4edf619 [INFO] running `Command { std: "docker" "start" "-a" "4eb7a5c8156e728eee6cdca483094f6fd5889f3eded3f257d8148e85a4edf619", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4eb7a5c8156e728eee6cdca483094f6fd5889f3eded3f257d8148e85a4edf619", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4eb7a5c8156e728eee6cdca483094f6fd5889f3eded3f257d8148e85a4edf619", kill_on_drop: false }` [INFO] [stdout] 4eb7a5c8156e728eee6cdca483094f6fd5889f3eded3f257d8148e85a4edf619 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b3f70d1cff03c42a778bb38847720ea68cb07297830030cbd96402da90b31783 [INFO] running `Command { std: "docker" "start" "-a" "b3f70d1cff03c42a778bb38847720ea68cb07297830030cbd96402da90b31783", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling num-bigint v0.1.45 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Compiling num-complex v0.1.44 [INFO] [stderr] Compiling num-rational v0.1.43 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking num v0.1.43 [INFO] [stderr] Checking sortrs v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | start = start - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `start -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | end = end - 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `end -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:193:16 [INFO] [stdout] | [INFO] [stdout] 193 | if !((first as usize) < (last as usize)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((first as usize) >= (last as usize))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:212:9 [INFO] [stdout] | [INFO] [stdout] 212 | return partition(ptr.offset(1), ptr.offset(len), ptr, lt); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 212 - return partition(ptr.offset(1), ptr.offset(len), ptr, lt); [INFO] [stdout] 212 + partition(ptr.offset(1), ptr.offset(len), ptr, lt) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | start = start - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `start -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | end = end - 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `end -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:193:16 [INFO] [stdout] | [INFO] [stdout] 193 | if !((first as usize) < (last as usize)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((first as usize) >= (last as usize))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:212:9 [INFO] [stdout] | [INFO] [stdout] 212 | return partition(ptr.offset(1), ptr.offset(len), ptr, lt); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 212 - return partition(ptr.offset(1), ptr.offset(len), ptr, lt); [INFO] [stdout] 212 + partition(ptr.offset(1), ptr.offset(len), ptr, lt) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.49s [INFO] running `Command { std: "docker" "inspect" "b3f70d1cff03c42a778bb38847720ea68cb07297830030cbd96402da90b31783", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3f70d1cff03c42a778bb38847720ea68cb07297830030cbd96402da90b31783", kill_on_drop: false }` [INFO] [stdout] b3f70d1cff03c42a778bb38847720ea68cb07297830030cbd96402da90b31783