[INFO] fetching crate socrates_rs 1.1.0... [INFO] linting socrates_rs-1.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate socrates_rs 1.1.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate socrates_rs 1.1.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate socrates_rs 1.1.0 [INFO] tweaked toml for crates.io crate socrates_rs 1.1.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate socrates_rs 1.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 46 packages to latest compatible versions [INFO] [stderr] Adding strum v0.26.3 (available: v0.28.0) [INFO] [stderr] Adding strum_macros v0.26.4 (available: v0.28.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f100f0e16f996b3d7d8cfa85ef8e8e7e1ee93129436dca70445ede0efe90b5e3 [INFO] running `Command { std: "docker" "start" "-a" "f100f0e16f996b3d7d8cfa85ef8e8e7e1ee93129436dca70445ede0efe90b5e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f100f0e16f996b3d7d8cfa85ef8e8e7e1ee93129436dca70445ede0efe90b5e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f100f0e16f996b3d7d8cfa85ef8e8e7e1ee93129436dca70445ede0efe90b5e3", kill_on_drop: false }` [INFO] [stdout] f100f0e16f996b3d7d8cfa85ef8e8e7e1ee93129436dca70445ede0efe90b5e3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4ce014fa3c46206e6983942add0c3f524a1ed76e6b3e34a5182f77ef8a86eb68 [INFO] running `Command { std: "docker" "start" "-a" "4ce014fa3c46206e6983942add0c3f524a1ed76e6b3e34a5182f77ef8a86eb68", kill_on_drop: false }` [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking socrates_rs v1.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `country_code` is never used [INFO] [stdout] --> src/generator/mod.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub trait CountryIdGenerator { [INFO] [stdout] | ------------------ method in this trait [INFO] [stdout] 7 | fn generate(&self, citizen: &Citizen) -> String; [INFO] [stdout] 8 | fn country_code(&self) -> country::Code; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `country_code` is never used [INFO] [stdout] --> src/validator/mod.rs:11:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub trait CountryValidator { [INFO] [stdout] | ---------------- method in this trait [INFO] [stdout] 10 | fn validate_id(&self, id: &str) -> bool; [INFO] [stdout] 11 | fn country_code(&self) -> country::Code; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `compute_luhn_10_check_digit` is never used [INFO] [stdout] --> src/validator/algorithms/mod.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn compute_luhn_10_check_digit(code: &str) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `VERHOEFF_INV` is never used [INFO] [stdout] --> src/validator/algorithms/mod.rs:55:7 [INFO] [stdout] | [INFO] [stdout] 55 | const VERHOEFF_INV: [u8; 10] = [0, 4, 3, 2, 1, 5, 6, 7, 8, 9]; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `compute_verhoeff_check_digit` is never used [INFO] [stdout] --> src/validator/algorithms/mod.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn compute_verhoeff_check_digit(code: &str) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/generator/denmark.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | return format!("{}-{}{}{}", dob, century, generated_digits, check_digit); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return format!("{}-{}{}{}", dob, century, generated_digits, check_digit); [INFO] [stdout] 43 + format!("{}-{}{}{}", dob, century, generated_digits, check_digit) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/generator/denmark.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return sum; [INFO] [stdout] 63 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/generator/denmark.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 71 | if target_sum % MULTIPLIER[7] == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `target_sum.is_multiple_of(MULTIPLIER[7])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/generator/denmark.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 75 | if target_sum % MULTIPLIER[8] == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `target_sum.is_multiple_of(MULTIPLIER[8])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/generator/mod.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return match country { [INFO] [stdout] 13 | | Code::DK => Some(Box::new(denmark::DenmarkGenerator)), [INFO] [stdout] 14 | | _ => None, [INFO] [stdout] 15 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ match country { [INFO] [stdout] 13 + Code::DK => Some(Box::new(denmark::DenmarkGenerator)), [INFO] [stdout] 14 + _ => None, [INFO] [stdout] 15 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/algorithms/mod.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | return (sum * 9) % 10; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 - return (sum * 9) % 10; [INFO] [stdout] 7 + (sum * 9) % 10 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/validator/algorithms/mod.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | code_with_check_digit.push_str("0"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `code_with_check_digit.push('0')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/algorithms/mod.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return (sum % 10) == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return (sum % 10) == 0; [INFO] [stdout] 12 + (sum % 10) == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/validator/algorithms/mod.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | return (sum % 10) == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace with: `sum.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/algorithms/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return sum; [INFO] [stdout] 28 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/validator/algorithms/mod.rs:18:22 [INFO] [stdout] | [INFO] [stdout] 18 | let mut is_odd = (code.chars().count() % 2) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!code.chars().count().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/algorithms/mod.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | return c == 0; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return c == 0; [INFO] [stdout] 59 + c == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/algorithms/mod.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | return VERHOEFF_INV[c] as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - return VERHOEFF_INV[c] as u32; [INFO] [stdout] 66 + VERHOEFF_INV[c] as u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/validator/algorithms/mod.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | owned_code.push_str("0"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `owned_code.push('0')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/algorithms/mod.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | return c; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return c; [INFO] [stdout] 77 + c [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::iter::Rev>` [INFO] [stdout] --> src/validator/algorithms/mod.rs:72:24 [INFO] [stdout] | [INFO] [stdout] 72 | for (idx, char) in code.chars().rev().into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `code.chars().rev()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/date/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / return if year > current_year { [INFO] [stdout] 10 | | year_string = "19".to_owned(); [INFO] [stdout] 11 | | year_string.push_str(code); [INFO] [stdout] 12 | | year_string.parse::().unwrap() [INFO] [stdout] 13 | | } else { [INFO] [stdout] 14 | | year [INFO] [stdout] 15 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 ~ if year > current_year { [INFO] [stdout] 10 + year_string = "19".to_owned(); [INFO] [stdout] 11 + year_string.push_str(code); [INFO] [stdout] 12 + year_string.parse::().unwrap() [INFO] [stdout] 13 + } else { [INFO] [stdout] 14 + year [INFO] [stdout] 15 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/regions/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return None; [INFO] [stdout] 21 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/validator/regions/mod.rs:16:27 [INFO] [stdout] | [INFO] [stdout] 16 | if record.code == code.to_owned() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/validator/albania.rs:77:24 [INFO] [stdout] | [INFO] [stdout] 77 | let first_letter = standard_id[0..1].chars().nth(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `standard_id[0..1].chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/validator/albania.rs:113:18 [INFO] [stdout] | [INFO] [stdout] 113 | let gender = id[2..3].chars().nth(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `id[2..3].chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/belgium.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return validate_date(("19".to_owned() + partial_id.get(0..6).unwrap()).borrow()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return validate_date(("19".to_owned() + partial_id.get(0..6).unwrap()).borrow()); [INFO] [stdout] 33 + validate_date(("19".to_owned() + partial_id.get(0..6).unwrap()).borrow()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/belgium.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return crate::country::Code::BE; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return crate::country::Code::BE; [INFO] [stdout] 37 + crate::country::Code::BE [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/belgium.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | / return Some(Citizen { [INFO] [stdout] 71 | | gender, [INFO] [stdout] 72 | | year_of_birth: year, [INFO] [stdout] 73 | | month_of_birth: Some(standard_id.get(2..4).unwrap().parse::().unwrap()), [INFO] [stdout] 74 | | day_of_birth: Some(standard_id.get(4..6).unwrap().parse::().unwrap()), [INFO] [stdout] 75 | | place_of_birth: None, [INFO] [stdout] 76 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 ~ Some(Citizen { [INFO] [stdout] 71 + gender, [INFO] [stdout] 72 + year_of_birth: year, [INFO] [stdout] 73 + month_of_birth: Some(standard_id.get(2..4).unwrap().parse::().unwrap()), [INFO] [stdout] 74 + day_of_birth: Some(standard_id.get(4..6).unwrap().parse::().unwrap()), [INFO] [stdout] 75 + place_of_birth: None, [INFO] [stdout] 76 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/validator/belgium.rs:41:49 [INFO] [stdout] | [INFO] [stdout] 41 | if !self::BelgiumValidator::validate_id(&self, id) { [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/belgium.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | return checksum.parse::().unwrap() == calculated_checksum; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return checksum.parse::().unwrap() == calculated_checksum; [INFO] [stdout] 82 + checksum.parse::().unwrap() == calculated_checksum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `date_of_birth` after checking its variant with `is_some` [INFO] [stdout] --> src/validator/belgium.rs:93:16 [INFO] [stdout] | [INFO] [stdout] 92 | if date_of_birth.is_some() { [INFO] [stdout] | -------------------------- help: try: `if let Some() = date_of_birth` [INFO] [stdout] 93 | return date_of_birth.unwrap() <= Utc::now().naive_local().date(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/validator/bosniaherzegovina.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | if (region < 10 || region > 19) && region != 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(10..=19).contains(®ion)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/validator/bosniaherzegovina.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | let g; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `g` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 57 ~ [INFO] [stdout] 58 ~ let g = if standard_id[9..12].parse::().unwrap() < 500 { [INFO] [stdout] 59 ~ 'M' [INFO] [stdout] 60 | } else { [INFO] [stdout] 61 ~ 'F' [INFO] [stdout] 62 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/brazil.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / return standard_id[(standard_id.len() - 2)..] [INFO] [stdout] 30 | | .parse::() [INFO] [stdout] 31 | | .unwrap() [INFO] [stdout] 32 | | == ((v1 * 10) + v2); [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ standard_id[(standard_id.len() - 2)..] [INFO] [stdout] 30 + .parse::() [INFO] [stdout] 31 + .unwrap() [INFO] [stdout] 32 ~ == ((v1 * 10) + v2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/validator/brazil.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | v1 = v1 + c.to_digit(32).unwrap() * (9 - (idx % 10)) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `v1 += c.to_digit(32).unwrap() * (9 - (idx % 10)) as u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/validator/brazil.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | v2 = v2 + c.to_digit(32).unwrap() * (9 - ((idx + 1) % 10)) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `v2 += c.to_digit(32).unwrap() * (9 - ((idx + 1) % 10)) as u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/validator/brazil.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | v2 = v2 + (v1 * 9); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `v2 += (v1 * 9)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/brazil.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | return crate::country::Code::BR; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return crate::country::Code::BR; [INFO] [stdout] 36 + crate::country::Code::BR [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/brazil.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return None; [INFO] [stdout] 40 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/validator/bulgaria.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | / if date_of_birth.is_none() { [INFO] [stdout] 60 | | return None; [INFO] [stdout] 61 | | } [INFO] [stdout] | |_________^ help: replace it with: `date_of_birth?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/denmark.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return self.is_date_valid(year, month, day) && validate_checksum(&standard_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return self.is_date_valid(year, month, day) && validate_checksum(&standard_id); [INFO] [stdout] 26 + self.is_date_valid(year, month, day) && validate_checksum(&standard_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/denmark.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | / return Some(Citizen { [INFO] [stdout] 41 | | gender, [INFO] [stdout] 42 | | year_of_birth: extract_year(&standard_id) as i32, [INFO] [stdout] 43 | | month_of_birth: Some(standard_id[2..4].parse::().unwrap()), [INFO] [stdout] 44 | | day_of_birth: Some(standard_id[0..2].parse::().unwrap()), [INFO] [stdout] 45 | | place_of_birth: None, [INFO] [stdout] 46 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 ~ Some(Citizen { [INFO] [stdout] 41 + gender, [INFO] [stdout] 42 + year_of_birth: extract_year(&standard_id) as i32, [INFO] [stdout] 43 + month_of_birth: Some(standard_id[2..4].parse::().unwrap()), [INFO] [stdout] 44 + day_of_birth: Some(standard_id[0..2].parse::().unwrap()), [INFO] [stdout] 45 + place_of_birth: None, [INFO] [stdout] 46 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/denmark.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | return century + year_code; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return century + year_code; [INFO] [stdout] 70 + century + year_code [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/denmark.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | return sum % 11 == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return sum % 11 == 0; [INFO] [stdout] 79 + sum % 11 == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/validator/denmark.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | return sum % 11 == 0; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace with: `sum.is_multiple_of(11)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/france.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return control_digit == 97 - (partial_id % 97); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return control_digit == 97 - (partial_id % 97); [INFO] [stdout] 33 + control_digit == 97 - (partial_id % 97) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/validator/france.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | if !char.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `char.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/france.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return crate::country::Code::FR; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return crate::country::Code::FR; [INFO] [stdout] 37 + crate::country::Code::FR [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/france.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | / return Some(Citizen { [INFO] [stdout] 47 | | gender: if String::from(&id[0..1]).parse::().unwrap() == 1_u8 { [INFO] [stdout] 48 | | 'M' [INFO] [stdout] 49 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 59 | | }, [INFO] [stdout] 60 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 ~ Some(Citizen { [INFO] [stdout] 47 + gender: if String::from(&id[0..1]).parse::().unwrap() == 1_u8 { [INFO] [stdout] 48 + 'M' [INFO] [stdout] 49 + } else { [INFO] [stdout] 50 + 'F' [INFO] [stdout] 51 + }, [INFO] [stdout] 52 + year_of_birth: date::get_year_of_birth(&id[1..3]), [INFO] [stdout] 53 + month_of_birth: get_month_of_birth(&id[3..5]), [INFO] [stdout] 54 + day_of_birth: None, [INFO] [stdout] 55 + place_of_birth: if region.is_some() { [INFO] [stdout] 56 + region [INFO] [stdout] 57 + } else { [INFO] [stdout] 58 + get_region_of_birth(&id[5..8]) [INFO] [stdout] 59 + }, [INFO] [stdout] 60 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/validator/france.rs:41:48 [INFO] [stdout] | [INFO] [stdout] 41 | if !self::FranceValidator::validate_id(&self, id) { [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/france.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | / return if month > 1_u8 && month < 13_u8 { [INFO] [stdout] 67 | | Some(month) [INFO] [stdout] 68 | | } else if month > 30_u8 && month < 43_u8 { [INFO] [stdout] 69 | | Some(month - 30_u8) [INFO] [stdout] 70 | | } else { [INFO] [stdout] 71 | | None [INFO] [stdout] 72 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 ~ if month > 1_u8 && month < 13_u8 { [INFO] [stdout] 67 + Some(month) [INFO] [stdout] 68 + } else if month > 30_u8 && month < 43_u8 { [INFO] [stdout] 69 + Some(month - 30_u8) [INFO] [stdout] 70 + } else { [INFO] [stdout] 71 + None [INFO] [stdout] 72 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/france.rs:187:5 [INFO] [stdout] | [INFO] [stdout] 187 | / return if region.is_empty() { [INFO] [stdout] 188 | | None [INFO] [stdout] 189 | | } else { [INFO] [stdout] 190 | | Some(String::from(region)) [INFO] [stdout] 191 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 187 ~ if region.is_empty() { [INFO] [stdout] 188 + None [INFO] [stdout] 189 + } else { [INFO] [stdout] 190 + Some(String::from(region)) [INFO] [stdout] 191 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/italy.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return (standard_id[15..].parse::().unwrap()) == control_letter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return (standard_id[15..].parse::().unwrap()) == control_letter; [INFO] [stdout] 39 + (standard_id[15..].parse::().unwrap()) == control_letter [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/italy.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | return crate::country::Code::IT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return crate::country::Code::IT; [INFO] [stdout] 43 + crate::country::Code::IT [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/italy.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | / return Some(Citizen { [INFO] [stdout] 52 | | gender: get_gender(&id[9..11]), [INFO] [stdout] 53 | | year_of_birth: date::get_year_of_birth(&id[6..8]), [INFO] [stdout] 54 | | month_of_birth: get_month_of_birth(id[8..9].parse::().unwrap()), [INFO] [stdout] ... | [INFO] [stdout] 59 | | ), //italy_regions::get_region(&id[11..15]), [INFO] [stdout] 60 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 ~ Some(Citizen { [INFO] [stdout] 52 + gender: get_gender(&id[9..11]), [INFO] [stdout] 53 + year_of_birth: date::get_year_of_birth(&id[6..8]), [INFO] [stdout] 54 + month_of_birth: get_month_of_birth(id[8..9].parse::().unwrap()), [INFO] [stdout] 55 + day_of_birth: Some(get_day_of_birth(&id[9..11])), [INFO] [stdout] 56 + place_of_birth: regions::get_region_from_csv( [INFO] [stdout] 57 + &id[11..15], [INFO] [stdout] 58 + "./src/validator/regions/italy_regions.csv", [INFO] [stdout] 59 + ), //italy_regions::get_region(&id[11..15]), [INFO] [stdout] 60 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/validator/italy.rs:47:47 [INFO] [stdout] | [INFO] [stdout] 47 | if !self::ItalyValidator::validate_id(&self, id) { [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/italy.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | / return match character { [INFO] [stdout] 66 | | '0' | 'A' => 1, [INFO] [stdout] 67 | | '1' | 'B' => 0, [INFO] [stdout] 68 | | '2' | 'C' => 5, [INFO] [stdout] ... | [INFO] [stdout] 92 | | _ => panic!("Unrecognized letter"), [INFO] [stdout] 93 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 ~ match character { [INFO] [stdout] 66 + '0' | 'A' => 1, [INFO] [stdout] 67 + '1' | 'B' => 0, [INFO] [stdout] 68 + '2' | 'C' => 5, [INFO] [stdout] 69 + '3' | 'D' => 7, [INFO] [stdout] 70 + '4' | 'F' => 9, [INFO] [stdout] 71 + '5' | 'E' => 13, [INFO] [stdout] 72 + '6' | 'G' => 15, [INFO] [stdout] 73 + '7' | 'H' => 17, [INFO] [stdout] 74 + '8' | 'I' => 19, [INFO] [stdout] 75 + '9' | 'J' => 21, [INFO] [stdout] 76 + 'K' => 2, [INFO] [stdout] 77 + 'L' => 4, [INFO] [stdout] 78 + 'M' => 18, [INFO] [stdout] 79 + 'N' => 20, [INFO] [stdout] 80 + 'O' => 11, [INFO] [stdout] 81 + 'P' => 3, [INFO] [stdout] 82 + 'Q' => 6, [INFO] [stdout] 83 + 'R' => 8, [INFO] [stdout] 84 + 'S' => 12, [INFO] [stdout] 85 + 'T' => 14, [INFO] [stdout] 86 + 'U' => 16, [INFO] [stdout] 87 + 'V' => 10, [INFO] [stdout] 88 + 'W' => 22, [INFO] [stdout] 89 + 'X' => 25, [INFO] [stdout] 90 + 'Y' => 24, [INFO] [stdout] 91 + 'Z' => 23, [INFO] [stdout] 92 + _ => panic!("Unrecognized letter"), [INFO] [stdout] 93 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/italy.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | / return match digit { [INFO] [stdout] 98 | | 0 => 'A', [INFO] [stdout] 99 | | 1 => 'B', [INFO] [stdout] 100 | | 2 => 'C', [INFO] [stdout] ... | [INFO] [stdout] 124 | | _ => panic!("out of range for digit conversion"), [INFO] [stdout] 125 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 ~ match digit { [INFO] [stdout] 98 + 0 => 'A', [INFO] [stdout] 99 + 1 => 'B', [INFO] [stdout] 100 + 2 => 'C', [INFO] [stdout] 101 + 3 => 'D', [INFO] [stdout] 102 + 4 => 'E', [INFO] [stdout] 103 + 5 => 'F', [INFO] [stdout] 104 + 6 => 'G', [INFO] [stdout] 105 + 7 => 'H', [INFO] [stdout] 106 + 8 => 'I', [INFO] [stdout] 107 + 9 => 'J', [INFO] [stdout] 108 + 10 => 'K', [INFO] [stdout] 109 + 11 => 'L', [INFO] [stdout] 110 + 12 => 'M', [INFO] [stdout] 111 + 13 => 'N', [INFO] [stdout] 112 + 14 => 'O', [INFO] [stdout] 113 + 15 => 'P', [INFO] [stdout] 114 + 16 => 'Q', [INFO] [stdout] 115 + 17 => 'R', [INFO] [stdout] 116 + 18 => 'S', [INFO] [stdout] 117 + 19 => 'T', [INFO] [stdout] 118 + 20 => 'U', [INFO] [stdout] 119 + 21 => 'V', [INFO] [stdout] 120 + 22 => 'W', [INFO] [stdout] 121 + 23 => 'X', [INFO] [stdout] 122 + 24 => 'Y', [INFO] [stdout] 123 + 25 => 'Z', [INFO] [stdout] 124 + _ => panic!("out of range for digit conversion"), [INFO] [stdout] 125 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/italy.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | return if digit > 9 { digit - 10_u8 } else { digit }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 - return if digit > 9 { digit - 10_u8 } else { digit }; [INFO] [stdout] 130 + if digit > 9 { digit - 10_u8 } else { digit } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/italy.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | / return match letter { [INFO] [stdout] 135 | | 'A' => Some(1), [INFO] [stdout] 136 | | 'B' => Some(2), [INFO] [stdout] 137 | | 'C' => Some(3), [INFO] [stdout] ... | [INFO] [stdout] 147 | | _ => None, [INFO] [stdout] 148 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 ~ match letter { [INFO] [stdout] 135 + 'A' => Some(1), [INFO] [stdout] 136 + 'B' => Some(2), [INFO] [stdout] 137 + 'C' => Some(3), [INFO] [stdout] 138 + 'D' => Some(4), [INFO] [stdout] 139 + 'E' => Some(5), [INFO] [stdout] 140 + 'H' => Some(6), [INFO] [stdout] 141 + 'L' => Some(7), [INFO] [stdout] 142 + 'M' => Some(8), [INFO] [stdout] 143 + 'P' => Some(9), [INFO] [stdout] 144 + 'R' => Some(10), [INFO] [stdout] 145 + 'S' => Some(11), [INFO] [stdout] 146 + 'T' => Some(12), [INFO] [stdout] 147 + _ => None, [INFO] [stdout] 148 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/italy.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | return if day > 40 { day - 40_u8 } else { day }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 153 - return if day > 40 { day - 40_u8 } else { day }; [INFO] [stdout] 153 + if day > 40 { day - 40_u8 } else { day } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/italy.rs:158:5 [INFO] [stdout] | [INFO] [stdout] 158 | return if day > 40 { 'F' } else { 'M' }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 158 - return if day > 40 { 'F' } else { 'M' }; [INFO] [stdout] 158 + if day > 40 { 'F' } else { 'M' } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/luxembourg.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | return algorithms::validate_verhoeff(&standard_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return algorithms::validate_verhoeff(&standard_id); [INFO] [stdout] 24 + algorithms::validate_verhoeff(&standard_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/luxembourg.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | return crate::country::Code::LU; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return crate::country::Code::LU; [INFO] [stdout] 28 + crate::country::Code::LU [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/luxembourg.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return None; [INFO] [stdout] 32 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/validator/mexico.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | !check_digit.is_err() && check_digit.unwrap() == ((10 - (sum % 10)) % 10) as u32 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `check_digit.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/validator/mexico.rs:64:37 [INFO] [stdout] | [INFO] [stdout] 64 | if (year_of_birth > 2000 && assigned_digit.is_digit(10)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `assigned_digit.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/portugal.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return (sum % 10) == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return (sum % 10) == 0; [INFO] [stdout] 39 + (sum % 10) == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/validator/portugal.rs:39:16 [INFO] [stdout] | [INFO] [stdout] 39 | return (sum % 10) == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace with: `sum.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/portugal.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | return crate::country::Code::PT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return crate::country::Code::PT; [INFO] [stdout] 43 + crate::country::Code::PT [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/portugal.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return None; [INFO] [stdout] 47 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/spain.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return validation == control; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return validation == control; [INFO] [stdout] 32 + validation == control [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/spain.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | return crate::country::Code::ES; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return crate::country::Code::ES; [INFO] [stdout] 36 + crate::country::Code::ES [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/spain.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return None; [INFO] [stdout] 40 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/usa.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return true; [INFO] [stdout] 44 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/validator/usa.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 36 | if &standard_id[3..5].parse::().unwrap() == &0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 36 - if &standard_id[3..5].parse::().unwrap() == &0 { [INFO] [stdout] 36 + if standard_id[3..5].parse::().unwrap() == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/validator/usa.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | if &standard_id[5..].parse::().unwrap() == &0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 40 - if &standard_id[5..].parse::().unwrap() == &0 { [INFO] [stdout] 40 + if standard_id[5..].parse::().unwrap() == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/usa.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return crate::country::Code::US; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return crate::country::Code::US; [INFO] [stdout] 48 + crate::country::Code::US [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/usa.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return None; [INFO] [stdout] 52 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | return country_validator.validate_id(id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return country_validator.validate_id(id); [INFO] [stdout] 15 + country_validator.validate_id(id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | return country_validator.extract_citizen(id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return country_validator.extract_citizen(id); [INFO] [stdout] 20 + country_validator.extract_citizen(id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/lib.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / if generator.is_none() { [INFO] [stdout] 26 | | return None; [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ help: replace it with: `generator.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/validator/germany.rs:33:28 [INFO] [stdout] | [INFO] [stdout] 33 | let mut repeated = vec![0; 10]; [INFO] [stdout] | ^^^^^^^^^^^ help: you can use an array directly: `[0; 10]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> tests/integration_test.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use socrates_rs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/generator/denmark.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | return format!("{}-{}{}{}", dob, century, generated_digits, check_digit); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return format!("{}-{}{}{}", dob, century, generated_digits, check_digit); [INFO] [stdout] 43 + format!("{}-{}{}{}", dob, century, generated_digits, check_digit) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/generator/denmark.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return sum; [INFO] [stdout] 63 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/generator/denmark.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 71 | if target_sum % MULTIPLIER[7] == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `target_sum.is_multiple_of(MULTIPLIER[7])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/generator/denmark.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 75 | if target_sum % MULTIPLIER[8] == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `target_sum.is_multiple_of(MULTIPLIER[8])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/generator/mod.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / return match country { [INFO] [stdout] 13 | | Code::DK => Some(Box::new(denmark::DenmarkGenerator)), [INFO] [stdout] 14 | | _ => None, [INFO] [stdout] 15 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ match country { [INFO] [stdout] 13 + Code::DK => Some(Box::new(denmark::DenmarkGenerator)), [INFO] [stdout] 14 + _ => None, [INFO] [stdout] 15 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/algorithms/mod.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | return (sum * 9) % 10; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 - return (sum * 9) % 10; [INFO] [stdout] 7 + (sum * 9) % 10 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/validator/algorithms/mod.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | code_with_check_digit.push_str("0"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `code_with_check_digit.push('0')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/algorithms/mod.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return (sum % 10) == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return (sum % 10) == 0; [INFO] [stdout] 12 + (sum % 10) == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/validator/algorithms/mod.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | return (sum % 10) == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace with: `sum.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/algorithms/mod.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return sum; [INFO] [stdout] 28 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/validator/algorithms/mod.rs:18:22 [INFO] [stdout] | [INFO] [stdout] 18 | let mut is_odd = (code.chars().count() % 2) != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!code.chars().count().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/algorithms/mod.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | return c == 0; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return c == 0; [INFO] [stdout] 59 + c == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/algorithms/mod.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | return VERHOEFF_INV[c] as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - return VERHOEFF_INV[c] as u32; [INFO] [stdout] 66 + VERHOEFF_INV[c] as u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/validator/algorithms/mod.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | owned_code.push_str("0"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `owned_code.push('0')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/algorithms/mod.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | return c; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return c; [INFO] [stdout] 77 + c [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::iter::Rev>` [INFO] [stdout] --> src/validator/algorithms/mod.rs:72:24 [INFO] [stdout] | [INFO] [stdout] 72 | for (idx, char) in code.chars().rev().into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `code.chars().rev()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/algorithms/mod.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | assert_eq!(validate_verhoeff("5971654782313"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 98 - assert_eq!(validate_verhoeff("5971654782313"), false); [INFO] [stdout] 98 + assert!(!validate_verhoeff("5971654782313")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/date/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / return if year > current_year { [INFO] [stdout] 10 | | year_string = "19".to_owned(); [INFO] [stdout] 11 | | year_string.push_str(code); [INFO] [stdout] 12 | | year_string.parse::().unwrap() [INFO] [stdout] 13 | | } else { [INFO] [stdout] 14 | | year [INFO] [stdout] 15 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 ~ if year > current_year { [INFO] [stdout] 10 + year_string = "19".to_owned(); [INFO] [stdout] 11 + year_string.push_str(code); [INFO] [stdout] 12 + year_string.parse::().unwrap() [INFO] [stdout] 13 + } else { [INFO] [stdout] 14 + year [INFO] [stdout] 15 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/regions/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return None; [INFO] [stdout] 21 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/validator/regions/mod.rs:16:27 [INFO] [stdout] | [INFO] [stdout] 16 | if record.code == code.to_owned() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/validator/albania.rs:77:24 [INFO] [stdout] | [INFO] [stdout] 77 | let first_letter = standard_id[0..1].chars().nth(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `standard_id[0..1].chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/validator/albania.rs:113:18 [INFO] [stdout] | [INFO] [stdout] 113 | let gender = id[2..3].chars().nth(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `id[2..3].chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/albania.rs:200:9 [INFO] [stdout] | [INFO] [stdout] 200 | assert_eq!(false, validator.validate_id("I05199Q")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 200 - assert_eq!(false, validator.validate_id("I05199Q")); [INFO] [stdout] 200 + assert!(!validator.validate_id("I05199Q")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/albania.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 206 | assert_eq!(false, validator.validate_id("H73211672R")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 206 - assert_eq!(false, validator.validate_id("H73211672R")); [INFO] [stdout] 206 + assert!(!validator.validate_id("H73211672R")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/albania.rs:212:9 [INFO] [stdout] | [INFO] [stdout] 212 | assert_eq!(false, validator.validate_id("Z71211672R")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 212 - assert_eq!(false, validator.validate_id("Z71211672R")); [INFO] [stdout] 212 + assert!(!validator.validate_id("Z71211672R")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/albania.rs:218:9 [INFO] [stdout] | [INFO] [stdout] 218 | assert_eq!(false, validator.validate_id("H71311672R")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 218 - assert_eq!(false, validator.validate_id("H71311672R")); [INFO] [stdout] 218 + assert!(!validator.validate_id("H71311672R")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/albania.rs:224:9 [INFO] [stdout] | [INFO] [stdout] 224 | assert_eq!(false, validator.validate_id("H71211672A")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 224 - assert_eq!(false, validator.validate_id("H71211672A")); [INFO] [stdout] 224 + assert!(!validator.validate_id("H71211672A")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/albania.rs:225:9 [INFO] [stdout] | [INFO] [stdout] 225 | assert_eq!(false, validator.validate_id("I90201535M")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 225 - assert_eq!(false, validator.validate_id("I90201535M")); [INFO] [stdout] 225 + assert!(!validator.validate_id("I90201535M")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/albania.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | assert_eq!(true, validator.validate_id("I05101999I")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 231 - assert_eq!(true, validator.validate_id("I05101999I")); [INFO] [stdout] 231 + assert!(validator.validate_id("I05101999I")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/albania.rs:232:9 [INFO] [stdout] | [INFO] [stdout] 232 | assert_eq!(true, validator.validate_id("I90201535E")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 232 - assert_eq!(true, validator.validate_id("I90201535E")); [INFO] [stdout] 232 + assert!(validator.validate_id("I90201535E")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/albania.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | assert_eq!(true, validator.validate_id("J45423004V")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 233 - assert_eq!(true, validator.validate_id("J45423004V")); [INFO] [stdout] 233 + assert!(validator.validate_id("J45423004V")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/albania.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | assert_eq!(true, validator.validate_id("H71211672R")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 234 - assert_eq!(true, validator.validate_id("H71211672R")); [INFO] [stdout] 234 + assert!(validator.validate_id("H71211672R")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/albania.rs:235:9 [INFO] [stdout] | [INFO] [stdout] 235 | assert_eq!(true, validator.validate_id("I85413200A")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 235 - assert_eq!(true, validator.validate_id("I85413200A")); [INFO] [stdout] 235 + assert!(validator.validate_id("I85413200A")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/belgium.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return validate_date(("19".to_owned() + partial_id.get(0..6).unwrap()).borrow()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return validate_date(("19".to_owned() + partial_id.get(0..6).unwrap()).borrow()); [INFO] [stdout] 33 + validate_date(("19".to_owned() + partial_id.get(0..6).unwrap()).borrow()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/belgium.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return crate::country::Code::BE; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return crate::country::Code::BE; [INFO] [stdout] 37 + crate::country::Code::BE [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/belgium.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | / return Some(Citizen { [INFO] [stdout] 71 | | gender, [INFO] [stdout] 72 | | year_of_birth: year, [INFO] [stdout] 73 | | month_of_birth: Some(standard_id.get(2..4).unwrap().parse::().unwrap()), [INFO] [stdout] 74 | | day_of_birth: Some(standard_id.get(4..6).unwrap().parse::().unwrap()), [INFO] [stdout] 75 | | place_of_birth: None, [INFO] [stdout] 76 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 ~ Some(Citizen { [INFO] [stdout] 71 + gender, [INFO] [stdout] 72 + year_of_birth: year, [INFO] [stdout] 73 + month_of_birth: Some(standard_id.get(2..4).unwrap().parse::().unwrap()), [INFO] [stdout] 74 + day_of_birth: Some(standard_id.get(4..6).unwrap().parse::().unwrap()), [INFO] [stdout] 75 + place_of_birth: None, [INFO] [stdout] 76 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/validator/belgium.rs:41:49 [INFO] [stdout] | [INFO] [stdout] 41 | if !self::BelgiumValidator::validate_id(&self, id) { [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/belgium.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | return checksum.parse::().unwrap() == calculated_checksum; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return checksum.parse::().unwrap() == calculated_checksum; [INFO] [stdout] 82 + checksum.parse::().unwrap() == calculated_checksum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `date_of_birth` after checking its variant with `is_some` [INFO] [stdout] --> src/validator/belgium.rs:93:16 [INFO] [stdout] | [INFO] [stdout] 92 | if date_of_birth.is_some() { [INFO] [stdout] | -------------------------- help: try: `if let Some() = date_of_birth` [INFO] [stdout] 93 | return date_of_birth.unwrap() <= Utc::now().naive_local().date(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/belgium.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 105 - assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] 105 + assert!(!validator.validate_id("123")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/belgium.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | assert_eq!(false, validator.validate_id("123 456 789 0")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 106 - assert_eq!(false, validator.validate_id("123 456 789 0")); [INFO] [stdout] 106 + assert!(!validator.validate_id("123 456 789 0")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/belgium.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | assert_eq!(validator.validate_id("12.12.12-132.32"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 112 - assert_eq!(validator.validate_id("12.12.12-132.32"), false); [INFO] [stdout] 112 + assert!(!validator.validate_id("12.12.12-132.32")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/belgium.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | assert_eq!(validator.validate_id("97.12.03-123.12"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 113 - assert_eq!(validator.validate_id("97.12.03-123.12"), false); [INFO] [stdout] 113 + assert!(!validator.validate_id("97.12.03-123.12")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/belgium.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | assert_eq!(validator.validate_id("01.06.18-468.99"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 114 - assert_eq!(validator.validate_id("01.06.18-468.99"), false); [INFO] [stdout] 114 + assert!(!validator.validate_id("01.06.18-468.99")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/belgium.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | assert_eq!(validator.validate_id("64.04.09-874.43"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 115 - assert_eq!(validator.validate_id("64.04.09-874.43"), false); [INFO] [stdout] 115 + assert!(!validator.validate_id("64.04.09-874.43")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/belgium.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | assert_eq!(validator.validate_id("12.10.23-954.11"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 116 - assert_eq!(validator.validate_id("12.10.23-954.11"), false); [INFO] [stdout] 116 + assert!(!validator.validate_id("12.10.23-954.11")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/belgium.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | assert_eq!(validator.validate_id("93.05.18-223.61"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 122 - assert_eq!(validator.validate_id("93.05.18-223.61"), true); [INFO] [stdout] 122 + assert!(validator.validate_id("93.05.18-223.61")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/belgium.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | assert_eq!(validator.validate_id("730111-361-73"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 123 - assert_eq!(validator.validate_id("730111-361-73"), true); [INFO] [stdout] 123 + assert!(validator.validate_id("730111-361-73")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/belgium.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | assert_eq!(validator.validate_id("75.12.05-137.14"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 124 - assert_eq!(validator.validate_id("75.12.05-137.14"), true); [INFO] [stdout] 124 + assert!(validator.validate_id("75.12.05-137.14")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/belgium.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | assert_eq!(validator.validate_id("09.08.24-282.48"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 125 - assert_eq!(validator.validate_id("09.08.24-282.48"), true); [INFO] [stdout] 125 + assert!(validator.validate_id("09.08.24-282.48")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/belgium.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | assert_eq!(validator.validate_id("71.09.07-213.64"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 126 - assert_eq!(validator.validate_id("71.09.07-213.64"), true); [INFO] [stdout] 126 + assert!(validator.validate_id("71.09.07-213.64")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/validator/bosniaherzegovina.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | if (region < 10 || region > 19) && region != 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(10..=19).contains(®ion)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/validator/bosniaherzegovina.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | let g; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `g` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 57 ~ [INFO] [stdout] 58 ~ let g = if standard_id[9..12].parse::().unwrap() < 500 { [INFO] [stdout] 59 ~ 'M' [INFO] [stdout] 60 | } else { [INFO] [stdout] 61 ~ 'F' [INFO] [stdout] 62 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bosniaherzegovina.rs:182:9 [INFO] [stdout] | [INFO] [stdout] 182 | assert_eq!(false, validator.validate_id("123456789")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 182 - assert_eq!(false, validator.validate_id("123456789")); [INFO] [stdout] 182 + assert!(!validator.validate_id("123456789")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bosniaherzegovina.rs:183:9 [INFO] [stdout] | [INFO] [stdout] 183 | assert_eq!(false, validator.validate_id("12345678910111213")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 183 - assert_eq!(false, validator.validate_id("12345678910111213")); [INFO] [stdout] 183 + assert!(!validator.validate_id("12345678910111213")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bosniaherzegovina.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | assert_eq!(false, validator.validate_id("2808928401264")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 189 - assert_eq!(false, validator.validate_id("2808928401264")); [INFO] [stdout] 189 + assert!(!validator.validate_id("2808928401264")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bosniaherzegovina.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | assert_eq!(false, validator.validate_id("2007950274591")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 190 - assert_eq!(false, validator.validate_id("2007950274591")); [INFO] [stdout] 190 + assert!(!validator.validate_id("2007950274591")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bosniaherzegovina.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | assert_eq!(false, validator.validate_id("1108291065212")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 196 - assert_eq!(false, validator.validate_id("1108291065212")); [INFO] [stdout] 196 + assert!(!validator.validate_id("1108291065212")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bosniaherzegovina.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 197 | assert_eq!(false, validator.validate_id("2801826817261")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 197 - assert_eq!(false, validator.validate_id("2801826817261")); [INFO] [stdout] 197 + assert!(!validator.validate_id("2801826817261")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bosniaherzegovina.rs:198:9 [INFO] [stdout] | [INFO] [stdout] 198 | assert_eq!(false, validator.validate_id("1012999121239")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 198 - assert_eq!(false, validator.validate_id("1012999121239")); [INFO] [stdout] 198 + assert!(!validator.validate_id("1012999121239")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bosniaherzegovina.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | assert_eq!(true, validator.validate_id("1502957172694")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 204 - assert_eq!(true, validator.validate_id("1502957172694")); [INFO] [stdout] 204 + assert!(validator.validate_id("1502957172694")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bosniaherzegovina.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 205 | assert_eq!(true, validator.validate_id("2508995191483")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 205 - assert_eq!(true, validator.validate_id("2508995191483")); [INFO] [stdout] 205 + assert!(validator.validate_id("2508995191483")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bosniaherzegovina.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 206 | assert_eq!(true, validator.validate_id("1012980163603")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 206 - assert_eq!(true, validator.validate_id("1012980163603")); [INFO] [stdout] 206 + assert!(validator.validate_id("1012980163603")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bosniaherzegovina.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | assert_eq!(true, validator.validate_id("1310963145538")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 207 - assert_eq!(true, validator.validate_id("1310963145538")); [INFO] [stdout] 207 + assert!(validator.validate_id("1310963145538")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bosniaherzegovina.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | assert_eq!(true, validator.validate_id("1806998154160")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 208 - assert_eq!(true, validator.validate_id("1806998154160")); [INFO] [stdout] 208 + assert!(validator.validate_id("1806998154160")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/brazil.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / return standard_id[(standard_id.len() - 2)..] [INFO] [stdout] 30 | | .parse::() [INFO] [stdout] 31 | | .unwrap() [INFO] [stdout] 32 | | == ((v1 * 10) + v2); [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ standard_id[(standard_id.len() - 2)..] [INFO] [stdout] 30 + .parse::() [INFO] [stdout] 31 + .unwrap() [INFO] [stdout] 32 ~ == ((v1 * 10) + v2) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/validator/brazil.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | v1 = v1 + c.to_digit(32).unwrap() * (9 - (idx % 10)) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `v1 += c.to_digit(32).unwrap() * (9 - (idx % 10)) as u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/validator/brazil.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | v2 = v2 + c.to_digit(32).unwrap() * (9 - ((idx + 1) % 10)) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `v2 += c.to_digit(32).unwrap() * (9 - ((idx + 1) % 10)) as u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/validator/brazil.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | v2 = v2 + (v1 * 9); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `v2 += (v1 * 9)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/brazil.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | return crate::country::Code::BR; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return crate::country::Code::BR; [INFO] [stdout] 36 + crate::country::Code::BR [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/brazil.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return None; [INFO] [stdout] 40 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | assert_eq!(validator.validate_id("1234567ACAB"), false); // not numeric [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 51 - assert_eq!(validator.validate_id("1234567ACAB"), false); // not numeric [INFO] [stdout] 51 + assert!(!validator.validate_id("1234567ACAB")); // not numeric [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | assert_eq!(validator.validate_id("123456789012"), false); // more than 11 digits [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 52 - assert_eq!(validator.validate_id("123456789012"), false); // more than 11 digits [INFO] [stdout] 52 + assert!(!validator.validate_id("123456789012")); // more than 11 digits [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | assert_eq!(validator.validate_id("1234567890"), false); // less than 11 digits [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 53 - assert_eq!(validator.validate_id("1234567890"), false); // less than 11 digits [INFO] [stdout] 53 + assert!(!validator.validate_id("1234567890")); // less than 11 digits [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | assert_eq!(validator.validate_id("23294954040"), false); // bad checksum [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 54 - assert_eq!(validator.validate_id("23294954040"), false); // bad checksum [INFO] [stdout] 54 + assert!(!validator.validate_id("23294954040")); // bad checksum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | assert_eq!(validator.validate_id("144-416-762.63"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 56 - assert_eq!(validator.validate_id("144-416-762.63"), true); [INFO] [stdout] 56 + assert!(validator.validate_id("144-416-762.63")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | assert_eq!(validator.validate_id(" 62363568400 "), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 57 - assert_eq!(validator.validate_id(" 62363568400 "), true); [INFO] [stdout] 57 + assert!(validator.validate_id(" 62363568400 ")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | assert_eq!(validator.validate_id("92205820230"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 58 - assert_eq!(validator.validate_id("92205820230"), true); [INFO] [stdout] 58 + assert!(validator.validate_id("92205820230")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | assert_eq!(validator.validate_id("88958056231"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 59 - assert_eq!(validator.validate_id("88958056231"), true); [INFO] [stdout] 59 + assert!(validator.validate_id("88958056231")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | assert_eq!(validator.validate_id("90701066555"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 60 - assert_eq!(validator.validate_id("90701066555"), true); [INFO] [stdout] 60 + assert!(validator.validate_id("90701066555")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | assert_eq!(validator.validate_id("31098035348"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 61 - assert_eq!(validator.validate_id("31098035348"), true); [INFO] [stdout] 61 + assert!(validator.validate_id("31098035348")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | assert_eq!(validator.validate_id("54271183148"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 62 - assert_eq!(validator.validate_id("54271183148"), true); [INFO] [stdout] 62 + assert!(validator.validate_id("54271183148")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | assert_eq!(validator.validate_id("03860881795"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 63 - assert_eq!(validator.validate_id("03860881795"), true); [INFO] [stdout] 63 + assert!(validator.validate_id("03860881795")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | assert_eq!(validator.validate_id("15777379117"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 64 - assert_eq!(validator.validate_id("15777379117"), true); [INFO] [stdout] 64 + assert!(validator.validate_id("15777379117")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | assert_eq!(validator.validate_id("46959616360"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 65 - assert_eq!(validator.validate_id("46959616360"), true); [INFO] [stdout] 65 + assert!(validator.validate_id("46959616360")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | assert_eq!(validator.validate_id("51861041675"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 66 - assert_eq!(validator.validate_id("51861041675"), true); [INFO] [stdout] 66 + assert!(validator.validate_id("51861041675")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | assert_eq!(validator.validate_id("35823686102"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 67 - assert_eq!(validator.validate_id("35823686102"), true); [INFO] [stdout] 67 + assert!(validator.validate_id("35823686102")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | assert_eq!(validator.validate_id("26319324120"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 68 - assert_eq!(validator.validate_id("26319324120"), true); [INFO] [stdout] 68 + assert!(validator.validate_id("26319324120")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | assert_eq!(validator.validate_id("81036850463"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 69 - assert_eq!(validator.validate_id("81036850463"), true); [INFO] [stdout] 69 + assert!(validator.validate_id("81036850463")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | assert_eq!(validator.validate_id("17188856443"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 70 - assert_eq!(validator.validate_id("17188856443"), true); [INFO] [stdout] 70 + assert!(validator.validate_id("17188856443")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | assert_eq!(validator.validate_id("16556182451"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 71 - assert_eq!(validator.validate_id("16556182451"), true); [INFO] [stdout] 71 + assert!(validator.validate_id("16556182451")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | assert_eq!(validator.validate_id("13369586347"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 72 - assert_eq!(validator.validate_id("13369586347"), true); [INFO] [stdout] 72 + assert!(validator.validate_id("13369586347")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | assert_eq!(validator.validate_id("19319810940"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 73 - assert_eq!(validator.validate_id("19319810940"), true); [INFO] [stdout] 73 + assert!(validator.validate_id("19319810940")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | assert_eq!(validator.validate_id("41120495792"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 74 - assert_eq!(validator.validate_id("41120495792"), true); [INFO] [stdout] 74 + assert!(validator.validate_id("41120495792")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | assert_eq!(validator.validate_id("79950524482"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 75 - assert_eq!(validator.validate_id("79950524482"), true); [INFO] [stdout] 75 + assert!(validator.validate_id("79950524482")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | assert_eq!(validator.validate_id("44667914068"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 76 - assert_eq!(validator.validate_id("44667914068"), true); [INFO] [stdout] 76 + assert!(validator.validate_id("44667914068")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | assert_eq!(validator.validate_id("41947527240"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 77 - assert_eq!(validator.validate_id("41947527240"), true); [INFO] [stdout] 77 + assert!(validator.validate_id("41947527240")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | assert_eq!(validator.validate_id("23554835234"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 78 - assert_eq!(validator.validate_id("23554835234"), true); [INFO] [stdout] 78 + assert!(validator.validate_id("23554835234")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | assert_eq!(validator.validate_id("04008125922"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 79 - assert_eq!(validator.validate_id("04008125922"), true); [INFO] [stdout] 79 + assert!(validator.validate_id("04008125922")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | assert_eq!(validator.validate_id("37025634581"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 80 - assert_eq!(validator.validate_id("37025634581"), true); [INFO] [stdout] 80 + assert!(validator.validate_id("37025634581")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | assert_eq!(validator.validate_id("26363102820"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 81 - assert_eq!(validator.validate_id("26363102820"), true); [INFO] [stdout] 81 + assert!(validator.validate_id("26363102820")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | assert_eq!(validator.validate_id("17758534112"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 82 - assert_eq!(validator.validate_id("17758534112"), true); [INFO] [stdout] 82 + assert!(validator.validate_id("17758534112")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/brazil.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | assert_eq!(validator.extract_citizen("17758534112").is_none(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 88 - assert_eq!(validator.extract_citizen("17758534112").is_none(), true); [INFO] [stdout] 88 + assert!(validator.extract_citizen("17758534112").is_none()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/validator/bulgaria.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | / if date_of_birth.is_none() { [INFO] [stdout] 60 | | return None; [INFO] [stdout] 61 | | } [INFO] [stdout] | |_________^ help: replace it with: `date_of_birth?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bulgaria.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 86 - assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] 86 + assert!(!validator.validate_id("123")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bulgaria.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | assert_eq!(false, validator.validate_id("12345678901")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 87 - assert_eq!(false, validator.validate_id("12345678901")); [INFO] [stdout] 87 + assert!(!validator.validate_id("12345678901")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bulgaria.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | assert_eq!(false, validator.validate_id("7542021030")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 93 - assert_eq!(false, validator.validate_id("7542021030")); [INFO] [stdout] 93 + assert!(!validator.validate_id("7542021030")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bulgaria.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | assert_eq!(false, validator.validate_id("8002560008")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 94 - assert_eq!(false, validator.validate_id("8002560008")); [INFO] [stdout] 94 + assert!(!validator.validate_id("8002560008")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bulgaria.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | assert_eq!(false, validator.validate_id("3542027033")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 95 - assert_eq!(false, validator.validate_id("3542027033")); [INFO] [stdout] 95 + assert!(!validator.validate_id("3542027033")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bulgaria.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | assert_eq!(false, validator.validate_id("6002567498")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 96 - assert_eq!(false, validator.validate_id("6002567498")); [INFO] [stdout] 96 + assert!(!validator.validate_id("6002567498")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bulgaria.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | assert_eq!(false, validator.validate_id("7542039611")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 97 - assert_eq!(false, validator.validate_id("7542039611")); [INFO] [stdout] 97 + assert!(!validator.validate_id("7542039611")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bulgaria.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | assert_eq!(true, validator.validate_id("7523169263")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 103 - assert_eq!(true, validator.validate_id("7523169263")); [INFO] [stdout] 103 + assert!(validator.validate_id("7523169263")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bulgaria.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | assert_eq!(true, validator.validate_id("8032056031")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 104 - assert_eq!(true, validator.validate_id("8032056031")); [INFO] [stdout] 104 + assert!(validator.validate_id("8032056031")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bulgaria.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | assert_eq!(true, validator.validate_id("8001010008")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 105 - assert_eq!(true, validator.validate_id("8001010008")); [INFO] [stdout] 105 + assert!(validator.validate_id("8001010008")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bulgaria.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | assert_eq!(true, validator.validate_id("7501020018")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 106 - assert_eq!(true, validator.validate_id("7501020018")); [INFO] [stdout] 106 + assert!(validator.validate_id("7501020018")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bulgaria.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | assert_eq!(true, validator.validate_id("7552010005")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 107 - assert_eq!(true, validator.validate_id("7552010005")); [INFO] [stdout] 107 + assert!(validator.validate_id("7552010005")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/bulgaria.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | assert_eq!(true, validator.validate_id("7542011030")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 108 - assert_eq!(true, validator.validate_id("7542011030")); [INFO] [stdout] 108 + assert!(validator.validate_id("7542011030")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/canada.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 41 - assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] 41 + assert!(!validator.validate_id("123")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/canada.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | assert_eq!(false, validator.validate_id("123-456-7")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 42 - assert_eq!(false, validator.validate_id("123-456-7")); [INFO] [stdout] 42 + assert!(!validator.validate_id("123-456-7")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/canada.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | assert_eq!(validator.validate_id("512 917 638"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 48 - assert_eq!(validator.validate_id("512 917 638"), false); [INFO] [stdout] 48 + assert!(!validator.validate_id("512 917 638")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/canada.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | assert_eq!(validator.validate_id("322 710 094"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 49 - assert_eq!(validator.validate_id("322 710 094"), false); [INFO] [stdout] 49 + assert!(!validator.validate_id("322 710 094")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/canada.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | assert_eq!(validator.validate_id("761 999 512"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 50 - assert_eq!(validator.validate_id("761 999 512"), false); [INFO] [stdout] 50 + assert!(!validator.validate_id("761 999 512")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/canada.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | assert_eq!(validator.validate_id("061 003 528"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 51 - assert_eq!(validator.validate_id("061 003 528"), false); [INFO] [stdout] 51 + assert!(!validator.validate_id("061 003 528")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/canada.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | assert_eq!(validator.validate_id("046 454 286"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 57 - assert_eq!(validator.validate_id("046 454 286"), true); [INFO] [stdout] 57 + assert!(validator.validate_id("046 454 286")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/canada.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | assert_eq!(validator.validate_id("671 143 899"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 58 - assert_eq!(validator.validate_id("671 143 899"), true); [INFO] [stdout] 58 + assert!(validator.validate_id("671 143 899")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/canada.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | assert_eq!(validator.validate_id("002 371 920"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 59 - assert_eq!(validator.validate_id("002 371 920"), true); [INFO] [stdout] 59 + assert!(validator.validate_id("002 371 920")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/canada.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | assert_eq!(validator.validate_id("501 343 719"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 60 - assert_eq!(validator.validate_id("501 343 719"), true); [INFO] [stdout] 60 + assert!(validator.validate_id("501 343 719")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/canada.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | assert_eq!(validator.validate_id("912 046 737"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 61 - assert_eq!(validator.validate_id("912 046 737"), true); [INFO] [stdout] 61 + assert!(validator.validate_id("912 046 737")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/denmark.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | return self.is_date_valid(year, month, day) && validate_checksum(&standard_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return self.is_date_valid(year, month, day) && validate_checksum(&standard_id); [INFO] [stdout] 26 + self.is_date_valid(year, month, day) && validate_checksum(&standard_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/denmark.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | / return Some(Citizen { [INFO] [stdout] 41 | | gender, [INFO] [stdout] 42 | | year_of_birth: extract_year(&standard_id) as i32, [INFO] [stdout] 43 | | month_of_birth: Some(standard_id[2..4].parse::().unwrap()), [INFO] [stdout] 44 | | day_of_birth: Some(standard_id[0..2].parse::().unwrap()), [INFO] [stdout] 45 | | place_of_birth: None, [INFO] [stdout] 46 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 ~ Some(Citizen { [INFO] [stdout] 41 + gender, [INFO] [stdout] 42 + year_of_birth: extract_year(&standard_id) as i32, [INFO] [stdout] 43 + month_of_birth: Some(standard_id[2..4].parse::().unwrap()), [INFO] [stdout] 44 + day_of_birth: Some(standard_id[0..2].parse::().unwrap()), [INFO] [stdout] 45 + place_of_birth: None, [INFO] [stdout] 46 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/denmark.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | return century + year_code; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return century + year_code; [INFO] [stdout] 70 + century + year_code [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/denmark.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | return sum % 11 == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return sum % 11 == 0; [INFO] [stdout] 79 + sum % 11 == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/validator/denmark.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | return sum % 11 == 0; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace with: `sum.is_multiple_of(11)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/denmark.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | assert_eq!(false, validator.validate_id("")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 89 - assert_eq!(false, validator.validate_id("")); [INFO] [stdout] 89 + assert!(!validator.validate_id("")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/denmark.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 90 - assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] 90 + assert!(!validator.validate_id("123")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/denmark.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | assert_eq!(false, validator.validate_id("123-456-78")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 91 - assert_eq!(false, validator.validate_id("123-456-78")); [INFO] [stdout] 91 + assert!(!validator.validate_id("123-456-78")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/denmark.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | assert_eq!(false, validator.validate_id("123-456-788-15")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 92 - assert_eq!(false, validator.validate_id("123-456-788-15")); [INFO] [stdout] 92 + assert!(!validator.validate_id("123-456-788-15")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/denmark.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | assert_eq!(validator.validate_id("161301-0001"), false); // month too high [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 98 - assert_eq!(validator.validate_id("161301-0001"), false); // month too high [INFO] [stdout] 98 + assert!(!validator.validate_id("161301-0001")); // month too high [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/denmark.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | assert_eq!(validator.validate_id("311101-0001"), false); // November has 30 days [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 99 - assert_eq!(validator.validate_id("311101-0001"), false); // November has 30 days [INFO] [stdout] 99 + assert!(!validator.validate_id("311101-0001")); // November has 30 days [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/denmark.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | assert_eq!(validator.validate_id("321201-0001"), false); // day too high [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 100 - assert_eq!(validator.validate_id("321201-0001"), false); // day too high [INFO] [stdout] 100 + assert!(!validator.validate_id("321201-0001")); // day too high [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/denmark.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | assert_eq!(validator.validate_id("290201-0001"), false); // 29 February only exists in leap year [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 101 - assert_eq!(validator.validate_id("290201-0001"), false); // 29 February only exists in leap year [INFO] [stdout] 101 + assert!(!validator.validate_id("290201-0001")); // 29 February only exists in leap year [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/denmark.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | assert_eq!(validator.validate_id("230321-2454"), false); // bad checksum [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 102 - assert_eq!(validator.validate_id("230321-2454"), false); // bad checksum [INFO] [stdout] 102 + assert!(!validator.validate_id("230321-2454")); // bad checksum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/denmark.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 108 | assert_eq!(validator.validate_id(" 090792-1395 "), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 108 - assert_eq!(validator.validate_id(" 090792-1395 "), true); [INFO] [stdout] 108 + assert!(validator.validate_id(" 090792-1395 ")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/denmark.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 109 | assert_eq!(validator.validate_id("0705930600"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 109 - assert_eq!(validator.validate_id("0705930600"), true); [INFO] [stdout] 109 + assert!(validator.validate_id("0705930600")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/denmark.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | assert_eq!(validator.validate_id("1504373068"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 110 - assert_eq!(validator.validate_id("1504373068"), true); [INFO] [stdout] 110 + assert!(validator.validate_id("1504373068")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/denmark.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | assert_eq!(validator.validate_id("1608881995"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 111 - assert_eq!(validator.validate_id("1608881995"), true); [INFO] [stdout] 111 + assert!(validator.validate_id("1608881995")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/denmark.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | assert_eq!(validator.validate_id("0404047094"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 112 - assert_eq!(validator.validate_id("0404047094"), true); [INFO] [stdout] 112 + assert!(validator.validate_id("0404047094")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/france.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return control_digit == 97 - (partial_id % 97); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return control_digit == 97 - (partial_id % 97); [INFO] [stdout] 33 + control_digit == 97 - (partial_id % 97) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/validator/france.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | if !char.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `char.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/france.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return crate::country::Code::FR; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return crate::country::Code::FR; [INFO] [stdout] 37 + crate::country::Code::FR [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/france.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | / return Some(Citizen { [INFO] [stdout] 47 | | gender: if String::from(&id[0..1]).parse::().unwrap() == 1_u8 { [INFO] [stdout] 48 | | 'M' [INFO] [stdout] 49 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 59 | | }, [INFO] [stdout] 60 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 ~ Some(Citizen { [INFO] [stdout] 47 + gender: if String::from(&id[0..1]).parse::().unwrap() == 1_u8 { [INFO] [stdout] 48 + 'M' [INFO] [stdout] 49 + } else { [INFO] [stdout] 50 + 'F' [INFO] [stdout] 51 + }, [INFO] [stdout] 52 + year_of_birth: date::get_year_of_birth(&id[1..3]), [INFO] [stdout] 53 + month_of_birth: get_month_of_birth(&id[3..5]), [INFO] [stdout] 54 + day_of_birth: None, [INFO] [stdout] 55 + place_of_birth: if region.is_some() { [INFO] [stdout] 56 + region [INFO] [stdout] 57 + } else { [INFO] [stdout] 58 + get_region_of_birth(&id[5..8]) [INFO] [stdout] 59 + }, [INFO] [stdout] 60 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/validator/france.rs:41:48 [INFO] [stdout] | [INFO] [stdout] 41 | if !self::FranceValidator::validate_id(&self, id) { [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/france.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | / return if month > 1_u8 && month < 13_u8 { [INFO] [stdout] 67 | | Some(month) [INFO] [stdout] 68 | | } else if month > 30_u8 && month < 43_u8 { [INFO] [stdout] 69 | | Some(month - 30_u8) [INFO] [stdout] 70 | | } else { [INFO] [stdout] 71 | | None [INFO] [stdout] 72 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 ~ if month > 1_u8 && month < 13_u8 { [INFO] [stdout] 67 + Some(month) [INFO] [stdout] 68 + } else if month > 30_u8 && month < 43_u8 { [INFO] [stdout] 69 + Some(month - 30_u8) [INFO] [stdout] 70 + } else { [INFO] [stdout] 71 + None [INFO] [stdout] 72 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/france.rs:187:5 [INFO] [stdout] | [INFO] [stdout] 187 | / return if region.is_empty() { [INFO] [stdout] 188 | | None [INFO] [stdout] 189 | | } else { [INFO] [stdout] 190 | | Some(String::from(region)) [INFO] [stdout] 191 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 187 ~ if region.is_empty() { [INFO] [stdout] 188 + None [INFO] [stdout] 189 + } else { [INFO] [stdout] 190 + Some(String::from(region)) [INFO] [stdout] 191 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/france.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 202 | assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 202 - assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] 202 + assert!(!validator.validate_id("123")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/france.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 203 | assert_eq!(false, validator.validate_id("123 456 789 0")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 203 - assert_eq!(false, validator.validate_id("123 456 789 0")); [INFO] [stdout] 203 + assert!(!validator.validate_id("123 456 789 0")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/france.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | assert_eq!(validator.validate_id("2312760989812 01"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 209 - assert_eq!(validator.validate_id("2312760989812 01"), false); [INFO] [stdout] 209 + assert!(!validator.validate_id("2312760989812 01")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/france.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 210 | assert_eq!(validator.validate_id("2312763214568 54"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 210 - assert_eq!(validator.validate_id("2312763214568 54"), false); [INFO] [stdout] 210 + assert!(!validator.validate_id("2312763214568 54")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/france.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | assert_eq!(validator.validate_id("2820819398814 09"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 216 - assert_eq!(validator.validate_id("2820819398814 09"), true); [INFO] [stdout] 216 + assert!(validator.validate_id("2820819398814 09")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/france.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 217 | assert_eq!(validator.validate_id("1350455179061 16"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 217 - assert_eq!(validator.validate_id("1350455179061 16"), true); [INFO] [stdout] 217 + assert!(validator.validate_id("1350455179061 16")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/france.rs:218:9 [INFO] [stdout] | [INFO] [stdout] 218 | assert_eq!(validator.validate_id("2381080214568 11"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 218 - assert_eq!(validator.validate_id("2381080214568 11"), true); [INFO] [stdout] 218 + assert!(validator.validate_id("2381080214568 11")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/france.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 219 | assert_eq!(validator.validate_id("1880858704571 57"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 219 - assert_eq!(validator.validate_id("1880858704571 57"), true); [INFO] [stdout] 219 + assert!(validator.validate_id("1880858704571 57")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/france.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | assert_eq!(validator.validate_id("1820897401154 75"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 220 - assert_eq!(validator.validate_id("1820897401154 75"), true); [INFO] [stdout] 220 + assert!(validator.validate_id("1820897401154 75")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/france.rs:226:9 [INFO] [stdout] | [INFO] [stdout] 226 | / assert_eq!( [INFO] [stdout] 227 | | validator.extract_citizen("2312760989812 01").is_none(), [INFO] [stdout] 228 | | true [INFO] [stdout] 229 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 226 ~ assert!( [INFO] [stdout] 227 ~ validator.extract_citizen("2312760989812 01").is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/france.rs:253:9 [INFO] [stdout] | [INFO] [stdout] 253 | assert_eq!(unknown_region.is_none(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 253 - assert_eq!(unknown_region.is_none(), true); [INFO] [stdout] 253 + assert!(unknown_region.is_none()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/france.rs:254:9 [INFO] [stdout] | [INFO] [stdout] 254 | assert_eq!(known_region.is_some(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 254 - assert_eq!(known_region.is_some(), true); [INFO] [stdout] 254 + assert!(known_region.is_some()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/germany.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | assert_eq!(false, validator.validate_id("")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 79 - assert_eq!(false, validator.validate_id("")); [INFO] [stdout] 79 + assert!(!validator.validate_id("")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/germany.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | assert_eq!(false, validator.validate_id("1234567890123")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 80 - assert_eq!(false, validator.validate_id("1234567890123")); [INFO] [stdout] 80 + assert!(!validator.validate_id("1234567890123")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/germany.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | assert_eq!(false, validator.validate_id("12345678901")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 81 - assert_eq!(false, validator.validate_id("12345678901")); [INFO] [stdout] 81 + assert!(!validator.validate_id("12345678901")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/germany.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | assert_eq!(false, validator.validate_id("12345678901A")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 82 - assert_eq!(false, validator.validate_id("12345678901A")); [INFO] [stdout] 82 + assert!(!validator.validate_id("12345678901A")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/germany.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | assert_eq!(false, validator.validate_id("02476291358")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 89 - assert_eq!(false, validator.validate_id("02476291358")); [INFO] [stdout] 89 + assert!(!validator.validate_id("02476291358")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/germany.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | assert_eq!(false, validator.validate_id("44491234560")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 91 - assert_eq!(false, validator.validate_id("44491234560")); [INFO] [stdout] 91 + assert!(!validator.validate_id("44491234560")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/germany.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | assert_eq!(false, validator.validate_id("11145678908")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 93 - assert_eq!(false, validator.validate_id("11145678908")); [INFO] [stdout] 93 + assert!(!validator.validate_id("11145678908")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/germany.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | assert_eq!(true, validator.validate_id("86095742719")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 99 - assert_eq!(true, validator.validate_id("86095742719")); [INFO] [stdout] 99 + assert!(validator.validate_id("86095742719")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/germany.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | assert_eq!(true, validator.validate_id("47036892816")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 100 - assert_eq!(true, validator.validate_id("47036892816")); [INFO] [stdout] 100 + assert!(validator.validate_id("47036892816")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/germany.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | assert_eq!(true, validator.validate_id("65929970489")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 101 - assert_eq!(true, validator.validate_id("65929970489")); [INFO] [stdout] 101 + assert!(validator.validate_id("65929970489")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/germany.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | assert_eq!(true, validator.validate_id("57549285017")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 102 - assert_eq!(true, validator.validate_id("57549285017")); [INFO] [stdout] 102 + assert!(validator.validate_id("57549285017")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/germany.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | assert_eq!(true, validator.validate_id("25768131411")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 103 - assert_eq!(true, validator.validate_id("25768131411")); [INFO] [stdout] 103 + assert!(validator.validate_id("25768131411")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/italy.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return (standard_id[15..].parse::().unwrap()) == control_letter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return (standard_id[15..].parse::().unwrap()) == control_letter; [INFO] [stdout] 39 + (standard_id[15..].parse::().unwrap()) == control_letter [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/italy.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | return crate::country::Code::IT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return crate::country::Code::IT; [INFO] [stdout] 43 + crate::country::Code::IT [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/italy.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | / return Some(Citizen { [INFO] [stdout] 52 | | gender: get_gender(&id[9..11]), [INFO] [stdout] 53 | | year_of_birth: date::get_year_of_birth(&id[6..8]), [INFO] [stdout] 54 | | month_of_birth: get_month_of_birth(id[8..9].parse::().unwrap()), [INFO] [stdout] ... | [INFO] [stdout] 59 | | ), //italy_regions::get_region(&id[11..15]), [INFO] [stdout] 60 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 ~ Some(Citizen { [INFO] [stdout] 52 + gender: get_gender(&id[9..11]), [INFO] [stdout] 53 + year_of_birth: date::get_year_of_birth(&id[6..8]), [INFO] [stdout] 54 + month_of_birth: get_month_of_birth(id[8..9].parse::().unwrap()), [INFO] [stdout] 55 + day_of_birth: Some(get_day_of_birth(&id[9..11])), [INFO] [stdout] 56 + place_of_birth: regions::get_region_from_csv( [INFO] [stdout] 57 + &id[11..15], [INFO] [stdout] 58 + "./src/validator/regions/italy_regions.csv", [INFO] [stdout] 59 + ), //italy_regions::get_region(&id[11..15]), [INFO] [stdout] 60 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/validator/italy.rs:47:47 [INFO] [stdout] | [INFO] [stdout] 47 | if !self::ItalyValidator::validate_id(&self, id) { [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/italy.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | / return match character { [INFO] [stdout] 66 | | '0' | 'A' => 1, [INFO] [stdout] 67 | | '1' | 'B' => 0, [INFO] [stdout] 68 | | '2' | 'C' => 5, [INFO] [stdout] ... | [INFO] [stdout] 92 | | _ => panic!("Unrecognized letter"), [INFO] [stdout] 93 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 ~ match character { [INFO] [stdout] 66 + '0' | 'A' => 1, [INFO] [stdout] 67 + '1' | 'B' => 0, [INFO] [stdout] 68 + '2' | 'C' => 5, [INFO] [stdout] 69 + '3' | 'D' => 7, [INFO] [stdout] 70 + '4' | 'F' => 9, [INFO] [stdout] 71 + '5' | 'E' => 13, [INFO] [stdout] 72 + '6' | 'G' => 15, [INFO] [stdout] 73 + '7' | 'H' => 17, [INFO] [stdout] 74 + '8' | 'I' => 19, [INFO] [stdout] 75 + '9' | 'J' => 21, [INFO] [stdout] 76 + 'K' => 2, [INFO] [stdout] 77 + 'L' => 4, [INFO] [stdout] 78 + 'M' => 18, [INFO] [stdout] 79 + 'N' => 20, [INFO] [stdout] 80 + 'O' => 11, [INFO] [stdout] 81 + 'P' => 3, [INFO] [stdout] 82 + 'Q' => 6, [INFO] [stdout] 83 + 'R' => 8, [INFO] [stdout] 84 + 'S' => 12, [INFO] [stdout] 85 + 'T' => 14, [INFO] [stdout] 86 + 'U' => 16, [INFO] [stdout] 87 + 'V' => 10, [INFO] [stdout] 88 + 'W' => 22, [INFO] [stdout] 89 + 'X' => 25, [INFO] [stdout] 90 + 'Y' => 24, [INFO] [stdout] 91 + 'Z' => 23, [INFO] [stdout] 92 + _ => panic!("Unrecognized letter"), [INFO] [stdout] 93 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/italy.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | / return match digit { [INFO] [stdout] 98 | | 0 => 'A', [INFO] [stdout] 99 | | 1 => 'B', [INFO] [stdout] 100 | | 2 => 'C', [INFO] [stdout] ... | [INFO] [stdout] 124 | | _ => panic!("out of range for digit conversion"), [INFO] [stdout] 125 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 ~ match digit { [INFO] [stdout] 98 + 0 => 'A', [INFO] [stdout] 99 + 1 => 'B', [INFO] [stdout] 100 + 2 => 'C', [INFO] [stdout] 101 + 3 => 'D', [INFO] [stdout] 102 + 4 => 'E', [INFO] [stdout] 103 + 5 => 'F', [INFO] [stdout] 104 + 6 => 'G', [INFO] [stdout] 105 + 7 => 'H', [INFO] [stdout] 106 + 8 => 'I', [INFO] [stdout] 107 + 9 => 'J', [INFO] [stdout] 108 + 10 => 'K', [INFO] [stdout] 109 + 11 => 'L', [INFO] [stdout] 110 + 12 => 'M', [INFO] [stdout] 111 + 13 => 'N', [INFO] [stdout] 112 + 14 => 'O', [INFO] [stdout] 113 + 15 => 'P', [INFO] [stdout] 114 + 16 => 'Q', [INFO] [stdout] 115 + 17 => 'R', [INFO] [stdout] 116 + 18 => 'S', [INFO] [stdout] 117 + 19 => 'T', [INFO] [stdout] 118 + 20 => 'U', [INFO] [stdout] 119 + 21 => 'V', [INFO] [stdout] 120 + 22 => 'W', [INFO] [stdout] 121 + 23 => 'X', [INFO] [stdout] 122 + 24 => 'Y', [INFO] [stdout] 123 + 25 => 'Z', [INFO] [stdout] 124 + _ => panic!("out of range for digit conversion"), [INFO] [stdout] 125 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/italy.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | return if digit > 9 { digit - 10_u8 } else { digit }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 - return if digit > 9 { digit - 10_u8 } else { digit }; [INFO] [stdout] 130 + if digit > 9 { digit - 10_u8 } else { digit } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/italy.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | / return match letter { [INFO] [stdout] 135 | | 'A' => Some(1), [INFO] [stdout] 136 | | 'B' => Some(2), [INFO] [stdout] 137 | | 'C' => Some(3), [INFO] [stdout] ... | [INFO] [stdout] 147 | | _ => None, [INFO] [stdout] 148 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 ~ match letter { [INFO] [stdout] 135 + 'A' => Some(1), [INFO] [stdout] 136 + 'B' => Some(2), [INFO] [stdout] 137 + 'C' => Some(3), [INFO] [stdout] 138 + 'D' => Some(4), [INFO] [stdout] 139 + 'E' => Some(5), [INFO] [stdout] 140 + 'H' => Some(6), [INFO] [stdout] 141 + 'L' => Some(7), [INFO] [stdout] 142 + 'M' => Some(8), [INFO] [stdout] 143 + 'P' => Some(9), [INFO] [stdout] 144 + 'R' => Some(10), [INFO] [stdout] 145 + 'S' => Some(11), [INFO] [stdout] 146 + 'T' => Some(12), [INFO] [stdout] 147 + _ => None, [INFO] [stdout] 148 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/italy.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | return if day > 40 { day - 40_u8 } else { day }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 153 - return if day > 40 { day - 40_u8 } else { day }; [INFO] [stdout] 153 + if day > 40 { day - 40_u8 } else { day } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/italy.rs:158:5 [INFO] [stdout] | [INFO] [stdout] 158 | return if day > 40 { 'F' } else { 'M' }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 158 - return if day > 40 { 'F' } else { 'M' }; [INFO] [stdout] 158 + if day > 40 { 'F' } else { 'M' } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/italy.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 169 - assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] 169 + assert!(!validator.validate_id("123")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/italy.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 170 | assert_eq!(false, validator.validate_id("123-456-7")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 170 - assert_eq!(false, validator.validate_id("123-456-7")); [INFO] [stdout] 170 + assert!(!validator.validate_id("123-456-7")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/italy.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 192 | assert_eq!(validator.validate_id("MECDRE01A11A025E"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 192 - assert_eq!(validator.validate_id("MECDRE01A11A025E"), false); [INFO] [stdout] 192 + assert!(!validator.validate_id("MECDRE01A11A025E")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/italy.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 193 | assert_eq!(validator.validate_id("ARSLGE02D50H987A"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 193 - assert_eq!(validator.validate_id("ARSLGE02D50H987A"), false); [INFO] [stdout] 193 + assert!(!validator.validate_id("ARSLGE02D50H987A")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/italy.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 194 | assert_eq!(validator.validate_id("CSTDAM75B06C215T"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 194 - assert_eq!(validator.validate_id("CSTDAM75B06C215T"), false); [INFO] [stdout] 194 + assert!(!validator.validate_id("CSTDAM75B06C215T")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/italy.rs:195:9 [INFO] [stdout] | [INFO] [stdout] 195 | assert_eq!(validator.validate_id("ARLSNT66P65Z404R"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 195 - assert_eq!(validator.validate_id("ARLSNT66P65Z404R"), false); [INFO] [stdout] 195 + assert!(!validator.validate_id("ARLSNT66P65Z404R")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/italy.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 201 | assert_eq!(validator.validate_id("MRTMTT25D09F205Z"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 201 - assert_eq!(validator.validate_id("MRTMTT25D09F205Z"), true); [INFO] [stdout] 201 + assert!(validator.validate_id("MRTMTT25D09F205Z")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/italy.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 202 | assert_eq!(validator.validate_id("MLLSNT82P65Z404U"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 202 - assert_eq!(validator.validate_id("MLLSNT82P65Z404U"), true); [INFO] [stdout] 202 + assert!(validator.validate_id("MLLSNT82P65Z404U")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/italy.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 203 | assert_eq!(validator.validate_id("DLMCTG75B07H227Y"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 203 - assert_eq!(validator.validate_id("DLMCTG75B07H227Y"), true); [INFO] [stdout] 203 + assert!(validator.validate_id("DLMCTG75B07H227Y")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/italy.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | assert_eq!(validator.validate_id("BRSLSE08D50H987B"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 204 - assert_eq!(validator.validate_id("BRSLSE08D50H987B"), true); [INFO] [stdout] 204 + assert!(validator.validate_id("BRSLSE08D50H987B")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/italy.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 205 | assert_eq!(validator.validate_id("MRCDRA01A13A065E"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 205 - assert_eq!(validator.validate_id("MRCDRA01A13A065E"), true); [INFO] [stdout] 205 + assert!(validator.validate_id("MRCDRA01A13A065E")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/italy.rs:211:9 [INFO] [stdout] | [INFO] [stdout] 211 | / assert_eq!( [INFO] [stdout] 212 | | validator.extract_citizen("ARLSNT66P65Z404R 01").is_none(), [INFO] [stdout] 213 | | true [INFO] [stdout] 214 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 211 ~ assert!( [INFO] [stdout] 212 ~ validator.extract_citizen("ARLSNT66P65Z404R 01").is_none() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/luxembourg.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | return algorithms::validate_verhoeff(&standard_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return algorithms::validate_verhoeff(&standard_id); [INFO] [stdout] 24 + algorithms::validate_verhoeff(&standard_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/luxembourg.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | return crate::country::Code::LU; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return crate::country::Code::LU; [INFO] [stdout] 28 + crate::country::Code::LU [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/luxembourg.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return None; [INFO] [stdout] 32 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/luxembourg.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 43 - assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] 43 + assert!(!validator.validate_id("123")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/luxembourg.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | assert_eq!(false, validator.validate_id("123-456-7")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 44 - assert_eq!(false, validator.validate_id("123-456-7")); [INFO] [stdout] 44 + assert!(!validator.validate_id("123-456-7")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/luxembourg.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | assert_eq!(validator.validate_id("1994789587182"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 50 - assert_eq!(validator.validate_id("1994789587182"), false); [INFO] [stdout] 50 + assert!(!validator.validate_id("1994789587182")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/luxembourg.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | assert_eq!(validator.validate_id("5971654782313"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 51 - assert_eq!(validator.validate_id("5971654782313"), false); [INFO] [stdout] 51 + assert!(!validator.validate_id("5971654782313")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/luxembourg.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | assert_eq!(validator.validate_id("2055101054879"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 52 - assert_eq!(validator.validate_id("2055101054879"), false); [INFO] [stdout] 52 + assert!(!validator.validate_id("2055101054879")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/luxembourg.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | assert_eq!(validator.validate_id("1997053045687"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 53 - assert_eq!(validator.validate_id("1997053045687"), false); [INFO] [stdout] 53 + assert!(!validator.validate_id("1997053045687")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/luxembourg.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | assert_eq!(validator.validate_id("1983081246783"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 59 - assert_eq!(validator.validate_id("1983081246783"), true); [INFO] [stdout] 59 + assert!(validator.validate_id("1983081246783")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/luxembourg.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | assert_eq!(validator.validate_id("2003042581931"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 60 - assert_eq!(validator.validate_id("2003042581931"), true); [INFO] [stdout] 60 + assert!(validator.validate_id("2003042581931")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/luxembourg.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | assert_eq!(validator.validate_id("1971110258746"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 61 - assert_eq!(validator.validate_id("1971110258746"), true); [INFO] [stdout] 61 + assert!(validator.validate_id("1971110258746")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/luxembourg.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | assert_eq!(validator.validate_id("2012051469336"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 62 - assert_eq!(validator.validate_id("2012051469336"), true); [INFO] [stdout] 62 + assert!(validator.validate_id("2012051469336")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/luxembourg.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | assert_eq!(validator.validate_id("1994092874551"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 63 - assert_eq!(validator.validate_id("1994092874551"), true); [INFO] [stdout] 63 + assert!(validator.validate_id("1994092874551")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/validator/mexico.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | !check_digit.is_err() && check_digit.unwrap() == ((10 - (sum % 10)) % 10) as u32 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `check_digit.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/validator/mexico.rs:64:37 [INFO] [stdout] | [INFO] [stdout] 64 | if (year_of_birth > 2000 && assigned_digit.is_digit(10)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `assigned_digit.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | assert_eq!(false, validator.validate_id("")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 158 - assert_eq!(false, validator.validate_id("")); [INFO] [stdout] 158 + assert!(!validator.validate_id("")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | assert_eq!(false, validator.validate_id("1234567890123456789")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 159 - assert_eq!(false, validator.validate_id("1234567890123456789")); [INFO] [stdout] 159 + assert!(!validator.validate_id("1234567890123456789")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | assert_eq!(false, validator.validate_id("12345678901234567")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 160 - assert_eq!(false, validator.validate_id("12345678901234567")); [INFO] [stdout] 160 + assert!(!validator.validate_id("12345678901234567")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | assert_eq!(false, validator.validate_id("0000101109MHGNMN01")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 166 - assert_eq!(false, validator.validate_id("0000101109MHGNMN01")); [INFO] [stdout] 166 + assert!(!validator.validate_id("0000101109MHGNMN01")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | assert_eq!(false, validator.validate_id("JOIMAAAAAAHHGSMN08")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 172 - assert_eq!(false, validator.validate_id("JOIMAAAAAAHHGSMN08")); [INFO] [stdout] 172 + assert!(!validator.validate_id("JOIMAAAAAAHHGSMN08")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | assert_eq!(false, validator.validate_id("AAIM901312MBCNMN08")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 173 - assert_eq!(false, validator.validate_id("AAIM901312MBCNMN08")); [INFO] [stdout] 173 + assert!(!validator.validate_id("AAIM901312MBCNMN08")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | assert_eq!(false, validator.validate_id("AAIM901131MBCNMN08")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 174 - assert_eq!(false, validator.validate_id("AAIM901131MBCNMN08")); [INFO] [stdout] 174 + assert!(!validator.validate_id("AAIM901131MBCNMN08")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | assert_eq!(false, validator.validate_id("AAIM901232MBCNMN08")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 175 - assert_eq!(false, validator.validate_id("AAIM901232MBCNMN08")); [INFO] [stdout] 175 + assert!(!validator.validate_id("AAIM901232MBCNMN08")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | assert_eq!(false, validator.validate_id("AAIM010229MBCNMN08")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 176 - assert_eq!(false, validator.validate_id("AAIM010229MBCNMN08")); [INFO] [stdout] 176 + assert!(!validator.validate_id("AAIM010229MBCNMN08")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:182:9 [INFO] [stdout] | [INFO] [stdout] 182 | assert_eq!(false, validator.validate_id("AAIM901112VBCNMN08")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 182 - assert_eq!(false, validator.validate_id("AAIM901112VBCNMN08")); [INFO] [stdout] 182 + assert!(!validator.validate_id("AAIM901112VBCNMN08")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 188 | assert_eq!(false, validator.validate_id("AAIM901112H99NMN08")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 188 - assert_eq!(false, validator.validate_id("AAIM901112H99NMN08")); [INFO] [stdout] 188 + assert!(!validator.validate_id("AAIM901112H99NMN08")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:194:9 [INFO] [stdout] | [INFO] [stdout] 194 | assert_eq!(false, validator.validate_id("AAIT101109MVZ11101")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 194 - assert_eq!(false, validator.validate_id("AAIT101109MVZ11101")); [INFO] [stdout] 194 + assert!(!validator.validate_id("AAIT101109MVZ11101")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:200:9 [INFO] [stdout] | [INFO] [stdout] 200 | assert_eq!(false, validator.validate_id("HEGG560427MVZRRLA4")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 200 - assert_eq!(false, validator.validate_id("HEGG560427MVZRRLA4")); [INFO] [stdout] 200 + assert!(!validator.validate_id("HEGG560427MVZRRLA4")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 201 | assert_eq!(false, validator.validate_id("HEGG040427MVZRRL04")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 201 - assert_eq!(false, validator.validate_id("HEGG040427MVZRRL04")); [INFO] [stdout] 201 + assert!(!validator.validate_id("HEGG040427MVZRRL04")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | assert_eq!(false, validator.validate_id("BUEI150102HAAAAAC1")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 207 - assert_eq!(false, validator.validate_id("BUEI150102HAAAAAC1")); [INFO] [stdout] 207 + assert!(!validator.validate_id("BUEI150102HAAAAAC1")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | assert_eq!(false, validator.validate_id("KAGO010101XAAAAAD1")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 208 - assert_eq!(false, validator.validate_id("KAGO010101XAAAAAD1")); [INFO] [stdout] 208 + assert!(!validator.validate_id("KAGO010101XAAAAAD1")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | assert_eq!(false, validator.validate_id("PEDA560102MAAAAA01")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 209 - assert_eq!(false, validator.validate_id("PEDA560102MAAAAA01")); [INFO] [stdout] 209 + assert!(!validator.validate_id("PEDA560102MAAAAA01")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 210 | assert_eq!(false, validator.validate_id("RATA001001HAAAAA21")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 210 - assert_eq!(false, validator.validate_id("RATA001001HAAAAA21")); [INFO] [stdout] 210 + assert!(!validator.validate_id("RATA001001HAAAAA21")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 216 | assert_eq!(false, validator.validate_id("BMHM260906HCHQAN04")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 216 - assert_eq!(false, validator.validate_id("BMHM260906HCHQAN04")); [INFO] [stdout] 216 + assert!(!validator.validate_id("BMHM260906HCHQAN04")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | assert_eq!(true, validator.validate_id(" AAIM901112MBCNMN08 ")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 222 - assert_eq!(true, validator.validate_id(" AAIM901112MBCNMN08 ")); [INFO] [stdout] 222 + assert!(validator.validate_id(" AAIM901112MBCNMN08 ")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | assert_eq!(true, validator.validate_id("JOIM890106HHGSMN08")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 223 - assert_eq!(true, validator.validate_id("JOIM890106HHGSMN08")); [INFO] [stdout] 223 + assert!(validator.validate_id("JOIM890106HHGSMN08")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:224:9 [INFO] [stdout] | [INFO] [stdout] 224 | assert_eq!(true, validator.validate_id("JOTA950616HBCSWS03")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 224 - assert_eq!(true, validator.validate_id("JOTA950616HBCSWS03")); [INFO] [stdout] 224 + assert!(validator.validate_id("JOTA950616HBCSWS03")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | assert_eq!(true, citizen.is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 231 - assert_eq!(true, citizen.is_some()); [INFO] [stdout] 231 + assert!(citizen.is_some()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 240 | assert_eq!(true, citizen.is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 240 - assert_eq!(true, citizen.is_some()); [INFO] [stdout] 240 + assert!(citizen.is_some()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/mexico.rs:249:9 [INFO] [stdout] | [INFO] [stdout] 249 | assert_eq!(true, citizen.is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 249 - assert_eq!(true, citizen.is_some()); [INFO] [stdout] 249 + assert!(citizen.is_some()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/portugal.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return (sum % 10) == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return (sum % 10) == 0; [INFO] [stdout] 39 + (sum % 10) == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/validator/portugal.rs:39:16 [INFO] [stdout] | [INFO] [stdout] 39 | return (sum % 10) == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace with: `sum.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/portugal.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | return crate::country::Code::PT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return crate::country::Code::PT; [INFO] [stdout] 43 + crate::country::Code::PT [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/portugal.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return None; [INFO] [stdout] 47 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/portugal.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 58 - assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] 58 + assert!(!validator.validate_id("123")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/portugal.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | assert_eq!(false, validator.validate_id("123 456 789 0")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 59 - assert_eq!(false, validator.validate_id("123 456 789 0")); [INFO] [stdout] 59 + assert!(!validator.validate_id("123 456 789 0")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/portugal.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | assert_eq!(validator.validate_id("14897475 4 ZY5"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 65 - assert_eq!(validator.validate_id("14897475 4 ZY5"), false); [INFO] [stdout] 65 + assert!(!validator.validate_id("14897475 4 ZY5")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/portugal.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | assert_eq!(validator.validate_id("11084129 8 ZX8"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 71 - assert_eq!(validator.validate_id("11084129 8 ZX8"), true); [INFO] [stdout] 71 + assert!(validator.validate_id("11084129 8 ZX8")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/portugal.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | assert_eq!(validator.validate_id("154203556ZX9"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 72 - assert_eq!(validator.validate_id("154203556ZX9"), true); [INFO] [stdout] 72 + assert!(validator.validate_id("154203556ZX9")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/portugal.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | assert_eq!(validator.validate_id("17653917 4ZZ5"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 73 - assert_eq!(validator.validate_id("17653917 4ZZ5"), true); [INFO] [stdout] 73 + assert!(validator.validate_id("17653917 4ZZ5")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/portugal.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | assert_eq!(validator.validate_id("174886721 ZX1"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 74 - assert_eq!(validator.validate_id("174886721 ZX1"), true); [INFO] [stdout] 74 + assert!(validator.validate_id("174886721 ZX1")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/portugal.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | assert_eq!(validator.validate_id("14898475 4 ZY5"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 75 - assert_eq!(validator.validate_id("14898475 4 ZY5"), true); [INFO] [stdout] 75 + assert!(validator.validate_id("14898475 4 ZY5")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/portugal.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | assert_eq!(validator.extract_citizen("11084129 8 ZX8").is_none(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 81 - assert_eq!(validator.extract_citizen("11084129 8 ZX8").is_none(), true); [INFO] [stdout] 81 + assert!(validator.extract_citizen("11084129 8 ZX8").is_none()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/spain.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return validation == control; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return validation == control; [INFO] [stdout] 32 + validation == control [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/spain.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | return crate::country::Code::ES; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return crate::country::Code::ES; [INFO] [stdout] 36 + crate::country::Code::ES [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/spain.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return None; [INFO] [stdout] 40 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/spain.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 51 - assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] 51 + assert!(!validator.validate_id("123")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/spain.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | assert_eq!(false, validator.validate_id("123-456-7")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 52 - assert_eq!(false, validator.validate_id("123-456-7")); [INFO] [stdout] 52 + assert!(!validator.validate_id("123-456-7")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/spain.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | assert_eq!(validator.validate_id("05756786M"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 58 - assert_eq!(validator.validate_id("05756786M"), false); [INFO] [stdout] 58 + assert!(!validator.validate_id("05756786M")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/spain.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | assert_eq!(validator.validate_id("84345642L"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 64 - assert_eq!(validator.validate_id("84345642L"), true); [INFO] [stdout] 64 + assert!(validator.validate_id("84345642L")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/spain.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | assert_eq!(validator.validate_id("Y3338121F"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 65 - assert_eq!(validator.validate_id("Y3338121F"), true); [INFO] [stdout] 65 + assert!(validator.validate_id("Y3338121F")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/spain.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | assert_eq!(validator.validate_id("40298386V"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 66 - assert_eq!(validator.validate_id("40298386V"), true); [INFO] [stdout] 66 + assert!(validator.validate_id("40298386V")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/spain.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | assert_eq!(validator.validate_id("Y0597591L"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 67 - assert_eq!(validator.validate_id("Y0597591L"), true); [INFO] [stdout] 67 + assert!(validator.validate_id("Y0597591L")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/spain.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | assert_eq!(validator.validate_id("09730915Y"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 68 - assert_eq!(validator.validate_id("09730915Y"), true); [INFO] [stdout] 68 + assert!(validator.validate_id("09730915Y")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/usa.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return true; [INFO] [stdout] 44 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/validator/usa.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 36 | if &standard_id[3..5].parse::().unwrap() == &0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 36 - if &standard_id[3..5].parse::().unwrap() == &0 { [INFO] [stdout] 36 + if standard_id[3..5].parse::().unwrap() == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/validator/usa.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | if &standard_id[5..].parse::().unwrap() == &0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 40 - if &standard_id[5..].parse::().unwrap() == &0 { [INFO] [stdout] 40 + if standard_id[5..].parse::().unwrap() == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/usa.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return crate::country::Code::US; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return crate::country::Code::US; [INFO] [stdout] 48 + crate::country::Code::US [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validator/usa.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return None; [INFO] [stdout] 52 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/usa.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 63 - assert_eq!(false, validator.validate_id("123")); [INFO] [stdout] 63 + assert!(!validator.validate_id("123")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/usa.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | assert_eq!(false, validator.validate_id("123-456-7")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 64 - assert_eq!(false, validator.validate_id("123-456-7")); [INFO] [stdout] 64 + assert!(!validator.validate_id("123-456-7")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/usa.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | assert_eq!(validator.validate_id("078-05-1120"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 70 - assert_eq!(validator.validate_id("078-05-1120"), false); [INFO] [stdout] 70 + assert!(!validator.validate_id("078-05-1120")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/usa.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | assert_eq!(validator.validate_id("219-09-9999"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 71 - assert_eq!(validator.validate_id("219-09-9999"), false); [INFO] [stdout] 71 + assert!(!validator.validate_id("219-09-9999")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/usa.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | assert_eq!(validator.validate_id("457-55-5462"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 72 - assert_eq!(validator.validate_id("457-55-5462"), false); [INFO] [stdout] 72 + assert!(!validator.validate_id("457-55-5462")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/usa.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | assert_eq!(validator.validate_id("666-91-8271"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 73 - assert_eq!(validator.validate_id("666-91-8271"), false); [INFO] [stdout] 73 + assert!(!validator.validate_id("666-91-8271")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/usa.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | assert_eq!(validator.validate_id("167-38-1265"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 79 - assert_eq!(validator.validate_id("167-38-1265"), true); [INFO] [stdout] 79 + assert!(validator.validate_id("167-38-1265")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/usa.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | assert_eq!(validator.validate_id("536-22-8726"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 80 - assert_eq!(validator.validate_id("536-22-8726"), true); [INFO] [stdout] 80 + assert!(validator.validate_id("536-22-8726")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/usa.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | assert_eq!(validator.validate_id("536-22-5232"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 81 - assert_eq!(validator.validate_id("536-22-5232"), true); [INFO] [stdout] 81 + assert!(validator.validate_id("536-22-5232")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/usa.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | assert_eq!(validator.validate_id("574-22-7664"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 82 - assert_eq!(validator.validate_id("574-22-7664"), true); [INFO] [stdout] 82 + assert!(validator.validate_id("574-22-7664")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/validator/usa.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | assert_eq!(validator.validate_id("671-26-9121"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 83 - assert_eq!(validator.validate_id("671-26-9121"), true); [INFO] [stdout] 83 + assert!(validator.validate_id("671-26-9121")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | return country_validator.validate_id(id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return country_validator.validate_id(id); [INFO] [stdout] 15 + country_validator.validate_id(id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | return country_validator.extract_citizen(id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return country_validator.extract_citizen(id); [INFO] [stdout] 20 + country_validator.extract_citizen(id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/lib.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / if generator.is_none() { [INFO] [stdout] 26 | | return None; [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ help: replace it with: `generator.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/validator/germany.rs:33:28 [INFO] [stdout] | [INFO] [stdout] 33 | let mut repeated = vec![0; 10]; [INFO] [stdout] | ^^^^^^^^^^^ help: you can use an array directly: `[0; 10]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.12s [INFO] running `Command { std: "docker" "inspect" "4ce014fa3c46206e6983942add0c3f524a1ed76e6b3e34a5182f77ef8a86eb68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ce014fa3c46206e6983942add0c3f524a1ed76e6b3e34a5182f77ef8a86eb68", kill_on_drop: false }` [INFO] [stdout] 4ce014fa3c46206e6983942add0c3f524a1ed76e6b3e34a5182f77ef8a86eb68