[INFO] fetching crate so-models 0.3.0... [INFO] linting so-models-0.3.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate so-models 0.3.0 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate so-models 0.3.0 [INFO] finished tweaking crates.io crate so-models 0.3.0 [INFO] tweaked toml for crates.io crate so-models 0.3.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate so-models 0.3.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate so-models 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded so-core v0.3.0 [INFO] [stderr] Downloaded atomic-wait v1.1.0 [INFO] [stderr] Downloaded spindle v0.2.6 [INFO] [stderr] Downloaded so-stats v0.3.0 [INFO] [stderr] Downloaded equator v0.2.2 [INFO] [stderr] Downloaded qd v0.7.7 [INFO] [stderr] Downloaded faer-traits v0.23.2 [INFO] [stderr] Downloaded generativity v1.1.0 [INFO] [stderr] Downloaded so-linalg v0.3.0 [INFO] [stderr] Downloaded nano-gemm v0.1.3 [INFO] [stderr] Downloaded private-gemm-x86 v0.1.20 [INFO] [stderr] Downloaded zerocopy-derive v0.8.32 [INFO] [stderr] Downloaded py_literal v0.4.0 [INFO] [stderr] Downloaded statrs v0.17.1 [INFO] [stderr] Downloaded faer-macros v0.22.1 [INFO] [stderr] Downloaded nano-gemm-c32 v0.1.0 [INFO] [stderr] Downloaded nano-gemm-codegen v0.1.0 [INFO] [stderr] Downloaded nano-gemm-core v0.1.0 [INFO] [stderr] Downloaded npyz v0.8.4 [INFO] [stderr] Downloaded zerocopy v0.8.32 [INFO] [stderr] Downloaded defer v0.2.1 [INFO] [stderr] Downloaded ndarray v0.17.1 [INFO] [stderr] Downloaded interpol v0.2.1 [INFO] [stderr] Downloaded equator-macro v0.2.1 [INFO] [stderr] Downloaded nano-gemm-c64 v0.1.0 [INFO] [stderr] Downloaded nano-gemm-f32 v0.1.0 [INFO] [stderr] Downloaded nano-gemm-f64 v0.1.0 [INFO] [stderr] Downloaded faer v0.23.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 50d1cd513762cfdb6f1e5693fef1a44739760f9e5ff0ab9de1d6e181d7bb98c2 [INFO] running `Command { std: "docker" "start" "-a" "50d1cd513762cfdb6f1e5693fef1a44739760f9e5ff0ab9de1d6e181d7bb98c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "50d1cd513762cfdb6f1e5693fef1a44739760f9e5ff0ab9de1d6e181d7bb98c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "50d1cd513762cfdb6f1e5693fef1a44739760f9e5ff0ab9de1d6e181d7bb98c2", kill_on_drop: false }` [INFO] [stdout] 50d1cd513762cfdb6f1e5693fef1a44739760f9e5ff0ab9de1d6e181d7bb98c2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 43298272b90d764cc58d4740de49ba50b398889d13fffb980944a07bab2cb586 [INFO] running `Command { std: "docker" "start" "-a" "43298272b90d764cc58d4740de49ba50b398889d13fffb980944a07bab2cb586", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.179 [INFO] [stderr] Compiling proc-macro2 v1.0.105 [INFO] [stderr] Compiling zerocopy v0.8.32 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Compiling nano-gemm-codegen v0.1.0 [INFO] [stderr] Checking reborrow v0.5.5 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling quote v1.0.43 [INFO] [stderr] Compiling pulp v0.21.5 [INFO] [stderr] Compiling dyn-stack-macros v0.1.3 [INFO] [stderr] Checking raw-cpuid v11.6.0 [INFO] [stderr] Compiling seq-macro v0.3.6 [INFO] [stderr] Compiling pest v2.8.5 [INFO] [stderr] Checking nano-gemm-core v0.1.0 [INFO] [stderr] Compiling matrixmultiply v0.3.10 [INFO] [stderr] Compiling defer v0.2.1 [INFO] [stderr] Checking generativity v1.1.0 [INFO] [stderr] Compiling zmij v1.0.12 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking safe_arch v0.7.4 [INFO] [stderr] Checking indexmap v2.12.1 [INFO] [stderr] Checking dyn-stack v0.13.2 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking wide v0.7.33 [INFO] [stderr] Compiling nano-gemm-c32 v0.1.0 [INFO] [stderr] Compiling nano-gemm-f64 v0.1.0 [INFO] [stderr] Compiling nano-gemm-c64 v0.1.0 [INFO] [stderr] Compiling nano-gemm-f32 v0.1.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Compiling syn v2.0.113 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking atomic-wait v1.1.0 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Compiling pest_meta v2.8.5 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking rand_distr v0.5.1 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking simba v0.8.1 [INFO] [stderr] Compiling interpol v0.2.1 [INFO] [stderr] Compiling private-gemm-x86 v0.1.20 [INFO] [stderr] Compiling pest_generator v2.8.5 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Compiling equator-macro v0.2.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling faer-macros v0.22.1 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling nalgebra-macros v0.2.2 [INFO] [stderr] Compiling pest_derive v2.8.5 [INFO] [stderr] Checking py_literal v0.4.0 [INFO] [stderr] Checking equator v0.2.2 [INFO] [stderr] Checking npyz v0.8.4 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Checking gemm-common v0.18.2 [INFO] [stderr] Checking qd v0.7.7 [INFO] [stderr] Checking spindle v0.2.6 [INFO] [stderr] Checking faer-traits v0.23.2 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking gemm-f64 v0.18.2 [INFO] [stderr] Checking gemm-c64 v0.18.2 [INFO] [stderr] Checking gemm-c32 v0.18.2 [INFO] [stderr] Checking gemm-f32 v0.18.2 [INFO] [stderr] Checking gemm v0.18.2 [INFO] [stderr] Checking nalgebra v0.32.6 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking ndarray v0.17.1 [INFO] [stderr] Checking nano-gemm v0.1.3 [INFO] [stderr] Checking faer v0.23.2 [INFO] [stderr] Checking statrs v0.17.1 [INFO] [stderr] Checking so-core v0.3.0 [INFO] [stderr] Checking so-linalg v0.3.0 [INFO] [stderr] Checking so-stats v0.3.0 [INFO] [stderr] Checking so-models v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Array2` [INFO] [stdout] --> src/robust.rs:637:34 [INFO] [stdout] | [INFO] [stdout] 637 | use ndarray::{array, Array1, Array2}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/glm/family.rs:90:35 [INFO] [stdout] | [INFO] [stdout] 90 | let clipped = y_val.max(0.0001).min(0.9999); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `y_val.clamp(0.0001, 0.9999)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/glm/model.rs:138:5 [INFO] [stdout] | [INFO] [stdout] 138 | / pub fn new() -> GLMModelBuilder { [INFO] [stdout] 139 | | GLMModelBuilder::new() [INFO] [stdout] 140 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/glm/family.rs:90:35 [INFO] [stdout] | [INFO] [stdout] 90 | let clipped = y_val.max(0.0001).min(0.9999); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `y_val.clamp(0.0001, 0.9999)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/glm/model.rs:138:5 [INFO] [stdout] | [INFO] [stdout] 138 | / pub fn new() -> GLMModelBuilder { [INFO] [stdout] 139 | | GLMModelBuilder::new() [INFO] [stdout] 140 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `KernelRegression` [INFO] [stdout] --> src/nonparametric.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 151 | / pub fn new() -> Self { [INFO] [stdout] 152 | | Self { [INFO] [stdout] 153 | | kernel: Kernel::Gaussian, [INFO] [stdout] 154 | | bandwidth: None, [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 149 + impl Default for KernelRegression { [INFO] [stdout] 150 + fn default() -> Self { [INFO] [stdout] 151 + Self::new() [INFO] [stdout] 152 + } [INFO] [stdout] 153 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/nonparametric.rs:953:17 [INFO] [stdout] | [INFO] [stdout] 953 | assert!(results.coefficients.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!results.coefficients.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `KernelRegression` [INFO] [stdout] --> src/nonparametric.rs:151:5 [INFO] [stdout] | [INFO] [stdout] 151 | / pub fn new() -> Self { [INFO] [stdout] 152 | | Self { [INFO] [stdout] 153 | | kernel: Kernel::Gaussian, [INFO] [stdout] 154 | | bandwidth: None, [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 149 + impl Default for KernelRegression { [INFO] [stdout] 150 + fn default() -> Self { [INFO] [stdout] 151 + Self::new() [INFO] [stdout] 152 + } [INFO] [stdout] 153 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `OLS` [INFO] [stdout] --> src/regression/linear.rs:146:5 [INFO] [stdout] | [INFO] [stdout] 146 | / pub fn new() -> Self { [INFO] [stdout] 147 | | Self { intercept: true } [INFO] [stdout] 148 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 144 + impl Default for OLS { [INFO] [stdout] 145 + fn default() -> Self { [INFO] [stdout] 146 + Self::new() [INFO] [stdout] 147 + } [INFO] [stdout] 148 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/regression/linear.rs:298:10 [INFO] [stdout] | [INFO] [stdout] 298 | ) -> ( [INFO] [stdout] | __________^ [INFO] [stdout] 299 | | Option>, [INFO] [stdout] 300 | | Option>, [INFO] [stdout] 301 | | Option>, [INFO] [stdout] 302 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `OLS` [INFO] [stdout] --> src/regression/linear.rs:146:5 [INFO] [stdout] | [INFO] [stdout] 146 | / pub fn new() -> Self { [INFO] [stdout] 147 | | Self { intercept: true } [INFO] [stdout] 148 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 144 + impl Default for OLS { [INFO] [stdout] 145 + fn default() -> Self { [INFO] [stdout] 146 + Self::new() [INFO] [stdout] 147 + } [INFO] [stdout] 148 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/regression/linear.rs:298:10 [INFO] [stdout] | [INFO] [stdout] 298 | ) -> ( [INFO] [stdout] | __________^ [INFO] [stdout] 299 | | Option>, [INFO] [stdout] 300 | | Option>, [INFO] [stdout] 301 | | Option>, [INFO] [stdout] 302 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MMEstimator` [INFO] [stdout] --> src/robust.rs:608:5 [INFO] [stdout] | [INFO] [stdout] 608 | / pub fn new() -> Self { [INFO] [stdout] 609 | | Self { [INFO] [stdout] 610 | | s_estimator: SEstimator::default(), [INFO] [stdout] 611 | | m_estimator: MEstimator::tukey(4.685), [INFO] [stdout] 612 | | } [INFO] [stdout] 613 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 606 + impl Default for MMEstimator { [INFO] [stdout] 607 + fn default() -> Self { [INFO] [stdout] 608 + Self::new() [INFO] [stdout] 609 + } [INFO] [stdout] 610 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MMEstimator` [INFO] [stdout] --> src/robust.rs:608:5 [INFO] [stdout] | [INFO] [stdout] 608 | / pub fn new() -> Self { [INFO] [stdout] 609 | | Self { [INFO] [stdout] 610 | | s_estimator: SEstimator::default(), [INFO] [stdout] 611 | | m_estimator: MEstimator::tukey(4.685), [INFO] [stdout] 612 | | } [INFO] [stdout] 613 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 606 + impl Default for MMEstimator { [INFO] [stdout] 607 + fn default() -> Self { [INFO] [stdout] 608 + Self::new() [INFO] [stdout] 609 + } [INFO] [stdout] 610 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 22s [INFO] running `Command { std: "docker" "inspect" "43298272b90d764cc58d4740de49ba50b398889d13fffb980944a07bab2cb586", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "43298272b90d764cc58d4740de49ba50b398889d13fffb980944a07bab2cb586", kill_on_drop: false }` [INFO] [stdout] 43298272b90d764cc58d4740de49ba50b398889d13fffb980944a07bab2cb586