[INFO] fetching crate sixth_database 1.0.10... [INFO] linting sixth_database-1.0.10 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate sixth_database 1.0.10 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate sixth_database 1.0.10 [INFO] finished tweaking crates.io crate sixth_database 1.0.10 [INFO] tweaked toml for crates.io crate sixth_database 1.0.10 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate sixth_database 1.0.10 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 8 packages to latest compatible versions [INFO] [stderr] Adding bincode v1.3.3 (available: v3.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `edition` is set on library `sixth_database` which is deprecated [INFO] [stderr] warning: unused manifest key: lib.plugin [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 556c0476fcc645dcd95c4d0b22a88c6c3d52318d7ec00c8a75c8658b6c12822e [INFO] running `Command { std: "docker" "start" "-a" "556c0476fcc645dcd95c4d0b22a88c6c3d52318d7ec00c8a75c8658b6c12822e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "556c0476fcc645dcd95c4d0b22a88c6c3d52318d7ec00c8a75c8658b6c12822e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "556c0476fcc645dcd95c4d0b22a88c6c3d52318d7ec00c8a75c8658b6c12822e", kill_on_drop: false }` [INFO] [stdout] 556c0476fcc645dcd95c4d0b22a88c6c3d52318d7ec00c8a75c8658b6c12822e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d19451a5365b7f267afbdab27d39ad2eb384d2879b9c14314a7e117beeeda6d0 [INFO] running `Command { std: "docker" "start" "-a" "d19451a5365b7f267afbdab27d39ad2eb384d2879b9c14314a7e117beeeda6d0", kill_on_drop: false }` [INFO] [stderr] warning: `edition` is set on library `sixth_database` which is deprecated [INFO] [stderr] warning: unused manifest key: lib.plugin [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Checking serde_core v1.0.228 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking sixth_database v1.0.10 (/opt/rustwide/workdir) [INFO] [stdout] warning: called `unwrap` on `result_of_bincode` after checking its variant with `is_ok` [INFO] [stdout] --> lib.rs:29:28 [INFO] [stdout] | [INFO] [stdout] 28 | if result_of_bincode.is_ok() { [INFO] [stdout] | ---------------------------- help: try: `if let Ok() = result_of_bincode` [INFO] [stdout] 29 | return result_of_bincode.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result_of_bincode` after checking its variant with `is_ok` [INFO] [stdout] --> lib.rs:44:24 [INFO] [stdout] | [INFO] [stdout] 43 | if result_of_bincode.is_ok() { [INFO] [stdout] | ---------------------------- help: try: `if let Ok() = result_of_bincode` [INFO] [stdout] 44 | return result_of_bincode.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> lib.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 62 | if !std::fs::read_dir("./SixthDatabase/").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::read_dir("./SixthDatabase/").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> lib.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | / if !master_file.exists() { [INFO] [stdout] 62 | | if !std::fs::read_dir("./SixthDatabase/").is_ok() { [INFO] [stdout] 63 | | std::fs::create_dir("./SixthDatabase/") [INFO] [stdout] 64 | | .expect("Could not create SixthDatabase directory"); [INFO] [stdout] 65 | | } [INFO] [stdout] 66 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 61 ~ if !master_file.exists() [INFO] [stdout] 62 ~ && !std::fs::read_dir("./SixthDatabase/").is_ok() { [INFO] [stdout] 63 | std::fs::create_dir("./SixthDatabase/") [INFO] [stdout] 64 | .expect("Could not create SixthDatabase directory"); [INFO] [stdout] 65 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> lib.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | return hasher.finish(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return hasher.finish(); [INFO] [stdout] 89 + hasher.finish() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> lib.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | return object.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return object.clone(); [INFO] [stdout] 157 + object.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result_of_bincode` after checking its variant with `is_ok` [INFO] [stdout] --> lib.rs:29:28 [INFO] [stdout] | [INFO] [stdout] 28 | if result_of_bincode.is_ok() { [INFO] [stdout] | ---------------------------- help: try: `if let Ok() = result_of_bincode` [INFO] [stdout] 29 | return result_of_bincode.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result_of_bincode` after checking its variant with `is_ok` [INFO] [stdout] --> lib.rs:44:24 [INFO] [stdout] | [INFO] [stdout] 43 | if result_of_bincode.is_ok() { [INFO] [stdout] | ---------------------------- help: try: `if let Ok() = result_of_bincode` [INFO] [stdout] 44 | return result_of_bincode.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> lib.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 62 | if !std::fs::read_dir("./SixthDatabase/").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::read_dir("./SixthDatabase/").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> lib.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | / if !master_file.exists() { [INFO] [stdout] 62 | | if !std::fs::read_dir("./SixthDatabase/").is_ok() { [INFO] [stdout] 63 | | std::fs::create_dir("./SixthDatabase/") [INFO] [stdout] 64 | | .expect("Could not create SixthDatabase directory"); [INFO] [stdout] 65 | | } [INFO] [stdout] 66 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 61 ~ if !master_file.exists() [INFO] [stdout] 62 ~ && !std::fs::read_dir("./SixthDatabase/").is_ok() { [INFO] [stdout] 63 | std::fs::create_dir("./SixthDatabase/") [INFO] [stdout] 64 | .expect("Could not create SixthDatabase directory"); [INFO] [stdout] 65 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> lib.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | return hasher.finish(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return hasher.finish(); [INFO] [stdout] 89 + hasher.finish() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> lib.rs:157:9 [INFO] [stdout] | [INFO] [stdout] 157 | return object.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 157 - return object.clone(); [INFO] [stdout] 157 + object.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.21s [INFO] running `Command { std: "docker" "inspect" "d19451a5365b7f267afbdab27d39ad2eb384d2879b9c14314a7e117beeeda6d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d19451a5365b7f267afbdab27d39ad2eb384d2879b9c14314a7e117beeeda6d0", kill_on_drop: false }` [INFO] [stdout] d19451a5365b7f267afbdab27d39ad2eb384d2879b9c14314a7e117beeeda6d0