[INFO] fetching crate simple-irc 0.3.2... [INFO] linting simple-irc-0.3.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate simple-irc 0.3.2 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate simple-irc 0.3.2 [INFO] finished tweaking crates.io crate simple-irc 0.3.2 [INFO] tweaked toml for crates.io crate simple-irc 0.3.2 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate simple-irc 0.3.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 17 packages to latest compatible versions [INFO] [stderr] Adding serde_yaml v0.8.26 (available: v0.9.34+deprecated) [INFO] [stderr] Adding thiserror v1.0.69 (available: v2.0.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ac0439248b76194ac65d7a02b822fc77e8702b9f31bffab3b28d38869c8bb74f [INFO] running `Command { std: "docker" "start" "-a" "ac0439248b76194ac65d7a02b822fc77e8702b9f31bffab3b28d38869c8bb74f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ac0439248b76194ac65d7a02b822fc77e8702b9f31bffab3b28d38869c8bb74f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac0439248b76194ac65d7a02b822fc77e8702b9f31bffab3b28d38869c8bb74f", kill_on_drop: false }` [INFO] [stdout] ac0439248b76194ac65d7a02b822fc77e8702b9f31bffab3b28d38869c8bb74f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5e8e81212f352c9696951283bfbfcb377131ed663b9c96b1fdbf36cd1df130ca [INFO] running `Command { std: "docker" "start" "-a" "5e8e81212f352c9696951283bfbfcb377131ed663b9c96b1fdbf36cd1df130ca", kill_on_drop: false }` [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking simple-irc v0.3.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/escaped.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | / /// information. [INFO] [stdout] 7 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 11 | pub(crate) fn escape_char(c: char) -> Option<&'static str> { [INFO] [stdout] | ------------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! This file implements helpers for tag escaping and unescaping. Each function [INFO] [stdout] 2 ~ //! lists all the possible escape characters, even if the fallback would be [INFO] [stdout] 3 ~ //! valid. [INFO] [stdout] 4 ~ //! [INFO] [stdout] 5 ~ //! See https://ircv3.net/specs/extensions/message-tags.html for more [INFO] [stdout] 6 ~ //! information. [INFO] [stdout] | [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 7 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/message.rs:58:40 [INFO] [stdout] | [INFO] [stdout] 58 | user: user.and_then(|s| if s == "" { None } else { Some(s.to_string()) }), [INFO] [stdout] | ^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/message.rs:59:40 [INFO] [stdout] | [INFO] [stdout] 59 | host: host.and_then(|s| if s == "" { None } else { Some(s.to_string()) }), [INFO] [stdout] | ^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/message.rs:189:29 [INFO] [stdout] | [INFO] [stdout] 189 | let mut parts = (&input[1..]).splitn(2, ' '); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `input[1..]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/message.rs:201:29 [INFO] [stdout] | [INFO] [stdout] 201 | let mut parts = (&input[1..]).splitn(2, ' '); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `input[1..]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> src/message.rs:203:17 [INFO] [stdout] | [INFO] [stdout] 203 | / parts [INFO] [stdout] 204 | | .next() [INFO] [stdout] 205 | | .ok_or_else(|| Error::TagError("missing prefix data".to_string()))? [INFO] [stdout] 206 | | .parse() [INFO] [stdout] 207 | | .or_else(|_| Err(Error::TagError("failed to parse prefix data".to_string())))?, [INFO] [stdout] | |_________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 203 ~ parts [INFO] [stdout] 204 + .next() [INFO] [stdout] 205 + .ok_or_else(|| Error::TagError("missing prefix data".to_string()))? [INFO] [stdout] 206 ~ .parse().map_err(|_| Error::TagError("failed to parse prefix data".to_string()))?, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/message.rs:229:29 [INFO] [stdout] | [INFO] [stdout] 229 | params.push(input[1..].to_string()); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/message.rs:228:13 [INFO] [stdout] | [INFO] [stdout] 228 | if input.starts_with(':') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 228 ~ if let Some() = input.strip_prefix(':') { [INFO] [stdout] 229 ~ params.push(.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/mod.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | !res.is_err(), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `res.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> tests/mod.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 96 | assert!(false, "Extra value {} for key {}", value, key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/escaped.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | / /// information. [INFO] [stdout] 7 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 11 | pub(crate) fn escape_char(c: char) -> Option<&'static str> { [INFO] [stdout] | ------------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! This file implements helpers for tag escaping and unescaping. Each function [INFO] [stdout] 2 ~ //! lists all the possible escape characters, even if the fallback would be [INFO] [stdout] 3 ~ //! valid. [INFO] [stdout] 4 ~ //! [INFO] [stdout] 5 ~ //! See https://ircv3.net/specs/extensions/message-tags.html for more [INFO] [stdout] 6 ~ //! information. [INFO] [stdout] | [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 7 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/message.rs:58:40 [INFO] [stdout] | [INFO] [stdout] 58 | user: user.and_then(|s| if s == "" { None } else { Some(s.to_string()) }), [INFO] [stdout] | ^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/message.rs:59:40 [INFO] [stdout] | [INFO] [stdout] 59 | host: host.and_then(|s| if s == "" { None } else { Some(s.to_string()) }), [INFO] [stdout] | ^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/message.rs:189:29 [INFO] [stdout] | [INFO] [stdout] 189 | let mut parts = (&input[1..]).splitn(2, ' '); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `input[1..]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/message.rs:201:29 [INFO] [stdout] | [INFO] [stdout] 201 | let mut parts = (&input[1..]).splitn(2, ' '); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `input[1..]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)` [INFO] [stdout] --> src/message.rs:203:17 [INFO] [stdout] | [INFO] [stdout] 203 | / parts [INFO] [stdout] 204 | | .next() [INFO] [stdout] 205 | | .ok_or_else(|| Error::TagError("missing prefix data".to_string()))? [INFO] [stdout] 206 | | .parse() [INFO] [stdout] 207 | | .or_else(|_| Err(Error::TagError("failed to parse prefix data".to_string())))?, [INFO] [stdout] | |_________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 203 ~ parts [INFO] [stdout] 204 + .next() [INFO] [stdout] 205 + .ok_or_else(|| Error::TagError("missing prefix data".to_string()))? [INFO] [stdout] 206 ~ .parse().map_err(|_| Error::TagError("failed to parse prefix data".to_string()))?, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/message.rs:229:29 [INFO] [stdout] | [INFO] [stdout] 229 | params.push(input[1..].to_string()); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/message.rs:228:13 [INFO] [stdout] | [INFO] [stdout] 228 | if input.starts_with(':') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 228 ~ if let Some() = input.strip_prefix(':') { [INFO] [stdout] 229 ~ params.push(.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.58s [INFO] running `Command { std: "docker" "inspect" "5e8e81212f352c9696951283bfbfcb377131ed663b9c96b1fdbf36cd1df130ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e8e81212f352c9696951283bfbfcb377131ed663b9c96b1fdbf36cd1df130ca", kill_on_drop: false }` [INFO] [stdout] 5e8e81212f352c9696951283bfbfcb377131ed663b9c96b1fdbf36cd1df130ca