[INFO] fetching crate si-vectors 0.1.0...
[INFO] linting si-vectors-0.1.0 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate si-vectors 0.1.0 into /workspace/builds/worker-7-tc1/source
[INFO] started tweaking crates.io crate si-vectors 0.1.0
[INFO] finished tweaking crates.io crate si-vectors 0.1.0
[INFO] tweaked toml for crates.io crate si-vectors 0.1.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate si-vectors 0.1.0 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate crates.io crate si-vectors 0.1.0 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] bc7f0792577330670c544e379c62d73f6f32467cabbe50dd916285d7afb8235c
[INFO] running `Command { std: "docker" "start" "-a" "bc7f0792577330670c544e379c62d73f6f32467cabbe50dd916285d7afb8235c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "bc7f0792577330670c544e379c62d73f6f32467cabbe50dd916285d7afb8235c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "bc7f0792577330670c544e379c62d73f6f32467cabbe50dd916285d7afb8235c", kill_on_drop: false }`
[INFO] [stdout] bc7f0792577330670c544e379c62d73f6f32467cabbe50dd916285d7afb8235c
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] aeadb76f712e3153b4571a35f5211a176405251a319b2079fb3e36ae7400de54
[INFO] running `Command { std: "docker" "start" "-a" "aeadb76f712e3153b4571a35f5211a176405251a319b2079fb3e36ae7400de54", kill_on_drop: false }`
[INFO] [stderr]     Checking si-vectors v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: empty line after doc comment
[INFO] [stdout]   --> src/value/mod.rs:40:1
[INFO] [stdout]    |
[INFO] [stdout] 40 | / /// println!("{}",v1);
[INFO] [stdout] 41 | |
[INFO] [stdout]    | |_^
[INFO] [stdout] 42 |       pub fn add_num(mut self,unit:SiUnit) -> Self{
[INFO] [stdout]    |       -------------- the comment documents this function
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]    = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
[INFO] [stdout]    = help: if the empty line is unintentional, remove it
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty line after doc comment
[INFO] [stdout]   --> src/value/mod.rs:40:1
[INFO] [stdout]    |
[INFO] [stdout] 40 | / /// println!("{}",v1);
[INFO] [stdout] 41 | |
[INFO] [stdout]    | |_^
[INFO] [stdout] 42 |       pub fn add_num(mut self,unit:SiUnit) -> Self{
[INFO] [stdout]    |       -------------- the comment documents this function
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]    = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
[INFO] [stdout]    = help: if the empty line is unintentional, remove it
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/value/mod.rs:28:9
[INFO] [stdout]    |
[INFO] [stdout] 28 |         return unit.si_units_num.len() == 0 && unit.si_units_den.len() == 0;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 28 -         return unit.si_units_num.len() == 0 && unit.si_units_den.len() == 0;
[INFO] [stdout] 28 +         unit.si_units_num.len() == 0 && unit.si_units_den.len() == 0
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/value/mod.rs:28:16
[INFO] [stdout]    |
[INFO] [stdout] 28 |         return unit.si_units_num.len() == 0 && unit.si_units_den.len() == 0;
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `unit.si_units_num.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/value/mod.rs:28:48
[INFO] [stdout]    |
[INFO] [stdout] 28 |         return unit.si_units_num.len() == 0 && unit.si_units_den.len() == 0;
[INFO] [stdout]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `unit.si_units_den.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/value/mod.rs:66:13
[INFO] [stdout]    |
[INFO] [stdout] 66 | /             match y.binary_search(e) {
[INFO] [stdout] 67 | |                 Ok(r) => {
[INFO] [stdout] 68 | |                     x.remove(i);
[INFO] [stdout] 69 | |                     y.remove(r);
[INFO] [stdout] ...  |
[INFO] [stdout] 73 | |                 Err(_) => ()
[INFO] [stdout] 74 | |             }
[INFO] [stdout]    | |_____________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]    = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 66 ~             if let Ok(r) = y.binary_search(e) {
[INFO] [stdout] 67 +                 x.remove(i);
[INFO] [stdout] 68 +                 y.remove(r);
[INFO] [stdout] 69 +                 
[INFO] [stdout] 70 +                 return Ok((x,y));
[INFO] [stdout] 71 +             }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/value/mod.rs:205:13
[INFO] [stdout]     |
[INFO] [stdout] 205 |             return Self{magnitude: self.magnitude + rhs.magnitude, ..self};
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 205 -             return Self{magnitude: self.magnitude + rhs.magnitude, ..self};
[INFO] [stdout] 205 +             Self{magnitude: self.magnitude + rhs.magnitude, ..self}
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `f64` is unnecessary
[INFO] [stdout]   --> src/si_constants/mod.rs:35:58
[INFO] [stdout]    |
[INFO] [stdout] 35 | ...   SiConstant::SpeedOfLight => Value{magnitude: 299_792_458 as f64,si_units_num: Vec::from([SiUnit::Metre]),si_units_den: Vec::fr...
[INFO] [stdout]    |                                                    ^^^^^^^^^^^^^^^^^^ help: try: `299_792_458_f64`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` has identical blocks
[INFO] [stdout]    --> src/vector/mod.rs:98:64
[INFO] [stdout]     |
[INFO] [stdout]  98 |           } else if x.is_sign_negative() && y.is_sign_positive() {
[INFO] [stdout]     |  ________________________________________________________________^
[INFO] [stdout]  99 | |             (y/x).atan() + PI
[INFO] [stdout] 100 | |         }else{
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout] note: same as this
[INFO] [stdout]    --> src/vector/mod.rs:100:14
[INFO] [stdout]     |
[INFO] [stdout] 100 |           }else{
[INFO] [stdout]     |  ______________^
[INFO] [stdout] 101 | |             (y/x).atan() + PI
[INFO] [stdout] 102 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stdout]     = note: `#[warn(clippy::if_same_then_else)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/cartesian/mod.rs:48:20
[INFO] [stdout]    |
[INFO] [stdout] 48 |                 if !(self.num[i] == rhs.num[i]){
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.num[i] != rhs.num[i])`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/cartesian/mod.rs:58:20
[INFO] [stdout]    |
[INFO] [stdout] 58 |                 if !(self.den[i] == rhs.den[i]){
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.den[i] != rhs.den[i])`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/value/mod.rs:28:9
[INFO] [stdout]    |
[INFO] [stdout] 28 |         return unit.si_units_num.len() == 0 && unit.si_units_den.len() == 0;
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 28 -         return unit.si_units_num.len() == 0 && unit.si_units_den.len() == 0;
[INFO] [stdout] 28 +         unit.si_units_num.len() == 0 && unit.si_units_den.len() == 0
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/value/mod.rs:28:16
[INFO] [stdout]    |
[INFO] [stdout] 28 |         return unit.si_units_num.len() == 0 && unit.si_units_den.len() == 0;
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `unit.si_units_num.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/value/mod.rs:28:48
[INFO] [stdout]    |
[INFO] [stdout] 28 |         return unit.si_units_num.len() == 0 && unit.si_units_den.len() == 0;
[INFO] [stdout]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `unit.si_units_den.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/value/mod.rs:66:13
[INFO] [stdout]    |
[INFO] [stdout] 66 | /             match y.binary_search(e) {
[INFO] [stdout] 67 | |                 Ok(r) => {
[INFO] [stdout] 68 | |                     x.remove(i);
[INFO] [stdout] 69 | |                     y.remove(r);
[INFO] [stdout] ...  |
[INFO] [stdout] 73 | |                 Err(_) => ()
[INFO] [stdout] 74 | |             }
[INFO] [stdout]    | |_____________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]    = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 66 ~             if let Ok(r) = y.binary_search(e) {
[INFO] [stdout] 67 +                 x.remove(i);
[INFO] [stdout] 68 +                 y.remove(r);
[INFO] [stdout] 69 +                 
[INFO] [stdout] 70 +                 return Ok((x,y));
[INFO] [stdout] 71 +             }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/value/mod.rs:205:13
[INFO] [stdout]     |
[INFO] [stdout] 205 |             return Self{magnitude: self.magnitude + rhs.magnitude, ..self};
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 205 -             return Self{magnitude: self.magnitude + rhs.magnitude, ..self};
[INFO] [stdout] 205 +             Self{magnitude: self.magnitude + rhs.magnitude, ..self}
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `f64` is unnecessary
[INFO] [stdout]   --> src/si_constants/mod.rs:35:58
[INFO] [stdout]    |
[INFO] [stdout] 35 | ...   SiConstant::SpeedOfLight => Value{magnitude: 299_792_458 as f64,si_units_num: Vec::from([SiUnit::Metre]),si_units_den: Vec::fr...
[INFO] [stdout]    |                                                    ^^^^^^^^^^^^^^^^^^ help: try: `299_792_458_f64`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` has identical blocks
[INFO] [stdout]    --> src/vector/mod.rs:98:64
[INFO] [stdout]     |
[INFO] [stdout]  98 |           } else if x.is_sign_negative() && y.is_sign_positive() {
[INFO] [stdout]     |  ________________________________________________________________^
[INFO] [stdout]  99 | |             (y/x).atan() + PI
[INFO] [stdout] 100 | |         }else{
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout] note: same as this
[INFO] [stdout]    --> src/vector/mod.rs:100:14
[INFO] [stdout]     |
[INFO] [stdout] 100 |           }else{
[INFO] [stdout]     |  ______________^
[INFO] [stdout] 101 | |             (y/x).atan() + PI
[INFO] [stdout] 102 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stdout]     = note: `#[warn(clippy::if_same_then_else)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/cartesian/mod.rs:48:20
[INFO] [stdout]    |
[INFO] [stdout] 48 |                 if !(self.num[i] == rhs.num[i]){
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.num[i] != rhs.num[i])`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/cartesian/mod.rs:58:20
[INFO] [stdout]    |
[INFO] [stdout] 58 |                 if !(self.den[i] == rhs.den[i]){
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.den[i] != rhs.den[i])`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.38s
[INFO] running `Command { std: "docker" "inspect" "aeadb76f712e3153b4571a35f5211a176405251a319b2079fb3e36ae7400de54", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "aeadb76f712e3153b4571a35f5211a176405251a319b2079fb3e36ae7400de54", kill_on_drop: false }`
[INFO] [stdout] aeadb76f712e3153b4571a35f5211a176405251a319b2079fb3e36ae7400de54