[INFO] fetching crate shuc 0.1.3... [INFO] linting shuc-0.1.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate shuc 0.1.3 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate shuc 0.1.3 [INFO] finished tweaking crates.io crate shuc 0.1.3 [INFO] tweaked toml for crates.io crate shuc 0.1.3 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate shuc 0.1.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate shuc 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 54ae7c40024ea12f1f6411724070159d0122ca3ee8a9636f8c8da5b4896897d6 [INFO] running `Command { std: "docker" "start" "-a" "54ae7c40024ea12f1f6411724070159d0122ca3ee8a9636f8c8da5b4896897d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "54ae7c40024ea12f1f6411724070159d0122ca3ee8a9636f8c8da5b4896897d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54ae7c40024ea12f1f6411724070159d0122ca3ee8a9636f8c8da5b4896897d6", kill_on_drop: false }` [INFO] [stdout] 54ae7c40024ea12f1f6411724070159d0122ca3ee8a9636f8c8da5b4896897d6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 642efd1889eb6c3aa353c1ee65dffe736222f579765cfc9988317c7d78568801 [INFO] running `Command { std: "docker" "start" "-a" "642efd1889eb6c3aa353c1ee65dffe736222f579765cfc9988317c7d78568801", kill_on_drop: false }` [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking shuc v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | if !who.is_err() && ["shutdown", "reboot", "poweroff"].contains(&cmd.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `who.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `who` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:36:61 [INFO] [stdout] | [INFO] [stdout] 35 | if !who.is_err() && ["shutdown", "reboot", "poweroff"].contains(&cmd.as_str()) { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 36 | let _ = println!("{}", String::from_utf8_lossy(&who.unwrap().stdout)); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | let _ = println!("{}", String::from_utf8_lossy(&who.unwrap().stdout)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 36 - let _ = println!("{}", String::from_utf8_lossy(&who.unwrap().stdout)); [INFO] [stdout] 36 + println!("{}", String::from_utf8_lossy(&who.unwrap().stdout)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/main.rs:99:19 [INFO] [stdout] | [INFO] [stdout] 99 | Err(_) => std::io::stdin() [INFO] [stdout] | ___________________^ [INFO] [stdout] 100 | | .bytes() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | if !who.is_err() && ["shutdown", "reboot", "poweroff"].contains(&cmd.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `who.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `who` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:36:61 [INFO] [stdout] | [INFO] [stdout] 35 | if !who.is_err() && ["shutdown", "reboot", "poweroff"].contains(&cmd.as_str()) { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 36 | let _ = println!("{}", String::from_utf8_lossy(&who.unwrap().stdout)); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/main.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | let _ = println!("{}", String::from_utf8_lossy(&who.unwrap().stdout)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 36 - let _ = println!("{}", String::from_utf8_lossy(&who.unwrap().stdout)); [INFO] [stdout] 36 + println!("{}", String::from_utf8_lossy(&who.unwrap().stdout)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/main.rs:99:19 [INFO] [stdout] | [INFO] [stdout] 99 | Err(_) => std::io::stdin() [INFO] [stdout] | ___________________^ [INFO] [stdout] 100 | | .bytes() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.03s [INFO] running `Command { std: "docker" "inspect" "642efd1889eb6c3aa353c1ee65dffe736222f579765cfc9988317c7d78568801", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "642efd1889eb6c3aa353c1ee65dffe736222f579765cfc9988317c7d78568801", kill_on_drop: false }` [INFO] [stdout] 642efd1889eb6c3aa353c1ee65dffe736222f579765cfc9988317c7d78568801