[INFO] fetching crate sgx_demangle 1.1.1... [INFO] linting sgx_demangle-1.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate sgx_demangle 1.1.1 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate sgx_demangle 1.1.1 [INFO] finished tweaking crates.io crate sgx_demangle 1.1.1 [INFO] tweaked toml for crates.io crate sgx_demangle 1.1.1 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate sgx_demangle 1.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f5559a0b6481c29a150ccad7eb9dbb3cb7797ce0232bf73b85df1e6871116fc1 [INFO] running `Command { std: "docker" "start" "-a" "f5559a0b6481c29a150ccad7eb9dbb3cb7797ce0232bf73b85df1e6871116fc1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f5559a0b6481c29a150ccad7eb9dbb3cb7797ce0232bf73b85df1e6871116fc1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5559a0b6481c29a150ccad7eb9dbb3cb7797ce0232bf73b85df1e6871116fc1", kill_on_drop: false }` [INFO] [stdout] f5559a0b6481c29a150ccad7eb9dbb3cb7797ce0232bf73b85df1e6871116fc1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9101b5cbc50ed19fc1603a636460ed910008badc61a27ab698467eb599088212 [INFO] running `Command { std: "docker" "start" "-a" "9101b5cbc50ed19fc1603a636460ed910008badc61a27ab698467eb599088212", kill_on_drop: false }` [INFO] [stderr] Checking sgx_demangle v1.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/legacy.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | / /// ``` [INFO] [stdout] 30 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn demangle(s: &str) -> Result { [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the doc comment should not document function `demangle` then comment it out [INFO] [stdout] | [INFO] [stdout] 10 ~ // /// De-mangles a Rust symbol into a more readable version [INFO] [stdout] 11 ~ // /// [INFO] [stdout] 12 ~ // /// All Rust symbols by default are mangled as they contain characters that [INFO] [stdout] 13 ~ // /// cannot be represented in all object files. The mangling mechanism is similar [INFO] [stdout] 14 ~ // /// to C++'s, but Rust has a few specifics to handle items like lifetimes in [INFO] [stdout] 15 ~ // /// symbols. [INFO] [stdout] 16 ~ // /// [INFO] [stdout] 17 ~ // /// This function will take a **mangled** symbol and return a value. When printed, [INFO] [stdout] 18 ~ // /// the de-mangled version will be written. If the symbol does not look like [INFO] [stdout] 19 ~ // /// a mangled symbol, the original value will be written instead. [INFO] [stdout] 20 ~ // /// [INFO] [stdout] 21 ~ // /// # Examples [INFO] [stdout] 22 ~ // /// [INFO] [stdout] 23 ~ // /// ``` [INFO] [stdout] 24 ~ // /// use rustc_demangle::demangle; [INFO] [stdout] 25 ~ // /// [INFO] [stdout] 26 ~ // /// assert_eq!(demangle("_ZN4testE").to_string(), "test"); [INFO] [stdout] 27 ~ // /// assert_eq!(demangle("_ZN3foo3barE").to_string(), "foo::bar"); [INFO] [stdout] 28 ~ // /// assert_eq!(demangle("foo").to_string(), "foo"); [INFO] [stdout] 29 ~ // /// ``` [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/legacy.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | inner: inner, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/legacy.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | elements: elements, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/v0.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | inner: inner, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | style: style, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | suffix: suffix, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `suffix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/legacy.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | / /// ``` [INFO] [stdout] 30 | | [INFO] [stdout] | |_^ [INFO] [stdout] ... [INFO] [stdout] 48 | pub fn demangle(s: &str) -> Result { [INFO] [stdout] | --------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the doc comment should not document function `demangle` then comment it out [INFO] [stdout] | [INFO] [stdout] 10 ~ // /// De-mangles a Rust symbol into a more readable version [INFO] [stdout] 11 ~ // /// [INFO] [stdout] 12 ~ // /// All Rust symbols by default are mangled as they contain characters that [INFO] [stdout] 13 ~ // /// cannot be represented in all object files. The mangling mechanism is similar [INFO] [stdout] 14 ~ // /// to C++'s, but Rust has a few specifics to handle items like lifetimes in [INFO] [stdout] 15 ~ // /// symbols. [INFO] [stdout] 16 ~ // /// [INFO] [stdout] 17 ~ // /// This function will take a **mangled** symbol and return a value. When printed, [INFO] [stdout] 18 ~ // /// the de-mangled version will be written. If the symbol does not look like [INFO] [stdout] 19 ~ // /// a mangled symbol, the original value will be written instead. [INFO] [stdout] 20 ~ // /// [INFO] [stdout] 21 ~ // /// # Examples [INFO] [stdout] 22 ~ // /// [INFO] [stdout] 23 ~ // /// ``` [INFO] [stdout] 24 ~ // /// use rustc_demangle::demangle; [INFO] [stdout] 25 ~ // /// [INFO] [stdout] 26 ~ // /// assert_eq!(demangle("_ZN4testE").to_string(), "test"); [INFO] [stdout] 27 ~ // /// assert_eq!(demangle("_ZN3foo3barE").to_string(), "foo::bar"); [INFO] [stdout] 28 ~ // /// assert_eq!(demangle("foo").to_string(), "foo"); [INFO] [stdout] 29 ~ // /// ``` [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/legacy.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | inner: inner, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/legacy.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | elements: elements, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/v0.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | inner: inner, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | style: style, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `style` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | suffix: suffix, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `suffix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/legacy.rs:91:16 [INFO] [stdout] | [INFO] [stdout] 91 | if !chars.next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `chars.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/legacy.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | if !c.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 16 [INFO] [stdout] --> src/legacy.rs:110:50 [INFO] [stdout] | [INFO] [stdout] 110 | s.starts_with('h') && s[1..].chars().all(|c| c.is_digit(16)) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_hexdigit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/legacy.rs:119:19 [INFO] [stdout] | [INFO] [stdout] 119 | while rest.chars().next().unwrap().is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rest.chars().next().unwrap().is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/legacy.rs:127:76 [INFO] [stdout] | [INFO] [stdout] 127 | if f.alternate() && element+1 == self.elements && is_rust_hash(&rest) { [INFO] [stdout] | ^^^^^ help: change this to: `rest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/v0.rs:382:13 [INFO] [stdout] | [INFO] [stdout] 382 | / loop { [INFO] [stdout] 383 | | match self.digit_10() { [INFO] [stdout] 384 | | Ok(d) => { [INFO] [stdout] 385 | | len = len.checked_mul(10).ok_or(Invalid)?; [INFO] [stdout] ... | [INFO] [stdout] 390 | | } [INFO] [stdout] | |_____________^ help: try: `while let Ok(d) = self.digit_10() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/v0.rs:776:9 [INFO] [stdout] | [INFO] [stdout] 776 | / match basic_type(tag) { [INFO] [stdout] 777 | | Some(ty) => return self.out.write_str(ty), [INFO] [stdout] 778 | | None => {} [INFO] [stdout] 779 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(ty) = basic_type(tag) { return self.out.write_str(ty) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/v0.rs:844:17 [INFO] [stdout] | [INFO] [stdout] 844 | / match abi { [INFO] [stdout] 845 | | Some(abi) => { [INFO] [stdout] 846 | | this.out.write_str("extern \"")?; [INFO] [stdout] ... | [INFO] [stdout] 859 | | None => {} [INFO] [stdout] 860 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 844 ~ if let Some(abi) = abi { [INFO] [stdout] 845 + this.out.write_str("extern \"")?; [INFO] [stdout] 846 + [INFO] [stdout] 847 + // If the ABI had any `-`, they were replaced with `_`, [INFO] [stdout] 848 + // so the parts between `_` have to be re-joined with `-`. [INFO] [stdout] 849 + let mut parts = abi.split('_'); [INFO] [stdout] 850 + this.out.write_str(parts.next().unwrap())?; [INFO] [stdout] 851 + for part in parts { [INFO] [stdout] 852 + this.out.write_str("-")?; [INFO] [stdout] 853 + this.out.write_str(part)?; [INFO] [stdout] 854 + } [INFO] [stdout] 855 + [INFO] [stdout] 856 + this.out.write_str("\" ")?; [INFO] [stdout] 857 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/legacy.rs:91:16 [INFO] [stdout] | [INFO] [stdout] 91 | if !chars.next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `chars.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/legacy.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | if !c.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 16 [INFO] [stdout] --> src/legacy.rs:110:50 [INFO] [stdout] | [INFO] [stdout] 110 | s.starts_with('h') && s[1..].chars().all(|c| c.is_digit(16)) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_hexdigit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/legacy.rs:119:19 [INFO] [stdout] | [INFO] [stdout] 119 | while rest.chars().next().unwrap().is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rest.chars().next().unwrap().is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/legacy.rs:127:76 [INFO] [stdout] | [INFO] [stdout] 127 | if f.alternate() && element+1 == self.elements && is_rust_hash(&rest) { [INFO] [stdout] | ^^^^^ help: change this to: `rest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lib.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | / match c { [INFO] [stdout] 71 | | 'A' ..= 'F' | '0' ..= '9' | '@' => true, [INFO] [stdout] 72 | | _ => false, [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 70 - match c { [INFO] [stdout] 71 - 'A' ..= 'F' | '0' ..= '9' | '@' => true, [INFO] [stdout] 72 - _ => false, [INFO] [stdout] 73 - } [INFO] [stdout] 70 + matches!(c, 'A' ..= 'F' | '0' ..= '9' | '@') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lib.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | / match c { [INFO] [stdout] 154 | | '\u{0041}' ..= '\u{005A}' | [INFO] [stdout] 155 | | '\u{0061}' ..= '\u{007A}' | [INFO] [stdout] 156 | | '\u{0030}' ..= '\u{0039}' => true, [INFO] [stdout] 157 | | _ => false, [INFO] [stdout] 158 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 153 ~ matches!(c, '\u{0041}' ..= '\u{005A}' | [INFO] [stdout] 154 + '\u{0061}' ..= '\u{007A}' | [INFO] [stdout] 155 + '\u{0030}' ..= '\u{0039}') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lib.rs:163:5 [INFO] [stdout] | [INFO] [stdout] 163 | / match c { [INFO] [stdout] 164 | | '\u{0021}' ..= '\u{002F}' | [INFO] [stdout] 165 | | '\u{003A}' ..= '\u{0040}' | [INFO] [stdout] 166 | | '\u{005B}' ..= '\u{0060}' | [INFO] [stdout] 167 | | '\u{007B}' ..= '\u{007E}' => true, [INFO] [stdout] 168 | | _ => false, [INFO] [stdout] 169 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 163 ~ matches!(c, '\u{0021}' ..= '\u{002F}' | [INFO] [stdout] 164 + '\u{003A}' ..= '\u{0040}' | [INFO] [stdout] 165 + '\u{005B}' ..= '\u{0060}' | [INFO] [stdout] 166 + '\u{007B}' ..= '\u{007E}') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:62:24 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn demangle(mut s: &str) -> Demangle { [INFO] [stdout] | ^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 62 | pub fn demangle(mut s: &str) -> Demangle<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:127:24 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn try_demangle(s: &str) -> Result { [INFO] [stdout] | ^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 127 | pub fn try_demangle(s: &str) -> Result, TryDemangleError> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/legacy.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn demangle(s: &str) -> Result { [INFO] [stdout] | ^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 48 | pub fn demangle(s: &str) -> Result, ()> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/v0.rs:15:20 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn demangle(s: &str) -> Result { [INFO] [stdout] | ^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 15 | pub fn demangle(s: &str) -> Result, Invalid> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/v0.rs:382:13 [INFO] [stdout] | [INFO] [stdout] 382 | / loop { [INFO] [stdout] 383 | | match self.digit_10() { [INFO] [stdout] 384 | | Ok(d) => { [INFO] [stdout] 385 | | len = len.checked_mul(10).ok_or(Invalid)?; [INFO] [stdout] ... | [INFO] [stdout] 390 | | } [INFO] [stdout] | |_____________^ help: try: `while let Ok(d) = self.digit_10() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/v0.rs:776:9 [INFO] [stdout] | [INFO] [stdout] 776 | / match basic_type(tag) { [INFO] [stdout] 777 | | Some(ty) => return self.out.write_str(ty), [INFO] [stdout] 778 | | None => {} [INFO] [stdout] 779 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(ty) = basic_type(tag) { return self.out.write_str(ty) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/v0.rs:844:17 [INFO] [stdout] | [INFO] [stdout] 844 | / match abi { [INFO] [stdout] 845 | | Some(abi) => { [INFO] [stdout] 846 | | this.out.write_str("extern \"")?; [INFO] [stdout] ... | [INFO] [stdout] 859 | | None => {} [INFO] [stdout] 860 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 844 ~ if let Some(abi) = abi { [INFO] [stdout] 845 + this.out.write_str("extern \"")?; [INFO] [stdout] 846 + [INFO] [stdout] 847 + // If the ABI had any `-`, they were replaced with `_`, [INFO] [stdout] 848 + // so the parts between `_` have to be re-joined with `-`. [INFO] [stdout] 849 + let mut parts = abi.split('_'); [INFO] [stdout] 850 + this.out.write_str(parts.next().unwrap())?; [INFO] [stdout] 851 + for part in parts { [INFO] [stdout] 852 + this.out.write_str("-")?; [INFO] [stdout] 853 + this.out.write_str(part)?; [INFO] [stdout] 854 + } [INFO] [stdout] 855 + [INFO] [stdout] 856 + this.out.write_str("\" ")?; [INFO] [stdout] 857 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lib.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | / match c { [INFO] [stdout] 71 | | 'A' ..= 'F' | '0' ..= '9' | '@' => true, [INFO] [stdout] 72 | | _ => false, [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 70 - match c { [INFO] [stdout] 71 - 'A' ..= 'F' | '0' ..= '9' | '@' => true, [INFO] [stdout] 72 - _ => false, [INFO] [stdout] 73 - } [INFO] [stdout] 70 + matches!(c, 'A' ..= 'F' | '0' ..= '9' | '@') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lib.rs:153:5 [INFO] [stdout] | [INFO] [stdout] 153 | / match c { [INFO] [stdout] 154 | | '\u{0041}' ..= '\u{005A}' | [INFO] [stdout] 155 | | '\u{0061}' ..= '\u{007A}' | [INFO] [stdout] 156 | | '\u{0030}' ..= '\u{0039}' => true, [INFO] [stdout] 157 | | _ => false, [INFO] [stdout] 158 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 153 ~ matches!(c, '\u{0041}' ..= '\u{005A}' | [INFO] [stdout] 154 + '\u{0061}' ..= '\u{007A}' | [INFO] [stdout] 155 + '\u{0030}' ..= '\u{0039}') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lib.rs:163:5 [INFO] [stdout] | [INFO] [stdout] 163 | / match c { [INFO] [stdout] 164 | | '\u{0021}' ..= '\u{002F}' | [INFO] [stdout] 165 | | '\u{003A}' ..= '\u{0040}' | [INFO] [stdout] 166 | | '\u{005B}' ..= '\u{0060}' | [INFO] [stdout] 167 | | '\u{007B}' ..= '\u{007E}' => true, [INFO] [stdout] 168 | | _ => false, [INFO] [stdout] 169 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 163 ~ matches!(c, '\u{0021}' ..= '\u{002F}' | [INFO] [stdout] 164 + '\u{003A}' ..= '\u{0040}' | [INFO] [stdout] 165 + '\u{005B}' ..= '\u{0060}' | [INFO] [stdout] 166 + '\u{007B}' ..= '\u{007E}') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:62:24 [INFO] [stdout] | [INFO] [stdout] 62 | pub fn demangle(mut s: &str) -> Demangle { [INFO] [stdout] | ^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 62 | pub fn demangle(mut s: &str) -> Demangle<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:127:24 [INFO] [stdout] | [INFO] [stdout] 127 | pub fn try_demangle(s: &str) -> Result { [INFO] [stdout] | ^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 127 | pub fn try_demangle(s: &str) -> Result, TryDemangleError> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/legacy.rs:48:20 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn demangle(s: &str) -> Result { [INFO] [stdout] | ^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 48 | pub fn demangle(s: &str) -> Result, ()> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/v0.rs:15:20 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn demangle(s: &str) -> Result { [INFO] [stdout] | ^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 15 | pub fn demangle(s: &str) -> Result, Invalid> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.41s [INFO] running `Command { std: "docker" "inspect" "9101b5cbc50ed19fc1603a636460ed910008badc61a27ab698467eb599088212", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9101b5cbc50ed19fc1603a636460ed910008badc61a27ab698467eb599088212", kill_on_drop: false }` [INFO] [stdout] 9101b5cbc50ed19fc1603a636460ed910008badc61a27ab698467eb599088212