[INFO] fetching crate sgf-render 3.3.1... [INFO] linting sgf-render-3.3.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate sgf-render 3.3.1 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate sgf-render 3.3.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate sgf-render 3.3.1 [INFO] tweaked toml for crates.io crate sgf-render 3.3.1 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate sgf-render 3.3.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate sgf-render 3.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded imagesize v0.12.0 [INFO] [stderr] Downloaded shell-words v1.0.0 [INFO] [stderr] Downloaded resvg v0.40.0 [INFO] [stderr] Downloaded minidom v0.15.2 [INFO] [stderr] Downloaded rgb v0.8.27 [INFO] [stderr] Downloaded roxmltree v0.19.0 [INFO] [stderr] Downloaded simplecss v0.2.1 [INFO] [stderr] Downloaded rustybuzz v0.12.1 [INFO] [stderr] Downloaded rxml_validation v0.9.1 [INFO] [stderr] Downloaded rxml v0.9.1 [INFO] [stderr] Downloaded sgf-parse v4.2.7 [INFO] [stderr] Downloaded flate2 v1.0.21 [INFO] [stderr] Downloaded fontconfig-parser v0.5.6 [INFO] [stderr] Downloaded usvg v0.40.0 [INFO] [stderr] Downloaded unicode-script v0.5.3 [INFO] [stderr] Downloaded svgtypes v0.14.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b84db0970c506d1898fb101d89872f9cbab97fd29046b99a699de75f96a51ab1 [INFO] running `Command { std: "docker" "start" "-a" "b84db0970c506d1898fb101d89872f9cbab97fd29046b99a699de75f96a51ab1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b84db0970c506d1898fb101d89872f9cbab97fd29046b99a699de75f96a51ab1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b84db0970c506d1898fb101d89872f9cbab97fd29046b99a699de75f96a51ab1", kill_on_drop: false }` [INFO] [stdout] b84db0970c506d1898fb101d89872f9cbab97fd29046b99a699de75f96a51ab1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e5936dec2d1526b209daf149d309018011b9c481be983fa3cd8815923482f303 [INFO] running `Command { std: "docker" "start" "-a" "e5936dec2d1526b209daf149d309018011b9c481be983fa3cd8815923482f303", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking bytemuck v1.14.3 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Compiling smartstring v1.0.1 [INFO] [stderr] Checking roxmltree v0.19.0 [INFO] [stderr] Checking arrayref v0.3.6 [INFO] [stderr] Compiling syn v2.0.50 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Checking fontconfig-parser v0.5.6 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking unicode-bidi-mirroring v0.1.0 [INFO] [stderr] Checking kurbo v0.10.4 [INFO] [stderr] Checking unicode-properties v0.1.1 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking unicode-script v0.5.3 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking unicode-ccc v0.1.2 [INFO] [stderr] Checking simplecss v0.2.1 [INFO] [stderr] Checking kurbo v0.9.5 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking rustybuzz v0.12.1 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking anstream v0.6.12 [INFO] [stderr] Checking pico-args v0.5.0 [INFO] [stderr] Checking rxml_validation v0.9.1 [INFO] [stderr] Checking unicode-vo v0.1.0 [INFO] [stderr] Checking imagesize v0.12.0 [INFO] [stderr] Checking winnow v0.6.2 [INFO] [stderr] Checking indexmap v2.2.3 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking data-url v0.3.1 [INFO] [stderr] Checking xmlwriter v0.1.0 [INFO] [stderr] Checking unicode-bidi v0.3.6 [INFO] [stderr] Checking rxml v0.9.1 [INFO] [stderr] Checking gif v0.12.0 [INFO] [stderr] Checking rgb v0.8.27 [INFO] [stderr] Compiling sgf-render v3.3.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking sgf-parse v4.2.7 [INFO] [stderr] Checking shell-words v1.0.0 [INFO] [stderr] Checking clap_builder v4.5.1 [INFO] [stderr] Checking svgtypes v0.14.0 [INFO] [stderr] Checking flate2 v1.0.21 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking fontdb v0.16.2 [INFO] [stderr] Checking minidom v0.15.2 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking usvg v0.40.0 [INFO] [stderr] Checking clap v4.5.1 [INFO] [stderr] Checking resvg v0.40.0 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking toml_edit v0.22.6 [INFO] [stderr] Checking toml v0.8.10 [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib/goban.rs:186:21 [INFO] [stdout] | [INFO] [stdout] 186 | / if !self.is_tt_pass(*point) { [INFO] [stdout] 187 | | self.play_stone(Stone::new(point.x, point.y, StoneColor::Black))?; [INFO] [stdout] 188 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 185 ~ go::Prop::B(go::Move::Move(point)) [INFO] [stdout] 186 ~ if !self.is_tt_pass(*point) => { [INFO] [stdout] 187 | self.play_stone(Stone::new(point.x, point.y, StoneColor::Black))?; [INFO] [stdout] 188 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib/goban.rs:191:21 [INFO] [stdout] | [INFO] [stdout] 191 | / if !self.is_tt_pass(*point) { [INFO] [stdout] 192 | | self.play_stone(Stone::new(point.x, point.y, StoneColor::White))?; [INFO] [stdout] 193 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 190 ~ go::Prop::W(go::Move::Move(point)) [INFO] [stdout] 191 ~ if !self.is_tt_pass(*point) => { [INFO] [stdout] 192 | self.play_stone(Stone::new(point.x, point.y, StoneColor::White))?; [INFO] [stdout] 193 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib/goban.rs:186:21 [INFO] [stdout] | [INFO] [stdout] 186 | / if !self.is_tt_pass(*point) { [INFO] [stdout] 187 | | self.play_stone(Stone::new(point.x, point.y, StoneColor::Black))?; [INFO] [stdout] 188 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 185 ~ go::Prop::B(go::Move::Move(point)) [INFO] [stdout] 186 ~ if !self.is_tt_pass(*point) => { [INFO] [stdout] 187 | self.play_stone(Stone::new(point.x, point.y, StoneColor::Black))?; [INFO] [stdout] 188 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib/goban.rs:191:21 [INFO] [stdout] | [INFO] [stdout] 191 | / if !self.is_tt_pass(*point) { [INFO] [stdout] 192 | | self.play_stone(Stone::new(point.x, point.y, StoneColor::White))?; [INFO] [stdout] 193 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 190 ~ go::Prop::W(go::Move::Move(point)) [INFO] [stdout] 191 ~ if !self.is_tt_pass(*point) => { [INFO] [stdout] 192 | self.play_stone(Stone::new(point.x, point.y, StoneColor::White))?; [INFO] [stdout] 193 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/goban.rs:397:17 [INFO] [stdout] | [INFO] [stdout] 397 | assert!(!result.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/render/text.rs:114:24 [INFO] [stdout] | [INFO] [stdout] 114 | render(&goban, &options).unwrap() [INFO] [stdout] | ^^^^^^^^ help: change this to: `options` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib/render/text.rs:147:9 [INFO] [stdout] | [INFO] [stdout] 147 | options.label_sides = "nw".parse().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `render::options::RenderOptions { label_sides: "nw".parse().unwrap(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/lib/render/text.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | let mut options = RenderOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib/render/text.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 175 | options.goban_range = GobanRange::Ranged(1..7, 0..5); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `render::options::RenderOptions { goban_range: GobanRange::Ranged(1..7, 0..5), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/lib/render/text.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | let mut options = RenderOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib/render/text.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | options.label_sides = "nwes".parse().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `render::options::RenderOptions { label_sides: "nwes".parse().unwrap(), goban_range: GobanRange::Ranged(1..7, 0..5), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/lib/render/text.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 188 | let mut options = RenderOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib/render/text.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 206 | options.goban_range = GobanRange::ShrinkWrap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `render::options::RenderOptions { goban_range: GobanRange::ShrinkWrap, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/lib/render/text.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 205 | let mut options = RenderOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib/render/text.rs:221:9 [INFO] [stdout] | [INFO] [stdout] 221 | options.goban_range = GobanRange::ShrinkWrap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `render::options::RenderOptions { goban_range: GobanRange::ShrinkWrap, tileset: "OX++++-|-|.".parse().unwrap(), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/lib/render/text.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | let mut options = RenderOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.23s [INFO] running `Command { std: "docker" "inspect" "e5936dec2d1526b209daf149d309018011b9c481be983fa3cd8815923482f303", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5936dec2d1526b209daf149d309018011b9c481be983fa3cd8815923482f303", kill_on_drop: false }` [INFO] [stdout] e5936dec2d1526b209daf149d309018011b9c481be983fa3cd8815923482f303