[INFO] fetching crate sequoia-man 0.3.2... [INFO] linting sequoia-man-0.3.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate sequoia-man 0.3.2 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate sequoia-man 0.3.2 [INFO] finished tweaking crates.io crate sequoia-man 0.3.2 [INFO] tweaked toml for crates.io crate sequoia-man 0.3.2 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate sequoia-man 0.3.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate sequoia-man 0.3.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ccb44906e3feaa48b861320ee5b35a38b16da05b5ef81d6a37458d97aaee4fbe [INFO] running `Command { std: "docker" "start" "-a" "ccb44906e3feaa48b861320ee5b35a38b16da05b5ef81d6a37458d97aaee4fbe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ccb44906e3feaa48b861320ee5b35a38b16da05b5ef81d6a37458d97aaee4fbe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ccb44906e3feaa48b861320ee5b35a38b16da05b5ef81d6a37458d97aaee4fbe", kill_on_drop: false }` [INFO] [stdout] ccb44906e3feaa48b861320ee5b35a38b16da05b5ef81d6a37458d97aaee4fbe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cae6fb92e5659546d469b6f016f5511059ea35d44bcde2435f828505ae098111 [INFO] running `Command { std: "docker" "start" "-a" "cae6fb92e5659546d469b6f016f5511059ea35d44bcde2435f828505ae098111", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.170 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Checking clap_builder v4.5.31 [INFO] [stderr] Checking once_cell v1.20.3 [INFO] [stderr] Checking roff v0.2.2 [INFO] [stderr] Checking getrandom v0.3.1 [INFO] [stderr] Checking tempfile v3.17.1 [INFO] [stderr] Compiling clap_derive v4.5.28 [INFO] [stderr] Checking clap v4.5.31 [INFO] [stderr] Checking sequoia-man v0.3.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/lib.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | / /// generator. The scope is specifically the Sequoia sq command. [INFO] [stdout] 25 | | [INFO] [stdout] | |_^ [INFO] [stdout] 26 | use std::env; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the crate use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! Generate Unix manual pages for sq from its `clap::Command` value. [INFO] [stdout] 2 ~ //! [INFO] [stdout] 3 ~ //! A Unix manual page is a document marked up with the [INFO] [stdout] 4 ~ //! [troff](https://en.wikipedia.org/wiki/Troff) language. The troff [INFO] [stdout] 5 ~ //! markup is the source code for the page, and is formatted and [INFO] [stdout] 6 ~ //! displayed using the "man" command. [INFO] [stdout] 7 ~ //! [INFO] [stdout] 8 ~ //! Troff is a child of the 1970s and is one of the earlier markup [INFO] [stdout] 9 ~ //! languages. It has little resemblance to markup languages born in [INFO] [stdout] 10 ~ //! the 21st century, such as Markdown. However, it's not actually [INFO] [stdout] 11 ~ //! difficult, merely old, and sometimes weird. Some of the design of [INFO] [stdout] 12 ~ //! the troff language was dictated by the constraints of 1970s [INFO] [stdout] 13 ~ //! hardware, programming languages, and fashions in programming. Let [INFO] [stdout] 14 ~ //! not those scare you. [INFO] [stdout] 15 ~ //! [INFO] [stdout] 16 ~ //! The troff language supports "macros", a way to define new commands [INFO] [stdout] 17 ~ //! based on built-in commands. There are a number of popular macro [INFO] [stdout] 18 ~ //! packages for various purposes. One of the most popular ones for [INFO] [stdout] 19 ~ //! manual pages is called "man", and this module generates manual [INFO] [stdout] 20 ~ //! pages for that package. It's supported by the "man" command on all [INFO] [stdout] 21 ~ //! Unix systems. [INFO] [stdout] 22 ~ //! [INFO] [stdout] 23 ~ //! Note that this module doesn't aim to be a generic manual page [INFO] [stdout] 24 ~ //! generator. The scope is specifically the Sequoia sq command. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/lib.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | / /// generator. The scope is specifically the Sequoia sq command. [INFO] [stdout] 25 | | [INFO] [stdout] | |_^ [INFO] [stdout] 26 | use std::env; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the crate use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! Generate Unix manual pages for sq from its `clap::Command` value. [INFO] [stdout] 2 ~ //! [INFO] [stdout] 3 ~ //! A Unix manual page is a document marked up with the [INFO] [stdout] 4 ~ //! [troff](https://en.wikipedia.org/wiki/Troff) language. The troff [INFO] [stdout] 5 ~ //! markup is the source code for the page, and is formatted and [INFO] [stdout] 6 ~ //! displayed using the "man" command. [INFO] [stdout] 7 ~ //! [INFO] [stdout] 8 ~ //! Troff is a child of the 1970s and is one of the earlier markup [INFO] [stdout] 9 ~ //! languages. It has little resemblance to markup languages born in [INFO] [stdout] 10 ~ //! the 21st century, such as Markdown. However, it's not actually [INFO] [stdout] 11 ~ //! difficult, merely old, and sometimes weird. Some of the design of [INFO] [stdout] 12 ~ //! the troff language was dictated by the constraints of 1970s [INFO] [stdout] 13 ~ //! hardware, programming languages, and fashions in programming. Let [INFO] [stdout] 14 ~ //! not those scare you. [INFO] [stdout] 15 ~ //! [INFO] [stdout] 16 ~ //! The troff language supports "macros", a way to define new commands [INFO] [stdout] 17 ~ //! based on built-in commands. There are a number of popular macro [INFO] [stdout] 18 ~ //! packages for various purposes. One of the most popular ones for [INFO] [stdout] 19 ~ //! manual pages is called "man", and this module generates manual [INFO] [stdout] 20 ~ //! pages for that package. It's supported by the "man" command on all [INFO] [stdout] 21 ~ //! Unix systems. [INFO] [stdout] 22 ~ //! [INFO] [stdout] 23 ~ //! Note that this module doesn't aim to be a generic manual page [INFO] [stdout] 24 ~ //! generator. The scope is specifically the Sequoia sq command. [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/man.rs:132:20 [INFO] [stdout] | [INFO] [stdout] 132 | let line = if let Some(line) = about.lines().next() { [INFO] [stdout] | ____________________^ [INFO] [stdout] 133 | | line [INFO] [stdout] 134 | | } else { [INFO] [stdout] 135 | | "" [INFO] [stdout] 136 | | }; [INFO] [stdout] | |_________^ help: replace it with: `about.lines().next().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/man.rs:150:34 [INFO] [stdout] | [INFO] [stdout] 150 | self.see_also = see_also.into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/man.rs:320:9 [INFO] [stdout] | [INFO] [stdout] 319 | let text = self.extract_exit_status(&text); [INFO] [stdout] | ------------------------------------------- unnecessary `let` binding [INFO] [stdout] 320 | text [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 319 ~ [INFO] [stdout] 320 ~ self.extract_exit_status(&text) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/man.rs:653:18 [INFO] [stdout] | [INFO] [stdout] 653 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/man.rs:735:31 [INFO] [stdout] | [INFO] [stdout] 735 | self.roff.text([roman(&format!("{} - {}", name, summary))]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{} - {}", name, summary)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/man.rs:927:23 [INFO] [stdout] | [INFO] [stdout] 927 | self.text(&chunk); [INFO] [stdout] | ^^^^^^ help: change this to: `chunk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/man.rs:960:28 [INFO] [stdout] | [INFO] [stdout] 960 | if ! continuation [INFO] [stdout] | ____________________________^ [INFO] [stdout] 961 | | && ! (description && line.starts_with("#")) [INFO] [stdout] | |_______________________________________________________________________^ help: try: `!(continuation || description && line.starts_with("#"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/lib.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 126 | man2html.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `man2html.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/lib.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | man2html.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `man2html.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/man.rs:132:20 [INFO] [stdout] | [INFO] [stdout] 132 | let line = if let Some(line) = about.lines().next() { [INFO] [stdout] | ____________________^ [INFO] [stdout] 133 | | line [INFO] [stdout] 134 | | } else { [INFO] [stdout] 135 | | "" [INFO] [stdout] 136 | | }; [INFO] [stdout] | |_________^ help: replace it with: `about.lines().next().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/man.rs:150:34 [INFO] [stdout] | [INFO] [stdout] 150 | self.see_also = see_also.into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/man.rs:320:9 [INFO] [stdout] | [INFO] [stdout] 319 | let text = self.extract_exit_status(&text); [INFO] [stdout] | ------------------------------------------- unnecessary `let` binding [INFO] [stdout] 320 | text [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 319 ~ [INFO] [stdout] 320 ~ self.extract_exit_status(&text) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/man.rs:653:18 [INFO] [stdout] | [INFO] [stdout] 653 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/man.rs:735:31 [INFO] [stdout] | [INFO] [stdout] 735 | self.roff.text([roman(&format!("{} - {}", name, summary))]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{} - {}", name, summary)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/man.rs:927:23 [INFO] [stdout] | [INFO] [stdout] 927 | self.text(&chunk); [INFO] [stdout] | ^^^^^^ help: change this to: `chunk` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/man.rs:960:28 [INFO] [stdout] | [INFO] [stdout] 960 | if ! continuation [INFO] [stdout] | ____________________________^ [INFO] [stdout] 961 | | && ! (description && line.starts_with("#")) [INFO] [stdout] | |_______________________________________________________________________^ help: try: `!(continuation || description && line.starts_with("#"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/lib.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 126 | man2html.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `man2html.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/lib.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | man2html.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `man2html.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.38s [INFO] running `Command { std: "docker" "inspect" "cae6fb92e5659546d469b6f016f5511059ea35d44bcde2435f828505ae098111", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cae6fb92e5659546d469b6f016f5511059ea35d44bcde2435f828505ae098111", kill_on_drop: false }` [INFO] [stdout] cae6fb92e5659546d469b6f016f5511059ea35d44bcde2435f828505ae098111