[INFO] fetching crate seqsample 0.2.0... [INFO] linting seqsample-0.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate seqsample 0.2.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate seqsample 0.2.0 [INFO] finished tweaking crates.io crate seqsample 0.2.0 [INFO] tweaked toml for crates.io crate seqsample 0.2.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate seqsample 0.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate seqsample 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded slug v0.1.4 [INFO] [stderr] Downloaded quote v1.0.20 [INFO] [stderr] Downloaded strum v0.23.0 [INFO] [stderr] Downloaded unicode-ident v1.0.1 [INFO] [stderr] Downloaded bio-types v0.12.1 [INFO] [stderr] Downloaded uncased v0.9.7 [INFO] [stderr] Downloaded anyhow v1.0.58 [INFO] [stderr] Downloaded num-complex v0.4.2 [INFO] [stderr] Downloaded matrixmultiply v0.3.2 [INFO] [stderr] Downloaded tera v1.16.0 [INFO] [stderr] Downloaded deunicode v0.4.3 [INFO] [stderr] Downloaded hashbrown v0.12.1 [INFO] [stderr] Downloaded statrs v0.15.0 [INFO] [stderr] Downloaded itertools v0.10.3 [INFO] [stderr] Downloaded unicode-normalization v0.1.20 [INFO] [stderr] Downloaded petgraph v0.6.2 [INFO] [stderr] Downloaded bio v0.41.0 [INFO] [stderr] Downloaded syn v1.0.98 [INFO] [stderr] Downloaded ndarray v0.15.4 [INFO] [stderr] Downloaded regex v1.5.6 [INFO] [stderr] Downloaded regex-syntax v0.6.26 [INFO] [stderr] Downloaded clap v3.2.8 [INFO] [stderr] Downloaded nalgebra v0.27.1 [INFO] [stderr] Downloaded libm v0.2.2 [INFO] [stderr] Downloaded serde_json v1.0.82 [INFO] [stderr] Downloaded textwrap v0.15.0 [INFO] [stderr] Downloaded indexmap v1.9.1 [INFO] [stderr] Downloaded crossbeam-utils v0.8.10 [INFO] [stderr] Downloaded simba v0.5.1 [INFO] [stderr] Downloaded strum_macros v0.23.1 [INFO] [stderr] Downloaded getrandom v0.2.7 [INFO] [stderr] Downloaded proc-macro2 v1.0.40 [INFO] [stderr] Downloaded rustversion v1.0.7 [INFO] [stderr] Downloaded os_str_bytes v6.1.0 [INFO] [stderr] Downloaded either v1.7.0 [INFO] [stderr] Downloaded unic-segment v0.9.0 [INFO] [stderr] Downloaded bit-set v0.5.2 [INFO] [stderr] Downloaded chrono-tz v0.6.1 [INFO] [stderr] Downloaded bytecount v0.6.3 [INFO] [stderr] Downloaded phf_codegen v0.10.0 [INFO] [stderr] Downloaded chrono-tz-build v0.0.2 [INFO] [stderr] Downloaded phf v0.10.1 [INFO] [stderr] Downloaded humansize v1.1.1 [INFO] [stderr] Downloaded unic-ucd-segment v0.9.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c2905231a89b896793fdc6cc003928429a9b21d2838a3359c0d578df1e4e12af [INFO] running `Command { std: "docker" "start" "-a" "c2905231a89b896793fdc6cc003928429a9b21d2838a3359c0d578df1e4e12af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c2905231a89b896793fdc6cc003928429a9b21d2838a3359c0d578df1e4e12af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2905231a89b896793fdc6cc003928429a9b21d2838a3359c0d578df1e4e12af", kill_on_drop: false }` [INFO] [stdout] c2905231a89b896793fdc6cc003928429a9b21d2838a3359c0d578df1e4e12af [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d849626cc21c701ec04357818705b1d9f6f69ee086afbb08f8627326312760aa [INFO] running `Command { std: "docker" "start" "-a" "d849626cc21c701ec04357818705b1d9f6f69ee086afbb08f8627326312760aa", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling libm v0.2.2 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Checking either v1.7.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Compiling uncased v0.9.7 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling siphasher v0.3.10 [INFO] [stderr] Compiling ppv-lite86 v0.2.16 [INFO] [stderr] Compiling getrandom v0.2.7 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Compiling rand_core v0.6.3 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking unicode-normalization v0.1.20 [INFO] [stderr] Checking hashbrown v0.12.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling openssl-sys v0.9.74 [INFO] [stderr] Compiling aho-corasick v0.7.18 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Checking parking_lot v0.9.0 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking crossbeam-deque v0.7.4 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Compiling phf_codegen v0.10.0 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Compiling phf v0.10.1 [INFO] [stderr] Checking num-complex v0.4.2 [INFO] [stderr] Compiling backtrace v0.3.65 [INFO] [stderr] Checking http v0.1.21 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling httparse v1.7.1 [INFO] [stderr] Compiling serde_json v1.0.82 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.10 [INFO] [stderr] Compiling openssl v0.10.40 [INFO] [stderr] Compiling semver v0.1.20 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Compiling unicode-xid v0.2.3 [INFO] [stderr] Checking gimli v0.26.1 [INFO] [stderr] Compiling rustversion v1.0.7 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Compiling rustc_version v0.1.7 [INFO] [stderr] Checking matrixmultiply v0.3.2 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking tokio-buf v0.1.1 [INFO] [stderr] Checking string v0.2.1 [INFO] [stderr] Compiling parse-zoneinfo v0.3.0 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking object v0.28.4 [INFO] [stderr] Compiling hyper v0.12.36 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling chrono-tz-build v0.0.2 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Compiling unicode-segmentation v1.9.0 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking addr2line v0.17.0 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling paste v1.0.7 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Checking want v0.2.0 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking http-body v0.1.0 [INFO] [stderr] Checking simba v0.5.1 [INFO] [stderr] Checking h2 v0.1.26 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Compiling openssl-macros v0.1.0 [INFO] [stderr] Compiling chrono-tz v0.6.1 [INFO] [stderr] Compiling nalgebra-macros v0.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.31 [INFO] [stderr] Compiling newtype_derive v0.1.6 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Compiling anyhow v1.0.58 [INFO] [stderr] Compiling encoding_rs v0.8.31 [INFO] [stderr] Checking thiserror v1.0.31 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Compiling strum_macros v0.23.1 [INFO] [stderr] Compiling pest_generator v2.1.3 [INFO] [stderr] Checking publicsuffix v1.5.6 [INFO] [stderr] Compiling derive-new v0.5.9 [INFO] [stderr] Compiling enum-map-derive v0.6.0 [INFO] [stderr] Checking unic-ucd-segment v0.9.0 [INFO] [stderr] Checking cookie v0.12.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking try_from v0.3.2 [INFO] [stderr] Checking deunicode v0.4.3 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking os_str_bytes v6.1.0 [INFO] [stderr] Checking ucd-trie v0.1.3 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking bit-set v0.5.2 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking petgraph v0.6.2 [INFO] [stderr] Checking slug v0.1.4 [INFO] [stderr] Checking unic-segment v0.9.0 [INFO] [stderr] Checking pest v2.1.3 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking bio-types v0.12.1 [INFO] [stderr] Checking hyper-tls v0.3.2 [INFO] [stderr] Checking enum-map v1.1.1 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking uuid v0.7.4 [INFO] [stderr] Compiling getset v0.1.2 [INFO] [stderr] Checking ndarray v0.15.4 [INFO] [stderr] Checking ordered-float v1.1.1 [INFO] [stderr] Checking itertools-num v0.1.3 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking nalgebra v0.27.1 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking custom_derive v0.1.7 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking strum v0.23.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking triple_accel v0.4.0 [INFO] [stderr] Checking humansize v1.1.1 [INFO] [stderr] Checking bytecount v0.6.3 [INFO] [stderr] Checking clap v3.2.8 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking multimap v0.8.3 [INFO] [stderr] Checking serde_urlencoded v0.5.5 [INFO] [stderr] Checking bv v0.11.1 [INFO] [stderr] Checking globset v0.4.9 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking cookie_store v0.7.0 [INFO] [stderr] Checking ignore v0.4.18 [INFO] [stderr] Checking reqwest v0.9.24 [INFO] [stderr] Checking globwalk v0.8.1 [INFO] [stderr] Checking tera v1.16.0 [INFO] [stderr] Checking statrs v0.15.0 [INFO] [stderr] Checking bio v0.41.0 [INFO] [stderr] Checking seqsample v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/process.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | let mut null_file = OpenOptions::new().write(true).open("/dev/null").unwrap(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/process.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return path.as_ref().to_string_lossy().to_string().is_empty(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return path.as_ref().to_string_lossy().to_string().is_empty(); [INFO] [stdout] 12 + path.as_ref().to_string_lossy().to_string().is_empty() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/process.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return true; [INFO] [stdout] 84 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/process.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | let whole_number: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `whole_number` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 46 ~ [INFO] [stdout] 47 | [INFO] [stdout] 48 ~ let whole_number: usize = if number < 1.0 { [INFO] [stdout] 49 | //Get proprotion [INFO] [stdout] 50 | let count: f32 = records3.count() as f32; [INFO] [stdout] 51 ~ (count * number) as usize [INFO] [stdout] 52 | } else { [INFO] [stdout] 53 ~ number as usize [INFO] [stdout] 54 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 39 | if !matches.value_of("store-background").is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `matches.value_of("store-background").is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/process.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | let mut null_file = OpenOptions::new().write(true).open("/dev/null").unwrap(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/process.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return path.as_ref().to_string_lossy().to_string().is_empty(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return path.as_ref().to_string_lossy().to_string().is_empty(); [INFO] [stdout] 12 + path.as_ref().to_string_lossy().to_string().is_empty() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/process.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return true; [INFO] [stdout] 84 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/process.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | let whole_number: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `whole_number` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 46 ~ [INFO] [stdout] 47 | [INFO] [stdout] 48 ~ let whole_number: usize = if number < 1.0 { [INFO] [stdout] 49 | //Get proprotion [INFO] [stdout] 50 | let count: f32 = records3.count() as f32; [INFO] [stdout] 51 ~ (count * number) as usize [INFO] [stdout] 52 | } else { [INFO] [stdout] 53 ~ number as usize [INFO] [stdout] 54 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 39 | if !matches.value_of("store-background").is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `matches.value_of("store-background").is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 36s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nalgebra v0.27.1, openssl v0.10.40 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "d849626cc21c701ec04357818705b1d9f6f69ee086afbb08f8627326312760aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d849626cc21c701ec04357818705b1d9f6f69ee086afbb08f8627326312760aa", kill_on_drop: false }` [INFO] [stdout] d849626cc21c701ec04357818705b1d9f6f69ee086afbb08f8627326312760aa