[INFO] fetching crate schema_guard_tokio 1.10.0... [INFO] linting schema_guard_tokio-1.10.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate schema_guard_tokio 1.10.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate schema_guard_tokio 1.10.0 [INFO] finished tweaking crates.io crate schema_guard_tokio 1.10.0 [INFO] tweaked toml for crates.io crate schema_guard_tokio 1.10.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate schema_guard_tokio 1.10.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate schema_guard_tokio 1.10.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded postgres-types v0.2.6 [INFO] [stderr] Downloaded tokio-postgres-rustls v0.12.0 [INFO] [stderr] Downloaded bcder v0.7.6 [INFO] [stderr] Downloaded bb8 v0.8.3 [INFO] [stderr] Downloaded bb8-postgres v0.8.1 [INFO] [stderr] Downloaded postgres v0.19.7 [INFO] [stderr] Downloaded slog v2.7.0 [INFO] [stderr] Downloaded x509-certificate v0.23.1 [INFO] [stderr] Downloaded tokio-postgres v0.7.10 [INFO] [stderr] Downloaded backtrace v0.3.72 [INFO] [stderr] Downloaded unicode-properties v0.1.1 [INFO] [stderr] Downloaded postgres-protocol v0.6.6 [INFO] [stderr] Downloaded yaml-validator v0.2.0 [INFO] [stderr] Downloaded redox_syscall v0.5.1 [INFO] [stderr] Downloaded async-trait v0.1.80 [INFO] [stderr] Downloaded object v0.35.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d83cce60d4f9d07846cf034a7d67b62cf0377e0fcde44962369f6977ccdb32e2 [INFO] running `Command { std: "docker" "start" "-a" "d83cce60d4f9d07846cf034a7d67b62cf0377e0fcde44962369f6977ccdb32e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d83cce60d4f9d07846cf034a7d67b62cf0377e0fcde44962369f6977ccdb32e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d83cce60d4f9d07846cf034a7d67b62cf0377e0fcde44962369f6977ccdb32e2", kill_on_drop: false }` [INFO] [stdout] d83cce60d4f9d07846cf034a7d67b62cf0377e0fcde44962369f6977ccdb32e2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4120f4cce2524425f50eaf73501fd6a69f5a4a705b92444156446017a417c41e [INFO] running `Command { std: "docker" "start" "-a" "4120f4cce2524425f50eaf73501fd6a69f5a4a705b92444156446017a417c41e", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling standback v0.2.17 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling const_fn v0.4.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling time v0.2.27 [INFO] [stderr] Checking unicode-properties v0.1.1 [INFO] [stderr] Compiling aws-lc-rs v1.16.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking stringprep v0.1.5 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Checking whoami v1.5.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking pem v3.0.6 [INFO] [stderr] Checking bcder v0.7.6 [INFO] [stderr] Compiling syn v2.0.116 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling slog v2.7.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling cc v1.2.56 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking postgres-protocol v0.6.6 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling aws-lc-sys v0.37.1 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling time-macros-impl v0.1.2 [INFO] [stderr] Checking time-macros v0.1.1 [INFO] [stderr] Checking postgres-types v0.2.6 [INFO] [stderr] Compiling zeroize_derive v1.4.3 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking rustls-pki-types v1.14.0 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Checking yaml-validator v0.2.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking x509-certificate v0.23.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking serde_json v1.0.117 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking bb8 v0.8.3 [INFO] [stderr] Checking tokio-postgres v0.7.10 [INFO] [stderr] Checking bb8-postgres v0.8.1 [INFO] [stderr] Checking postgres v0.19.7 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking tokio-postgres-rustls v0.12.0 [INFO] [stderr] Checking schema_guard_tokio v1.10.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:33:22 [INFO] [stdout] | [INFO] [stdout] 33 | static SCHEMA_YAML: &'static str = include_str!("schema.yaml"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/lib.rs:33:22 [INFO] [stdout] | [INFO] [stdout] 33 | static SCHEMA_YAML: &'static str = include_str!("schema.yaml"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/loader.rs:148:16 [INFO] [stdout] | [INFO] [stdout] 148 | if cs.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/loader.rs:162:32 [INFO] [stdout] | [INFO] [stdout] 162 | column_default: if column_def.len() > 0 { Some(column_def.into()) } else { None }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!column_def.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/loader.rs:148:16 [INFO] [stdout] | [INFO] [stdout] 148 | if cs.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cs.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/loader.rs:162:32 [INFO] [stdout] | [INFO] [stdout] 162 | column_default: if column_def.len() > 0 { Some(column_def.into()) } else { None }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!column_def.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/loader.rs:181:16 [INFO] [stdout] | [INFO] [stdout] 181 | if def.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!def.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/loader.rs:187:16 [INFO] [stdout] | [INFO] [stdout] 187 | if ssql.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ssql.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/loader.rs:188:17 [INFO] [stdout] | [INFO] [stdout] 188 | sql.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `sql.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/loader.rs:181:16 [INFO] [stdout] | [INFO] [stdout] 181 | if def.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!def.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/loader.rs:187:16 [INFO] [stdout] | [INFO] [stdout] 187 | if ssql.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ssql.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/loader.rs:188:17 [INFO] [stdout] | [INFO] [stdout] 188 | sql.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `sql.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/loader.rs:199:5 [INFO] [stdout] | [INFO] [stdout] 199 | let _ = load_info_pk(db_name, db, &mut data).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 199 - let _ = load_info_pk(db_name, db, &mut data).await?; [INFO] [stdout] 199 + load_info_pk(db_name, db, &mut data).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/loader.rs:199:5 [INFO] [stdout] | [INFO] [stdout] 199 | let _ = load_info_pk(db_name, db, &mut data).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 199 - let _ = load_info_pk(db_name, db, &mut data).await?; [INFO] [stdout] 199 + load_info_pk(db_name, db, &mut data).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/loader.rs:200:5 [INFO] [stdout] | [INFO] [stdout] 200 | let _ = load_info_idx(db_name, db, &mut data).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 200 - let _ = load_info_idx(db_name, db, &mut data).await?; [INFO] [stdout] 200 + load_info_idx(db_name, db, &mut data).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/loader.rs:200:5 [INFO] [stdout] | [INFO] [stdout] 200 | let _ = load_info_idx(db_name, db, &mut data).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 200 - let _ = load_info_idx(db_name, db, &mut data).await?; [INFO] [stdout] 200 + load_info_idx(db_name, db, &mut data).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/loader.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | let _ = load_info_fk(db_name, db, &mut data).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 201 - let _ = load_info_fk(db_name, db, &mut data).await?; [INFO] [stdout] 201 + load_info_fk(db_name, db, &mut data).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/loader.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | let _ = load_info_fk(db_name, db, &mut data).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 201 - let _ = load_info_fk(db_name, db, &mut data).await?; [INFO] [stdout] 201 + load_info_fk(db_name, db, &mut data).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/loader.rs:202:5 [INFO] [stdout] | [INFO] [stdout] 202 | let _ = load_info_tg(db_name, db, &mut data).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 202 - let _ = load_info_tg(db_name, db, &mut data).await?; [INFO] [stdout] 202 + load_info_tg(db_name, db, &mut data).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/loader.rs:202:5 [INFO] [stdout] | [INFO] [stdout] 202 | let _ = load_info_tg(db_name, db, &mut data).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 202 - let _ = load_info_tg(db_name, db, &mut data).await?; [INFO] [stdout] 202 + load_info_tg(db_name, db, &mut data).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/loader.rs:203:5 [INFO] [stdout] | [INFO] [stdout] 203 | let _ = load_info_grant(db_name, db, &mut data).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 203 - let _ = load_info_grant(db_name, db, &mut data).await?; [INFO] [stdout] 203 + load_info_grant(db_name, db, &mut data).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/loader.rs:203:5 [INFO] [stdout] | [INFO] [stdout] 203 | let _ = load_info_grant(db_name, db, &mut data).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 203 - let _ = load_info_grant(db_name, db, &mut data).await?; [INFO] [stdout] 203 + load_info_grant(db_name, db, &mut data).await?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/loader.rs:241:32 [INFO] [stdout] | [INFO] [stdout] 241 | let mut data_type = if udt_name.len() == 0 { data_type.to_string() } else { udt_name.to_string() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `udt_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/loader.rs:241:32 [INFO] [stdout] | [INFO] [stdout] 241 | let mut data_type = if udt_name.len() == 0 { data_type.to_string() } else { udt_name.to_string() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `udt_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/table.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | let ref vo = YcVO { column: c }; [INFO] [stdout] | ----^^^^^^---------------------- help: try: `let vo = &YcVO { column: c };` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] = note: `#[warn(clippy::toplevel_ref_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/table.rs:143:17 [INFO] [stdout] | [INFO] [stdout] 143 | let ref vo = YtVO { table: t }; [INFO] [stdout] | ----^^^^^^--------------------- help: try: `let vo = &YtVO { table: t };` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/table.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | let ref vo = YcVO { column: c }; [INFO] [stdout] | ----^^^^^^---------------------- help: try: `let vo = &YcVO { column: c };` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] = note: `#[warn(clippy::toplevel_ref_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/table.rs:143:17 [INFO] [stdout] | [INFO] [stdout] 143 | let ref vo = YtVO { table: t }; [INFO] [stdout] | ----^^^^^^--------------------- help: try: `let vo = &YtVO { table: t };` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:222:28 [INFO] [stdout] | [INFO] [stdout] 222 | if name.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/table.rs:223:36 [INFO] [stdout] | [INFO] [stdout] 223 | ... if let Err(_) = triggers.append(Trig::new(t)) { [INFO] [stdout] | -------^^^^^^-------------------------------- help: try: `if triggers.append(Trig::new(t)).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:222:28 [INFO] [stdout] | [INFO] [stdout] 222 | if name.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/table.rs:223:36 [INFO] [stdout] | [INFO] [stdout] 223 | ... if let Err(_) = triggers.append(Trig::new(t)) { [INFO] [stdout] | -------^^^^^^-------------------------------- help: try: `if triggers.append(Trig::new(t)).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/table.rs:349:50 [INFO] [stdout] | [INFO] [stdout] 349 | ... if def.pk && !pks.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `pks.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/table.rs:349:50 [INFO] [stdout] | [INFO] [stdout] 349 | ... if def.pk && !pks.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `pks.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:484:28 [INFO] [stdout] | [INFO] [stdout] 484 | if self.owner.len() > 0 && &self.owner != o { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.owner.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/table.rs:496:51 [INFO] [stdout] | [INFO] [stdout] 496 | ... let trigger_changed = existing_trigger.map_or(false, |ex| !dt.matches_pg_trigger(ex)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 496 - let trigger_changed = existing_trigger.map_or(false, |ex| !dt.matches_pg_trigger(ex)); [INFO] [stdout] 496 + let trigger_changed = existing_trigger.is_some_and(|ex| !dt.matches_pg_trigger(ex)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:484:28 [INFO] [stdout] | [INFO] [stdout] 484 | if self.owner.len() > 0 && &self.owner != o { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.owner.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/table.rs:496:51 [INFO] [stdout] | [INFO] [stdout] 496 | ... let trigger_changed = existing_trigger.map_or(false, |ex| !dt.matches_pg_trigger(ex)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 496 - let trigger_changed = existing_trigger.map_or(false, |ex| !dt.matches_pg_trigger(ex)); [INFO] [stdout] 496 + let trigger_changed = existing_trigger.is_some_and(|ex| !dt.matches_pg_trigger(ex)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: omit braces around single expression condition [INFO] [stdout] --> src/table.rs:607:12 [INFO] [stdout] | [INFO] [stdout] 607 | if { [INFO] [stdout] | ____________^ [INFO] [stdout] 608 | | match do_create { [INFO] [stdout] 609 | | CreateST::None => false, [INFO] [stdout] 610 | | _ => true [INFO] [stdout] 611 | | } [INFO] [stdout] 612 | | } { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_conditions [INFO] [stdout] = note: `#[warn(clippy::blocks_in_conditions)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 607 ~ if match do_create { [INFO] [stdout] 608 + CreateST::None => false, [INFO] [stdout] 609 + _ => true [INFO] [stdout] 610 ~ } { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/table.rs:608:13 [INFO] [stdout] | [INFO] [stdout] 608 | / match do_create { [INFO] [stdout] 609 | | CreateST::None => false, [INFO] [stdout] 610 | | _ => true [INFO] [stdout] 611 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 608 - match do_create { [INFO] [stdout] 609 - CreateST::None => false, [INFO] [stdout] 610 - _ => true [INFO] [stdout] 611 - } [INFO] [stdout] 608 + !matches!(do_create, CreateST::None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:637:27 [INFO] [stdout] | [INFO] [stdout] 637 | owner: if self.owner.len() > 0 { Some(self.owner.clone()) } else { None }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.owner.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: omit braces around single expression condition [INFO] [stdout] --> src/table.rs:607:12 [INFO] [stdout] | [INFO] [stdout] 607 | if { [INFO] [stdout] | ____________^ [INFO] [stdout] 608 | | match do_create { [INFO] [stdout] 609 | | CreateST::None => false, [INFO] [stdout] 610 | | _ => true [INFO] [stdout] 611 | | } [INFO] [stdout] 612 | | } { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_conditions [INFO] [stdout] = note: `#[warn(clippy::blocks_in_conditions)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 607 ~ if match do_create { [INFO] [stdout] 608 + CreateST::None => false, [INFO] [stdout] 609 + _ => true [INFO] [stdout] 610 ~ } { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:672:24 [INFO] [stdout] | [INFO] [stdout] 672 | if self.owner.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.owner.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/table.rs:608:13 [INFO] [stdout] | [INFO] [stdout] 608 | / match do_create { [INFO] [stdout] 609 | | CreateST::None => false, [INFO] [stdout] 610 | | _ => true [INFO] [stdout] 611 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 608 - match do_create { [INFO] [stdout] 609 - CreateST::None => false, [INFO] [stdout] 610 - _ => true [INFO] [stdout] 611 - } [INFO] [stdout] 608 + !matches!(do_create, CreateST::None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/table.rs:675:29 [INFO] [stdout] | [INFO] [stdout] 675 | let _ = write!(sql, ";\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 675 - let _ = write!(sql, ";\n"); [INFO] [stdout] 675 + let _ = writeln!(sql, ";"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:637:27 [INFO] [stdout] | [INFO] [stdout] 637 | owner: if self.owner.len() > 0 { Some(self.owner.clone()) } else { None }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.owner.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:692:35 [INFO] [stdout] | [INFO] [stdout] 692 | ... if self.constraint.len() > 0 { ", " } else { "" }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.constraint.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:699:16 [INFO] [stdout] | [INFO] [stdout] 699 | if self.owner.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.owner.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:672:24 [INFO] [stdout] | [INFO] [stdout] 672 | if self.owner.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.owner.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/table.rs:675:29 [INFO] [stdout] | [INFO] [stdout] 675 | let _ = write!(sql, ";\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 675 - let _ = write!(sql, ";\n"); [INFO] [stdout] 675 + let _ = writeln!(sql, ";"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/table.rs:719:9 [INFO] [stdout] | [INFO] [stdout] 719 | / if exec { [INFO] [stdout] 720 | | if self.description.len() > 0 { [INFO] [stdout] 721 | | let _ = writeln!( [INFO] [stdout] 722 | | comments, [INFO] [stdout] ... | [INFO] [stdout] 728 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 719 ~ if exec [INFO] [stdout] 720 ~ && self.description.len() > 0 { [INFO] [stdout] 721 | let _ = writeln!( [INFO] [stdout] ... [INFO] [stdout] 725 | ); [INFO] [stdout] 726 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:720:16 [INFO] [stdout] | [INFO] [stdout] 720 | if self.description.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.description.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:692:35 [INFO] [stdout] | [INFO] [stdout] 692 | ... if self.constraint.len() > 0 { ", " } else { "" }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.constraint.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:699:16 [INFO] [stdout] | [INFO] [stdout] 699 | if self.owner.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.owner.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/table.rs:753:25 [INFO] [stdout] | [INFO] [stdout] 753 | / let _ = db.batch_execute(sql.as_str()).await [INFO] [stdout] 754 | | .map_err(|e| Self::format_it("DB execute", sql, e, file))?; [INFO] [stdout] | |_______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 753 - let _ = db.batch_execute(sql.as_str()).await [INFO] [stdout] 753 + db.batch_execute(sql.as_str()).await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/table.rs:758:25 [INFO] [stdout] | [INFO] [stdout] 758 | / let _ = db.batch_execute(comments.as_str()).await [INFO] [stdout] 759 | | .map_err(|e| Self::format_it("DB execute comments", comments, e, file))?; [INFO] [stdout] | |_____________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 758 - let _ = db.batch_execute(comments.as_str()).await [INFO] [stdout] 758 + db.batch_execute(comments.as_str()).await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/table.rs:719:9 [INFO] [stdout] | [INFO] [stdout] 719 | / if exec { [INFO] [stdout] 720 | | if self.description.len() > 0 { [INFO] [stdout] 721 | | let _ = writeln!( [INFO] [stdout] 722 | | comments, [INFO] [stdout] ... | [INFO] [stdout] 728 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 719 ~ if exec [INFO] [stdout] 720 ~ && self.description.len() > 0 { [INFO] [stdout] 721 | let _ = writeln!( [INFO] [stdout] ... [INFO] [stdout] 725 | ); [INFO] [stdout] 726 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:720:16 [INFO] [stdout] | [INFO] [stdout] 720 | if self.description.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.description.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/table.rs:763:25 [INFO] [stdout] | [INFO] [stdout] 763 | / let _ = db.batch_execute(indexes_sql.as_str()).await [INFO] [stdout] 764 | | .map_err(|e| Self::format_it("DB execute indexes", indexes_sql, e, file))?; [INFO] [stdout] | |_______________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 763 - let _ = db.batch_execute(indexes_sql.as_str()).await [INFO] [stdout] 763 + db.batch_execute(indexes_sql.as_str()).await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/table.rs:768:25 [INFO] [stdout] | [INFO] [stdout] 768 | / let _ = db.batch_execute(grants_sql.as_str()).await [INFO] [stdout] 769 | | .map_err(|e| Self::format_it("DB execute grants", grants_sql, e, file))?; [INFO] [stdout] | |_____________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 768 - let _ = db.batch_execute(grants_sql.as_str()).await [INFO] [stdout] 768 + db.batch_execute(grants_sql.as_str()).await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/table.rs:773:25 [INFO] [stdout] | [INFO] [stdout] 773 | / let _ = db.batch_execute(data.as_str()).await [INFO] [stdout] 774 | | .map_err(|e| Self::format_it("DB execute data upserts", data, e, file))?; [INFO] [stdout] | |_____________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 773 - let _ = db.batch_execute(data.as_str()).await [INFO] [stdout] 773 + db.batch_execute(data.as_str()).await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/table.rs:753:25 [INFO] [stdout] | [INFO] [stdout] 753 | / let _ = db.batch_execute(sql.as_str()).await [INFO] [stdout] 754 | | .map_err(|e| Self::format_it("DB execute", sql, e, file))?; [INFO] [stdout] | |_______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 753 - let _ = db.batch_execute(sql.as_str()).await [INFO] [stdout] 753 + db.batch_execute(sql.as_str()).await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/table.rs:758:25 [INFO] [stdout] | [INFO] [stdout] 758 | / let _ = db.batch_execute(comments.as_str()).await [INFO] [stdout] 759 | | .map_err(|e| Self::format_it("DB execute comments", comments, e, file))?; [INFO] [stdout] | |_____________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 758 - let _ = db.batch_execute(comments.as_str()).await [INFO] [stdout] 758 + db.batch_execute(comments.as_str()).await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:784:20 [INFO] [stdout] | [INFO] [stdout] 784 | if file.len() > 0 { ", source: " } else { "" }, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!file.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/table.rs:763:25 [INFO] [stdout] | [INFO] [stdout] 763 | / let _ = db.batch_execute(indexes_sql.as_str()).await [INFO] [stdout] 764 | | .map_err(|e| Self::format_it("DB execute indexes", indexes_sql, e, file))?; [INFO] [stdout] | |_______________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 763 - let _ = db.batch_execute(indexes_sql.as_str()).await [INFO] [stdout] 763 + db.batch_execute(indexes_sql.as_str()).await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/table.rs:793:46 [INFO] [stdout] | [INFO] [stdout] 793 | fn insert(&self, data: &mut String, row: &Vec, schema: &String) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 793 - fn insert(&self, data: &mut String, row: &Vec, schema: &String) { [INFO] [stdout] 793 + fn insert(&self, data: &mut String, row: &[String], schema: &String) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `row` [INFO] [stdout] --> src/table.rs:797:18 [INFO] [stdout] | [INFO] [stdout] 797 | for i in 0..row.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 797 - for i in 0..row.len() { [INFO] [stdout] 797 + for (i, ) in row.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/table.rs:768:25 [INFO] [stdout] | [INFO] [stdout] 768 | / let _ = db.batch_execute(grants_sql.as_str()).await [INFO] [stdout] 769 | | .map_err(|e| Self::format_it("DB execute grants", grants_sql, e, file))?; [INFO] [stdout] | |_____________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 768 - let _ = db.batch_execute(grants_sql.as_str()).await [INFO] [stdout] 768 + db.batch_execute(grants_sql.as_str()).await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:800:20 [INFO] [stdout] | [INFO] [stdout] 800 | if pks.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!pks.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/table.rs:773:25 [INFO] [stdout] | [INFO] [stdout] 773 | / let _ = db.batch_execute(data.as_str()).await [INFO] [stdout] 774 | | .map_err(|e| Self::format_it("DB execute data upserts", data, e, file))?; [INFO] [stdout] | |_____________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 773 - let _ = db.batch_execute(data.as_str()).await [INFO] [stdout] 773 + db.batch_execute(data.as_str()).await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/table.rs:810:13 [INFO] [stdout] | [INFO] [stdout] 810 | vals.push_str("'"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `vals.push('\'')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/table.rs:812:13 [INFO] [stdout] | [INFO] [stdout] 812 | vals.push_str("'"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `vals.push('\'')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:784:20 [INFO] [stdout] | [INFO] [stdout] 784 | if file.len() > 0 { ", source: " } else { "" }, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!file.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:834:12 [INFO] [stdout] | [INFO] [stdout] 834 | if t.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!t.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/table.rs:793:46 [INFO] [stdout] | [INFO] [stdout] 793 | fn insert(&self, data: &mut String, row: &Vec, schema: &String) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 793 - fn insert(&self, data: &mut String, row: &Vec, schema: &String) { [INFO] [stdout] 793 + fn insert(&self, data: &mut String, row: &[String], schema: &String) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `row` [INFO] [stdout] --> src/table.rs:797:18 [INFO] [stdout] | [INFO] [stdout] 797 | for i in 0..row.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 797 - for i in 0..row.len() { [INFO] [stdout] 797 + for (i, ) in row.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:800:20 [INFO] [stdout] | [INFO] [stdout] 800 | if pks.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!pks.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/table.rs:810:13 [INFO] [stdout] | [INFO] [stdout] 810 | vals.push_str("'"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `vals.push('\'')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/table.rs:845:5 [INFO] [stdout] | [INFO] [stdout] 845 | / pub async fn deploy_fk( [INFO] [stdout] 846 | | &self, [INFO] [stdout] 847 | | // target: &FileVersion, [INFO] [stdout] 848 | | schemas: &OrderedHashMap, //FilesMap, [INFO] [stdout] ... | [INFO] [stdout] 854 | | dry_run: Option<&(dyn Fn(Vec) -> Result<(), String> + Send + Sync)>, [INFO] [stdout] 855 | | ) -> Result { [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/table.rs:812:13 [INFO] [stdout] | [INFO] [stdout] 812 | vals.push_str("'"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `vals.push('\'')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:834:12 [INFO] [stdout] | [INFO] [stdout] 834 | if t.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!t.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/table.rs:873:44 [INFO] [stdout] | [INFO] [stdout] 873 | ... if let Some(_) = b.fks.get(&dc.name) { [INFO] [stdout] | -------^^^^^^^---------------------- help: try: `if b.fks.get(&dc.name).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/table.rs:845:5 [INFO] [stdout] | [INFO] [stdout] 845 | / pub async fn deploy_fk( [INFO] [stdout] 846 | | &self, [INFO] [stdout] 847 | | // target: &FileVersion, [INFO] [stdout] 848 | | schemas: &OrderedHashMap, //FilesMap, [INFO] [stdout] ... | [INFO] [stdout] 854 | | dry_run: Option<&(dyn Fn(Vec) -> Result<(), String> + Send + Sync)>, [INFO] [stdout] 855 | | ) -> Result { [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:880:32 [INFO] [stdout] | [INFO] [stdout] 880 | ... if fk_columns.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!fk_columns.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:894:20 [INFO] [stdout] | [INFO] [stdout] 894 | let exec = fk_list.len() > 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!fk_list.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/table.rs:873:44 [INFO] [stdout] | [INFO] [stdout] 873 | ... if let Some(_) = b.fks.get(&dc.name) { [INFO] [stdout] | -------^^^^^^^---------------------- help: try: `if b.fks.get(&dc.name).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:880:32 [INFO] [stdout] | [INFO] [stdout] 880 | ... if fk_columns.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!fk_columns.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/table.rs:894:20 [INFO] [stdout] | [INFO] [stdout] 894 | let exec = fk_list.len() > 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!fk_list.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `parts.get(0)` [INFO] [stdout] --> src/table.rs:1143:29 [INFO] [stdout] | [INFO] [stdout] 1143 | let precision = parts.get(0).and_then(|s| s.trim().parse::().ok()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `parts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `parts.get(0)` [INFO] [stdout] --> src/table.rs:1143:29 [INFO] [stdout] | [INFO] [stdout] 1143 | let precision = parts.get(0).and_then(|s| s.trim().parse::().ok()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `parts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/table.rs:1244:44 [INFO] [stdout] | [INFO] [stdout] 1244 | ("varchar", Some(size)) => min_varchar_size.map_or(false, |min| size >= min), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1244 - ("varchar", Some(size)) => min_varchar_size.map_or(false, |min| size >= min), [INFO] [stdout] 1244 + ("varchar", Some(size)) => min_varchar_size.is_some_and(|min| size >= min), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/table.rs:1244:44 [INFO] [stdout] | [INFO] [stdout] 1244 | ("varchar", Some(size)) => min_varchar_size.map_or(false, |min| size >= min), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 1244 - ("varchar", Some(size)) => min_varchar_size.map_or(false, |min| size >= min), [INFO] [stdout] 1244 + ("varchar", Some(size)) => min_varchar_size.is_some_and(|min| size >= min), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/column.rs:115:40 [INFO] [stdout] | [INFO] [stdout] 115 | let (foreign_key, fk_set) = if references.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `references.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/column.rs:115:40 [INFO] [stdout] | [INFO] [stdout] 115 | let (foreign_key, fk_set) = if references.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `references.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/column.rs:164:63 [INFO] [stdout] | [INFO] [stdout] 164 | default_value: input["defaultValue"].as_str().map(|s| crate::utils::as_esc(s)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `crate::utils::as_esc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/column.rs:210:12 [INFO] [stdout] | [INFO] [stdout] 210 | if self.column_type.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.column_type.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/column.rs:164:63 [INFO] [stdout] | [INFO] [stdout] 164 | default_value: input["defaultValue"].as_str().map(|s| crate::utils::as_esc(s)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `crate::utils::as_esc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/column.rs:222:21 [INFO] [stdout] | [INFO] [stdout] 222 | pk: c.as_ref().map_or(false, |c| c.primary_key.unwrap_or(false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 222 - pk: c.as_ref().map_or(false, |c| c.primary_key.unwrap_or(false)), [INFO] [stdout] 222 + pk: c.as_ref().is_some_and(|c| c.primary_key.unwrap_or(false)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/column.rs:223:27 [INFO] [stdout] | [INFO] [stdout] 223 | nullable: c.as_ref().map_or(true, |c| c.nullable), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 223 - nullable: c.as_ref().map_or(true, |c| c.nullable), [INFO] [stdout] 223 + nullable: c.as_ref().is_none_or(|c| c.nullable), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value [INFO] [stdout] --> src/column.rs:224:21 [INFO] [stdout] | [INFO] [stdout] 224 | fk: c.map_or(None, |cs| cs.foreign_key [INFO] [stdout] | _____________________^ [INFO] [stdout] 225 | | .map_or(None, |fk| Some((fk.references.trim().into(), fk.sql.trim().into())))), [INFO] [stdout] | |__________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stdout] = note: `#[warn(clippy::option_map_or_none)]` on by default [INFO] [stdout] help: consider using `and_then` [INFO] [stdout] | [INFO] [stdout] 224 ~ fk: c.and_then(|cs| cs.foreign_key [INFO] [stdout] 225 ~ .map_or(None, |fk| Some((fk.references.trim().into(), fk.sql.trim().into())))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value [INFO] [stdout] --> src/column.rs:224:41 [INFO] [stdout] | [INFO] [stdout] 224 | fk: c.map_or(None, |cs| cs.foreign_key [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 225 | | .map_or(None, |fk| Some((fk.references.trim().into(), fk.sql.trim().into())))), [INFO] [stdout] | |_________________________________________________________________________________________________^ help: consider using `map`: `cs.foreign_key.map(|fk| (fk.references.trim().into(), fk.sql.trim().into()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/column.rs:210:12 [INFO] [stdout] | [INFO] [stdout] 210 | if self.column_type.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.column_type.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/column.rs:247:12 [INFO] [stdout] | [INFO] [stdout] 247 | if self.proc.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.proc.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/column.rs:222:21 [INFO] [stdout] | [INFO] [stdout] 222 | pk: c.as_ref().map_or(false, |c| c.primary_key.unwrap_or(false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 222 - pk: c.as_ref().map_or(false, |c| c.primary_key.unwrap_or(false)), [INFO] [stdout] 222 + pk: c.as_ref().is_some_and(|c| c.primary_key.unwrap_or(false)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/column.rs:223:27 [INFO] [stdout] | [INFO] [stdout] 223 | nullable: c.as_ref().map_or(true, |c| c.nullable), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 223 - nullable: c.as_ref().map_or(true, |c| c.nullable), [INFO] [stdout] 223 + nullable: c.as_ref().is_none_or(|c| c.nullable), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value [INFO] [stdout] --> src/column.rs:224:21 [INFO] [stdout] | [INFO] [stdout] 224 | fk: c.map_or(None, |cs| cs.foreign_key [INFO] [stdout] | _____________________^ [INFO] [stdout] 225 | | .map_or(None, |fk| Some((fk.references.trim().into(), fk.sql.trim().into())))), [INFO] [stdout] | |__________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stdout] = note: `#[warn(clippy::option_map_or_none)]` on by default [INFO] [stdout] help: consider using `and_then` [INFO] [stdout] | [INFO] [stdout] 224 ~ fk: c.and_then(|cs| cs.foreign_key [INFO] [stdout] 225 ~ .map_or(None, |fk| Some((fk.references.trim().into(), fk.sql.trim().into())))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value [INFO] [stdout] --> src/column.rs:224:41 [INFO] [stdout] | [INFO] [stdout] 224 | fk: c.map_or(None, |cs| cs.foreign_key [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 225 | | .map_or(None, |fk| Some((fk.references.trim().into(), fk.sql.trim().into())))), [INFO] [stdout] | |_________________________________________________________________________________________________^ help: consider using `map`: `cs.foreign_key.map(|fk| (fk.references.trim().into(), fk.sql.trim().into()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/column.rs:247:12 [INFO] [stdout] | [INFO] [stdout] 247 | if self.proc.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.proc.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/index.rs:117:37 [INFO] [stdout] | [INFO] [stdout] 117 | for (_idx_name, desired) in &self.index_groups { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 117 - for (_idx_name, desired) in &self.index_groups { [INFO] [stdout] 117 + for desired in self.index_groups.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/index.rs:117:37 [INFO] [stdout] | [INFO] [stdout] 117 | for (_idx_name, desired) in &self.index_groups { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 117 - for (_idx_name, desired) in &self.index_groups { [INFO] [stdout] 117 + for desired in self.index_groups.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/grant.rs:62:71 [INFO] [stdout] | [INFO] [stdout] 62 | let entry = desired_grants.entry(grantee.clone()).or_insert_with(HashSet::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/grant.rs:62:71 [INFO] [stdout] | [INFO] [stdout] 62 | let entry = desired_grants.entry(grantee.clone()).or_insert_with(HashSet::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:16:16 [INFO] [stdout] | [INFO] [stdout] 16 | if val.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!val.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/utils.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | format!("{}", val) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `val.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:16:16 [INFO] [stdout] | [INFO] [stdout] 16 | if val.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!val.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/utils.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | format!("{}", val) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `val.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 88 | if input.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `OrderedHashMap` [INFO] [stdout] --> src/utils.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 126 | / pub fn new() -> Self { [INFO] [stdout] 127 | | OrderedHashMap { [INFO] [stdout] 128 | | map: Default::default(), [INFO] [stdout] 129 | | list: vec![], [INFO] [stdout] 130 | | } [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 124 + impl Default for OrderedHashMap { [INFO] [stdout] 125 + fn default() -> Self { [INFO] [stdout] 126 + Self::new() [INFO] [stdout] 127 + } [INFO] [stdout] 128 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 135 | if key_name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `key_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 88 | if input.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `OrderedHashMap` [INFO] [stdout] --> src/utils.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 126 | / pub fn new() -> Self { [INFO] [stdout] 127 | | OrderedHashMap { [INFO] [stdout] 128 | | map: Default::default(), [INFO] [stdout] 129 | | list: vec![], [INFO] [stdout] 130 | | } [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 124 + impl Default for OrderedHashMap { [INFO] [stdout] 125 + fn default() -> Self { [INFO] [stdout] 126 + Self::new() [INFO] [stdout] 127 + } [INFO] [stdout] 128 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 135 | if key_name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `key_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:115:50 [INFO] [stdout] | [INFO] [stdout] 115 | let cnt = migrate(schema, &mut tx, None, "", &opt).await?; [INFO] [stdout] | ^^^^ help: change this to: `opt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:115:50 [INFO] [stdout] | [INFO] [stdout] 115 | let cnt = migrate(schema, &mut tx, None, "", &opt).await?; [INFO] [stdout] | ^^^^ help: change this to: `opt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/lib.rs:167:13 [INFO] [stdout] | [INFO] [stdout] 167 | / let _ = yts.validate(&context, &doc) [INFO] [stdout] 168 | | .map_err(|err| {format!("Schema validation error: {}", err)})?; [INFO] [stdout] | |_______________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 167 - let _ = yts.validate(&context, &doc) [INFO] [stdout] 167 + yts.validate(&context, &doc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:185:50 [INFO] [stdout] | [INFO] [stdout] 185 | let mut ss = Schema::new(&s, file_name); [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/lib.rs:186:25 [INFO] [stdout] | [INFO] [stdout] 186 | let _ = ss.append(s)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 186 - let _ = ss.append(s)?; [INFO] [stdout] 186 + ss.append(s)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/lib.rs:167:13 [INFO] [stdout] | [INFO] [stdout] 167 | / let _ = yts.validate(&context, &doc) [INFO] [stdout] 168 | | .map_err(|err| {format!("Schema validation error: {}", err)})?; [INFO] [stdout] | |_______________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 167 - let _ = yts.validate(&context, &doc) [INFO] [stdout] 167 + yts.validate(&context, &doc) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `r.list.get(0).unwrap().tables.list.get(0)` [INFO] [stdout] --> src/lib.rs:215:17 [INFO] [stdout] | [INFO] [stdout] 215 | let t = r.list.get(0).unwrap().tables.list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `r.list.get(0).unwrap().tables.list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `r.list.get(0)` [INFO] [stdout] --> src/lib.rs:215:17 [INFO] [stdout] | [INFO] [stdout] 215 | let t = r.list.get(0).unwrap().tables.list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `r.list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:185:50 [INFO] [stdout] | [INFO] [stdout] 185 | let mut ss = Schema::new(&s, file_name); [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/lib.rs:186:25 [INFO] [stdout] | [INFO] [stdout] 186 | let _ = ss.append(s)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 186 - let _ = ss.append(s)?; [INFO] [stdout] 186 + ss.append(s)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `t.grant.get(0)` [INFO] [stdout] --> src/lib.rs:217:20 [INFO] [stdout] | [INFO] [stdout] 217 | assert_eq!(t.grant.get(0).unwrap().all.as_str(), "postgres"); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `t.grant.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `t.grant.get(0)` [INFO] [stdout] --> src/lib.rs:218:20 [INFO] [stdout] | [INFO] [stdout] 218 | assert_eq!(t.grant.get(0).unwrap().by.as_str(), ""); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `t.grant.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `t.data.get(0)` [INFO] [stdout] --> src/lib.rs:222:19 [INFO] [stdout] | [INFO] [stdout] 222 | let row = t.data.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `t.data.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `t.columns.list.get(0)` [INFO] [stdout] --> src/lib.rs:230:17 [INFO] [stdout] | [INFO] [stdout] 230 | let i = t.columns.list.get(0).unwrap().index.as_ref(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `t.columns.list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/utils.rs:201:18 [INFO] [stdout] | [INFO] [stdout] 201 | for v in vec!["true", "yes", "+", "Y", "OK", "ok"] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["true", "yes", "+", "Y", "OK", "ok"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/utils.rs:207:18 [INFO] [stdout] | [INFO] [stdout] 207 | for v in vec!["false", "no"] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["false", "no"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 43.62s [INFO] running `Command { std: "docker" "inspect" "4120f4cce2524425f50eaf73501fd6a69f5a4a705b92444156446017a417c41e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4120f4cce2524425f50eaf73501fd6a69f5a4a705b92444156446017a417c41e", kill_on_drop: false }` [INFO] [stdout] 4120f4cce2524425f50eaf73501fd6a69f5a4a705b92444156446017a417c41e