[INFO] fetching crate sayit 0.3.0... [INFO] linting sayit-0.3.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate sayit 0.3.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate sayit 0.3.0 [INFO] finished tweaking crates.io crate sayit 0.3.0 [INFO] tweaked toml for crates.io crate sayit 0.3.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate sayit 0.3.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate sayit 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded typetag-impl v0.2.16 [INFO] [stderr] Downloaded typetag v0.2.16 [INFO] [stderr] Downloaded clap_lex v0.2.4 [INFO] [stderr] Downloaded strsim v0.11.0 [INFO] [stderr] Downloaded erased-serde v0.4.3 [INFO] [stderr] Downloaded clap_derive v4.5.0 [INFO] [stderr] Downloaded clap v4.5.1 [INFO] [stderr] Downloaded serde_derive v1.0.197 [INFO] [stderr] Downloaded bumpalo v3.15.3 [INFO] [stderr] Downloaded criterion v0.4.0 [INFO] [stderr] Downloaded rayon v1.9.0 [INFO] [stderr] Downloaded serde v1.0.197 [INFO] [stderr] Downloaded clap_builder v4.5.1 [INFO] [stderr] Downloaded serde_json v1.0.114 [INFO] [stderr] Downloaded half v2.4.0 [INFO] [stderr] Downloaded clap v3.2.25 [INFO] [stderr] Downloaded os_str_bytes v6.6.1 [INFO] [stderr] Downloaded syn v2.0.52 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dc4d276a31339fb920d590946a5c6519ac0f06fd86b257d15040b1d1b12a3a9b [INFO] running `Command { std: "docker" "start" "-a" "dc4d276a31339fb920d590946a5c6519ac0f06fd86b257d15040b1d1b12a3a9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dc4d276a31339fb920d590946a5c6519ac0f06fd86b257d15040b1d1b12a3a9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc4d276a31339fb920d590946a5c6519ac0f06fd86b257d15040b1d1b12a3a9b", kill_on_drop: false }` [INFO] [stdout] dc4d276a31339fb920d590946a5c6519ac0f06fd86b257d15040b1d1b12a3a9b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8f3884a3b37a80c17ea8074ecb63d23a195419dc277a16f1467176f74bc13d82 [INFO] running `Command { std: "docker" "start" "-a" "8f3884a3b37a80c17ea8074ecb63d23a195419dc277a16f1467176f74bc13d82", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking half v2.4.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking inventory v0.3.15 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking rayon v1.9.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling typetag-impl v0.2.16 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking erased-serde v0.4.3 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking typetag v0.2.16 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.4.0 [INFO] [stderr] Checking sayit v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/pass.rs:64:75 [INFO] [stdout] | [INFO] [stdout] 64 | 'outer: for (new_regex, new_tag) in other.regexes.into_iter().zip(other.tags.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 64 - 'outer: for (new_regex, new_tag) in other.regexes.into_iter().zip(other.tags.into_iter()) { [INFO] [stdout] 64 + 'outer: for (new_regex, new_tag) in other.regexes.into_iter().zip(other.tags) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/utils.rs:89:17 [INFO] [stdout] | [INFO] [stdout] 89 | / if opened { [INFO] [stdout] 90 | | // pop '{' [INFO] [stdout] 91 | | result.pop(); [INFO] [stdout] 92 | | result.push_str(value); [INFO] [stdout] 93 | | formatted = true; [INFO] [stdout] 94 | | break; [INFO] [stdout] 95 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 88 ~ '}' [INFO] [stdout] 89 ~ if opened => { [INFO] [stdout] 90 | // pop '{' [INFO] [stdout] ... [INFO] [stdout] 94 | break; [INFO] [stdout] 95 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> benches/examples.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 36 | if !path.extension().is_some_and(|ext| ext == "ron") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `path.extension().is_none_or(|ext| ext != "ron")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/pass.rs:64:75 [INFO] [stdout] | [INFO] [stdout] 64 | 'outer: for (new_regex, new_tag) in other.regexes.into_iter().zip(other.tags.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 64 - 'outer: for (new_regex, new_tag) in other.regexes.into_iter().zip(other.tags.into_iter()) { [INFO] [stdout] 64 + 'outer: for (new_regex, new_tag) in other.regexes.into_iter().zip(other.tags) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tag_impls/literal.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | assert_eq!(PrecomputedLiteral::from("hello").chars().1, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 124 - assert_eq!(PrecomputedLiteral::from("hello").chars().1, true); [INFO] [stdout] 124 + assert!(PrecomputedLiteral::from("hello").chars().1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tag_impls/literal.rs:125:9 [INFO] [stdout] | [INFO] [stdout] 125 | assert_eq!(PrecomputedLiteral::from("Hello").chars().1, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 125 - assert_eq!(PrecomputedLiteral::from("Hello").chars().1, true); [INFO] [stdout] 125 + assert!(PrecomputedLiteral::from("Hello").chars().1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tag_impls/literal.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | assert_eq!(PrecomputedLiteral::from("1!@$#$").chars().1, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 126 - assert_eq!(PrecomputedLiteral::from("1!@$#$").chars().1, false); [INFO] [stdout] 126 + assert!(!PrecomputedLiteral::from("1!@$#$").chars().1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tag_impls/literal.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 127 | assert_eq!(PrecomputedLiteral::from("1!@$H#$").chars().1, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 127 - assert_eq!(PrecomputedLiteral::from("1!@$H#$").chars().1, false); [INFO] [stdout] 127 + assert!(!PrecomputedLiteral::from("1!@$H#$").chars().1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tag_impls/literal.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | assert_eq!(PrecomputedLiteral::from("1!@$Hh#$").chars().1, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 128 - assert_eq!(PrecomputedLiteral::from("1!@$Hh#$").chars().1, true); [INFO] [stdout] 128 + assert!(PrecomputedLiteral::from("1!@$Hh#$").chars().1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tag_impls/literal.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | assert_eq!(PrecomputedLiteral::from("привет").chars().1, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 129 - assert_eq!(PrecomputedLiteral::from("привет").chars().1, true); [INFO] [stdout] 129 + assert!(PrecomputedLiteral::from("привет").chars().1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tag_impls/literal.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | assert_eq!(PrecomputedLiteral::from("ПРИВЕТ").chars().1, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 130 - assert_eq!(PrecomputedLiteral::from("ПРИВЕТ").chars().1, false); [INFO] [stdout] 130 + assert!(!PrecomputedLiteral::from("ПРИВЕТ").chars().1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tag_impls/literal.rs:134:9 [INFO] [stdout] | [INFO] [stdout] 134 | assert_eq!(PrecomputedLiteral::from("hello").chars().2, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 134 - assert_eq!(PrecomputedLiteral::from("hello").chars().2, false); [INFO] [stdout] 134 + assert!(!PrecomputedLiteral::from("hello").chars().2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tag_impls/literal.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | assert_eq!(PrecomputedLiteral::from("Hello").chars().2, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 135 - assert_eq!(PrecomputedLiteral::from("Hello").chars().2, true); [INFO] [stdout] 135 + assert!(PrecomputedLiteral::from("Hello").chars().2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tag_impls/literal.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 136 | assert_eq!(PrecomputedLiteral::from("1!@$#$").chars().2, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 136 - assert_eq!(PrecomputedLiteral::from("1!@$#$").chars().2, false); [INFO] [stdout] 136 + assert!(!PrecomputedLiteral::from("1!@$#$").chars().2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tag_impls/literal.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | assert_eq!(PrecomputedLiteral::from("1!@$H#$").chars().2, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 137 - assert_eq!(PrecomputedLiteral::from("1!@$H#$").chars().2, true); [INFO] [stdout] 137 + assert!(PrecomputedLiteral::from("1!@$H#$").chars().2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tag_impls/literal.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | assert_eq!(PrecomputedLiteral::from("1!@$Hh#$").chars().2, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 138 - assert_eq!(PrecomputedLiteral::from("1!@$Hh#$").chars().2, true); [INFO] [stdout] 138 + assert!(PrecomputedLiteral::from("1!@$Hh#$").chars().2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tag_impls/literal.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | assert_eq!(PrecomputedLiteral::from("привет").chars().2, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 139 - assert_eq!(PrecomputedLiteral::from("привет").chars().2, false); [INFO] [stdout] 139 + assert!(!PrecomputedLiteral::from("привет").chars().2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tag_impls/literal.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | assert_eq!(PrecomputedLiteral::from("ПРИВЕТ").chars().2, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 140 - assert_eq!(PrecomputedLiteral::from("ПРИВЕТ").chars().2, true); [INFO] [stdout] 140 + assert!(PrecomputedLiteral::from("ПРИВЕТ").chars().2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::borrow::Cow<'_, str>` [INFO] [stdout] --> src/tag_impls/mod.rs:289:9 [INFO] [stdout] | [INFO] [stdout] 289 | tag.generate(&make_match(self_matching_pattern)).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `tag.generate(&make_match(self_matching_pattern))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/utils.rs:89:17 [INFO] [stdout] | [INFO] [stdout] 89 | / if opened { [INFO] [stdout] 90 | | // pop '{' [INFO] [stdout] 91 | | result.pop(); [INFO] [stdout] 92 | | result.push_str(value); [INFO] [stdout] 93 | | formatted = true; [INFO] [stdout] 94 | | break; [INFO] [stdout] 95 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 88 ~ '}' [INFO] [stdout] 89 ~ if opened => { [INFO] [stdout] 90 | // pop '{' [INFO] [stdout] ... [INFO] [stdout] 94 | break; [INFO] [stdout] 95 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/tag_impls/mod.rs:368:17 [INFO] [stdout] | [INFO] [stdout] 368 | assert!(vec!["bar", "baz"].contains(&selected.as_str())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["bar", "baz"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/tag_impls/mod.rs:276:28 [INFO] [stdout] | [INFO] [stdout] 276 | fn make_match(pattern: &str) -> Match { [INFO] [stdout] | ^^^^ ^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 276 | fn make_match(pattern: &str) -> Match<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [optimized + debuginfo] target(s) in 37.97s [INFO] running `Command { std: "docker" "inspect" "8f3884a3b37a80c17ea8074ecb63d23a195419dc277a16f1467176f74bc13d82", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f3884a3b37a80c17ea8074ecb63d23a195419dc277a16f1467176f74bc13d82", kill_on_drop: false }` [INFO] [stdout] 8f3884a3b37a80c17ea8074ecb63d23a195419dc277a16f1467176f74bc13d82