[INFO] fetching crate sansavision-pulse-control 0.4.0... [INFO] linting sansavision-pulse-control-0.4.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate sansavision-pulse-control 0.4.0 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate sansavision-pulse-control 0.4.0 [INFO] finished tweaking crates.io crate sansavision-pulse-control 0.4.0 [INFO] tweaked toml for crates.io crate sansavision-pulse-control 0.4.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate sansavision-pulse-control 0.4.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate sansavision-pulse-control 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.63 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.113 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.113 [INFO] [stderr] Downloaded sansavision-pulse-idl v0.4.0 [INFO] [stderr] Downloaded rand_xoshiro v0.7.0 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.113 [INFO] [stderr] Downloaded metrics v0.24.3 [INFO] [stderr] Downloaded metrics-exporter-prometheus v0.18.1 [INFO] [stderr] Downloaded metrics-util v0.20.1 [INFO] [stderr] Downloaded opentelemetry-otlp v0.31.0 [INFO] [stderr] Downloaded wasm-bindgen v0.2.113 [INFO] [stderr] Downloaded opentelemetry-http v0.31.0 [INFO] [stderr] Downloaded opentelemetry-proto v0.31.0 [INFO] [stderr] Downloaded js-sys v0.3.90 [INFO] [stderr] Downloaded web-sys v0.3.90 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ae304fb3d15c19af612ce977f9799af6314aacd8d31f10f3be6a934f256b5d85 [INFO] running `Command { std: "docker" "start" "-a" "ae304fb3d15c19af612ce977f9799af6314aacd8d31f10f3be6a934f256b5d85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ae304fb3d15c19af612ce977f9799af6314aacd8d31f10f3be6a934f256b5d85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae304fb3d15c19af612ce977f9799af6314aacd8d31f10f3be6a934f256b5d85", kill_on_drop: false }` [INFO] [stdout] ae304fb3d15c19af612ce977f9799af6314aacd8d31f10f3be6a934f256b5d85 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d0e5e7c3053438e47fbaa8980fe1526bd0fe04907810ba1f589008b33895145d [INFO] running `Command { std: "docker" "start" "-a" "d0e5e7c3053438e47fbaa8980fe1526bd0fe04907810ba1f589008b33895145d", kill_on_drop: false }` [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Compiling aws-lc-sys v0.37.1 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Compiling aws-lc-rs v1.16.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Compiling futures-core v0.3.32 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling yoke v0.8.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ring v0.17.14 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Compiling zerovec v0.11.5 [INFO] [stderr] Compiling zerotrie v0.2.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling rustls-pki-types v1.14.0 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling futures-sink v0.3.32 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Compiling socket2 v0.6.2 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Compiling mio v1.1.1 [INFO] [stderr] Compiling futures-task v0.3.32 [INFO] [stderr] Compiling tinystr v0.8.2 [INFO] [stderr] Compiling potential_utf v0.1.4 [INFO] [stderr] Compiling slab v0.4.12 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Compiling icu_locale_core v2.1.1 [INFO] [stderr] Compiling icu_collections v2.1.1 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Compiling webpki-roots v1.0.6 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking ff v0.13.1 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Compiling tokio v1.49.0 [INFO] [stderr] Compiling zerocopy v0.8.39 [INFO] [stderr] Compiling anyhow v1.0.102 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Compiling event-listener v5.4.1 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Compiling webpki-roots v0.26.11 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling crossbeam-queue v0.3.12 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling icu_provider v2.1.1 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling icu_properties v2.1.2 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling futures-channel v0.3.32 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Compiling rustls-webpki v0.103.9 [INFO] [stderr] Checking opentelemetry v0.31.0 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling itertools v0.14.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling icu_normalizer v2.1.1 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Compiling idna v1.1.0 [INFO] [stderr] Compiling ppv-lite86 v0.2.21 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Compiling unicode-properties v0.1.4 [INFO] [stderr] Compiling ryu v1.0.23 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Checking crc v3.4.0 [INFO] [stderr] Compiling stringprep v0.1.5 [INFO] [stderr] Compiling prost-derive v0.14.3 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Compiling flume v0.11.1 [INFO] [stderr] Compiling md-5 v0.10.6 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Compiling whoami v1.6.1 [INFO] [stderr] Compiling dotenvy v0.15.7 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Compiling bitflags v2.11.0 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Compiling time-macros v0.2.27 [INFO] [stderr] Checking deranged v0.5.8 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking unicode-normalization v0.1.25 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking raw-cpuid v11.6.0 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling getrandom v0.4.1 [INFO] [stderr] Checking num-bigint-dig v0.8.6 [INFO] [stderr] Checking metrics v0.24.3 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking rand_xoshiro v0.7.0 [INFO] [stderr] Compiling tokio-stream v0.1.18 [INFO] [stderr] Checking curve25519-dalek v4.1.3 [INFO] [stderr] Checking sketches-ddsketch v0.3.0 [INFO] [stderr] Checking home v0.5.12 [INFO] [stderr] Compiling metrics-exporter-prometheus v0.18.1 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking p384 v0.13.1 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking axum-core v0.5.6 [INFO] [stderr] Checking prost v0.14.3 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking matchit v0.8.4 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking uuid v1.21.0 [INFO] [stderr] Checking sansavision-pulse-idl v0.4.0 [INFO] [stderr] Checking quick-xml v0.37.5 [INFO] [stderr] Checking rsa v0.9.10 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Checking quanta v0.12.6 [INFO] [stderr] Checking tracing-opentelemetry v0.32.1 [INFO] [stderr] Checking metrics-util v0.20.1 [INFO] [stderr] Compiling sqlx-core v0.8.6 [INFO] [stderr] Checking simple_asn1 v0.6.4 [INFO] [stderr] Checking jsonwebtoken v10.3.0 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tonic v0.14.5 [INFO] [stderr] Checking opentelemetry_sdk v0.31.0 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking tonic-prost v0.14.5 [INFO] [stderr] Compiling sqlx-postgres v0.8.6 [INFO] [stderr] Checking opentelemetry-proto v0.31.0 [INFO] [stderr] Compiling sqlx-sqlite v0.8.6 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Compiling sqlx-macros-core v0.8.6 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking axum v0.8.8 [INFO] [stderr] Checking opentelemetry-http v0.31.0 [INFO] [stderr] Compiling sqlx-macros v0.8.6 [INFO] [stderr] Checking opentelemetry-otlp v0.31.0 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking rustls-platform-verifier v0.6.2 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.13.2 [INFO] [stderr] Checking sqlx v0.8.6 [INFO] [stderr] Checking sansavision-pulse-control v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/alerts.rs:333:13 [INFO] [stdout] | [INFO] [stdout] 333 | / if let Some(last) = self.last_fired_at_ms.get(&policy.id) { [INFO] [stdout] 334 | | if ts.saturating_sub(*last) < self.min_interval_ms { [INFO] [stdout] 335 | | continue; [INFO] [stdout] 336 | | } [INFO] [stdout] 337 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 333 ~ if let Some(last) = self.last_fired_at_ms.get(&policy.id) [INFO] [stdout] 334 ~ && ts.saturating_sub(*last) < self.min_interval_ms { [INFO] [stdout] 335 | continue; [INFO] [stdout] 336 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual checked division [INFO] [stdout] --> src/api.rs:518:25 [INFO] [stdout] | [INFO] [stdout] 518 | let avg_rtt_ms = if rtt_count > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ check performed here [INFO] [stdout] 519 | total_rtt / rtt_count [INFO] [stdout] | --------------------- division performed here [INFO] [stdout] | [INFO] [stdout] = help: consider using `checked_div` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_checked_ops [INFO] [stdout] = note: `#[warn(clippy::manual_checked_ops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/billing.rs:175:5 [INFO] [stdout] | [INFO] [stdout] 175 | / if let Some(email) = payload.customer_email.as_ref() { [INFO] [stdout] 176 | | if !email.trim().is_empty() { [INFO] [stdout] 177 | | form.push(("customer_email".to_string(), email.trim().to_string())); [INFO] [stdout] 178 | | } [INFO] [stdout] 179 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 175 ~ if let Some(email) = payload.customer_email.as_ref() [INFO] [stdout] 176 ~ && !email.trim().is_empty() { [INFO] [stdout] 177 | form.push(("customer_email".to_string(), email.trim().to_string())); [INFO] [stdout] 178 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/billing.rs:234:5 [INFO] [stdout] | [INFO] [stdout] 234 | / if let Some(customer) = body.get("customer").and_then(|v| v.as_str()) { [INFO] [stdout] 235 | | if !customer.is_empty() { [INFO] [stdout] 236 | | let mut store = app_state.billing.write().await; [INFO] [stdout] 237 | | store.stripe_customer_id = Some(customer.to_string()); [INFO] [stdout] 238 | | } [INFO] [stdout] 239 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 234 ~ if let Some(customer) = body.get("customer").and_then(|v| v.as_str()) [INFO] [stdout] 235 ~ && !customer.is_empty() { [INFO] [stdout] 236 | let mut store = app_state.billing.write().await; [INFO] [stdout] 237 | store.stripe_customer_id = Some(customer.to_string()); [INFO] [stdout] 238 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CacheLayer` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/cache.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | pub async fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ComplianceEngine` [INFO] [stdout] --> src/compliance.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 126 | / pub fn new() -> Self { [INFO] [stdout] 127 | | Self::new_with_config(ComplianceConfig::from_env()) [INFO] [stdout] 128 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 125 + impl Default for ComplianceEngine { [INFO] [stdout] 126 + fn default() -> Self { [INFO] [stdout] 127 + Self::new() [INFO] [stdout] 128 + } [INFO] [stdout] 129 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/alerts.rs:333:13 [INFO] [stdout] | [INFO] [stdout] 333 | / if let Some(last) = self.last_fired_at_ms.get(&policy.id) { [INFO] [stdout] 334 | | if ts.saturating_sub(*last) < self.min_interval_ms { [INFO] [stdout] 335 | | continue; [INFO] [stdout] 336 | | } [INFO] [stdout] 337 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 333 ~ if let Some(last) = self.last_fired_at_ms.get(&policy.id) [INFO] [stdout] 334 ~ && ts.saturating_sub(*last) < self.min_interval_ms { [INFO] [stdout] 335 | continue; [INFO] [stdout] 336 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual checked division [INFO] [stdout] --> src/api.rs:518:25 [INFO] [stdout] | [INFO] [stdout] 518 | let avg_rtt_ms = if rtt_count > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ check performed here [INFO] [stdout] 519 | total_rtt / rtt_count [INFO] [stdout] | --------------------- division performed here [INFO] [stdout] | [INFO] [stdout] = help: consider using `checked_div` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_checked_ops [INFO] [stdout] = note: `#[warn(clippy::manual_checked_ops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/billing.rs:175:5 [INFO] [stdout] | [INFO] [stdout] 175 | / if let Some(email) = payload.customer_email.as_ref() { [INFO] [stdout] 176 | | if !email.trim().is_empty() { [INFO] [stdout] 177 | | form.push(("customer_email".to_string(), email.trim().to_string())); [INFO] [stdout] 178 | | } [INFO] [stdout] 179 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 175 ~ if let Some(email) = payload.customer_email.as_ref() [INFO] [stdout] 176 ~ && !email.trim().is_empty() { [INFO] [stdout] 177 | form.push(("customer_email".to_string(), email.trim().to_string())); [INFO] [stdout] 178 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/persistence.rs:31:1 [INFO] [stdout] | [INFO] [stdout] 31 | / impl Default for StorageBackend { [INFO] [stdout] 32 | | fn default() -> Self { [INFO] [stdout] 33 | | Self::InMemory [INFO] [stdout] 34 | | } [INFO] [stdout] 35 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 21 + #[derive(Default)] [INFO] [stdout] 22 | pub enum StorageBackend { [INFO] [stdout] 23 | /// In-memory HashMap stores (default for dev/test). [INFO] [stdout] 24 ~ #[default] [INFO] [stdout] 25 ~ InMemory, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/billing.rs:234:5 [INFO] [stdout] | [INFO] [stdout] 234 | / if let Some(customer) = body.get("customer").and_then(|v| v.as_str()) { [INFO] [stdout] 235 | | if !customer.is_empty() { [INFO] [stdout] 236 | | let mut store = app_state.billing.write().await; [INFO] [stdout] 237 | | store.stripe_customer_id = Some(customer.to_string()); [INFO] [stdout] 238 | | } [INFO] [stdout] 239 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 234 ~ if let Some(customer) = body.get("customer").and_then(|v| v.as_str()) [INFO] [stdout] 235 ~ && !customer.is_empty() { [INFO] [stdout] 236 | let mut store = app_state.billing.write().await; [INFO] [stdout] 237 | store.stripe_customer_id = Some(customer.to_string()); [INFO] [stdout] 238 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `InMemoryStore` [INFO] [stdout] --> src/persistence.rs:148:5 [INFO] [stdout] | [INFO] [stdout] 148 | / pub fn new() -> Self { [INFO] [stdout] 149 | | Self { [INFO] [stdout] 150 | | data: Arc::new(RwLock::new(HashMap::new())), [INFO] [stdout] 151 | | } [INFO] [stdout] 152 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 147 + impl Default for InMemoryStore { [INFO] [stdout] 148 + fn default() -> Self { [INFO] [stdout] 149 + Self::new() [INFO] [stdout] 150 + } [INFO] [stdout] 151 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `CacheLayer` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/cache.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 89 | pub async fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ComplianceEngine` [INFO] [stdout] --> src/compliance.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 126 | / pub fn new() -> Self { [INFO] [stdout] 127 | | Self::new_with_config(ComplianceConfig::from_env()) [INFO] [stdout] 128 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 125 + impl Default for ComplianceEngine { [INFO] [stdout] 126 + fn default() -> Self { [INFO] [stdout] 127 + Self::new() [INFO] [stdout] 128 + } [INFO] [stdout] 129 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/schema_registry.rs:41:1 [INFO] [stdout] | [INFO] [stdout] 41 | / impl Default for CompatibilityMode { [INFO] [stdout] 42 | | fn default() -> Self { [INFO] [stdout] 43 | | CompatibilityMode::Backward [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 30 + #[derive(Default)] [INFO] [stdout] 31 | pub enum CompatibilityMode { [INFO] [stdout] 32 | /// No compatibility checks (allow any change). [INFO] [stdout] 33 | None, [INFO] [stdout] 34 | /// New schema can read data written by old schema. [INFO] [stdout] 35 ~ #[default] [INFO] [stdout] 36 ~ Backward, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sso.rs:520:5 [INFO] [stdout] | [INFO] [stdout] 520 | / if let Some(ref issuer) = attrs.issuer { [INFO] [stdout] 521 | | if issuer != expected_entity_id { [INFO] [stdout] 522 | | return Err(SamlParseError::InvalidIssuer); [INFO] [stdout] 523 | | } [INFO] [stdout] 524 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 520 ~ if let Some(ref issuer) = attrs.issuer [INFO] [stdout] 521 ~ && issuer != expected_entity_id { [INFO] [stdout] 522 | return Err(SamlParseError::InvalidIssuer); [INFO] [stdout] 523 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sso.rs:531:5 [INFO] [stdout] | [INFO] [stdout] 531 | / if attrs.email.is_none() { [INFO] [stdout] 532 | | if let Some(ref nid) = attrs.name_id { [INFO] [stdout] 533 | | if nid.contains('@') { [INFO] [stdout] 534 | | attrs.email = Some(nid.clone()); [INFO] [stdout] ... | [INFO] [stdout] 539 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 531 ~ if attrs.email.is_none() [INFO] [stdout] 532 ~ && let Some(ref nid) = attrs.name_id { [INFO] [stdout] 533 | if nid.contains('@') { [INFO] [stdout] ... [INFO] [stdout] 537 | } [INFO] [stdout] 538 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/persistence.rs:31:1 [INFO] [stdout] | [INFO] [stdout] 31 | / impl Default for StorageBackend { [INFO] [stdout] 32 | | fn default() -> Self { [INFO] [stdout] 33 | | Self::InMemory [INFO] [stdout] 34 | | } [INFO] [stdout] 35 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 21 + #[derive(Default)] [INFO] [stdout] 22 | pub enum StorageBackend { [INFO] [stdout] 23 | /// In-memory HashMap stores (default for dev/test). [INFO] [stdout] 24 ~ #[default] [INFO] [stdout] 25 ~ InMemory, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `InMemoryStore` [INFO] [stdout] --> src/persistence.rs:148:5 [INFO] [stdout] | [INFO] [stdout] 148 | / pub fn new() -> Self { [INFO] [stdout] 149 | | Self { [INFO] [stdout] 150 | | data: Arc::new(RwLock::new(HashMap::new())), [INFO] [stdout] 151 | | } [INFO] [stdout] 152 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 147 + impl Default for InMemoryStore { [INFO] [stdout] 148 + fn default() -> Self { [INFO] [stdout] 149 + Self::new() [INFO] [stdout] 150 + } [INFO] [stdout] 151 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/schema_registry.rs:41:1 [INFO] [stdout] | [INFO] [stdout] 41 | / impl Default for CompatibilityMode { [INFO] [stdout] 42 | | fn default() -> Self { [INFO] [stdout] 43 | | CompatibilityMode::Backward [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 30 + #[derive(Default)] [INFO] [stdout] 31 | pub enum CompatibilityMode { [INFO] [stdout] 32 | /// No compatibility checks (allow any change). [INFO] [stdout] 33 | None, [INFO] [stdout] 34 | /// New schema can read data written by old schema. [INFO] [stdout] 35 ~ #[default] [INFO] [stdout] 36 ~ Backward, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sso.rs:520:5 [INFO] [stdout] | [INFO] [stdout] 520 | / if let Some(ref issuer) = attrs.issuer { [INFO] [stdout] 521 | | if issuer != expected_entity_id { [INFO] [stdout] 522 | | return Err(SamlParseError::InvalidIssuer); [INFO] [stdout] 523 | | } [INFO] [stdout] 524 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 520 ~ if let Some(ref issuer) = attrs.issuer [INFO] [stdout] 521 ~ && issuer != expected_entity_id { [INFO] [stdout] 522 | return Err(SamlParseError::InvalidIssuer); [INFO] [stdout] 523 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/sso.rs:531:5 [INFO] [stdout] | [INFO] [stdout] 531 | / if attrs.email.is_none() { [INFO] [stdout] 532 | | if let Some(ref nid) = attrs.name_id { [INFO] [stdout] 533 | | if nid.contains('@') { [INFO] [stdout] 534 | | attrs.email = Some(nid.clone()); [INFO] [stdout] ... | [INFO] [stdout] 539 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 531 ~ if attrs.email.is_none() [INFO] [stdout] 532 ~ && let Some(ref nid) = attrs.name_id { [INFO] [stdout] 533 | if nid.contains('@') { [INFO] [stdout] ... [INFO] [stdout] 537 | } [INFO] [stdout] 538 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 37s [INFO] running `Command { std: "docker" "inspect" "d0e5e7c3053438e47fbaa8980fe1526bd0fe04907810ba1f589008b33895145d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d0e5e7c3053438e47fbaa8980fe1526bd0fe04907810ba1f589008b33895145d", kill_on_drop: false }` [INFO] [stdout] d0e5e7c3053438e47fbaa8980fe1526bd0fe04907810ba1f589008b33895145d