[INFO] fetching crate salt-compressor 0.4.0... [INFO] linting salt-compressor-0.4.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate salt-compressor 0.4.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate salt-compressor 0.4.0 [INFO] finished tweaking crates.io crate salt-compressor 0.4.0 [INFO] tweaked toml for crates.io crate salt-compressor 0.4.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate salt-compressor 0.4.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 43 packages to latest compatible versions [INFO] [stderr] Adding clap v2.34.0 (available: v4.6.0) [INFO] [stderr] Adding colored v1.9.4 (available: v3.1.1) [INFO] [stderr] Adding log v0.3.9 (available: v0.4.29) [INFO] [stderr] Adding loggerv v0.3.0 (available: v0.7.2) [INFO] [stderr] Adding regex v0.2.11 (available: v1.12.3) [INFO] [stderr] Adding time v0.1.45 (available: v0.3.47) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (available: v0.10.2+wasi-snapshot-preview1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded loggerv v0.3.0 [INFO] [stderr] Downloaded yaml-rust v0.3.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7191f6b118a5b9fe427084b1b77b69430dd14606ded05991a85ba8d9b624493b [INFO] running `Command { std: "docker" "start" "-a" "7191f6b118a5b9fe427084b1b77b69430dd14606ded05991a85ba8d9b624493b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7191f6b118a5b9fe427084b1b77b69430dd14606ded05991a85ba8d9b624493b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7191f6b118a5b9fe427084b1b77b69430dd14606ded05991a85ba8d9b624493b", kill_on_drop: false }` [INFO] [stdout] 7191f6b118a5b9fe427084b1b77b69430dd14606ded05991a85ba8d9b624493b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c92fbac365911554c5ce01e2cafaa0f49e4d80472687863304c882d8b7edb063 [INFO] running `Command { std: "docker" "start" "-a" "c92fbac365911554c5ce01e2cafaa0f49e4d80472687863304c882d8b7edb063", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking ucd-util v0.1.10 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking ansi_term v0.9.0 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking colored v1.9.4 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking loggerv v0.3.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking salt-compressor v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:268:34 [INFO] [stdout] | [INFO] [stdout] 268 | ... result: result, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:269:34 [INFO] [stdout] | [INFO] [stdout] 269 | ... retcode: retcode, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `retcode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:278:34 [INFO] [stdout] | [INFO] [stdout] 278 | ... retcode: retcode, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `retcode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:294:34 [INFO] [stdout] | [INFO] [stdout] 294 | ... retcode: retcode, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `retcode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:339:38 [INFO] [stdout] | [INFO] [stdout] 339 | ... output: output, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:340:38 [INFO] [stdout] | [INFO] [stdout] 340 | ... result: result, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:350:26 [INFO] [stdout] | [INFO] [stdout] 350 | host: host, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:268:34 [INFO] [stdout] | [INFO] [stdout] 268 | ... result: result, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:269:34 [INFO] [stdout] | [INFO] [stdout] 269 | ... retcode: retcode, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `retcode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:278:34 [INFO] [stdout] | [INFO] [stdout] 278 | ... retcode: retcode, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `retcode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:294:34 [INFO] [stdout] | [INFO] [stdout] 294 | ... retcode: retcode, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `retcode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:339:38 [INFO] [stdout] | [INFO] [stdout] 339 | ... output: output, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:340:38 [INFO] [stdout] | [INFO] [stdout] 340 | ... result: result, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:350:26 [INFO] [stdout] | [INFO] [stdout] 350 | host: host, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:407:31 [INFO] [stdout] | [INFO] [stdout] 407 | ... host: host, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `host` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/main.rs:70:1 [INFO] [stdout] | [INFO] [stdout] 70 | / impl Default for Retcode { [INFO] [stdout] 71 | | fn default() -> Retcode { [INFO] [stdout] 72 | | Retcode::Failure [INFO] [stdout] 73 | | } [INFO] [stdout] 74 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 42 + #[derive(Default)] [INFO] [stdout] 43 | enum Retcode { [INFO] [stdout] 44 | Success, [INFO] [stdout] 45 ~ #[default] [INFO] [stdout] 46 ~ Failure, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/main.rs:70:1 [INFO] [stdout] | [INFO] [stdout] 70 | / impl Default for Retcode { [INFO] [stdout] 71 | | fn default() -> Retcode { [INFO] [stdout] 72 | | Retcode::Failure [INFO] [stdout] 73 | | } [INFO] [stdout] 74 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 42 + #[derive(Default)] [INFO] [stdout] 43 | enum Retcode { [INFO] [stdout] 44 | Success, [INFO] [stdout] 45 ~ #[default] [INFO] [stdout] 46 ~ Failure, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:524:14 [INFO] [stdout] | [INFO] [stdout] 524 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:561:32 [INFO] [stdout] | [INFO] [stdout] 561 | if filter.unchanged && !result.output.is_some() && result.retcode.is_success() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `result.output.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result.result` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:643:34 [INFO] [stdout] | [INFO] [stdout] 641 | if result.result.is_some() { [INFO] [stdout] | -------------------------- help: try: `if let Some() = result.result` [INFO] [stdout] 642 | println!("{}", "RESULT:".yellow()); [INFO] [stdout] 643 | println!("{}\n", result.result.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result.output` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:648:29 [INFO] [stdout] | [INFO] [stdout] 647 | if result.output.is_some() { [INFO] [stdout] | -------------------------- help: try: `if let Some() = result.output` [INFO] [stdout] 648 | for line in result.output.unwrap().lines() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:596:9 [INFO] [stdout] | [INFO] [stdout] 596 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:598:9 [INFO] [stdout] | [INFO] [stdout] 598 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:668:5 [INFO] [stdout] | [INFO] [stdout] 668 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/main.rs:431:9 [INFO] [stdout] | [INFO] [stdout] 431 | / let mut expected = Vec::new(); [INFO] [stdout] 432 | | expected.push(MinionResult { [INFO] [stdout] 433 | | host: "minion".to_string(), [INFO] [stdout] 434 | | retcode: Retcode::Failure, [INFO] [stdout] 435 | | result: Some("line1\nline2\nline3".to_string()), [INFO] [stdout] 436 | | ..MinionResult::default() [INFO] [stdout] 437 | | }); [INFO] [stdout] | |_________________________^ help: consider using the `vec![]` macro: `let expected = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/main.rs:467:9 [INFO] [stdout] | [INFO] [stdout] 467 | / let mut expected = Vec::new(); [INFO] [stdout] 468 | | expected.push(MinionResult { [INFO] [stdout] 469 | | host: "minion".to_string(), [INFO] [stdout] 470 | | retcode: Retcode::Success, [INFO] [stdout] ... | [INFO] [stdout] 478 | | ..MinionResult::default() [INFO] [stdout] 479 | | }); [INFO] [stdout] | |_________________________^ help: consider using the `vec![]` macro: `let mut expected = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/main.rs:498:9 [INFO] [stdout] | [INFO] [stdout] 498 | / let mut expected = Vec::new(); [INFO] [stdout] 499 | | expected.push(MinionResult { [INFO] [stdout] 500 | | host: "minion".to_string(), [INFO] [stdout] 501 | | retcode: Retcode::Failure, [INFO] [stdout] 502 | | result: Some("line1\nline2\nline3".to_string()), [INFO] [stdout] 503 | | ..MinionResult::default() [INFO] [stdout] 504 | | }); [INFO] [stdout] | |_________________________^ help: consider using the `vec![]` macro: `let expected = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:524:14 [INFO] [stdout] | [INFO] [stdout] 524 | .or_insert_with(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:561:32 [INFO] [stdout] | [INFO] [stdout] 561 | if filter.unchanged && !result.output.is_some() && result.retcode.is_success() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `result.output.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result.result` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:643:34 [INFO] [stdout] | [INFO] [stdout] 641 | if result.result.is_some() { [INFO] [stdout] | -------------------------- help: try: `if let Some() = result.result` [INFO] [stdout] 642 | println!("{}", "RESULT:".yellow()); [INFO] [stdout] 643 | println!("{}\n", result.result.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result.output` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:648:29 [INFO] [stdout] | [INFO] [stdout] 647 | if result.output.is_some() { [INFO] [stdout] | -------------------------- help: try: `if let Some() = result.output` [INFO] [stdout] 648 | for line in result.output.unwrap().lines() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:596:9 [INFO] [stdout] | [INFO] [stdout] 596 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:598:9 [INFO] [stdout] | [INFO] [stdout] 598 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/main.rs:668:5 [INFO] [stdout] | [INFO] [stdout] 668 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:375:30 [INFO] [stdout] | [INFO] [stdout] 375 | Err(e) => panic!(format!("{}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 375 - Err(e) => panic!(format!("{}", e)), [INFO] [stdout] 375 + Err(e) => panic!("{}", e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/main.rs:453:30 [INFO] [stdout] | [INFO] [stdout] 453 | Err(e) => panic!(e), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 453 | Err(e) => panic!("{}", e), [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 453 - Err(e) => panic!(e), [INFO] [stdout] 453 + Err(e) => std::panic::panic_any(e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.98s [INFO] running `Command { std: "docker" "inspect" "c92fbac365911554c5ce01e2cafaa0f49e4d80472687863304c882d8b7edb063", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c92fbac365911554c5ce01e2cafaa0f49e4d80472687863304c882d8b7edb063", kill_on_drop: false }` [INFO] [stdout] c92fbac365911554c5ce01e2cafaa0f49e4d80472687863304c882d8b7edb063