[INFO] fetching crate s3ql 0.1.3... [INFO] linting s3ql-0.1.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate s3ql 0.1.3 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate s3ql 0.1.3 [INFO] finished tweaking crates.io crate s3ql 0.1.3 [INFO] tweaked toml for crates.io crate s3ql 0.1.3 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate s3ql 0.1.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 200 packages to latest compatible versions [INFO] [stderr] Adding rusoto_core v0.45.0 (available: v0.48.0) [INFO] [stderr] Adding rusoto_credential v0.45.0 (available: v0.48.0) [INFO] [stderr] Adding rusoto_s3 v0.45.0 (available: v0.48.0) [INFO] [stderr] Adding tokio v0.2.25 (available: v1.50.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rusoto_signature v0.45.0 [INFO] [stderr] Downloaded cargo-husky v1.5.0 [INFO] [stderr] Downloaded pin-project-internal v0.4.30 [INFO] [stderr] Downloaded pin-project v0.4.30 [INFO] [stderr] Downloaded rusoto_credential v0.45.0 [INFO] [stderr] Downloaded rusoto_core v0.45.0 [INFO] [stderr] Downloaded const_fn v0.4.12 [INFO] [stderr] Downloaded rusoto_s3 v0.45.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e33080246fff65dcc136498531b3f00ca61f063bb62a67f1353c6407631817b1 [INFO] running `Command { std: "docker" "start" "-a" "e33080246fff65dcc136498531b3f00ca61f063bb62a67f1353c6407631817b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e33080246fff65dcc136498531b3f00ca61f063bb62a67f1353c6407631817b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e33080246fff65dcc136498531b3f00ca61f063bb62a67f1353c6407631817b1", kill_on_drop: false }` [INFO] [stdout] e33080246fff65dcc136498531b3f00ca61f063bb62a67f1353c6407631817b1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a5c622698f12285e999464fb1a33e50cf1b6d5b8fc72c537dc768ca1d75a76ad [INFO] running `Command { std: "docker" "start" "-a" "a5c622698f12285e999464fb1a33e50cf1b6d5b8fc72c537dc768ca1d75a76ad", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking pin-project-lite v0.1.12 [INFO] [stderr] Compiling standback v0.2.17 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Compiling pin-project-internal v1.1.11 [INFO] [stderr] Compiling pin-project-internal v0.4.30 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Compiling const_fn v0.4.12 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking httpdate v0.3.2 [INFO] [stderr] Compiling time v0.2.27 [INFO] [stderr] Checking crypto-mac v0.8.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking shlex v0.1.1 [INFO] [stderr] Checking hmac v0.8.1 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Compiling cargo-husky v1.5.0 [INFO] [stderr] Checking http-body v0.3.1 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling rusoto_core v0.45.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking openssl-sys v0.9.112 [INFO] [stderr] Checking socket2 v0.3.19 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking pin-project v1.1.11 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking openssl v0.10.76 [INFO] [stderr] Compiling tokio-macros v0.2.6 [INFO] [stderr] Compiling time-macros-impl v0.1.2 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking tokio v0.2.25 [INFO] [stderr] Checking time-macros v0.1.1 [INFO] [stderr] Checking pin-project v0.4.30 [INFO] [stderr] Checking native-tls v0.2.18 [INFO] [stderr] Checking tokio-util v0.3.1 [INFO] [stderr] Checking tokio-tls v0.3.1 [INFO] [stderr] Checking h2 v0.2.7 [INFO] [stderr] Checking hyper v0.13.10 [INFO] [stderr] Checking rusoto_credential v0.45.0 [INFO] [stderr] Checking hyper-tls v0.4.3 [INFO] [stderr] Checking rusoto_signature v0.45.0 [INFO] [stderr] Checking rusoto_s3 v0.45.0 [INFO] [stderr] Checking s3ql v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/transact.rs:152:17 [INFO] [stdout] | [INFO] [stdout] 152 | metadata: metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/transact.rs:152:17 [INFO] [stdout] | [INFO] [stdout] 152 | metadata: metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/query.rs:139:17 [INFO] [stdout] | [INFO] [stdout] 139 | fn to_where(self) -> String { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.limit` after checking its variant with `is_some` [INFO] [stdout] --> src/query.rs:247:42 [INFO] [stdout] | [INFO] [stdout] 246 | if self.limit.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = self.limit` [INFO] [stdout] 247 | query = query + " LIMIT " + &self.limit.unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/query.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 237 | query = query + " FROM S3Object s"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `query += " FROM S3Object s"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `body` after checking its variant with `is_some` [INFO] [stdout] --> src/transact.rs:61:50 [INFO] [stdout] | [INFO] [stdout] 60 | if body.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = body` [INFO] [stdout] 61 | obj.body = Some(ByteStream::from(body.unwrap().as_bytes().to_vec())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `body` after checking its variant with `is_some` [INFO] [stdout] --> src/transact.rs:79:57 [INFO] [stdout] | [INFO] [stdout] 78 | if body.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = body` [INFO] [stdout] 79 | put_object.body = Some(ByteStream::from(body.unwrap().as_bytes().to_vec())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/query.rs:139:17 [INFO] [stdout] | [INFO] [stdout] 139 | fn to_where(self) -> String { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.limit` after checking its variant with `is_some` [INFO] [stdout] --> src/query.rs:247:42 [INFO] [stdout] | [INFO] [stdout] 246 | if self.limit.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = self.limit` [INFO] [stdout] 247 | query = query + " LIMIT " + &self.limit.unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/query.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 237 | query = query + " FROM S3Object s"; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `query += " FROM S3Object s"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `body` after checking its variant with `is_some` [INFO] [stdout] --> src/transact.rs:61:50 [INFO] [stdout] | [INFO] [stdout] 60 | if body.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = body` [INFO] [stdout] 61 | obj.body = Some(ByteStream::from(body.unwrap().as_bytes().to_vec())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `body` after checking its variant with `is_some` [INFO] [stdout] --> src/transact.rs:79:57 [INFO] [stdout] | [INFO] [stdout] 78 | if body.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = body` [INFO] [stdout] 79 | put_object.body = Some(ByteStream::from(body.unwrap().as_bytes().to_vec())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/query.rs:8:20 [INFO] [stdout] | [INFO] [stdout] 8 | pub const BUCKET: &'static str = "selectObjectsBucket"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/read.rs:4:20 [INFO] [stdout] | [INFO] [stdout] 4 | pub const BUCKET: &'static str = "readObjectsBucket"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/query.rs:8:20 [INFO] [stdout] | [INFO] [stdout] 8 | pub const BUCKET: &'static str = "selectObjectsBucket"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/read.rs:4:20 [INFO] [stdout] | [INFO] [stdout] 4 | pub const BUCKET: &'static str = "readObjectsBucket"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/transact.rs:9:20 [INFO] [stdout] | [INFO] [stdout] 9 | pub const BUCKET: &'static str = "transactObjectsBucket"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/transact.rs:10:27 [INFO] [stdout] | [INFO] [stdout] 10 | pub const UPDATE_BUCKET: &'static str = "updateTransactObjectsBucket"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/transact.rs:9:20 [INFO] [stdout] | [INFO] [stdout] 9 | pub const BUCKET: &'static str = "transactObjectsBucket"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> tests/transact.rs:10:27 [INFO] [stdout] | [INFO] [stdout] 10 | pub const UPDATE_BUCKET: &'static str = "updateTransactObjectsBucket"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/read.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if !s3 [INFO] [stdout] | ________^ [INFO] [stdout] 16 | | .has_s3_object(BUCKET.to_string(), "key1".to_string(), None, None, None) [INFO] [stdout] 17 | | .await [INFO] [stdout] 18 | | .is_ok() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 15 ~ if s3 [INFO] [stdout] 16 + .has_s3_object(BUCKET.to_string(), "key1".to_string(), None, None, None) [INFO] [stdout] 17 + .await.is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/read.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !s3 [INFO] [stdout] | ________^ [INFO] [stdout] 35 | | .has_s3_object(BUCKET.to_string(), "key2".to_string(), None, None, None) [INFO] [stdout] 36 | | .await [INFO] [stdout] 37 | | .is_ok() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 34 ~ if s3 [INFO] [stdout] 35 + .has_s3_object(BUCKET.to_string(), "key2".to_string(), None, None, None) [INFO] [stdout] 36 + .await.is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/read.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | if !s3 [INFO] [stdout] | ________^ [INFO] [stdout] 54 | | .has_s3_object(BUCKET.to_string(), "key3".to_string(), None, None, None) [INFO] [stdout] 55 | | .await [INFO] [stdout] 56 | | .is_ok() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 53 ~ if s3 [INFO] [stdout] 54 + .has_s3_object(BUCKET.to_string(), "key3".to_string(), None, None, None) [INFO] [stdout] 55 + .await.is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/read.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if !s3 [INFO] [stdout] | ________^ [INFO] [stdout] 16 | | .has_s3_object(BUCKET.to_string(), "key1".to_string(), None, None, None) [INFO] [stdout] 17 | | .await [INFO] [stdout] 18 | | .is_ok() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 15 ~ if s3 [INFO] [stdout] 16 + .has_s3_object(BUCKET.to_string(), "key1".to_string(), None, None, None) [INFO] [stdout] 17 + .await.is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/read.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 34 | if !s3 [INFO] [stdout] | ________^ [INFO] [stdout] 35 | | .has_s3_object(BUCKET.to_string(), "key2".to_string(), None, None, None) [INFO] [stdout] 36 | | .await [INFO] [stdout] 37 | | .is_ok() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 34 ~ if s3 [INFO] [stdout] 35 + .has_s3_object(BUCKET.to_string(), "key2".to_string(), None, None, None) [INFO] [stdout] 36 + .await.is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/read.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | if !s3 [INFO] [stdout] | ________^ [INFO] [stdout] 54 | | .has_s3_object(BUCKET.to_string(), "key3".to_string(), None, None, None) [INFO] [stdout] 55 | | .await [INFO] [stdout] 56 | | .is_ok() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 53 ~ if s3 [INFO] [stdout] 54 + .has_s3_object(BUCKET.to_string(), "key3".to_string(), None, None, None) [INFO] [stdout] 55 + .await.is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.95s [INFO] running `Command { std: "docker" "inspect" "a5c622698f12285e999464fb1a33e50cf1b6d5b8fc72c537dc768ca1d75a76ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5c622698f12285e999464fb1a33e50cf1b6d5b8fc72c537dc768ca1d75a76ad", kill_on_drop: false }` [INFO] [stdout] a5c622698f12285e999464fb1a33e50cf1b6d5b8fc72c537dc768ca1d75a76ad