[INFO] fetching crate rxr 0.1.11... [INFO] linting rxr-0.1.11 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rxr 0.1.11 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate rxr 0.1.11 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate rxr 0.1.11 [INFO] tweaked toml for crates.io crate rxr 0.1.11 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rxr 0.1.11 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate rxr 0.1.11 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tokio v1.44.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5160daedaa4ea68f3217880ddb17f0c78b2151113a9a4b68cfb7ac9ac17708ea [INFO] running `Command { std: "docker" "start" "-a" "5160daedaa4ea68f3217880ddb17f0c78b2151113a9a4b68cfb7ac9ac17708ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5160daedaa4ea68f3217880ddb17f0c78b2151113a9a4b68cfb7ac9ac17708ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5160daedaa4ea68f3217880ddb17f0c78b2151113a9a4b68cfb7ac9ac17708ea", kill_on_drop: false }` [INFO] [stdout] 5160daedaa4ea68f3217880ddb17f0c78b2151113a9a4b68cfb7ac9ac17708ea [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 51519338408c9879cb64811dd31edb743a48e161a75d513ac6542aac9e04bef1 [INFO] running `Command { std: "docker" "start" "-a" "51519338408c9879cb64811dd31edb743a48e161a75d513ac6542aac9e04bef1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Checking tokio v1.44.0 [INFO] [stderr] Checking rxr v0.1.11 (/opt/rustwide/workdir) [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/subscription/subscribe.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | /// the observable stream. [INFO] [stdout] | ^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/subscription/subscribe.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | /// the observable stream. [INFO] [stdout] | ^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> tests/register_emissions/mod.rs:5:43 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn register_emissions_subscriber() -> ( [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 6 | | Vec Subscriber>, [INFO] [stdout] 7 | | Arc>>, [INFO] [stdout] 8 | | Arc>>, [INFO] [stdout] 9 | | Arc>>, [INFO] [stdout] 10 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> tests/register_emissions/mod.rs:5:43 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn register_emissions_subscriber() -> ( [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 6 | | Vec Subscriber>, [INFO] [stdout] 7 | | Arc>>, [INFO] [stdout] 8 | | Arc>>, [INFO] [stdout] 9 | | Arc>>, [INFO] [stdout] 10 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> tests/register_emissions/mod.rs:5:43 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn register_emissions_subscriber() -> ( [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 6 | | Vec Subscriber>, [INFO] [stdout] 7 | | Arc>>, [INFO] [stdout] 8 | | Arc>>, [INFO] [stdout] 9 | | Arc>>, [INFO] [stdout] 10 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> tests/generate_observable/mod.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 33 | if *done.lock().unwrap() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*done.lock().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> tests/generate_observable/mod.rs:47:24 [INFO] [stdout] | [INFO] [stdout] 47 | if let Err(_) = tx.send(true) { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if tx.send(true).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> tests/generate_observable/mod.rs:79:20 [INFO] [stdout] | [INFO] [stdout] 79 | if *done.lock().unwrap() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*done.lock().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> tests/generate_observable/mod.rs:93:24 [INFO] [stdout] | [INFO] [stdout] 93 | if let Err(_) = tx.send(true).await { [INFO] [stdout] | -------^^^^^^---------------------- help: try: `if tx.send(true).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> tests/generate_observable/mod.rs:126:20 [INFO] [stdout] | [INFO] [stdout] 126 | if *done.lock().unwrap() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*done.lock().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> tests/generate_observable/mod.rs:142:24 [INFO] [stdout] | [INFO] [stdout] 142 | if let Err(_) = tx.send(true).await { [INFO] [stdout] | -------^^^^^^---------------------- help: try: `if tx.send(true).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> tests/register_emissions/mod.rs:5:43 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn register_emissions_subscriber() -> ( [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 6 | | Vec Subscriber>, [INFO] [stdout] 7 | | Arc>>, [INFO] [stdout] 8 | | Arc>>, [INFO] [stdout] 9 | | Arc>>, [INFO] [stdout] 10 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> tests/generate_observable/mod.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 33 | if *done.lock().unwrap() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*done.lock().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> tests/generate_observable/mod.rs:47:24 [INFO] [stdout] | [INFO] [stdout] 47 | if let Err(_) = tx.send(true) { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if tx.send(true).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> tests/generate_observable/mod.rs:79:20 [INFO] [stdout] | [INFO] [stdout] 79 | if *done.lock().unwrap() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*done.lock().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> tests/generate_observable/mod.rs:93:24 [INFO] [stdout] | [INFO] [stdout] 93 | if let Err(_) = tx.send(true).await { [INFO] [stdout] | -------^^^^^^---------------------- help: try: `if tx.send(true).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> tests/generate_observable/mod.rs:126:20 [INFO] [stdout] | [INFO] [stdout] 126 | if *done.lock().unwrap() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*done.lock().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> tests/generate_observable/mod.rs:142:24 [INFO] [stdout] | [INFO] [stdout] 142 | if let Err(_) = tx.send(true).await { [INFO] [stdout] | -------^^^^^^---------------------- help: try: `if tx.send(true).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> tests/generate_observable/mod.rs:33:20 [INFO] [stdout] | [INFO] [stdout] 33 | if *done.lock().unwrap() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*done.lock().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> tests/generate_observable/mod.rs:47:24 [INFO] [stdout] | [INFO] [stdout] 47 | if let Err(_) = tx.send(true) { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if tx.send(true).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> tests/generate_observable/mod.rs:79:20 [INFO] [stdout] | [INFO] [stdout] 79 | if *done.lock().unwrap() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*done.lock().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u32` [INFO] [stdout] --> tests/operators.rs:193:50 [INFO] [stdout] | [INFO] [stdout] 193 | let observable = generate_delayed_observable(end.try_into().unwrap(), 100, |_| {}); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> tests/generate_observable/mod.rs:93:24 [INFO] [stdout] | [INFO] [stdout] 93 | if let Err(_) = tx.send(true).await { [INFO] [stdout] | -------^^^^^^---------------------- help: try: `if tx.send(true).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> tests/generate_observable/mod.rs:126:20 [INFO] [stdout] | [INFO] [stdout] 126 | if *done.lock().unwrap() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*done.lock().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> tests/generate_observable/mod.rs:142:24 [INFO] [stdout] | [INFO] [stdout] 142 | if let Err(_) = tx.send(true).await { [INFO] [stdout] | -------^^^^^^---------------------- help: try: `if tx.send(true).await.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> tests/operators.rs:321:16 [INFO] [stdout] | [INFO] [stdout] 321 | if v.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/higher_order_operators.rs:285:13 [INFO] [stdout] | [INFO] [stdout] 285 | !(values_emitted_count > outer_o_max_count), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(values_emitted_count <= outer_o_max_count)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> tests/higher_order_operators.rs:185:33 [INFO] [stdout] | [INFO] [stdout] 185 | ... *ongoing_emissions3.lock().unwrap() == false, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!*ongoing_emissions3.lock().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> tests/operators.rs:507:9 [INFO] [stdout] | [INFO] [stdout] 507 | emitted.len() > 0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!emitted.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> tests/operators.rs:516:9 [INFO] [stdout] | [INFO] [stdout] 516 | *completed.lock().unwrap() == true, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*completed.lock().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> tests/operators.rs:546:9 [INFO] [stdout] | [INFO] [stdout] 546 | *completed.lock().unwrap() == true, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*completed.lock().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> tests/operators.rs:590:9 [INFO] [stdout] | [INFO] [stdout] 590 | *completed.lock().unwrap() == false, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!*completed.lock().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/operators.rs:658:57 [INFO] [stdout] | [INFO] [stdout] 658 | > as AsRef>>>::as_ref(&emitted.lock().unwrap().as_ref()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `emitted.lock().unwrap().as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/operators.rs:687:63 [INFO] [stdout] | [INFO] [stdout] 687 | > as AsRef>>>::as_ref(&emitted.lock().unwrap().as_ref()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `emitted.lock().unwrap().as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/higher_order_operators.rs:466:5 [INFO] [stdout] | [INFO] [stdout] 466 | / assert_eq!( [INFO] [stdout] 467 | | *all_notifeirs_unsubscribed.lock().unwrap(), [INFO] [stdout] 468 | | true, [INFO] [stdout] 469 | | "one or more duration observables failed to unsubscribe" [INFO] [stdout] 470 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 466 ~ assert!( [INFO] [stdout] 467 ~ *all_notifeirs_unsubscribed.lock().unwrap(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/higher_order_operators.rs:512:5 [INFO] [stdout] | [INFO] [stdout] 512 | / assert_eq!( [INFO] [stdout] 513 | | *all_notifeirs_unsubscribed.lock().unwrap(), [INFO] [stdout] 514 | | true, [INFO] [stdout] 515 | | "one or more duration observables failed to unsubscribe" [INFO] [stdout] 516 | | ); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 512 ~ assert!( [INFO] [stdout] 513 ~ *all_notifeirs_unsubscribed.lock().unwrap(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.08s [INFO] running `Command { std: "docker" "inspect" "51519338408c9879cb64811dd31edb743a48e161a75d513ac6542aac9e04bef1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "51519338408c9879cb64811dd31edb743a48e161a75d513ac6542aac9e04bef1", kill_on_drop: false }` [INFO] [stdout] 51519338408c9879cb64811dd31edb743a48e161a75d513ac6542aac9e04bef1