[INFO] fetching crate rxml_validation 0.12.0... [INFO] linting rxml_validation-0.12.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rxml_validation 0.12.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate rxml_validation 0.12.0 [INFO] finished tweaking crates.io crate rxml_validation 0.12.0 [INFO] tweaked toml for crates.io crate rxml_validation 0.12.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rxml_validation 0.12.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate rxml_validation 0.12.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 26e0f3afb9875c0b4f2332236f96aa1c999ea81f958eb671e7143b010ac33f92 [INFO] running `Command { std: "docker" "start" "-a" "26e0f3afb9875c0b4f2332236f96aa1c999ea81f958eb671e7143b010ac33f92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "26e0f3afb9875c0b4f2332236f96aa1c999ea81f958eb671e7143b010ac33f92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26e0f3afb9875c0b4f2332236f96aa1c999ea81f958eb671e7143b010ac33f92", kill_on_drop: false }` [INFO] [stdout] 26e0f3afb9875c0b4f2332236f96aa1c999ea81f958eb671e7143b010ac33f92 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d358a1d0c688aefccb3cfd54eaecd6b2cee17b0d10f5dc440e1dc4661db39d81 [INFO] running `Command { std: "docker" "start" "-a" "d358a1d0c688aefccb3cfd54eaecd6b2cee17b0d10f5dc440e1dc4661db39d81", kill_on_drop: false }` [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Checking compact_str v0.9.0 [INFO] [stderr] Checking rxml_validation v0.12.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/strings.rs:640:4 [INFO] [stdout] | [INFO] [stdout] 640 | / pub fn from_str(s: &str) -> Result<&Self, Error> { [INFO] [stdout] 641 | | s.try_into() [INFO] [stdout] 642 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] ... [INFO] [stdout] 876 | / rxml_custom_string_type_pair! { [INFO] [stdout] 877 | | /// String which conforms to the Name production of XML 1.0. [INFO] [stdout] 878 | | /// [INFO] [stdout] 879 | | /// [`Name`] corresponds to a (restricted) [`String`]. For a [`str`]-like type [INFO] [stdout] ... | [INFO] [stdout] 920 | | pub struct NameStr(str); [INFO] [stdout] 921 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] = note: this warning originates in the macro `rxml_custom_str_type` which comes from the expansion of the macro `rxml_custom_string_type_pair` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> src/strings.rs:733:28 [INFO] [stdout] | [INFO] [stdout] 733 | Ok(unsafe { core::mem::transmute(other) } ) [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&str, &strings::NameStr>` [INFO] [stdout] ... [INFO] [stdout] 876 | / rxml_custom_string_type_pair! { [INFO] [stdout] 877 | | /// String which conforms to the Name production of XML 1.0. [INFO] [stdout] 878 | | /// [INFO] [stdout] 879 | | /// [`Name`] corresponds to a (restricted) [`String`]. For a [`str`]-like type [INFO] [stdout] ... | [INFO] [stdout] 920 | | pub struct NameStr(str); [INFO] [stdout] 921 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] = note: this warning originates in the macro `rxml_custom_str_type` which comes from the expansion of the macro `rxml_custom_string_type_pair` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/strings.rs:640:4 [INFO] [stdout] | [INFO] [stdout] 640 | / pub fn from_str(s: &str) -> Result<&Self, Error> { [INFO] [stdout] 641 | | s.try_into() [INFO] [stdout] 642 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] ... [INFO] [stdout] 1072 | / rxml_custom_string_type_pair! { [INFO] [stdout] 1073 | | /// String which conforms to the NcName production of Namespaces in XML 1.0. [INFO] [stdout] 1074 | | /// [INFO] [stdout] 1075 | | /// [`NcName`] corresponds to a (restricted) [`String`]. For a [`str`]-like [INFO] [stdout] ... | [INFO] [stdout] 1108 | | pub struct NcNameStr(str); [INFO] [stdout] 1109 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: this warning originates in the macro `rxml_custom_str_type` which comes from the expansion of the macro `rxml_custom_string_type_pair` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> src/strings.rs:733:28 [INFO] [stdout] | [INFO] [stdout] 733 | Ok(unsafe { core::mem::transmute(other) } ) [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&str, &strings::NcNameStr>` [INFO] [stdout] ... [INFO] [stdout] 1072 | / rxml_custom_string_type_pair! { [INFO] [stdout] 1073 | | /// String which conforms to the NcName production of Namespaces in XML 1.0. [INFO] [stdout] 1074 | | /// [INFO] [stdout] 1075 | | /// [`NcName`] corresponds to a (restricted) [`String`]. For a [`str`]-like [INFO] [stdout] ... | [INFO] [stdout] 1108 | | pub struct NcNameStr(str); [INFO] [stdout] 1109 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: this warning originates in the macro `rxml_custom_str_type` which comes from the expansion of the macro `rxml_custom_string_type_pair` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:199:3 [INFO] [stdout] | [INFO] [stdout] 199 | / if b == 0xbe || b == 0xbf { [INFO] [stdout] 200 | | if i >= 2 && s[i - 2] == 0xef && s[i - 1] == 0xbf { [INFO] [stdout] 201 | | // U+FFFE or U+FFFF [INFO] [stdout] 202 | | let bit = (b & 0x01) as u32; [INFO] [stdout] ... | [INFO] [stdout] 209 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 199 ~ if (b == 0xbe || b == 0xbf) { [INFO] [stdout] 200 ~ && i >= 2 && s[i - 2] == 0xef && s[i - 1] == 0xbf { [INFO] [stdout] 201 | // U+FFFE or U+FFFF [INFO] [stdout] ... [INFO] [stdout] 207 | return Err(Error::InvalidChar(ch)); [INFO] [stdout] 208 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/strings.rs:640:4 [INFO] [stdout] | [INFO] [stdout] 640 | / pub fn from_str(s: &str) -> Result<&Self, Error> { [INFO] [stdout] 641 | | s.try_into() [INFO] [stdout] 642 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] ... [INFO] [stdout] 876 | / rxml_custom_string_type_pair! { [INFO] [stdout] 877 | | /// String which conforms to the Name production of XML 1.0. [INFO] [stdout] 878 | | /// [INFO] [stdout] 879 | | /// [`Name`] corresponds to a (restricted) [`String`]. For a [`str`]-like type [INFO] [stdout] ... | [INFO] [stdout] 920 | | pub struct NameStr(str); [INFO] [stdout] 921 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] = note: this warning originates in the macro `rxml_custom_str_type` which comes from the expansion of the macro `rxml_custom_string_type_pair` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> src/strings.rs:733:28 [INFO] [stdout] | [INFO] [stdout] 733 | Ok(unsafe { core::mem::transmute(other) } ) [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&str, &strings::NameStr>` [INFO] [stdout] ... [INFO] [stdout] 876 | / rxml_custom_string_type_pair! { [INFO] [stdout] 877 | | /// String which conforms to the Name production of XML 1.0. [INFO] [stdout] 878 | | /// [INFO] [stdout] 879 | | /// [`Name`] corresponds to a (restricted) [`String`]. For a [`str`]-like type [INFO] [stdout] ... | [INFO] [stdout] 920 | | pub struct NameStr(str); [INFO] [stdout] 921 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: `#[warn(clippy::missing_transmute_annotations)]` on by default [INFO] [stdout] = note: this warning originates in the macro `rxml_custom_str_type` which comes from the expansion of the macro `rxml_custom_string_type_pair` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/strings.rs:640:4 [INFO] [stdout] | [INFO] [stdout] 640 | / pub fn from_str(s: &str) -> Result<&Self, Error> { [INFO] [stdout] 641 | | s.try_into() [INFO] [stdout] 642 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] ... [INFO] [stdout] 1072 | / rxml_custom_string_type_pair! { [INFO] [stdout] 1073 | | /// String which conforms to the NcName production of Namespaces in XML 1.0. [INFO] [stdout] 1074 | | /// [INFO] [stdout] 1075 | | /// [`NcName`] corresponds to a (restricted) [`String`]. For a [`str`]-like [INFO] [stdout] ... | [INFO] [stdout] 1108 | | pub struct NcNameStr(str); [INFO] [stdout] 1109 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: this warning originates in the macro `rxml_custom_str_type` which comes from the expansion of the macro `rxml_custom_string_type_pair` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: transmute used without annotations [INFO] [stdout] --> src/strings.rs:733:28 [INFO] [stdout] | [INFO] [stdout] 733 | Ok(unsafe { core::mem::transmute(other) } ) [INFO] [stdout] | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&str, &strings::NcNameStr>` [INFO] [stdout] ... [INFO] [stdout] 1072 | / rxml_custom_string_type_pair! { [INFO] [stdout] 1073 | | /// String which conforms to the NcName production of Namespaces in XML 1.0. [INFO] [stdout] 1074 | | /// [INFO] [stdout] 1075 | | /// [`NcName`] corresponds to a (restricted) [`String`]. For a [`str`]-like [INFO] [stdout] ... | [INFO] [stdout] 1108 | | pub struct NcNameStr(str); [INFO] [stdout] 1109 | | } [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations [INFO] [stdout] = note: this warning originates in the macro `rxml_custom_str_type` which comes from the expansion of the macro `rxml_custom_string_type_pair` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/selectors.rs:177:8 [INFO] [stdout] | [INFO] [stdout] 177 | if !includer.select(ch) != excluder.select(ch) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `includer.select(ch) == excluder.select(ch)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:199:3 [INFO] [stdout] | [INFO] [stdout] 199 | / if b == 0xbe || b == 0xbf { [INFO] [stdout] 200 | | if i >= 2 && s[i - 2] == 0xef && s[i - 1] == 0xbf { [INFO] [stdout] 201 | | // U+FFFE or U+FFFF [INFO] [stdout] 202 | | let bit = (b & 0x01) as u32; [INFO] [stdout] ... | [INFO] [stdout] 209 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 199 ~ if (b == 0xbe || b == 0xbf) { [INFO] [stdout] 200 ~ && i >= 2 && s[i - 2] == 0xef && s[i - 1] == 0xbf { [INFO] [stdout] 201 | // U+FFFE or U+FFFF [INFO] [stdout] ... [INFO] [stdout] 207 | return Err(Error::InvalidChar(ch)); [INFO] [stdout] 208 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.03s [INFO] running `Command { std: "docker" "inspect" "d358a1d0c688aefccb3cfd54eaecd6b2cee17b0d10f5dc440e1dc4661db39d81", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d358a1d0c688aefccb3cfd54eaecd6b2cee17b0d10f5dc440e1dc4661db39d81", kill_on_drop: false }` [INFO] [stdout] d358a1d0c688aefccb3cfd54eaecd6b2cee17b0d10f5dc440e1dc4661db39d81