[INFO] fetching crate rxcalc 1.0.5... [INFO] linting rxcalc-1.0.5 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rxcalc 1.0.5 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate rxcalc 1.0.5 [INFO] finished tweaking crates.io crate rxcalc 1.0.5 [INFO] tweaked toml for crates.io crate rxcalc 1.0.5 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rxcalc 1.0.5 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate rxcalc 1.0.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0e760fd370279adcb95e34f9935ac67cdfe103712432e484b94adee9f742176d [INFO] running `Command { std: "docker" "start" "-a" "0e760fd370279adcb95e34f9935ac67cdfe103712432e484b94adee9f742176d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0e760fd370279adcb95e34f9935ac67cdfe103712432e484b94adee9f742176d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e760fd370279adcb95e34f9935ac67cdfe103712432e484b94adee9f742176d", kill_on_drop: false }` [INFO] [stdout] 0e760fd370279adcb95e34f9935ac67cdfe103712432e484b94adee9f742176d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 94cfe8750a2fd7a94deba78a3a9a9b8ba0bd9f5165f168b9d6df95f092d51c65 [INFO] running `Command { std: "docker" "start" "-a" "94cfe8750a2fd7a94deba78a3a9a9b8ba0bd9f5165f168b9d6df95f092d51c65", kill_on_drop: false }` [INFO] [stderr] Checking rxcalc v1.0.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: this pattern reimplements `Result::unwrap_or` [INFO] [stdout] --> src/rxcalc.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | / match num { [INFO] [stdout] 6 | | Ok(parsed_num) => parsed_num, [INFO] [stdout] 7 | | Err(_) => 0.0, [INFO] [stdout] 8 | | } [INFO] [stdout] | |_____^ help: replace with: `num.unwrap_or(0.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Result::unwrap_or` [INFO] [stdout] --> src/rxcalc.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | / match num { [INFO] [stdout] 6 | | Ok(parsed_num) => parsed_num, [INFO] [stdout] 7 | | Err(_) => 0.0, [INFO] [stdout] 8 | | } [INFO] [stdout] | |_____^ help: replace with: `num.unwrap_or(0.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/rxcalc.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / if trimmed_input.is_empty() [INFO] [stdout] 13 | | || trimmed_input == "0" [INFO] [stdout] 14 | | || trimmed_input.eq_ignore_ascii_case("false") [INFO] [stdout] ... | [INFO] [stdout] 18 | | true [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] help: you can reduce it to [INFO] [stdout] | [INFO] [stdout] 12 ~ !(trimmed_input.is_empty() [INFO] [stdout] 13 + || trimmed_input == "0" || trimmed_input.eq_ignore_ascii_case("false")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/rxcalc.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / if trimmed_input.is_empty() [INFO] [stdout] 13 | | || trimmed_input == "0" [INFO] [stdout] 14 | | || trimmed_input.eq_ignore_ascii_case("false") [INFO] [stdout] ... | [INFO] [stdout] 18 | | true [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] help: you can reduce it to [INFO] [stdout] | [INFO] [stdout] 12 ~ !(trimmed_input.is_empty() [INFO] [stdout] 13 + || trimmed_input == "0" || trimmed_input.eq_ignore_ascii_case("false")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:100:20 [INFO] [stdout] | [INFO] [stdout] 100 | if !(String::from(pm_12) == String::from(pm_14)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(String::from(pm_12) != String::from(pm_14))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:100:20 [INFO] [stdout] | [INFO] [stdout] 100 | if !(String::from(pm_12) == String::from(pm_14)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(String::from(pm_12) != String::from(pm_14))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:90:27 [INFO] [stdout] | [INFO] [stdout] 90 | if pm_13.contains(&"==") { [INFO] [stdout] | ^^^^^ help: change this to: `"=="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:90:27 [INFO] [stdout] | [INFO] [stdout] 90 | if pm_13.contains(&"==") { [INFO] [stdout] | ^^^^^ help: change this to: `"=="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:91:16 [INFO] [stdout] | [INFO] [stdout] 91 | if String::from(pm_12) == String::from(pm_14) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_12` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:91:16 [INFO] [stdout] | [INFO] [stdout] 91 | if String::from(pm_12) == String::from(pm_14) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_12` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:91:39 [INFO] [stdout] | [INFO] [stdout] 91 | if String::from(pm_12) == String::from(pm_14) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_14` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:91:39 [INFO] [stdout] | [INFO] [stdout] 91 | if String::from(pm_12) == String::from(pm_14) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_14` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:99:31 [INFO] [stdout] | [INFO] [stdout] 99 | if pm_13.contains(&"!=") { [INFO] [stdout] | ^^^^^ help: change this to: `"!="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:99:31 [INFO] [stdout] | [INFO] [stdout] 99 | if pm_13.contains(&"!=") { [INFO] [stdout] | ^^^^^ help: change this to: `"!="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:100:22 [INFO] [stdout] | [INFO] [stdout] 100 | if !(String::from(pm_12) == String::from(pm_14)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_12` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:100:45 [INFO] [stdout] | [INFO] [stdout] 100 | if !(String::from(pm_12) == String::from(pm_14)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_14` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:108:35 [INFO] [stdout] | [INFO] [stdout] 108 | if pm_13.contains(&"<") { [INFO] [stdout] | ^^^^ help: change this to: `"<"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:100:22 [INFO] [stdout] | [INFO] [stdout] 100 | if !(String::from(pm_12) == String::from(pm_14)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_12` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:100:45 [INFO] [stdout] | [INFO] [stdout] 100 | if !(String::from(pm_12) == String::from(pm_14)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_14` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:108:35 [INFO] [stdout] | [INFO] [stdout] 108 | if pm_13.contains(&"<") { [INFO] [stdout] | ^^^^ help: change this to: `"<"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:117:39 [INFO] [stdout] | [INFO] [stdout] 117 | if pm_13.contains(&">") { [INFO] [stdout] | ^^^^ help: change this to: `">"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:117:39 [INFO] [stdout] | [INFO] [stdout] 117 | if pm_13.contains(&">") { [INFO] [stdout] | ^^^^ help: change this to: `">"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:126:43 [INFO] [stdout] | [INFO] [stdout] 126 | if pm_13.contains(&"<=") { [INFO] [stdout] | ^^^^^ help: change this to: `"<="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:135:47 [INFO] [stdout] | [INFO] [stdout] 135 | ... if pm_13.contains(&">=") { [INFO] [stdout] | ^^^^^ help: change this to: `">="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:126:43 [INFO] [stdout] | [INFO] [stdout] 126 | if pm_13.contains(&"<=") { [INFO] [stdout] | ^^^^^ help: change this to: `"<="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:135:47 [INFO] [stdout] | [INFO] [stdout] 135 | ... if pm_13.contains(&">=") { [INFO] [stdout] | ^^^^^ help: change this to: `">="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:144:51 [INFO] [stdout] | [INFO] [stdout] 144 | ... if pm_13.contains(&"+") { [INFO] [stdout] | ^^^^ help: change this to: `"+"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:149:55 [INFO] [stdout] | [INFO] [stdout] 149 | ... if pm_13.contains(&"/") { [INFO] [stdout] | ^^^^ help: change this to: `"/"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:155:59 [INFO] [stdout] | [INFO] [stdout] 155 | ... if pm_13.contains(&"*") { [INFO] [stdout] | ^^^^ help: change this to: `"*"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:162:63 [INFO] [stdout] | [INFO] [stdout] 162 | ... if pm_13.contains(&"%") { [INFO] [stdout] | ^^^^ help: change this to: `"%"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:144:51 [INFO] [stdout] | [INFO] [stdout] 144 | ... if pm_13.contains(&"+") { [INFO] [stdout] | ^^^^ help: change this to: `"+"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:149:55 [INFO] [stdout] | [INFO] [stdout] 149 | ... if pm_13.contains(&"/") { [INFO] [stdout] | ^^^^ help: change this to: `"/"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:169:67 [INFO] [stdout] | [INFO] [stdout] 169 | ... if pm_13.contains(&"||") { [INFO] [stdout] | ^^^^^ help: change this to: `"||"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:155:59 [INFO] [stdout] | [INFO] [stdout] 155 | ... if pm_13.contains(&"*") { [INFO] [stdout] | ^^^^ help: change this to: `"*"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:188:71 [INFO] [stdout] | [INFO] [stdout] 188 | ... if pm_13.contains(&"&&") { [INFO] [stdout] | ^^^^^ help: change this to: `"&&"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:162:63 [INFO] [stdout] | [INFO] [stdout] 162 | ... if pm_13.contains(&"%") { [INFO] [stdout] | ^^^^ help: change this to: `"%"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:207:75 [INFO] [stdout] | [INFO] [stdout] 207 | ... if pm_13.contains(&"..") { [INFO] [stdout] | ^^^^^ help: change this to: `".."` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/rxcalc.rs:213:67 [INFO] [stdout] | [INFO] [stdout] 213 | ... + &pm_14.to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `pm_14` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:169:67 [INFO] [stdout] | [INFO] [stdout] 169 | ... if pm_13.contains(&"||") { [INFO] [stdout] | ^^^^^ help: change this to: `"||"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:215:79 [INFO] [stdout] | [INFO] [stdout] 215 | ... if pm_13.contains(&"^") { [INFO] [stdout] | ^^^^ help: change this to: `"^"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/rxcalc.rs:222:69 [INFO] [stdout] | [INFO] [stdout] 222 | / ... self.vf_1_6 = self.vf_1_6 [INFO] [stdout] 223 | | ... * get_f64_string(pm_12); [INFO] [stdout] | |_________________________________________________^ help: replace it with: `self.vf_1_6 *= get_f64_string(pm_12)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:188:71 [INFO] [stdout] | [INFO] [stdout] 188 | ... if pm_13.contains(&"&&") { [INFO] [stdout] | ^^^^^ help: change this to: `"&&"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:229:69 [INFO] [stdout] | [INFO] [stdout] 229 | ... if (String::from(pm_13) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_13` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:230:72 [INFO] [stdout] | [INFO] [stdout] 230 | ... == String::from("")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:207:75 [INFO] [stdout] | [INFO] [stdout] 207 | ... if pm_13.contains(&"..") { [INFO] [stdout] | ^^^^^ help: change this to: `".."` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/rxcalc.rs:213:67 [INFO] [stdout] | [INFO] [stdout] 213 | ... + &pm_14.to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `pm_14` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:231:73 [INFO] [stdout] | [INFO] [stdout] 231 | ... && (String::from(pm_14) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_14` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:232:76 [INFO] [stdout] | [INFO] [stdout] 232 | ... == String::from("")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:215:79 [INFO] [stdout] | [INFO] [stdout] 215 | ... if pm_13.contains(&"^") { [INFO] [stdout] | ^^^^ help: change this to: `"^"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/rxcalc.rs:222:69 [INFO] [stdout] | [INFO] [stdout] 222 | / ... self.vf_1_6 = self.vf_1_6 [INFO] [stdout] 223 | | ... * get_f64_string(pm_12); [INFO] [stdout] | |_________________________________________________^ help: replace it with: `self.vf_1_6 *= get_f64_string(pm_12)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/rxcalc.rs:264:65 [INFO] [stdout] | [INFO] [stdout] 264 | if let Some(position) = self.l_1_11.iter().position(|x| x == &value_to_find) { [INFO] [stdout] | ^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `value_to_find` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:229:69 [INFO] [stdout] | [INFO] [stdout] 229 | ... if (String::from(pm_13) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_13` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:230:72 [INFO] [stdout] | [INFO] [stdout] 230 | ... == String::from("")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:231:73 [INFO] [stdout] | [INFO] [stdout] 231 | ... && (String::from(pm_14) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_14` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:232:76 [INFO] [stdout] | [INFO] [stdout] 232 | ... == String::from("")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:283:21 [INFO] [stdout] | [INFO] [stdout] 283 | / &*(self.get_item_11( [INFO] [stdout] 284 | | if let Some(result) = [INFO] [stdout] 285 | | ((self.get_position_11("*") - 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 290 | | }, [INFO] [stdout] 291 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 283 ~ &(self.get_item_11( [INFO] [stdout] 284 + if let Some(result) = [INFO] [stdout] 285 + ((self.get_position_11("*") - 1.0) as usize).checked_sub(1) [INFO] [stdout] 286 + { [INFO] [stdout] 287 + result [INFO] [stdout] 288 + } else { [INFO] [stdout] 289 + 0 [INFO] [stdout] 290 + }, [INFO] [stdout] 291 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:284:25 [INFO] [stdout] | [INFO] [stdout] 284 | / if let Some(result) = [INFO] [stdout] 285 | | ((self.get_position_11("*") - 1.0) as usize).checked_sub(1) [INFO] [stdout] 286 | | { [INFO] [stdout] 287 | | result [INFO] [stdout] 288 | | } else { [INFO] [stdout] 289 | | 0 [INFO] [stdout] 290 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("*") - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:292:21 [INFO] [stdout] | [INFO] [stdout] 292 | / &*(self.get_item_11( [INFO] [stdout] 293 | | if let Some(result) = ((self.get_position_11("*")) as usize).checked_sub(1) [INFO] [stdout] 294 | | { [INFO] [stdout] 295 | | result [INFO] [stdout] ... | [INFO] [stdout] 298 | | }, [INFO] [stdout] 299 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 292 ~ &(self.get_item_11( [INFO] [stdout] 293 + if let Some(result) = ((self.get_position_11("*")) as usize).checked_sub(1) [INFO] [stdout] 294 + { [INFO] [stdout] 295 + result [INFO] [stdout] 296 + } else { [INFO] [stdout] 297 + 0 [INFO] [stdout] 298 + }, [INFO] [stdout] 299 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:293:25 [INFO] [stdout] | [INFO] [stdout] 293 | / if let Some(result) = ((self.get_position_11("*")) as usize).checked_sub(1) [INFO] [stdout] 294 | | { [INFO] [stdout] 295 | | result [INFO] [stdout] 296 | | } else { [INFO] [stdout] 297 | | 0 [INFO] [stdout] 298 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("*")) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:300:21 [INFO] [stdout] | [INFO] [stdout] 300 | / &*(self.get_item_11( [INFO] [stdout] 301 | | if let Some(result) = [INFO] [stdout] 302 | | ((self.get_position_11("*") + 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 307 | | }, [INFO] [stdout] 308 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 300 ~ &(self.get_item_11( [INFO] [stdout] 301 + if let Some(result) = [INFO] [stdout] 302 + ((self.get_position_11("*") + 1.0) as usize).checked_sub(1) [INFO] [stdout] 303 + { [INFO] [stdout] 304 + result [INFO] [stdout] 305 + } else { [INFO] [stdout] 306 + 0 [INFO] [stdout] 307 + }, [INFO] [stdout] 308 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/rxcalc.rs:264:65 [INFO] [stdout] | [INFO] [stdout] 264 | if let Some(position) = self.l_1_11.iter().position(|x| x == &value_to_find) { [INFO] [stdout] | ^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `value_to_find` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:301:25 [INFO] [stdout] | [INFO] [stdout] 301 | / if let Some(result) = [INFO] [stdout] 302 | | ((self.get_position_11("*") + 1.0) as usize).checked_sub(1) [INFO] [stdout] 303 | | { [INFO] [stdout] 304 | | result [INFO] [stdout] 305 | | } else { [INFO] [stdout] 306 | | 0 [INFO] [stdout] 307 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("*") + 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:283:21 [INFO] [stdout] | [INFO] [stdout] 283 | / &*(self.get_item_11( [INFO] [stdout] 284 | | if let Some(result) = [INFO] [stdout] 285 | | ((self.get_position_11("*") - 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 290 | | }, [INFO] [stdout] 291 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 283 ~ &(self.get_item_11( [INFO] [stdout] 284 + if let Some(result) = [INFO] [stdout] 285 + ((self.get_position_11("*") - 1.0) as usize).checked_sub(1) [INFO] [stdout] 286 + { [INFO] [stdout] 287 + result [INFO] [stdout] 288 + } else { [INFO] [stdout] 289 + 0 [INFO] [stdout] 290 + }, [INFO] [stdout] 291 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:315:21 [INFO] [stdout] | [INFO] [stdout] 315 | / if removein != usize::MAX { [INFO] [stdout] 316 | | if removein < self.l_1_11.len() { [INFO] [stdout] 317 | | self.l_1_11.remove(removein); [INFO] [stdout] 318 | | } [INFO] [stdout] 319 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 315 ~ if removein != usize::MAX [INFO] [stdout] 316 ~ && removein < self.l_1_11.len() { [INFO] [stdout] 317 | self.l_1_11.remove(removein); [INFO] [stdout] 318 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:284:25 [INFO] [stdout] | [INFO] [stdout] 284 | / if let Some(result) = [INFO] [stdout] 285 | | ((self.get_position_11("*") - 1.0) as usize).checked_sub(1) [INFO] [stdout] 286 | | { [INFO] [stdout] 287 | | result [INFO] [stdout] 288 | | } else { [INFO] [stdout] 289 | | 0 [INFO] [stdout] 290 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("*") - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:330:21 [INFO] [stdout] | [INFO] [stdout] 330 | / &*(self.get_item_11( [INFO] [stdout] 331 | | if let Some(result) = [INFO] [stdout] 332 | | ((self.get_position_11("/") - 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 337 | | }, [INFO] [stdout] 338 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 330 ~ &(self.get_item_11( [INFO] [stdout] 331 + if let Some(result) = [INFO] [stdout] 332 + ((self.get_position_11("/") - 1.0) as usize).checked_sub(1) [INFO] [stdout] 333 + { [INFO] [stdout] 334 + result [INFO] [stdout] 335 + } else { [INFO] [stdout] 336 + 0 [INFO] [stdout] 337 + }, [INFO] [stdout] 338 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:292:21 [INFO] [stdout] | [INFO] [stdout] 292 | / &*(self.get_item_11( [INFO] [stdout] 293 | | if let Some(result) = ((self.get_position_11("*")) as usize).checked_sub(1) [INFO] [stdout] 294 | | { [INFO] [stdout] 295 | | result [INFO] [stdout] ... | [INFO] [stdout] 298 | | }, [INFO] [stdout] 299 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 292 ~ &(self.get_item_11( [INFO] [stdout] 293 + if let Some(result) = ((self.get_position_11("*")) as usize).checked_sub(1) [INFO] [stdout] 294 + { [INFO] [stdout] 295 + result [INFO] [stdout] 296 + } else { [INFO] [stdout] 297 + 0 [INFO] [stdout] 298 + }, [INFO] [stdout] 299 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:331:25 [INFO] [stdout] | [INFO] [stdout] 331 | / if let Some(result) = [INFO] [stdout] 332 | | ((self.get_position_11("/") - 1.0) as usize).checked_sub(1) [INFO] [stdout] 333 | | { [INFO] [stdout] 334 | | result [INFO] [stdout] 335 | | } else { [INFO] [stdout] 336 | | 0 [INFO] [stdout] 337 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("/") - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:293:25 [INFO] [stdout] | [INFO] [stdout] 293 | / if let Some(result) = ((self.get_position_11("*")) as usize).checked_sub(1) [INFO] [stdout] 294 | | { [INFO] [stdout] 295 | | result [INFO] [stdout] 296 | | } else { [INFO] [stdout] 297 | | 0 [INFO] [stdout] 298 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("*")) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:339:21 [INFO] [stdout] | [INFO] [stdout] 339 | / &*(self.get_item_11( [INFO] [stdout] 340 | | if let Some(result) = ((self.get_position_11("/")) as usize).checked_sub(1) [INFO] [stdout] 341 | | { [INFO] [stdout] 342 | | result [INFO] [stdout] ... | [INFO] [stdout] 345 | | }, [INFO] [stdout] 346 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 339 ~ &(self.get_item_11( [INFO] [stdout] 340 + if let Some(result) = ((self.get_position_11("/")) as usize).checked_sub(1) [INFO] [stdout] 341 + { [INFO] [stdout] 342 + result [INFO] [stdout] 343 + } else { [INFO] [stdout] 344 + 0 [INFO] [stdout] 345 + }, [INFO] [stdout] 346 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:300:21 [INFO] [stdout] | [INFO] [stdout] 300 | / &*(self.get_item_11( [INFO] [stdout] 301 | | if let Some(result) = [INFO] [stdout] 302 | | ((self.get_position_11("*") + 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 307 | | }, [INFO] [stdout] 308 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 300 ~ &(self.get_item_11( [INFO] [stdout] 301 + if let Some(result) = [INFO] [stdout] 302 + ((self.get_position_11("*") + 1.0) as usize).checked_sub(1) [INFO] [stdout] 303 + { [INFO] [stdout] 304 + result [INFO] [stdout] 305 + } else { [INFO] [stdout] 306 + 0 [INFO] [stdout] 307 + }, [INFO] [stdout] 308 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:301:25 [INFO] [stdout] | [INFO] [stdout] 301 | / if let Some(result) = [INFO] [stdout] 302 | | ((self.get_position_11("*") + 1.0) as usize).checked_sub(1) [INFO] [stdout] 303 | | { [INFO] [stdout] 304 | | result [INFO] [stdout] 305 | | } else { [INFO] [stdout] 306 | | 0 [INFO] [stdout] 307 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("*") + 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:340:25 [INFO] [stdout] | [INFO] [stdout] 340 | / if let Some(result) = ((self.get_position_11("/")) as usize).checked_sub(1) [INFO] [stdout] 341 | | { [INFO] [stdout] 342 | | result [INFO] [stdout] 343 | | } else { [INFO] [stdout] 344 | | 0 [INFO] [stdout] 345 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("/")) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:315:21 [INFO] [stdout] | [INFO] [stdout] 315 | / if removein != usize::MAX { [INFO] [stdout] 316 | | if removein < self.l_1_11.len() { [INFO] [stdout] 317 | | self.l_1_11.remove(removein); [INFO] [stdout] 318 | | } [INFO] [stdout] 319 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 315 ~ if removein != usize::MAX [INFO] [stdout] 316 ~ && removein < self.l_1_11.len() { [INFO] [stdout] 317 | self.l_1_11.remove(removein); [INFO] [stdout] 318 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:347:21 [INFO] [stdout] | [INFO] [stdout] 347 | / &*(self.get_item_11( [INFO] [stdout] 348 | | if let Some(result) = [INFO] [stdout] 349 | | ((self.get_position_11("/") + 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 354 | | }, [INFO] [stdout] 355 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 347 ~ &(self.get_item_11( [INFO] [stdout] 348 + if let Some(result) = [INFO] [stdout] 349 + ((self.get_position_11("/") + 1.0) as usize).checked_sub(1) [INFO] [stdout] 350 + { [INFO] [stdout] 351 + result [INFO] [stdout] 352 + } else { [INFO] [stdout] 353 + 0 [INFO] [stdout] 354 + }, [INFO] [stdout] 355 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:348:25 [INFO] [stdout] | [INFO] [stdout] 348 | / if let Some(result) = [INFO] [stdout] 349 | | ((self.get_position_11("/") + 1.0) as usize).checked_sub(1) [INFO] [stdout] 350 | | { [INFO] [stdout] 351 | | result [INFO] [stdout] 352 | | } else { [INFO] [stdout] 353 | | 0 [INFO] [stdout] 354 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("/") + 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:330:21 [INFO] [stdout] | [INFO] [stdout] 330 | / &*(self.get_item_11( [INFO] [stdout] 331 | | if let Some(result) = [INFO] [stdout] 332 | | ((self.get_position_11("/") - 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 337 | | }, [INFO] [stdout] 338 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 330 ~ &(self.get_item_11( [INFO] [stdout] 331 + if let Some(result) = [INFO] [stdout] 332 + ((self.get_position_11("/") - 1.0) as usize).checked_sub(1) [INFO] [stdout] 333 + { [INFO] [stdout] 334 + result [INFO] [stdout] 335 + } else { [INFO] [stdout] 336 + 0 [INFO] [stdout] 337 + }, [INFO] [stdout] 338 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:331:25 [INFO] [stdout] | [INFO] [stdout] 331 | / if let Some(result) = [INFO] [stdout] 332 | | ((self.get_position_11("/") - 1.0) as usize).checked_sub(1) [INFO] [stdout] 333 | | { [INFO] [stdout] 334 | | result [INFO] [stdout] 335 | | } else { [INFO] [stdout] 336 | | 0 [INFO] [stdout] 337 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("/") - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:362:21 [INFO] [stdout] | [INFO] [stdout] 362 | / if removein != usize::MAX { [INFO] [stdout] 363 | | if removein < self.l_1_11.len() { [INFO] [stdout] 364 | | self.l_1_11.remove(removein); [INFO] [stdout] 365 | | } [INFO] [stdout] 366 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 362 ~ if removein != usize::MAX [INFO] [stdout] 363 ~ && removein < self.l_1_11.len() { [INFO] [stdout] 364 | self.l_1_11.remove(removein); [INFO] [stdout] 365 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:339:21 [INFO] [stdout] | [INFO] [stdout] 339 | / &*(self.get_item_11( [INFO] [stdout] 340 | | if let Some(result) = ((self.get_position_11("/")) as usize).checked_sub(1) [INFO] [stdout] 341 | | { [INFO] [stdout] 342 | | result [INFO] [stdout] ... | [INFO] [stdout] 345 | | }, [INFO] [stdout] 346 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 339 ~ &(self.get_item_11( [INFO] [stdout] 340 + if let Some(result) = ((self.get_position_11("/")) as usize).checked_sub(1) [INFO] [stdout] 341 + { [INFO] [stdout] 342 + result [INFO] [stdout] 343 + } else { [INFO] [stdout] 344 + 0 [INFO] [stdout] 345 + }, [INFO] [stdout] 346 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:340:25 [INFO] [stdout] | [INFO] [stdout] 340 | / if let Some(result) = ((self.get_position_11("/")) as usize).checked_sub(1) [INFO] [stdout] 341 | | { [INFO] [stdout] 342 | | result [INFO] [stdout] 343 | | } else { [INFO] [stdout] 344 | | 0 [INFO] [stdout] 345 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("/")) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:347:21 [INFO] [stdout] | [INFO] [stdout] 347 | / &*(self.get_item_11( [INFO] [stdout] 348 | | if let Some(result) = [INFO] [stdout] 349 | | ((self.get_position_11("/") + 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 354 | | }, [INFO] [stdout] 355 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 347 ~ &(self.get_item_11( [INFO] [stdout] 348 + if let Some(result) = [INFO] [stdout] 349 + ((self.get_position_11("/") + 1.0) as usize).checked_sub(1) [INFO] [stdout] 350 + { [INFO] [stdout] 351 + result [INFO] [stdout] 352 + } else { [INFO] [stdout] 353 + 0 [INFO] [stdout] 354 + }, [INFO] [stdout] 355 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:348:25 [INFO] [stdout] | [INFO] [stdout] 348 | / if let Some(result) = [INFO] [stdout] 349 | | ((self.get_position_11("/") + 1.0) as usize).checked_sub(1) [INFO] [stdout] 350 | | { [INFO] [stdout] 351 | | result [INFO] [stdout] 352 | | } else { [INFO] [stdout] 353 | | 0 [INFO] [stdout] 354 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("/") + 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:380:15 [INFO] [stdout] | [INFO] [stdout] 380 | while !(!(self.get_contains_11(String::from(pm_15)))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.get_contains_11(String::from(pm_15)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:362:21 [INFO] [stdout] | [INFO] [stdout] 362 | / if removein != usize::MAX { [INFO] [stdout] 363 | | if removein < self.l_1_11.len() { [INFO] [stdout] 364 | | self.l_1_11.remove(removein); [INFO] [stdout] 365 | | } [INFO] [stdout] 366 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 362 ~ if removein != usize::MAX [INFO] [stdout] 363 ~ && removein < self.l_1_11.len() { [INFO] [stdout] 364 | self.l_1_11.remove(removein); [INFO] [stdout] 365 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:382:17 [INFO] [stdout] | [INFO] [stdout] 382 | / &*(self.get_item_11( [INFO] [stdout] 383 | | if let Some(result) = [INFO] [stdout] 384 | | ((self.get_position_11(pm_15) - 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 389 | | }, [INFO] [stdout] 390 | | )), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 382 ~ &(self.get_item_11( [INFO] [stdout] 383 + if let Some(result) = [INFO] [stdout] 384 + ((self.get_position_11(pm_15) - 1.0) as usize).checked_sub(1) [INFO] [stdout] 385 + { [INFO] [stdout] 386 + result [INFO] [stdout] 387 + } else { [INFO] [stdout] 388 + 0 [INFO] [stdout] 389 + }, [INFO] [stdout] 390 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:380:15 [INFO] [stdout] | [INFO] [stdout] 380 | while !(!(self.get_contains_11(String::from(pm_15)))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.get_contains_11(String::from(pm_15)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:383:21 [INFO] [stdout] | [INFO] [stdout] 383 | / if let Some(result) = [INFO] [stdout] 384 | | ((self.get_position_11(pm_15) - 1.0) as usize).checked_sub(1) [INFO] [stdout] 385 | | { [INFO] [stdout] 386 | | result [INFO] [stdout] 387 | | } else { [INFO] [stdout] 388 | | 0 [INFO] [stdout] 389 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `((self.get_position_11(pm_15) - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:382:17 [INFO] [stdout] | [INFO] [stdout] 382 | / &*(self.get_item_11( [INFO] [stdout] 383 | | if let Some(result) = [INFO] [stdout] 384 | | ((self.get_position_11(pm_15) - 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 389 | | }, [INFO] [stdout] 390 | | )), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 382 ~ &(self.get_item_11( [INFO] [stdout] 383 + if let Some(result) = [INFO] [stdout] 384 + ((self.get_position_11(pm_15) - 1.0) as usize).checked_sub(1) [INFO] [stdout] 385 + { [INFO] [stdout] 386 + result [INFO] [stdout] 387 + } else { [INFO] [stdout] 388 + 0 [INFO] [stdout] 389 + }, [INFO] [stdout] 390 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:383:21 [INFO] [stdout] | [INFO] [stdout] 383 | / if let Some(result) = [INFO] [stdout] 384 | | ((self.get_position_11(pm_15) - 1.0) as usize).checked_sub(1) [INFO] [stdout] 385 | | { [INFO] [stdout] 386 | | result [INFO] [stdout] 387 | | } else { [INFO] [stdout] 388 | | 0 [INFO] [stdout] 389 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `((self.get_position_11(pm_15) - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:391:17 [INFO] [stdout] | [INFO] [stdout] 391 | / &*(self.get_item_11( [INFO] [stdout] 392 | | if let Some(result) = ((self.get_position_11(pm_15)) as usize).checked_sub(1) { [INFO] [stdout] 393 | | result [INFO] [stdout] 394 | | } else { [INFO] [stdout] 395 | | 0 [INFO] [stdout] 396 | | }, [INFO] [stdout] 397 | | )), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 391 ~ &(self.get_item_11( [INFO] [stdout] 392 + if let Some(result) = ((self.get_position_11(pm_15)) as usize).checked_sub(1) { [INFO] [stdout] 393 + result [INFO] [stdout] 394 + } else { [INFO] [stdout] 395 + 0 [INFO] [stdout] 396 + }, [INFO] [stdout] 397 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:392:21 [INFO] [stdout] | [INFO] [stdout] 392 | / if let Some(result) = ((self.get_position_11(pm_15)) as usize).checked_sub(1) { [INFO] [stdout] 393 | | result [INFO] [stdout] 394 | | } else { [INFO] [stdout] 395 | | 0 [INFO] [stdout] 396 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `((self.get_position_11(pm_15)) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:398:17 [INFO] [stdout] | [INFO] [stdout] 398 | / &*(self.get_item_11( [INFO] [stdout] 399 | | if let Some(result) = [INFO] [stdout] 400 | | ((self.get_position_11(pm_15) + 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 405 | | }, [INFO] [stdout] 406 | | )), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 398 ~ &(self.get_item_11( [INFO] [stdout] 399 + if let Some(result) = [INFO] [stdout] 400 + ((self.get_position_11(pm_15) + 1.0) as usize).checked_sub(1) [INFO] [stdout] 401 + { [INFO] [stdout] 402 + result [INFO] [stdout] 403 + } else { [INFO] [stdout] 404 + 0 [INFO] [stdout] 405 + }, [INFO] [stdout] 406 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:399:21 [INFO] [stdout] | [INFO] [stdout] 399 | / if let Some(result) = [INFO] [stdout] 400 | | ((self.get_position_11(pm_15) + 1.0) as usize).checked_sub(1) [INFO] [stdout] 401 | | { [INFO] [stdout] 402 | | result [INFO] [stdout] 403 | | } else { [INFO] [stdout] 404 | | 0 [INFO] [stdout] 405 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `((self.get_position_11(pm_15) + 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:391:17 [INFO] [stdout] | [INFO] [stdout] 391 | / &*(self.get_item_11( [INFO] [stdout] 392 | | if let Some(result) = ((self.get_position_11(pm_15)) as usize).checked_sub(1) { [INFO] [stdout] 393 | | result [INFO] [stdout] 394 | | } else { [INFO] [stdout] 395 | | 0 [INFO] [stdout] 396 | | }, [INFO] [stdout] 397 | | )), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 391 ~ &(self.get_item_11( [INFO] [stdout] 392 + if let Some(result) = ((self.get_position_11(pm_15)) as usize).checked_sub(1) { [INFO] [stdout] 393 + result [INFO] [stdout] 394 + } else { [INFO] [stdout] 395 + 0 [INFO] [stdout] 396 + }, [INFO] [stdout] 397 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:392:21 [INFO] [stdout] | [INFO] [stdout] 392 | / if let Some(result) = ((self.get_position_11(pm_15)) as usize).checked_sub(1) { [INFO] [stdout] 393 | | result [INFO] [stdout] 394 | | } else { [INFO] [stdout] 395 | | 0 [INFO] [stdout] 396 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `((self.get_position_11(pm_15)) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:413:17 [INFO] [stdout] | [INFO] [stdout] 413 | / if removein != usize::MAX { [INFO] [stdout] 414 | | if removein < self.l_1_11.len() { [INFO] [stdout] 415 | | self.l_1_11.remove(removein); [INFO] [stdout] 416 | | } [INFO] [stdout] 417 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 413 ~ if removein != usize::MAX [INFO] [stdout] 414 ~ && removein < self.l_1_11.len() { [INFO] [stdout] 415 | self.l_1_11.remove(removein); [INFO] [stdout] 416 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:398:17 [INFO] [stdout] | [INFO] [stdout] 398 | / &*(self.get_item_11( [INFO] [stdout] 399 | | if let Some(result) = [INFO] [stdout] 400 | | ((self.get_position_11(pm_15) + 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 405 | | }, [INFO] [stdout] 406 | | )), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 398 ~ &(self.get_item_11( [INFO] [stdout] 399 + if let Some(result) = [INFO] [stdout] 400 + ((self.get_position_11(pm_15) + 1.0) as usize).checked_sub(1) [INFO] [stdout] 401 + { [INFO] [stdout] 402 + result [INFO] [stdout] 403 + } else { [INFO] [stdout] 404 + 0 [INFO] [stdout] 405 + }, [INFO] [stdout] 406 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:399:21 [INFO] [stdout] | [INFO] [stdout] 399 | / if let Some(result) = [INFO] [stdout] 400 | | ((self.get_position_11(pm_15) + 1.0) as usize).checked_sub(1) [INFO] [stdout] 401 | | { [INFO] [stdout] 402 | | result [INFO] [stdout] 403 | | } else { [INFO] [stdout] 404 | | 0 [INFO] [stdout] 405 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `((self.get_position_11(pm_15) + 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:437:34 [INFO] [stdout] | [INFO] [stdout] 437 | self.get_item_11(if let Some(result) = (1_usize).checked_sub(1) { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 438 | | result [INFO] [stdout] 439 | | } else { [INFO] [stdout] 440 | | 0 [INFO] [stdout] 441 | | }) [INFO] [stdout] | |_________________^ help: replace it with: `(1_usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:444:44 [INFO] [stdout] | [INFO] [stdout] 444 | self.vs_1_6 = self.get_item_11(if let Some(result) = (1_usize).checked_sub(1) { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 445 | | result [INFO] [stdout] 446 | | } else { [INFO] [stdout] 447 | | 0 [INFO] [stdout] 448 | | }); [INFO] [stdout] | |_____________^ help: replace it with: `(1_usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:413:17 [INFO] [stdout] | [INFO] [stdout] 413 | / if removein != usize::MAX { [INFO] [stdout] 414 | | if removein < self.l_1_11.len() { [INFO] [stdout] 415 | | self.l_1_11.remove(removein); [INFO] [stdout] 416 | | } [INFO] [stdout] 417 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 413 ~ if removein != usize::MAX [INFO] [stdout] 414 ~ && removein < self.l_1_11.len() { [INFO] [stdout] 415 | self.l_1_11.remove(removein); [INFO] [stdout] 416 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:437:34 [INFO] [stdout] | [INFO] [stdout] 437 | self.get_item_11(if let Some(result) = (1_usize).checked_sub(1) { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 438 | | result [INFO] [stdout] 439 | | } else { [INFO] [stdout] 440 | | 0 [INFO] [stdout] 441 | | }) [INFO] [stdout] | |_________________^ help: replace it with: `(1_usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:444:44 [INFO] [stdout] | [INFO] [stdout] 444 | self.vs_1_6 = self.get_item_11(if let Some(result) = (1_usize).checked_sub(1) { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 445 | | result [INFO] [stdout] 446 | | } else { [INFO] [stdout] 447 | | 0 [INFO] [stdout] 448 | | }); [INFO] [stdout] | |_____________^ help: replace it with: `(1_usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/rxcalc.rs:501:65 [INFO] [stdout] | [INFO] [stdout] 501 | if let Some(position) = self.l_1_10.iter().position(|x| x == &value_to_find) { [INFO] [stdout] | ^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `value_to_find` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/rxcalc.rs:501:65 [INFO] [stdout] | [INFO] [stdout] 501 | if let Some(position) = self.l_1_10.iter().position(|x| x == &value_to_find) { [INFO] [stdout] | ^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `value_to_find` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:554:16 [INFO] [stdout] | [INFO] [stdout] 554 | if !(get_char_at(self.vs_1_5.clone(), 1.0) == String::from("-")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(get_char_at(self.vs_1_5.clone(), 1.0) != String::from("-"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:555:20 [INFO] [stdout] | [INFO] [stdout] 555 | && !(get_char_at(self.vs_1_5.clone(), 1.0) == String::from("!")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(get_char_at(self.vs_1_5.clone(), 1.0) != String::from("!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:1152:23 [INFO] [stdout] | [INFO] [stdout] 1152 | while !(!(self.get_contains_10(self.vs_1_7.clone()))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.get_contains_10(self.vs_1_7.clone()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:554:16 [INFO] [stdout] | [INFO] [stdout] 554 | if !(get_char_at(self.vs_1_5.clone(), 1.0) == String::from("-")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(get_char_at(self.vs_1_5.clone(), 1.0) != String::from("-"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:555:20 [INFO] [stdout] | [INFO] [stdout] 555 | && !(get_char_at(self.vs_1_5.clone(), 1.0) == String::from("!")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(get_char_at(self.vs_1_5.clone(), 1.0) != String::from("!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:1152:23 [INFO] [stdout] | [INFO] [stdout] 1152 | while !(!(self.get_contains_10(self.vs_1_7.clone()))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.get_contains_10(self.vs_1_7.clone()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:532:25 [INFO] [stdout] | [INFO] [stdout] 532 | / if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 533 | | result [INFO] [stdout] 534 | | } else { [INFO] [stdout] 535 | | 0 [INFO] [stdout] 536 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:554:59 [INFO] [stdout] | [INFO] [stdout] 554 | if !(get_char_at(self.vs_1_5.clone(), 1.0) == String::from("-")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"-"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:555:63 [INFO] [stdout] | [INFO] [stdout] 555 | && !(get_char_at(self.vs_1_5.clone(), 1.0) == String::from("!")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"!"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:532:25 [INFO] [stdout] | [INFO] [stdout] 532 | / if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 533 | | result [INFO] [stdout] 534 | | } else { [INFO] [stdout] 535 | | 0 [INFO] [stdout] 536 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:572:70 [INFO] [stdout] | [INFO] [stdout] 572 | if (get_char_at(self.vs_1_5.clone(), self.vf_1_2) == String::from("\"")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"\""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:573:74 [INFO] [stdout] | [INFO] [stdout] 573 | || (get_char_at(self.vs_1_5.clone(), self.vf_1_2) == String::from("'")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"'"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:554:59 [INFO] [stdout] | [INFO] [stdout] 554 | if !(get_char_at(self.vs_1_5.clone(), 1.0) == String::from("-")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"-"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:555:63 [INFO] [stdout] | [INFO] [stdout] 555 | && !(get_char_at(self.vs_1_5.clone(), 1.0) == String::from("!")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"!"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:572:70 [INFO] [stdout] | [INFO] [stdout] 572 | if (get_char_at(self.vs_1_5.clone(), self.vf_1_2) == String::from("\"")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"\""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:573:74 [INFO] [stdout] | [INFO] [stdout] 573 | || (get_char_at(self.vs_1_5.clone(), self.vf_1_2) == String::from("'")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"'"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:596:33 [INFO] [stdout] | [INFO] [stdout] 596 | / ... if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 597 | | ... result [INFO] [stdout] 598 | | ... } else { [INFO] [stdout] 599 | | ... 0 [INFO] [stdout] 600 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:613:41 [INFO] [stdout] | [INFO] [stdout] 613 | / ... if let Some(result) = [INFO] [stdout] 614 | | ... ((self.vf_1_4 - 1.0) as usize).checked_sub(1) [INFO] [stdout] 615 | | ... { [INFO] [stdout] 616 | | ... result [INFO] [stdout] 617 | | ... } else { [INFO] [stdout] 618 | | ... 0 [INFO] [stdout] 619 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.vf_1_4 - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:626:45 [INFO] [stdout] | [INFO] [stdout] 626 | / ... if let Some(result) = [INFO] [stdout] 627 | | ... ((self.vf_1_4 - 1.0) as usize).checked_sub(1) [INFO] [stdout] 628 | | ... { [INFO] [stdout] 629 | | ... result [INFO] [stdout] 630 | | ... } else { [INFO] [stdout] 631 | | ... 0 [INFO] [stdout] 632 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.vf_1_4 - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:596:33 [INFO] [stdout] | [INFO] [stdout] 596 | / ... if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 597 | | ... result [INFO] [stdout] 598 | | ... } else { [INFO] [stdout] 599 | | ... 0 [INFO] [stdout] 600 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:646:41 [INFO] [stdout] | [INFO] [stdout] 646 | / ... if let Some(result) = [INFO] [stdout] 647 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 648 | | ... { [INFO] [stdout] 649 | | ... result [INFO] [stdout] 650 | | ... } else { [INFO] [stdout] 651 | | ... 0 [INFO] [stdout] 652 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:659:41 [INFO] [stdout] | [INFO] [stdout] 659 | / ... if let Some(result) = [INFO] [stdout] 660 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 661 | | ... { [INFO] [stdout] 662 | | ... result [INFO] [stdout] 663 | | ... } else { [INFO] [stdout] 664 | | ... 0 [INFO] [stdout] 665 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:613:41 [INFO] [stdout] | [INFO] [stdout] 613 | / ... if let Some(result) = [INFO] [stdout] 614 | | ... ((self.vf_1_4 - 1.0) as usize).checked_sub(1) [INFO] [stdout] 615 | | ... { [INFO] [stdout] 616 | | ... result [INFO] [stdout] 617 | | ... } else { [INFO] [stdout] 618 | | ... 0 [INFO] [stdout] 619 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.vf_1_4 - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:671:53 [INFO] [stdout] | [INFO] [stdout] 671 | / ... if let Some(result) = ((self.get_leng_9() - 1.0) [INFO] [stdout] 672 | | ... as usize) [INFO] [stdout] 673 | | ... .checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 677 | | ... 0 [INFO] [stdout] 678 | | ... }, [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 671 ~ ((self.get_leng_9() - 1.0) [INFO] [stdout] 672 + as usize) [INFO] [stdout] 673 ~ .checked_sub(1).unwrap_or_default(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:626:45 [INFO] [stdout] | [INFO] [stdout] 626 | / ... if let Some(result) = [INFO] [stdout] 627 | | ... ((self.vf_1_4 - 1.0) as usize).checked_sub(1) [INFO] [stdout] 628 | | ... { [INFO] [stdout] 629 | | ... result [INFO] [stdout] 630 | | ... } else { [INFO] [stdout] 631 | | ... 0 [INFO] [stdout] 632 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.vf_1_4 - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:695:41 [INFO] [stdout] | [INFO] [stdout] 695 | / ... if let Some(result) = [INFO] [stdout] 696 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 697 | | ... { [INFO] [stdout] 698 | | ... result [INFO] [stdout] 699 | | ... } else { [INFO] [stdout] 700 | | ... 0 [INFO] [stdout] 701 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:714:37 [INFO] [stdout] | [INFO] [stdout] 714 | / ... if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 715 | | ... result [INFO] [stdout] 716 | | ... } else { [INFO] [stdout] 717 | | ... 0 [INFO] [stdout] 718 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:646:41 [INFO] [stdout] | [INFO] [stdout] 646 | / ... if let Some(result) = [INFO] [stdout] 647 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 648 | | ... { [INFO] [stdout] 649 | | ... result [INFO] [stdout] 650 | | ... } else { [INFO] [stdout] 651 | | ... 0 [INFO] [stdout] 652 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:659:41 [INFO] [stdout] | [INFO] [stdout] 659 | / ... if let Some(result) = [INFO] [stdout] 660 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 661 | | ... { [INFO] [stdout] 662 | | ... result [INFO] [stdout] 663 | | ... } else { [INFO] [stdout] 664 | | ... 0 [INFO] [stdout] 665 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:727:41 [INFO] [stdout] | [INFO] [stdout] 727 | / ... if let Some(result) = [INFO] [stdout] 728 | | ... ((self.vf_1_4 - 1.0) as usize).checked_sub(1) [INFO] [stdout] 729 | | ... { [INFO] [stdout] 730 | | ... result [INFO] [stdout] 731 | | ... } else { [INFO] [stdout] 732 | | ... 0 [INFO] [stdout] 733 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.vf_1_4 - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:745:45 [INFO] [stdout] | [INFO] [stdout] 745 | / ... if let Some(result) = [INFO] [stdout] 746 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 747 | | ... { [INFO] [stdout] 748 | | ... result [INFO] [stdout] 749 | | ... } else { [INFO] [stdout] 750 | | ... 0 [INFO] [stdout] 751 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:759:45 [INFO] [stdout] | [INFO] [stdout] 759 | / ... if let Some(result) = [INFO] [stdout] 760 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 761 | | ... { [INFO] [stdout] 762 | | ... result [INFO] [stdout] 763 | | ... } else { [INFO] [stdout] 764 | | ... 0 [INFO] [stdout] 765 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:671:53 [INFO] [stdout] | [INFO] [stdout] 671 | / ... if let Some(result) = ((self.get_leng_9() - 1.0) [INFO] [stdout] 672 | | ... as usize) [INFO] [stdout] 673 | | ... .checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 677 | | ... 0 [INFO] [stdout] 678 | | ... }, [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 671 ~ ((self.get_leng_9() - 1.0) [INFO] [stdout] 672 + as usize) [INFO] [stdout] 673 ~ .checked_sub(1).unwrap_or_default(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:695:41 [INFO] [stdout] | [INFO] [stdout] 695 | / ... if let Some(result) = [INFO] [stdout] 696 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 697 | | ... { [INFO] [stdout] 698 | | ... result [INFO] [stdout] 699 | | ... } else { [INFO] [stdout] 700 | | ... 0 [INFO] [stdout] 701 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:714:37 [INFO] [stdout] | [INFO] [stdout] 714 | / ... if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 715 | | ... result [INFO] [stdout] 716 | | ... } else { [INFO] [stdout] 717 | | ... 0 [INFO] [stdout] 718 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:771:57 [INFO] [stdout] | [INFO] [stdout] 771 | / ... if let Some(result) = [INFO] [stdout] 772 | | ... ((self.get_leng_9() - 1.0) as usize) [INFO] [stdout] 773 | | ... .checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 777 | | ... 0 [INFO] [stdout] 778 | | ... }, [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 771 ~ ((self.get_leng_9() - 1.0) as usize) [INFO] [stdout] 772 ~ .checked_sub(1).unwrap_or_default(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:727:41 [INFO] [stdout] | [INFO] [stdout] 727 | / ... if let Some(result) = [INFO] [stdout] 728 | | ... ((self.vf_1_4 - 1.0) as usize).checked_sub(1) [INFO] [stdout] 729 | | ... { [INFO] [stdout] 730 | | ... result [INFO] [stdout] 731 | | ... } else { [INFO] [stdout] 732 | | ... 0 [INFO] [stdout] 733 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.vf_1_4 - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:795:45 [INFO] [stdout] | [INFO] [stdout] 795 | / ... if let Some(result) = [INFO] [stdout] 796 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 797 | | ... { [INFO] [stdout] 798 | | ... result [INFO] [stdout] 799 | | ... } else { [INFO] [stdout] 800 | | ... 0 [INFO] [stdout] 801 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:745:45 [INFO] [stdout] | [INFO] [stdout] 745 | / ... if let Some(result) = [INFO] [stdout] 746 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 747 | | ... { [INFO] [stdout] 748 | | ... result [INFO] [stdout] 749 | | ... } else { [INFO] [stdout] 750 | | ... 0 [INFO] [stdout] 751 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:820:25 [INFO] [stdout] | [INFO] [stdout] 820 | / if let Some(result) = (self.vf_1_4 as usize).checked_sub(1) { [INFO] [stdout] 821 | | result [INFO] [stdout] 822 | | } else { [INFO] [stdout] 823 | | 0 [INFO] [stdout] 824 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_4 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:759:45 [INFO] [stdout] | [INFO] [stdout] 759 | / ... if let Some(result) = [INFO] [stdout] 760 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 761 | | ... { [INFO] [stdout] 762 | | ... result [INFO] [stdout] 763 | | ... } else { [INFO] [stdout] 764 | | ... 0 [INFO] [stdout] 765 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:771:57 [INFO] [stdout] | [INFO] [stdout] 771 | / ... if let Some(result) = [INFO] [stdout] 772 | | ... ((self.get_leng_9() - 1.0) as usize) [INFO] [stdout] 773 | | ... .checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 777 | | ... 0 [INFO] [stdout] 778 | | ... }, [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 771 ~ ((self.get_leng_9() - 1.0) as usize) [INFO] [stdout] 772 ~ .checked_sub(1).unwrap_or_default(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:833:17 [INFO] [stdout] | [INFO] [stdout] 833 | / if removein != usize::MAX { [INFO] [stdout] 834 | | if removein < self.l_1_9.len() { [INFO] [stdout] 835 | | self.l_1_9.remove(removein); [INFO] [stdout] 836 | | } [INFO] [stdout] 837 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 833 ~ if removein != usize::MAX [INFO] [stdout] 834 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 835 | self.l_1_9.remove(removein); [INFO] [stdout] 836 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:795:45 [INFO] [stdout] | [INFO] [stdout] 795 | / ... if let Some(result) = [INFO] [stdout] 796 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 797 | | ... { [INFO] [stdout] 798 | | ... result [INFO] [stdout] 799 | | ... } else { [INFO] [stdout] 800 | | ... 0 [INFO] [stdout] 801 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:843:25 [INFO] [stdout] | [INFO] [stdout] 843 | / if let Some(result) = ((self.get_leng_9()) as usize).checked_sub(1) { [INFO] [stdout] 844 | | result [INFO] [stdout] 845 | | } else { [INFO] [stdout] 846 | | 0 [INFO] [stdout] 847 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_leng_9()) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:854:25 [INFO] [stdout] | [INFO] [stdout] 854 | / if let Some(result) = ((self.get_leng_9()) as usize).checked_sub(1) { [INFO] [stdout] 855 | | result [INFO] [stdout] 856 | | } else { [INFO] [stdout] 857 | | 0 [INFO] [stdout] 858 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_leng_9()) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:820:25 [INFO] [stdout] | [INFO] [stdout] 820 | / if let Some(result) = (self.vf_1_4 as usize).checked_sub(1) { [INFO] [stdout] 821 | | result [INFO] [stdout] 822 | | } else { [INFO] [stdout] 823 | | 0 [INFO] [stdout] 824 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_4 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:864:37 [INFO] [stdout] | [INFO] [stdout] 864 | / ... if let Some(result) = [INFO] [stdout] 865 | | ... ((self.get_leng_9()) as usize).checked_sub(1) [INFO] [stdout] 866 | | ... { [INFO] [stdout] 867 | | ... result [INFO] [stdout] 868 | | ... } else { [INFO] [stdout] 869 | | ... 0 [INFO] [stdout] 870 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9()) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:884:25 [INFO] [stdout] | [INFO] [stdout] 884 | / if let Some(result) = ((self.get_leng_9()) as usize).checked_sub(1) { [INFO] [stdout] 885 | | result [INFO] [stdout] 886 | | } else { [INFO] [stdout] 887 | | 0 [INFO] [stdout] 888 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_leng_9()) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:833:17 [INFO] [stdout] | [INFO] [stdout] 833 | / if removein != usize::MAX { [INFO] [stdout] 834 | | if removein < self.l_1_9.len() { [INFO] [stdout] 835 | | self.l_1_9.remove(removein); [INFO] [stdout] 836 | | } [INFO] [stdout] 837 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 833 ~ if removein != usize::MAX [INFO] [stdout] 834 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 835 | self.l_1_9.remove(removein); [INFO] [stdout] 836 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:843:25 [INFO] [stdout] | [INFO] [stdout] 843 | / if let Some(result) = ((self.get_leng_9()) as usize).checked_sub(1) { [INFO] [stdout] 844 | | result [INFO] [stdout] 845 | | } else { [INFO] [stdout] 846 | | 0 [INFO] [stdout] 847 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_leng_9()) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:854:25 [INFO] [stdout] | [INFO] [stdout] 854 | / if let Some(result) = ((self.get_leng_9()) as usize).checked_sub(1) { [INFO] [stdout] 855 | | result [INFO] [stdout] 856 | | } else { [INFO] [stdout] 857 | | 0 [INFO] [stdout] 858 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_leng_9()) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:910:25 [INFO] [stdout] | [INFO] [stdout] 910 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 911 | | result [INFO] [stdout] 912 | | } else { [INFO] [stdout] 913 | | 0 [INFO] [stdout] 914 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:928:22 [INFO] [stdout] | [INFO] [stdout] 928 | ) == String::from("") [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:923:21 [INFO] [stdout] | [INFO] [stdout] 923 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 924 | | result [INFO] [stdout] 925 | | } else { [INFO] [stdout] 926 | | 0 [INFO] [stdout] 927 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:931:21 [INFO] [stdout] | [INFO] [stdout] 931 | / if removein != usize::MAX { [INFO] [stdout] 932 | | if removein < self.l_1_9.len() { [INFO] [stdout] 933 | | self.l_1_9.remove(removein); [INFO] [stdout] 934 | | } [INFO] [stdout] 935 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 931 ~ if removein != usize::MAX [INFO] [stdout] 932 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 933 | self.l_1_9.remove(removein); [INFO] [stdout] 934 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:953:22 [INFO] [stdout] | [INFO] [stdout] 953 | ) == String::from("-") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"-"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:948:21 [INFO] [stdout] | [INFO] [stdout] 948 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 949 | | result [INFO] [stdout] 950 | | } else { [INFO] [stdout] 951 | | 0 [INFO] [stdout] 952 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:956:25 [INFO] [stdout] | [INFO] [stdout] 956 | / if let Some(result) = ((self.vf_1_2 - 1.0) as usize).checked_sub(1) { [INFO] [stdout] 957 | | result [INFO] [stdout] 958 | | } else { [INFO] [stdout] 959 | | 0 [INFO] [stdout] 960 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.vf_1_2 - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:981:33 [INFO] [stdout] | [INFO] [stdout] 981 | / ... if let Some(result) = ((self.vf_1_2 + 1.0) as usize).checked_sub(1) [INFO] [stdout] 982 | | ... { [INFO] [stdout] 983 | | ... result [INFO] [stdout] 984 | | ... } else { [INFO] [stdout] 985 | | ... 0 [INFO] [stdout] 986 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.vf_1_2 + 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:1014:22 [INFO] [stdout] | [INFO] [stdout] 1014 | ) == String::from("(") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"("` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1009:21 [INFO] [stdout] | [INFO] [stdout] 1009 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1010 | | result [INFO] [stdout] 1011 | | } else { [INFO] [stdout] 1012 | | 0 [INFO] [stdout] 1013 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1019:21 [INFO] [stdout] | [INFO] [stdout] 1019 | / if removein != usize::MAX { [INFO] [stdout] 1020 | | if removein < self.l_1_9.len() { [INFO] [stdout] 1021 | | self.l_1_9.remove(removein); [INFO] [stdout] 1022 | | } [INFO] [stdout] 1023 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1019 ~ if removein != usize::MAX [INFO] [stdout] 1020 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 1021 | self.l_1_9.remove(removein); [INFO] [stdout] 1022 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:1033:26 [INFO] [stdout] | [INFO] [stdout] 1033 | ) == String::from(")") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `")"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1028:25 [INFO] [stdout] | [INFO] [stdout] 1028 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1029 | | result [INFO] [stdout] 1030 | | } else { [INFO] [stdout] 1031 | | 0 [INFO] [stdout] 1032 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1038:25 [INFO] [stdout] | [INFO] [stdout] 1038 | / if removein != usize::MAX { [INFO] [stdout] 1039 | | if removein < self.l_1_9.len() { [INFO] [stdout] 1040 | | self.l_1_9.remove(removein); [INFO] [stdout] 1041 | | } [INFO] [stdout] 1042 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1038 ~ if removein != usize::MAX [INFO] [stdout] 1039 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 1040 | self.l_1_9.remove(removein); [INFO] [stdout] 1041 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1048:37 [INFO] [stdout] | [INFO] [stdout] 1048 | / ... if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1049 | | ... result [INFO] [stdout] 1050 | | ... } else { [INFO] [stdout] 1051 | | ... 0 [INFO] [stdout] 1052 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:864:37 [INFO] [stdout] | [INFO] [stdout] 864 | / ... if let Some(result) = [INFO] [stdout] 865 | | ... ((self.get_leng_9()) as usize).checked_sub(1) [INFO] [stdout] 866 | | ... { [INFO] [stdout] 867 | | ... result [INFO] [stdout] 868 | | ... } else { [INFO] [stdout] 869 | | ... 0 [INFO] [stdout] 870 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9()) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:884:25 [INFO] [stdout] | [INFO] [stdout] 884 | / if let Some(result) = ((self.get_leng_9()) as usize).checked_sub(1) { [INFO] [stdout] 885 | | result [INFO] [stdout] 886 | | } else { [INFO] [stdout] 887 | | 0 [INFO] [stdout] 888 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_leng_9()) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:910:25 [INFO] [stdout] | [INFO] [stdout] 910 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 911 | | result [INFO] [stdout] 912 | | } else { [INFO] [stdout] 913 | | 0 [INFO] [stdout] 914 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:928:22 [INFO] [stdout] | [INFO] [stdout] 928 | ) == String::from("") [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:923:21 [INFO] [stdout] | [INFO] [stdout] 923 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 924 | | result [INFO] [stdout] 925 | | } else { [INFO] [stdout] 926 | | 0 [INFO] [stdout] 927 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1077:25 [INFO] [stdout] | [INFO] [stdout] 1077 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1078 | | result [INFO] [stdout] 1079 | | } else { [INFO] [stdout] 1080 | | 0 [INFO] [stdout] 1081 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1094:29 [INFO] [stdout] | [INFO] [stdout] 1094 | / ... if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1095 | | ... result [INFO] [stdout] 1096 | | ... } else { [INFO] [stdout] 1097 | | ... 0 [INFO] [stdout] 1098 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1132:25 [INFO] [stdout] | [INFO] [stdout] 1132 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1133 | | result [INFO] [stdout] 1134 | | } else { [INFO] [stdout] 1135 | | 0 [INFO] [stdout] 1136 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:931:21 [INFO] [stdout] | [INFO] [stdout] 931 | / if removein != usize::MAX { [INFO] [stdout] 932 | | if removein < self.l_1_9.len() { [INFO] [stdout] 933 | | self.l_1_9.remove(removein); [INFO] [stdout] 934 | | } [INFO] [stdout] 935 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 931 ~ if removein != usize::MAX [INFO] [stdout] 932 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 933 | self.l_1_9.remove(removein); [INFO] [stdout] 934 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:953:22 [INFO] [stdout] | [INFO] [stdout] 953 | ) == String::from("-") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"-"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:948:21 [INFO] [stdout] | [INFO] [stdout] 948 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 949 | | result [INFO] [stdout] 950 | | } else { [INFO] [stdout] 951 | | 0 [INFO] [stdout] 952 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:956:25 [INFO] [stdout] | [INFO] [stdout] 956 | / if let Some(result) = ((self.vf_1_2 - 1.0) as usize).checked_sub(1) { [INFO] [stdout] 957 | | result [INFO] [stdout] 958 | | } else { [INFO] [stdout] 959 | | 0 [INFO] [stdout] 960 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.vf_1_2 - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:981:33 [INFO] [stdout] | [INFO] [stdout] 981 | / ... if let Some(result) = ((self.vf_1_2 + 1.0) as usize).checked_sub(1) [INFO] [stdout] 982 | | ... { [INFO] [stdout] 983 | | ... result [INFO] [stdout] 984 | | ... } else { [INFO] [stdout] 985 | | ... 0 [INFO] [stdout] 986 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.vf_1_2 + 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:1154:56 [INFO] [stdout] | [INFO] [stdout] 1154 | self.vf_1_2 = self.get_position_10(&*self.vs_1_7); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `&self.vs_1_7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:1155:57 [INFO] [stdout] | [INFO] [stdout] 1155 | self.vs_1_2 = (self.get_position_10(&*self.vs_1_7)).to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `&self.vs_1_7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:1157:48 [INFO] [stdout] | [INFO] [stdout] 1157 | - self.get_position_10(&*self.vs_1_7)) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `&self.vs_1_7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1161:29 [INFO] [stdout] | [INFO] [stdout] 1161 | / ... if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1162 | | ... result [INFO] [stdout] 1163 | | ... } else { [INFO] [stdout] 1164 | | ... 0 [INFO] [stdout] 1165 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1169:25 [INFO] [stdout] | [INFO] [stdout] 1169 | / if removein != usize::MAX { [INFO] [stdout] 1170 | | if removein < self.l_1_9.len() { [INFO] [stdout] 1171 | | self.l_1_9.remove(removein); [INFO] [stdout] 1172 | | } [INFO] [stdout] 1173 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1169 ~ if removein != usize::MAX [INFO] [stdout] 1170 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 1171 | self.l_1_9.remove(removein); [INFO] [stdout] 1172 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1175:25 [INFO] [stdout] | [INFO] [stdout] 1175 | / if removein != usize::MAX { [INFO] [stdout] 1176 | | if removein < self.l_1_10.len() { [INFO] [stdout] 1177 | | self.l_1_10.remove(removein); [INFO] [stdout] 1178 | | } [INFO] [stdout] 1179 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1175 ~ if removein != usize::MAX [INFO] [stdout] 1176 ~ && removein < self.l_1_10.len() { [INFO] [stdout] 1177 | self.l_1_10.remove(removein); [INFO] [stdout] 1178 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1193:33 [INFO] [stdout] | [INFO] [stdout] 1193 | / ... if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 1194 | | ... result [INFO] [stdout] 1195 | | ... } else { [INFO] [stdout] 1196 | | ... 0 [INFO] [stdout] 1197 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:1211:30 [INFO] [stdout] | [INFO] [stdout] 1211 | ) == String::from("") [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1206:29 [INFO] [stdout] | [INFO] [stdout] 1206 | / ... if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 1207 | | ... result [INFO] [stdout] 1208 | | ... } else { [INFO] [stdout] 1209 | | ... 0 [INFO] [stdout] 1210 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:1014:22 [INFO] [stdout] | [INFO] [stdout] 1014 | ) == String::from("(") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"("` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1009:21 [INFO] [stdout] | [INFO] [stdout] 1009 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1010 | | result [INFO] [stdout] 1011 | | } else { [INFO] [stdout] 1012 | | 0 [INFO] [stdout] 1013 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1019:21 [INFO] [stdout] | [INFO] [stdout] 1019 | / if removein != usize::MAX { [INFO] [stdout] 1020 | | if removein < self.l_1_9.len() { [INFO] [stdout] 1021 | | self.l_1_9.remove(removein); [INFO] [stdout] 1022 | | } [INFO] [stdout] 1023 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1019 ~ if removein != usize::MAX [INFO] [stdout] 1020 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 1021 | self.l_1_9.remove(removein); [INFO] [stdout] 1022 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1214:29 [INFO] [stdout] | [INFO] [stdout] 1214 | / ... if removein != usize::MAX { [INFO] [stdout] 1215 | | ... if removein < self.l_1_11.len() { [INFO] [stdout] 1216 | | ... self.l_1_11.remove(removein); [INFO] [stdout] 1217 | | ... } [INFO] [stdout] 1218 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1214 ~ if removein != usize::MAX [INFO] [stdout] 1215 ~ && removein < self.l_1_11.len() { [INFO] [stdout] 1216 | self.l_1_11.remove(removein); [INFO] [stdout] 1217 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:1033:26 [INFO] [stdout] | [INFO] [stdout] 1033 | ) == String::from(")") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `")"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1028:25 [INFO] [stdout] | [INFO] [stdout] 1028 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1029 | | result [INFO] [stdout] 1030 | | } else { [INFO] [stdout] 1031 | | 0 [INFO] [stdout] 1032 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1038:25 [INFO] [stdout] | [INFO] [stdout] 1038 | / if removein != usize::MAX { [INFO] [stdout] 1039 | | if removein < self.l_1_9.len() { [INFO] [stdout] 1040 | | self.l_1_9.remove(removein); [INFO] [stdout] 1041 | | } [INFO] [stdout] 1042 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1038 ~ if removein != usize::MAX [INFO] [stdout] 1039 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 1040 | self.l_1_9.remove(removein); [INFO] [stdout] 1041 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1048:37 [INFO] [stdout] | [INFO] [stdout] 1048 | / ... if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1049 | | ... result [INFO] [stdout] 1050 | | ... } else { [INFO] [stdout] 1051 | | ... 0 [INFO] [stdout] 1052 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1077:25 [INFO] [stdout] | [INFO] [stdout] 1077 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1078 | | result [INFO] [stdout] 1079 | | } else { [INFO] [stdout] 1080 | | 0 [INFO] [stdout] 1081 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1094:29 [INFO] [stdout] | [INFO] [stdout] 1094 | / ... if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1095 | | ... result [INFO] [stdout] 1096 | | ... } else { [INFO] [stdout] 1097 | | ... 0 [INFO] [stdout] 1098 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1258:21 [INFO] [stdout] | [INFO] [stdout] 1258 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1259 | | result [INFO] [stdout] 1260 | | } else { [INFO] [stdout] 1261 | | 0 [INFO] [stdout] 1262 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1132:25 [INFO] [stdout] | [INFO] [stdout] 1132 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1133 | | result [INFO] [stdout] 1134 | | } else { [INFO] [stdout] 1135 | | 0 [INFO] [stdout] 1136 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:1154:56 [INFO] [stdout] | [INFO] [stdout] 1154 | self.vf_1_2 = self.get_position_10(&*self.vs_1_7); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `&self.vs_1_7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:1155:57 [INFO] [stdout] | [INFO] [stdout] 1155 | self.vs_1_2 = (self.get_position_10(&*self.vs_1_7)).to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `&self.vs_1_7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:1157:48 [INFO] [stdout] | [INFO] [stdout] 1157 | - self.get_position_10(&*self.vs_1_7)) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `&self.vs_1_7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1161:29 [INFO] [stdout] | [INFO] [stdout] 1161 | / ... if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1162 | | ... result [INFO] [stdout] 1163 | | ... } else { [INFO] [stdout] 1164 | | ... 0 [INFO] [stdout] 1165 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1169:25 [INFO] [stdout] | [INFO] [stdout] 1169 | / if removein != usize::MAX { [INFO] [stdout] 1170 | | if removein < self.l_1_9.len() { [INFO] [stdout] 1171 | | self.l_1_9.remove(removein); [INFO] [stdout] 1172 | | } [INFO] [stdout] 1173 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1169 ~ if removein != usize::MAX [INFO] [stdout] 1170 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 1171 | self.l_1_9.remove(removein); [INFO] [stdout] 1172 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1175:25 [INFO] [stdout] | [INFO] [stdout] 1175 | / if removein != usize::MAX { [INFO] [stdout] 1176 | | if removein < self.l_1_10.len() { [INFO] [stdout] 1177 | | self.l_1_10.remove(removein); [INFO] [stdout] 1178 | | } [INFO] [stdout] 1179 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1175 ~ if removein != usize::MAX [INFO] [stdout] 1176 ~ && removein < self.l_1_10.len() { [INFO] [stdout] 1177 | self.l_1_10.remove(removein); [INFO] [stdout] 1178 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1193:33 [INFO] [stdout] | [INFO] [stdout] 1193 | / ... if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 1194 | | ... result [INFO] [stdout] 1195 | | ... } else { [INFO] [stdout] 1196 | | ... 0 [INFO] [stdout] 1197 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:1211:30 [INFO] [stdout] | [INFO] [stdout] 1211 | ) == String::from("") [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1206:29 [INFO] [stdout] | [INFO] [stdout] 1206 | / ... if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 1207 | | ... result [INFO] [stdout] 1208 | | ... } else { [INFO] [stdout] 1209 | | ... 0 [INFO] [stdout] 1210 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1214:29 [INFO] [stdout] | [INFO] [stdout] 1214 | / ... if removein != usize::MAX { [INFO] [stdout] 1215 | | ... if removein < self.l_1_11.len() { [INFO] [stdout] 1216 | | ... self.l_1_11.remove(removein); [INFO] [stdout] 1217 | | ... } [INFO] [stdout] 1218 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1214 ~ if removein != usize::MAX [INFO] [stdout] 1215 ~ && removein < self.l_1_11.len() { [INFO] [stdout] 1216 | self.l_1_11.remove(removein); [INFO] [stdout] 1217 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1258:21 [INFO] [stdout] | [INFO] [stdout] 1258 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1259 | | result [INFO] [stdout] 1260 | | } else { [INFO] [stdout] 1261 | | 0 [INFO] [stdout] 1262 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Result::unwrap_or` [INFO] [stdout] --> src/rxcalc.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | / match num { [INFO] [stdout] 6 | | Ok(parsed_num) => parsed_num, [INFO] [stdout] 7 | | Err(_) => 0.0, [INFO] [stdout] 8 | | } [INFO] [stdout] | |_____^ help: replace with: `num.unwrap_or(0.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/rxcalc.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / if trimmed_input.is_empty() [INFO] [stdout] 13 | | || trimmed_input == "0" [INFO] [stdout] 14 | | || trimmed_input.eq_ignore_ascii_case("false") [INFO] [stdout] ... | [INFO] [stdout] 18 | | true [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] help: you can reduce it to [INFO] [stdout] | [INFO] [stdout] 12 ~ !(trimmed_input.is_empty() [INFO] [stdout] 13 + || trimmed_input == "0" || trimmed_input.eq_ignore_ascii_case("false")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:100:20 [INFO] [stdout] | [INFO] [stdout] 100 | if !(String::from(pm_12) == String::from(pm_14)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(String::from(pm_12) != String::from(pm_14))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:90:27 [INFO] [stdout] | [INFO] [stdout] 90 | if pm_13.contains(&"==") { [INFO] [stdout] | ^^^^^ help: change this to: `"=="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:91:16 [INFO] [stdout] | [INFO] [stdout] 91 | if String::from(pm_12) == String::from(pm_14) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_12` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:91:39 [INFO] [stdout] | [INFO] [stdout] 91 | if String::from(pm_12) == String::from(pm_14) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_14` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:99:31 [INFO] [stdout] | [INFO] [stdout] 99 | if pm_13.contains(&"!=") { [INFO] [stdout] | ^^^^^ help: change this to: `"!="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:100:22 [INFO] [stdout] | [INFO] [stdout] 100 | if !(String::from(pm_12) == String::from(pm_14)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_12` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:100:45 [INFO] [stdout] | [INFO] [stdout] 100 | if !(String::from(pm_12) == String::from(pm_14)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_14` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:108:35 [INFO] [stdout] | [INFO] [stdout] 108 | if pm_13.contains(&"<") { [INFO] [stdout] | ^^^^ help: change this to: `"<"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:117:39 [INFO] [stdout] | [INFO] [stdout] 117 | if pm_13.contains(&">") { [INFO] [stdout] | ^^^^ help: change this to: `">"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:126:43 [INFO] [stdout] | [INFO] [stdout] 126 | if pm_13.contains(&"<=") { [INFO] [stdout] | ^^^^^ help: change this to: `"<="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:135:47 [INFO] [stdout] | [INFO] [stdout] 135 | ... if pm_13.contains(&">=") { [INFO] [stdout] | ^^^^^ help: change this to: `">="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:144:51 [INFO] [stdout] | [INFO] [stdout] 144 | ... if pm_13.contains(&"+") { [INFO] [stdout] | ^^^^ help: change this to: `"+"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:149:55 [INFO] [stdout] | [INFO] [stdout] 149 | ... if pm_13.contains(&"/") { [INFO] [stdout] | ^^^^ help: change this to: `"/"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:155:59 [INFO] [stdout] | [INFO] [stdout] 155 | ... if pm_13.contains(&"*") { [INFO] [stdout] | ^^^^ help: change this to: `"*"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:162:63 [INFO] [stdout] | [INFO] [stdout] 162 | ... if pm_13.contains(&"%") { [INFO] [stdout] | ^^^^ help: change this to: `"%"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:169:67 [INFO] [stdout] | [INFO] [stdout] 169 | ... if pm_13.contains(&"||") { [INFO] [stdout] | ^^^^^ help: change this to: `"||"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:188:71 [INFO] [stdout] | [INFO] [stdout] 188 | ... if pm_13.contains(&"&&") { [INFO] [stdout] | ^^^^^ help: change this to: `"&&"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:207:75 [INFO] [stdout] | [INFO] [stdout] 207 | ... if pm_13.contains(&"..") { [INFO] [stdout] | ^^^^^ help: change this to: `".."` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/rxcalc.rs:213:67 [INFO] [stdout] | [INFO] [stdout] 213 | ... + &pm_14.to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `pm_14` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:215:79 [INFO] [stdout] | [INFO] [stdout] 215 | ... if pm_13.contains(&"^") { [INFO] [stdout] | ^^^^ help: change this to: `"^"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/rxcalc.rs:222:69 [INFO] [stdout] | [INFO] [stdout] 222 | / ... self.vf_1_6 = self.vf_1_6 [INFO] [stdout] 223 | | ... * get_f64_string(pm_12); [INFO] [stdout] | |_________________________________________________^ help: replace it with: `self.vf_1_6 *= get_f64_string(pm_12)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:229:69 [INFO] [stdout] | [INFO] [stdout] 229 | ... if (String::from(pm_13) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_13` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:230:72 [INFO] [stdout] | [INFO] [stdout] 230 | ... == String::from("")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:231:73 [INFO] [stdout] | [INFO] [stdout] 231 | ... && (String::from(pm_14) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_14` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:232:76 [INFO] [stdout] | [INFO] [stdout] 232 | ... == String::from("")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/rxcalc.rs:264:65 [INFO] [stdout] | [INFO] [stdout] 264 | if let Some(position) = self.l_1_11.iter().position(|x| x == &value_to_find) { [INFO] [stdout] | ^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `value_to_find` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:283:21 [INFO] [stdout] | [INFO] [stdout] 283 | / &*(self.get_item_11( [INFO] [stdout] 284 | | if let Some(result) = [INFO] [stdout] 285 | | ((self.get_position_11("*") - 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 290 | | }, [INFO] [stdout] 291 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 283 ~ &(self.get_item_11( [INFO] [stdout] 284 + if let Some(result) = [INFO] [stdout] 285 + ((self.get_position_11("*") - 1.0) as usize).checked_sub(1) [INFO] [stdout] 286 + { [INFO] [stdout] 287 + result [INFO] [stdout] 288 + } else { [INFO] [stdout] 289 + 0 [INFO] [stdout] 290 + }, [INFO] [stdout] 291 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:284:25 [INFO] [stdout] | [INFO] [stdout] 284 | / if let Some(result) = [INFO] [stdout] 285 | | ((self.get_position_11("*") - 1.0) as usize).checked_sub(1) [INFO] [stdout] 286 | | { [INFO] [stdout] 287 | | result [INFO] [stdout] 288 | | } else { [INFO] [stdout] 289 | | 0 [INFO] [stdout] 290 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("*") - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:292:21 [INFO] [stdout] | [INFO] [stdout] 292 | / &*(self.get_item_11( [INFO] [stdout] 293 | | if let Some(result) = ((self.get_position_11("*")) as usize).checked_sub(1) [INFO] [stdout] 294 | | { [INFO] [stdout] 295 | | result [INFO] [stdout] ... | [INFO] [stdout] 298 | | }, [INFO] [stdout] 299 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 292 ~ &(self.get_item_11( [INFO] [stdout] 293 + if let Some(result) = ((self.get_position_11("*")) as usize).checked_sub(1) [INFO] [stdout] 294 + { [INFO] [stdout] 295 + result [INFO] [stdout] 296 + } else { [INFO] [stdout] 297 + 0 [INFO] [stdout] 298 + }, [INFO] [stdout] 299 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:293:25 [INFO] [stdout] | [INFO] [stdout] 293 | / if let Some(result) = ((self.get_position_11("*")) as usize).checked_sub(1) [INFO] [stdout] 294 | | { [INFO] [stdout] 295 | | result [INFO] [stdout] 296 | | } else { [INFO] [stdout] 297 | | 0 [INFO] [stdout] 298 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("*")) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:300:21 [INFO] [stdout] | [INFO] [stdout] 300 | / &*(self.get_item_11( [INFO] [stdout] 301 | | if let Some(result) = [INFO] [stdout] 302 | | ((self.get_position_11("*") + 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 307 | | }, [INFO] [stdout] 308 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 300 ~ &(self.get_item_11( [INFO] [stdout] 301 + if let Some(result) = [INFO] [stdout] 302 + ((self.get_position_11("*") + 1.0) as usize).checked_sub(1) [INFO] [stdout] 303 + { [INFO] [stdout] 304 + result [INFO] [stdout] 305 + } else { [INFO] [stdout] 306 + 0 [INFO] [stdout] 307 + }, [INFO] [stdout] 308 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:301:25 [INFO] [stdout] | [INFO] [stdout] 301 | / if let Some(result) = [INFO] [stdout] 302 | | ((self.get_position_11("*") + 1.0) as usize).checked_sub(1) [INFO] [stdout] 303 | | { [INFO] [stdout] 304 | | result [INFO] [stdout] 305 | | } else { [INFO] [stdout] 306 | | 0 [INFO] [stdout] 307 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("*") + 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:315:21 [INFO] [stdout] | [INFO] [stdout] 315 | / if removein != usize::MAX { [INFO] [stdout] 316 | | if removein < self.l_1_11.len() { [INFO] [stdout] 317 | | self.l_1_11.remove(removein); [INFO] [stdout] 318 | | } [INFO] [stdout] 319 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 315 ~ if removein != usize::MAX [INFO] [stdout] 316 ~ && removein < self.l_1_11.len() { [INFO] [stdout] 317 | self.l_1_11.remove(removein); [INFO] [stdout] 318 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:330:21 [INFO] [stdout] | [INFO] [stdout] 330 | / &*(self.get_item_11( [INFO] [stdout] 331 | | if let Some(result) = [INFO] [stdout] 332 | | ((self.get_position_11("/") - 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 337 | | }, [INFO] [stdout] 338 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 330 ~ &(self.get_item_11( [INFO] [stdout] 331 + if let Some(result) = [INFO] [stdout] 332 + ((self.get_position_11("/") - 1.0) as usize).checked_sub(1) [INFO] [stdout] 333 + { [INFO] [stdout] 334 + result [INFO] [stdout] 335 + } else { [INFO] [stdout] 336 + 0 [INFO] [stdout] 337 + }, [INFO] [stdout] 338 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:331:25 [INFO] [stdout] | [INFO] [stdout] 331 | / if let Some(result) = [INFO] [stdout] 332 | | ((self.get_position_11("/") - 1.0) as usize).checked_sub(1) [INFO] [stdout] 333 | | { [INFO] [stdout] 334 | | result [INFO] [stdout] 335 | | } else { [INFO] [stdout] 336 | | 0 [INFO] [stdout] 337 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("/") - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:339:21 [INFO] [stdout] | [INFO] [stdout] 339 | / &*(self.get_item_11( [INFO] [stdout] 340 | | if let Some(result) = ((self.get_position_11("/")) as usize).checked_sub(1) [INFO] [stdout] 341 | | { [INFO] [stdout] 342 | | result [INFO] [stdout] ... | [INFO] [stdout] 345 | | }, [INFO] [stdout] 346 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 339 ~ &(self.get_item_11( [INFO] [stdout] 340 + if let Some(result) = ((self.get_position_11("/")) as usize).checked_sub(1) [INFO] [stdout] 341 + { [INFO] [stdout] 342 + result [INFO] [stdout] 343 + } else { [INFO] [stdout] 344 + 0 [INFO] [stdout] 345 + }, [INFO] [stdout] 346 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:340:25 [INFO] [stdout] | [INFO] [stdout] 340 | / if let Some(result) = ((self.get_position_11("/")) as usize).checked_sub(1) [INFO] [stdout] 341 | | { [INFO] [stdout] 342 | | result [INFO] [stdout] 343 | | } else { [INFO] [stdout] 344 | | 0 [INFO] [stdout] 345 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("/")) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:347:21 [INFO] [stdout] | [INFO] [stdout] 347 | / &*(self.get_item_11( [INFO] [stdout] 348 | | if let Some(result) = [INFO] [stdout] 349 | | ((self.get_position_11("/") + 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 354 | | }, [INFO] [stdout] 355 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 347 ~ &(self.get_item_11( [INFO] [stdout] 348 + if let Some(result) = [INFO] [stdout] 349 + ((self.get_position_11("/") + 1.0) as usize).checked_sub(1) [INFO] [stdout] 350 + { [INFO] [stdout] 351 + result [INFO] [stdout] 352 + } else { [INFO] [stdout] 353 + 0 [INFO] [stdout] 354 + }, [INFO] [stdout] 355 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:348:25 [INFO] [stdout] | [INFO] [stdout] 348 | / if let Some(result) = [INFO] [stdout] 349 | | ((self.get_position_11("/") + 1.0) as usize).checked_sub(1) [INFO] [stdout] 350 | | { [INFO] [stdout] 351 | | result [INFO] [stdout] 352 | | } else { [INFO] [stdout] 353 | | 0 [INFO] [stdout] 354 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("/") + 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:362:21 [INFO] [stdout] | [INFO] [stdout] 362 | / if removein != usize::MAX { [INFO] [stdout] 363 | | if removein < self.l_1_11.len() { [INFO] [stdout] 364 | | self.l_1_11.remove(removein); [INFO] [stdout] 365 | | } [INFO] [stdout] 366 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 362 ~ if removein != usize::MAX [INFO] [stdout] 363 ~ && removein < self.l_1_11.len() { [INFO] [stdout] 364 | self.l_1_11.remove(removein); [INFO] [stdout] 365 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:380:15 [INFO] [stdout] | [INFO] [stdout] 380 | while !(!(self.get_contains_11(String::from(pm_15)))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.get_contains_11(String::from(pm_15)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:382:17 [INFO] [stdout] | [INFO] [stdout] 382 | / &*(self.get_item_11( [INFO] [stdout] 383 | | if let Some(result) = [INFO] [stdout] 384 | | ((self.get_position_11(pm_15) - 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 389 | | }, [INFO] [stdout] 390 | | )), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 382 ~ &(self.get_item_11( [INFO] [stdout] 383 + if let Some(result) = [INFO] [stdout] 384 + ((self.get_position_11(pm_15) - 1.0) as usize).checked_sub(1) [INFO] [stdout] 385 + { [INFO] [stdout] 386 + result [INFO] [stdout] 387 + } else { [INFO] [stdout] 388 + 0 [INFO] [stdout] 389 + }, [INFO] [stdout] 390 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:383:21 [INFO] [stdout] | [INFO] [stdout] 383 | / if let Some(result) = [INFO] [stdout] 384 | | ((self.get_position_11(pm_15) - 1.0) as usize).checked_sub(1) [INFO] [stdout] 385 | | { [INFO] [stdout] 386 | | result [INFO] [stdout] 387 | | } else { [INFO] [stdout] 388 | | 0 [INFO] [stdout] 389 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `((self.get_position_11(pm_15) - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:391:17 [INFO] [stdout] | [INFO] [stdout] 391 | / &*(self.get_item_11( [INFO] [stdout] 392 | | if let Some(result) = ((self.get_position_11(pm_15)) as usize).checked_sub(1) { [INFO] [stdout] 393 | | result [INFO] [stdout] 394 | | } else { [INFO] [stdout] 395 | | 0 [INFO] [stdout] 396 | | }, [INFO] [stdout] 397 | | )), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 391 ~ &(self.get_item_11( [INFO] [stdout] 392 + if let Some(result) = ((self.get_position_11(pm_15)) as usize).checked_sub(1) { [INFO] [stdout] 393 + result [INFO] [stdout] 394 + } else { [INFO] [stdout] 395 + 0 [INFO] [stdout] 396 + }, [INFO] [stdout] 397 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:392:21 [INFO] [stdout] | [INFO] [stdout] 392 | / if let Some(result) = ((self.get_position_11(pm_15)) as usize).checked_sub(1) { [INFO] [stdout] 393 | | result [INFO] [stdout] 394 | | } else { [INFO] [stdout] 395 | | 0 [INFO] [stdout] 396 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `((self.get_position_11(pm_15)) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:398:17 [INFO] [stdout] | [INFO] [stdout] 398 | / &*(self.get_item_11( [INFO] [stdout] 399 | | if let Some(result) = [INFO] [stdout] 400 | | ((self.get_position_11(pm_15) + 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 405 | | }, [INFO] [stdout] 406 | | )), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 398 ~ &(self.get_item_11( [INFO] [stdout] 399 + if let Some(result) = [INFO] [stdout] 400 + ((self.get_position_11(pm_15) + 1.0) as usize).checked_sub(1) [INFO] [stdout] 401 + { [INFO] [stdout] 402 + result [INFO] [stdout] 403 + } else { [INFO] [stdout] 404 + 0 [INFO] [stdout] 405 + }, [INFO] [stdout] 406 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:399:21 [INFO] [stdout] | [INFO] [stdout] 399 | / if let Some(result) = [INFO] [stdout] 400 | | ((self.get_position_11(pm_15) + 1.0) as usize).checked_sub(1) [INFO] [stdout] 401 | | { [INFO] [stdout] 402 | | result [INFO] [stdout] 403 | | } else { [INFO] [stdout] 404 | | 0 [INFO] [stdout] 405 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `((self.get_position_11(pm_15) + 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:413:17 [INFO] [stdout] | [INFO] [stdout] 413 | / if removein != usize::MAX { [INFO] [stdout] 414 | | if removein < self.l_1_11.len() { [INFO] [stdout] 415 | | self.l_1_11.remove(removein); [INFO] [stdout] 416 | | } [INFO] [stdout] 417 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 413 ~ if removein != usize::MAX [INFO] [stdout] 414 ~ && removein < self.l_1_11.len() { [INFO] [stdout] 415 | self.l_1_11.remove(removein); [INFO] [stdout] 416 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:437:34 [INFO] [stdout] | [INFO] [stdout] 437 | self.get_item_11(if let Some(result) = (1_usize).checked_sub(1) { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 438 | | result [INFO] [stdout] 439 | | } else { [INFO] [stdout] 440 | | 0 [INFO] [stdout] 441 | | }) [INFO] [stdout] | |_________________^ help: replace it with: `(1_usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:444:44 [INFO] [stdout] | [INFO] [stdout] 444 | self.vs_1_6 = self.get_item_11(if let Some(result) = (1_usize).checked_sub(1) { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 445 | | result [INFO] [stdout] 446 | | } else { [INFO] [stdout] 447 | | 0 [INFO] [stdout] 448 | | }); [INFO] [stdout] | |_____________^ help: replace it with: `(1_usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/rxcalc.rs:501:65 [INFO] [stdout] | [INFO] [stdout] 501 | if let Some(position) = self.l_1_10.iter().position(|x| x == &value_to_find) { [INFO] [stdout] | ^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `value_to_find` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:554:16 [INFO] [stdout] | [INFO] [stdout] 554 | if !(get_char_at(self.vs_1_5.clone(), 1.0) == String::from("-")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(get_char_at(self.vs_1_5.clone(), 1.0) != String::from("-"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:555:20 [INFO] [stdout] | [INFO] [stdout] 555 | && !(get_char_at(self.vs_1_5.clone(), 1.0) == String::from("!")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(get_char_at(self.vs_1_5.clone(), 1.0) != String::from("!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:1152:23 [INFO] [stdout] | [INFO] [stdout] 1152 | while !(!(self.get_contains_10(self.vs_1_7.clone()))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.get_contains_10(self.vs_1_7.clone()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:532:25 [INFO] [stdout] | [INFO] [stdout] 532 | / if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 533 | | result [INFO] [stdout] 534 | | } else { [INFO] [stdout] 535 | | 0 [INFO] [stdout] 536 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:554:59 [INFO] [stdout] | [INFO] [stdout] 554 | if !(get_char_at(self.vs_1_5.clone(), 1.0) == String::from("-")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"-"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:555:63 [INFO] [stdout] | [INFO] [stdout] 555 | && !(get_char_at(self.vs_1_5.clone(), 1.0) == String::from("!")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"!"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:572:70 [INFO] [stdout] | [INFO] [stdout] 572 | if (get_char_at(self.vs_1_5.clone(), self.vf_1_2) == String::from("\"")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"\""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:573:74 [INFO] [stdout] | [INFO] [stdout] 573 | || (get_char_at(self.vs_1_5.clone(), self.vf_1_2) == String::from("'")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"'"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:596:33 [INFO] [stdout] | [INFO] [stdout] 596 | / ... if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 597 | | ... result [INFO] [stdout] 598 | | ... } else { [INFO] [stdout] 599 | | ... 0 [INFO] [stdout] 600 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:613:41 [INFO] [stdout] | [INFO] [stdout] 613 | / ... if let Some(result) = [INFO] [stdout] 614 | | ... ((self.vf_1_4 - 1.0) as usize).checked_sub(1) [INFO] [stdout] 615 | | ... { [INFO] [stdout] 616 | | ... result [INFO] [stdout] 617 | | ... } else { [INFO] [stdout] 618 | | ... 0 [INFO] [stdout] 619 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.vf_1_4 - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:626:45 [INFO] [stdout] | [INFO] [stdout] 626 | / ... if let Some(result) = [INFO] [stdout] 627 | | ... ((self.vf_1_4 - 1.0) as usize).checked_sub(1) [INFO] [stdout] 628 | | ... { [INFO] [stdout] 629 | | ... result [INFO] [stdout] 630 | | ... } else { [INFO] [stdout] 631 | | ... 0 [INFO] [stdout] 632 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.vf_1_4 - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:646:41 [INFO] [stdout] | [INFO] [stdout] 646 | / ... if let Some(result) = [INFO] [stdout] 647 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 648 | | ... { [INFO] [stdout] 649 | | ... result [INFO] [stdout] 650 | | ... } else { [INFO] [stdout] 651 | | ... 0 [INFO] [stdout] 652 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:659:41 [INFO] [stdout] | [INFO] [stdout] 659 | / ... if let Some(result) = [INFO] [stdout] 660 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 661 | | ... { [INFO] [stdout] 662 | | ... result [INFO] [stdout] 663 | | ... } else { [INFO] [stdout] 664 | | ... 0 [INFO] [stdout] 665 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:671:53 [INFO] [stdout] | [INFO] [stdout] 671 | / ... if let Some(result) = ((self.get_leng_9() - 1.0) [INFO] [stdout] 672 | | ... as usize) [INFO] [stdout] 673 | | ... .checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 677 | | ... 0 [INFO] [stdout] 678 | | ... }, [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 671 ~ ((self.get_leng_9() - 1.0) [INFO] [stdout] 672 + as usize) [INFO] [stdout] 673 ~ .checked_sub(1).unwrap_or_default(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:695:41 [INFO] [stdout] | [INFO] [stdout] 695 | / ... if let Some(result) = [INFO] [stdout] 696 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 697 | | ... { [INFO] [stdout] 698 | | ... result [INFO] [stdout] 699 | | ... } else { [INFO] [stdout] 700 | | ... 0 [INFO] [stdout] 701 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:714:37 [INFO] [stdout] | [INFO] [stdout] 714 | / ... if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 715 | | ... result [INFO] [stdout] 716 | | ... } else { [INFO] [stdout] 717 | | ... 0 [INFO] [stdout] 718 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:727:41 [INFO] [stdout] | [INFO] [stdout] 727 | / ... if let Some(result) = [INFO] [stdout] 728 | | ... ((self.vf_1_4 - 1.0) as usize).checked_sub(1) [INFO] [stdout] 729 | | ... { [INFO] [stdout] 730 | | ... result [INFO] [stdout] 731 | | ... } else { [INFO] [stdout] 732 | | ... 0 [INFO] [stdout] 733 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.vf_1_4 - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:745:45 [INFO] [stdout] | [INFO] [stdout] 745 | / ... if let Some(result) = [INFO] [stdout] 746 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 747 | | ... { [INFO] [stdout] 748 | | ... result [INFO] [stdout] 749 | | ... } else { [INFO] [stdout] 750 | | ... 0 [INFO] [stdout] 751 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:759:45 [INFO] [stdout] | [INFO] [stdout] 759 | / ... if let Some(result) = [INFO] [stdout] 760 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 761 | | ... { [INFO] [stdout] 762 | | ... result [INFO] [stdout] 763 | | ... } else { [INFO] [stdout] 764 | | ... 0 [INFO] [stdout] 765 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:771:57 [INFO] [stdout] | [INFO] [stdout] 771 | / ... if let Some(result) = [INFO] [stdout] 772 | | ... ((self.get_leng_9() - 1.0) as usize) [INFO] [stdout] 773 | | ... .checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 777 | | ... 0 [INFO] [stdout] 778 | | ... }, [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 771 ~ ((self.get_leng_9() - 1.0) as usize) [INFO] [stdout] 772 ~ .checked_sub(1).unwrap_or_default(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:795:45 [INFO] [stdout] | [INFO] [stdout] 795 | / ... if let Some(result) = [INFO] [stdout] 796 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 797 | | ... { [INFO] [stdout] 798 | | ... result [INFO] [stdout] 799 | | ... } else { [INFO] [stdout] 800 | | ... 0 [INFO] [stdout] 801 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:820:25 [INFO] [stdout] | [INFO] [stdout] 820 | / if let Some(result) = (self.vf_1_4 as usize).checked_sub(1) { [INFO] [stdout] 821 | | result [INFO] [stdout] 822 | | } else { [INFO] [stdout] 823 | | 0 [INFO] [stdout] 824 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_4 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:833:17 [INFO] [stdout] | [INFO] [stdout] 833 | / if removein != usize::MAX { [INFO] [stdout] 834 | | if removein < self.l_1_9.len() { [INFO] [stdout] 835 | | self.l_1_9.remove(removein); [INFO] [stdout] 836 | | } [INFO] [stdout] 837 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 833 ~ if removein != usize::MAX [INFO] [stdout] 834 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 835 | self.l_1_9.remove(removein); [INFO] [stdout] 836 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Result::unwrap_or` [INFO] [stdout] --> src/rxcalc.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | / match num { [INFO] [stdout] 6 | | Ok(parsed_num) => parsed_num, [INFO] [stdout] 7 | | Err(_) => 0.0, [INFO] [stdout] 8 | | } [INFO] [stdout] | |_____^ help: replace with: `num.unwrap_or(0.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:843:25 [INFO] [stdout] | [INFO] [stdout] 843 | / if let Some(result) = ((self.get_leng_9()) as usize).checked_sub(1) { [INFO] [stdout] 844 | | result [INFO] [stdout] 845 | | } else { [INFO] [stdout] 846 | | 0 [INFO] [stdout] 847 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_leng_9()) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/rxcalc.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / if trimmed_input.is_empty() [INFO] [stdout] 13 | | || trimmed_input == "0" [INFO] [stdout] 14 | | || trimmed_input.eq_ignore_ascii_case("false") [INFO] [stdout] ... | [INFO] [stdout] 18 | | true [INFO] [stdout] 19 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] help: you can reduce it to [INFO] [stdout] | [INFO] [stdout] 12 ~ !(trimmed_input.is_empty() [INFO] [stdout] 13 + || trimmed_input == "0" || trimmed_input.eq_ignore_ascii_case("false")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:854:25 [INFO] [stdout] | [INFO] [stdout] 854 | / if let Some(result) = ((self.get_leng_9()) as usize).checked_sub(1) { [INFO] [stdout] 855 | | result [INFO] [stdout] 856 | | } else { [INFO] [stdout] 857 | | 0 [INFO] [stdout] 858 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_leng_9()) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:864:37 [INFO] [stdout] | [INFO] [stdout] 864 | / ... if let Some(result) = [INFO] [stdout] 865 | | ... ((self.get_leng_9()) as usize).checked_sub(1) [INFO] [stdout] 866 | | ... { [INFO] [stdout] 867 | | ... result [INFO] [stdout] 868 | | ... } else { [INFO] [stdout] 869 | | ... 0 [INFO] [stdout] 870 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9()) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:884:25 [INFO] [stdout] | [INFO] [stdout] 884 | / if let Some(result) = ((self.get_leng_9()) as usize).checked_sub(1) { [INFO] [stdout] 885 | | result [INFO] [stdout] 886 | | } else { [INFO] [stdout] 887 | | 0 [INFO] [stdout] 888 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_leng_9()) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:910:25 [INFO] [stdout] | [INFO] [stdout] 910 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 911 | | result [INFO] [stdout] 912 | | } else { [INFO] [stdout] 913 | | 0 [INFO] [stdout] 914 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:928:22 [INFO] [stdout] | [INFO] [stdout] 928 | ) == String::from("") [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:923:21 [INFO] [stdout] | [INFO] [stdout] 923 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 924 | | result [INFO] [stdout] 925 | | } else { [INFO] [stdout] 926 | | 0 [INFO] [stdout] 927 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:931:21 [INFO] [stdout] | [INFO] [stdout] 931 | / if removein != usize::MAX { [INFO] [stdout] 932 | | if removein < self.l_1_9.len() { [INFO] [stdout] 933 | | self.l_1_9.remove(removein); [INFO] [stdout] 934 | | } [INFO] [stdout] 935 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 931 ~ if removein != usize::MAX [INFO] [stdout] 932 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 933 | self.l_1_9.remove(removein); [INFO] [stdout] 934 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:100:20 [INFO] [stdout] | [INFO] [stdout] 100 | if !(String::from(pm_12) == String::from(pm_14)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(String::from(pm_12) != String::from(pm_14))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:953:22 [INFO] [stdout] | [INFO] [stdout] 953 | ) == String::from("-") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"-"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:948:21 [INFO] [stdout] | [INFO] [stdout] 948 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 949 | | result [INFO] [stdout] 950 | | } else { [INFO] [stdout] 951 | | 0 [INFO] [stdout] 952 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:90:27 [INFO] [stdout] | [INFO] [stdout] 90 | if pm_13.contains(&"==") { [INFO] [stdout] | ^^^^^ help: change this to: `"=="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:91:16 [INFO] [stdout] | [INFO] [stdout] 91 | if String::from(pm_12) == String::from(pm_14) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_12` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:91:39 [INFO] [stdout] | [INFO] [stdout] 91 | if String::from(pm_12) == String::from(pm_14) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_14` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:99:31 [INFO] [stdout] | [INFO] [stdout] 99 | if pm_13.contains(&"!=") { [INFO] [stdout] | ^^^^^ help: change this to: `"!="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:956:25 [INFO] [stdout] | [INFO] [stdout] 956 | / if let Some(result) = ((self.vf_1_2 - 1.0) as usize).checked_sub(1) { [INFO] [stdout] 957 | | result [INFO] [stdout] 958 | | } else { [INFO] [stdout] 959 | | 0 [INFO] [stdout] 960 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.vf_1_2 - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:100:22 [INFO] [stdout] | [INFO] [stdout] 100 | if !(String::from(pm_12) == String::from(pm_14)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_12` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:100:45 [INFO] [stdout] | [INFO] [stdout] 100 | if !(String::from(pm_12) == String::from(pm_14)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_14` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:981:33 [INFO] [stdout] | [INFO] [stdout] 981 | / ... if let Some(result) = ((self.vf_1_2 + 1.0) as usize).checked_sub(1) [INFO] [stdout] 982 | | ... { [INFO] [stdout] 983 | | ... result [INFO] [stdout] 984 | | ... } else { [INFO] [stdout] 985 | | ... 0 [INFO] [stdout] 986 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.vf_1_2 + 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:108:35 [INFO] [stdout] | [INFO] [stdout] 108 | if pm_13.contains(&"<") { [INFO] [stdout] | ^^^^ help: change this to: `"<"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:117:39 [INFO] [stdout] | [INFO] [stdout] 117 | if pm_13.contains(&">") { [INFO] [stdout] | ^^^^ help: change this to: `">"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:1014:22 [INFO] [stdout] | [INFO] [stdout] 1014 | ) == String::from("(") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"("` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1009:21 [INFO] [stdout] | [INFO] [stdout] 1009 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1010 | | result [INFO] [stdout] 1011 | | } else { [INFO] [stdout] 1012 | | 0 [INFO] [stdout] 1013 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:126:43 [INFO] [stdout] | [INFO] [stdout] 126 | if pm_13.contains(&"<=") { [INFO] [stdout] | ^^^^^ help: change this to: `"<="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:135:47 [INFO] [stdout] | [INFO] [stdout] 135 | ... if pm_13.contains(&">=") { [INFO] [stdout] | ^^^^^ help: change this to: `">="` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1019:21 [INFO] [stdout] | [INFO] [stdout] 1019 | / if removein != usize::MAX { [INFO] [stdout] 1020 | | if removein < self.l_1_9.len() { [INFO] [stdout] 1021 | | self.l_1_9.remove(removein); [INFO] [stdout] 1022 | | } [INFO] [stdout] 1023 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1019 ~ if removein != usize::MAX [INFO] [stdout] 1020 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 1021 | self.l_1_9.remove(removein); [INFO] [stdout] 1022 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:144:51 [INFO] [stdout] | [INFO] [stdout] 144 | ... if pm_13.contains(&"+") { [INFO] [stdout] | ^^^^ help: change this to: `"+"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:149:55 [INFO] [stdout] | [INFO] [stdout] 149 | ... if pm_13.contains(&"/") { [INFO] [stdout] | ^^^^ help: change this to: `"/"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:1033:26 [INFO] [stdout] | [INFO] [stdout] 1033 | ) == String::from(")") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `")"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1028:25 [INFO] [stdout] | [INFO] [stdout] 1028 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1029 | | result [INFO] [stdout] 1030 | | } else { [INFO] [stdout] 1031 | | 0 [INFO] [stdout] 1032 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1038:25 [INFO] [stdout] | [INFO] [stdout] 1038 | / if removein != usize::MAX { [INFO] [stdout] 1039 | | if removein < self.l_1_9.len() { [INFO] [stdout] 1040 | | self.l_1_9.remove(removein); [INFO] [stdout] 1041 | | } [INFO] [stdout] 1042 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1038 ~ if removein != usize::MAX [INFO] [stdout] 1039 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 1040 | self.l_1_9.remove(removein); [INFO] [stdout] 1041 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:155:59 [INFO] [stdout] | [INFO] [stdout] 155 | ... if pm_13.contains(&"*") { [INFO] [stdout] | ^^^^ help: change this to: `"*"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1048:37 [INFO] [stdout] | [INFO] [stdout] 1048 | / ... if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1049 | | ... result [INFO] [stdout] 1050 | | ... } else { [INFO] [stdout] 1051 | | ... 0 [INFO] [stdout] 1052 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:162:63 [INFO] [stdout] | [INFO] [stdout] 162 | ... if pm_13.contains(&"%") { [INFO] [stdout] | ^^^^ help: change this to: `"%"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:169:67 [INFO] [stdout] | [INFO] [stdout] 169 | ... if pm_13.contains(&"||") { [INFO] [stdout] | ^^^^^ help: change this to: `"||"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1077:25 [INFO] [stdout] | [INFO] [stdout] 1077 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1078 | | result [INFO] [stdout] 1079 | | } else { [INFO] [stdout] 1080 | | 0 [INFO] [stdout] 1081 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:188:71 [INFO] [stdout] | [INFO] [stdout] 188 | ... if pm_13.contains(&"&&") { [INFO] [stdout] | ^^^^^ help: change this to: `"&&"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1094:29 [INFO] [stdout] | [INFO] [stdout] 1094 | / ... if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1095 | | ... result [INFO] [stdout] 1096 | | ... } else { [INFO] [stdout] 1097 | | ... 0 [INFO] [stdout] 1098 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:207:75 [INFO] [stdout] | [INFO] [stdout] 207 | ... if pm_13.contains(&"..") { [INFO] [stdout] | ^^^^^ help: change this to: `".."` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/rxcalc.rs:213:67 [INFO] [stdout] | [INFO] [stdout] 213 | ... + &pm_14.to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `pm_14` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/rxcalc.rs:215:79 [INFO] [stdout] | [INFO] [stdout] 215 | ... if pm_13.contains(&"^") { [INFO] [stdout] | ^^^^ help: change this to: `"^"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1132:25 [INFO] [stdout] | [INFO] [stdout] 1132 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1133 | | result [INFO] [stdout] 1134 | | } else { [INFO] [stdout] 1135 | | 0 [INFO] [stdout] 1136 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/rxcalc.rs:222:69 [INFO] [stdout] | [INFO] [stdout] 222 | / ... self.vf_1_6 = self.vf_1_6 [INFO] [stdout] 223 | | ... * get_f64_string(pm_12); [INFO] [stdout] | |_________________________________________________^ help: replace it with: `self.vf_1_6 *= get_f64_string(pm_12)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:229:69 [INFO] [stdout] | [INFO] [stdout] 229 | ... if (String::from(pm_13) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_13` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:230:72 [INFO] [stdout] | [INFO] [stdout] 230 | ... == String::from("")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:231:73 [INFO] [stdout] | [INFO] [stdout] 231 | ... && (String::from(pm_14) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `pm_14` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:1154:56 [INFO] [stdout] | [INFO] [stdout] 1154 | self.vf_1_2 = self.get_position_10(&*self.vs_1_7); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `&self.vs_1_7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:232:76 [INFO] [stdout] | [INFO] [stdout] 232 | ... == String::from("")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:1155:57 [INFO] [stdout] | [INFO] [stdout] 1155 | self.vs_1_2 = (self.get_position_10(&*self.vs_1_7)).to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `&self.vs_1_7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:1157:48 [INFO] [stdout] | [INFO] [stdout] 1157 | - self.get_position_10(&*self.vs_1_7)) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `&self.vs_1_7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1161:29 [INFO] [stdout] | [INFO] [stdout] 1161 | / ... if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1162 | | ... result [INFO] [stdout] 1163 | | ... } else { [INFO] [stdout] 1164 | | ... 0 [INFO] [stdout] 1165 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/rxcalc.rs:264:65 [INFO] [stdout] | [INFO] [stdout] 264 | if let Some(position) = self.l_1_11.iter().position(|x| x == &value_to_find) { [INFO] [stdout] | ^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `value_to_find` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1169:25 [INFO] [stdout] | [INFO] [stdout] 1169 | / if removein != usize::MAX { [INFO] [stdout] 1170 | | if removein < self.l_1_9.len() { [INFO] [stdout] 1171 | | self.l_1_9.remove(removein); [INFO] [stdout] 1172 | | } [INFO] [stdout] 1173 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1169 ~ if removein != usize::MAX [INFO] [stdout] 1170 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 1171 | self.l_1_9.remove(removein); [INFO] [stdout] 1172 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1175:25 [INFO] [stdout] | [INFO] [stdout] 1175 | / if removein != usize::MAX { [INFO] [stdout] 1176 | | if removein < self.l_1_10.len() { [INFO] [stdout] 1177 | | self.l_1_10.remove(removein); [INFO] [stdout] 1178 | | } [INFO] [stdout] 1179 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1175 ~ if removein != usize::MAX [INFO] [stdout] 1176 ~ && removein < self.l_1_10.len() { [INFO] [stdout] 1177 | self.l_1_10.remove(removein); [INFO] [stdout] 1178 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:283:21 [INFO] [stdout] | [INFO] [stdout] 283 | / &*(self.get_item_11( [INFO] [stdout] 284 | | if let Some(result) = [INFO] [stdout] 285 | | ((self.get_position_11("*") - 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 290 | | }, [INFO] [stdout] 291 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 283 ~ &(self.get_item_11( [INFO] [stdout] 284 + if let Some(result) = [INFO] [stdout] 285 + ((self.get_position_11("*") - 1.0) as usize).checked_sub(1) [INFO] [stdout] 286 + { [INFO] [stdout] 287 + result [INFO] [stdout] 288 + } else { [INFO] [stdout] 289 + 0 [INFO] [stdout] 290 + }, [INFO] [stdout] 291 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:284:25 [INFO] [stdout] | [INFO] [stdout] 284 | / if let Some(result) = [INFO] [stdout] 285 | | ((self.get_position_11("*") - 1.0) as usize).checked_sub(1) [INFO] [stdout] 286 | | { [INFO] [stdout] 287 | | result [INFO] [stdout] 288 | | } else { [INFO] [stdout] 289 | | 0 [INFO] [stdout] 290 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("*") - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1193:33 [INFO] [stdout] | [INFO] [stdout] 1193 | / ... if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 1194 | | ... result [INFO] [stdout] 1195 | | ... } else { [INFO] [stdout] 1196 | | ... 0 [INFO] [stdout] 1197 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:292:21 [INFO] [stdout] | [INFO] [stdout] 292 | / &*(self.get_item_11( [INFO] [stdout] 293 | | if let Some(result) = ((self.get_position_11("*")) as usize).checked_sub(1) [INFO] [stdout] 294 | | { [INFO] [stdout] 295 | | result [INFO] [stdout] ... | [INFO] [stdout] 298 | | }, [INFO] [stdout] 299 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 292 ~ &(self.get_item_11( [INFO] [stdout] 293 + if let Some(result) = ((self.get_position_11("*")) as usize).checked_sub(1) [INFO] [stdout] 294 + { [INFO] [stdout] 295 + result [INFO] [stdout] 296 + } else { [INFO] [stdout] 297 + 0 [INFO] [stdout] 298 + }, [INFO] [stdout] 299 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:1211:30 [INFO] [stdout] | [INFO] [stdout] 1211 | ) == String::from("") [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:293:25 [INFO] [stdout] | [INFO] [stdout] 293 | / if let Some(result) = ((self.get_position_11("*")) as usize).checked_sub(1) [INFO] [stdout] 294 | | { [INFO] [stdout] 295 | | result [INFO] [stdout] 296 | | } else { [INFO] [stdout] 297 | | 0 [INFO] [stdout] 298 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("*")) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1206:29 [INFO] [stdout] | [INFO] [stdout] 1206 | / ... if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 1207 | | ... result [INFO] [stdout] 1208 | | ... } else { [INFO] [stdout] 1209 | | ... 0 [INFO] [stdout] 1210 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:300:21 [INFO] [stdout] | [INFO] [stdout] 300 | / &*(self.get_item_11( [INFO] [stdout] 301 | | if let Some(result) = [INFO] [stdout] 302 | | ((self.get_position_11("*") + 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 307 | | }, [INFO] [stdout] 308 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 300 ~ &(self.get_item_11( [INFO] [stdout] 301 + if let Some(result) = [INFO] [stdout] 302 + ((self.get_position_11("*") + 1.0) as usize).checked_sub(1) [INFO] [stdout] 303 + { [INFO] [stdout] 304 + result [INFO] [stdout] 305 + } else { [INFO] [stdout] 306 + 0 [INFO] [stdout] 307 + }, [INFO] [stdout] 308 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:301:25 [INFO] [stdout] | [INFO] [stdout] 301 | / if let Some(result) = [INFO] [stdout] 302 | | ((self.get_position_11("*") + 1.0) as usize).checked_sub(1) [INFO] [stdout] 303 | | { [INFO] [stdout] 304 | | result [INFO] [stdout] 305 | | } else { [INFO] [stdout] 306 | | 0 [INFO] [stdout] 307 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("*") + 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1214:29 [INFO] [stdout] | [INFO] [stdout] 1214 | / ... if removein != usize::MAX { [INFO] [stdout] 1215 | | ... if removein < self.l_1_11.len() { [INFO] [stdout] 1216 | | ... self.l_1_11.remove(removein); [INFO] [stdout] 1217 | | ... } [INFO] [stdout] 1218 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1214 ~ if removein != usize::MAX [INFO] [stdout] 1215 ~ && removein < self.l_1_11.len() { [INFO] [stdout] 1216 | self.l_1_11.remove(removein); [INFO] [stdout] 1217 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:315:21 [INFO] [stdout] | [INFO] [stdout] 315 | / if removein != usize::MAX { [INFO] [stdout] 316 | | if removein < self.l_1_11.len() { [INFO] [stdout] 317 | | self.l_1_11.remove(removein); [INFO] [stdout] 318 | | } [INFO] [stdout] 319 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 315 ~ if removein != usize::MAX [INFO] [stdout] 316 ~ && removein < self.l_1_11.len() { [INFO] [stdout] 317 | self.l_1_11.remove(removein); [INFO] [stdout] 318 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:330:21 [INFO] [stdout] | [INFO] [stdout] 330 | / &*(self.get_item_11( [INFO] [stdout] 331 | | if let Some(result) = [INFO] [stdout] 332 | | ((self.get_position_11("/") - 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 337 | | }, [INFO] [stdout] 338 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 330 ~ &(self.get_item_11( [INFO] [stdout] 331 + if let Some(result) = [INFO] [stdout] 332 + ((self.get_position_11("/") - 1.0) as usize).checked_sub(1) [INFO] [stdout] 333 + { [INFO] [stdout] 334 + result [INFO] [stdout] 335 + } else { [INFO] [stdout] 336 + 0 [INFO] [stdout] 337 + }, [INFO] [stdout] 338 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:331:25 [INFO] [stdout] | [INFO] [stdout] 331 | / if let Some(result) = [INFO] [stdout] 332 | | ((self.get_position_11("/") - 1.0) as usize).checked_sub(1) [INFO] [stdout] 333 | | { [INFO] [stdout] 334 | | result [INFO] [stdout] 335 | | } else { [INFO] [stdout] 336 | | 0 [INFO] [stdout] 337 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("/") - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1258:21 [INFO] [stdout] | [INFO] [stdout] 1258 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1259 | | result [INFO] [stdout] 1260 | | } else { [INFO] [stdout] 1261 | | 0 [INFO] [stdout] 1262 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:339:21 [INFO] [stdout] | [INFO] [stdout] 339 | / &*(self.get_item_11( [INFO] [stdout] 340 | | if let Some(result) = ((self.get_position_11("/")) as usize).checked_sub(1) [INFO] [stdout] 341 | | { [INFO] [stdout] 342 | | result [INFO] [stdout] ... | [INFO] [stdout] 345 | | }, [INFO] [stdout] 346 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 339 ~ &(self.get_item_11( [INFO] [stdout] 340 + if let Some(result) = ((self.get_position_11("/")) as usize).checked_sub(1) [INFO] [stdout] 341 + { [INFO] [stdout] 342 + result [INFO] [stdout] 343 + } else { [INFO] [stdout] 344 + 0 [INFO] [stdout] 345 + }, [INFO] [stdout] 346 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:340:25 [INFO] [stdout] | [INFO] [stdout] 340 | / if let Some(result) = ((self.get_position_11("/")) as usize).checked_sub(1) [INFO] [stdout] 341 | | { [INFO] [stdout] 342 | | result [INFO] [stdout] 343 | | } else { [INFO] [stdout] 344 | | 0 [INFO] [stdout] 345 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("/")) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:347:21 [INFO] [stdout] | [INFO] [stdout] 347 | / &*(self.get_item_11( [INFO] [stdout] 348 | | if let Some(result) = [INFO] [stdout] 349 | | ((self.get_position_11("/") + 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 354 | | }, [INFO] [stdout] 355 | | )), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 347 ~ &(self.get_item_11( [INFO] [stdout] 348 + if let Some(result) = [INFO] [stdout] 349 + ((self.get_position_11("/") + 1.0) as usize).checked_sub(1) [INFO] [stdout] 350 + { [INFO] [stdout] 351 + result [INFO] [stdout] 352 + } else { [INFO] [stdout] 353 + 0 [INFO] [stdout] 354 + }, [INFO] [stdout] 355 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:348:25 [INFO] [stdout] | [INFO] [stdout] 348 | / if let Some(result) = [INFO] [stdout] 349 | | ((self.get_position_11("/") + 1.0) as usize).checked_sub(1) [INFO] [stdout] 350 | | { [INFO] [stdout] 351 | | result [INFO] [stdout] 352 | | } else { [INFO] [stdout] 353 | | 0 [INFO] [stdout] 354 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_position_11("/") + 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:362:21 [INFO] [stdout] | [INFO] [stdout] 362 | / if removein != usize::MAX { [INFO] [stdout] 363 | | if removein < self.l_1_11.len() { [INFO] [stdout] 364 | | self.l_1_11.remove(removein); [INFO] [stdout] 365 | | } [INFO] [stdout] 366 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 362 ~ if removein != usize::MAX [INFO] [stdout] 363 ~ && removein < self.l_1_11.len() { [INFO] [stdout] 364 | self.l_1_11.remove(removein); [INFO] [stdout] 365 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:380:15 [INFO] [stdout] | [INFO] [stdout] 380 | while !(!(self.get_contains_11(String::from(pm_15)))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.get_contains_11(String::from(pm_15)))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:382:17 [INFO] [stdout] | [INFO] [stdout] 382 | / &*(self.get_item_11( [INFO] [stdout] 383 | | if let Some(result) = [INFO] [stdout] 384 | | ((self.get_position_11(pm_15) - 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 389 | | }, [INFO] [stdout] 390 | | )), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 382 ~ &(self.get_item_11( [INFO] [stdout] 383 + if let Some(result) = [INFO] [stdout] 384 + ((self.get_position_11(pm_15) - 1.0) as usize).checked_sub(1) [INFO] [stdout] 385 + { [INFO] [stdout] 386 + result [INFO] [stdout] 387 + } else { [INFO] [stdout] 388 + 0 [INFO] [stdout] 389 + }, [INFO] [stdout] 390 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:383:21 [INFO] [stdout] | [INFO] [stdout] 383 | / if let Some(result) = [INFO] [stdout] 384 | | ((self.get_position_11(pm_15) - 1.0) as usize).checked_sub(1) [INFO] [stdout] 385 | | { [INFO] [stdout] 386 | | result [INFO] [stdout] 387 | | } else { [INFO] [stdout] 388 | | 0 [INFO] [stdout] 389 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `((self.get_position_11(pm_15) - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:391:17 [INFO] [stdout] | [INFO] [stdout] 391 | / &*(self.get_item_11( [INFO] [stdout] 392 | | if let Some(result) = ((self.get_position_11(pm_15)) as usize).checked_sub(1) { [INFO] [stdout] 393 | | result [INFO] [stdout] 394 | | } else { [INFO] [stdout] 395 | | 0 [INFO] [stdout] 396 | | }, [INFO] [stdout] 397 | | )), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 391 ~ &(self.get_item_11( [INFO] [stdout] 392 + if let Some(result) = ((self.get_position_11(pm_15)) as usize).checked_sub(1) { [INFO] [stdout] 393 + result [INFO] [stdout] 394 + } else { [INFO] [stdout] 395 + 0 [INFO] [stdout] 396 + }, [INFO] [stdout] 397 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:392:21 [INFO] [stdout] | [INFO] [stdout] 392 | / if let Some(result) = ((self.get_position_11(pm_15)) as usize).checked_sub(1) { [INFO] [stdout] 393 | | result [INFO] [stdout] 394 | | } else { [INFO] [stdout] 395 | | 0 [INFO] [stdout] 396 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `((self.get_position_11(pm_15)) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:398:17 [INFO] [stdout] | [INFO] [stdout] 398 | / &*(self.get_item_11( [INFO] [stdout] 399 | | if let Some(result) = [INFO] [stdout] 400 | | ((self.get_position_11(pm_15) + 1.0) as usize).checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 405 | | }, [INFO] [stdout] 406 | | )), [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 398 ~ &(self.get_item_11( [INFO] [stdout] 399 + if let Some(result) = [INFO] [stdout] 400 + ((self.get_position_11(pm_15) + 1.0) as usize).checked_sub(1) [INFO] [stdout] 401 + { [INFO] [stdout] 402 + result [INFO] [stdout] 403 + } else { [INFO] [stdout] 404 + 0 [INFO] [stdout] 405 + }, [INFO] [stdout] 406 ~ )), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:399:21 [INFO] [stdout] | [INFO] [stdout] 399 | / if let Some(result) = [INFO] [stdout] 400 | | ((self.get_position_11(pm_15) + 1.0) as usize).checked_sub(1) [INFO] [stdout] 401 | | { [INFO] [stdout] 402 | | result [INFO] [stdout] 403 | | } else { [INFO] [stdout] 404 | | 0 [INFO] [stdout] 405 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `((self.get_position_11(pm_15) + 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:413:17 [INFO] [stdout] | [INFO] [stdout] 413 | / if removein != usize::MAX { [INFO] [stdout] 414 | | if removein < self.l_1_11.len() { [INFO] [stdout] 415 | | self.l_1_11.remove(removein); [INFO] [stdout] 416 | | } [INFO] [stdout] 417 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 413 ~ if removein != usize::MAX [INFO] [stdout] 414 ~ && removein < self.l_1_11.len() { [INFO] [stdout] 415 | self.l_1_11.remove(removein); [INFO] [stdout] 416 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:437:34 [INFO] [stdout] | [INFO] [stdout] 437 | self.get_item_11(if let Some(result) = (1_usize).checked_sub(1) { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 438 | | result [INFO] [stdout] 439 | | } else { [INFO] [stdout] 440 | | 0 [INFO] [stdout] 441 | | }) [INFO] [stdout] | |_________________^ help: replace it with: `(1_usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:444:44 [INFO] [stdout] | [INFO] [stdout] 444 | self.vs_1_6 = self.get_item_11(if let Some(result) = (1_usize).checked_sub(1) { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 445 | | result [INFO] [stdout] 446 | | } else { [INFO] [stdout] 447 | | 0 [INFO] [stdout] 448 | | }); [INFO] [stdout] | |_____________^ help: replace it with: `(1_usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/rxcalc.rs:501:65 [INFO] [stdout] | [INFO] [stdout] 501 | if let Some(position) = self.l_1_10.iter().position(|x| x == &value_to_find) { [INFO] [stdout] | ^^^^^-------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `value_to_find` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:554:16 [INFO] [stdout] | [INFO] [stdout] 554 | if !(get_char_at(self.vs_1_5.clone(), 1.0) == String::from("-")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(get_char_at(self.vs_1_5.clone(), 1.0) != String::from("-"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:555:20 [INFO] [stdout] | [INFO] [stdout] 555 | && !(get_char_at(self.vs_1_5.clone(), 1.0) == String::from("!")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(get_char_at(self.vs_1_5.clone(), 1.0) != String::from("!"))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/rxcalc.rs:1152:23 [INFO] [stdout] | [INFO] [stdout] 1152 | while !(!(self.get_contains_10(self.vs_1_7.clone()))) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.get_contains_10(self.vs_1_7.clone()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:532:25 [INFO] [stdout] | [INFO] [stdout] 532 | / if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 533 | | result [INFO] [stdout] 534 | | } else { [INFO] [stdout] 535 | | 0 [INFO] [stdout] 536 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:554:59 [INFO] [stdout] | [INFO] [stdout] 554 | if !(get_char_at(self.vs_1_5.clone(), 1.0) == String::from("-")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"-"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:555:63 [INFO] [stdout] | [INFO] [stdout] 555 | && !(get_char_at(self.vs_1_5.clone(), 1.0) == String::from("!")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"!"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:572:70 [INFO] [stdout] | [INFO] [stdout] 572 | if (get_char_at(self.vs_1_5.clone(), self.vf_1_2) == String::from("\"")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"\""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:573:74 [INFO] [stdout] | [INFO] [stdout] 573 | || (get_char_at(self.vs_1_5.clone(), self.vf_1_2) == String::from("'")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"'"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:596:33 [INFO] [stdout] | [INFO] [stdout] 596 | / ... if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 597 | | ... result [INFO] [stdout] 598 | | ... } else { [INFO] [stdout] 599 | | ... 0 [INFO] [stdout] 600 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:613:41 [INFO] [stdout] | [INFO] [stdout] 613 | / ... if let Some(result) = [INFO] [stdout] 614 | | ... ((self.vf_1_4 - 1.0) as usize).checked_sub(1) [INFO] [stdout] 615 | | ... { [INFO] [stdout] 616 | | ... result [INFO] [stdout] 617 | | ... } else { [INFO] [stdout] 618 | | ... 0 [INFO] [stdout] 619 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.vf_1_4 - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:626:45 [INFO] [stdout] | [INFO] [stdout] 626 | / ... if let Some(result) = [INFO] [stdout] 627 | | ... ((self.vf_1_4 - 1.0) as usize).checked_sub(1) [INFO] [stdout] 628 | | ... { [INFO] [stdout] 629 | | ... result [INFO] [stdout] 630 | | ... } else { [INFO] [stdout] 631 | | ... 0 [INFO] [stdout] 632 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.vf_1_4 - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:646:41 [INFO] [stdout] | [INFO] [stdout] 646 | / ... if let Some(result) = [INFO] [stdout] 647 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 648 | | ... { [INFO] [stdout] 649 | | ... result [INFO] [stdout] 650 | | ... } else { [INFO] [stdout] 651 | | ... 0 [INFO] [stdout] 652 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:659:41 [INFO] [stdout] | [INFO] [stdout] 659 | / ... if let Some(result) = [INFO] [stdout] 660 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 661 | | ... { [INFO] [stdout] 662 | | ... result [INFO] [stdout] 663 | | ... } else { [INFO] [stdout] 664 | | ... 0 [INFO] [stdout] 665 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:671:53 [INFO] [stdout] | [INFO] [stdout] 671 | / ... if let Some(result) = ((self.get_leng_9() - 1.0) [INFO] [stdout] 672 | | ... as usize) [INFO] [stdout] 673 | | ... .checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 677 | | ... 0 [INFO] [stdout] 678 | | ... }, [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 671 ~ ((self.get_leng_9() - 1.0) [INFO] [stdout] 672 + as usize) [INFO] [stdout] 673 ~ .checked_sub(1).unwrap_or_default(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:695:41 [INFO] [stdout] | [INFO] [stdout] 695 | / ... if let Some(result) = [INFO] [stdout] 696 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 697 | | ... { [INFO] [stdout] 698 | | ... result [INFO] [stdout] 699 | | ... } else { [INFO] [stdout] 700 | | ... 0 [INFO] [stdout] 701 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:714:37 [INFO] [stdout] | [INFO] [stdout] 714 | / ... if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 715 | | ... result [INFO] [stdout] 716 | | ... } else { [INFO] [stdout] 717 | | ... 0 [INFO] [stdout] 718 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:727:41 [INFO] [stdout] | [INFO] [stdout] 727 | / ... if let Some(result) = [INFO] [stdout] 728 | | ... ((self.vf_1_4 - 1.0) as usize).checked_sub(1) [INFO] [stdout] 729 | | ... { [INFO] [stdout] 730 | | ... result [INFO] [stdout] 731 | | ... } else { [INFO] [stdout] 732 | | ... 0 [INFO] [stdout] 733 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.vf_1_4 - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:745:45 [INFO] [stdout] | [INFO] [stdout] 745 | / ... if let Some(result) = [INFO] [stdout] 746 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 747 | | ... { [INFO] [stdout] 748 | | ... result [INFO] [stdout] 749 | | ... } else { [INFO] [stdout] 750 | | ... 0 [INFO] [stdout] 751 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:759:45 [INFO] [stdout] | [INFO] [stdout] 759 | / ... if let Some(result) = [INFO] [stdout] 760 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 761 | | ... { [INFO] [stdout] 762 | | ... result [INFO] [stdout] 763 | | ... } else { [INFO] [stdout] 764 | | ... 0 [INFO] [stdout] 765 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:771:57 [INFO] [stdout] | [INFO] [stdout] 771 | / ... if let Some(result) = [INFO] [stdout] 772 | | ... ((self.get_leng_9() - 1.0) as usize) [INFO] [stdout] 773 | | ... .checked_sub(1) [INFO] [stdout] ... | [INFO] [stdout] 777 | | ... 0 [INFO] [stdout] 778 | | ... }, [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 771 ~ ((self.get_leng_9() - 1.0) as usize) [INFO] [stdout] 772 ~ .checked_sub(1).unwrap_or_default(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:795:45 [INFO] [stdout] | [INFO] [stdout] 795 | / ... if let Some(result) = [INFO] [stdout] 796 | | ... ((self.get_leng_9() - 1.0) as usize).checked_sub(1) [INFO] [stdout] 797 | | ... { [INFO] [stdout] 798 | | ... result [INFO] [stdout] 799 | | ... } else { [INFO] [stdout] 800 | | ... 0 [INFO] [stdout] 801 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9() - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:820:25 [INFO] [stdout] | [INFO] [stdout] 820 | / if let Some(result) = (self.vf_1_4 as usize).checked_sub(1) { [INFO] [stdout] 821 | | result [INFO] [stdout] 822 | | } else { [INFO] [stdout] 823 | | 0 [INFO] [stdout] 824 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_4 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:833:17 [INFO] [stdout] | [INFO] [stdout] 833 | / if removein != usize::MAX { [INFO] [stdout] 834 | | if removein < self.l_1_9.len() { [INFO] [stdout] 835 | | self.l_1_9.remove(removein); [INFO] [stdout] 836 | | } [INFO] [stdout] 837 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 833 ~ if removein != usize::MAX [INFO] [stdout] 834 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 835 | self.l_1_9.remove(removein); [INFO] [stdout] 836 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:843:25 [INFO] [stdout] | [INFO] [stdout] 843 | / if let Some(result) = ((self.get_leng_9()) as usize).checked_sub(1) { [INFO] [stdout] 844 | | result [INFO] [stdout] 845 | | } else { [INFO] [stdout] 846 | | 0 [INFO] [stdout] 847 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_leng_9()) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:854:25 [INFO] [stdout] | [INFO] [stdout] 854 | / if let Some(result) = ((self.get_leng_9()) as usize).checked_sub(1) { [INFO] [stdout] 855 | | result [INFO] [stdout] 856 | | } else { [INFO] [stdout] 857 | | 0 [INFO] [stdout] 858 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_leng_9()) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:864:37 [INFO] [stdout] | [INFO] [stdout] 864 | / ... if let Some(result) = [INFO] [stdout] 865 | | ... ((self.get_leng_9()) as usize).checked_sub(1) [INFO] [stdout] 866 | | ... { [INFO] [stdout] 867 | | ... result [INFO] [stdout] 868 | | ... } else { [INFO] [stdout] 869 | | ... 0 [INFO] [stdout] 870 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.get_leng_9()) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:884:25 [INFO] [stdout] | [INFO] [stdout] 884 | / if let Some(result) = ((self.get_leng_9()) as usize).checked_sub(1) { [INFO] [stdout] 885 | | result [INFO] [stdout] 886 | | } else { [INFO] [stdout] 887 | | 0 [INFO] [stdout] 888 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.get_leng_9()) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:910:25 [INFO] [stdout] | [INFO] [stdout] 910 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 911 | | result [INFO] [stdout] 912 | | } else { [INFO] [stdout] 913 | | 0 [INFO] [stdout] 914 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:928:22 [INFO] [stdout] | [INFO] [stdout] 928 | ) == String::from("") [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:923:21 [INFO] [stdout] | [INFO] [stdout] 923 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 924 | | result [INFO] [stdout] 925 | | } else { [INFO] [stdout] 926 | | 0 [INFO] [stdout] 927 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:931:21 [INFO] [stdout] | [INFO] [stdout] 931 | / if removein != usize::MAX { [INFO] [stdout] 932 | | if removein < self.l_1_9.len() { [INFO] [stdout] 933 | | self.l_1_9.remove(removein); [INFO] [stdout] 934 | | } [INFO] [stdout] 935 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 931 ~ if removein != usize::MAX [INFO] [stdout] 932 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 933 | self.l_1_9.remove(removein); [INFO] [stdout] 934 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:953:22 [INFO] [stdout] | [INFO] [stdout] 953 | ) == String::from("-") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"-"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:948:21 [INFO] [stdout] | [INFO] [stdout] 948 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 949 | | result [INFO] [stdout] 950 | | } else { [INFO] [stdout] 951 | | 0 [INFO] [stdout] 952 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:956:25 [INFO] [stdout] | [INFO] [stdout] 956 | / if let Some(result) = ((self.vf_1_2 - 1.0) as usize).checked_sub(1) { [INFO] [stdout] 957 | | result [INFO] [stdout] 958 | | } else { [INFO] [stdout] 959 | | 0 [INFO] [stdout] 960 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `((self.vf_1_2 - 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:981:33 [INFO] [stdout] | [INFO] [stdout] 981 | / ... if let Some(result) = ((self.vf_1_2 + 1.0) as usize).checked_sub(1) [INFO] [stdout] 982 | | ... { [INFO] [stdout] 983 | | ... result [INFO] [stdout] 984 | | ... } else { [INFO] [stdout] 985 | | ... 0 [INFO] [stdout] 986 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `((self.vf_1_2 + 1.0) as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:1014:22 [INFO] [stdout] | [INFO] [stdout] 1014 | ) == String::from("(") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"("` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1009:21 [INFO] [stdout] | [INFO] [stdout] 1009 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1010 | | result [INFO] [stdout] 1011 | | } else { [INFO] [stdout] 1012 | | 0 [INFO] [stdout] 1013 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1019:21 [INFO] [stdout] | [INFO] [stdout] 1019 | / if removein != usize::MAX { [INFO] [stdout] 1020 | | if removein < self.l_1_9.len() { [INFO] [stdout] 1021 | | self.l_1_9.remove(removein); [INFO] [stdout] 1022 | | } [INFO] [stdout] 1023 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1019 ~ if removein != usize::MAX [INFO] [stdout] 1020 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 1021 | self.l_1_9.remove(removein); [INFO] [stdout] 1022 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:1033:26 [INFO] [stdout] | [INFO] [stdout] 1033 | ) == String::from(")") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `")"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1028:25 [INFO] [stdout] | [INFO] [stdout] 1028 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1029 | | result [INFO] [stdout] 1030 | | } else { [INFO] [stdout] 1031 | | 0 [INFO] [stdout] 1032 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1038:25 [INFO] [stdout] | [INFO] [stdout] 1038 | / if removein != usize::MAX { [INFO] [stdout] 1039 | | if removein < self.l_1_9.len() { [INFO] [stdout] 1040 | | self.l_1_9.remove(removein); [INFO] [stdout] 1041 | | } [INFO] [stdout] 1042 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1038 ~ if removein != usize::MAX [INFO] [stdout] 1039 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 1040 | self.l_1_9.remove(removein); [INFO] [stdout] 1041 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1048:37 [INFO] [stdout] | [INFO] [stdout] 1048 | / ... if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1049 | | ... result [INFO] [stdout] 1050 | | ... } else { [INFO] [stdout] 1051 | | ... 0 [INFO] [stdout] 1052 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1077:25 [INFO] [stdout] | [INFO] [stdout] 1077 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1078 | | result [INFO] [stdout] 1079 | | } else { [INFO] [stdout] 1080 | | 0 [INFO] [stdout] 1081 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1094:29 [INFO] [stdout] | [INFO] [stdout] 1094 | / ... if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1095 | | ... result [INFO] [stdout] 1096 | | ... } else { [INFO] [stdout] 1097 | | ... 0 [INFO] [stdout] 1098 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1132:25 [INFO] [stdout] | [INFO] [stdout] 1132 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1133 | | result [INFO] [stdout] 1134 | | } else { [INFO] [stdout] 1135 | | 0 [INFO] [stdout] 1136 | | }, [INFO] [stdout] | |_________________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:1154:56 [INFO] [stdout] | [INFO] [stdout] 1154 | self.vf_1_2 = self.get_position_10(&*self.vs_1_7); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `&self.vs_1_7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:1155:57 [INFO] [stdout] | [INFO] [stdout] 1155 | self.vs_1_2 = (self.get_position_10(&*self.vs_1_7)).to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `&self.vs_1_7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/rxcalc.rs:1157:48 [INFO] [stdout] | [INFO] [stdout] 1157 | - self.get_position_10(&*self.vs_1_7)) [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `&self.vs_1_7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1161:29 [INFO] [stdout] | [INFO] [stdout] 1161 | / ... if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1162 | | ... result [INFO] [stdout] 1163 | | ... } else { [INFO] [stdout] 1164 | | ... 0 [INFO] [stdout] 1165 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1169:25 [INFO] [stdout] | [INFO] [stdout] 1169 | / if removein != usize::MAX { [INFO] [stdout] 1170 | | if removein < self.l_1_9.len() { [INFO] [stdout] 1171 | | self.l_1_9.remove(removein); [INFO] [stdout] 1172 | | } [INFO] [stdout] 1173 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1169 ~ if removein != usize::MAX [INFO] [stdout] 1170 ~ && removein < self.l_1_9.len() { [INFO] [stdout] 1171 | self.l_1_9.remove(removein); [INFO] [stdout] 1172 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1175:25 [INFO] [stdout] | [INFO] [stdout] 1175 | / if removein != usize::MAX { [INFO] [stdout] 1176 | | if removein < self.l_1_10.len() { [INFO] [stdout] 1177 | | self.l_1_10.remove(removein); [INFO] [stdout] 1178 | | } [INFO] [stdout] 1179 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1175 ~ if removein != usize::MAX [INFO] [stdout] 1176 ~ && removein < self.l_1_10.len() { [INFO] [stdout] 1177 | self.l_1_10.remove(removein); [INFO] [stdout] 1178 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1193:33 [INFO] [stdout] | [INFO] [stdout] 1193 | / ... if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 1194 | | ... result [INFO] [stdout] 1195 | | ... } else { [INFO] [stdout] 1196 | | ... 0 [INFO] [stdout] 1197 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/rxcalc.rs:1211:30 [INFO] [stdout] | [INFO] [stdout] 1211 | ) == String::from("") [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1206:29 [INFO] [stdout] | [INFO] [stdout] 1206 | / ... if let Some(result) = (self.vf_1_3 as usize).checked_sub(1) { [INFO] [stdout] 1207 | | ... result [INFO] [stdout] 1208 | | ... } else { [INFO] [stdout] 1209 | | ... 0 [INFO] [stdout] 1210 | | ... }, [INFO] [stdout] | |_______________________^ help: replace it with: `(self.vf_1_3 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/rxcalc.rs:1214:29 [INFO] [stdout] | [INFO] [stdout] 1214 | / ... if removein != usize::MAX { [INFO] [stdout] 1215 | | ... if removein < self.l_1_11.len() { [INFO] [stdout] 1216 | | ... self.l_1_11.remove(removein); [INFO] [stdout] 1217 | | ... } [INFO] [stdout] 1218 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1214 ~ if removein != usize::MAX [INFO] [stdout] 1215 ~ && removein < self.l_1_11.len() { [INFO] [stdout] 1216 | self.l_1_11.remove(removein); [INFO] [stdout] 1217 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: if let can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/rxcalc.rs:1258:21 [INFO] [stdout] | [INFO] [stdout] 1258 | / if let Some(result) = (self.vf_1_2 as usize).checked_sub(1) { [INFO] [stdout] 1259 | | result [INFO] [stdout] 1260 | | } else { [INFO] [stdout] 1261 | | 0 [INFO] [stdout] 1262 | | }, [INFO] [stdout] | |_____________________^ help: replace it with: `(self.vf_1_2 as usize).checked_sub(1).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.58s [INFO] running `Command { std: "docker" "inspect" "94cfe8750a2fd7a94deba78a3a9a9b8ba0bd9f5165f168b9d6df95f092d51c65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "94cfe8750a2fd7a94deba78a3a9a9b8ba0bd9f5165f168b9d6df95f092d51c65", kill_on_drop: false }` [INFO] [stdout] 94cfe8750a2fd7a94deba78a3a9a9b8ba0bd9f5165f168b9d6df95f092d51c65