[INFO] fetching crate rwpspread 0.5.1... [INFO] linting rwpspread-0.5.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rwpspread 0.5.1 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate rwpspread 0.5.1 [INFO] finished tweaking crates.io crate rwpspread 0.5.1 [INFO] tweaked toml for crates.io crate rwpspread 0.5.1 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rwpspread 0.5.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate rwpspread 0.5.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wayland-cursor v0.31.1 [INFO] [stderr] Downloaded inotify v0.11.1 [INFO] [stderr] Downloaded anyhow v1.0.82 [INFO] [stderr] Downloaded profiling-procmacros v1.0.15 [INFO] [stderr] Downloaded calloop-wayland-source v0.4.0 [INFO] [stderr] Downloaded xcursor v0.3.5 [INFO] [stderr] Downloaded jobserver v0.1.30 [INFO] [stderr] Downloaded wayland-protocols-wlr v0.3.1 [INFO] [stderr] Downloaded roff v0.2.1 [INFO] [stderr] Downloaded hyprwire-rs v0.1.0 [INFO] [stderr] Downloaded fdeflate v0.3.4 [INFO] [stderr] Downloaded profiling v1.0.15 [INFO] [stderr] Downloaded material-colors v0.4.2 [INFO] [stderr] Downloaded zerocopy-derive v0.8.14 [INFO] [stderr] Downloaded xkeysym v0.2.0 [INFO] [stderr] Downloaded zerocopy v0.8.14 [INFO] [stderr] Downloaded libfuzzer-sys v0.4.7 [INFO] [stderr] Downloaded pxfm v0.1.20 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] abe85d2c1f9a93245459103706d1597ecfe76b0ccdcc94b9a99337949c6ec495 [INFO] running `Command { std: "docker" "start" "-a" "abe85d2c1f9a93245459103706d1597ecfe76b0ccdcc94b9a99337949c6ec495", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "abe85d2c1f9a93245459103706d1597ecfe76b0ccdcc94b9a99337949c6ec495", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "abe85d2c1f9a93245459103706d1597ecfe76b0ccdcc94b9a99337949c6ec495", kill_on_drop: false }` [INFO] [stdout] abe85d2c1f9a93245459103706d1597ecfe76b0ccdcc94b9a99337949c6ec495 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f4cdea58d2183ad003a99501e731c5c7fd8d9563c2a5b0fea11d10eaa1b77c93 [INFO] running `Command { std: "docker" "start" "-a" "f4cdea58d2183ad003a99501e731c5c7fd8d9563c2a5b0fea11d10eaa1b77c93", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.96 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Compiling cc v1.2.5 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling memchr v2.7.2 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Compiling wayland-client v0.31.11 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling wayland-sys v0.31.7 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling utf8parse v0.2.2 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling anstyle-parse v0.2.5 [INFO] [stderr] Compiling quick-xml v0.37.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Compiling anstyle v1.0.8 [INFO] [stderr] Compiling is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling anstyle-query v1.1.1 [INFO] [stderr] Compiling colorchoice v1.0.2 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling anstream v0.6.15 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Checking aligned-vec v0.5.0 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Checking stable_deref_trait v1.2.1 [INFO] [stderr] Compiling clap_lex v1.0.0 [INFO] [stderr] Checking adler2 v2.0.1 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Compiling clap_builder v4.5.60 [INFO] [stderr] Checking as-slice v0.2.1 [INFO] [stderr] Checking v_frame v0.3.8 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling built v0.8.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling av-scenechange v0.14.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling rav1e v0.8.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking aligned v0.4.2 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling pastey v0.1.1 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking y4m v0.8.0 [INFO] [stderr] Checking av1-grain v0.2.3 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking polling v3.6.0 [INFO] [stderr] Checking bitstream-io v4.9.0 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling profiling-procmacros v1.0.15 [INFO] [stderr] Compiling fax_derive v0.2.0 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Checking aligned-vec v0.6.4 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking imgref v1.11.0 [INFO] [stderr] Checking rand_core v0.10.0 [INFO] [stderr] Compiling roff v0.2.1 [INFO] [stderr] Compiling zmij v1.0.2 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Compiling clap v4.5.60 [INFO] [stderr] Compiling getrandom v0.4.1 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking weezl v0.1.10 [INFO] [stderr] Compiling clap_mangen v0.2.31 [INFO] [stderr] Checking zune-jpeg v0.4.20 [INFO] [stderr] Compiling clap_complete v4.5.66 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking fax v0.2.6 [INFO] [stderr] Checking calloop v0.14.3 [INFO] [stderr] Compiling blake3 v1.8.3 [INFO] [stderr] Checking avif-serialize v0.8.6 [INFO] [stderr] Checking pxfm v0.1.20 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking zune-core v0.5.0 [INFO] [stderr] Checking byteorder-lite v0.1.0 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking rgb v0.8.50 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking cursor-icon v1.2.0 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.20.0 [INFO] [stderr] Checking cpufeatures v0.3.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking bytemuck v1.19.0 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking xcursor v0.3.5 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking wayland-cursor v0.31.1 [INFO] [stderr] Checking indexmap v2.7.0 [INFO] [stderr] Compiling rwpspread v0.5.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking gif v0.14.0 [INFO] [stderr] Checking chacha20 v0.10.0 [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cli.rs:231:17 [INFO] [stdout] | [INFO] [stdout] 231 | diagonals: diagonals, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `diagonals` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cli.rs:248:13 [INFO] [stdout] | [INFO] [stdout] 248 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 248 - return Ok(None); [INFO] [stdout] 248 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:258:16 [INFO] [stdout] | [INFO] [stdout] 258 | if (file || (!dir && !file)) [INFO] [stdout] | ________________^ [INFO] [stdout] 259 | | && fs::metadata(&abs_path) [INFO] [stdout] 260 | | .map_err(|_| "could not get metadata")? [INFO] [stdout] 261 | | .is_file() [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 258 ~ if !(!fs::metadata(&abs_path) [INFO] [stdout] 259 + .map_err(|_| "could not get metadata")? [INFO] [stdout] 260 + .is_file() || !file && dir) [INFO] [stdout] | [INFO] [stdout] 258 ~ if (!dir || file) && fs::metadata(&abs_path) [INFO] [stdout] 259 + .map_err(|_| "could not get metadata")? [INFO] [stdout] 260 + .is_file() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:258:16 [INFO] [stdout] | [INFO] [stdout] 258 | if (file || (!dir && !file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 258 - if (file || (!dir && !file)) [INFO] [stdout] 258 + if !(!file && dir) [INFO] [stdout] | [INFO] [stdout] 258 - if (file || (!dir && !file)) [INFO] [stdout] 258 + if file || !dir [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:266:16 [INFO] [stdout] | [INFO] [stdout] 266 | if (dir || (!dir && !file)) [INFO] [stdout] | ________________^ [INFO] [stdout] 267 | | && fs::metadata(&abs_path) [INFO] [stdout] 268 | | .map_err(|_| "could not get metadata")? [INFO] [stdout] 269 | | .is_dir() [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 266 ~ if !(!fs::metadata(&abs_path) [INFO] [stdout] 267 + .map_err(|_| "could not get metadata")? [INFO] [stdout] 268 + .is_dir() || !dir && file) [INFO] [stdout] | [INFO] [stdout] 266 ~ if (!file || dir) && fs::metadata(&abs_path) [INFO] [stdout] 267 + .map_err(|_| "could not get metadata")? [INFO] [stdout] 268 + .is_dir() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:266:16 [INFO] [stdout] | [INFO] [stdout] 266 | if (dir || (!dir && !file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 266 - if (dir || (!dir && !file)) [INFO] [stdout] 266 + if !(!dir && file) [INFO] [stdout] | [INFO] [stdout] 266 - if (dir || (!dir && !file)) [INFO] [stdout] 266 + if dir || !file [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> build.rs:31:29 [INFO] [stdout] | [INFO] [stdout] 31 | std::fs::create_dir_all(&dest.join("completions"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `dest.join("completions")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> build.rs:32:29 [INFO] [stdout] | [INFO] [stdout] 32 | std::fs::create_dir_all(&dest.join("man"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `dest.join("man")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking image-webp v0.2.0 [INFO] [stderr] Checking zune-jpeg v0.5.5 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking moxcms v0.7.5 [INFO] [stderr] Checking calloop-wayland-source v0.4.0 [INFO] [stderr] Checking tiff v0.10.3 [INFO] [stderr] Checking wayland-protocols-misc v0.3.9 [INFO] [stderr] Checking wayland-protocols-experimental v20250721.0.1 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.1 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking xkeysym v0.2.0 [INFO] [stderr] Checking constant_time_eq v0.4.2 [INFO] [stderr] Checking cpufeatures v0.2.17 [INFO] [stderr] Checking arrayref v0.3.9 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking unty v0.0.4 [INFO] [stderr] Checking bincode v2.0.1 [INFO] [stderr] Checking inotify v0.11.1 [INFO] [stderr] Checking rand v0.10.0 [INFO] [stderr] Checking material-colors v0.4.2 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking hyprwire-rs v0.1.0 [INFO] [stderr] Checking glob v0.3.3 [INFO] [stderr] Checking ravif v0.12.0 [INFO] [stderr] Checking image v0.25.9 [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cli.rs:231:17 [INFO] [stdout] | [INFO] [stdout] 231 | diagonals: diagonals, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `diagonals` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/cli.rs:231:17 [INFO] [stdout] | [INFO] [stdout] 231 | diagonals: diagonals, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `diagonals` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cli.rs:248:13 [INFO] [stdout] | [INFO] [stdout] 248 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 248 - return Ok(None); [INFO] [stdout] 248 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:258:16 [INFO] [stdout] | [INFO] [stdout] 258 | if (file || (!dir && !file)) [INFO] [stdout] | ________________^ [INFO] [stdout] 259 | | && fs::metadata(&abs_path) [INFO] [stdout] 260 | | .map_err(|_| "could not get metadata")? [INFO] [stdout] 261 | | .is_file() [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 258 ~ if !(!fs::metadata(&abs_path) [INFO] [stdout] 259 + .map_err(|_| "could not get metadata")? [INFO] [stdout] 260 + .is_file() || !file && dir) [INFO] [stdout] | [INFO] [stdout] 258 ~ if (!dir || file) && fs::metadata(&abs_path) [INFO] [stdout] 259 + .map_err(|_| "could not get metadata")? [INFO] [stdout] 260 + .is_file() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:258:16 [INFO] [stdout] | [INFO] [stdout] 258 | if (file || (!dir && !file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 258 - if (file || (!dir && !file)) [INFO] [stdout] 258 + if !(!file && dir) [INFO] [stdout] | [INFO] [stdout] 258 - if (file || (!dir && !file)) [INFO] [stdout] 258 + if file || !dir [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:266:16 [INFO] [stdout] | [INFO] [stdout] 266 | if (dir || (!dir && !file)) [INFO] [stdout] | ________________^ [INFO] [stdout] 267 | | && fs::metadata(&abs_path) [INFO] [stdout] 268 | | .map_err(|_| "could not get metadata")? [INFO] [stdout] 269 | | .is_dir() [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 266 ~ if !(!fs::metadata(&abs_path) [INFO] [stdout] 267 + .map_err(|_| "could not get metadata")? [INFO] [stdout] 268 + .is_dir() || !dir && file) [INFO] [stdout] | [INFO] [stdout] 266 ~ if (!file || dir) && fs::metadata(&abs_path) [INFO] [stdout] 267 + .map_err(|_| "could not get metadata")? [INFO] [stdout] 268 + .is_dir() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:266:16 [INFO] [stdout] | [INFO] [stdout] 266 | if (dir || (!dir && !file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 266 - if (dir || (!dir && !file)) [INFO] [stdout] 266 + if !(!dir && file) [INFO] [stdout] | [INFO] [stdout] 266 - if (dir || (!dir && !file)) [INFO] [stdout] 266 + if dir || !file [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers.rs:13:23 [INFO] [stdout] | [INFO] [stdout] 13 | Err(_) => return Err(format!("failed to run {}", program)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - Err(_) => return Err(format!("failed to run {}", program)), [INFO] [stdout] 13 + Err(_) => Err(format!("failed to run {}", program)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | return Ok(status.success()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return Ok(status.success()); [INFO] [stdout] 25 + Ok(status.success()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers.rs:27:23 [INFO] [stdout] | [INFO] [stdout] 27 | Err(_) => return Err("pidof failed".to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - Err(_) => return Err("pidof failed".to_string()), [INFO] [stdout] 27 + Err(_) => Err("pidof failed".to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/integrations/hyprlock.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / pub fn new(path: &String, wallpapers: &HashMap) -> Result<(), String> { [INFO] [stdout] 8 | | let mut base_string = String::new(); [INFO] [stdout] 9 | | for paper in wallpapers { [INFO] [stdout] ... | [INFO] [stdout] 19 | | Ok(()) [INFO] [stdout] 20 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.args.get(0)` [INFO] [stdout] --> src/integrations/hyprpaper.rs:66:69 [INFO] [stdout] | [INFO] [stdout] 66 | let Some(wire::Value::Uint(hp_object_id)) = response.args.get(0) else { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `response.args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/integrations/palette.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | count_vec.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 66 - count_vec.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 66 + count_vec.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range` [INFO] [stdout] --> src/integrations/palette.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | / (0..16) [INFO] [stdout] 89 | | .into_iter() [INFO] [stdout] | |________________________^ help: consider removing `.into_iter()`: `(0..16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/integrations/palette.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 159 | let linear = (input as f64 / 255.0).powf(gamma); [INFO] [stdout] | ------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 160 | linear [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 159 ~ [INFO] [stdout] 160 ~ (input as f64 / 255.0).powf(gamma) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/integrations/palette.rs:202:16 [INFO] [stdout] | [INFO] [stdout] 202 | fn to_json(self, path: &String) -> Result<(), String> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/integrations/palette.rs:218:47 [INFO] [stdout] | [INFO] [stdout] 218 | palletes.dark.into_iter().zip(palletes.light.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 218 - palletes.dark.into_iter().zip(palletes.light.into_iter()) [INFO] [stdout] 218 + palletes.dark.into_iter().zip(palletes.light) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/integrations/swaybg.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / pub fn new(wallpapers: &HashMap) -> Result, String> { [INFO] [stdout] 7 | | let mut arguments: Vec<&str> = Vec::new(); [INFO] [stdout] 8 | | for paper in wallpapers { [INFO] [stdout] 9 | | arguments.push(&"-o"); [INFO] [stdout] ... | [INFO] [stdout] 15 | | Ok(arguments) [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/integrations/swaybg.rs:9:28 [INFO] [stdout] | [INFO] [stdout] 9 | arguments.push(&"-o"); [INFO] [stdout] | ^^^^^ help: change this to: `"-o"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/integrations/swaybg.rs:10:28 [INFO] [stdout] | [INFO] [stdout] 10 | arguments.push(&paper.0); [INFO] [stdout] | ^^^^^^^^ help: change this to: `paper.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/integrations/swaybg.rs:11:28 [INFO] [stdout] | [INFO] [stdout] 11 | arguments.push(&"-i"); [INFO] [stdout] | ^^^^^ help: change this to: `"-i"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/integrations/swaybg.rs:12:28 [INFO] [stdout] | [INFO] [stdout] 12 | arguments.push(&paper.1); [INFO] [stdout] | ^^^^^^^^ help: change this to: `paper.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/integrations/swaylock.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / pub fn new(path: &String, wallpapers: &HashMap) -> Result<(), String> { [INFO] [stdout] 8 | | let mut base_string = String::new(); [INFO] [stdout] 9 | | for paper in wallpapers { [INFO] [stdout] 10 | | base_string += &format!("-i {}:{} ", paper.0, paper.1); [INFO] [stdout] ... | [INFO] [stdout] 15 | | Ok(()) [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/integrations/wpaperd.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / pub fn new( [INFO] [stdout] 9 | | path: &String, [INFO] [stdout] 10 | | hash: &String, [INFO] [stdout] 11 | | wallpapers: &HashMap, [INFO] [stdout] ... | [INFO] [stdout] 34 | | Ok(()) [INFO] [stdout] 35 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/integrations/wpaperd.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 23 | .write(format!("[default]\nmode = \"center\"\n\n").as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"[default]\nmode = \"center\"\n\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/layout.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::i32; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `i32::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/layout.rs:111:17 [INFO] [stdout] | [INFO] [stdout] 105 | / let result = layout_monitors.iter().all(|monitor| { [INFO] [stdout] 106 | | (monitor.initial_width == this.initial_width [INFO] [stdout] 107 | | && monitor.initial_height == this.initial_height) [INFO] [stdout] 108 | | || (monitor.initial_height == this.initial_width [INFO] [stdout] 109 | | && monitor.initial_width == this.initial_height) [INFO] [stdout] 110 | | }); [INFO] [stdout] | |___________________- unnecessary `let` binding [INFO] [stdout] 111 | result [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 105 ~ [INFO] [stdout] 106 ~ layout_monitors.iter().all(|monitor| { [INFO] [stdout] 107 + (monitor.initial_width == this.initial_width [INFO] [stdout] 108 + && monitor.initial_height == this.initial_height) [INFO] [stdout] 109 + || (monitor.initial_height == this.initial_width [INFO] [stdout] 110 + && monitor.initial_width == this.initial_height) [INFO] [stdout] 111 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/layout.rs:113:27 [INFO] [stdout] | [INFO] [stdout] 113 | .all(|result| result == true); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/layout.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 141 | return ppi_max.to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - return ppi_max.to_owned(); [INFO] [stdout] 141 + ppi_max.to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/layout.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 143 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - return 0; [INFO] [stdout] 143 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/layout.rs:148:46 [INFO] [stdout] | [INFO] [stdout] 148 | let max_ppi = self.calculate_max_ppi(&diagonals); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `diagonals` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/watch.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | return Ok(thread_handle); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return Ok(thread_handle); [INFO] [stdout] 28 + Ok(thread_handle) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/watch.rs:18:65 [INFO] [stdout] | [INFO] [stdout] 18 | ... eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 18 - eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] 18 + eprintln!("rwpspread: \x1B[91m{}\x1B[39m", err); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/watch.rs:23:57 [INFO] [stdout] | [INFO] [stdout] 23 | eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 23 - eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] 23 + eprintln!("rwpspread: \x1B[91m{}\x1B[39m", err); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/watch.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return Ok(thread_handle); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return Ok(thread_handle); [INFO] [stdout] 48 + Ok(thread_handle) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/watch.rs:38:65 [INFO] [stdout] | [INFO] [stdout] 38 | ... eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 38 - eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] 38 + eprintln!("rwpspread: \x1B[91m{}\x1B[39m", err); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/watch.rs:43:57 [INFO] [stdout] | [INFO] [stdout] 43 | eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 43 - eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] 43 + eprintln!("rwpspread: \x1B[91m{}\x1B[39m", err); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/worker.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | let target_image: PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `target_image` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 44 ~ [INFO] [stdout] 45 ~ let target_image: PathBuf = if fs::metadata(&config.input_path) [INFO] [stdout] 46 | .map_err(|err| err.to_string())? [INFO] [stdout] ... [INFO] [stdout] 49 | // image is random from directory [INFO] [stdout] 50 ~ self.select_random_image(&config.input_path)? [INFO] [stdout] 51 | } else { [INFO] [stdout] 52 | // image is actual input [INFO] [stdout] 53 ~ config.input_path.to_owned() [INFO] [stdout] 54 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/worker.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | / if config.ppi { [INFO] [stdout] 84 | | if !monitors [INFO] [stdout] 85 | | .iter() [INFO] [stdout] 86 | | .all(|a| config.diagonals.contains_key(&a.name)) [INFO] [stdout] ... | [INFO] [stdout] 89 | | }; [INFO] [stdout] 90 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 83 ~ if config.ppi [INFO] [stdout] 84 ~ && !monitors [INFO] [stdout] 85 | .iter() [INFO] [stdout] ... [INFO] [stdout] 88 | return Err("missing monitor definitions!".to_string()); [INFO] [stdout] 89 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/worker.rs:94:34 [INFO] [stdout] | [INFO] [stdout] 94 | serde::encode_to_vec(&config, config::standard()) [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:104:27 [INFO] [stdout] | [INFO] [stdout] 104 | .check_caches(&config, &monitors) [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/worker.rs:232:21 [INFO] [stdout] | [INFO] [stdout] 232 | / "rwpspread", [INFO] [stdout] 233 | | "detected monitors with different resolutions, try `--ppi` compensation!" [INFO] [stdout] | |_____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 231 - "{}: \x1B[93m{}\x1B[39m", [INFO] [stdout] 232 - "rwpspread", [INFO] [stdout] 233 - "detected monitors with different resolutions, try `--ppi` compensation!" [INFO] [stdout] 231 + "rwpspread: \x1B[93mdetected monitors with different resolutions, try `--ppi` compensation!\x1B[39m" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/worker.rs:376:41 [INFO] [stdout] | [INFO] [stdout] 376 | fn select_random_image(&self, path: &PathBuf) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 376 - fn select_random_image(&self, path: &PathBuf) -> Result { [INFO] [stdout] 376 + fn select_random_image(&self, path: &Path) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/worker.rs:381:13 [INFO] [stdout] | [INFO] [stdout] 381 | / for entry in glob(&pattern).expect("Failed to read glob pattern") { [INFO] [stdout] 382 | | if let Ok(path) = entry { [INFO] [stdout] 383 | | paths.push(path); [INFO] [stdout] 384 | | } [INFO] [stdout] 385 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/worker.rs:382:17 [INFO] [stdout] | [INFO] [stdout] 382 | / if let Ok(path) = entry { [INFO] [stdout] 383 | | paths.push(path); [INFO] [stdout] 384 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 381 ~ for path in glob(&pattern).expect("Failed to read glob pattern").flatten() { [INFO] [stdout] 382 + paths.push(path); [INFO] [stdout] 383 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/worker.rs:413:9 [INFO] [stdout] | [INFO] [stdout] 413 | / for entry in [INFO] [stdout] 414 | | glob(&format!("{}/rwps_*", &self.workdir)).map_err(|_| "failed to iterate directory")? [INFO] [stdout] 415 | | { [INFO] [stdout] 416 | | if let Ok(path) = entry { [INFO] [stdout] ... | [INFO] [stdout] 419 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/worker.rs:416:13 [INFO] [stdout] | [INFO] [stdout] 416 | / if let Ok(path) = entry { [INFO] [stdout] 417 | | fs::remove_file(path).map_err(|_| "failed to clear cache")?; [INFO] [stdout] 418 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 413 ~ for path in [INFO] [stdout] 414 ~ glob(&format!("{}/rwps_*", &self.workdir)).map_err(|_| "failed to iterate directory")?.flatten() [INFO] [stdout] 415 ~ { [INFO] [stdout] 416 + fs::remove_file(path).map_err(|_| "failed to clear cache")?; [INFO] [stdout] 417 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/main.rs:68:28 [INFO] [stdout] | [INFO] [stdout] 68 | if let Ok(_) = rx_monitors.recv() { [INFO] [stdout] | -------^^^^^--------------------- help: try: `if rx_monitors.recv().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/main.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | result.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:110:49 [INFO] [stdout] | [INFO] [stdout] 110 | eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 110 - eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] 110 + eprintln!("rwpspread: \x1B[91m{}\x1B[39m", err); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cli.rs:248:13 [INFO] [stdout] | [INFO] [stdout] 248 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 248 - return Ok(None); [INFO] [stdout] 248 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:258:16 [INFO] [stdout] | [INFO] [stdout] 258 | if (file || (!dir && !file)) [INFO] [stdout] | ________________^ [INFO] [stdout] 259 | | && fs::metadata(&abs_path) [INFO] [stdout] 260 | | .map_err(|_| "could not get metadata")? [INFO] [stdout] 261 | | .is_file() [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 258 ~ if !(!fs::metadata(&abs_path) [INFO] [stdout] 259 + .map_err(|_| "could not get metadata")? [INFO] [stdout] 260 + .is_file() || !file && dir) [INFO] [stdout] | [INFO] [stdout] 258 ~ if (!dir || file) && fs::metadata(&abs_path) [INFO] [stdout] 259 + .map_err(|_| "could not get metadata")? [INFO] [stdout] 260 + .is_file() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:258:16 [INFO] [stdout] | [INFO] [stdout] 258 | if (file || (!dir && !file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 258 - if (file || (!dir && !file)) [INFO] [stdout] 258 + if !(!file && dir) [INFO] [stdout] | [INFO] [stdout] 258 - if (file || (!dir && !file)) [INFO] [stdout] 258 + if file || !dir [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:266:16 [INFO] [stdout] | [INFO] [stdout] 266 | if (dir || (!dir && !file)) [INFO] [stdout] | ________________^ [INFO] [stdout] 267 | | && fs::metadata(&abs_path) [INFO] [stdout] 268 | | .map_err(|_| "could not get metadata")? [INFO] [stdout] 269 | | .is_dir() [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 266 ~ if !(!fs::metadata(&abs_path) [INFO] [stdout] 267 + .map_err(|_| "could not get metadata")? [INFO] [stdout] 268 + .is_dir() || !dir && file) [INFO] [stdout] | [INFO] [stdout] 266 ~ if (!file || dir) && fs::metadata(&abs_path) [INFO] [stdout] 267 + .map_err(|_| "could not get metadata")? [INFO] [stdout] 268 + .is_dir() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:266:16 [INFO] [stdout] | [INFO] [stdout] 266 | if (dir || (!dir && !file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 266 - if (dir || (!dir && !file)) [INFO] [stdout] 266 + if !(!dir && file) [INFO] [stdout] | [INFO] [stdout] 266 - if (dir || (!dir && !file)) [INFO] [stdout] 266 + if dir || !file [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers.rs:13:23 [INFO] [stdout] | [INFO] [stdout] 13 | Err(_) => return Err(format!("failed to run {}", program)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - Err(_) => return Err(format!("failed to run {}", program)), [INFO] [stdout] 13 + Err(_) => Err(format!("failed to run {}", program)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | return Ok(status.success()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return Ok(status.success()); [INFO] [stdout] 25 + Ok(status.success()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helpers.rs:27:23 [INFO] [stdout] | [INFO] [stdout] 27 | Err(_) => return Err("pidof failed".to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - Err(_) => return Err("pidof failed".to_string()), [INFO] [stdout] 27 + Err(_) => Err("pidof failed".to_string()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/integrations/hyprlock.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / pub fn new(path: &String, wallpapers: &HashMap) -> Result<(), String> { [INFO] [stdout] 8 | | let mut base_string = String::new(); [INFO] [stdout] 9 | | for paper in wallpapers { [INFO] [stdout] ... | [INFO] [stdout] 19 | | Ok(()) [INFO] [stdout] 20 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.args.get(0)` [INFO] [stdout] --> src/integrations/hyprpaper.rs:66:69 [INFO] [stdout] | [INFO] [stdout] 66 | let Some(wire::Value::Uint(hp_object_id)) = response.args.get(0) else { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `response.args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/integrations/palette.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | count_vec.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 66 - count_vec.sort_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 66 + count_vec.sort_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range` [INFO] [stdout] --> src/integrations/palette.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | / (0..16) [INFO] [stdout] 89 | | .into_iter() [INFO] [stdout] | |________________________^ help: consider removing `.into_iter()`: `(0..16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/integrations/palette.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 159 | let linear = (input as f64 / 255.0).powf(gamma); [INFO] [stdout] | ------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 160 | linear [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 159 ~ [INFO] [stdout] 160 ~ (input as f64 / 255.0).powf(gamma) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/integrations/palette.rs:202:16 [INFO] [stdout] | [INFO] [stdout] 202 | fn to_json(self, path: &String) -> Result<(), String> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/integrations/palette.rs:218:47 [INFO] [stdout] | [INFO] [stdout] 218 | palletes.dark.into_iter().zip(palletes.light.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 218 - palletes.dark.into_iter().zip(palletes.light.into_iter()) [INFO] [stdout] 218 + palletes.dark.into_iter().zip(palletes.light) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/integrations/swaybg.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | / pub fn new(wallpapers: &HashMap) -> Result, String> { [INFO] [stdout] 7 | | let mut arguments: Vec<&str> = Vec::new(); [INFO] [stdout] 8 | | for paper in wallpapers { [INFO] [stdout] 9 | | arguments.push(&"-o"); [INFO] [stdout] ... | [INFO] [stdout] 15 | | Ok(arguments) [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/integrations/swaybg.rs:9:28 [INFO] [stdout] | [INFO] [stdout] 9 | arguments.push(&"-o"); [INFO] [stdout] | ^^^^^ help: change this to: `"-o"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/integrations/swaybg.rs:10:28 [INFO] [stdout] | [INFO] [stdout] 10 | arguments.push(&paper.0); [INFO] [stdout] | ^^^^^^^^ help: change this to: `paper.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/integrations/swaybg.rs:11:28 [INFO] [stdout] | [INFO] [stdout] 11 | arguments.push(&"-i"); [INFO] [stdout] | ^^^^^ help: change this to: `"-i"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/integrations/swaybg.rs:12:28 [INFO] [stdout] | [INFO] [stdout] 12 | arguments.push(&paper.1); [INFO] [stdout] | ^^^^^^^^ help: change this to: `paper.1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/integrations/swaylock.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | / pub fn new(path: &String, wallpapers: &HashMap) -> Result<(), String> { [INFO] [stdout] 8 | | let mut base_string = String::new(); [INFO] [stdout] 9 | | for paper in wallpapers { [INFO] [stdout] 10 | | base_string += &format!("-i {}:{} ", paper.0, paper.1); [INFO] [stdout] ... | [INFO] [stdout] 15 | | Ok(()) [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/integrations/wpaperd.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | / pub fn new( [INFO] [stdout] 9 | | path: &String, [INFO] [stdout] 10 | | hash: &String, [INFO] [stdout] 11 | | wallpapers: &HashMap, [INFO] [stdout] ... | [INFO] [stdout] 34 | | Ok(()) [INFO] [stdout] 35 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/integrations/wpaperd.rs:23:20 [INFO] [stdout] | [INFO] [stdout] 23 | .write(format!("[default]\nmode = \"center\"\n\n").as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"[default]\nmode = \"center\"\n\n".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/layout.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::i32; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `i32::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/layout.rs:111:17 [INFO] [stdout] | [INFO] [stdout] 105 | / let result = layout_monitors.iter().all(|monitor| { [INFO] [stdout] 106 | | (monitor.initial_width == this.initial_width [INFO] [stdout] 107 | | && monitor.initial_height == this.initial_height) [INFO] [stdout] 108 | | || (monitor.initial_height == this.initial_width [INFO] [stdout] 109 | | && monitor.initial_width == this.initial_height) [INFO] [stdout] 110 | | }); [INFO] [stdout] | |___________________- unnecessary `let` binding [INFO] [stdout] 111 | result [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 105 ~ [INFO] [stdout] 106 ~ layout_monitors.iter().all(|monitor| { [INFO] [stdout] 107 + (monitor.initial_width == this.initial_width [INFO] [stdout] 108 + && monitor.initial_height == this.initial_height) [INFO] [stdout] 109 + || (monitor.initial_height == this.initial_width [INFO] [stdout] 110 + && monitor.initial_width == this.initial_height) [INFO] [stdout] 111 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/layout.rs:113:27 [INFO] [stdout] | [INFO] [stdout] 113 | .all(|result| result == true); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/layout.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 141 | return ppi_max.to_owned(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - return ppi_max.to_owned(); [INFO] [stdout] 141 + ppi_max.to_owned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/layout.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 143 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - return 0; [INFO] [stdout] 143 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/layout.rs:148:46 [INFO] [stdout] | [INFO] [stdout] 148 | let max_ppi = self.calculate_max_ppi(&diagonals); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `diagonals` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/watch.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | return Ok(thread_handle); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return Ok(thread_handle); [INFO] [stdout] 28 + Ok(thread_handle) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/watch.rs:18:65 [INFO] [stdout] | [INFO] [stdout] 18 | ... eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 18 - eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] 18 + eprintln!("rwpspread: \x1B[91m{}\x1B[39m", err); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/watch.rs:23:57 [INFO] [stdout] | [INFO] [stdout] 23 | eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 23 - eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] 23 + eprintln!("rwpspread: \x1B[91m{}\x1B[39m", err); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/watch.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return Ok(thread_handle); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return Ok(thread_handle); [INFO] [stdout] 48 + Ok(thread_handle) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/watch.rs:38:65 [INFO] [stdout] | [INFO] [stdout] 38 | ... eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 38 - eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] 38 + eprintln!("rwpspread: \x1B[91m{}\x1B[39m", err); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/watch.rs:43:57 [INFO] [stdout] | [INFO] [stdout] 43 | eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 43 - eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] 43 + eprintln!("rwpspread: \x1B[91m{}\x1B[39m", err); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/worker.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | let target_image: PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `target_image` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 44 ~ [INFO] [stdout] 45 ~ let target_image: PathBuf = if fs::metadata(&config.input_path) [INFO] [stdout] 46 | .map_err(|err| err.to_string())? [INFO] [stdout] ... [INFO] [stdout] 49 | // image is random from directory [INFO] [stdout] 50 ~ self.select_random_image(&config.input_path)? [INFO] [stdout] 51 | } else { [INFO] [stdout] 52 | // image is actual input [INFO] [stdout] 53 ~ config.input_path.to_owned() [INFO] [stdout] 54 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/worker.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | / if config.ppi { [INFO] [stdout] 84 | | if !monitors [INFO] [stdout] 85 | | .iter() [INFO] [stdout] 86 | | .all(|a| config.diagonals.contains_key(&a.name)) [INFO] [stdout] ... | [INFO] [stdout] 89 | | }; [INFO] [stdout] 90 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 83 ~ if config.ppi [INFO] [stdout] 84 ~ && !monitors [INFO] [stdout] 85 | .iter() [INFO] [stdout] ... [INFO] [stdout] 88 | return Err("missing monitor definitions!".to_string()); [INFO] [stdout] 89 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/worker.rs:94:34 [INFO] [stdout] | [INFO] [stdout] 94 | serde::encode_to_vec(&config, config::standard()) [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/worker.rs:104:27 [INFO] [stdout] | [INFO] [stdout] 104 | .check_caches(&config, &monitors) [INFO] [stdout] | ^^^^^^^ help: change this to: `config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/worker.rs:232:21 [INFO] [stdout] | [INFO] [stdout] 232 | / "rwpspread", [INFO] [stdout] 233 | | "detected monitors with different resolutions, try `--ppi` compensation!" [INFO] [stdout] | |_____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 231 - "{}: \x1B[93m{}\x1B[39m", [INFO] [stdout] 232 - "rwpspread", [INFO] [stdout] 233 - "detected monitors with different resolutions, try `--ppi` compensation!" [INFO] [stdout] 231 + "rwpspread: \x1B[93mdetected monitors with different resolutions, try `--ppi` compensation!\x1B[39m" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/worker.rs:376:41 [INFO] [stdout] | [INFO] [stdout] 376 | fn select_random_image(&self, path: &PathBuf) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 376 - fn select_random_image(&self, path: &PathBuf) -> Result { [INFO] [stdout] 376 + fn select_random_image(&self, path: &Path) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/worker.rs:381:13 [INFO] [stdout] | [INFO] [stdout] 381 | / for entry in glob(&pattern).expect("Failed to read glob pattern") { [INFO] [stdout] 382 | | if let Ok(path) = entry { [INFO] [stdout] 383 | | paths.push(path); [INFO] [stdout] 384 | | } [INFO] [stdout] 385 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/worker.rs:382:17 [INFO] [stdout] | [INFO] [stdout] 382 | / if let Ok(path) = entry { [INFO] [stdout] 383 | | paths.push(path); [INFO] [stdout] 384 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 381 ~ for path in glob(&pattern).expect("Failed to read glob pattern").flatten() { [INFO] [stdout] 382 + paths.push(path); [INFO] [stdout] 383 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/worker.rs:413:9 [INFO] [stdout] | [INFO] [stdout] 413 | / for entry in [INFO] [stdout] 414 | | glob(&format!("{}/rwps_*", &self.workdir)).map_err(|_| "failed to iterate directory")? [INFO] [stdout] 415 | | { [INFO] [stdout] 416 | | if let Ok(path) = entry { [INFO] [stdout] ... | [INFO] [stdout] 419 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/worker.rs:416:13 [INFO] [stdout] | [INFO] [stdout] 416 | / if let Ok(path) = entry { [INFO] [stdout] 417 | | fs::remove_file(path).map_err(|_| "failed to clear cache")?; [INFO] [stdout] 418 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 413 ~ for path in [INFO] [stdout] 414 ~ glob(&format!("{}/rwps_*", &self.workdir)).map_err(|_| "failed to iterate directory")?.flatten() [INFO] [stdout] 415 ~ { [INFO] [stdout] 416 + fs::remove_file(path).map_err(|_| "failed to clear cache")?; [INFO] [stdout] 417 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/main.rs:68:28 [INFO] [stdout] | [INFO] [stdout] 68 | if let Ok(_) = rx_monitors.recv() { [INFO] [stdout] | -------^^^^^--------------------- help: try: `if rx_monitors.recv().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/main.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 94 | result.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/main.rs:110:49 [INFO] [stdout] | [INFO] [stdout] 110 | eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 110 - eprintln!("{}: \x1B[91m{}\x1B[39m", "rwpspread", err); [INFO] [stdout] 110 + eprintln!("rwpspread: \x1B[91m{}\x1B[39m", err); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [optimized + debuginfo] target(s) in 1m 55s [INFO] running `Command { std: "docker" "inspect" "f4cdea58d2183ad003a99501e731c5c7fd8d9563c2a5b0fea11d10eaa1b77c93", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4cdea58d2183ad003a99501e731c5c7fd8d9563c2a5b0fea11d10eaa1b77c93", kill_on_drop: false }` [INFO] [stdout] f4cdea58d2183ad003a99501e731c5c7fd8d9563c2a5b0fea11d10eaa1b77c93