[INFO] fetching crate rusty-css 0.1.3... [INFO] linting rusty-css-0.1.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rusty-css 0.1.3 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate rusty-css 0.1.3 [INFO] finished tweaking crates.io crate rusty-css 0.1.3 [INFO] tweaked toml for crates.io crate rusty-css 0.1.3 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rusty-css 0.1.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 126 packages to latest compatible versions [INFO] [stderr] Adding bevy_reflect v0.9.1 (available: v0.18.1) [INFO] [stderr] Adding yew v0.19.3 (available: v0.23.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pin-project-lite v0.2.17 [INFO] [stderr] Downloaded futures-core v0.3.32 [INFO] [stderr] Downloaded boolinator v2.4.0 [INFO] [stderr] Downloaded futures-task v0.3.32 [INFO] [stderr] Downloaded scoped-tls-hkt v0.1.5 [INFO] [stderr] Downloaded gloo-timers v0.2.6 [INFO] [stderr] Downloaded gloo-utils v0.1.7 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.64 [INFO] [stderr] Downloaded gloo-console v0.2.3 [INFO] [stderr] Downloaded wasm-bindgen-test-shared v0.2.114 [INFO] [stderr] Downloaded substring v1.4.5 [INFO] [stderr] Downloaded bevy_ptr v0.9.1 [INFO] [stderr] Downloaded gloo-render v0.1.1 [INFO] [stderr] Downloaded gloo-storage v0.2.2 [INFO] [stderr] Downloaded bevy_macro_utils v0.9.1 [INFO] [stderr] Downloaded wasm-logger v0.2.0 [INFO] [stderr] Downloaded bevy_utils v0.9.1 [INFO] [stderr] Downloaded bevy_reflect_derive v0.9.1 [INFO] [stderr] Downloaded minicov v0.3.8 [INFO] [stderr] Downloaded toml v0.5.11 [INFO] [stderr] Downloaded bevy_reflect v0.9.1 [INFO] [stderr] Downloaded wasm-bindgen-test v0.3.64 [INFO] [stderr] Downloaded yew-macro v0.19.3 [INFO] [stderr] Downloaded ahash v0.7.8 [INFO] [stderr] Downloaded yew v0.19.3 [INFO] [stderr] Downloaded erased-serde v0.3.31 [INFO] [stderr] Downloaded futures-util v0.3.32 [INFO] [stderr] Downloaded async-trait v0.1.89 [INFO] [stderr] Downloaded cast v0.3.0 [INFO] [stderr] Downloaded nu-ansi-term v0.50.3 [INFO] [stderr] Downloaded oorandom v11.1.5 [INFO] [stderr] Downloaded wasm-bindgen-test-macro v0.3.64 [INFO] [stderr] Downloaded gloo-dialogs v0.1.1 [INFO] [stderr] Downloaded gloo-events v0.1.2 [INFO] [stderr] Downloaded gloo-file v0.2.3 [INFO] [stderr] Downloaded console_error_panic_hook v0.1.7 [INFO] [stderr] Downloaded gloo v0.4.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8d36cd799b98ee5f20c2cd2903abd9e7f8871ca888ef5bfb9fdb3bd07663ea70 [INFO] running `Command { std: "docker" "start" "-a" "8d36cd799b98ee5f20c2cd2903abd9e7f8871ca888ef5bfb9fdb3bd07663ea70", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8d36cd799b98ee5f20c2cd2903abd9e7f8871ca888ef5bfb9fdb3bd07663ea70", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d36cd799b98ee5f20c2cd2903abd9e7f8871ca888ef5bfb9fdb3bd07663ea70", kill_on_drop: false }` [INFO] [stdout] 8d36cd799b98ee5f20c2cd2903abd9e7f8871ca888ef5bfb9fdb3bd07663ea70 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7920e7ada55657b510cb7451a14bfdf2bfde40dfc03a87b9e8ea7b3bb0cae62f [INFO] running `Command { std: "docker" "start" "-a" "7920e7ada55657b510cb7451a14bfdf2bfde40dfc03a87b9e8ea7b3bb0cae62f", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.114 [INFO] [stderr] Compiling rustversion v1.0.22 [INFO] [stderr] Compiling bumpalo v3.20.2 [INFO] [stderr] Checking unicode-ident v1.0.24 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling autocfg v1.5.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling getrandom v0.4.2 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking pin-project-lite v0.2.17 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling wasm-bindgen v0.2.114 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Compiling libm v0.2.16 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking uuid v1.22.0 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Compiling substring v1.4.5 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling boolinator v2.4.0 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking oorandom v11.1.5 [INFO] [stderr] Checking wasm-bindgen-test-shared v0.2.114 [INFO] [stderr] Checking nu-ansi-term v0.50.3 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking scoped-tls-hkt v0.1.5 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking bevy_ptr v0.9.1 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.114 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling wasm-bindgen-test-macro v0.3.64 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling yew-macro v0.19.3 [INFO] [stderr] Compiling bevy_macro_utils v0.9.1 [INFO] [stderr] Compiling bevy_reflect_derive v0.9.1 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.114 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking erased-serde v0.3.31 [INFO] [stderr] Checking bevy_utils v0.9.1 [INFO] [stderr] Checking js-sys v0.3.91 [INFO] [stderr] Checking console_error_panic_hook v0.1.7 [INFO] [stderr] Checking bevy_reflect v0.9.1 [INFO] [stderr] Checking web-sys v0.3.91 [INFO] [stderr] Checking gloo-timers v0.2.6 [INFO] [stderr] Checking wasm-bindgen-futures v0.4.64 [INFO] [stderr] Checking wasm-bindgen-test v0.3.64 [INFO] [stderr] Checking gloo-utils v0.1.7 [INFO] [stderr] Checking gloo-events v0.1.2 [INFO] [stderr] Checking gloo-render v0.1.1 [INFO] [stderr] Checking gloo-dialogs v0.1.1 [INFO] [stderr] Checking wasm-logger v0.2.0 [INFO] [stderr] Checking gloo-file v0.2.3 [INFO] [stderr] Checking gloo-console v0.2.3 [INFO] [stderr] Checking gloo-storage v0.2.2 [INFO] [stderr] Checking gloo v0.4.2 [INFO] [stderr] Checking yew v0.19.3 [INFO] [stderr] Checking rusty-css v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lib.rs:24:39 [INFO] [stdout] | [INFO] [stdout] 24 | Some( self.chars().filter(|c| c.is_digit(10) || c == &'.' || c == &'-').collect() ) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `new_structs_values` [INFO] [stdout] --> src/lib.rs:56:22 [INFO] [stdout] | [INFO] [stdout] 56 | for i in 0..list_reflect.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 56 - for i in 0..list_reflect.len() { [INFO] [stdout] 56 + for (i, ) in new_structs_values.iter().enumerate().take(list_reflect.len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:262:12 [INFO] [stdout] | [INFO] [stdout] 262 | if !append.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `append.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lib.rs:24:39 [INFO] [stdout] | [INFO] [stdout] 24 | Some( self.chars().filter(|c| c.is_digit(10) || c == &'.' || c == &'-').collect() ) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `c.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `append` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:264:17 [INFO] [stdout] | [INFO] [stdout] 262 | if !append.is_none() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 263 | class_name_appended.push_str( [INFO] [stdout] 264 | append.unwrap().downcast_ref::().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:257:43 [INFO] [stdout] | [INFO] [stdout] 257 | fn as_class_string(&self, class_name: &String) -> Result where Self: Sized { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 257 ~ fn as_class_string(&self, class_name: &str) -> Result where Self: Sized { [INFO] [stdout] 258 | [INFO] [stdout] 259 ~ let mut class_name_appended = class_name.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:280:29 [INFO] [stdout] | [INFO] [stdout] 280 | self.append_to_head(&document, &class_name, &class_string); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `document` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:286:63 [INFO] [stdout] | [INFO] [stdout] 286 | fn append_to_head(&self, document: &Document, class_name: &String, class_string: &String) where Self: Sized { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 286 - fn append_to_head(&self, document: &Document, class_name: &String, class_string: &String) where Self: Sized { [INFO] [stdout] 286 + fn append_to_head(&self, document: &Document, class_name: &str, class_string: &String) where Self: Sized { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:291:49 [INFO] [stdout] | [INFO] [stdout] 291 | new_style_element.set_text_content(Some(&class_string)); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `class_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `new_structs_values` [INFO] [stdout] --> src/lib.rs:56:22 [INFO] [stdout] | [INFO] [stdout] 56 | for i in 0..list_reflect.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 56 - for i in 0..list_reflect.len() { [INFO] [stdout] 56 + for (i, ) in new_structs_values.iter().enumerate().take(list_reflect.len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:315:12 [INFO] [stdout] | [INFO] [stdout] 315 | if class_name_slice == "" { return Err("(Internal Error) couldn't strip arbitrary_caller_name:: prefix"); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `class_name_slice.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/lib.rs:324:54 [INFO] [stdout] | [INFO] [stdout] 324 | for (_i, value_reflect) in self.iter_fields().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 324 - for (_i, value_reflect) in self.iter_fields().enumerate() { [INFO] [stdout] 324 + for value_reflect in self.iter_fields() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:262:12 [INFO] [stdout] | [INFO] [stdout] 262 | if !append.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `append.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `append` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:264:17 [INFO] [stdout] | [INFO] [stdout] 262 | if !append.is_none() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 263 | class_name_appended.push_str( [INFO] [stdout] 264 | append.unwrap().downcast_ref::().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:257:43 [INFO] [stdout] | [INFO] [stdout] 257 | fn as_class_string(&self, class_name: &String) -> Result where Self: Sized { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 257 ~ fn as_class_string(&self, class_name: &str) -> Result where Self: Sized { [INFO] [stdout] 258 | [INFO] [stdout] 259 ~ let mut class_name_appended = class_name.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:280:29 [INFO] [stdout] | [INFO] [stdout] 280 | self.append_to_head(&document, &class_name, &class_string); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `document` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:286:63 [INFO] [stdout] | [INFO] [stdout] 286 | fn append_to_head(&self, document: &Document, class_name: &String, class_string: &String) where Self: Sized { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 286 - fn append_to_head(&self, document: &Document, class_name: &String, class_string: &String) where Self: Sized { [INFO] [stdout] 286 + fn append_to_head(&self, document: &Document, class_name: &str, class_string: &String) where Self: Sized { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:291:49 [INFO] [stdout] | [INFO] [stdout] 291 | new_style_element.set_text_content(Some(&class_string)); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `class_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/lib.rs:315:12 [INFO] [stdout] | [INFO] [stdout] 315 | if class_name_slice == "" { return Err("(Internal Error) couldn't strip arbitrary_caller_name:: prefix"); } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `class_name_slice.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/lib.rs:324:54 [INFO] [stdout] | [INFO] [stdout] 324 | for (_i, value_reflect) in self.iter_fields().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 324 - for (_i, value_reflect) in self.iter_fields().enumerate() { [INFO] [stdout] 324 + for value_reflect in self.iter_fields() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 09s [INFO] running `Command { std: "docker" "inspect" "7920e7ada55657b510cb7451a14bfdf2bfde40dfc03a87b9e8ea7b3bb0cae62f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7920e7ada55657b510cb7451a14bfdf2bfde40dfc03a87b9e8ea7b3bb0cae62f", kill_on_drop: false }` [INFO] [stdout] 7920e7ada55657b510cb7451a14bfdf2bfde40dfc03a87b9e8ea7b3bb0cae62f