[INFO] fetching crate rustrings 1.0.2... [INFO] linting rustrings-1.0.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rustrings 1.0.2 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate rustrings 1.0.2 [INFO] finished tweaking crates.io crate rustrings 1.0.2 [INFO] tweaked toml for crates.io crate rustrings 1.0.2 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rustrings 1.0.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] be86eba5d2ea7c4f06af4578520c2d2a0dfdae3dd9cd95f2fb17b6c02838a49a [INFO] running `Command { std: "docker" "start" "-a" "be86eba5d2ea7c4f06af4578520c2d2a0dfdae3dd9cd95f2fb17b6c02838a49a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "be86eba5d2ea7c4f06af4578520c2d2a0dfdae3dd9cd95f2fb17b6c02838a49a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be86eba5d2ea7c4f06af4578520c2d2a0dfdae3dd9cd95f2fb17b6c02838a49a", kill_on_drop: false }` [INFO] [stdout] be86eba5d2ea7c4f06af4578520c2d2a0dfdae3dd9cd95f2fb17b6c02838a49a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bce8181bdf3600ab17d8bf02adc63594109e2308bb7fb174507b97f4c84f3914 [INFO] running `Command { std: "docker" "start" "-a" "bce8181bdf3600ab17d8bf02adc63594109e2308bb7fb174507b97f4c84f3914", kill_on_drop: false }` [INFO] [stderr] Checking rustrings v1.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/format.rs:35:4 [INFO] [stdout] | [INFO] [stdout] 35 | padding: padding, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `padding` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/format.rs:36:4 [INFO] [stdout] | [INFO] [stdout] 36 | filling: filling, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `filling` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/format.rs:35:4 [INFO] [stdout] | [INFO] [stdout] 35 | padding: padding, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `padding` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/format.rs:36:4 [INFO] [stdout] | [INFO] [stdout] 36 | filling: filling, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `filling` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/converters.rs:229:6 [INFO] [stdout] | [INFO] [stdout] 229 | if char == '\t' || [INFO] [stdout] | ____________^ [INFO] [stdout] 230 | | char == '\n' || [INFO] [stdout] 231 | | char == '\x0b' || [INFO] [stdout] 232 | | char == '\x0c' || [INFO] [stdout] 233 | | char == '\n' || [INFO] [stdout] 234 | | char == ' ' || [INFO] [stdout] 235 | | char == '_' [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 229 - if char == '\t' || [INFO] [stdout] 230 - char == '\n' || [INFO] [stdout] 231 - char == '\x0b' || [INFO] [stdout] 232 - char == '\x0c' || [INFO] [stdout] 233 - char == '\n' || [INFO] [stdout] 234 - char == ' ' || [INFO] [stdout] 235 - char == '_' [INFO] [stdout] 229 + if !(char != '\t' && char != '\n' && char != '\x0b' && char != '\x0c' && char != ' ' && char != '_') [INFO] [stdout] | [INFO] [stdout] 229 - if char == '\t' || [INFO] [stdout] 230 - char == '\n' || [INFO] [stdout] 231 - char == '\x0b' || [INFO] [stdout] 232 - char == '\x0c' || [INFO] [stdout] 233 - char == '\n' || [INFO] [stdout] 234 - char == ' ' || [INFO] [stdout] 235 - char == '_' [INFO] [stdout] 229 + if char == '\t' || char == '\n' || char == '\x0b' || char == '\x0c' || char == ' ' || char == '_' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/converters.rs:229:6 [INFO] [stdout] | [INFO] [stdout] 229 | if char == '\t' || [INFO] [stdout] | ____________^ [INFO] [stdout] 230 | | char == '\n' || [INFO] [stdout] 231 | | char == '\x0b' || [INFO] [stdout] 232 | | char == '\x0c' || [INFO] [stdout] 233 | | char == '\n' || [INFO] [stdout] 234 | | char == ' ' || [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 229 - if char == '\t' || [INFO] [stdout] 230 - char == '\n' || [INFO] [stdout] 231 - char == '\x0b' || [INFO] [stdout] 232 - char == '\x0c' || [INFO] [stdout] 233 - char == '\n' || [INFO] [stdout] 234 - char == ' ' || [INFO] [stdout] 229 + if !(char != '\t' && char != '\n' && char != '\x0b' && char != '\x0c' && char != ' ') || [INFO] [stdout] | [INFO] [stdout] 229 - if char == '\t' || [INFO] [stdout] 230 - char == '\n' || [INFO] [stdout] 231 - char == '\x0b' || [INFO] [stdout] 232 - char == '\x0c' || [INFO] [stdout] 233 - char == '\n' || [INFO] [stdout] 234 - char == ' ' || [INFO] [stdout] 229 + if char == '\t' || char == '\n' || char == '\x0b' || char == '\x0c' || char == ' ' || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/converters.rs:229:6 [INFO] [stdout] | [INFO] [stdout] 229 | if char == '\t' || [INFO] [stdout] | ____________^ [INFO] [stdout] 230 | | char == '\n' || [INFO] [stdout] 231 | | char == '\x0b' || [INFO] [stdout] 232 | | char == '\x0c' || [INFO] [stdout] 233 | | char == '\n' || [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 229 - if char == '\t' || [INFO] [stdout] 230 - char == '\n' || [INFO] [stdout] 231 - char == '\x0b' || [INFO] [stdout] 232 - char == '\x0c' || [INFO] [stdout] 233 - char == '\n' || [INFO] [stdout] 229 + if !(char != '\t' && char != '\n' && char != '\x0b' && char != '\x0c') || [INFO] [stdout] | [INFO] [stdout] 229 - if char == '\t' || [INFO] [stdout] 230 - char == '\n' || [INFO] [stdout] 231 - char == '\x0b' || [INFO] [stdout] 232 - char == '\x0c' || [INFO] [stdout] 233 - char == '\n' || [INFO] [stdout] 229 + if char == '\t' || char == '\n' || char == '\x0b' || char == '\x0c' || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/converters.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | o: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 204 - o: &String, [INFO] [stdout] 204 + o: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/converters.rs:316:6 [INFO] [stdout] | [INFO] [stdout] 316 | if char == '\t' || [INFO] [stdout] | ____________^ [INFO] [stdout] 317 | | char == '\n' || [INFO] [stdout] 318 | | char == '\x0b' || [INFO] [stdout] 319 | | char == '\x0c' || [INFO] [stdout] 320 | | char == '\n' || [INFO] [stdout] 321 | | char == ' ' || [INFO] [stdout] 322 | | char == '_' [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 316 - if char == '\t' || [INFO] [stdout] 317 - char == '\n' || [INFO] [stdout] 318 - char == '\x0b' || [INFO] [stdout] 319 - char == '\x0c' || [INFO] [stdout] 320 - char == '\n' || [INFO] [stdout] 321 - char == ' ' || [INFO] [stdout] 322 - char == '_' [INFO] [stdout] 316 + if !(char != '\t' && char != '\n' && char != '\x0b' && char != '\x0c' && char != ' ' && char != '_') [INFO] [stdout] | [INFO] [stdout] 316 - if char == '\t' || [INFO] [stdout] 317 - char == '\n' || [INFO] [stdout] 318 - char == '\x0b' || [INFO] [stdout] 319 - char == '\x0c' || [INFO] [stdout] 320 - char == '\n' || [INFO] [stdout] 321 - char == ' ' || [INFO] [stdout] 322 - char == '_' [INFO] [stdout] 316 + if char == '\t' || char == '\n' || char == '\x0b' || char == '\x0c' || char == ' ' || char == '_' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/converters.rs:316:6 [INFO] [stdout] | [INFO] [stdout] 316 | if char == '\t' || [INFO] [stdout] | ____________^ [INFO] [stdout] 317 | | char == '\n' || [INFO] [stdout] 318 | | char == '\x0b' || [INFO] [stdout] 319 | | char == '\x0c' || [INFO] [stdout] 320 | | char == '\n' || [INFO] [stdout] 321 | | char == ' ' || [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 316 - if char == '\t' || [INFO] [stdout] 317 - char == '\n' || [INFO] [stdout] 318 - char == '\x0b' || [INFO] [stdout] 319 - char == '\x0c' || [INFO] [stdout] 320 - char == '\n' || [INFO] [stdout] 321 - char == ' ' || [INFO] [stdout] 316 + if !(char != '\t' && char != '\n' && char != '\x0b' && char != '\x0c' && char != ' ') || [INFO] [stdout] | [INFO] [stdout] 316 - if char == '\t' || [INFO] [stdout] 317 - char == '\n' || [INFO] [stdout] 318 - char == '\x0b' || [INFO] [stdout] 319 - char == '\x0c' || [INFO] [stdout] 320 - char == '\n' || [INFO] [stdout] 321 - char == ' ' || [INFO] [stdout] 316 + if char == '\t' || char == '\n' || char == '\x0b' || char == '\x0c' || char == ' ' || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/converters.rs:316:6 [INFO] [stdout] | [INFO] [stdout] 316 | if char == '\t' || [INFO] [stdout] | ____________^ [INFO] [stdout] 317 | | char == '\n' || [INFO] [stdout] 318 | | char == '\x0b' || [INFO] [stdout] 319 | | char == '\x0c' || [INFO] [stdout] 320 | | char == '\n' || [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 316 - if char == '\t' || [INFO] [stdout] 317 - char == '\n' || [INFO] [stdout] 318 - char == '\x0b' || [INFO] [stdout] 319 - char == '\x0c' || [INFO] [stdout] 320 - char == '\n' || [INFO] [stdout] 316 + if !(char != '\t' && char != '\n' && char != '\x0b' && char != '\x0c') || [INFO] [stdout] | [INFO] [stdout] 316 - if char == '\t' || [INFO] [stdout] 317 - char == '\n' || [INFO] [stdout] 318 - char == '\x0b' || [INFO] [stdout] 319 - char == '\x0c' || [INFO] [stdout] 320 - char == '\n' || [INFO] [stdout] 316 + if char == '\t' || char == '\n' || char == '\x0b' || char == '\x0c' || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/converters.rs:296:5 [INFO] [stdout] | [INFO] [stdout] 296 | o: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 296 - o: &String, [INFO] [stdout] 296 + o: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/converters.rs:339:32 [INFO] [stdout] | [INFO] [stdout] 339 | tmp = result.overflowing_add(position.unwrap() as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `position.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/format.rs:99:8 [INFO] [stdout] | [INFO] [stdout] 99 | text: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 99 ~ text: &str, [INFO] [stdout] 100 | options: FormatOptions, [INFO] [stdout] ... [INFO] [stdout] 104 | .unwrap_or(' '); [INFO] [stdout] 105 ~ let mut result = text.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:114:20 [INFO] [stdout] | [INFO] [stdout] 114 | result.push_str(&String::from(filling).repeat(width).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `String::from(filling).repeat(width).as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/format.rs:566:11 [INFO] [stdout] | [INFO] [stdout] 566 | if !character.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `character.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:672:54 [INFO] [stdout] | [INFO] [stdout] 672 | CFormatTypeSpecifier::Integer => result.push_str(&format_text(&itoa_signed( [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 673 | | if let CFormatArgument::Int32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 674 | | *temp as isize [INFO] [stdout] 675 | | } else { [INFO] [stdout] 676 | | return result [INFO] [stdout] 677 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 672 ~ CFormatTypeSpecifier::Integer => result.push_str(format_text(&itoa_signed( [INFO] [stdout] 673 ~ if let CFormatArgument::Int32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 674 ~ *temp as isize [INFO] [stdout] 675 ~ } else { [INFO] [stdout] 676 ~ return result [INFO] [stdout] 677 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:678:52 [INFO] [stdout] | [INFO] [stdout] 678 | CFormatTypeSpecifier::Octal => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 679 | | if let CFormatArgument::UInt32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 680 | | *temp as usize [INFO] [stdout] 681 | | } else { [INFO] [stdout] 682 | | return result [INFO] [stdout] 683 | | }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 678 ~ CFormatTypeSpecifier::Octal => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 679 ~ if let CFormatArgument::UInt32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 680 ~ *temp as usize [INFO] [stdout] 681 ~ } else { [INFO] [stdout] 682 ~ return result [INFO] [stdout] 683 ~ }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:684:55 [INFO] [stdout] | [INFO] [stdout] 684 | CFormatTypeSpecifier::Unsigned => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ___________________________________________________________________^ [INFO] [stdout] 685 | | if let CFormatArgument::UInt32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 686 | | *temp as usize [INFO] [stdout] 687 | | } else { [INFO] [stdout] 688 | | return result [INFO] [stdout] 689 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 684 ~ CFormatTypeSpecifier::Unsigned => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 685 ~ if let CFormatArgument::UInt32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 686 ~ *temp as usize [INFO] [stdout] 687 ~ } else { [INFO] [stdout] 688 ~ return result [INFO] [stdout] 689 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:690:55 [INFO] [stdout] | [INFO] [stdout] 690 | CFormatTypeSpecifier::LowerHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ___________________________________________________________________^ [INFO] [stdout] 691 | | if let CFormatArgument::UInt32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 692 | | *temp as usize [INFO] [stdout] 693 | | } else { [INFO] [stdout] 694 | | return result [INFO] [stdout] 695 | | }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 690 ~ CFormatTypeSpecifier::LowerHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 691 ~ if let CFormatArgument::UInt32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 692 ~ *temp as usize [INFO] [stdout] 693 ~ } else { [INFO] [stdout] 694 ~ return result [INFO] [stdout] 695 ~ }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:696:55 [INFO] [stdout] | [INFO] [stdout] 696 | CFormatTypeSpecifier::UpperHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ___________________________________________________________________^ [INFO] [stdout] 697 | | if let CFormatArgument::UInt32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 698 | | *temp as usize [INFO] [stdout] 699 | | } else { [INFO] [stdout] 700 | | return result [INFO] [stdout] 701 | | }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 696 ~ CFormatTypeSpecifier::UpperHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 697 ~ if let CFormatArgument::UInt32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 698 ~ *temp as usize [INFO] [stdout] 699 ~ } else { [INFO] [stdout] 700 ~ return result [INFO] [stdout] 701 ~ }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:702:54 [INFO] [stdout] | [INFO] [stdout] 702 | CFormatTypeSpecifier::LongInt => result.push_str(&format_text(&itoa_signed( [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 703 | | if let CFormatArgument::IntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 704 | | *temp as isize [INFO] [stdout] 705 | | } else { [INFO] [stdout] 706 | | return result [INFO] [stdout] 707 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 702 ~ CFormatTypeSpecifier::LongInt => result.push_str(format_text(&itoa_signed( [INFO] [stdout] 703 ~ if let CFormatArgument::IntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 704 ~ *temp as isize [INFO] [stdout] 705 ~ } else { [INFO] [stdout] 706 ~ return result [INFO] [stdout] 707 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`isize` -> `isize`) [INFO] [stdout] --> src/format.rs:704:7 [INFO] [stdout] | [INFO] [stdout] 704 | *temp as isize [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `*temp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:708:56 [INFO] [stdout] | [INFO] [stdout] 708 | CFormatTypeSpecifier::LongOctal => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 709 | | if let CFormatArgument::UIntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 710 | | *temp as usize [INFO] [stdout] 711 | | } else { [INFO] [stdout] 712 | | return result [INFO] [stdout] 713 | | }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 708 ~ CFormatTypeSpecifier::LongOctal => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 709 ~ if let CFormatArgument::UIntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 710 ~ *temp as usize [INFO] [stdout] 711 ~ } else { [INFO] [stdout] 712 ~ return result [INFO] [stdout] 713 ~ }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/format.rs:710:7 [INFO] [stdout] | [INFO] [stdout] 710 | *temp as usize [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `*temp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:714:59 [INFO] [stdout] | [INFO] [stdout] 714 | CFormatTypeSpecifier::LongUnsigned => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | _______________________________________________________________________^ [INFO] [stdout] 715 | | if let CFormatArgument::UIntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 716 | | *temp [INFO] [stdout] 717 | | } else { [INFO] [stdout] 718 | | return result [INFO] [stdout] 719 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 714 ~ CFormatTypeSpecifier::LongUnsigned => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 715 ~ if let CFormatArgument::UIntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 716 ~ *temp [INFO] [stdout] 717 ~ } else { [INFO] [stdout] 718 ~ return result [INFO] [stdout] 719 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:720:59 [INFO] [stdout] | [INFO] [stdout] 720 | CFormatTypeSpecifier::LongLowerHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | _______________________________________________________________________^ [INFO] [stdout] 721 | | if let CFormatArgument::UIntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 722 | | *temp [INFO] [stdout] 723 | | } else { [INFO] [stdout] 724 | | return result [INFO] [stdout] 725 | | }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 720 ~ CFormatTypeSpecifier::LongLowerHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 721 ~ if let CFormatArgument::UIntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 722 ~ *temp [INFO] [stdout] 723 ~ } else { [INFO] [stdout] 724 ~ return result [INFO] [stdout] 725 ~ }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:726:59 [INFO] [stdout] | [INFO] [stdout] 726 | CFormatTypeSpecifier::LongUpperHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | _______________________________________________________________________^ [INFO] [stdout] 727 | | if let CFormatArgument::UIntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 728 | | *temp [INFO] [stdout] 729 | | } else { [INFO] [stdout] 730 | | return result [INFO] [stdout] 731 | | }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 726 ~ CFormatTypeSpecifier::LongUpperHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 727 ~ if let CFormatArgument::UIntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 728 ~ *temp [INFO] [stdout] 729 ~ } else { [INFO] [stdout] 730 ~ return result [INFO] [stdout] 731 ~ }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:732:58 [INFO] [stdout] | [INFO] [stdout] 732 | CFormatTypeSpecifier::LongLongInt => result.push_str(&format_text(&itoa_signed( [INFO] [stdout] | ______________________________________________________________________^ [INFO] [stdout] 733 | | if let CFormatArgument::Int64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 734 | | *temp as isize [INFO] [stdout] 735 | | } else { [INFO] [stdout] 736 | | return result [INFO] [stdout] 737 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 732 ~ CFormatTypeSpecifier::LongLongInt => result.push_str(format_text(&itoa_signed( [INFO] [stdout] 733 ~ if let CFormatArgument::Int64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 734 ~ *temp as isize [INFO] [stdout] 735 ~ } else { [INFO] [stdout] 736 ~ return result [INFO] [stdout] 737 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:738:60 [INFO] [stdout] | [INFO] [stdout] 738 | CFormatTypeSpecifier::LongLongOctal => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 739 | | if let CFormatArgument::UInt64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 740 | | *temp as usize [INFO] [stdout] 741 | | } else { [INFO] [stdout] 742 | | return result [INFO] [stdout] 743 | | }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 738 ~ CFormatTypeSpecifier::LongLongOctal => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 739 ~ if let CFormatArgument::UInt64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 740 ~ *temp as usize [INFO] [stdout] 741 ~ } else { [INFO] [stdout] 742 ~ return result [INFO] [stdout] 743 ~ }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:744:63 [INFO] [stdout] | [INFO] [stdout] 744 | CFormatTypeSpecifier::LongLongUnsigned => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ___________________________________________________________________________^ [INFO] [stdout] 745 | | if let CFormatArgument::UInt64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 746 | | *temp as usize [INFO] [stdout] 747 | | } else { [INFO] [stdout] 748 | | return result [INFO] [stdout] 749 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 744 ~ CFormatTypeSpecifier::LongLongUnsigned => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 745 ~ if let CFormatArgument::UInt64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 746 ~ *temp as usize [INFO] [stdout] 747 ~ } else { [INFO] [stdout] 748 ~ return result [INFO] [stdout] 749 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:750:63 [INFO] [stdout] | [INFO] [stdout] 750 | CFormatTypeSpecifier::LongLongLowerHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ___________________________________________________________________________^ [INFO] [stdout] 751 | | if let CFormatArgument::UInt64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 752 | | *temp as usize [INFO] [stdout] 753 | | } else { [INFO] [stdout] 754 | | return result [INFO] [stdout] 755 | | }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 750 ~ CFormatTypeSpecifier::LongLongLowerHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 751 ~ if let CFormatArgument::UInt64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 752 ~ *temp as usize [INFO] [stdout] 753 ~ } else { [INFO] [stdout] 754 ~ return result [INFO] [stdout] 755 ~ }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:756:63 [INFO] [stdout] | [INFO] [stdout] 756 | CFormatTypeSpecifier::LongLongUpperHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ___________________________________________________________________________^ [INFO] [stdout] 757 | | if let CFormatArgument::UInt64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 758 | | *temp as usize [INFO] [stdout] 759 | | } else { [INFO] [stdout] 760 | | return result [INFO] [stdout] 761 | | }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 756 ~ CFormatTypeSpecifier::LongLongUpperHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 757 ~ if let CFormatArgument::UInt64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 758 ~ *temp as usize [INFO] [stdout] 759 ~ } else { [INFO] [stdout] 760 ~ return result [INFO] [stdout] 761 ~ }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:762:55 [INFO] [stdout] | [INFO] [stdout] 762 | CFormatTypeSpecifier::ShortInt => result.push_str(&format_text(&itoa_signed( [INFO] [stdout] | ___________________________________________________________________^ [INFO] [stdout] 763 | | if let CFormatArgument::Int16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 764 | | *temp as isize [INFO] [stdout] 765 | | } else { [INFO] [stdout] 766 | | return result [INFO] [stdout] 767 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 762 ~ CFormatTypeSpecifier::ShortInt => result.push_str(format_text(&itoa_signed( [INFO] [stdout] 763 ~ if let CFormatArgument::Int16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 764 ~ *temp as isize [INFO] [stdout] 765 ~ } else { [INFO] [stdout] 766 ~ return result [INFO] [stdout] 767 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:768:57 [INFO] [stdout] | [INFO] [stdout] 768 | CFormatTypeSpecifier::ShortOctal => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 769 | | if let CFormatArgument::UInt16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 770 | | *temp as usize [INFO] [stdout] 771 | | } else { [INFO] [stdout] 772 | | return result [INFO] [stdout] 773 | | }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 768 ~ CFormatTypeSpecifier::ShortOctal => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 769 ~ if let CFormatArgument::UInt16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 770 ~ *temp as usize [INFO] [stdout] 771 ~ } else { [INFO] [stdout] 772 ~ return result [INFO] [stdout] 773 ~ }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:774:60 [INFO] [stdout] | [INFO] [stdout] 774 | CFormatTypeSpecifier::ShortUnsigned => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 775 | | if let CFormatArgument::UInt16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 776 | | *temp as usize [INFO] [stdout] 777 | | } else { [INFO] [stdout] 778 | | return result [INFO] [stdout] 779 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 774 ~ CFormatTypeSpecifier::ShortUnsigned => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 775 ~ if let CFormatArgument::UInt16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 776 ~ *temp as usize [INFO] [stdout] 777 ~ } else { [INFO] [stdout] 778 ~ return result [INFO] [stdout] 779 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:780:60 [INFO] [stdout] | [INFO] [stdout] 780 | CFormatTypeSpecifier::ShortLowerHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 781 | | if let CFormatArgument::UInt16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 782 | | *temp as usize [INFO] [stdout] 783 | | } else { [INFO] [stdout] 784 | | return result [INFO] [stdout] 785 | | }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 780 ~ CFormatTypeSpecifier::ShortLowerHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 781 ~ if let CFormatArgument::UInt16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 782 ~ *temp as usize [INFO] [stdout] 783 ~ } else { [INFO] [stdout] 784 ~ return result [INFO] [stdout] 785 ~ }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:786:60 [INFO] [stdout] | [INFO] [stdout] 786 | CFormatTypeSpecifier::ShortUpperHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 787 | | if let CFormatArgument::UInt16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 788 | | *temp as usize [INFO] [stdout] 789 | | } else { [INFO] [stdout] 790 | | return result [INFO] [stdout] 791 | | }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 786 ~ CFormatTypeSpecifier::ShortUpperHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 787 ~ if let CFormatArgument::UInt16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 788 ~ *temp as usize [INFO] [stdout] 789 ~ } else { [INFO] [stdout] 790 ~ return result [INFO] [stdout] 791 ~ }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:792:54 [INFO] [stdout] | [INFO] [stdout] 792 | CFormatTypeSpecifier::ByteInt => result.push_str(&format_text(&itoa_signed( [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 793 | | if let CFormatArgument::Int8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 794 | | *temp as isize [INFO] [stdout] 795 | | } else { [INFO] [stdout] 796 | | return result [INFO] [stdout] 797 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 792 ~ CFormatTypeSpecifier::ByteInt => result.push_str(format_text(&itoa_signed( [INFO] [stdout] 793 ~ if let CFormatArgument::Int8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 794 ~ *temp as isize [INFO] [stdout] 795 ~ } else { [INFO] [stdout] 796 ~ return result [INFO] [stdout] 797 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:798:56 [INFO] [stdout] | [INFO] [stdout] 798 | CFormatTypeSpecifier::ByteOctal => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 799 | | if let CFormatArgument::UInt8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 800 | | *temp as usize [INFO] [stdout] 801 | | } else { [INFO] [stdout] 802 | | return result [INFO] [stdout] 803 | | }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 798 ~ CFormatTypeSpecifier::ByteOctal => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 799 ~ if let CFormatArgument::UInt8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 800 ~ *temp as usize [INFO] [stdout] 801 ~ } else { [INFO] [stdout] 802 ~ return result [INFO] [stdout] 803 ~ }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:804:59 [INFO] [stdout] | [INFO] [stdout] 804 | CFormatTypeSpecifier::ByteUnsigned => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | _______________________________________________________________________^ [INFO] [stdout] 805 | | if let CFormatArgument::UInt8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 806 | | *temp as usize [INFO] [stdout] 807 | | } else { [INFO] [stdout] 808 | | return result [INFO] [stdout] 809 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 804 ~ CFormatTypeSpecifier::ByteUnsigned => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 805 ~ if let CFormatArgument::UInt8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 806 ~ *temp as usize [INFO] [stdout] 807 ~ } else { [INFO] [stdout] 808 ~ return result [INFO] [stdout] 809 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:810:59 [INFO] [stdout] | [INFO] [stdout] 810 | CFormatTypeSpecifier::ByteLowerHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | _______________________________________________________________________^ [INFO] [stdout] 811 | | if let CFormatArgument::UInt8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 812 | | *temp as usize [INFO] [stdout] 813 | | } else { [INFO] [stdout] 814 | | return result [INFO] [stdout] 815 | | }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 810 ~ CFormatTypeSpecifier::ByteLowerHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 811 ~ if let CFormatArgument::UInt8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 812 ~ *temp as usize [INFO] [stdout] 813 ~ } else { [INFO] [stdout] 814 ~ return result [INFO] [stdout] 815 ~ }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:816:59 [INFO] [stdout] | [INFO] [stdout] 816 | CFormatTypeSpecifier::ByteUpperHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | _______________________________________________________________________^ [INFO] [stdout] 817 | | if let CFormatArgument::UInt8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 818 | | *temp as usize [INFO] [stdout] 819 | | } else { [INFO] [stdout] 820 | | return result [INFO] [stdout] 821 | | }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 816 ~ CFormatTypeSpecifier::ByteUpperHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 817 ~ if let CFormatArgument::UInt8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 818 ~ *temp as usize [INFO] [stdout] 819 ~ } else { [INFO] [stdout] 820 ~ return result [INFO] [stdout] 821 ~ }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:822:54 [INFO] [stdout] | [INFO] [stdout] 822 | CFormatTypeSpecifier::Pointer => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 823 | | if let CFormatArgument::Pointer(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 824 | | *temp as usize [INFO] [stdout] 825 | | } else { [INFO] [stdout] 826 | | return result [INFO] [stdout] 827 | | }, Base::new(16), Case::Upper), [INFO] [stdout] 828 | | FormatOptions::new(FormatDirection::Right(usize::BITS as usize / u8::BITS as usize), Some('0'))).as_str() [INFO] [stdout] | |_________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 822 ~ CFormatTypeSpecifier::Pointer => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 823 ~ if let CFormatArgument::Pointer(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 824 ~ *temp as usize [INFO] [stdout] 825 ~ } else { [INFO] [stdout] 826 ~ return result [INFO] [stdout] 827 ~ }, Base::new(16), Case::Upper), [INFO] [stdout] 828 ~ FormatOptions::new(FormatDirection::Right(usize::BITS as usize / u8::BITS as usize), Some('0'))).as_str() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/converters.rs:229:6 [INFO] [stdout] | [INFO] [stdout] 229 | if char == '\t' || [INFO] [stdout] | ____________^ [INFO] [stdout] 230 | | char == '\n' || [INFO] [stdout] 231 | | char == '\x0b' || [INFO] [stdout] 232 | | char == '\x0c' || [INFO] [stdout] 233 | | char == '\n' || [INFO] [stdout] 234 | | char == ' ' || [INFO] [stdout] 235 | | char == '_' [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 229 - if char == '\t' || [INFO] [stdout] 230 - char == '\n' || [INFO] [stdout] 231 - char == '\x0b' || [INFO] [stdout] 232 - char == '\x0c' || [INFO] [stdout] 233 - char == '\n' || [INFO] [stdout] 234 - char == ' ' || [INFO] [stdout] 235 - char == '_' [INFO] [stdout] 229 + if !(char != '\t' && char != '\n' && char != '\x0b' && char != '\x0c' && char != ' ' && char != '_') [INFO] [stdout] | [INFO] [stdout] 229 - if char == '\t' || [INFO] [stdout] 230 - char == '\n' || [INFO] [stdout] 231 - char == '\x0b' || [INFO] [stdout] 232 - char == '\x0c' || [INFO] [stdout] 233 - char == '\n' || [INFO] [stdout] 234 - char == ' ' || [INFO] [stdout] 235 - char == '_' [INFO] [stdout] 229 + if char == '\t' || char == '\n' || char == '\x0b' || char == '\x0c' || char == ' ' || char == '_' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/converters.rs:229:6 [INFO] [stdout] | [INFO] [stdout] 229 | if char == '\t' || [INFO] [stdout] | ____________^ [INFO] [stdout] 230 | | char == '\n' || [INFO] [stdout] 231 | | char == '\x0b' || [INFO] [stdout] 232 | | char == '\x0c' || [INFO] [stdout] 233 | | char == '\n' || [INFO] [stdout] 234 | | char == ' ' || [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 229 - if char == '\t' || [INFO] [stdout] 230 - char == '\n' || [INFO] [stdout] 231 - char == '\x0b' || [INFO] [stdout] 232 - char == '\x0c' || [INFO] [stdout] 233 - char == '\n' || [INFO] [stdout] 234 - char == ' ' || [INFO] [stdout] 229 + if !(char != '\t' && char != '\n' && char != '\x0b' && char != '\x0c' && char != ' ') || [INFO] [stdout] | [INFO] [stdout] 229 - if char == '\t' || [INFO] [stdout] 230 - char == '\n' || [INFO] [stdout] 231 - char == '\x0b' || [INFO] [stdout] 232 - char == '\x0c' || [INFO] [stdout] 233 - char == '\n' || [INFO] [stdout] 234 - char == ' ' || [INFO] [stdout] 229 + if char == '\t' || char == '\n' || char == '\x0b' || char == '\x0c' || char == ' ' || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/converters.rs:229:6 [INFO] [stdout] | [INFO] [stdout] 229 | if char == '\t' || [INFO] [stdout] | ____________^ [INFO] [stdout] 230 | | char == '\n' || [INFO] [stdout] 231 | | char == '\x0b' || [INFO] [stdout] 232 | | char == '\x0c' || [INFO] [stdout] 233 | | char == '\n' || [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 229 - if char == '\t' || [INFO] [stdout] 230 - char == '\n' || [INFO] [stdout] 231 - char == '\x0b' || [INFO] [stdout] 232 - char == '\x0c' || [INFO] [stdout] 233 - char == '\n' || [INFO] [stdout] 229 + if !(char != '\t' && char != '\n' && char != '\x0b' && char != '\x0c') || [INFO] [stdout] | [INFO] [stdout] 229 - if char == '\t' || [INFO] [stdout] 230 - char == '\n' || [INFO] [stdout] 231 - char == '\x0b' || [INFO] [stdout] 232 - char == '\x0c' || [INFO] [stdout] 233 - char == '\n' || [INFO] [stdout] 229 + if char == '\t' || char == '\n' || char == '\x0b' || char == '\x0c' || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/converters.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | o: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 204 - o: &String, [INFO] [stdout] 204 + o: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/converters.rs:316:6 [INFO] [stdout] | [INFO] [stdout] 316 | if char == '\t' || [INFO] [stdout] | ____________^ [INFO] [stdout] 317 | | char == '\n' || [INFO] [stdout] 318 | | char == '\x0b' || [INFO] [stdout] 319 | | char == '\x0c' || [INFO] [stdout] 320 | | char == '\n' || [INFO] [stdout] 321 | | char == ' ' || [INFO] [stdout] 322 | | char == '_' [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 316 - if char == '\t' || [INFO] [stdout] 317 - char == '\n' || [INFO] [stdout] 318 - char == '\x0b' || [INFO] [stdout] 319 - char == '\x0c' || [INFO] [stdout] 320 - char == '\n' || [INFO] [stdout] 321 - char == ' ' || [INFO] [stdout] 322 - char == '_' [INFO] [stdout] 316 + if !(char != '\t' && char != '\n' && char != '\x0b' && char != '\x0c' && char != ' ' && char != '_') [INFO] [stdout] | [INFO] [stdout] 316 - if char == '\t' || [INFO] [stdout] 317 - char == '\n' || [INFO] [stdout] 318 - char == '\x0b' || [INFO] [stdout] 319 - char == '\x0c' || [INFO] [stdout] 320 - char == '\n' || [INFO] [stdout] 321 - char == ' ' || [INFO] [stdout] 322 - char == '_' [INFO] [stdout] 316 + if char == '\t' || char == '\n' || char == '\x0b' || char == '\x0c' || char == ' ' || char == '_' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/converters.rs:316:6 [INFO] [stdout] | [INFO] [stdout] 316 | if char == '\t' || [INFO] [stdout] | ____________^ [INFO] [stdout] 317 | | char == '\n' || [INFO] [stdout] 318 | | char == '\x0b' || [INFO] [stdout] 319 | | char == '\x0c' || [INFO] [stdout] 320 | | char == '\n' || [INFO] [stdout] 321 | | char == ' ' || [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 316 - if char == '\t' || [INFO] [stdout] 317 - char == '\n' || [INFO] [stdout] 318 - char == '\x0b' || [INFO] [stdout] 319 - char == '\x0c' || [INFO] [stdout] 320 - char == '\n' || [INFO] [stdout] 321 - char == ' ' || [INFO] [stdout] 316 + if !(char != '\t' && char != '\n' && char != '\x0b' && char != '\x0c' && char != ' ') || [INFO] [stdout] | [INFO] [stdout] 316 - if char == '\t' || [INFO] [stdout] 317 - char == '\n' || [INFO] [stdout] 318 - char == '\x0b' || [INFO] [stdout] 319 - char == '\x0c' || [INFO] [stdout] 320 - char == '\n' || [INFO] [stdout] 321 - char == ' ' || [INFO] [stdout] 316 + if char == '\t' || char == '\n' || char == '\x0b' || char == '\x0c' || char == ' ' || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/converters.rs:316:6 [INFO] [stdout] | [INFO] [stdout] 316 | if char == '\t' || [INFO] [stdout] | ____________^ [INFO] [stdout] 317 | | char == '\n' || [INFO] [stdout] 318 | | char == '\x0b' || [INFO] [stdout] 319 | | char == '\x0c' || [INFO] [stdout] 320 | | char == '\n' || [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 316 - if char == '\t' || [INFO] [stdout] 317 - char == '\n' || [INFO] [stdout] 318 - char == '\x0b' || [INFO] [stdout] 319 - char == '\x0c' || [INFO] [stdout] 320 - char == '\n' || [INFO] [stdout] 316 + if !(char != '\t' && char != '\n' && char != '\x0b' && char != '\x0c') || [INFO] [stdout] | [INFO] [stdout] 316 - if char == '\t' || [INFO] [stdout] 317 - char == '\n' || [INFO] [stdout] 318 - char == '\x0b' || [INFO] [stdout] 319 - char == '\x0c' || [INFO] [stdout] 320 - char == '\n' || [INFO] [stdout] 316 + if char == '\t' || char == '\n' || char == '\x0b' || char == '\x0c' || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/converters.rs:296:5 [INFO] [stdout] | [INFO] [stdout] 296 | o: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 296 - o: &String, [INFO] [stdout] 296 + o: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/converters.rs:339:32 [INFO] [stdout] | [INFO] [stdout] 339 | tmp = result.overflowing_add(position.unwrap() as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `position.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/format.rs:99:8 [INFO] [stdout] | [INFO] [stdout] 99 | text: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 99 ~ text: &str, [INFO] [stdout] 100 | options: FormatOptions, [INFO] [stdout] ... [INFO] [stdout] 104 | .unwrap_or(' '); [INFO] [stdout] 105 ~ let mut result = text.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:114:20 [INFO] [stdout] | [INFO] [stdout] 114 | result.push_str(&String::from(filling).repeat(width).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `String::from(filling).repeat(width).as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/format.rs:566:11 [INFO] [stdout] | [INFO] [stdout] 566 | if !character.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `character.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:672:54 [INFO] [stdout] | [INFO] [stdout] 672 | CFormatTypeSpecifier::Integer => result.push_str(&format_text(&itoa_signed( [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 673 | | if let CFormatArgument::Int32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 674 | | *temp as isize [INFO] [stdout] 675 | | } else { [INFO] [stdout] 676 | | return result [INFO] [stdout] 677 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 672 ~ CFormatTypeSpecifier::Integer => result.push_str(format_text(&itoa_signed( [INFO] [stdout] 673 ~ if let CFormatArgument::Int32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 674 ~ *temp as isize [INFO] [stdout] 675 ~ } else { [INFO] [stdout] 676 ~ return result [INFO] [stdout] 677 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:678:52 [INFO] [stdout] | [INFO] [stdout] 678 | CFormatTypeSpecifier::Octal => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 679 | | if let CFormatArgument::UInt32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 680 | | *temp as usize [INFO] [stdout] 681 | | } else { [INFO] [stdout] 682 | | return result [INFO] [stdout] 683 | | }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 678 ~ CFormatTypeSpecifier::Octal => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 679 ~ if let CFormatArgument::UInt32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 680 ~ *temp as usize [INFO] [stdout] 681 ~ } else { [INFO] [stdout] 682 ~ return result [INFO] [stdout] 683 ~ }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:684:55 [INFO] [stdout] | [INFO] [stdout] 684 | CFormatTypeSpecifier::Unsigned => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ___________________________________________________________________^ [INFO] [stdout] 685 | | if let CFormatArgument::UInt32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 686 | | *temp as usize [INFO] [stdout] 687 | | } else { [INFO] [stdout] 688 | | return result [INFO] [stdout] 689 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 684 ~ CFormatTypeSpecifier::Unsigned => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 685 ~ if let CFormatArgument::UInt32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 686 ~ *temp as usize [INFO] [stdout] 687 ~ } else { [INFO] [stdout] 688 ~ return result [INFO] [stdout] 689 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:690:55 [INFO] [stdout] | [INFO] [stdout] 690 | CFormatTypeSpecifier::LowerHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ___________________________________________________________________^ [INFO] [stdout] 691 | | if let CFormatArgument::UInt32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 692 | | *temp as usize [INFO] [stdout] 693 | | } else { [INFO] [stdout] 694 | | return result [INFO] [stdout] 695 | | }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 690 ~ CFormatTypeSpecifier::LowerHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 691 ~ if let CFormatArgument::UInt32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 692 ~ *temp as usize [INFO] [stdout] 693 ~ } else { [INFO] [stdout] 694 ~ return result [INFO] [stdout] 695 ~ }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:696:55 [INFO] [stdout] | [INFO] [stdout] 696 | CFormatTypeSpecifier::UpperHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ___________________________________________________________________^ [INFO] [stdout] 697 | | if let CFormatArgument::UInt32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 698 | | *temp as usize [INFO] [stdout] 699 | | } else { [INFO] [stdout] 700 | | return result [INFO] [stdout] 701 | | }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 696 ~ CFormatTypeSpecifier::UpperHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 697 ~ if let CFormatArgument::UInt32(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 698 ~ *temp as usize [INFO] [stdout] 699 ~ } else { [INFO] [stdout] 700 ~ return result [INFO] [stdout] 701 ~ }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:702:54 [INFO] [stdout] | [INFO] [stdout] 702 | CFormatTypeSpecifier::LongInt => result.push_str(&format_text(&itoa_signed( [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 703 | | if let CFormatArgument::IntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 704 | | *temp as isize [INFO] [stdout] 705 | | } else { [INFO] [stdout] 706 | | return result [INFO] [stdout] 707 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 702 ~ CFormatTypeSpecifier::LongInt => result.push_str(format_text(&itoa_signed( [INFO] [stdout] 703 ~ if let CFormatArgument::IntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 704 ~ *temp as isize [INFO] [stdout] 705 ~ } else { [INFO] [stdout] 706 ~ return result [INFO] [stdout] 707 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`isize` -> `isize`) [INFO] [stdout] --> src/format.rs:704:7 [INFO] [stdout] | [INFO] [stdout] 704 | *temp as isize [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `*temp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:708:56 [INFO] [stdout] | [INFO] [stdout] 708 | CFormatTypeSpecifier::LongOctal => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 709 | | if let CFormatArgument::UIntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 710 | | *temp as usize [INFO] [stdout] 711 | | } else { [INFO] [stdout] 712 | | return result [INFO] [stdout] 713 | | }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 708 ~ CFormatTypeSpecifier::LongOctal => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 709 ~ if let CFormatArgument::UIntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 710 ~ *temp as usize [INFO] [stdout] 711 ~ } else { [INFO] [stdout] 712 ~ return result [INFO] [stdout] 713 ~ }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/format.rs:710:7 [INFO] [stdout] | [INFO] [stdout] 710 | *temp as usize [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `*temp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:714:59 [INFO] [stdout] | [INFO] [stdout] 714 | CFormatTypeSpecifier::LongUnsigned => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | _______________________________________________________________________^ [INFO] [stdout] 715 | | if let CFormatArgument::UIntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 716 | | *temp [INFO] [stdout] 717 | | } else { [INFO] [stdout] 718 | | return result [INFO] [stdout] 719 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 714 ~ CFormatTypeSpecifier::LongUnsigned => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 715 ~ if let CFormatArgument::UIntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 716 ~ *temp [INFO] [stdout] 717 ~ } else { [INFO] [stdout] 718 ~ return result [INFO] [stdout] 719 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:720:59 [INFO] [stdout] | [INFO] [stdout] 720 | CFormatTypeSpecifier::LongLowerHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | _______________________________________________________________________^ [INFO] [stdout] 721 | | if let CFormatArgument::UIntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 722 | | *temp [INFO] [stdout] 723 | | } else { [INFO] [stdout] 724 | | return result [INFO] [stdout] 725 | | }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 720 ~ CFormatTypeSpecifier::LongLowerHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 721 ~ if let CFormatArgument::UIntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 722 ~ *temp [INFO] [stdout] 723 ~ } else { [INFO] [stdout] 724 ~ return result [INFO] [stdout] 725 ~ }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:726:59 [INFO] [stdout] | [INFO] [stdout] 726 | CFormatTypeSpecifier::LongUpperHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | _______________________________________________________________________^ [INFO] [stdout] 727 | | if let CFormatArgument::UIntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 728 | | *temp [INFO] [stdout] 729 | | } else { [INFO] [stdout] 730 | | return result [INFO] [stdout] 731 | | }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 726 ~ CFormatTypeSpecifier::LongUpperHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 727 ~ if let CFormatArgument::UIntSize(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 728 ~ *temp [INFO] [stdout] 729 ~ } else { [INFO] [stdout] 730 ~ return result [INFO] [stdout] 731 ~ }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:732:58 [INFO] [stdout] | [INFO] [stdout] 732 | CFormatTypeSpecifier::LongLongInt => result.push_str(&format_text(&itoa_signed( [INFO] [stdout] | ______________________________________________________________________^ [INFO] [stdout] 733 | | if let CFormatArgument::Int64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 734 | | *temp as isize [INFO] [stdout] 735 | | } else { [INFO] [stdout] 736 | | return result [INFO] [stdout] 737 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 732 ~ CFormatTypeSpecifier::LongLongInt => result.push_str(format_text(&itoa_signed( [INFO] [stdout] 733 ~ if let CFormatArgument::Int64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 734 ~ *temp as isize [INFO] [stdout] 735 ~ } else { [INFO] [stdout] 736 ~ return result [INFO] [stdout] 737 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:738:60 [INFO] [stdout] | [INFO] [stdout] 738 | CFormatTypeSpecifier::LongLongOctal => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 739 | | if let CFormatArgument::UInt64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 740 | | *temp as usize [INFO] [stdout] 741 | | } else { [INFO] [stdout] 742 | | return result [INFO] [stdout] 743 | | }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 738 ~ CFormatTypeSpecifier::LongLongOctal => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 739 ~ if let CFormatArgument::UInt64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 740 ~ *temp as usize [INFO] [stdout] 741 ~ } else { [INFO] [stdout] 742 ~ return result [INFO] [stdout] 743 ~ }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:744:63 [INFO] [stdout] | [INFO] [stdout] 744 | CFormatTypeSpecifier::LongLongUnsigned => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ___________________________________________________________________________^ [INFO] [stdout] 745 | | if let CFormatArgument::UInt64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 746 | | *temp as usize [INFO] [stdout] 747 | | } else { [INFO] [stdout] 748 | | return result [INFO] [stdout] 749 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 744 ~ CFormatTypeSpecifier::LongLongUnsigned => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 745 ~ if let CFormatArgument::UInt64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 746 ~ *temp as usize [INFO] [stdout] 747 ~ } else { [INFO] [stdout] 748 ~ return result [INFO] [stdout] 749 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:750:63 [INFO] [stdout] | [INFO] [stdout] 750 | CFormatTypeSpecifier::LongLongLowerHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ___________________________________________________________________________^ [INFO] [stdout] 751 | | if let CFormatArgument::UInt64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 752 | | *temp as usize [INFO] [stdout] 753 | | } else { [INFO] [stdout] 754 | | return result [INFO] [stdout] 755 | | }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 750 ~ CFormatTypeSpecifier::LongLongLowerHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 751 ~ if let CFormatArgument::UInt64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 752 ~ *temp as usize [INFO] [stdout] 753 ~ } else { [INFO] [stdout] 754 ~ return result [INFO] [stdout] 755 ~ }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:756:63 [INFO] [stdout] | [INFO] [stdout] 756 | CFormatTypeSpecifier::LongLongUpperHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ___________________________________________________________________________^ [INFO] [stdout] 757 | | if let CFormatArgument::UInt64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 758 | | *temp as usize [INFO] [stdout] 759 | | } else { [INFO] [stdout] 760 | | return result [INFO] [stdout] 761 | | }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 756 ~ CFormatTypeSpecifier::LongLongUpperHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 757 ~ if let CFormatArgument::UInt64(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 758 ~ *temp as usize [INFO] [stdout] 759 ~ } else { [INFO] [stdout] 760 ~ return result [INFO] [stdout] 761 ~ }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:762:55 [INFO] [stdout] | [INFO] [stdout] 762 | CFormatTypeSpecifier::ShortInt => result.push_str(&format_text(&itoa_signed( [INFO] [stdout] | ___________________________________________________________________^ [INFO] [stdout] 763 | | if let CFormatArgument::Int16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 764 | | *temp as isize [INFO] [stdout] 765 | | } else { [INFO] [stdout] 766 | | return result [INFO] [stdout] 767 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 762 ~ CFormatTypeSpecifier::ShortInt => result.push_str(format_text(&itoa_signed( [INFO] [stdout] 763 ~ if let CFormatArgument::Int16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 764 ~ *temp as isize [INFO] [stdout] 765 ~ } else { [INFO] [stdout] 766 ~ return result [INFO] [stdout] 767 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:768:57 [INFO] [stdout] | [INFO] [stdout] 768 | CFormatTypeSpecifier::ShortOctal => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 769 | | if let CFormatArgument::UInt16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 770 | | *temp as usize [INFO] [stdout] 771 | | } else { [INFO] [stdout] 772 | | return result [INFO] [stdout] 773 | | }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 768 ~ CFormatTypeSpecifier::ShortOctal => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 769 ~ if let CFormatArgument::UInt16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 770 ~ *temp as usize [INFO] [stdout] 771 ~ } else { [INFO] [stdout] 772 ~ return result [INFO] [stdout] 773 ~ }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:774:60 [INFO] [stdout] | [INFO] [stdout] 774 | CFormatTypeSpecifier::ShortUnsigned => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 775 | | if let CFormatArgument::UInt16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 776 | | *temp as usize [INFO] [stdout] 777 | | } else { [INFO] [stdout] 778 | | return result [INFO] [stdout] 779 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 774 ~ CFormatTypeSpecifier::ShortUnsigned => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 775 ~ if let CFormatArgument::UInt16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 776 ~ *temp as usize [INFO] [stdout] 777 ~ } else { [INFO] [stdout] 778 ~ return result [INFO] [stdout] 779 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:780:60 [INFO] [stdout] | [INFO] [stdout] 780 | CFormatTypeSpecifier::ShortLowerHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 781 | | if let CFormatArgument::UInt16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 782 | | *temp as usize [INFO] [stdout] 783 | | } else { [INFO] [stdout] 784 | | return result [INFO] [stdout] 785 | | }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 780 ~ CFormatTypeSpecifier::ShortLowerHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 781 ~ if let CFormatArgument::UInt16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 782 ~ *temp as usize [INFO] [stdout] 783 ~ } else { [INFO] [stdout] 784 ~ return result [INFO] [stdout] 785 ~ }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:786:60 [INFO] [stdout] | [INFO] [stdout] 786 | CFormatTypeSpecifier::ShortUpperHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ________________________________________________________________________^ [INFO] [stdout] 787 | | if let CFormatArgument::UInt16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 788 | | *temp as usize [INFO] [stdout] 789 | | } else { [INFO] [stdout] 790 | | return result [INFO] [stdout] 791 | | }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 786 ~ CFormatTypeSpecifier::ShortUpperHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 787 ~ if let CFormatArgument::UInt16(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 788 ~ *temp as usize [INFO] [stdout] 789 ~ } else { [INFO] [stdout] 790 ~ return result [INFO] [stdout] 791 ~ }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:792:54 [INFO] [stdout] | [INFO] [stdout] 792 | CFormatTypeSpecifier::ByteInt => result.push_str(&format_text(&itoa_signed( [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 793 | | if let CFormatArgument::Int8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 794 | | *temp as isize [INFO] [stdout] 795 | | } else { [INFO] [stdout] 796 | | return result [INFO] [stdout] 797 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 792 ~ CFormatTypeSpecifier::ByteInt => result.push_str(format_text(&itoa_signed( [INFO] [stdout] 793 ~ if let CFormatArgument::Int8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 794 ~ *temp as isize [INFO] [stdout] 795 ~ } else { [INFO] [stdout] 796 ~ return result [INFO] [stdout] 797 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:798:56 [INFO] [stdout] | [INFO] [stdout] 798 | CFormatTypeSpecifier::ByteOctal => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | ____________________________________________________________________^ [INFO] [stdout] 799 | | if let CFormatArgument::UInt8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 800 | | *temp as usize [INFO] [stdout] 801 | | } else { [INFO] [stdout] 802 | | return result [INFO] [stdout] 803 | | }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 798 ~ CFormatTypeSpecifier::ByteOctal => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 799 ~ if let CFormatArgument::UInt8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 800 ~ *temp as usize [INFO] [stdout] 801 ~ } else { [INFO] [stdout] 802 ~ return result [INFO] [stdout] 803 ~ }, Base::new(8), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:804:59 [INFO] [stdout] | [INFO] [stdout] 804 | CFormatTypeSpecifier::ByteUnsigned => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | _______________________________________________________________________^ [INFO] [stdout] 805 | | if let CFormatArgument::UInt8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 806 | | *temp as usize [INFO] [stdout] 807 | | } else { [INFO] [stdout] 808 | | return result [INFO] [stdout] 809 | | }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 804 ~ CFormatTypeSpecifier::ByteUnsigned => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 805 ~ if let CFormatArgument::UInt8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 806 ~ *temp as usize [INFO] [stdout] 807 ~ } else { [INFO] [stdout] 808 ~ return result [INFO] [stdout] 809 ~ }, Base::new(10), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:810:59 [INFO] [stdout] | [INFO] [stdout] 810 | CFormatTypeSpecifier::ByteLowerHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | _______________________________________________________________________^ [INFO] [stdout] 811 | | if let CFormatArgument::UInt8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 812 | | *temp as usize [INFO] [stdout] 813 | | } else { [INFO] [stdout] 814 | | return result [INFO] [stdout] 815 | | }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 810 ~ CFormatTypeSpecifier::ByteLowerHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 811 ~ if let CFormatArgument::UInt8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 812 ~ *temp as usize [INFO] [stdout] 813 ~ } else { [INFO] [stdout] 814 ~ return result [INFO] [stdout] 815 ~ }, Base::new(16), Case::Lower), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:816:59 [INFO] [stdout] | [INFO] [stdout] 816 | CFormatTypeSpecifier::ByteUpperHex => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | _______________________________________________________________________^ [INFO] [stdout] 817 | | if let CFormatArgument::UInt8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 818 | | *temp as usize [INFO] [stdout] 819 | | } else { [INFO] [stdout] 820 | | return result [INFO] [stdout] 821 | | }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 816 ~ CFormatTypeSpecifier::ByteUpperHex => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 817 ~ if let CFormatArgument::UInt8(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 818 ~ *temp as usize [INFO] [stdout] 819 ~ } else { [INFO] [stdout] 820 ~ return result [INFO] [stdout] 821 ~ }, Base::new(16), Case::Upper), options).as_str()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/format.rs:822:54 [INFO] [stdout] | [INFO] [stdout] 822 | CFormatTypeSpecifier::Pointer => result.push_str(&format_text(&itoa_unsigned( [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 823 | | if let CFormatArgument::Pointer(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 824 | | *temp as usize [INFO] [stdout] 825 | | } else { [INFO] [stdout] 826 | | return result [INFO] [stdout] 827 | | }, Base::new(16), Case::Upper), [INFO] [stdout] 828 | | FormatOptions::new(FormatDirection::Right(usize::BITS as usize / u8::BITS as usize), Some('0'))).as_str() [INFO] [stdout] | |_________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 822 ~ CFormatTypeSpecifier::Pointer => result.push_str(format_text(&itoa_unsigned( [INFO] [stdout] 823 ~ if let CFormatArgument::Pointer(temp) = args_iterator.next().unwrap() { [INFO] [stdout] 824 ~ *temp as usize [INFO] [stdout] 825 ~ } else { [INFO] [stdout] 826 ~ return result [INFO] [stdout] 827 ~ }, Base::new(16), Case::Upper), [INFO] [stdout] 828 ~ FormatOptions::new(FormatDirection::Right(usize::BITS as usize / u8::BITS as usize), Some('0'))).as_str() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/tests.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | / mod tests { [INFO] [stdout] 3 | | use crate::converters::*; [INFO] [stdout] 4 | | use crate::format::*; [INFO] [stdout] ... | [INFO] [stdout] 502 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.64s [INFO] running `Command { std: "docker" "inspect" "bce8181bdf3600ab17d8bf02adc63594109e2308bb7fb174507b97f4c84f3914", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bce8181bdf3600ab17d8bf02adc63594109e2308bb7fb174507b97f4c84f3914", kill_on_drop: false }` [INFO] [stdout] bce8181bdf3600ab17d8bf02adc63594109e2308bb7fb174507b97f4c84f3914