[INFO] fetching crate rustrict 0.7.38... [INFO] linting rustrict-0.7.38 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rustrict 0.7.38 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate rustrict 0.7.38 [INFO] finished tweaking crates.io crate rustrict 0.7.38 [INFO] tweaked toml for crates.io crate rustrict 0.7.38 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rustrict 0.7.38 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate rustrict 0.7.38 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded strsim v0.10.0 [INFO] [stderr] Downloaded serial_test_derive v0.5.1 [INFO] [stderr] Downloaded stfu v0.1.0 [INFO] [stderr] Downloaded itoa v0.4.8 [INFO] [stderr] Downloaded unicode-width v0.1.10 [INFO] [stderr] Downloaded tinyvec_macros v0.1.0 [INFO] [stderr] Downloaded tinyvec v1.3.1 [INFO] [stderr] Downloaded adler32 v1.2.0 [INFO] [stderr] Downloaded getrandom v0.2.3 [INFO] [stderr] Downloaded rayon v1.5.1 [INFO] [stderr] Downloaded csv-core v0.1.10 [INFO] [stderr] Downloaded terminal_size v0.1.17 [INFO] [stderr] Downloaded rayon-core v1.9.1 [INFO] [stderr] Downloaded color_quant v1.1.0 [INFO] [stderr] Downloaded ryu v1.0.5 [INFO] [stderr] Downloaded custom_derive v0.1.7 [INFO] [stderr] Downloaded autocfg v1.0.1 [INFO] [stderr] Downloaded scoped_threadpool v0.1.9 [INFO] [stderr] Downloaded proc-macro2 v1.0.92 [INFO] [stderr] Downloaded ab_glyph_rasterizer v0.1.5 [INFO] [stderr] Downloaded rand_chacha v0.2.2 [INFO] [stderr] Downloaded rawpointer v0.1.0 [INFO] [stderr] Downloaded serde v1.0.130 [INFO] [stderr] Downloaded num-bigint v0.3.3 [INFO] [stderr] Downloaded censor v0.3.0 [INFO] [stderr] Downloaded bincode v1.3.3 [INFO] [stderr] Downloaded num-traits v0.2.14 [INFO] [stderr] Downloaded itertools v0.9.0 [INFO] [stderr] Downloaded rand v0.7.3 [INFO] [stderr] Downloaded rulinalg v0.4.2 [INFO] [stderr] Downloaded aho-corasick v0.7.18 [INFO] [stderr] Downloaded ttf-parser v0.6.2 [INFO] [stderr] Downloaded serde_json v1.0.94 [INFO] [stderr] Downloaded itertools v0.10.1 [INFO] [stderr] Downloaded syn v1.0.82 [INFO] [stderr] Downloaded image v0.23.14 [INFO] [stderr] Downloaded jpeg-decoder v0.1.22 [INFO] [stderr] Downloaded crossbeam-channel v0.5.1 [INFO] [stderr] Downloaded bstr v0.2.16 [INFO] [stderr] Downloaded regex-syntax v0.6.25 [INFO] [stderr] Downloaded regex v1.5.4 [INFO] [stderr] Downloaded rand_distr v0.2.2 [INFO] [stderr] Downloaded encode_unicode v0.3.6 [INFO] [stderr] Downloaded console v0.14.1 [INFO] [stderr] Downloaded indicatif v0.17.0-beta.1 [INFO] [stderr] Downloaded memchr v2.4.1 [INFO] [stderr] Downloaded arrayvec v0.7.2 [INFO] [stderr] Downloaded redox_syscall v0.2.10 [INFO] [stderr] Downloaded once_cell v1.20.2 [INFO] [stderr] Downloaded gif v0.11.3 [INFO] [stderr] Downloaded finl_unicode v1.2.0 [INFO] [stderr] Downloaded miniz_oxide v0.4.4 [INFO] [stderr] Downloaded weezl v0.1.5 [INFO] [stderr] Downloaded num-complex v0.3.1 [INFO] [stderr] Downloaded libc v0.2.101 [INFO] [stderr] Downloaded rustrict v0.7.36 [INFO] [stderr] Downloaded num-rational v0.3.2 [INFO] [stderr] Downloaded wasi v0.10.2+wasi-snapshot-preview1 [INFO] [stderr] Downloaded crossbeam-epoch v0.9.5 [INFO] [stderr] Downloaded crossbeam-utils v0.8.5 [INFO] [stderr] Downloaded either v1.6.1 [INFO] [stderr] Downloaded owned_ttf_parser v0.6.0 [INFO] [stderr] Downloaded rusttype v0.9.2 [INFO] [stderr] Downloaded byteorder v1.4.3 [INFO] [stderr] Downloaded miniz_oxide v0.3.7 [INFO] [stderr] Downloaded num v0.3.1 [INFO] [stderr] Downloaded ppv-lite86 v0.2.15 [INFO] [stderr] Downloaded rand_core v0.6.3 [INFO] [stderr] Downloaded num_cpus v1.13.0 [INFO] [stderr] Downloaded rustc-hash v1.1.0 [INFO] [stderr] Downloaded csv v1.1.6 [INFO] [stderr] Downloaded scopeguard v1.1.0 [INFO] [stderr] Downloaded instant v0.1.12 [INFO] [stderr] Downloaded wasi v0.9.0+wasi-snapshot-preview1 [INFO] [stderr] Downloaded num-iter v0.1.42 [INFO] [stderr] Downloaded unicode-ident v1.0.14 [INFO] [stderr] Downloaded deflate v0.8.6 [INFO] [stderr] Downloaded num-integer v0.1.44 [INFO] [stderr] Downloaded rand_hc v0.3.1 [INFO] [stderr] Downloaded rand v0.8.4 [INFO] [stderr] Downloaded hermit-abi v0.1.19 [INFO] [stderr] Downloaded doc-comment v0.3.3 [INFO] [stderr] Downloaded itoa v1.0.6 [INFO] [stderr] Downloaded lock_api v0.4.5 [INFO] [stderr] Downloaded smallvec v1.7.0 [INFO] [stderr] Downloaded parking_lot v0.11.2 [INFO] [stderr] Downloaded unicode-xid v0.2.2 [INFO] [stderr] Downloaded conv v0.3.3 [INFO] [stderr] Downloaded bytemuck v1.8.0 [INFO] [stderr] Downloaded crc32fast v1.3.2 [INFO] [stderr] Downloaded png v0.16.8 [INFO] [stderr] Downloaded getrandom v0.1.16 [INFO] [stderr] Downloaded matrixmultiply v0.1.15 [INFO] [stderr] Downloaded num v0.1.42 [INFO] [stderr] Downloaded memoffset v0.6.4 [INFO] [stderr] Downloaded crossbeam-deque v0.8.1 [INFO] [stderr] Downloaded tiff v0.6.1 [INFO] [stderr] Downloaded parking_lot_core v0.8.5 [INFO] [stderr] Downloaded quote v1.0.37 [INFO] [stderr] Downloaded serde_derive v1.0.130 [INFO] [stderr] Downloaded walkdir v2.3.2 [INFO] [stderr] Downloaded serial_test v0.5.1 [INFO] [stderr] Downloaded winapi-util v0.1.5 [INFO] [stderr] Downloaded imageproc v0.22.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a436a3135dfc3003535e4d940a8b1424f42fd30512730810fb59974d2bcb198c [INFO] running `Command { std: "docker" "start" "-a" "a436a3135dfc3003535e4d940a8b1424f42fd30512730810fb59974d2bcb198c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a436a3135dfc3003535e4d940a8b1424f42fd30512730810fb59974d2bcb198c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a436a3135dfc3003535e4d940a8b1424f42fd30512730810fb59974d2bcb198c", kill_on_drop: false }` [INFO] [stdout] a436a3135dfc3003535e4d940a8b1424f42fd30512730810fb59974d2bcb198c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] edc8cc1365659105f5e92e4061cf2fe9e4201c54a8009826b5e04adfbd568176 [INFO] running `Command { std: "docker" "start" "-a" "edc8cc1365659105f5e92e4061cf2fe9e4201c54a8009826b5e04adfbd568176", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling unicode-ident v1.0.14 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling syn v1.0.82 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling serde_json v1.0.94 [INFO] [stderr] Checking finl_unicode v1.2.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking tinyvec v1.3.1 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Checking ppv-lite86 v0.2.15 [INFO] [stderr] Checking arrayvec v0.7.2 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking stfu v0.1.0 [INFO] [stderr] Checking censor v0.3.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking rustrict v0.7.36 [INFO] [stderr] Checking rustrict v0.7.38 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/banned.rs:19:57 [INFO] [stdout] | [INFO] [stdout] 19 | ['\u{A9C1}', '\u{A9C2}'].as_slice().into_iter().copied() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/banned.rs:21:35 [INFO] [stdout] | [INFO] [stdout] 21 | [].as_slice().into_iter().copied() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/censor.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | buffer: BufferProxyIterator, fn(&char) -> bool>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/censor.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | / pub fn from_str(s: &'a str) -> Self { [INFO] [stdout] 144 | | Self::new(s.chars()) [INFO] [stdout] 145 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/censor.rs:161:10 [INFO] [stdout] | [INFO] [stdout] 161 | ) -> BufferProxyIterator, fn(&char) -> bool>>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/censor.rs:289:13 [INFO] [stdout] | [INFO] [stdout] 289 | !self.buffer.index().is_some(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buffer.index().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/censor.rs:506:28 [INFO] [stdout] | [INFO] [stdout] 506 | .unwrap_or(&&*raw_c.encode_utf8(&mut [0; 4])) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(&*raw_c.encode_utf8(&mut [0; 4]))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `is_*` usually take `self` by mutable reference or `self` by reference or no `self` [INFO] [stdout] --> src/censor.rs:805:25 [INFO] [stdout] | [INFO] [stdout] 805 | fn is_inappropriate(self) -> bool { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking bstr v0.2.16 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Compiling serial_test_derive v0.5.1 [INFO] [stderr] Checking serial_test v0.5.1 [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/censor.rs:1266:22 [INFO] [stdout] | [INFO] [stdout] 1266 | const TEST: &'static str = "हत्यारा मकसहूद भाई तुम बड़ा मस्त काम करती।"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/banned.rs:19:57 [INFO] [stdout] | [INFO] [stdout] 19 | ['\u{A9C1}', '\u{A9C2}'].as_slice().into_iter().copied() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/banned.rs:21:35 [INFO] [stdout] | [INFO] [stdout] 21 | [].as_slice().into_iter().copied() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/censor.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | buffer: BufferProxyIterator, fn(&char) -> bool>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/censor.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | / pub fn from_str(s: &'a str) -> Self { [INFO] [stdout] 144 | | Self::new(s.chars()) [INFO] [stdout] 145 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/censor.rs:161:10 [INFO] [stdout] | [INFO] [stdout] 161 | ) -> BufferProxyIterator, fn(&char) -> bool>>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/censor.rs:289:13 [INFO] [stdout] | [INFO] [stdout] 289 | !self.buffer.index().is_some(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.buffer.index().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/censor.rs:506:28 [INFO] [stdout] | [INFO] [stdout] 506 | .unwrap_or(&&*raw_c.encode_utf8(&mut [0; 4])) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(&*raw_c.encode_utf8(&mut [0; 4]))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `is_*` usually take `self` by mutable reference or `self` by reference or no `self` [INFO] [stdout] --> src/censor.rs:805:25 [INFO] [stdout] | [INFO] [stdout] 805 | fn is_inappropriate(self) -> bool { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/censor.rs:1200:13 [INFO] [stdout] | [INFO] [stdout] 1200 | link.split('/').last().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1200 - link.split('/').last().unwrap(), [INFO] [stdout] 1200 + link.split('/').next_back().unwrap(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.51s [INFO] running `Command { std: "docker" "inspect" "edc8cc1365659105f5e92e4061cf2fe9e4201c54a8009826b5e04adfbd568176", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "edc8cc1365659105f5e92e4061cf2fe9e4201c54a8009826b5e04adfbd568176", kill_on_drop: false }` [INFO] [stdout] edc8cc1365659105f5e92e4061cf2fe9e4201c54a8009826b5e04adfbd568176