[INFO] fetching crate rustque 1.1.1... [INFO] linting rustque-1.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rustque 1.1.1 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate rustque 1.1.1 [INFO] finished tweaking crates.io crate rustque 1.1.1 [INFO] tweaked toml for crates.io crate rustque 1.1.1 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rustque 1.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 57 packages to latest compatible versions [INFO] [stderr] Adding flume v0.10.14 (available: v0.12.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded gzb_binary_69 v0.2.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ecf91432347ee92416b51f3434263c0b7ab969e316557b72efce1479840a469c [INFO] running `Command { std: "docker" "start" "-a" "ecf91432347ee92416b51f3434263c0b7ab969e316557b72efce1479840a469c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ecf91432347ee92416b51f3434263c0b7ab969e316557b72efce1479840a469c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ecf91432347ee92416b51f3434263c0b7ab969e316557b72efce1479840a469c", kill_on_drop: false }` [INFO] [stdout] ecf91432347ee92416b51f3434263c0b7ab969e316557b72efce1479840a469c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 28f23afc0fa0590f6c0df44a95aa5ed50bebd426665312c4f7ba27ac84ab6155 [INFO] running `Command { std: "docker" "start" "-a" "28f23afc0fa0590f6c0df44a95aa5ed50bebd426665312c4f7ba27ac84ab6155", kill_on_drop: false }` [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Checking gzb_binary_69 v0.2.2 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking crossbeam-queue v0.3.12 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling pin-project-internal v1.1.11 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking pin-project v1.1.11 [INFO] [stderr] Checking flume v0.10.14 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking rustque v1.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | files:files, [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `files` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | min_que_size:min_que_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_que_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | expand_size:expand_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expand_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | files:files, [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `files` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | num_of_writers:num_of_writers [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_of_writers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | receiver:receiver, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | frame_size:frame_size [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | min_que_size:min_que_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_que_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:180:17 [INFO] [stdout] | [INFO] [stdout] 180 | map_index:map_index, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `map_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:181:17 [INFO] [stdout] | [INFO] [stdout] 181 | file_path:file_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:184:17 [INFO] [stdout] | [INFO] [stdout] 184 | reader:reader, [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | expand_size:expand_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expand_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:185:17 [INFO] [stdout] | [INFO] [stdout] 185 | receiver:receiver, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:186:17 [INFO] [stdout] | [INFO] [stdout] 186 | locator_sender:locator_sender, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `locator_sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | num_of_writers:num_of_writers [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_of_writers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:188:17 [INFO] [stdout] | [INFO] [stdout] 188 | num_of_writers:num_of_writers, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_of_writers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:189:17 [INFO] [stdout] | [INFO] [stdout] 189 | min_que_size:min_que_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_que_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:190:17 [INFO] [stdout] | [INFO] [stdout] 190 | expand_size:expand_size [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expand_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/que.rs:97:17 [INFO] [stdout] | [INFO] [stdout] 97 | value:value, [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/que.rs:132:17 [INFO] [stdout] | [INFO] [stdout] 132 | pointer:pointer, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `pointer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | receiver:receiver, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/que.rs:150:17 [INFO] [stdout] | [INFO] [stdout] 150 | pointer:pointer, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `pointer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | frame_size:frame_size [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:180:17 [INFO] [stdout] | [INFO] [stdout] 180 | map_index:map_index, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `map_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:181:17 [INFO] [stdout] | [INFO] [stdout] 181 | file_path:file_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:184:17 [INFO] [stdout] | [INFO] [stdout] 184 | reader:reader, [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:185:17 [INFO] [stdout] | [INFO] [stdout] 185 | receiver:receiver, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `receiver` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:186:17 [INFO] [stdout] | [INFO] [stdout] 186 | locator_sender:locator_sender, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `locator_sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:188:17 [INFO] [stdout] | [INFO] [stdout] 188 | num_of_writers:num_of_writers, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_of_writers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:189:17 [INFO] [stdout] | [INFO] [stdout] 189 | min_que_size:min_que_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_que_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/config.rs:190:17 [INFO] [stdout] | [INFO] [stdout] 190 | expand_size:expand_size [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expand_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/map.rs:179:13 [INFO] [stdout] | [INFO] [stdout] 179 | boundry:boundry, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `boundry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/map.rs:214:13 [INFO] [stdout] | [INFO] [stdout] 214 | value_boundry:value_boundry, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_boundry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/que.rs:97:17 [INFO] [stdout] | [INFO] [stdout] 97 | value:value, [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/que.rs:132:17 [INFO] [stdout] | [INFO] [stdout] 132 | pointer:pointer, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `pointer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/que.rs:150:17 [INFO] [stdout] | [INFO] [stdout] 150 | pointer:pointer, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `pointer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/response.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | signal:signal, [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `signal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/response.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | sleeper:sleeper [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `sleeper` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/map.rs:179:13 [INFO] [stdout] | [INFO] [stdout] 179 | boundry:boundry, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `boundry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/map.rs:214:13 [INFO] [stdout] | [INFO] [stdout] 214 | value_boundry:value_boundry, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_boundry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/response.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | signal:signal, [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `signal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/response.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | sleeper:sleeper [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `sleeper` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `locator_sender` is never read [INFO] [stdout] --> src/config.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 145 | pub struct MapConfig{ [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 153 | pub locator_sender:FlumeSender, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/io.rs:18:8 [INFO] [stdout] | [INFO] [stdout] 18 | if !build.exists() || false{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 18 - if !build.exists() || false{ [INFO] [stdout] 18 + if !build.exists(){ [INFO] [stdout] | [INFO] [stdout] 18 - if !build.exists() || false{ [INFO] [stdout] 18 + if !build.exists(){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | return Ok((file,metadata)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - return Ok((file,metadata)); [INFO] [stdout] 106 + Ok((file,metadata)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 110 | return Err("failed-get-metadata"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 - return Err("failed-get-metadata"); [INFO] [stdout] 110 + Err("failed-get-metadata") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/io.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | let metadata:Metadata; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `metadata` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 76 ~ [INFO] [stdout] 77 ~ let metadata:Metadata = match file.metadata().await{ [INFO] [stdout] 78 | Ok(v)=>{ [INFO] [stdout] 79 | // return Ok((file,v)); [INFO] [stdout] 80 ~ v [INFO] [stdout] 81 | }, [INFO] [stdout] ... [INFO] [stdout] 85 | } [INFO] [stdout] 86 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:186:13 [INFO] [stdout] | [INFO] [stdout] 186 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 186 - return Ok(()); [INFO] [stdout] 186 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 189 | return Err("failed-write_to_file"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 - return Err("failed-write_to_file"); [INFO] [stdout] 189 + Err("failed-write_to_file") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/io.rs:129:20 [INFO] [stdout] | [INFO] [stdout] 129 | let mut size = size_og.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*size_og` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/io.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 158 | build.push(0); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![0;SIZE]` [INFO] [stdout] = help: or `build.extend(std::iter::repeat_n(0, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/io.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 179 | build.push(0); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![0;SIZE]` [INFO] [stdout] = help: or `build.extend(std::iter::repeat_n(0, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/io.rs:178:17 [INFO] [stdout] | [INFO] [stdout] 178 | for _ in 0..size.clone(){ [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:213:13 [INFO] [stdout] | [INFO] [stdout] 213 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 213 - return Ok(()); [INFO] [stdout] 213 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:216:13 [INFO] [stdout] | [INFO] [stdout] 216 | return Err("failed-build_frame-create_file"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 216 - return Err("failed-build_frame-create_file"); [INFO] [stdout] 216 + Err("failed-build_frame-create_file") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/io.rs:206:50 [INFO] [stdout] | [INFO] [stdout] 206 | let mut collect:Vec = Vec::with_capacity(len as usize); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/io.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | collect.push(0); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![0;SIZE]` [INFO] [stdout] = help: or `collect.extend(std::iter::repeat_n(0, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 237 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 237 - return Ok(()); [INFO] [stdout] 237 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:241:13 [INFO] [stdout] | [INFO] [stdout] 241 | return Err("failed-read_chunk"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 241 - return Err("failed-read_chunk"); [INFO] [stdout] 241 + Err("failed-read_chunk") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:259:13 [INFO] [stdout] | [INFO] [stdout] 259 | return Ok(v); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 259 - return Ok(v); [INFO] [stdout] 259 + Ok(v) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:263:13 [INFO] [stdout] | [INFO] [stdout] 263 | return Err("failed-read_chunk"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 - return Err("failed-read_chunk"); [INFO] [stdout] 263 + Err("failed-read_chunk") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:301:13 [INFO] [stdout] | [INFO] [stdout] 301 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 300 - // debug_error("failed-read_file",ERROR); [INFO] [stdout] 301 - return; [INFO] [stdout] 300 + // debug_error("failed-read_file",ERROR); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:328:13 [INFO] [stdout] | [INFO] [stdout] 328 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 328 - return Ok(()); [INFO] [stdout] 328 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:331:13 [INFO] [stdout] | [INFO] [stdout] 331 | return Err("failed-read_chunk"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 331 - return Err("failed-read_chunk"); [INFO] [stdout] 331 + Err("failed-read_chunk") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | / return DiskConfig{ [INFO] [stdout] 78 | | receiver:receiver, [INFO] [stdout] 79 | | path:p, [INFO] [stdout] 80 | | frame_size:frame_size [INFO] [stdout] 81 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 ~ DiskConfig{ [INFO] [stdout] 78 + receiver:receiver, [INFO] [stdout] 79 + path:p, [INFO] [stdout] 80 + frame_size:frame_size [INFO] [stdout] 81 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | / return ( [INFO] [stdout] 179 | | MapConfig{ [INFO] [stdout] 180 | | map_index:map_index, [INFO] [stdout] 181 | | file_path:file_path, [INFO] [stdout] ... | [INFO] [stdout] 193 | | sender [INFO] [stdout] 194 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 178 ~ ( [INFO] [stdout] 179 + MapConfig{ [INFO] [stdout] 180 + map_index:map_index, [INFO] [stdout] 181 + file_path:file_path, [INFO] [stdout] 182 + // disk_senders:HashMap::new(), [INFO] [stdout] 183 + // locator_sender:locator_sender, [INFO] [stdout] 184 + reader:reader, [INFO] [stdout] 185 + receiver:receiver, [INFO] [stdout] 186 + locator_sender:locator_sender, [INFO] [stdout] 187 + // items:items, [INFO] [stdout] 188 + num_of_writers:num_of_writers, [INFO] [stdout] 189 + min_que_size:min_que_size, [INFO] [stdout] 190 + expand_size:expand_size [INFO] [stdout] 191 + // items_in_processing:Vec::new() [INFO] [stdout] 192 + }, [INFO] [stdout] 193 + sender [INFO] [stdout] 194 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | / return Ok(Que{ [INFO] [stdout] 88 | | locator_sender:Arc::new(locator_sender) [INFO] [stdout] 89 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 ~ Ok(Que{ [INFO] [stdout] 88 + locator_sender:Arc::new(locator_sender) [INFO] [stdout] 89 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/que.rs:53:17 [INFO] [stdout] | [INFO] [stdout] 53 | c.num_of_writers.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `c.num_of_writers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/que.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | c.min_que_size.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `c.min_que_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/que.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | c.expand_size.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `c.expand_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/que.rs:64:40 [INFO] [stdout] | [INFO] [stdout] 64 | locator.insert(item.clone(),index); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:102:17 [INFO] [stdout] | [INFO] [stdout] 102 | return Ok(QueResponse::new(signal,sleeper)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return Ok(QueResponse::new(signal,sleeper)); [INFO] [stdout] 102 + Ok(QueResponse::new(signal,sleeper)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | return Err(()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return Err(()); [INFO] [stdout] 105 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 119 | return Ok(QueResponse::new(signal,sleeper)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 119 - return Ok(QueResponse::new(signal,sleeper)); [INFO] [stdout] 119 + Ok(QueResponse::new(signal,sleeper)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:122:17 [INFO] [stdout] | [INFO] [stdout] 122 | return Err(()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return Err(()); [INFO] [stdout] 122 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | return Ok(QueResponse::new(signal,sleeper)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - return Ok(QueResponse::new(signal,sleeper)); [INFO] [stdout] 137 + Ok(QueResponse::new(signal,sleeper)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | return Err(()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 - return Err(()); [INFO] [stdout] 140 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:155:17 [INFO] [stdout] | [INFO] [stdout] 155 | return Ok(QueResponse::new(signal,sleeper)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 155 - return Ok(QueResponse::new(signal,sleeper)); [INFO] [stdout] 155 + Ok(QueResponse::new(signal,sleeper)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 158 | return Err(()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 158 - return Err(()); [INFO] [stdout] 158 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:222:5 [INFO] [stdout] | [INFO] [stdout] 222 | return Ok((index,items,map_sender)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 222 - return Ok((index,items,map_sender)); [INFO] [stdout] 222 + Ok((index,items,map_sender)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `locator_sender` is never read [INFO] [stdout] --> src/config.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 145 | pub struct MapConfig{ [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 153 | pub locator_sender:FlumeSender, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/que.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | index.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:296:5 [INFO] [stdout] | [INFO] [stdout] 296 | return Ok((reader,collect)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 296 - return Ok((reader,collect)); [INFO] [stdout] 296 + Ok((reader,collect)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/que.rs:260:9 [INFO] [stdout] | [INFO] [stdout] 260 | let read_len:u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `read_len` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 260 ~ [INFO] [stdout] 261 ~ let read_len:u64 = if len < chunk_size{len} else {chunk_size}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/io.rs:18:8 [INFO] [stdout] | [INFO] [stdout] 18 | if !build.exists() || false{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 18 - if !build.exists() || false{ [INFO] [stdout] 18 + if !build.exists(){ [INFO] [stdout] | [INFO] [stdout] 18 - if !build.exists() || false{ [INFO] [stdout] 18 + if !build.exists(){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | return Ok((file,metadata)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - return Ok((file,metadata)); [INFO] [stdout] 106 + Ok((file,metadata)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 110 | return Err("failed-get-metadata"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 - return Err("failed-get-metadata"); [INFO] [stdout] 110 + Err("failed-get-metadata") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/que.rs:280:5 [INFO] [stdout] | [INFO] [stdout] 280 | / match reader.end(){ [INFO] [stdout] 281 | | Ok(_)=>{}, [INFO] [stdout] 282 | | Err(_)=>{} [INFO] [stdout] 283 | | } [INFO] [stdout] | |_____^ help: try: `if let Ok(_) = reader.end() {}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/que.rs:287:9 [INFO] [stdout] | [INFO] [stdout] 287 | / match u64_from_bytes(&key){ [INFO] [stdout] 288 | | Ok(num)=>{ [INFO] [stdout] 289 | | collect.push(num); [INFO] [stdout] 290 | | }, [INFO] [stdout] 291 | | Err(_)=>{} [INFO] [stdout] 292 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 287 ~ if let Ok(num) = u64_from_bytes(&key) { [INFO] [stdout] 288 + collect.push(num); [INFO] [stdout] 289 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/que.rs:287:30 [INFO] [stdout] | [INFO] [stdout] 287 | match u64_from_bytes(&key){ [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/io.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | let metadata:Metadata; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `metadata` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 76 ~ [INFO] [stdout] 77 ~ let metadata:Metadata = match file.metadata().await{ [INFO] [stdout] 78 | Ok(v)=>{ [INFO] [stdout] 79 | // return Ok((file,v)); [INFO] [stdout] 80 ~ v [INFO] [stdout] 81 | }, [INFO] [stdout] ... [INFO] [stdout] 85 | } [INFO] [stdout] 86 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/map.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | config.min_que_size.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.min_que_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/map.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | let message:MapMessage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `message` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 40 ~ [INFO] [stdout] 41 ~ let message:MapMessage = match config.receiver.recv_async().await{ [INFO] [stdout] 42 | Ok(m)=>{ [INFO] [stdout] 43 ~ m [INFO] [stdout] 44 | }, [INFO] [stdout] ... [INFO] [stdout] 47 | } [INFO] [stdout] 48 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:186:13 [INFO] [stdout] | [INFO] [stdout] 186 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 186 - return Ok(()); [INFO] [stdout] 186 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:189:13 [INFO] [stdout] | [INFO] [stdout] 189 | return Err("failed-write_to_file"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 - return Err("failed-write_to_file"); [INFO] [stdout] 189 + Err("failed-write_to_file") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/io.rs:129:20 [INFO] [stdout] | [INFO] [stdout] 129 | let mut size = size_og.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*size_og` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/map.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | let build_message_body:Vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `build_message_body` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 73 ~ [INFO] [stdout] 74 ~ let build_message_body:Vec = match BinaryWriter( [INFO] [stdout] 75 | message.index.to_be_bytes().to_vec(), [INFO] [stdout] ... [INFO] [stdout] 78 | Ok(v)=>{ [INFO] [stdout] 79 ~ v [INFO] [stdout] 80 | }, [INFO] [stdout] ... [INFO] [stdout] 85 | } [INFO] [stdout] 86 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/map.rs:90:71 [INFO] [stdout] | [INFO] [stdout] 90 | match config.reader.fill(message.index.to_be_bytes().to_vec(),value_len.clone()){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `value_len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/io.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 158 | build.push(0); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![0;SIZE]` [INFO] [stdout] = help: or `build.extend(std::iter::repeat_n(0, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/io.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 179 | build.push(0); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![0;SIZE]` [INFO] [stdout] = help: or `build.extend(std::iter::repeat_n(0, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/io.rs:178:17 [INFO] [stdout] | [INFO] [stdout] 178 | for _ in 0..size.clone(){ [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/map.rs:113:48 [INFO] [stdout] | [INFO] [stdout] 113 | match config.reader.expand(config.expand_size.clone() as usize){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.expand_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:213:13 [INFO] [stdout] | [INFO] [stdout] 213 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 213 - return Ok(()); [INFO] [stdout] 213 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:216:13 [INFO] [stdout] | [INFO] [stdout] 216 | return Err("failed-build_frame-create_file"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 216 - return Err("failed-build_frame-create_file"); [INFO] [stdout] 216 + Err("failed-build_frame-create_file") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/io.rs:206:50 [INFO] [stdout] | [INFO] [stdout] 206 | let mut collect:Vec = Vec::with_capacity(len as usize); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/map.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 157 | let boundry:(usize,usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `boundry` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 157 ~ [INFO] [stdout] 158 | let key = message.pointer.item_index.to_be_bytes().to_vec(); [INFO] [stdout] 159 ~ let boundry:(usize,usize) = match config.reader.pointers.get(&key){ [INFO] [stdout] 160 | Some(pointer)=>{ [INFO] [stdout] 161 ~ pointer.0 [INFO] [stdout] 162 | }, [INFO] [stdout] ... [INFO] [stdout] 166 | } [INFO] [stdout] 167 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/io.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | collect.push(0); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![0;SIZE]` [INFO] [stdout] = help: or `collect.extend(std::iter::repeat_n(0, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 237 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 237 - return Ok(()); [INFO] [stdout] 237 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:241:13 [INFO] [stdout] | [INFO] [stdout] 241 | return Err("failed-read_chunk"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 241 - return Err("failed-read_chunk"); [INFO] [stdout] 241 + Err("failed-read_chunk") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:259:13 [INFO] [stdout] | [INFO] [stdout] 259 | return Ok(v); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 259 - return Ok(v); [INFO] [stdout] 259 + Ok(v) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:263:13 [INFO] [stdout] | [INFO] [stdout] 263 | return Err("failed-read_chunk"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 - return Err("failed-read_chunk"); [INFO] [stdout] 263 + Err("failed-read_chunk") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 221 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 220 - Signal::error(message.signal).await; [INFO] [stdout] 221 - return; [INFO] [stdout] 220 + Signal::error(message.signal).await; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:301:13 [INFO] [stdout] | [INFO] [stdout] 301 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 300 - // debug_error("failed-read_file",ERROR); [INFO] [stdout] 301 - return; [INFO] [stdout] 300 + // debug_error("failed-read_file",ERROR); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/map.rs:197:5 [INFO] [stdout] | [INFO] [stdout] 197 | let value_boundry:(usize,usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `value_boundry` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 197 ~ [INFO] [stdout] 198 ~ let value_boundry:(usize,usize) = match config.reader.pointers.get( [INFO] [stdout] 199 | &message.index.to_be_bytes().to_vec() [INFO] [stdout] 200 | ){ [INFO] [stdout] 201 | Some(pointer)=>{ [INFO] [stdout] 202 ~ pointer.1 [INFO] [stdout] 203 | }, [INFO] [stdout] ... [INFO] [stdout] 207 | } [INFO] [stdout] 208 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/map.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | &message.index.to_be_bytes().to_vec() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message.index.to_be_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/map.rs:213:23 [INFO] [stdout] | [INFO] [stdout] 213 | map_index:config.map_index.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.map_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:328:13 [INFO] [stdout] | [INFO] [stdout] 328 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 328 - return Ok(()); [INFO] [stdout] 328 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/io.rs:331:13 [INFO] [stdout] | [INFO] [stdout] 331 | return Err("failed-read_chunk"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 331 - return Err("failed-read_chunk"); [INFO] [stdout] 331 + Err("failed-read_chunk") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/disk.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | let message:DiskMessage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `message` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 36 ~ [INFO] [stdout] 37 ~ let message:DiskMessage = match config.receiver.recv_async().await{ [INFO] [stdout] 38 | Ok(m)=>{ [INFO] [stdout] 39 ~ m [INFO] [stdout] 40 | }, [INFO] [stdout] ... [INFO] [stdout] 44 | } [INFO] [stdout] 45 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | / return DiskConfig{ [INFO] [stdout] 78 | | receiver:receiver, [INFO] [stdout] 79 | | path:p, [INFO] [stdout] 80 | | frame_size:frame_size [INFO] [stdout] 81 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 ~ DiskConfig{ [INFO] [stdout] 78 + receiver:receiver, [INFO] [stdout] 79 + path:p, [INFO] [stdout] 80 + frame_size:frame_size [INFO] [stdout] 81 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config.rs:178:9 [INFO] [stdout] | [INFO] [stdout] 178 | / return ( [INFO] [stdout] 179 | | MapConfig{ [INFO] [stdout] 180 | | map_index:map_index, [INFO] [stdout] 181 | | file_path:file_path, [INFO] [stdout] ... | [INFO] [stdout] 193 | | sender [INFO] [stdout] 194 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 178 ~ ( [INFO] [stdout] 179 + MapConfig{ [INFO] [stdout] 180 + map_index:map_index, [INFO] [stdout] 181 + file_path:file_path, [INFO] [stdout] 182 + // disk_senders:HashMap::new(), [INFO] [stdout] 183 + // locator_sender:locator_sender, [INFO] [stdout] 184 + reader:reader, [INFO] [stdout] 185 + receiver:receiver, [INFO] [stdout] 186 + locator_sender:locator_sender, [INFO] [stdout] 187 + // items:items, [INFO] [stdout] 188 + num_of_writers:num_of_writers, [INFO] [stdout] 189 + min_que_size:min_que_size, [INFO] [stdout] 190 + expand_size:expand_size [INFO] [stdout] 191 + // items_in_processing:Vec::new() [INFO] [stdout] 192 + }, [INFO] [stdout] 193 + sender [INFO] [stdout] 194 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | / return Ok(Que{ [INFO] [stdout] 88 | | locator_sender:Arc::new(locator_sender) [INFO] [stdout] 89 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 ~ Ok(Que{ [INFO] [stdout] 88 + locator_sender:Arc::new(locator_sender) [INFO] [stdout] 89 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/que.rs:53:17 [INFO] [stdout] | [INFO] [stdout] 53 | c.num_of_writers.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `c.num_of_writers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/que.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | c.min_que_size.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `c.min_que_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/que.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | c.expand_size.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `c.expand_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/que.rs:64:40 [INFO] [stdout] | [INFO] [stdout] 64 | locator.insert(item.clone(),index); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/workers.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | Ok(v)=>{return Ok(v)}, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - Ok(v)=>{return Ok(v)}, [INFO] [stdout] 26 + Ok(v)=>{Ok(v)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/workers.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | return Err(()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return Err(()); [INFO] [stdout] 29 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/workers.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | return Ok(value_len_as_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Ok(value_len_as_bytes); [INFO] [stdout] 40 + Ok(value_len_as_bytes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:102:17 [INFO] [stdout] | [INFO] [stdout] 102 | return Ok(QueResponse::new(signal,sleeper)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return Ok(QueResponse::new(signal,sleeper)); [INFO] [stdout] 102 + Ok(QueResponse::new(signal,sleeper)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/workers.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | return Err(()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return Err(()); [INFO] [stdout] 43 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | return Err(()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return Err(()); [INFO] [stdout] 105 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 119 | return Ok(QueResponse::new(signal,sleeper)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 119 - return Ok(QueResponse::new(signal,sleeper)); [INFO] [stdout] 119 + Ok(QueResponse::new(signal,sleeper)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:122:17 [INFO] [stdout] | [INFO] [stdout] 122 | return Err(()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return Err(()); [INFO] [stdout] 122 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:137:17 [INFO] [stdout] | [INFO] [stdout] 137 | return Ok(QueResponse::new(signal,sleeper)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - return Ok(QueResponse::new(signal,sleeper)); [INFO] [stdout] 137 + Ok(QueResponse::new(signal,sleeper)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | return Err(()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 - return Err(()); [INFO] [stdout] 140 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:155:17 [INFO] [stdout] | [INFO] [stdout] 155 | return Ok(QueResponse::new(signal,sleeper)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 155 - return Ok(QueResponse::new(signal,sleeper)); [INFO] [stdout] 155 + Ok(QueResponse::new(signal,sleeper)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 158 | return Err(()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 158 - return Err(()); [INFO] [stdout] 158 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:222:5 [INFO] [stdout] | [INFO] [stdout] 222 | return Ok((index,items,map_sender)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 222 - return Ok((index,items,map_sender)); [INFO] [stdout] 222 + Ok((index,items,map_sender)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/workers.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | return lock.result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return lock.result; [INFO] [stdout] 99 + lock.result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/workers.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | return Ok(hold.data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return Ok(hold.data); [INFO] [stdout] 105 + Ok(hold.data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/workers.rs:109:17 [INFO] [stdout] | [INFO] [stdout] 109 | return Ok(lock.data.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 109 - return Ok(lock.data.clone()); [INFO] [stdout] 109 + Ok(lock.data.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/que.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | index.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/que.rs:296:5 [INFO] [stdout] | [INFO] [stdout] 296 | return Ok((reader,collect)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 296 - return Ok((reader,collect)); [INFO] [stdout] 296 + Ok((reader,collect)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/locator.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | if items.len() > 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!items.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/locator.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 31 | biggest = items[items.len()-1].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `items[items.len()-1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/que.rs:260:9 [INFO] [stdout] | [INFO] [stdout] 260 | let read_len:u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `read_len` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 260 ~ [INFO] [stdout] 261 ~ let read_len:u64 = if len < chunk_size{len} else {chunk_size}; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/locator.rs:40:28 [INFO] [stdout] | [INFO] [stdout] 40 | if items.len() ==0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/que.rs:280:5 [INFO] [stdout] | [INFO] [stdout] 280 | / match reader.end(){ [INFO] [stdout] 281 | | Ok(_)=>{}, [INFO] [stdout] 282 | | Err(_)=>{} [INFO] [stdout] 283 | | } [INFO] [stdout] | |_____^ help: try: `if let Ok(_) = reader.end() {}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/que.rs:287:9 [INFO] [stdout] | [INFO] [stdout] 287 | / match u64_from_bytes(&key){ [INFO] [stdout] 288 | | Ok(num)=>{ [INFO] [stdout] 289 | | collect.push(num); [INFO] [stdout] 290 | | }, [INFO] [stdout] 291 | | Err(_)=>{} [INFO] [stdout] 292 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 287 ~ if let Ok(num) = u64_from_bytes(&key) { [INFO] [stdout] 288 + collect.push(num); [INFO] [stdout] 289 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/que.rs:287:30 [INFO] [stdout] | [INFO] [stdout] 287 | match u64_from_bytes(&key){ [INFO] [stdout] | ^^^^ help: change this to: `key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/map.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | config.min_que_size.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.min_que_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/locator.rs:72:28 [INFO] [stdout] | [INFO] [stdout] 72 | if items.len() == 0 && processing == 0{biggest = 1;} else {biggest += 1;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/locator.rs:74:40 [INFO] [stdout] | [INFO] [stdout] 74 | locator.insert(biggest.clone(),last_map_added.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `biggest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/locator.rs:74:56 [INFO] [stdout] | [INFO] [stdout] 74 | locator.insert(biggest.clone(),last_map_added.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `last_map_added` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/map.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | let message:MapMessage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `message` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 40 ~ [INFO] [stdout] 41 ~ let message:MapMessage = match config.receiver.recv_async().await{ [INFO] [stdout] 42 | Ok(m)=>{ [INFO] [stdout] 43 ~ m [INFO] [stdout] 44 | }, [INFO] [stdout] ... [INFO] [stdout] 47 | } [INFO] [stdout] 48 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/map.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | let build_message_body:Vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `build_message_body` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 73 ~ [INFO] [stdout] 74 ~ let build_message_body:Vec = match BinaryWriter( [INFO] [stdout] 75 | message.index.to_be_bytes().to_vec(), [INFO] [stdout] ... [INFO] [stdout] 78 | Ok(v)=>{ [INFO] [stdout] 79 ~ v [INFO] [stdout] 80 | }, [INFO] [stdout] ... [INFO] [stdout] 85 | } [INFO] [stdout] 86 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/locator.rs:119:36 [INFO] [stdout] | [INFO] [stdout] 119 | items.push(message.pointer.item_index.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `message.pointer.item_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/locator.rs:121:29 [INFO] [stdout] | [INFO] [stdout] 121 | ... message.pointer.item_index.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `message.pointer.item_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/locator.rs:122:29 [INFO] [stdout] | [INFO] [stdout] 122 | ... message.pointer.map_index.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `message.pointer.map_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/map.rs:90:71 [INFO] [stdout] | [INFO] [stdout] 90 | match config.reader.fill(message.index.to_be_bytes().to_vec(),value_len.clone()){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `value_len` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/map.rs:113:48 [INFO] [stdout] | [INFO] [stdout] 113 | match config.reader.expand(config.expand_size.clone() as usize){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.expand_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return false; [INFO] [stdout] 22 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return true; [INFO] [stdout] 24 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/response.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / if !Signal::check(&self.signal).await{ [INFO] [stdout] 22 | | return false; [INFO] [stdout] 23 | | } else { [INFO] [stdout] 24 | | return true; [INFO] [stdout] 25 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `return !!Signal::check(&self.signal).await` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return None; [INFO] [stdout] 38 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/map.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 157 | let boundry:(usize,usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `boundry` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 157 ~ [INFO] [stdout] 158 | let key = message.pointer.item_index.to_be_bytes().to_vec(); [INFO] [stdout] 159 ~ let boundry:(usize,usize) = match config.reader.pointers.get(&key){ [INFO] [stdout] 160 | Some(pointer)=>{ [INFO] [stdout] 161 ~ pointer.0 [INFO] [stdout] 162 | }, [INFO] [stdout] ... [INFO] [stdout] 166 | } [INFO] [stdout] 167 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/map.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 221 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 220 - Signal::error(message.signal).await; [INFO] [stdout] 221 - return; [INFO] [stdout] 220 + Signal::error(message.signal).await; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/map.rs:197:5 [INFO] [stdout] | [INFO] [stdout] 197 | let value_boundry:(usize,usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `value_boundry` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 197 ~ [INFO] [stdout] 198 ~ let value_boundry:(usize,usize) = match config.reader.pointers.get( [INFO] [stdout] 199 | &message.index.to_be_bytes().to_vec() [INFO] [stdout] 200 | ){ [INFO] [stdout] 201 | Some(pointer)=>{ [INFO] [stdout] 202 ~ pointer.1 [INFO] [stdout] 203 | }, [INFO] [stdout] ... [INFO] [stdout] 207 | } [INFO] [stdout] 208 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_vec` [INFO] [stdout] --> src/map.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | &message.index.to_be_bytes().to_vec() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message.index.to_be_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/map.rs:213:23 [INFO] [stdout] | [INFO] [stdout] 213 | map_index:config.map_index.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `config.map_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/disk.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | let message:DiskMessage; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `message` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 36 ~ [INFO] [stdout] 37 ~ let message:DiskMessage = match config.receiver.recv_async().await{ [INFO] [stdout] 38 | Ok(m)=>{ [INFO] [stdout] 39 ~ m [INFO] [stdout] 40 | }, [INFO] [stdout] ... [INFO] [stdout] 44 | } [INFO] [stdout] 45 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/workers.rs:26:17 [INFO] [stdout] | [INFO] [stdout] 26 | Ok(v)=>{return Ok(v)}, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - Ok(v)=>{return Ok(v)}, [INFO] [stdout] 26 + Ok(v)=>{Ok(v)}, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/workers.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | return Err(()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return Err(()); [INFO] [stdout] 29 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/workers.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | return Ok(value_len_as_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Ok(value_len_as_bytes); [INFO] [stdout] 40 + Ok(value_len_as_bytes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/workers.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | return Err(()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return Err(()); [INFO] [stdout] 43 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/workers.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | return lock.result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return lock.result; [INFO] [stdout] 99 + lock.result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/workers.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | return Ok(hold.data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return Ok(hold.data); [INFO] [stdout] 105 + Ok(hold.data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/workers.rs:109:17 [INFO] [stdout] | [INFO] [stdout] 109 | return Ok(lock.data.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 109 - return Ok(lock.data.clone()); [INFO] [stdout] 109 + Ok(lock.data.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/locator.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | if items.len() > 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!items.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/locator.rs:31:19 [INFO] [stdout] | [INFO] [stdout] 31 | biggest = items[items.len()-1].clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `items[items.len()-1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/locator.rs:40:28 [INFO] [stdout] | [INFO] [stdout] 40 | if items.len() ==0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/locator.rs:72:28 [INFO] [stdout] | [INFO] [stdout] 72 | if items.len() == 0 && processing == 0{biggest = 1;} else {biggest += 1;} [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/locator.rs:74:40 [INFO] [stdout] | [INFO] [stdout] 74 | locator.insert(biggest.clone(),last_map_added.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `biggest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/locator.rs:74:56 [INFO] [stdout] | [INFO] [stdout] 74 | locator.insert(biggest.clone(),last_map_added.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `last_map_added` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/locator.rs:119:36 [INFO] [stdout] | [INFO] [stdout] 119 | items.push(message.pointer.item_index.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `message.pointer.item_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/locator.rs:121:29 [INFO] [stdout] | [INFO] [stdout] 121 | ... message.pointer.item_index.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `message.pointer.item_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/locator.rs:122:29 [INFO] [stdout] | [INFO] [stdout] 122 | ... message.pointer.map_index.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `message.pointer.map_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return false; [INFO] [stdout] 22 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return true; [INFO] [stdout] 24 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/response.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / if !Signal::check(&self.signal).await{ [INFO] [stdout] 22 | | return false; [INFO] [stdout] 23 | | } else { [INFO] [stdout] 24 | | return true; [INFO] [stdout] 25 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `return !!Signal::check(&self.signal).await` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return None; [INFO] [stdout] 38 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.04s [INFO] running `Command { std: "docker" "inspect" "28f23afc0fa0590f6c0df44a95aa5ed50bebd426665312c4f7ba27ac84ab6155", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28f23afc0fa0590f6c0df44a95aa5ed50bebd426665312c4f7ba27ac84ab6155", kill_on_drop: false }` [INFO] [stdout] 28f23afc0fa0590f6c0df44a95aa5ed50bebd426665312c4f7ba27ac84ab6155