[INFO] fetching crate rustolio-web 0.1.0... [INFO] linting rustolio-web-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rustolio-web 0.1.0 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate rustolio-web 0.1.0 [INFO] finished tweaking crates.io crate rustolio-web 0.1.0 [INFO] tweaked toml for crates.io crate rustolio-web 0.1.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rustolio-web 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate rustolio-web 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde-wasm-bindgen v0.6.5 [INFO] [stderr] Downloaded typed-builder v0.23.2 [INFO] [stderr] Downloaded typed-builder-macro v0.23.2 [INFO] [stderr] Downloaded wasm-tracing v2.1.0 [INFO] [stderr] Downloaded rustolio-web-core-macros v0.1.0 [INFO] [stderr] Downloaded rustolio-build-utils v0.1.0 [INFO] [stderr] Downloaded rustolio-utils-macros v0.1.0 [INFO] [stderr] Downloaded ml-kem v0.2.1 [INFO] [stderr] Downloaded matchit v0.8.6 [INFO] [stderr] Downloaded hybrid-array v0.2.3 [INFO] [stderr] Downloaded rustolio-utils v0.1.0 [INFO] [stderr] Downloaded kem v0.3.0-pre.0 [INFO] [stderr] Downloaded time v0.3.46 [INFO] [stderr] Downloaded rustolio-web-router-macro v0.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3baece0788cf5795b2d92e1832e454ea1b17124e9b5ea77aeddd2e3d01b3ddb9 [INFO] running `Command { std: "docker" "start" "-a" "3baece0788cf5795b2d92e1832e454ea1b17124e9b5ea77aeddd2e3d01b3ddb9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3baece0788cf5795b2d92e1832e454ea1b17124e9b5ea77aeddd2e3d01b3ddb9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3baece0788cf5795b2d92e1832e454ea1b17124e9b5ea77aeddd2e3d01b3ddb9", kill_on_drop: false }` [INFO] [stdout] 3baece0788cf5795b2d92e1832e454ea1b17124e9b5ea77aeddd2e3d01b3ddb9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d26555db9df689a35f3a6e67c95cc15faed63eeaca76be2145426b3bc77de888 [INFO] running `Command { std: "docker" "start" "-a" "d26555db9df689a35f3a6e67c95cc15faed63eeaca76be2145426b3bc77de888", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Compiling zeroize v1.8.2 [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Compiling subtle v2.6.1 [INFO] [stderr] Compiling log v0.4.27 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.100 [INFO] [stderr] Compiling bumpalo v3.19.0 [INFO] [stderr] Compiling const-oid v0.9.6 [INFO] [stderr] Compiling wasm-bindgen v0.2.100 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling futures-core v0.3.31 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling futures-sink v0.3.31 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Compiling ff v0.13.1 [INFO] [stderr] Compiling tracing-core v0.1.34 [INFO] [stderr] Compiling slab v0.4.11 [INFO] [stderr] Compiling convert_case v0.10.0 [INFO] [stderr] Compiling group v0.13.0 [INFO] [stderr] Compiling futures-channel v0.3.31 [INFO] [stderr] Compiling http v1.3.1 [INFO] [stderr] Compiling der v0.7.10 [INFO] [stderr] Compiling serde_json v1.0.143 [INFO] [stderr] Compiling pin-utils v0.1.0 [INFO] [stderr] Compiling memchr v2.7.5 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Compiling futures-task v0.3.31 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.100 [INFO] [stderr] Compiling regex-syntax v0.8.8 [INFO] [stderr] Compiling opaque-debug v0.3.1 [INFO] [stderr] Compiling futures-io v0.3.31 [INFO] [stderr] Compiling hashbrown v0.15.5 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Compiling try-lock v0.2.5 [INFO] [stderr] Compiling tracing v0.1.41 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Compiling atomic-waker v1.1.2 [INFO] [stderr] Compiling overload v0.1.1 [INFO] [stderr] Compiling keccak v0.1.5 [INFO] [stderr] Compiling deranged v0.5.5 [INFO] [stderr] Compiling nu-ansi-term v0.46.0 [INFO] [stderr] Compiling mio v1.0.4 [INFO] [stderr] Compiling socket2 v0.6.0 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling parking_lot v0.12.4 [INFO] [stderr] Compiling signal-hook-registry v1.4.6 [INFO] [stderr] Compiling indexmap v2.10.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling spki v0.7.3 [INFO] [stderr] Compiling http-body v1.0.1 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.100 [INFO] [stderr] Compiling cipher v0.4.4 [INFO] [stderr] Compiling universal-hash v0.5.1 [INFO] [stderr] Compiling tokio v1.47.1 [INFO] [stderr] Compiling polyval v0.6.2 [INFO] [stderr] Compiling hmac v0.12.1 [INFO] [stderr] Compiling signature v2.2.0 [INFO] [stderr] Compiling regex-automata v0.4.13 [INFO] [stderr] Compiling ghash v0.5.1 [INFO] [stderr] Compiling ctr v0.9.2 [INFO] [stderr] Compiling rfc6979 v0.4.0 [INFO] [stderr] Compiling aes v0.8.4 [INFO] [stderr] Compiling sha2 v0.10.9 [INFO] [stderr] Compiling sha3 v0.10.8 [INFO] [stderr] Compiling aead v0.5.2 [INFO] [stderr] Compiling sharded-slab v0.1.7 [INFO] [stderr] Compiling regex-automata v0.1.10 [INFO] [stderr] Compiling elliptic-curve v0.13.8 [INFO] [stderr] Compiling hybrid-array v0.2.3 [INFO] [stderr] Compiling want v0.3.1 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.100 [INFO] [stderr] Compiling tracing-log v0.2.0 [INFO] [stderr] Compiling kem v0.3.0-pre.0 [INFO] [stderr] Compiling crc32fast v1.5.0 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Compiling rustolio-utils-macros v0.1.0 [INFO] [stderr] Compiling primeorder v0.13.6 [INFO] [stderr] Compiling ecdsa v0.16.9 [INFO] [stderr] Compiling thread_local v1.1.9 [INFO] [stderr] Compiling time-core v0.1.8 [INFO] [stderr] Compiling num-conv v0.2.0 [INFO] [stderr] Compiling httpdate v1.0.3 [INFO] [stderr] Compiling time v0.3.46 [INFO] [stderr] Compiling flate2 v1.1.5 [INFO] [stderr] Compiling aes-gcm v0.10.3 [INFO] [stderr] Compiling matchers v0.1.0 [INFO] [stderr] Compiling p256 v0.13.2 [INFO] [stderr] Compiling ml-kem v0.2.1 [INFO] [stderr] Compiling http-body-util v0.1.3 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling js-sys v0.3.77 [INFO] [stderr] Compiling futures-executor v0.3.31 [INFO] [stderr] Compiling regex v1.12.2 [INFO] [stderr] Compiling futures v0.3.31 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling tracing-subscriber v0.3.19 [INFO] [stderr] Compiling typed-builder-macro v0.23.2 [INFO] [stderr] Compiling rustolio-web-router-macro v0.1.0 [INFO] [stderr] Compiling rustolio-web-core-macros v0.1.0 [INFO] [stderr] Checking matchit v0.8.6 [INFO] [stderr] Checking inventory v0.3.21 [INFO] [stderr] Compiling derive_more v2.1.1 [INFO] [stderr] Checking typed-builder v0.23.2 [INFO] [stderr] Compiling web-sys v0.3.77 [INFO] [stderr] Compiling wasm-bindgen-futures v0.4.50 [INFO] [stderr] Compiling serde-wasm-bindgen v0.6.5 [INFO] [stderr] Compiling tokio-util v0.7.16 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Checking rustolio-utils v0.1.0 [INFO] [stderr] Compiling rustolio-build-utils v0.1.0 [INFO] [stderr] Compiling rustolio-web v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded sub `cfg` when there is only one condition [INFO] [stdout] --> src/hooks/mod.rs:73:11 [INFO] [stdout] | [INFO] [stdout] 73 | #[cfg(all(not(target_arch = "wasm32")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `not(target_arch = "wasm32")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg [INFO] [stdout] = note: `#[warn(clippy::non_minimal_cfg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded sub `cfg` when there is only one condition [INFO] [stdout] --> src/hooks/mod.rs:73:11 [INFO] [stdout] | [INFO] [stdout] 73 | #[cfg(all(not(target_arch = "wasm32")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `not(target_arch = "wasm32")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg [INFO] [stdout] = note: `#[warn(clippy::non_minimal_cfg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `register_timeout` is never used [INFO] [stdout] --> src/hooks/scope.rs:148:12 [INFO] [stdout] | [INFO] [stdout] 49 | impl Scope { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 148 | pub fn register_timeout(id: i32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/elements/mod.rs:204:21 [INFO] [stdout] | [INFO] [stdout] 204 | fn into_wrapper(&self) -> StringWrapper; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/elements/mod.rs:379:9 [INFO] [stdout] | [INFO] [stdout] 379 | / let Some(elements) = self.elements.take() else { [INFO] [stdout] 380 | | return None; [INFO] [stdout] 381 | | }; [INFO] [stdout] | |__________^ help: replace it with: `let elements = self.elements.take()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/hooks/callbacks.rs:73:10 [INFO] [stdout] | [INFO] [stdout] 73 | ) -> Rc) -> T + 'static> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/hooks/callbacks.rs:139:10 [INFO] [stdout] | [INFO] [stdout] 139 | run: Rc) -> T>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/hooks/effect/store.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / pub fn new() -> usize { [INFO] [stdout] 39 | | EFFECT_STORE.with(|store| { [INFO] [stdout] 40 | | let mut store = store.borrow_mut(); [INFO] [stdout] 41 | | store.current += 1; [INFO] [stdout] ... | [INFO] [stdout] 44 | | }) [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/hooks/effect/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use std::usize; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `usize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/hooks/scope.rs:198:13 [INFO] [stdout] | [INFO] [stdout] 198 | / let Some(&idx) = stack.last() else { [INFO] [stdout] 199 | | return None; [INFO] [stdout] 200 | | }; [INFO] [stdout] | |______________^ help: replace it with: `let &idx = stack.last()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/hooks/scope.rs:212:13 [INFO] [stdout] | [INFO] [stdout] 212 | / let Some(&idx) = stack.last() else { [INFO] [stdout] 213 | | return None; [INFO] [stdout] 214 | | }; [INFO] [stdout] | |______________^ help: replace it with: `let &idx = stack.last()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this macro expands metavariables in an unsafe block [INFO] [stdout] --> src/hooks/global.rs:45:39 [INFO] [stdout] | [INFO] [stdout] 45 | static __SIGNAL: $t = unsafe { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 46 | | let s = $init; [INFO] [stdout] 47 | | $crate::hooks::SignalBase::globalize(&s); [INFO] [stdout] 48 | | s [INFO] [stdout] 49 | | }; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = note: this allows the user of the macro to write unsafe code outside of an unsafe block [INFO] [stdout] = help: consider expanding any metavariables outside of this block, e.g. by storing them in a variable [INFO] [stdout] = help: ... or also expand referenced metavariables in a safe context to require an unsafe block at callsite [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#macro_metavars_in_unsafe [INFO] [stdout] = note: `#[warn(clippy::macro_metavars_in_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `register_timeout` is never used [INFO] [stdout] --> src/hooks/scope.rs:148:12 [INFO] [stdout] | [INFO] [stdout] 49 | impl Scope { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 148 | pub fn register_timeout(id: i32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/elements/mod.rs:204:21 [INFO] [stdout] | [INFO] [stdout] 204 | fn into_wrapper(&self) -> StringWrapper; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/elements/mod.rs:379:9 [INFO] [stdout] | [INFO] [stdout] 379 | / let Some(elements) = self.elements.take() else { [INFO] [stdout] 380 | | return None; [INFO] [stdout] 381 | | }; [INFO] [stdout] | |__________^ help: replace it with: `let elements = self.elements.take()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/elements/mod.rs:624:44 [INFO] [stdout] | [INFO] [stdout] 624 | [String::new()].into_iter().map(|i| i), [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 625 | | (vec![1].into_iter()), [INFO] [stdout] 626 | | ], [INFO] [stdout] | |_____________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/hooks/callbacks.rs:73:10 [INFO] [stdout] | [INFO] [stdout] 73 | ) -> Rc) -> T + 'static> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/hooks/callbacks.rs:139:10 [INFO] [stdout] | [INFO] [stdout] 139 | run: Rc) -> T>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/hooks/effect/store.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / pub fn new() -> usize { [INFO] [stdout] 39 | | EFFECT_STORE.with(|store| { [INFO] [stdout] 40 | | let mut store = store.borrow_mut(); [INFO] [stdout] 41 | | store.current += 1; [INFO] [stdout] ... | [INFO] [stdout] 44 | | }) [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/hooks/effect/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use std::usize; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `usize::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/hooks/scope.rs:198:13 [INFO] [stdout] | [INFO] [stdout] 198 | / let Some(&idx) = stack.last() else { [INFO] [stdout] 199 | | return None; [INFO] [stdout] 200 | | }; [INFO] [stdout] | |______________^ help: replace it with: `let &idx = stack.last()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/hooks/scope.rs:212:13 [INFO] [stdout] | [INFO] [stdout] 212 | / let Some(&idx) = stack.last() else { [INFO] [stdout] 213 | | return None; [INFO] [stdout] 214 | | }; [INFO] [stdout] | |______________^ help: replace it with: `let &idx = stack.last()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this macro expands metavariables in an unsafe block [INFO] [stdout] --> src/hooks/global.rs:45:39 [INFO] [stdout] | [INFO] [stdout] 45 | static __SIGNAL: $t = unsafe { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 46 | | let s = $init; [INFO] [stdout] 47 | | $crate::hooks::SignalBase::globalize(&s); [INFO] [stdout] 48 | | s [INFO] [stdout] 49 | | }; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = note: this allows the user of the macro to write unsafe code outside of an unsafe block [INFO] [stdout] = help: consider expanding any metavariables outside of this block, e.g. by storing them in a variable [INFO] [stdout] = help: ... or also expand referenced metavariables in a safe context to require an unsafe block at callsite [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#macro_metavars_in_unsafe [INFO] [stdout] = note: `#[warn(clippy::macro_metavars_in_unsafe)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this macro expands metavariables in an unsafe block [INFO] [stdout] --> src/hooks/global.rs:99:39 [INFO] [stdout] | [INFO] [stdout] 99 | static __EFFECT: Effect = unsafe { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 100 | | // SAFETY: Cannot use scoped signals here [INFO] [stdout] 101 | | let mut e = Effect::$method($init); [INFO] [stdout] 102 | | e.deregister(); [INFO] [stdout] 103 | | e [INFO] [stdout] 104 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: this allows the user of the macro to write unsafe code outside of an unsafe block [INFO] [stdout] = help: consider expanding any metavariables outside of this block, e.g. by storing them in a variable [INFO] [stdout] = help: ... or also expand referenced metavariables in a safe context to require an unsafe block at callsite [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#macro_metavars_in_unsafe [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 16s [INFO] running `Command { std: "docker" "inspect" "d26555db9df689a35f3a6e67c95cc15faed63eeaca76be2145426b3bc77de888", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d26555db9df689a35f3a6e67c95cc15faed63eeaca76be2145426b3bc77de888", kill_on_drop: false }` [INFO] [stdout] d26555db9df689a35f3a6e67c95cc15faed63eeaca76be2145426b3bc77de888