[INFO] fetching crate rust_pie_ob 0.3.0...
[INFO] linting rust_pie_ob-0.3.0 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate rust_pie_ob 0.3.0 into /workspace/builds/worker-6-tc1/source
[INFO] started tweaking crates.io crate rust_pie_ob 0.3.0
[INFO] finished tweaking crates.io crate rust_pie_ob 0.3.0
[INFO] tweaked toml for crates.io crate rust_pie_ob 0.3.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate rust_pie_ob 0.3.0 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]      Locking 68 packages to latest compatible versions
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded borsh-derive v1.6.1
[INFO] [stderr]   Downloaded rust_decimal_macros v1.40.0
[INFO] [stderr]   Downloaded borsh v1.6.1
[INFO] [stderr]   Downloaded rust_ob v2.5.3
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 55e78ff7a4a1e6aca3ff77e47a7ace0ad9f9acbe635216c52f6f05fa50722160
[INFO] running `Command { std: "docker" "start" "-a" "55e78ff7a4a1e6aca3ff77e47a7ace0ad9f9acbe635216c52f6f05fa50722160", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "55e78ff7a4a1e6aca3ff77e47a7ace0ad9f9acbe635216c52f6f05fa50722160", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "55e78ff7a4a1e6aca3ff77e47a7ace0ad9f9acbe635216c52f6f05fa50722160", kill_on_drop: false }`
[INFO] [stdout] 55e78ff7a4a1e6aca3ff77e47a7ace0ad9f9acbe635216c52f6f05fa50722160
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 3140e4558d522b2600b7df90d5aac1885f957dc6c2e09b4cea3d01a519254acd
[INFO] running `Command { std: "docker" "start" "-a" "3140e4558d522b2600b7df90d5aac1885f957dc6c2e09b4cea3d01a519254acd", kill_on_drop: false }`
[INFO] [stderr]    Compiling serde v1.0.228
[INFO] [stderr]    Compiling num-traits v0.2.19
[INFO] [stderr]    Compiling quote v1.0.45
[INFO] [stderr]    Compiling syn v2.0.117
[INFO] [stderr]     Checking rust_decimal v1.40.0
[INFO] [stderr]     Checking rust_ob v2.5.3
[INFO] [stderr]     Checking rust_pie_ob v0.3.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/pieorderbook.rs:74:21
[INFO] [stdout]    |
[INFO] [stdout] 74 |                     price >= own_price && !(own_price > others_price && !others_quantity.is_zero())
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(others_quantity.is_zero() || own_price <= others_price) && price >= own_price`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/pieorderbook.rs:74:43
[INFO] [stdout]    |
[INFO] [stdout] 74 |                     price >= own_price && !(own_price > others_price && !others_quantity.is_zero())
[INFO] [stdout]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `own_price <= others_price || others_quantity.is_zero()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/pieorderbook.rs:78:21
[INFO] [stdout]    |
[INFO] [stdout] 78 |                     price <= own_price && !(own_price <= others_price && !others_quantity.is_zero())
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(others_quantity.is_zero() || own_price > others_price) && price <= own_price`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/pieorderbook.rs:78:43
[INFO] [stdout]    |
[INFO] [stdout] 78 |                     price <= own_price && !(own_price <= others_price && !others_quantity.is_zero())
[INFO] [stdout]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `own_price > others_price || others_quantity.is_zero()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]    Compiling rust_decimal_macros v1.40.0
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/pieorderbook.rs:74:21
[INFO] [stdout]    |
[INFO] [stdout] 74 |                     price >= own_price && !(own_price > others_price && !others_quantity.is_zero())
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(others_quantity.is_zero() || own_price <= others_price) && price >= own_price`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/pieorderbook.rs:74:43
[INFO] [stdout]    |
[INFO] [stdout] 74 |                     price >= own_price && !(own_price > others_price && !others_quantity.is_zero())
[INFO] [stdout]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `own_price <= others_price || others_quantity.is_zero()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/pieorderbook.rs:78:21
[INFO] [stdout]    |
[INFO] [stdout] 78 |                     price <= own_price && !(own_price <= others_price && !others_quantity.is_zero())
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(others_quantity.is_zero() || own_price > others_price) && price <= own_price`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/pieorderbook.rs:78:43
[INFO] [stdout]    |
[INFO] [stdout] 78 |                     price <= own_price && !(own_price <= others_price && !others_quantity.is_zero())
[INFO] [stdout]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `own_price > others_price || others_quantity.is_zero()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]   --> tests/test.rs:61:5
[INFO] [stdout]    |
[INFO] [stdout] 61 |     res.sort_by(|v1, v2| v1.order.cmp(&v2.order));
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_sort_by)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 61 -     res.sort_by(|v1, v2| v1.order.cmp(&v2.order));
[INFO] [stdout] 61 +     res.sort_by_key(|v1| v1.order);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> tests/test.rs:101:5
[INFO] [stdout]     |
[INFO] [stdout] 101 |     res.sort_by(|v1, v2| v1.order.cmp(&v2.order));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 101 -     res.sort_by(|v1, v2| v1.order.cmp(&v2.order));
[INFO] [stdout] 101 +     res.sort_by_key(|v1| v1.order);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> tests/test.rs:106:5
[INFO] [stdout]     |
[INFO] [stdout] 106 |     res.sort_by(|v1, v2| v1.order.cmp(&v2.order));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 106 -     res.sort_by(|v1, v2| v1.order.cmp(&v2.order));
[INFO] [stdout] 106 +     res.sort_by_key(|v1| v1.order);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> tests/test.rs:192:5
[INFO] [stdout]     |
[INFO] [stdout] 192 |     res.sort_by(|v1, v2| v1.order.cmp(&v2.order));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 192 -     res.sort_by(|v1, v2| v1.order.cmp(&v2.order));
[INFO] [stdout] 192 +     res.sort_by_key(|v1| v1.order);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> tests/test.rs:388:5
[INFO] [stdout]     |
[INFO] [stdout] 388 |     res.sort_by(|v1, v2| v1.order.cmp(&v2.order));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 388 -     res.sort_by(|v1, v2| v1.order.cmp(&v2.order));
[INFO] [stdout] 388 +     res.sort_by_key(|v1| v1.order);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> tests/test.rs:431:5
[INFO] [stdout]     |
[INFO] [stdout] 431 |     res.sort_by(|v1, v2| v1.order.cmp(&v2.order));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 431 -     res.sort_by(|v1, v2| v1.order.cmp(&v2.order));
[INFO] [stdout] 431 +     res.sort_by_key(|v1| v1.order);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> tests/test.rs:461:5
[INFO] [stdout]     |
[INFO] [stdout] 461 |     res.sort_by(|v1, v2| v1.order.cmp(&v2.order));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 461 -     res.sort_by(|v1, v2| v1.order.cmp(&v2.order));
[INFO] [stdout] 461 +     res.sort_by_key(|v1| v1.order);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> tests/test.rs:504:5
[INFO] [stdout]     |
[INFO] [stdout] 504 |     res.sort_by(|v1, v2| v1.order.cmp(&v2.order));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 504 -     res.sort_by(|v1, v2| v1.order.cmp(&v2.order));
[INFO] [stdout] 504 +     res.sort_by_key(|v1| v1.order);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> tests/test.rs:549:5
[INFO] [stdout]     |
[INFO] [stdout] 549 |     res.sort_by(|v1, v2| v1.order.cmp(&v2.order));
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 549 -     res.sort_by(|v1, v2| v1.order.cmp(&v2.order));
[INFO] [stdout] 549 +     res.sort_by_key(|v1| v1.order);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.14s
[INFO] running `Command { std: "docker" "inspect" "3140e4558d522b2600b7df90d5aac1885f957dc6c2e09b4cea3d01a519254acd", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "3140e4558d522b2600b7df90d5aac1885f957dc6c2e09b4cea3d01a519254acd", kill_on_drop: false }`
[INFO] [stdout] 3140e4558d522b2600b7df90d5aac1885f957dc6c2e09b4cea3d01a519254acd