[INFO] fetching crate rust_icu_uloc 5.4.0... [INFO] linting rust_icu_uloc-5.4.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rust_icu_uloc 5.4.0 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate rust_icu_uloc 5.4.0 [INFO] finished tweaking crates.io crate rust_icu_uloc 5.4.0 [INFO] tweaked toml for crates.io crate rust_icu_uloc 5.4.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rust_icu_uloc 5.4.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate rust_icu_uloc 5.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rust_icu_ustring v5.4.0 [INFO] [stderr] Downloaded rust_icu_common v5.4.0 [INFO] [stderr] Downloaded rust_icu_release v5.4.0 [INFO] [stderr] Downloaded rust_icu_uenum v5.4.0 [INFO] [stderr] Downloaded rust_icu_sys v5.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 317c91cd4441f1039b2742ee4b004434e6c26ccc270a6477bce332bdd4a6983c [INFO] running `Command { std: "docker" "start" "-a" "317c91cd4441f1039b2742ee4b004434e6c26ccc270a6477bce332bdd4a6983c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "317c91cd4441f1039b2742ee4b004434e6c26ccc270a6477bce332bdd4a6983c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "317c91cd4441f1039b2742ee4b004434e6c26ccc270a6477bce332bdd4a6983c", kill_on_drop: false }` [INFO] [stdout] 317c91cd4441f1039b2742ee4b004434e6c26ccc270a6477bce332bdd4a6983c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f6a53330f2ac58127fa67cc2471b3cf098229b9a694e231af1940098f585e487 [INFO] running `Command { std: "docker" "start" "-a" "f6a53330f2ac58127fa67cc2471b3cf098229b9a694e231af1940098f585e487", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling prettyplease v0.2.37 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling regex-syntax v0.8.8 [INFO] [stderr] Compiling bitflags v2.9.4 [INFO] [stderr] Compiling linux-raw-sys v0.4.15 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Compiling home v0.5.11 [INFO] [stderr] Compiling bindgen v0.69.5 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling log v0.4.28 [INFO] [stderr] Compiling rust_icu_release v5.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling rust_icu_uloc v5.4.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling regex-automata v0.4.13 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling regex v1.12.2 [INFO] [stderr] Compiling rust_icu_sys v5.4.0 [INFO] [stderr] Checking rust_icu_common v5.4.0 [INFO] [stderr] Checking rust_icu_ustring v5.4.0 [INFO] [stderr] Checking rust_icu_uenum v5.4.0 [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lib.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 76 | / let locmut = ULocMut { [INFO] [stdout] 77 | | base: l.base_name(), [INFO] [stdout] 78 | | unicode_keyvalues, [INFO] [stdout] 79 | | other_keyvalues, [INFO] [stdout] 80 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 81 | locmut [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 76 ~ [INFO] [stdout] 77 ~ ULocMut { [INFO] [stdout] 78 + base: l.base_name(), [INFO] [stdout] 79 + unicode_keyvalues, [INFO] [stdout] 80 + other_keyvalues, [INFO] [stdout] 81 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:97:44 [INFO] [stdout] | [INFO] [stdout] 97 | let unicode_extension: String = if unicode_extensions.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!unicode_extensions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 110 | if unicode_extension.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!unicode_extension.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/lib.rs:132:16 [INFO] [stdout] | [INFO] [stdout] 132 | if let None = to_unicode_locale_key(key) { [INFO] [stdout] | -------^^^^----------------------------- help: try: `if to_unicode_locale_key(key).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/lib.rs:143:16 [INFO] [stdout] | [INFO] [stdout] 143 | if let None = to_unicode_locale_key(key) { [INFO] [stdout] | -------^^^^----------------------------- help: try: `if to_unicode_locale_key(key).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:318:37 [INFO] [stdout] | [INFO] [stdout] 318 | pub fn display_keyword(keyword: &String, display_locale: &ULoc) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 318 ~ pub fn display_keyword(keyword: &str, display_locale: &ULoc) -> Result { [INFO] [stdout] 319 | buffered_uchar_method_with_retry!( [INFO] [stdout] ... [INFO] [stdout] 324 | ); [INFO] [stdout] 325 ~ let keyword = ffi::CString::new(keyword).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:334:50 [INFO] [stdout] | [INFO] [stdout] 334 | pub fn display_keyword_value(&self, keyword: &String, display_locale: &ULoc) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 334 ~ pub fn display_keyword_value(&self, keyword: &str, display_locale: &ULoc) -> Result { [INFO] [stdout] 335 | buffered_uchar_method_with_retry!( [INFO] [stdout] ... [INFO] [stdout] 340 | ); [INFO] [stdout] 341 ~ let keyword = ffi::CString::new(keyword).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lib.rs:368:9 [INFO] [stdout] | [INFO] [stdout] 367 | let count = unsafe { versioned_function!(uloc_countAvailable)() }; [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 368 | count [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 367 ~ [INFO] [stdout] 368 ~ unsafe { versioned_function!(uloc_countAvailable)() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparing with null is better expressed by the `.is_null()` method [INFO] [stdout] --> src/lib.rs:377:12 [INFO] [stdout] | [INFO] [stdout] 377 | if ptr == std::ptr::null() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.is_null()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stdout] = note: `#[warn(clippy::cmp_null)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:605:44 [INFO] [stdout] | [INFO] [stdout] 605 | match self_keyword.cmp(&other_keyword) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `other_keyword` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lib.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 76 | / let locmut = ULocMut { [INFO] [stdout] 77 | | base: l.base_name(), [INFO] [stdout] 78 | | unicode_keyvalues, [INFO] [stdout] 79 | | other_keyvalues, [INFO] [stdout] 80 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 81 | locmut [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 76 ~ [INFO] [stdout] 77 ~ ULocMut { [INFO] [stdout] 78 + base: l.base_name(), [INFO] [stdout] 79 + unicode_keyvalues, [INFO] [stdout] 80 + other_keyvalues, [INFO] [stdout] 81 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:97:44 [INFO] [stdout] | [INFO] [stdout] 97 | let unicode_extension: String = if unicode_extensions.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!unicode_extensions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 110 | if unicode_extension.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!unicode_extension.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/lib.rs:132:16 [INFO] [stdout] | [INFO] [stdout] 132 | if let None = to_unicode_locale_key(key) { [INFO] [stdout] | -------^^^^----------------------------- help: try: `if to_unicode_locale_key(key).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/lib.rs:143:16 [INFO] [stdout] | [INFO] [stdout] 143 | if let None = to_unicode_locale_key(key) { [INFO] [stdout] | -------^^^^----------------------------- help: try: `if to_unicode_locale_key(key).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:318:37 [INFO] [stdout] | [INFO] [stdout] 318 | pub fn display_keyword(keyword: &String, display_locale: &ULoc) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 318 ~ pub fn display_keyword(keyword: &str, display_locale: &ULoc) -> Result { [INFO] [stdout] 319 | buffered_uchar_method_with_retry!( [INFO] [stdout] ... [INFO] [stdout] 324 | ); [INFO] [stdout] 325 ~ let keyword = ffi::CString::new(keyword).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/lib.rs:334:50 [INFO] [stdout] | [INFO] [stdout] 334 | pub fn display_keyword_value(&self, keyword: &String, display_locale: &ULoc) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 334 ~ pub fn display_keyword_value(&self, keyword: &str, display_locale: &ULoc) -> Result { [INFO] [stdout] 335 | buffered_uchar_method_with_retry!( [INFO] [stdout] ... [INFO] [stdout] 340 | ); [INFO] [stdout] 341 ~ let keyword = ffi::CString::new(keyword).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/lib.rs:368:9 [INFO] [stdout] | [INFO] [stdout] 367 | let count = unsafe { versioned_function!(uloc_countAvailable)() }; [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 368 | count [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 367 ~ [INFO] [stdout] 368 ~ unsafe { versioned_function!(uloc_countAvailable)() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparing with null is better expressed by the `.is_null()` method [INFO] [stdout] --> src/lib.rs:377:12 [INFO] [stdout] | [INFO] [stdout] 377 | if ptr == std::ptr::null() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.is_null()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stdout] = note: `#[warn(clippy::cmp_null)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:605:44 [INFO] [stdout] | [INFO] [stdout] 605 | match self_keyword.cmp(&other_keyword) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `other_keyword` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/lib.rs:857:21 [INFO] [stdout] | [INFO] [stdout] 857 | None => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1350:42 [INFO] [stdout] | [INFO] [stdout] 1350 | assert!(all_locales.contains(&locale)); [INFO] [stdout] | ^^^^^^^ help: change this to: `locale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1351:40 [INFO] [stdout] | [INFO] [stdout] 1351 | assert!(!locales1.contains(&locale)); [INFO] [stdout] | ^^^^^^^ help: change this to: `locale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1354:42 [INFO] [stdout] | [INFO] [stdout] 1354 | assert!(all_locales.contains(&locale)); [INFO] [stdout] | ^^^^^^^ help: change this to: `locale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1355:45 [INFO] [stdout] | [INFO] [stdout] 1355 | assert!(!alias_locales.contains(&locale)); [INFO] [stdout] | ^^^^^^^ help: change this to: `locale` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:1357:17 [INFO] [stdout] | [INFO] [stdout] 1357 | assert!(alias_locales.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!alias_locales.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:1377:17 [INFO] [stdout] | [INFO] [stdout] 1377 | assert!(!ULoc::open_available_by_type(ULocAvailableType::ULOC_AVAILABLE_COUNT).is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ULoc::open_available_by_type(ULocAvailableType::ULOC_AVAILABLE_COUNT).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 30.19s [INFO] running `Command { std: "docker" "inspect" "f6a53330f2ac58127fa67cc2471b3cf098229b9a694e231af1940098f585e487", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f6a53330f2ac58127fa67cc2471b3cf098229b9a694e231af1940098f585e487", kill_on_drop: false }` [INFO] [stdout] f6a53330f2ac58127fa67cc2471b3cf098229b9a694e231af1940098f585e487