[INFO] fetching crate rust-web-server 16.1.0... [INFO] linting rust-web-server-16.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rust-web-server 16.1.0 into /workspace/builds/worker-7-tc1/source [INFO] removed /workspace/builds/worker-7-tc1/source/.cargo/config [INFO] started tweaking crates.io crate rust-web-server 16.1.0 [INFO] finished tweaking crates.io crate rust-web-server 16.1.0 [INFO] tweaked toml for crates.io crate rust-web-server 16.1.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rust-web-server 16.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 3 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded url-search-params v12.0.0 [INFO] [stderr] Downloaded file-ext v12.0.0 [INFO] [stderr] Downloaded url-build-parse v12.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d5660ffcd7c4e0bef95847d722b5058ce538e2c4e72836448d723b55b0f1aed4 [INFO] running `Command { std: "docker" "start" "-a" "d5660ffcd7c4e0bef95847d722b5058ce538e2c4e72836448d723b55b0f1aed4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d5660ffcd7c4e0bef95847d722b5058ce538e2c4e72836448d723b55b0f1aed4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d5660ffcd7c4e0bef95847d722b5058ce538e2c4e72836448d723b55b0f1aed4", kill_on_drop: false }` [INFO] [stdout] d5660ffcd7c4e0bef95847d722b5058ce538e2c4e72836448d723b55b0f1aed4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7324a81566b0e33a591ad78e65f9782478efd3050452e6f7c1bbcc2226b08b91 [INFO] running `Command { std: "docker" "start" "-a" "7324a81566b0e33a591ad78e65f9782478efd3050452e6f7c1bbcc2226b08b91", kill_on_drop: false }` [INFO] [stderr] Checking url-search-params v12.0.0 [INFO] [stderr] Checking file-ext v12.0.0 [INFO] [stderr] Checking url-build-parse v12.1.0 [INFO] [stderr] Checking rust-web-server v16.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/null/mod.rs:8:18 [INFO] [stdout] | [INFO] [stdout] 8 | pub const NULL: &'static Null = &Null{}; [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&Null` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/range/example/mod.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | range: range, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/response/example/mod.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | range: range, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/null/mod.rs:8:18 [INFO] [stdout] | [INFO] [stdout] 8 | pub const NULL: &'static Null = &Null{}; [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&Null` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/not_found/mod.rs:26:37 [INFO] [stdout] | [INFO] [stdout] 25 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 26 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/not_found/mod.rs:75:37 [INFO] [stdout] | [INFO] [stdout] 74 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 75 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/index/mod.rs:30:37 [INFO] [stdout] | [INFO] [stdout] 29 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 30 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/index/mod.rs:79:37 [INFO] [stdout] | [INFO] [stdout] 78 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 79 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_md` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:51:22 [INFO] [stdout] | [INFO] [stdout] 50 | if boxed_md.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = boxed_md` [INFO] [stdout] 51 | let md = boxed_md.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:40:66 [INFO] [stdout] | [INFO] [stdout] 40 | let boxed_static_filepath = FileExt::get_static_filepath(&os_specific_path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `os_specific_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range_list` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:109:38 [INFO] [stdout] | [INFO] [stdout] 108 | if boxed_content_range_list.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_content_range_list` [INFO] [stdout] 109 | let content_range_list = boxed_content_range_list.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_modified_date_time` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:145:46 [INFO] [stdout] | [INFO] [stdout] 144 | if boxed_modified_date_time.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_modified_date_time` [INFO] [stdout] 145 | let modified_date_time = boxed_modified_date_time.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:107:91 [INFO] [stdout] | [INFO] [stdout] 107 | let boxed_content_range_list = StaticResourceController::process_static_resources(&request); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:111:16 [INFO] [stdout] | [INFO] [stdout] 111 | if content_range_list.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content_range_list.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range_list` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:209:38 [INFO] [stdout] | [INFO] [stdout] 208 | if boxed_content_range_list.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_content_range_list` [INFO] [stdout] 209 | let content_range_list = boxed_content_range_list.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_modified_date_time` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:232:46 [INFO] [stdout] | [INFO] [stdout] 231 | if boxed_modified_date_time.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_modified_date_time` [INFO] [stdout] 232 | let modified_date_time = boxed_modified_date_time.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:207:91 [INFO] [stdout] | [INFO] [stdout] 207 | let boxed_content_range_list = StaticResourceController::process_static_resources(&request); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:211:16 [INFO] [stdout] | [INFO] [stdout] 211 | if content_range_list.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content_range_list.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_md` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:300:22 [INFO] [stdout] | [INFO] [stdout] 299 | if boxed_md.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = boxed_md` [INFO] [stdout] 300 | let md = boxed_md.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_header` after checking its variant with `is_some` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:310:36 [INFO] [stdout] | [INFO] [stdout] 309 | if boxed_header.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = boxed_header` [INFO] [stdout] 310 | range_header = boxed_header.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range_list` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:325:42 [INFO] [stdout] | [INFO] [stdout] 324 | if boxed_content_range_list.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_content_range_list` [INFO] [stdout] 325 | content_range_list = boxed_content_range_list.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_header` after checking its variant with `is_some` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:345:40 [INFO] [stdout] | [INFO] [stdout] 344 | if boxed_header.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = boxed_header` [INFO] [stdout] 345 | range_header = boxed_header.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range_list` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:360:46 [INFO] [stdout] | [INFO] [stdout] 359 | if boxed_content_range_list.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_content_range_list` [INFO] [stdout] 360 | content_range_list = boxed_content_range_list.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_header` after checking its variant with `is_some` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:375:40 [INFO] [stdout] | [INFO] [stdout] 374 | if boxed_header.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = boxed_header` [INFO] [stdout] 375 | range_header = boxed_header.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range_list` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:380:46 [INFO] [stdout] | [INFO] [stdout] 379 | if boxed_content_range_list.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_content_range_list` [INFO] [stdout] 380 | content_range_list = boxed_content_range_list.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_header` after checking its variant with `is_some` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:404:44 [INFO] [stdout] | [INFO] [stdout] 403 | if boxed_header.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = boxed_header` [INFO] [stdout] 404 | range_header = boxed_header.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range_list` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:425:50 [INFO] [stdout] | [INFO] [stdout] 424 | if boxed_content_range_list.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_content_range_list` [INFO] [stdout] 425 | content_range_list = boxed_content_range_list.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:282:66 [INFO] [stdout] | [INFO] [stdout] 282 | let boxed_static_filepath = FileExt::get_static_filepath(&os_specific_path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `os_specific_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/style/mod.rs:26:37 [INFO] [stdout] | [INFO] [stdout] 25 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 26 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/style/mod.rs:75:37 [INFO] [stdout] | [INFO] [stdout] 74 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 75 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/favicon/mod.rs:30:37 [INFO] [stdout] | [INFO] [stdout] 29 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 30 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/favicon/mod.rs:79:37 [INFO] [stdout] | [INFO] [stdout] 78 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 79 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/script/mod.rs:29:37 [INFO] [stdout] | [INFO] [stdout] 28 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 29 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/script/mod.rs:78:37 [INFO] [stdout] | [INFO] [stdout] 77 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 78 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `query_option` after checking its variant with `is_some` [INFO] [stdout] --> src/app/controller/form/get_method/mod.rs:37:49 [INFO] [stdout] | [INFO] [stdout] 36 | if query_option.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = query_option` [INFO] [stdout] 37 | let form: HashMap = query_option.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `query_option` after checking its variant with `is_some` [INFO] [stdout] --> src/app/controller/form/get_method/mod.rs:89:49 [INFO] [stdout] | [INFO] [stdout] 88 | if query_option.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = query_option` [INFO] [stdout] 89 | let form: HashMap = query_option.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get("name").is_none()` [INFO] [stdout] --> src/app/controller/file/initiate/mod.rs:49:17 [INFO] [stdout] | [INFO] [stdout] 49 | if form.get("name").is_none() { [INFO] [stdout] | -----^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!form.contains_key("name")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get("lastModified").is_none()` [INFO] [stdout] --> src/app/controller/file/initiate/mod.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | if form.get("lastModified").is_none() { [INFO] [stdout] | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!form.contains_key("lastModified")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get("size").is_none()` [INFO] [stdout] --> src/app/controller/file/initiate/mod.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | if form.get("size").is_none() { [INFO] [stdout] | -----^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!form.contains_key("size")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get("name").is_none()` [INFO] [stdout] --> src/app/controller/file/initiate/mod.rs:126:17 [INFO] [stdout] | [INFO] [stdout] 126 | if form.get("name").is_none() { [INFO] [stdout] | -----^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!form.contains_key("name")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get("lastModified").is_none()` [INFO] [stdout] --> src/app/controller/file/initiate/mod.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | if form.get("lastModified").is_none() { [INFO] [stdout] | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!form.contains_key("lastModified")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get("size").is_none()` [INFO] [stdout] --> src/app/controller/file/initiate/mod.rs:132:17 [INFO] [stdout] | [INFO] [stdout] 132 | if form.get("size").is_none() { [INFO] [stdout] | -----^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!form.contains_key("size")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:36:51 [INFO] [stdout] | [INFO] [stdout] 36 | let header_list = Header::get_header_list(&request); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:46:41 [INFO] [stdout] | [INFO] [stdout] 46 | if IndexController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:47:49 [INFO] [stdout] | [INFO] [stdout] 47 | response = IndexController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:51:41 [INFO] [stdout] | [INFO] [stdout] 51 | if StyleController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:52:49 [INFO] [stdout] | [INFO] [stdout] 52 | response = StyleController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:56:42 [INFO] [stdout] | [INFO] [stdout] 56 | if ScriptController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:57:50 [INFO] [stdout] | [INFO] [stdout] 57 | response = ScriptController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:61:54 [INFO] [stdout] | [INFO] [stdout] 61 | if FileUploadInitiateController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:62:62 [INFO] [stdout] | [INFO] [stdout] 62 | response = FileUploadInitiateController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:66:67 [INFO] [stdout] | [INFO] [stdout] 66 | if FormUrlEncodedEnctypePostMethodController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:67:75 [INFO] [stdout] | [INFO] [stdout] 67 | response = FormUrlEncodedEnctypePostMethodController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:71:49 [INFO] [stdout] | [INFO] [stdout] 71 | if FormGetMethodController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:72:57 [INFO] [stdout] | [INFO] [stdout] 72 | response = FormGetMethodController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:76:66 [INFO] [stdout] | [INFO] [stdout] 76 | if FormMultipartEnctypePostMethodController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:77:74 [INFO] [stdout] | [INFO] [stdout] 77 | response = FormMultipartEnctypePostMethodController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:81:43 [INFO] [stdout] | [INFO] [stdout] 81 | if FaviconController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:82:51 [INFO] [stdout] | [INFO] [stdout] 82 | response = FaviconController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:86:50 [INFO] [stdout] | [INFO] [stdout] 86 | if StaticResourceController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:87:58 [INFO] [stdout] | [INFO] [stdout] 87 | response = StaticResourceController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:91:44 [INFO] [stdout] | [INFO] [stdout] 91 | if NotFoundController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:92:52 [INFO] [stdout] | [INFO] [stdout] 92 | response = NotFoundController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/client_hint/mod.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 41 | let hint_header_value = hint_list.join(", "); [INFO] [stdout] | --------------------------------------------- unnecessary `let` binding [INFO] [stdout] 42 | hint_header_value [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 41 ~ [INFO] [stdout] 42 ~ hint_list.join(", ") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/client_hint/mod.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 47 | let header = Header { name: ClientHint::ACCEPT_CLIENT_HINTS.to_string(), value: hint_header_value.to_string() }; [INFO] [stdout] | ---------------------------------------------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 48 | header [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 47 ~ [INFO] [stdout] 48 ~ Header { name: ClientHint::ACCEPT_CLIENT_HINTS.to_string(), value: hint_header_value.to_string() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/client_hint/mod.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 53 | let header = Header { name: ClientHint::CRITICAL_CLIENT_HINTS.to_string(), value: hint_header_value.to_string() }; [INFO] [stdout] | ------------------------------------------------------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 54 | header [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 53 ~ [INFO] [stdout] 54 ~ Header { name: ClientHint::CRITICAL_CLIENT_HINTS.to_string(), value: hint_header_value.to_string() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/client_hint/mod.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 70 | let vary_client_hint = hint_list.join(", "); [INFO] [stdout] | -------------------------------------------- unnecessary `let` binding [INFO] [stdout] 71 | vary_client_hint [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 70 ~ [INFO] [stdout] 71 ~ hint_list.join(", ") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `origin` after checking its variant with `is_some` [INFO] [stdout] --> src/cors/mod.rs:35:24 [INFO] [stdout] | [INFO] [stdout] 32 | if origin.is_some() { [INFO] [stdout] | ------------------- help: try: `if let Some() = origin` [INFO] [stdout] ... [INFO] [stdout] 35 | value: origin.unwrap().value.to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `method` after checking its variant with `is_some` [INFO] [stdout] --> src/cors/mod.rs:51:32 [INFO] [stdout] | [INFO] [stdout] 48 | if method.is_some() { [INFO] [stdout] | ------------------- help: try: `if let Some() = method` [INFO] [stdout] ... [INFO] [stdout] 51 | value: method.unwrap().value.to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `access_control_request_headers` after checking its variant with `is_some` [INFO] [stdout] --> src/cors/mod.rs:58:43 [INFO] [stdout] | [INFO] [stdout] 57 | if access_control_request_headers.is_some() { [INFO] [stdout] | ------------------------------------------- help: try: `if let Some() = access_control_request_headers` [INFO] [stdout] 58 | let request_headers = access_control_request_headers.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cors/mod.rs:95:28 [INFO] [stdout] | [INFO] [stdout] 95 | let origin_value = format!("{}", origin.value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `origin.value.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_allow_origins` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:156:29 [INFO] [stdout] | [INFO] [stdout] 153 | if boxed_allow_origins.is_err() { [INFO] [stdout] | ------------------------------- help: try: `if let Ok() = boxed_allow_origins` [INFO] [stdout] ... [INFO] [stdout] 156 | allow_origins = boxed_allow_origins.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_is_allow_credentials` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:183:31 [INFO] [stdout] | [INFO] [stdout] 180 | if boxed_is_allow_credentials.is_err() { [INFO] [stdout] | -------------------------------------- help: try: `if let Ok() = boxed_is_allow_credentials` [INFO] [stdout] ... [INFO] [stdout] 183 | let boxed_parse = boxed_is_allow_credentials.unwrap().parse::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_parse` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:187:51 [INFO] [stdout] | [INFO] [stdout] 184 | if boxed_parse.is_err() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = boxed_parse` [INFO] [stdout] ... [INFO] [stdout] 187 | let is_allow_credentials : bool = boxed_parse.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_methods` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:205:31 [INFO] [stdout] | [INFO] [stdout] 202 | if boxed_methods.is_err() { [INFO] [stdout] | ------------------------- help: try: `if let Ok() = boxed_methods` [INFO] [stdout] ... [INFO] [stdout] 205 | let methods = boxed_methods.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_allow_headers_env_variable` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:218:50 [INFO] [stdout] | [INFO] [stdout] 215 | if boxed_allow_headers_env_variable.is_err() { [INFO] [stdout] | -------------------------------------------- help: try: `if let Ok() = boxed_allow_headers_env_variable` [INFO] [stdout] ... [INFO] [stdout] 218 | let allow_headers_env_variable = boxed_allow_headers_env_variable.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_allow_expose_headers` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:231:45 [INFO] [stdout] | [INFO] [stdout] 228 | if boxed_allow_expose_headers.is_err() { [INFO] [stdout] | -------------------------------------- help: try: `if let Ok() = boxed_allow_expose_headers` [INFO] [stdout] ... [INFO] [stdout] 231 | let allow_expose_headers = boxed_allow_expose_headers.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_max_age_value` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:244:38 [INFO] [stdout] | [INFO] [stdout] 241 | if boxed_max_age_value.is_err() { [INFO] [stdout] | ------------------------------- help: try: `if let Ok() = boxed_max_age_value` [INFO] [stdout] ... [INFO] [stdout] 244 | let max_age_value = boxed_max_age_value.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cors/mod.rs:166:28 [INFO] [stdout] | [INFO] [stdout] 166 | let origin_value = format!("{}", origin.value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `origin.value.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_header_list` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:267:24 [INFO] [stdout] | [INFO] [stdout] 264 | if boxed_cors_header_list.is_err() { [INFO] [stdout] | ---------------------------------- help: try: `if let Ok() = boxed_cors_header_list` [INFO] [stdout] ... [INFO] [stdout] 267 | return boxed_cors_header_list.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_rws_config_cors_allow_all` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:270:31 [INFO] [stdout] | [INFO] [stdout] 261 | if boxed_rws_config_cors_allow_all.is_err() { [INFO] [stdout] | ------------------------------------------- help: try: `if let Ok() = boxed_rws_config_cors_allow_all` [INFO] [stdout] ... [INFO] [stdout] 270 | let boxed_parse = boxed_rws_config_cors_allow_all.unwrap().parse::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_parse` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:274:57 [INFO] [stdout] | [INFO] [stdout] 271 | if boxed_parse.is_err() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = boxed_parse` [INFO] [stdout] ... [INFO] [stdout] 274 | let is_cors_set_to_allow_all_requests = boxed_parse.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_header_list` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:280:32 [INFO] [stdout] | [INFO] [stdout] 277 | if boxed_cors_header_list.is_err() { [INFO] [stdout] | ---------------------------------- help: try: `if let Ok() = boxed_cors_header_list` [INFO] [stdout] ... [INFO] [stdout] 280 | return boxed_cors_header_list.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_header_list` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:292:20 [INFO] [stdout] | [INFO] [stdout] 288 | if boxed_cors_header_list.is_err() { [INFO] [stdout] | ---------------------------------- help: try: `if let Ok() = boxed_cors_header_list` [INFO] [stdout] ... [INFO] [stdout] 292 | return boxed_cors_header_list.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cors/mod.rs:292:13 [INFO] [stdout] | [INFO] [stdout] 292 | return boxed_cors_header_list.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 292 - return boxed_cors_header_list.unwrap() [INFO] [stdout] 292 + boxed_cors_header_list.unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cors/mod.rs:263:58 [INFO] [stdout] | [INFO] [stdout] 263 | let boxed_cors_header_list = Cors::allow_all(&request); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cors/mod.rs:276:85 [INFO] [stdout] | [INFO] [stdout] 276 | let boxed_cors_header_list = Cors::process_using_default_config(&request); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cors/mod.rs:287:54 [INFO] [stdout] | [INFO] [stdout] 287 | let boxed_cors_header_list = Cors::allow_all(&request); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_split` after checking its variant with `is_some` [INFO] [stdout] --> src/entry_point/command_line_args/mod.rs:126:42 [INFO] [stdout] | [INFO] [stdout] 124 | if boxed_split.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = boxed_split` [INFO] [stdout] 125 | [INFO] [stdout] 126 | let (parameter, value) = boxed_split.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_predefined_argument` after checking its variant with `is_some` [INFO] [stdout] --> src/entry_point/command_line_args/mod.rs:142:47 [INFO] [stdout] | [INFO] [stdout] 141 | if boxed_predefined_argument.is_some() { [INFO] [stdout] | -------------------------------------- help: try: `if let Some() = boxed_predefined_argument` [INFO] [stdout] 142 | let predefined_argument = boxed_predefined_argument.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::io::Lines>` [INFO] [stdout] --> src/entry_point/config_file/mod.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | let lines = cursor.lines().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `cursor.lines()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/entry_point/config_file/mod.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | let arg: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `arg` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 30 ~ [INFO] [stdout] 31 | let (unparsed_key, unparsed_value) = boxed_split.unwrap(); [INFO] [stdout] ... [INFO] [stdout] 40 | [INFO] [stdout] 41 ~ let arg: String = if prefix.chars().count() == 0 { [INFO] [stdout] 42 ~ [ [INFO] [stdout] 43 | SYMBOL.hyphen, [INFO] [stdout] ... [INFO] [stdout] 47 | &value [INFO] [stdout] 48 ~ ].join("") [INFO] [stdout] 49 | } else { [INFO] [stdout] 50 ~ [ [INFO] [stdout] 51 | SYMBOL.hyphen, [INFO] [stdout] ... [INFO] [stdout] 56 | SYMBOL.equals, [INFO] [stdout] 57 ~ &value].join("") [INFO] [stdout] 58 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/entry_point/config_file/mod.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 80 | let without_whitespaces = line.replace(SYMBOL.whitespace, SYMBOL.empty_string); [INFO] [stdout] | ------------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 81 | [INFO] [stdout] 82 | without_whitespaces [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 80 ~ [INFO] [stdout] 81 | [INFO] [stdout] 82 ~ line.replace(SYMBOL.whitespace, SYMBOL.empty_string) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `filepath` after checking its variant with `is_none` [INFO] [stdout] --> src/entry_point/config_file/mod.rs:92:16 [INFO] [stdout] | [INFO] [stdout] 89 | if filepath.is_none() { [INFO] [stdout] | --------------------- help: try: `if let Some() = filepath` [INFO] [stdout] ... [INFO] [stdout] 92 | path = filepath.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content` after checking its variant with `is_err` [INFO] [stdout] --> src/entry_point/config_file/mod.rs:109:23 [INFO] [stdout] | [INFO] [stdout] 104 | if boxed_content.is_err() { [INFO] [stdout] | ------------------------- help: try: `if let Ok() = boxed_content` [INFO] [stdout] ... [INFO] [stdout] 109 | let content = boxed_content.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/entry_point/config_file/mod.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | let path: &str; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `path` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 88 ~ [INFO] [stdout] 89 ~ let path: &str = if filepath.is_none() { [INFO] [stdout] 90 ~ "/rws.config.toml" [INFO] [stdout] 91 | } else { [INFO] [stdout] 92 ~ filepath.unwrap() [INFO] [stdout] 93 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_ip` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:14:18 [INFO] [stdout] | [INFO] [stdout] 11 | if boxed_ip.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = boxed_ip` [INFO] [stdout] ... [INFO] [stdout] 14 | boxed_ip.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_port` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:21:18 [INFO] [stdout] | [INFO] [stdout] 18 | if boxed_port.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = boxed_port` [INFO] [stdout] ... [INFO] [stdout] 21 | boxed_port.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_request_allocation_size` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 25 | if boxed_request_allocation_size.is_ok() { [INFO] [stdout] | ---------------------------------------- help: try: `if let Ok() = boxed_request_allocation_size` [INFO] [stdout] ... [INFO] [stdout] 28 | boxed_request_allocation_size.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_thread_count` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 32 | if boxed_thread_count.is_ok() { [INFO] [stdout] | ----------------------------- help: try: `if let Ok() = boxed_thread_count` [INFO] [stdout] ... [INFO] [stdout] 35 | boxed_thread_count.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_allow_all` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:42:18 [INFO] [stdout] | [INFO] [stdout] 39 | if boxed_cors_allow_all.is_ok() { [INFO] [stdout] | ------------------------------- help: try: `if let Ok() = boxed_cors_allow_all` [INFO] [stdout] ... [INFO] [stdout] 42 | boxed_cors_allow_all.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_allow_origins` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:49:18 [INFO] [stdout] | [INFO] [stdout] 46 | if boxed_cors_allow_origins.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_cors_allow_origins` [INFO] [stdout] ... [INFO] [stdout] 49 | boxed_cors_allow_origins.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_allow_methods` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:56:18 [INFO] [stdout] | [INFO] [stdout] 53 | if boxed_cors_allow_methods.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_cors_allow_methods` [INFO] [stdout] ... [INFO] [stdout] 56 | boxed_cors_allow_methods.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_allow_headers` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:63:18 [INFO] [stdout] | [INFO] [stdout] 60 | if boxed_cors_allow_headers.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_cors_allow_headers` [INFO] [stdout] ... [INFO] [stdout] 63 | boxed_cors_allow_headers.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_allow_credentials` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:70:18 [INFO] [stdout] | [INFO] [stdout] 67 | if boxed_cors_allow_credentials.is_ok() { [INFO] [stdout] | --------------------------------------- help: try: `if let Ok() = boxed_cors_allow_credentials` [INFO] [stdout] ... [INFO] [stdout] 70 | boxed_cors_allow_credentials.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_expose_headers` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:77:18 [INFO] [stdout] | [INFO] [stdout] 74 | if boxed_cors_expose_headers.is_ok() { [INFO] [stdout] | ------------------------------------ help: try: `if let Ok() = boxed_cors_expose_headers` [INFO] [stdout] ... [INFO] [stdout] 77 | boxed_cors_expose_headers.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_max_age` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:84:18 [INFO] [stdout] | [INFO] [stdout] 81 | if boxed_cors_max_age.is_ok() { [INFO] [stdout] | ----------------------------- help: try: `if let Ok() = boxed_cors_max_age` [INFO] [stdout] ... [INFO] [stdout] 84 | boxed_cors_max_age.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_ip` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/mod.rs:173:14 [INFO] [stdout] | [INFO] [stdout] 172 | if boxed_ip.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = boxed_ip` [INFO] [stdout] 173 | ip = boxed_ip.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_port` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/mod.rs:178:21 [INFO] [stdout] | [INFO] [stdout] 177 | if boxed_port.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = boxed_port` [INFO] [stdout] 178 | let _port = boxed_port.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_parse` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/mod.rs:181:20 [INFO] [stdout] | [INFO] [stdout] 180 | if boxed_parse.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_parse` [INFO] [stdout] 181 | port = boxed_parse.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_thread_count` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/mod.rs:192:29 [INFO] [stdout] | [INFO] [stdout] 191 | if boxed_thread_count.is_ok() { [INFO] [stdout] | ----------------------------- help: try: `if let Ok() = boxed_thread_count` [INFO] [stdout] 192 | let _thread_count = boxed_thread_count.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_parse` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/mod.rs:195:28 [INFO] [stdout] | [INFO] [stdout] 194 | if boxed_parse.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_parse` [INFO] [stdout] 195 | thread_count = boxed_parse.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_port` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/mod.rs:213:40 [INFO] [stdout] | [INFO] [stdout] 212 | if boxed_port.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = boxed_port` [INFO] [stdout] 213 | let _request_allocation_size = boxed_port.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_parse` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/mod.rs:216:39 [INFO] [stdout] | [INFO] [stdout] 215 | if boxed_parse.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_parse` [INFO] [stdout] 216 | request_allocation_size = boxed_parse.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/ext/date_time_ext/mod.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 11 | let nanos = DateTimeExt::_system_time_to_unix_nanos(now); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 12 | nanos [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 11 ~ [INFO] [stdout] 12 ~ DateTimeExt::_system_time_to_unix_nanos(now) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/ext/date_time_ext/mod.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 23 | let nanos = boxed_duration.unwrap().as_nanos(); [INFO] [stdout] | ----------------------------------------------- unnecessary `let` binding [INFO] [stdout] 24 | nanos [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 23 ~ [INFO] [stdout] 24 ~ boxed_duration.unwrap().as_nanos() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u128` is unnecessary [INFO] [stdout] --> src/ext/date_time_ext/mod.rs:19:25 [INFO] [stdout] | [INFO] [stdout] 19 | let nanos = 0 as u128; [INFO] [stdout] | ^^^^^^^^^ help: try: `0_u128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:22:25 [INFO] [stdout] | [INFO] [stdout] 22 | let is_inline = self.disposition_type.to_string() == DISPOSITION_TYPE.inline.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.disposition_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:22:62 [INFO] [stdout] | [INFO] [stdout] 22 | let is_inline = self.disposition_type.to_string() == DISPOSITION_TYPE.inline.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `DISPOSITION_TYPE.inline` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/header/content_disposition/mod.rs:35:71 [INFO] [stdout] | [INFO] [stdout] 35 | formatted = format!("{}: {}", Header::_CONTENT_DISPOSITION.to_string(), self.disposition_type); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:38:29 [INFO] [stdout] | [INFO] [stdout] 38 | let is_attachment = self.disposition_type.to_string() == DISPOSITION_TYPE.attachment.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.disposition_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:38:66 [INFO] [stdout] | [INFO] [stdout] 38 | let is_attachment = self.disposition_type.to_string() == DISPOSITION_TYPE.attachment.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `DISPOSITION_TYPE.attachment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/header/content_disposition/mod.rs:50:92 [INFO] [stdout] | [INFO] [stdout] 50 | ... formatted = format!("{}: {}; filename=\"{}\"", Header::_CONTENT_DISPOSITION.to_string(), self.disposition_type, file_name); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/header/content_disposition/mod.rs:52:75 [INFO] [stdout] | [INFO] [stdout] 52 | formatted = format!("{}: {}", Header::_CONTENT_DISPOSITION.to_string(), self.disposition_type); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:56:28 [INFO] [stdout] | [INFO] [stdout] 56 | let is_form_data = self.disposition_type.to_string() == DISPOSITION_TYPE.form_data.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.disposition_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:56:65 [INFO] [stdout] | [INFO] [stdout] 56 | let is_form_data = self.disposition_type.to_string() == DISPOSITION_TYPE.form_data.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `DISPOSITION_TYPE.form_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/header/content_disposition/mod.rs:70:105 [INFO] [stdout] | [INFO] [stdout] 70 | ... formatted = format!("{}: {}; name=\"{}\"; filename=\"{}\"", Header::_CONTENT_DISPOSITION.to_string(), self.disposition_type, f... [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/header/content_disposition/mod.rs:74:88 [INFO] [stdout] | [INFO] [stdout] 74 | ... formatted = format!("{}: {}; name=\"{}\"", Header::_CONTENT_DISPOSITION.to_string(), self.disposition_type, field_name); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_second_element` after checking its variant with `is_some` [INFO] [stdout] --> src/header/content_disposition/mod.rs:110:34 [INFO] [stdout] | [INFO] [stdout] 109 | if boxed_second_element.is_some() { [INFO] [stdout] | --------------------------------- help: try: `if let Some() = boxed_second_element` [INFO] [stdout] 110 | let second_element = boxed_second_element.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_third_element` after checking its variant with `is_some` [INFO] [stdout] --> src/header/content_disposition/mod.rs:130:34 [INFO] [stdout] | [INFO] [stdout] 129 | if boxed_third_element.is_some() { [INFO] [stdout] | -------------------------------- help: try: `if let Some() = boxed_third_element` [INFO] [stdout] 130 | let second_element = boxed_third_element.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/header/content_disposition/mod.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 93 | if parts.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parts.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `parts.get(0)` [INFO] [stdout] --> src/header/content_disposition/mod.rs:97:32 [INFO] [stdout] | [INFO] [stdout] 97 | let disposition_type = parts.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `parts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 98 | if disposition_type.to_string() != DISPOSITION_TYPE.inline.to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*disposition_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:98:44 [INFO] [stdout] | [INFO] [stdout] 98 | if disposition_type.to_string() != DISPOSITION_TYPE.inline.to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `DISPOSITION_TYPE.inline` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 99 | && disposition_type.to_string() != DISPOSITION_TYPE.attachment.to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*disposition_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:99:48 [INFO] [stdout] | [INFO] [stdout] 99 | && disposition_type.to_string() != DISPOSITION_TYPE.attachment.to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `DISPOSITION_TYPE.attachment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:100:16 [INFO] [stdout] | [INFO] [stdout] 100 | && disposition_type.to_string() != DISPOSITION_TYPE.form_data.to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*disposition_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:100:48 [INFO] [stdout] | [INFO] [stdout] 100 | && disposition_type.to_string() != DISPOSITION_TYPE.form_data.to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `DISPOSITION_TYPE.form_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 159 | if disposition_type.to_string() == DISPOSITION_TYPE.form_data.to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*disposition_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:159:44 [INFO] [stdout] | [INFO] [stdout] 159 | if disposition_type.to_string() == DISPOSITION_TYPE.form_data.to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `DISPOSITION_TYPE.form_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/header/content_disposition/mod.rs:160:16 [INFO] [stdout] | [INFO] [stdout] 160 | && content_disposition.field_name == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `content_disposition.field_name.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/header/mod.rs:149:63 [INFO] [stdout] | [INFO] [stdout] 149 | let cors_header_list: Vec
= Cors::get_headers(&request); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/language/mod.rs:253:9 [INFO] [stdout] | [INFO] [stdout] 253 | / let mut language_list : Vec = vec![]; [INFO] [stdout] 254 | | [INFO] [stdout] 255 | | language_list.push(Language::AFRIKAANS); [INFO] [stdout] 256 | | language_list.push(Language::AFRIKAANS_SOUTH_AFRICA); [INFO] [stdout] ... | [INFO] [stdout] 492 | | language_list.push(Language::ZULU); [INFO] [stdout] 493 | | language_list.push(Language::ZULU_SOUTH_AFRICA); [INFO] [stdout] | |________________________________________________________^ help: consider using the `vec![]` macro: `let language_list: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mime_type/mod.rs:204:12 [INFO] [stdout] | [INFO] [stdout] 204 | if !boxed_extension.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_extension.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mime_type/mod.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 217 | if !boxed_extension.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_extension.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mime_type/mod.rs:250:12 [INFO] [stdout] | [INFO] [stdout] 250 | if !boxed_extension.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_extension.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mime_type/mod.rs:278:12 [INFO] [stdout] | [INFO] [stdout] 278 | if !boxed_extension.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_extension.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mime_type/mod.rs:291:12 [INFO] [stdout] | [INFO] [stdout] 291 | if !boxed_extension.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_extension.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mime_type/mod.rs:334:12 [INFO] [stdout] | [INFO] [stdout] 334 | if !boxed_extension.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_extension.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mime_type/mod.rs:347:12 [INFO] [stdout] | [INFO] [stdout] 347 | if !boxed_extension.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_extension.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mime_type/mod.rs:360:12 [INFO] [stdout] | [INFO] [stdout] 360 | if !boxed_extension.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_extension.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mime_type/mod.rs:474:12 [INFO] [stdout] | [INFO] [stdout] 474 | if !boxed_extension.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_extension.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_extension` after checking its variant with `is_none` [INFO] [stdout] --> src/mime_type/mod.rs:206:29 [INFO] [stdout] | [INFO] [stdout] 204 | if !boxed_extension.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 205 | let html_suffixes = vec![MimeType::HTML_SUFFIX, MimeType::HTM_SUFFIX]; [INFO] [stdout] 206 | let extension = boxed_extension.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_extension` after checking its variant with `is_none` [INFO] [stdout] --> src/mime_type/mod.rs:219:29 [INFO] [stdout] | [INFO] [stdout] 217 | if !boxed_extension.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 218 | let js_suffixes = vec![MimeType::MJS_SUFFIX, MimeType::JS_SUFFIX]; [INFO] [stdout] 219 | let extension = boxed_extension.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_extension` after checking its variant with `is_none` [INFO] [stdout] --> src/mime_type/mod.rs:252:29 [INFO] [stdout] | [INFO] [stdout] 250 | if !boxed_extension.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 251 | let jpeg_suffixes = vec![MimeType::JPG... [INFO] [stdout] 252 | let extension = boxed_extension.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_extension` after checking its variant with `is_none` [INFO] [stdout] --> src/mime_type/mod.rs:280:29 [INFO] [stdout] | [INFO] [stdout] 278 | if !boxed_extension.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 279 | let ico_suffixes = vec![MimeType::ICO_SUFFIX, MimeType::CUR_SUFFIX]; [INFO] [stdout] 280 | let extension = boxed_extension.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_extension` after checking its variant with `is_none` [INFO] [stdout] --> src/mime_type/mod.rs:293:29 [INFO] [stdout] | [INFO] [stdout] 291 | if !boxed_extension.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 292 | let tiff_suffixes = vec![MimeType::TIF_SUFFIX, MimeType::TIFF_SUFFIX]; [INFO] [stdout] 293 | let extension = boxed_extension.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_extension` after checking its variant with `is_none` [INFO] [stdout] --> src/mime_type/mod.rs:336:29 [INFO] [stdout] | [INFO] [stdout] 334 | if !boxed_extension.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 335 | let mpeg_suffixes = vec![MimeType::MPG_SUFFIX, MimeType::MPEG_SUFFIX]; [INFO] [stdout] 336 | let extension = boxed_extension.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_extension` after checking its variant with `is_none` [INFO] [stdout] --> src/mime_type/mod.rs:349:29 [INFO] [stdout] | [INFO] [stdout] 347 | if !boxed_extension.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 348 | let mp4_suffixes = vec![MimeType::MP4_SUFFIX, MimeType::M4V_SUFFIX, MimeType::M4P_SUFFIX]; [INFO] [stdout] 349 | let extension = boxed_extension.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_extension` after checking its variant with `is_none` [INFO] [stdout] --> src/mime_type/mod.rs:362:29 [INFO] [stdout] | [INFO] [stdout] 360 | if !boxed_extension.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 361 | let ogg_suffixes = vec![MimeType::OGG_SUFFIX, MimeType::OGV_SUFFIX]; [INFO] [stdout] 362 | let extension = boxed_extension.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_extension` after checking its variant with `is_none` [INFO] [stdout] --> src/mime_type/mod.rs:476:29 [INFO] [stdout] | [INFO] [stdout] 474 | if !boxed_extension.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 475 | let midi_suffixes = vec![MimeType::MIDI_SUFFIX, MimeType::MID_SUFFIX]; [INFO] [stdout] 476 | let extension = boxed_extension.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mime_type/mod.rs:645:9 [INFO] [stdout] | [INFO] [stdout] 645 | return MimeType::APPLICATION_OCTET_STREAM.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 645 - return MimeType::APPLICATION_OCTET_STREAM.to_string(); [INFO] [stdout] 645 + MimeType::APPLICATION_OCTET_STREAM.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_start` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:87:35 [INFO] [stdout] | [INFO] [stdout] 86 | if boxed_start.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_start` [INFO] [stdout] 87 | range.start = boxed_start.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_end` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:100:33 [INFO] [stdout] | [INFO] [stdout] 99 | if boxed_end.is_ok() { [INFO] [stdout] | -------------------- help: try: `if let Ok() = boxed_end` [INFO] [stdout] 100 | range.end = boxed_end.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:188:29 [INFO] [stdout] | [INFO] [stdout] 187 | if boxed_range.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_range` [INFO] [stdout] 188 | let range = boxed_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_read` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:193:32 [INFO] [stdout] | [INFO] [stdout] 190 | if boxed_read.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = boxed_read` [INFO] [stdout] ... [INFO] [stdout] 193 | let body = boxed_read.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_split` after checking its variant with `is_some` [INFO] [stdout] --> src/range/mod.rs:289:45 [INFO] [stdout] | [INFO] [stdout] 288 | if boxed_split.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = boxed_split` [INFO] [stdout] 289 | let (_filename, path) = boxed_split.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range_list` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:299:38 [INFO] [stdout] | [INFO] [stdout] 298 | if boxed_content_range_list.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_content_range_list` [INFO] [stdout] 299 | content_range_list = boxed_content_range_list.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:351:42 [INFO] [stdout] | [INFO] [stdout] 350 | if boxed_result.is_ok() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = boxed_result` [INFO] [stdout] 351 | let (start, end, size) = boxed_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:404:16 [INFO] [stdout] | [INFO] [stdout] 403 | return if boxed_result.is_ok() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = boxed_result` [INFO] [stdout] 404 | Ok(boxed_result.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/range/mod.rs:403:9 [INFO] [stdout] | [INFO] [stdout] 403 | / return if boxed_result.is_ok() { [INFO] [stdout] 404 | | Ok(boxed_result.unwrap()) [INFO] [stdout] 405 | | } else { [INFO] [stdout] 406 | | let error = boxed_result.err().unwrap(); [INFO] [stdout] 407 | | Err(error) [INFO] [stdout] 408 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 403 ~ if boxed_result.is_ok() { [INFO] [stdout] 404 + Ok(boxed_result.unwrap()) [INFO] [stdout] 405 + } else { [INFO] [stdout] 406 + let error = boxed_result.err().unwrap(); [INFO] [stdout] 407 + Err(error) [INFO] [stdout] 408 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:312:35 [INFO] [stdout] | [INFO] [stdout] 312 | let new_line_char_found = buffer.len() != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:327:43 [INFO] [stdout] | [INFO] [stdout] 327 | let content_range_is_not_parsed = content_range.body.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content_range.body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:335:42 [INFO] [stdout] | [INFO] [stdout] 335 | let content_type_is_not_parsed = content_range.content_type.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content_range.content_type.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:345:43 [INFO] [stdout] | [INFO] [stdout] 345 | let content_range_is_not_parsed = content_range.size.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content_range.size.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:366:16 [INFO] [stdout] | [INFO] [stdout] 366 | if string.trim().len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!string.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:375:39 [INFO] [stdout] | [INFO] [stdout] 375 | let content_range_is_parsed = content_range.size.len() != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content_range.size.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:376:38 [INFO] [stdout] | [INFO] [stdout] 376 | let content_type_is_parsed = content_range.content_type.len() != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content_range.content_type.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/range/mod.rs:415:9 [INFO] [stdout] | [INFO] [stdout] 415 | let start : i64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 442 | start = boxed_start.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `start` here [INFO] [stdout] | [INFO] [stdout] 415 ~ [INFO] [stdout] 416 | let end : i64; [INFO] [stdout] ... [INFO] [stdout] 441 | [INFO] [stdout] 442 ~ let start : i64 = boxed_start.unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/range/mod.rs:416:9 [INFO] [stdout] | [INFO] [stdout] 416 | let end : i64; [INFO] [stdout] | ^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 457 | end = boxed_end.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `end` here [INFO] [stdout] | [INFO] [stdout] 416 ~ [INFO] [stdout] 417 | let size : i64; [INFO] [stdout] ... [INFO] [stdout] 456 | [INFO] [stdout] 457 ~ let end : i64 = boxed_end.unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/range/mod.rs:417:9 [INFO] [stdout] | [INFO] [stdout] 417 | let size : i64; [INFO] [stdout] | ^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 464 | size = boxed_size.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `size` here [INFO] [stdout] | [INFO] [stdout] 417 ~ [INFO] [stdout] 418 | [INFO] [stdout] ... [INFO] [stdout] 463 | [INFO] [stdout] 464 ~ let size : i64 = boxed_size.unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/range/mod.rs:511:9 [INFO] [stdout] | [INFO] [stdout] 503 | / let content_range = ContentRange { [INFO] [stdout] 504 | | unit: Range::BYTES.to_string(), [INFO] [stdout] 505 | | range: Range { start: 0, end: length }, [INFO] [stdout] 506 | | size: length.to_string(), [INFO] [stdout] 507 | | body, [INFO] [stdout] 508 | | content_type: mime_type [INFO] [stdout] 509 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 510 | [INFO] [stdout] 511 | content_range [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 503 ~ [INFO] [stdout] 504 | [INFO] [stdout] 505 ~ ContentRange { [INFO] [stdout] 506 + unit: Range::BYTES.to_string(), [INFO] [stdout] 507 + range: Range { start: 0, end: length }, [INFO] [stdout] 508 + size: length.to_string(), [INFO] [stdout] 509 + body, [INFO] [stdout] 510 + content_type: mime_type [INFO] [stdout] 511 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/range/mod.rs:515:9 [INFO] [stdout] | [INFO] [stdout] 515 | let body: Vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 522 | body = boxed_file.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `body` here [INFO] [stdout] | [INFO] [stdout] 515 ~ [INFO] [stdout] 516 | let boxed_file = FileExt::read_file(filepath); [INFO] [stdout] ... [INFO] [stdout] 521 | [INFO] [stdout] 522 ~ let body: Vec = boxed_file.unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:614:42 [INFO] [stdout] | [INFO] [stdout] 613 | if boxed_result.is_ok() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = boxed_result` [INFO] [stdout] 614 | let (start, end, size) = boxed_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:689:16 [INFO] [stdout] | [INFO] [stdout] 688 | return if boxed_result.is_ok() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = boxed_result` [INFO] [stdout] 689 | Ok(boxed_result.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/range/mod.rs:688:9 [INFO] [stdout] | [INFO] [stdout] 688 | / return if boxed_result.is_ok() { [INFO] [stdout] 689 | | Ok(boxed_result.unwrap()) [INFO] [stdout] 690 | | } else { [INFO] [stdout] 691 | | let error = boxed_result.err().unwrap(); [INFO] [stdout] 692 | | Err(error) [INFO] [stdout] 693 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 688 ~ if boxed_result.is_ok() { [INFO] [stdout] 689 + Ok(boxed_result.unwrap()) [INFO] [stdout] 690 + } else { [INFO] [stdout] 691 + let error = boxed_result.err().unwrap(); [INFO] [stdout] 692 + Err(error) [INFO] [stdout] 693 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:540:35 [INFO] [stdout] | [INFO] [stdout] 540 | let new_line_char_found = buffer.len() != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:562:43 [INFO] [stdout] | [INFO] [stdout] 562 | let content_range_is_not_parsed = content_range.body.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content_range.body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:581:42 [INFO] [stdout] | [INFO] [stdout] 581 | let content_type_is_not_parsed = content_range.content_type.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content_range.content_type.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:608:43 [INFO] [stdout] | [INFO] [stdout] 608 | let content_range_is_not_parsed = content_range.size.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content_range.size.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:640:16 [INFO] [stdout] | [INFO] [stdout] 640 | if string.trim().len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!string.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:660:39 [INFO] [stdout] | [INFO] [stdout] 660 | let content_range_is_parsed = content_range.size.len() != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content_range.size.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:661:38 [INFO] [stdout] | [INFO] [stdout] 661 | let content_type_is_parsed = content_range.content_type.len() != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content_range.content_type.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:816:42 [INFO] [stdout] | [INFO] [stdout] 815 | if boxed_result.is_ok() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = boxed_result` [INFO] [stdout] 816 | let (start, end, size) = boxed_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:904:16 [INFO] [stdout] | [INFO] [stdout] 903 | return if boxed_result.is_ok() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = boxed_result` [INFO] [stdout] 904 | Ok(boxed_result.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/range/mod.rs:903:9 [INFO] [stdout] | [INFO] [stdout] 903 | / return if boxed_result.is_ok() { [INFO] [stdout] 904 | | Ok(boxed_result.unwrap()) [INFO] [stdout] 905 | | } else { [INFO] [stdout] 906 | | let error = boxed_result.err().unwrap(); [INFO] [stdout] 907 | | Err(error) [INFO] [stdout] 908 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 903 ~ if boxed_result.is_ok() { [INFO] [stdout] 904 + Ok(boxed_result.unwrap()) [INFO] [stdout] 905 + } else { [INFO] [stdout] 906 + let error = boxed_result.err().unwrap(); [INFO] [stdout] 907 + Err(error) [INFO] [stdout] 908 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/range/mod.rs:735:9 [INFO] [stdout] | [INFO] [stdout] 735 | bytes_read = bytes_read + bytes_offset as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += bytes_offset as i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:741:35 [INFO] [stdout] | [INFO] [stdout] 741 | let new_line_char_found = buffer.len() != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:757:43 [INFO] [stdout] | [INFO] [stdout] 757 | let content_range_is_not_parsed = content_range.body.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content_range.body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:759:12 [INFO] [stdout] | [INFO] [stdout] 759 | if string.trim().len() != 0 && !is_opening_boundary_read && !string.contains(boundary.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!string.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:783:42 [INFO] [stdout] | [INFO] [stdout] 783 | let content_type_is_not_parsed = content_range.content_type.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content_range.content_type.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:810:43 [INFO] [stdout] | [INFO] [stdout] 810 | let content_range_is_not_parsed = content_range.size.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content_range.size.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:842:16 [INFO] [stdout] | [INFO] [stdout] 842 | if string.trim().len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!string.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:848:39 [INFO] [stdout] | [INFO] [stdout] 848 | let content_range_is_parsed = content_range.size.len() != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content_range.size.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:849:38 [INFO] [stdout] | [INFO] [stdout] 849 | let content_type_is_parsed = content_range.content_type.len() != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content_range.content_type.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/range/mod.rs:863:17 [INFO] [stdout] | [INFO] [stdout] 863 | bytes_read = bytes_read + _bytes_offset as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += _bytes_offset as i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:228:9 [INFO] [stdout] | [INFO] [stdout] 228 | / return match Request::cursor_read(&mut cursor, iteration_number, &mut request, content_length) { [INFO] [stdout] 229 | | Ok(_) => { [INFO] [stdout] 230 | | Ok(request) [INFO] [stdout] ... | [INFO] [stdout] 235 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 228 ~ match Request::cursor_read(&mut cursor, iteration_number, &mut request, content_length) { [INFO] [stdout] 229 + Ok(_) => { [INFO] [stdout] 230 + Ok(request) [INFO] [stdout] 231 + } [INFO] [stdout] 232 + Err(error_message) => { [INFO] [stdout] 233 + Err(error_message) [INFO] [stdout] 234 + } [INFO] [stdout] 235 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/request/mod.rs:298:39 [INFO] [stdout] | [INFO] [stdout] 298 | let current_string_is_empty = string.trim().len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `string.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/request/mod.rs:285:108 [INFO] [stdout] | [INFO] [stdout] 285 | ...&mut Request, mut content_length: usize) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_content_length` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/request/mod.rs:328:86 [INFO] [stdout] | [INFO] [stdout] 328 | let boxed_read = Request::cursor_read(cursor, iteration_number, request, content_length); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:394:9 [INFO] [stdout] | [INFO] [stdout] 394 | / return if is_head || is_options { [INFO] [stdout] 395 | | response_without_body.into_bytes() [INFO] [stdout] 396 | | } else { [INFO] [stdout] 397 | | [response_without_body.into_bytes(), body].concat() [INFO] [stdout] 398 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 394 ~ if is_head || is_options { [INFO] [stdout] 395 + response_without_body.into_bytes() [INFO] [stdout] 396 + } else { [INFO] [stdout] 397 + [response_without_body.into_bytes(), body].concat() [INFO] [stdout] 398 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:418:9 [INFO] [stdout] | [INFO] [stdout] 418 | return response; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 418 - return response; [INFO] [stdout] 418 + response [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:471:9 [INFO] [stdout] | [INFO] [stdout] 471 | return Ok((http_version.to_string(), status_code_i16, reason_phrase.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 471 - return Ok((http_version.to_string(), status_code_i16, reason_phrase.to_string())) [INFO] [stdout] 471 + Ok((http_version.to_string(), status_code_i16, reason_phrase.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:453:21 [INFO] [stdout] | [INFO] [stdout] 453 | return x.status_code == &status_code_i16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 453 - return x.status_code == &status_code_i16 [INFO] [stdout] 453 + x.status_code == &status_code_i16 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_value` after checking its variant with `is_ok` [INFO] [stdout] --> src/response/mod.rs:534:34 [INFO] [stdout] | [INFO] [stdout] 533 | if boxed_value.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_value` [INFO] [stdout] 534 | range_list = boxed_value.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/response/mod.rs:505:39 [INFO] [stdout] | [INFO] [stdout] 505 | let current_string_is_empty = string.trim().len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `string.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/response/mod.rs:524:80 [INFO] [stdout] | [INFO] [stdout] 524 | let is_multipart = Response::_is_multipart_byteranges_content_type(&content_type); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `content_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `eprintln!` args [INFO] [stdout] --> src/response/mod.rs:556:63 [INFO] [stdout] | [INFO] [stdout] 556 | eprintln!("error reading file: {}", reason.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/response/mod.rs:491:13 [INFO] [stdout] | [INFO] [stdout] 491 | mut content_length: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_content_length` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/response/mod.rs:575:90 [INFO] [stdout] | [INFO] [stdout] 575 | Response::_parse_raw_response_via_cursor(cursor, iteration_number, response, content_length); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/response/mod.rs:587:9 [INFO] [stdout] | [INFO] [stdout] 586 | let is_multipart_byteranges = content_type.value.starts_with(&multipart_byteranges); [INFO] [stdout] | ------------------------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 587 | is_multipart_byteranges [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 586 ~ [INFO] [stdout] 587 ~ content_type.value.starts_with(&multipart_byteranges) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_header_list` after checking its variant with `is_some` [INFO] [stdout] --> src/response/mod.rs:598:27 [INFO] [stdout] | [INFO] [stdout] 597 | if boxed_header_list.is_some() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = boxed_header_list` [INFO] [stdout] 598 | header_list = boxed_header_list.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range_list` after checking its variant with `is_some` [INFO] [stdout] --> src/response/mod.rs:603:34 [INFO] [stdout] | [INFO] [stdout] 602 | if boxed_content_range_list.is_some() { [INFO] [stdout] | ------------------------------------- help: try: `if let Some() = boxed_content_range_list` [INFO] [stdout] 603 | content_range_list = boxed_content_range_list.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/response/mod.rs:614:9 [INFO] [stdout] | [INFO] [stdout] 606 | / let response = Response { [INFO] [stdout] 607 | | http_version: VERSION.http_1_1.to_string(), [INFO] [stdout] 608 | | status_code: *status_code_reason_phrase.status_code, [INFO] [stdout] 609 | | reason_phrase: status_code_reason_phrase.reason_phrase.to_string(), [INFO] [stdout] 610 | | headers: header_list, [INFO] [stdout] 611 | | content_range_list [INFO] [stdout] 612 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 613 | [INFO] [stdout] 614 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 606 ~ [INFO] [stdout] 607 | [INFO] [stdout] 608 ~ Response { [INFO] [stdout] 609 + http_version: VERSION.http_1_1.to_string(), [INFO] [stdout] 610 + status_code: *status_code_reason_phrase.status_code, [INFO] [stdout] 611 + reason_phrase: status_code_reason_phrase.reason_phrase.to_string(), [INFO] [stdout] 612 + headers: header_list, [INFO] [stdout] 613 + content_range_list [INFO] [stdout] 614 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:725:9 [INFO] [stdout] | [INFO] [stdout] 725 | return Ok(response); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 725 - return Ok(response); [INFO] [stdout] 725 + Ok(response) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:862:13 [INFO] [stdout] | [INFO] [stdout] 862 | ... return Response::parse_raw_response_via_cursor(cursor, iteration_number, response, content_length, total_bytes, bytes_read ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 862 - return Response::parse_raw_response_via_cursor(cursor, iteration_number, response, content_length, total_bytes, bytes_read ); [INFO] [stdout] 862 + Response::parse_raw_response_via_cursor(cursor, iteration_number, response, content_length, total_bytes, bytes_read ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:864:13 [INFO] [stdout] | [INFO] [stdout] 864 | return Err("unable to parse".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 864 - return Err("unable to parse".to_string()); [INFO] [stdout] 864 + Err("unable to parse".to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/response/mod.rs:743:9 [INFO] [stdout] | [INFO] [stdout] 743 | bytes_read = bytes_read + bytes_offset as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += bytes_offset as i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/response/mod.rs:757:39 [INFO] [stdout] | [INFO] [stdout] 757 | let current_string_is_empty = string.trim().len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `string.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/response/mod.rs:782:80 [INFO] [stdout] | [INFO] [stdout] 782 | is_multipart = Response::_is_multipart_byteranges_content_type(&content_type_header); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `content_type_header` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/response/mod.rs:822:17 [INFO] [stdout] | [INFO] [stdout] 822 | bytes_read = bytes_read + bytes_offset as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += bytes_offset as i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/response/mod.rs:732:13 [INFO] [stdout] | [INFO] [stdout] 732 | mut content_length: usize, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_content_length` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/response/mod.rs:862:96 [INFO] [stdout] | [INFO] [stdout] 862 | ... return Response::parse_raw_response_via_cursor(cursor, iteration_number, response, content_length, total_bytes, bytes_read ); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/response/mod.rs:875:73 [INFO] [stdout] | [INFO] [stdout] 875 | let header_value = StringExt::truncate_new_line_carriage_return(&raw_header_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `raw_header_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/mod.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | return response; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return response; [INFO] [stdout] 104 + response [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_local_addr` after checking its variant with `is_ok` [INFO] [stdout] --> src/server/mod.rs:248:42 [INFO] [stdout] | [INFO] [stdout] 247 | if boxed_local_addr.is_ok() { [INFO] [stdout] | --------------------------- help: try: `if let Ok() = boxed_local_addr` [INFO] [stdout] 248 | print!("local addr: {}", boxed_local_addr.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `print!` args [INFO] [stdout] --> src/server/mod.rs:260:50 [INFO] [stdout] | [INFO] [stdout] 260 | print!(", peer addr: {}\n", peer_addr.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/server/mod.rs:260:13 [INFO] [stdout] | [INFO] [stdout] 260 | print!(", peer addr: {}\n", peer_addr.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 260 - print!(", peer addr: {}\n", peer_addr.to_string()); [INFO] [stdout] 260 + println!(", peer addr: {}", peer_addr.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_send` after checking its variant with `is_err` [INFO] [stdout] --> src/thread_pool/mod.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 39 | if boxed_send.is_err() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_send` [INFO] [stdout] ... [INFO] [stdout] 42 | boxed_send.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_lock` after checking its variant with `is_err` [INFO] [stdout] --> src/thread_pool/mod.rs:63:33 [INFO] [stdout] | [INFO] [stdout] 60 | if boxed_lock.is_err() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_lock` [INFO] [stdout] ... [INFO] [stdout] 63 | let boxed_job = boxed_lock.unwrap().recv(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_job` after checking its variant with `is_err` [INFO] [stdout] --> src/thread_pool/mod.rs:67:31 [INFO] [stdout] | [INFO] [stdout] 64 | if boxed_job.is_err() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = boxed_job` [INFO] [stdout] ... [INFO] [stdout] 67 | let job = boxed_job.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_parse` after checking its variant with `is_ok` [INFO] [stdout] --> src/log/mod.rs:46:41 [INFO] [stdout] | [INFO] [stdout] 45 | if boxed_parse.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_parse` [INFO] [stdout] 46 | response_body_length += boxed_parse.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/log/mod.rs:17:16 [INFO] [stdout] | [INFO] [stdout] 17 | if &header.name.chars().count() > &0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 17 - if &header.name.chars().count() > &0 { [INFO] [stdout] 17 + if header.name.chars().count() > 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/log/mod.rs:30:16 [INFO] [stdout] | [INFO] [stdout] 30 | if &header.name.chars().count() > &0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 30 - if &header.name.chars().count() > &0 { [INFO] [stdout] 30 + if header.name.chars().count() > 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_sequence` after checking its variant with `is_some` [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:173:42 [INFO] [stdout] | [INFO] [stdout] 171 | if boxed_sequence.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = boxed_sequence` [INFO] [stdout] 172 | current_string_is_boundary = true; [INFO] [stdout] 173 | _boundary_position = boxed_sequence.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | bytes_read = bytes_read + bytes_offset as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += bytes_offset as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | bytes_read = bytes_read + bytes_offset as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += bytes_offset as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:111:39 [INFO] [stdout] | [INFO] [stdout] 111 | current_string_is_empty = string.trim().len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `string.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i128` -> `i128`) [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:122:30 [INFO] [stdout] | [INFO] [stdout] 122 | if bytes_read == total_bytes as i128 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `total_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:128:43 [INFO] [stdout] | [INFO] [stdout] 128 | if current_string_is_empty && part.headers.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `part.headers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:164:13 [INFO] [stdout] | [INFO] [stdout] 164 | bytes_read = bytes_read + bytes_offset as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += bytes_offset as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i128` -> `i128`) [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:183:57 [INFO] [stdout] | [INFO] [stdout] 183 | if !current_string_is_boundary && bytes_read == total_bytes as i128 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `total_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i128` -> `i128`) [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:215:26 [INFO] [stdout] | [INFO] [stdout] 215 | if bytes_read == total_bytes as i128 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `total_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:239:12 [INFO] [stdout] | [INFO] [stdout] 239 | if part.headers.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `part.headers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:246:96 [INFO] [stdout] | [INFO] [stdout] 246 | let formatted = format!("{}{}", header.as_string(), SYMBOL.new_line_carriage_return.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:264:12 [INFO] [stdout] | [INFO] [stdout] 264 | if part_list.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `part_list.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.f64` after checking its variant with `is_some` [INFO] [stdout] --> src/json/property/mod.rs:50:23 [INFO] [stdout] | [INFO] [stdout] 49 | if self.f64.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = self.f64` [INFO] [stdout] 50 | let f64 = self.f64.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.i128` after checking its variant with `is_some` [INFO] [stdout] --> src/json/property/mod.rs:56:29 [INFO] [stdout] | [INFO] [stdout] 55 | if self.i128.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = self.i128` [INFO] [stdout] 56 | let formatted = self.i128.unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.string` after checking its variant with `is_some` [INFO] [stdout] --> src/json/property/mod.rs:61:29 [INFO] [stdout] | [INFO] [stdout] 60 | if self.string.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self.string` [INFO] [stdout] 61 | let formatted = self.string.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.array` after checking its variant with `is_some` [INFO] [stdout] --> src/json/property/mod.rs:66:29 [INFO] [stdout] | [INFO] [stdout] 65 | if self.array.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = &self.array` [INFO] [stdout] 66 | let formatted = self.array.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.object` after checking its variant with `is_some` [INFO] [stdout] --> src/json/property/mod.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 74 | if self.object.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self.object` [INFO] [stdout] 75 | let formatted = self.object.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.bool` after checking its variant with `is_some` [INFO] [stdout] --> src/json/property/mod.rs:80:29 [INFO] [stdout] | [INFO] [stdout] 79 | if self.bool.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = &self.bool` [INFO] [stdout] 80 | let formatted = self.bool.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_f64_parse` after checking its variant with `is_err` [INFO] [stdout] --> src/json/property/mod.rs:149:31 [INFO] [stdout] | [INFO] [stdout] 143 | if boxed_f64_parse.is_err() { [INFO] [stdout] | --------------------------- help: try: `if let Ok() = boxed_f64_parse` [INFO] [stdout] ... [INFO] [stdout] 149 | let f64 = boxed_f64_parse.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_i128_parse` after checking its variant with `is_err` [INFO] [stdout] --> src/json/property/mod.rs:155:28 [INFO] [stdout] | [INFO] [stdout] 141 | if boxed_i128_parse.is_err() { [INFO] [stdout] | ---------------------------- help: try: `if let Ok() = boxed_i128_parse` [INFO] [stdout] ... [INFO] [stdout] 155 | let i128 = boxed_i128_parse.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/boolean/mod.rs:26:43 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn to_json_from_list_bool(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 26 - pub fn to_json_from_list_bool(items : &Vec) -> Result { [INFO] [stdout] 26 + pub fn to_json_from_list_bool(items : &[bool]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `starts_with` method [INFO] [stdout] --> src/json/array/string/mod.rs:17:46 [INFO] [stdout] | [INFO] [stdout] 17 | let starts_with_quotation_mark = string.chars().next().unwrap() == '"'; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `string.starts_with('\"')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stdout] = note: `#[warn(clippy::chars_next_cmp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `ends_with` method [INFO] [stdout] --> src/json/array/string/mod.rs:18:44 [INFO] [stdout] | [INFO] [stdout] 18 | let ends_with_quotation_mark = string.chars().last().unwrap() == '"'; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `string.ends_with('\"')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stdout] = note: `#[warn(clippy::chars_last_cmp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/json/array/string/mod.rs:23:63 [INFO] [stdout] | [INFO] [stdout] 23 | let message = format!("not a string: {}", item.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/string/mod.rs:31:45 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn to_json_from_list_string(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 31 - pub fn to_json_from_list_string(items : &Vec) -> Result { [INFO] [stdout] 31 + pub fn to_json_from_list_string(items : &[String]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/float/mod.rs:30:42 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn to_json_from_list_f64(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 30 - pub fn to_json_from_list_f64(items : &Vec) -> Result { [INFO] [stdout] 30 + pub fn to_json_from_list_f64(items : &[f64]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/float/mod.rs:64:42 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn to_json_from_list_f32(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 64 - pub fn to_json_from_list_f32(items : &Vec) -> Result { [INFO] [stdout] 64 + pub fn to_json_from_list_f32(items : &[f32]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/integer/mod.rs:63:43 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn to_json_from_list_i128(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 63 - pub fn to_json_from_list_i128(items : &Vec) -> Result { [INFO] [stdout] 63 + pub fn to_json_from_list_i128(items : &[i128]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/integer/mod.rs:93:42 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn to_json_from_list_i64(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 93 - pub fn to_json_from_list_i64(items : &Vec) -> Result { [INFO] [stdout] 93 + pub fn to_json_from_list_i64(items : &[i64]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/integer/mod.rs:123:42 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn to_json_from_list_i32(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 123 - pub fn to_json_from_list_i32(items : &Vec) -> Result { [INFO] [stdout] 123 + pub fn to_json_from_list_i32(items : &[i32]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/integer/mod.rs:153:42 [INFO] [stdout] | [INFO] [stdout] 153 | pub fn to_json_from_list_i16(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 153 - pub fn to_json_from_list_i16(items : &Vec) -> Result { [INFO] [stdout] 153 + pub fn to_json_from_list_i16(items : &[i16]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/integer/mod.rs:183:41 [INFO] [stdout] | [INFO] [stdout] 183 | pub fn to_json_from_list_i8(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 183 - pub fn to_json_from_list_i8(items : &Vec) -> Result { [INFO] [stdout] 183 + pub fn to_json_from_list_i8(items : &[i8]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/integer/mod.rs:213:43 [INFO] [stdout] | [INFO] [stdout] 213 | pub fn to_json_from_list_u128(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 213 - pub fn to_json_from_list_u128(items : &Vec) -> Result { [INFO] [stdout] 213 + pub fn to_json_from_list_u128(items : &[u128]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/integer/mod.rs:243:42 [INFO] [stdout] | [INFO] [stdout] 243 | pub fn to_json_from_list_u64(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 243 - pub fn to_json_from_list_u64(items : &Vec) -> Result { [INFO] [stdout] 243 + pub fn to_json_from_list_u64(items : &[u64]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/integer/mod.rs:273:42 [INFO] [stdout] | [INFO] [stdout] 273 | pub fn to_json_from_list_u32(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 273 - pub fn to_json_from_list_u32(items : &Vec) -> Result { [INFO] [stdout] 273 + pub fn to_json_from_list_u32(items : &[u32]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/integer/mod.rs:303:42 [INFO] [stdout] | [INFO] [stdout] 303 | pub fn to_json_from_list_u16(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 303 - pub fn to_json_from_list_u16(items : &Vec) -> Result { [INFO] [stdout] 303 + pub fn to_json_from_list_u16(items : &[u16]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/integer/mod.rs:333:41 [INFO] [stdout] | [INFO] [stdout] 333 | pub fn to_json_from_list_u8(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 333 - pub fn to_json_from_list_u8(items : &Vec) -> Result { [INFO] [stdout] 333 + pub fn to_json_from_list_u8(items : &[u8]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/json/array/object/mod.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn new() -> T { [INFO] [stdout] 17 | | T::new() [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/object/mod.rs:22:28 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn to_json(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 22 - pub fn to_json(items : &Vec) -> Result { [INFO] [stdout] 22 + pub fn to_json(items : &[T]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/json/array/mod.rs:33:91 [INFO] [stdout] | [INFO] [stdout] 33 | let message = format!("not proper end of the json array: {}", _json_string.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/array/mod.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | bytes_read = bytes_read + length as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += length as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/json/array/mod.rs:49:93 [INFO] [stdout] | [INFO] [stdout] 49 | let message = format!("not proper start of the json array: {}", _json_string.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/array/mod.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | bytes_read = bytes_read + length as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += length as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/array/mod.rs:103:25 [INFO] [stdout] | [INFO] [stdout] 103 | bytes_read = bytes_read + length as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += length as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/array/mod.rs:125:29 [INFO] [stdout] | [INFO] [stdout] 125 | ... bytes_read = bytes_read + length as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += length as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/array/mod.rs:156:21 [INFO] [stdout] | [INFO] [stdout] 156 | bytes_read = bytes_read + length as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += length as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/array/mod.rs:179:21 [INFO] [stdout] | [INFO] [stdout] 179 | bytes_read = bytes_read + length as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += length as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/array/mod.rs:202:21 [INFO] [stdout] | [INFO] [stdout] 202 | bytes_read = bytes_read + length as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += length as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/array/mod.rs:231:25 [INFO] [stdout] | [INFO] [stdout] 231 | bytes_read = bytes_read + length as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += length as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/array/mod.rs:236:29 [INFO] [stdout] | [INFO] [stdout] 236 | ... number_of_open_square_brackets = number_of_open_square_brackets + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number_of_open_square_brackets += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/array/mod.rs:242:29 [INFO] [stdout] | [INFO] [stdout] 242 | ... number_of_closed_square_brackets = number_of_closed_square_brackets + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number_of_closed_square_brackets += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/array/mod.rs:274:25 [INFO] [stdout] | [INFO] [stdout] 274 | bytes_read = bytes_read + length as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += length as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/array/mod.rs:279:29 [INFO] [stdout] | [INFO] [stdout] 279 | ... number_of_open_curly_braces = number_of_open_curly_braces + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number_of_open_curly_braces += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/array/mod.rs:285:29 [INFO] [stdout] | [INFO] [stdout] 285 | ... number_of_closed_curly_braces = number_of_closed_curly_braces + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number_of_closed_curly_braces += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/array/mod.rs:336:25 [INFO] [stdout] | [INFO] [stdout] 336 | bytes_read = bytes_read + length as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += length as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/array/mod.rs:383:33 [INFO] [stdout] | [INFO] [stdout] 383 | ... bytes_read = bytes_read + length as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += length as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/array/mod.rs:459:13 [INFO] [stdout] | [INFO] [stdout] 459 | bytes_read = bytes_read + length as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += length as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | bytes_read = bytes_read + boxed_read.unwrap() as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += boxed_read.unwrap() as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | bytes_read = bytes_read + boxed_read.unwrap() as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += boxed_read.unwrap() as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/json/object/mod.rs:82:31 [INFO] [stdout] | [INFO] [stdout] 82 | let message = format!("provided json is not valid"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"provided json is not valid".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 98 | bytes_read = bytes_read + boxed_read.unwrap() as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += boxed_read.unwrap() as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:124:17 [INFO] [stdout] | [INFO] [stdout] 124 | bytes_read = bytes_read + bytes_to_read as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += bytes_to_read as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:169:17 [INFO] [stdout] | [INFO] [stdout] 169 | bytes_read = bytes_read + bytes_to_read as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += bytes_to_read as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:206:29 [INFO] [stdout] | [INFO] [stdout] 206 | ... bytes_read = bytes_read + bytes_to_read as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += bytes_to_read as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:228:25 [INFO] [stdout] | [INFO] [stdout] 228 | bytes_read = bytes_read + boxed_read.unwrap() as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += boxed_read.unwrap() as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:263:25 [INFO] [stdout] | [INFO] [stdout] 263 | bytes_read = bytes_read + length as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += length as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:286:25 [INFO] [stdout] | [INFO] [stdout] 286 | bytes_read = bytes_read + boxed_read.unwrap() as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += boxed_read.unwrap() as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:321:25 [INFO] [stdout] | [INFO] [stdout] 321 | bytes_read = bytes_read + length as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += length as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:344:25 [INFO] [stdout] | [INFO] [stdout] 344 | bytes_read = bytes_read + boxed_read.unwrap() as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += boxed_read.unwrap() as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:379:25 [INFO] [stdout] | [INFO] [stdout] 379 | bytes_read = bytes_read + length as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += length as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:402:25 [INFO] [stdout] | [INFO] [stdout] 402 | bytes_read = bytes_read + boxed_read.unwrap() as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += boxed_read.unwrap() as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:443:29 [INFO] [stdout] | [INFO] [stdout] 443 | ... bytes_read = bytes_read + length as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += length as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:454:33 [INFO] [stdout] | [INFO] [stdout] 454 | ... number_of_open_square_brackets = number_of_open_square_brackets + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number_of_open_square_brackets += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:460:33 [INFO] [stdout] | [INFO] [stdout] 460 | ... number_of_closed_square_brackets = number_of_closed_square_brackets + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number_of_closed_square_brackets += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:478:25 [INFO] [stdout] | [INFO] [stdout] 478 | bytes_read = bytes_read + boxed_read.unwrap() as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += boxed_read.unwrap() as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:520:29 [INFO] [stdout] | [INFO] [stdout] 520 | ... bytes_read = bytes_read + length as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += length as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:537:33 [INFO] [stdout] | [INFO] [stdout] 537 | ... number_of_open_curly_braces = number_of_open_curly_braces + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number_of_open_curly_braces += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:543:33 [INFO] [stdout] | [INFO] [stdout] 543 | ... number_of_closed_curly_braces = number_of_closed_curly_braces + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number_of_closed_curly_braces += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:561:25 [INFO] [stdout] | [INFO] [stdout] 561 | bytes_read = bytes_read + boxed_read.unwrap() as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += boxed_read.unwrap() as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:604:29 [INFO] [stdout] | [INFO] [stdout] 604 | ... bytes_read = bytes_read + length as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += length as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/json/object/mod.rs:688:17 [INFO] [stdout] | [INFO] [stdout] 688 | bytes_read = bytes_read + boxed_read.unwrap() as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += boxed_read.unwrap() as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.string` after checking its variant with `is_some` [INFO] [stdout] --> src/json/object/mod.rs:720:37 [INFO] [stdout] | [INFO] [stdout] 719 | if value.string.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = value.string` [INFO] [stdout] 720 | let raw_value = value.string.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.bool` after checking its variant with `is_some` [INFO] [stdout] --> src/json/object/mod.rs:728:37 [INFO] [stdout] | [INFO] [stdout] 727 | if value.bool.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = value.bool` [INFO] [stdout] 728 | let raw_value = value.bool.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.i128` after checking its variant with `is_some` [INFO] [stdout] --> src/json/object/mod.rs:736:37 [INFO] [stdout] | [INFO] [stdout] 735 | if value.i128.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = value.i128` [INFO] [stdout] 736 | let raw_value = value.i128.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.f64` after checking its variant with `is_some` [INFO] [stdout] --> src/json/object/mod.rs:744:37 [INFO] [stdout] | [INFO] [stdout] 743 | if value.f64.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = value.f64` [INFO] [stdout] 744 | let raw_value = value.f64.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.object` after checking its variant with `is_some` [INFO] [stdout] --> src/json/object/mod.rs:756:37 [INFO] [stdout] | [INFO] [stdout] 755 | if value.object.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = value.object` [INFO] [stdout] 756 | let raw_value = value.object.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.array` after checking its variant with `is_some` [INFO] [stdout] --> src/json/object/mod.rs:764:37 [INFO] [stdout] | [INFO] [stdout] 763 | if value.array.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = value.array` [INFO] [stdout] 764 | let raw_value = value.array.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/json/object/mod.rs:778:9 [INFO] [stdout] | [INFO] [stdout] 777 | let json= json_list.join(SYMBOL.new_line_carriage_return); [INFO] [stdout] | ---------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 778 | json [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 777 ~ [INFO] [stdout] 778 ~ json_list.join(SYMBOL.new_line_carriage_return) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/object/mod.rs:718:13 [INFO] [stdout] | [INFO] [stdout] 718 | / if &property.property_type == "String" { [INFO] [stdout] 719 | | if value.string.is_some() { [INFO] [stdout] 720 | | let raw_value = value.string.unwrap(); [INFO] [stdout] 721 | | let formatted_property = format!(" \"{}\": \"{}\"", &property.property_name, raw_value); [INFO] [stdout] ... | [INFO] [stdout] 724 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 718 ~ if &property.property_type == "String" [INFO] [stdout] 719 ~ && value.string.is_some() { [INFO] [stdout] 720 | let raw_value = value.string.unwrap(); [INFO] [stdout] 721 | let formatted_property = format!(" \"{}\": \"{}\"", &property.property_name, raw_value); [INFO] [stdout] 722 | properties_list.push(formatted_property.to_string()); [INFO] [stdout] 723 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/object/mod.rs:726:13 [INFO] [stdout] | [INFO] [stdout] 726 | / if &property.property_type == "bool" { [INFO] [stdout] 727 | | if value.bool.is_some() { [INFO] [stdout] 728 | | let raw_value = value.bool.unwrap(); [INFO] [stdout] 729 | | let formatted_property = format!(" \"{}\": {}", &property.property_name, raw_value); [INFO] [stdout] ... | [INFO] [stdout] 732 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 726 ~ if &property.property_type == "bool" [INFO] [stdout] 727 ~ && value.bool.is_some() { [INFO] [stdout] 728 | let raw_value = value.bool.unwrap(); [INFO] [stdout] 729 | let formatted_property = format!(" \"{}\": {}", &property.property_name, raw_value); [INFO] [stdout] 730 | properties_list.push(formatted_property.to_string()); [INFO] [stdout] 731 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/object/mod.rs:734:13 [INFO] [stdout] | [INFO] [stdout] 734 | / if &property.property_type == "i128" { [INFO] [stdout] 735 | | if value.i128.is_some() { [INFO] [stdout] 736 | | let raw_value = value.i128.unwrap(); [INFO] [stdout] 737 | | let formatted_property = format!(" \"{}\": {}", &property.property_name, raw_value); [INFO] [stdout] ... | [INFO] [stdout] 740 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 734 ~ if &property.property_type == "i128" [INFO] [stdout] 735 ~ && value.i128.is_some() { [INFO] [stdout] 736 | let raw_value = value.i128.unwrap(); [INFO] [stdout] 737 | let formatted_property = format!(" \"{}\": {}", &property.property_name, raw_value); [INFO] [stdout] 738 | properties_list.push(formatted_property.to_string()); [INFO] [stdout] 739 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/object/mod.rs:742:13 [INFO] [stdout] | [INFO] [stdout] 742 | / if &property.property_type == "f64" { [INFO] [stdout] 743 | | if value.f64.is_some() { [INFO] [stdout] 744 | | let raw_value = value.f64.unwrap(); [INFO] [stdout] 745 | | let mut _parsed_float = "0.0".to_string(); [INFO] [stdout] ... | [INFO] [stdout] 752 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 742 ~ if &property.property_type == "f64" [INFO] [stdout] 743 ~ && value.f64.is_some() { [INFO] [stdout] 744 | let raw_value = value.f64.unwrap(); [INFO] [stdout] ... [INFO] [stdout] 750 | properties_list.push(formatted_property.to_string()); [INFO] [stdout] 751 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/object/mod.rs:754:13 [INFO] [stdout] | [INFO] [stdout] 754 | / if &property.property_type == "object" { [INFO] [stdout] 755 | | if value.object.is_some() { [INFO] [stdout] 756 | | let raw_value = value.object.unwrap(); [INFO] [stdout] 757 | | let formatted_property = format!(" \"{}\": {}", &property.property_name, raw_value); [INFO] [stdout] ... | [INFO] [stdout] 760 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 754 ~ if &property.property_type == "object" [INFO] [stdout] 755 ~ && value.object.is_some() { [INFO] [stdout] 756 | let raw_value = value.object.unwrap(); [INFO] [stdout] 757 | let formatted_property = format!(" \"{}\": {}", &property.property_name, raw_value); [INFO] [stdout] 758 | properties_list.push(formatted_property.to_string()); [INFO] [stdout] 759 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/object/mod.rs:762:13 [INFO] [stdout] | [INFO] [stdout] 762 | / if &property.property_type == "array" { [INFO] [stdout] 763 | | if value.array.is_some() { [INFO] [stdout] 764 | | let raw_value = value.array.unwrap(); [INFO] [stdout] 765 | | let formatted_property = format!(" \"{}\": {}", &property.property_name, raw_value); [INFO] [stdout] ... | [INFO] [stdout] 768 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 762 ~ if &property.property_type == "array" [INFO] [stdout] 763 ~ && value.array.is_some() { [INFO] [stdout] 764 | let raw_value = value.array.unwrap(); [INFO] [stdout] 765 | let formatted_property = format!(" \"{}\": {}", &property.property_name, raw_value); [INFO] [stdout] 766 | properties_list.push(formatted_property.to_string()); [INFO] [stdout] 767 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/core/base64/mod.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | if bytes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/core/base64/mod.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | index = index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/core/base64/mod.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | index = index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/core/base64/mod.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | index = index + 1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/core/base64/mod.rs:88:17 [INFO] [stdout] | [INFO] [stdout] 88 | index = index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/core/base64/mod.rs:98:17 [INFO] [stdout] | [INFO] [stdout] 98 | index = index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/core/base64/mod.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | index = index + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/core/base64/mod.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 131 | index = index + 1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/core/base64/mod.rs:354:12 [INFO] [stdout] | [INFO] [stdout] 354 | if bytes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `bytes.get(0)` [INFO] [stdout] --> src/core/base64/mod.rs:359:30 [INFO] [stdout] | [INFO] [stdout] 359 | let boxed_byte = bytes.get(0); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `bytes.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `bytes.get(0)` [INFO] [stdout] --> src/core/base64/mod.rs:396:30 [INFO] [stdout] | [INFO] [stdout] 396 | let boxed_byte = bytes.get(0); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `bytes.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `bytes.get(0)` [INFO] [stdout] --> src/core/base64/mod.rs:462:30 [INFO] [stdout] | [INFO] [stdout] 462 | let boxed_byte = bytes.get(0); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `bytes.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeInclusive` [INFO] [stdout] --> src/core/base64/mod.rs:567:29 [INFO] [stdout] | [INFO] [stdout] 567 | let mut uppercase = ('A'..='Z').into_iter().collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `('A'..='Z')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeInclusive` [INFO] [stdout] --> src/core/base64/mod.rs:570:29 [INFO] [stdout] | [INFO] [stdout] 570 | let mut lowercase = ('a'..='z').into_iter().collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `('a'..='z')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeInclusive` [INFO] [stdout] --> src/core/base64/mod.rs:573:27 [INFO] [stdout] | [INFO] [stdout] 573 | let mut numbers = ('0'..='9').into_iter().collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `('0'..='9')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/mime_type/mod.rs:205:33 [INFO] [stdout] | [INFO] [stdout] 205 | let html_suffixes = vec![MimeType::HTML_SUFFIX, MimeType::HTM_SUFFIX]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[MimeType::HTML_SUFFIX, MimeType::HTM_SUFFIX]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/mime_type/mod.rs:218:31 [INFO] [stdout] | [INFO] [stdout] 218 | let js_suffixes = vec![MimeType::MJS_SUFFIX, MimeType::JS_SUFFIX]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[MimeType::MJS_SUFFIX, MimeType::JS_SUFFIX]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/mime_type/mod.rs:251:33 [INFO] [stdout] | [INFO] [stdout] 251 | ...es = vec![MimeType::JPG_SUFFIX, MimeType::JPEG_SUFFIX, MimeType::JPE_SUFFIX, MimeType::JIF_SUFFIX, MimeType::JFIF_SUFFIX]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[MimeType::JPG_SUFFIX, MimeType::JPEG_SUFFIX, MimeType::JPE_SUFFIX, MimeType::JIF_SUFFIX, MimeType::JFIF_SUFFIX]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/mime_type/mod.rs:279:32 [INFO] [stdout] | [INFO] [stdout] 279 | let ico_suffixes = vec![MimeType::ICO_SUFFIX, MimeType::CUR_SUFFIX]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[MimeType::ICO_SUFFIX, MimeType::CUR_SUFFIX]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/mime_type/mod.rs:292:33 [INFO] [stdout] | [INFO] [stdout] 292 | let tiff_suffixes = vec![MimeType::TIF_SUFFIX, MimeType::TIFF_SUFFIX]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[MimeType::TIF_SUFFIX, MimeType::TIFF_SUFFIX]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/mime_type/mod.rs:335:33 [INFO] [stdout] | [INFO] [stdout] 335 | let mpeg_suffixes = vec![MimeType::MPG_SUFFIX, MimeType::MPEG_SUFFIX]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[MimeType::MPG_SUFFIX, MimeType::MPEG_SUFFIX]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/mime_type/mod.rs:348:32 [INFO] [stdout] | [INFO] [stdout] 348 | let mp4_suffixes = vec![MimeType::MP4_SUFFIX, MimeType::M4V_SUFFIX, MimeType::M4P_SUFFIX]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[MimeType::MP4_SUFFIX, MimeType::M4V_SUFFIX, MimeType::M4P_SUFFIX]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/mime_type/mod.rs:361:32 [INFO] [stdout] | [INFO] [stdout] 361 | let ogg_suffixes = vec![MimeType::OGG_SUFFIX, MimeType::OGV_SUFFIX]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[MimeType::OGG_SUFFIX, MimeType::OGV_SUFFIX]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/mime_type/mod.rs:475:33 [INFO] [stdout] | [INFO] [stdout] 475 | let midi_suffixes = vec![MimeType::MIDI_SUFFIX, MimeType::MID_SUFFIX]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[MimeType::MIDI_SUFFIX, MimeType::MID_SUFFIX]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `App` is never constructed [INFO] [stdout] --> src/application/example/mod.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct App {} [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `IndexController` is never constructed [INFO] [stdout] --> src/controller/example/mod.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct IndexController; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `INDEX_FILEPATH` is never used [INFO] [stdout] --> src/controller/example/mod.rs:13:15 [INFO] [stdout] | [INFO] [stdout] 12 | impl IndexController { [INFO] [stdout] | -------------------- associated constant in this implementation [INFO] [stdout] 13 | pub const INDEX_FILEPATH: &'static str = "index.html"; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/not_found/mod.rs:26:37 [INFO] [stdout] | [INFO] [stdout] 25 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 26 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/not_found/mod.rs:75:37 [INFO] [stdout] | [INFO] [stdout] 74 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 75 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/app/controller/index/tests.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 42 | let actual_text = response.content_range_list.get(0).unwrap().body.to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/app/controller/index/tests.rs:79:23 [INFO] [stdout] | [INFO] [stdout] 79 | let actual_text = response.content_range_list.get(0).unwrap().body.to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/index/mod.rs:30:37 [INFO] [stdout] | [INFO] [stdout] 29 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 30 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/index/mod.rs:79:37 [INFO] [stdout] | [INFO] [stdout] 78 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 79 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/app/controller/static_resource/tests.rs:39:23 [INFO] [stdout] | [INFO] [stdout] 39 | let actual_text = response.content_range_list.get(0).unwrap().body.to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/app/controller/static_resource/tests.rs:72:23 [INFO] [stdout] | [INFO] [stdout] 72 | let actual_text = response.content_range_list.get(0).unwrap().body.to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/app/controller/static_resource/tests.rs:105:23 [INFO] [stdout] | [INFO] [stdout] 105 | let actual_text = response.content_range_list.get(0).unwrap().body.to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/app/controller/static_resource/tests.rs:138:23 [INFO] [stdout] | [INFO] [stdout] 138 | let actual_text = response.content_range_list.get(0).unwrap().body.to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/app/controller/static_resource/tests.rs:171:23 [INFO] [stdout] | [INFO] [stdout] 171 | let actual_text = response.content_range_list.get(0).unwrap().body.to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/app/controller/static_resource/tests.rs:262:23 [INFO] [stdout] | [INFO] [stdout] 262 | let actual_text = response.content_range_list.get(0).unwrap().body.to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/app/controller/static_resource/tests.rs:295:23 [INFO] [stdout] | [INFO] [stdout] 295 | let actual_text = response.content_range_list.get(0).unwrap().body.to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/app/controller/static_resource/tests.rs:328:23 [INFO] [stdout] | [INFO] [stdout] 328 | let actual_text = response.content_range_list.get(0).unwrap().body.to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_md` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:51:22 [INFO] [stdout] | [INFO] [stdout] 50 | if boxed_md.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = boxed_md` [INFO] [stdout] 51 | let md = boxed_md.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:40:66 [INFO] [stdout] | [INFO] [stdout] 40 | let boxed_static_filepath = FileExt::get_static_filepath(&os_specific_path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `os_specific_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range_list` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:109:38 [INFO] [stdout] | [INFO] [stdout] 108 | if boxed_content_range_list.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_content_range_list` [INFO] [stdout] 109 | let content_range_list = boxed_content_range_list.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_modified_date_time` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:145:46 [INFO] [stdout] | [INFO] [stdout] 144 | if boxed_modified_date_time.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_modified_date_time` [INFO] [stdout] 145 | let modified_date_time = boxed_modified_date_time.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:107:91 [INFO] [stdout] | [INFO] [stdout] 107 | let boxed_content_range_list = StaticResourceController::process_static_resources(&request); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:111:16 [INFO] [stdout] | [INFO] [stdout] 111 | if content_range_list.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content_range_list.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range_list` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:209:38 [INFO] [stdout] | [INFO] [stdout] 208 | if boxed_content_range_list.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_content_range_list` [INFO] [stdout] 209 | let content_range_list = boxed_content_range_list.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_modified_date_time` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:232:46 [INFO] [stdout] | [INFO] [stdout] 231 | if boxed_modified_date_time.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_modified_date_time` [INFO] [stdout] 232 | let modified_date_time = boxed_modified_date_time.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:207:91 [INFO] [stdout] | [INFO] [stdout] 207 | let boxed_content_range_list = StaticResourceController::process_static_resources(&request); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:211:16 [INFO] [stdout] | [INFO] [stdout] 211 | if content_range_list.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content_range_list.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_md` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:300:22 [INFO] [stdout] | [INFO] [stdout] 299 | if boxed_md.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = boxed_md` [INFO] [stdout] 300 | let md = boxed_md.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_header` after checking its variant with `is_some` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:310:36 [INFO] [stdout] | [INFO] [stdout] 309 | if boxed_header.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = boxed_header` [INFO] [stdout] 310 | range_header = boxed_header.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range_list` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:325:42 [INFO] [stdout] | [INFO] [stdout] 324 | if boxed_content_range_list.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_content_range_list` [INFO] [stdout] 325 | content_range_list = boxed_content_range_list.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_header` after checking its variant with `is_some` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:345:40 [INFO] [stdout] | [INFO] [stdout] 344 | if boxed_header.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = boxed_header` [INFO] [stdout] 345 | range_header = boxed_header.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range_list` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:360:46 [INFO] [stdout] | [INFO] [stdout] 359 | if boxed_content_range_list.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_content_range_list` [INFO] [stdout] 360 | content_range_list = boxed_content_range_list.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_header` after checking its variant with `is_some` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:375:40 [INFO] [stdout] | [INFO] [stdout] 374 | if boxed_header.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = boxed_header` [INFO] [stdout] 375 | range_header = boxed_header.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range_list` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:380:46 [INFO] [stdout] | [INFO] [stdout] 379 | if boxed_content_range_list.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_content_range_list` [INFO] [stdout] 380 | content_range_list = boxed_content_range_list.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_header` after checking its variant with `is_some` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:404:44 [INFO] [stdout] | [INFO] [stdout] 403 | if boxed_header.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = boxed_header` [INFO] [stdout] 404 | range_header = boxed_header.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range_list` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:425:50 [INFO] [stdout] | [INFO] [stdout] 424 | if boxed_content_range_list.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_content_range_list` [INFO] [stdout] 425 | content_range_list = boxed_content_range_list.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/controller/static_resource/mod.rs:282:66 [INFO] [stdout] | [INFO] [stdout] 282 | let boxed_static_filepath = FileExt::get_static_filepath(&os_specific_path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `os_specific_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/style/mod.rs:26:37 [INFO] [stdout] | [INFO] [stdout] 25 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 26 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/style/mod.rs:75:37 [INFO] [stdout] | [INFO] [stdout] 74 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 75 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/app/controller/favicon/tests.rs:43:23 [INFO] [stdout] | [INFO] [stdout] 43 | let actual_text = response.content_range_list.get(0).unwrap().body.to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/app/controller/favicon/tests.rs:54:23 [INFO] [stdout] | [INFO] [stdout] 54 | let actual_text = response.content_range_list.get(0).unwrap().body.to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/favicon/mod.rs:30:37 [INFO] [stdout] | [INFO] [stdout] 29 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 30 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/favicon/mod.rs:79:37 [INFO] [stdout] | [INFO] [stdout] 78 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 79 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/app/controller/script/tests.rs:43:23 [INFO] [stdout] | [INFO] [stdout] 43 | let actual_text = response.content_range_list.get(0).unwrap().body.to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/app/controller/script/tests.rs:55:23 [INFO] [stdout] | [INFO] [stdout] 55 | let actual_text = response.content_range_list.get(0).unwrap().body.to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/app/controller/script/tests.rs:64:23 [INFO] [stdout] | [INFO] [stdout] 64 | let actual_text = response.content_range_list.get(0).unwrap().body.to_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/script/mod.rs:29:37 [INFO] [stdout] | [INFO] [stdout] 28 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 29 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/app/controller/script/mod.rs:78:37 [INFO] [stdout] | [INFO] [stdout] 77 | if boxed_content_range.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = boxed_content_range` [INFO] [stdout] 78 | let content_range = boxed_content_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `query_option` after checking its variant with `is_some` [INFO] [stdout] --> src/app/controller/form/get_method/mod.rs:37:49 [INFO] [stdout] | [INFO] [stdout] 36 | if query_option.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = query_option` [INFO] [stdout] 37 | let form: HashMap = query_option.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `query_option` after checking its variant with `is_some` [INFO] [stdout] --> src/app/controller/form/get_method/mod.rs:89:49 [INFO] [stdout] | [INFO] [stdout] 88 | if query_option.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = query_option` [INFO] [stdout] 89 | let form: HashMap = query_option.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get("name").is_none()` [INFO] [stdout] --> src/app/controller/file/initiate/mod.rs:49:17 [INFO] [stdout] | [INFO] [stdout] 49 | if form.get("name").is_none() { [INFO] [stdout] | -----^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!form.contains_key("name")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get("lastModified").is_none()` [INFO] [stdout] --> src/app/controller/file/initiate/mod.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | if form.get("lastModified").is_none() { [INFO] [stdout] | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!form.contains_key("lastModified")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get("size").is_none()` [INFO] [stdout] --> src/app/controller/file/initiate/mod.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | if form.get("size").is_none() { [INFO] [stdout] | -----^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!form.contains_key("size")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get("name").is_none()` [INFO] [stdout] --> src/app/controller/file/initiate/mod.rs:126:17 [INFO] [stdout] | [INFO] [stdout] 126 | if form.get("name").is_none() { [INFO] [stdout] | -----^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!form.contains_key("name")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get("lastModified").is_none()` [INFO] [stdout] --> src/app/controller/file/initiate/mod.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | if form.get("lastModified").is_none() { [INFO] [stdout] | -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!form.contains_key("lastModified")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get("size").is_none()` [INFO] [stdout] --> src/app/controller/file/initiate/mod.rs:132:17 [INFO] [stdout] | [INFO] [stdout] 132 | if form.get("size").is_none() { [INFO] [stdout] | -----^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!form.contains_key("size")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:36:51 [INFO] [stdout] | [INFO] [stdout] 36 | let header_list = Header::get_header_list(&request); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:46:41 [INFO] [stdout] | [INFO] [stdout] 46 | if IndexController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:47:49 [INFO] [stdout] | [INFO] [stdout] 47 | response = IndexController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:51:41 [INFO] [stdout] | [INFO] [stdout] 51 | if StyleController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:52:49 [INFO] [stdout] | [INFO] [stdout] 52 | response = StyleController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:56:42 [INFO] [stdout] | [INFO] [stdout] 56 | if ScriptController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:57:50 [INFO] [stdout] | [INFO] [stdout] 57 | response = ScriptController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:61:54 [INFO] [stdout] | [INFO] [stdout] 61 | if FileUploadInitiateController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:62:62 [INFO] [stdout] | [INFO] [stdout] 62 | response = FileUploadInitiateController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:66:67 [INFO] [stdout] | [INFO] [stdout] 66 | if FormUrlEncodedEnctypePostMethodController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:67:75 [INFO] [stdout] | [INFO] [stdout] 67 | response = FormUrlEncodedEnctypePostMethodController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:71:49 [INFO] [stdout] | [INFO] [stdout] 71 | if FormGetMethodController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:72:57 [INFO] [stdout] | [INFO] [stdout] 72 | response = FormGetMethodController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:76:66 [INFO] [stdout] | [INFO] [stdout] 76 | if FormMultipartEnctypePostMethodController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:77:74 [INFO] [stdout] | [INFO] [stdout] 77 | response = FormMultipartEnctypePostMethodController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:81:43 [INFO] [stdout] | [INFO] [stdout] 81 | if FaviconController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:82:51 [INFO] [stdout] | [INFO] [stdout] 82 | response = FaviconController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:86:50 [INFO] [stdout] | [INFO] [stdout] 86 | if StaticResourceController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:87:58 [INFO] [stdout] | [INFO] [stdout] 87 | response = StaticResourceController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:91:44 [INFO] [stdout] | [INFO] [stdout] 91 | if NotFoundController::is_matching(&request, connection) { [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app/mod.rs:92:52 [INFO] [stdout] | [INFO] [stdout] 92 | response = NotFoundController::process(&request, response, connection); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/client_hint/mod.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 41 | let hint_header_value = hint_list.join(", "); [INFO] [stdout] | --------------------------------------------- unnecessary `let` binding [INFO] [stdout] 42 | hint_header_value [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 41 ~ [INFO] [stdout] 42 ~ hint_list.join(", ") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/client_hint/mod.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 47 | let header = Header { name: ClientHint::ACCEPT_CLIENT_HINTS.to_string(), value: hint_header_value.to_string() }; [INFO] [stdout] | ---------------------------------------------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 48 | header [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 47 ~ [INFO] [stdout] 48 ~ Header { name: ClientHint::ACCEPT_CLIENT_HINTS.to_string(), value: hint_header_value.to_string() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/client_hint/mod.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 53 | let header = Header { name: ClientHint::CRITICAL_CLIENT_HINTS.to_string(), value: hint_header_value.to_string() }; [INFO] [stdout] | ------------------------------------------------------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 54 | header [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 53 ~ [INFO] [stdout] 54 ~ Header { name: ClientHint::CRITICAL_CLIENT_HINTS.to_string(), value: hint_header_value.to_string() } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/client_hint/mod.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 70 | let vary_client_hint = hint_list.join(", "); [INFO] [stdout] | -------------------------------------------- unnecessary `let` binding [INFO] [stdout] 71 | vary_client_hint [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 70 ~ [INFO] [stdout] 71 ~ hint_list.join(", ") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cors/tests.rs:70:51 [INFO] [stdout] | [INFO] [stdout] 70 | let request: Request = Request::parse_request(&raw_request.as_bytes()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `raw_request.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/cors/tests.rs:87:48 [INFO] [stdout] | [INFO] [stdout] 87 | let response_html_file= fs::read_to_string(response_filepath.to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&response_filepath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cors/tests.rs:114:25 [INFO] [stdout] | [INFO] [stdout] 114 | let allow_origins = format!("{}", access_control_allow_origin_header.value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `access_control_allow_origin_header.value.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cors/tests.rs:175:51 [INFO] [stdout] | [INFO] [stdout] 175 | let request: Request = Request::parse_request(&raw_request.as_bytes()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `raw_request.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/cors/tests.rs:192:48 [INFO] [stdout] | [INFO] [stdout] 192 | let response_html_file= fs::read_to_string(response_filepath.to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&response_filepath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/cors/tests.rs:207:49 [INFO] [stdout] | [INFO] [stdout] 207 | assert_eq!(response_html_file.into_bytes(), response.content_range_list.get(0).unwrap().body); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cors/tests.rs:219:25 [INFO] [stdout] | [INFO] [stdout] 219 | let allow_origins = format!("{}", access_control_allow_origin_header.value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `access_control_allow_origin_header.value.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cors/tests.rs:337:34 [INFO] [stdout] | [INFO] [stdout] 337 | let expected_allow_origins = format!("{}", origin_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `origin_value.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cors/tests.rs:399:34 [INFO] [stdout] | [INFO] [stdout] 399 | let expected_allow_origins = format!("{}", origin_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `origin_value.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `origin` after checking its variant with `is_some` [INFO] [stdout] --> src/cors/mod.rs:35:24 [INFO] [stdout] | [INFO] [stdout] 32 | if origin.is_some() { [INFO] [stdout] | ------------------- help: try: `if let Some() = origin` [INFO] [stdout] ... [INFO] [stdout] 35 | value: origin.unwrap().value.to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `method` after checking its variant with `is_some` [INFO] [stdout] --> src/cors/mod.rs:51:32 [INFO] [stdout] | [INFO] [stdout] 48 | if method.is_some() { [INFO] [stdout] | ------------------- help: try: `if let Some() = method` [INFO] [stdout] ... [INFO] [stdout] 51 | value: method.unwrap().value.to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `access_control_request_headers` after checking its variant with `is_some` [INFO] [stdout] --> src/cors/mod.rs:58:43 [INFO] [stdout] | [INFO] [stdout] 57 | if access_control_request_headers.is_some() { [INFO] [stdout] | ------------------------------------------- help: try: `if let Some() = access_control_request_headers` [INFO] [stdout] 58 | let request_headers = access_control_request_headers.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cors/mod.rs:95:28 [INFO] [stdout] | [INFO] [stdout] 95 | let origin_value = format!("{}", origin.value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `origin.value.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_allow_origins` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:156:29 [INFO] [stdout] | [INFO] [stdout] 153 | if boxed_allow_origins.is_err() { [INFO] [stdout] | ------------------------------- help: try: `if let Ok() = boxed_allow_origins` [INFO] [stdout] ... [INFO] [stdout] 156 | allow_origins = boxed_allow_origins.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_is_allow_credentials` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:183:31 [INFO] [stdout] | [INFO] [stdout] 180 | if boxed_is_allow_credentials.is_err() { [INFO] [stdout] | -------------------------------------- help: try: `if let Ok() = boxed_is_allow_credentials` [INFO] [stdout] ... [INFO] [stdout] 183 | let boxed_parse = boxed_is_allow_credentials.unwrap().parse::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_parse` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:187:51 [INFO] [stdout] | [INFO] [stdout] 184 | if boxed_parse.is_err() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = boxed_parse` [INFO] [stdout] ... [INFO] [stdout] 187 | let is_allow_credentials : bool = boxed_parse.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_methods` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:205:31 [INFO] [stdout] | [INFO] [stdout] 202 | if boxed_methods.is_err() { [INFO] [stdout] | ------------------------- help: try: `if let Ok() = boxed_methods` [INFO] [stdout] ... [INFO] [stdout] 205 | let methods = boxed_methods.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_allow_headers_env_variable` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:218:50 [INFO] [stdout] | [INFO] [stdout] 215 | if boxed_allow_headers_env_variable.is_err() { [INFO] [stdout] | -------------------------------------------- help: try: `if let Ok() = boxed_allow_headers_env_variable` [INFO] [stdout] ... [INFO] [stdout] 218 | let allow_headers_env_variable = boxed_allow_headers_env_variable.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_allow_expose_headers` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:231:45 [INFO] [stdout] | [INFO] [stdout] 228 | if boxed_allow_expose_headers.is_err() { [INFO] [stdout] | -------------------------------------- help: try: `if let Ok() = boxed_allow_expose_headers` [INFO] [stdout] ... [INFO] [stdout] 231 | let allow_expose_headers = boxed_allow_expose_headers.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_max_age_value` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:244:38 [INFO] [stdout] | [INFO] [stdout] 241 | if boxed_max_age_value.is_err() { [INFO] [stdout] | ------------------------------- help: try: `if let Ok() = boxed_max_age_value` [INFO] [stdout] ... [INFO] [stdout] 244 | let max_age_value = boxed_max_age_value.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cors/mod.rs:166:28 [INFO] [stdout] | [INFO] [stdout] 166 | let origin_value = format!("{}", origin.value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `origin.value.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_header_list` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:267:24 [INFO] [stdout] | [INFO] [stdout] 264 | if boxed_cors_header_list.is_err() { [INFO] [stdout] | ---------------------------------- help: try: `if let Ok() = boxed_cors_header_list` [INFO] [stdout] ... [INFO] [stdout] 267 | return boxed_cors_header_list.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_rws_config_cors_allow_all` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:270:31 [INFO] [stdout] | [INFO] [stdout] 261 | if boxed_rws_config_cors_allow_all.is_err() { [INFO] [stdout] | ------------------------------------------- help: try: `if let Ok() = boxed_rws_config_cors_allow_all` [INFO] [stdout] ... [INFO] [stdout] 270 | let boxed_parse = boxed_rws_config_cors_allow_all.unwrap().parse::(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_parse` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:274:57 [INFO] [stdout] | [INFO] [stdout] 271 | if boxed_parse.is_err() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = boxed_parse` [INFO] [stdout] ... [INFO] [stdout] 274 | let is_cors_set_to_allow_all_requests = boxed_parse.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_header_list` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:280:32 [INFO] [stdout] | [INFO] [stdout] 277 | if boxed_cors_header_list.is_err() { [INFO] [stdout] | ---------------------------------- help: try: `if let Ok() = boxed_cors_header_list` [INFO] [stdout] ... [INFO] [stdout] 280 | return boxed_cors_header_list.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_header_list` after checking its variant with `is_err` [INFO] [stdout] --> src/cors/mod.rs:292:20 [INFO] [stdout] | [INFO] [stdout] 288 | if boxed_cors_header_list.is_err() { [INFO] [stdout] | ---------------------------------- help: try: `if let Ok() = boxed_cors_header_list` [INFO] [stdout] ... [INFO] [stdout] 292 | return boxed_cors_header_list.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cors/mod.rs:292:13 [INFO] [stdout] | [INFO] [stdout] 292 | return boxed_cors_header_list.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 292 - return boxed_cors_header_list.unwrap() [INFO] [stdout] 292 + boxed_cors_header_list.unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cors/mod.rs:263:58 [INFO] [stdout] | [INFO] [stdout] 263 | let boxed_cors_header_list = Cors::allow_all(&request); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cors/mod.rs:276:85 [INFO] [stdout] | [INFO] [stdout] 276 | let boxed_cors_header_list = Cors::process_using_default_config(&request); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cors/mod.rs:287:54 [INFO] [stdout] | [INFO] [stdout] 287 | let boxed_cors_header_list = Cors::allow_all(&request); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `command_line_arg_list.get(0)` [INFO] [stdout] --> src/entry_point/command_line_args/tests.rs:9:20 [INFO] [stdout] | [INFO] [stdout] 9 | let argument = command_line_arg_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `command_line_arg_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_split` after checking its variant with `is_some` [INFO] [stdout] --> src/entry_point/command_line_args/mod.rs:126:42 [INFO] [stdout] | [INFO] [stdout] 124 | if boxed_split.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = boxed_split` [INFO] [stdout] 125 | [INFO] [stdout] 126 | let (parameter, value) = boxed_split.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_predefined_argument` after checking its variant with `is_some` [INFO] [stdout] --> src/entry_point/command_line_args/mod.rs:142:47 [INFO] [stdout] | [INFO] [stdout] 141 | if boxed_predefined_argument.is_some() { [INFO] [stdout] | -------------------------------------- help: try: `if let Some() = boxed_predefined_argument` [INFO] [stdout] 142 | let predefined_argument = boxed_predefined_argument.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::io::Lines>` [INFO] [stdout] --> src/entry_point/config_file/mod.rs:12:17 [INFO] [stdout] | [INFO] [stdout] 12 | let lines = cursor.lines().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `cursor.lines()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/entry_point/config_file/mod.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | let arg: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `arg` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 30 ~ [INFO] [stdout] 31 | let (unparsed_key, unparsed_value) = boxed_split.unwrap(); [INFO] [stdout] ... [INFO] [stdout] 40 | [INFO] [stdout] 41 ~ let arg: String = if prefix.chars().count() == 0 { [INFO] [stdout] 42 ~ [ [INFO] [stdout] 43 | SYMBOL.hyphen, [INFO] [stdout] ... [INFO] [stdout] 47 | &value [INFO] [stdout] 48 ~ ].join("") [INFO] [stdout] 49 | } else { [INFO] [stdout] 50 ~ [ [INFO] [stdout] 51 | SYMBOL.hyphen, [INFO] [stdout] ... [INFO] [stdout] 56 | SYMBOL.equals, [INFO] [stdout] 57 ~ &value].join("") [INFO] [stdout] 58 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/entry_point/config_file/mod.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 80 | let without_whitespaces = line.replace(SYMBOL.whitespace, SYMBOL.empty_string); [INFO] [stdout] | ------------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 81 | [INFO] [stdout] 82 | without_whitespaces [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 80 ~ [INFO] [stdout] 81 | [INFO] [stdout] 82 ~ line.replace(SYMBOL.whitespace, SYMBOL.empty_string) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `filepath` after checking its variant with `is_none` [INFO] [stdout] --> src/entry_point/config_file/mod.rs:92:16 [INFO] [stdout] | [INFO] [stdout] 89 | if filepath.is_none() { [INFO] [stdout] | --------------------- help: try: `if let Some() = filepath` [INFO] [stdout] ... [INFO] [stdout] 92 | path = filepath.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content` after checking its variant with `is_err` [INFO] [stdout] --> src/entry_point/config_file/mod.rs:109:23 [INFO] [stdout] | [INFO] [stdout] 104 | if boxed_content.is_err() { [INFO] [stdout] | ------------------------- help: try: `if let Ok() = boxed_content` [INFO] [stdout] ... [INFO] [stdout] 109 | let content = boxed_content.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/entry_point/config_file/mod.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | let path: &str; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `path` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 88 ~ [INFO] [stdout] 89 ~ let path: &str = if filepath.is_none() { [INFO] [stdout] 90 ~ "/rws.config.toml" [INFO] [stdout] 91 | } else { [INFO] [stdout] 92 ~ filepath.unwrap() [INFO] [stdout] 93 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_ip` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:14:18 [INFO] [stdout] | [INFO] [stdout] 11 | if boxed_ip.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = boxed_ip` [INFO] [stdout] ... [INFO] [stdout] 14 | boxed_ip.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_port` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:21:18 [INFO] [stdout] | [INFO] [stdout] 18 | if boxed_port.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = boxed_port` [INFO] [stdout] ... [INFO] [stdout] 21 | boxed_port.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_request_allocation_size` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 25 | if boxed_request_allocation_size.is_ok() { [INFO] [stdout] | ---------------------------------------- help: try: `if let Ok() = boxed_request_allocation_size` [INFO] [stdout] ... [INFO] [stdout] 28 | boxed_request_allocation_size.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_thread_count` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:35:18 [INFO] [stdout] | [INFO] [stdout] 32 | if boxed_thread_count.is_ok() { [INFO] [stdout] | ----------------------------- help: try: `if let Ok() = boxed_thread_count` [INFO] [stdout] ... [INFO] [stdout] 35 | boxed_thread_count.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_allow_all` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:42:18 [INFO] [stdout] | [INFO] [stdout] 39 | if boxed_cors_allow_all.is_ok() { [INFO] [stdout] | ------------------------------- help: try: `if let Ok() = boxed_cors_allow_all` [INFO] [stdout] ... [INFO] [stdout] 42 | boxed_cors_allow_all.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_allow_origins` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:49:18 [INFO] [stdout] | [INFO] [stdout] 46 | if boxed_cors_allow_origins.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_cors_allow_origins` [INFO] [stdout] ... [INFO] [stdout] 49 | boxed_cors_allow_origins.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_allow_methods` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:56:18 [INFO] [stdout] | [INFO] [stdout] 53 | if boxed_cors_allow_methods.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_cors_allow_methods` [INFO] [stdout] ... [INFO] [stdout] 56 | boxed_cors_allow_methods.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_allow_headers` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:63:18 [INFO] [stdout] | [INFO] [stdout] 60 | if boxed_cors_allow_headers.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_cors_allow_headers` [INFO] [stdout] ... [INFO] [stdout] 63 | boxed_cors_allow_headers.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_allow_credentials` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:70:18 [INFO] [stdout] | [INFO] [stdout] 67 | if boxed_cors_allow_credentials.is_ok() { [INFO] [stdout] | --------------------------------------- help: try: `if let Ok() = boxed_cors_allow_credentials` [INFO] [stdout] ... [INFO] [stdout] 70 | boxed_cors_allow_credentials.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_expose_headers` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:77:18 [INFO] [stdout] | [INFO] [stdout] 74 | if boxed_cors_expose_headers.is_ok() { [INFO] [stdout] | ------------------------------------ help: try: `if let Ok() = boxed_cors_expose_headers` [INFO] [stdout] ... [INFO] [stdout] 77 | boxed_cors_expose_headers.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_cors_max_age` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/environment_variables/mod.rs:84:18 [INFO] [stdout] | [INFO] [stdout] 81 | if boxed_cors_max_age.is_ok() { [INFO] [stdout] | ----------------------------- help: try: `if let Ok() = boxed_cors_max_age` [INFO] [stdout] ... [INFO] [stdout] 84 | boxed_cors_max_age.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_ip` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/mod.rs:173:14 [INFO] [stdout] | [INFO] [stdout] 172 | if boxed_ip.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = boxed_ip` [INFO] [stdout] 173 | ip = boxed_ip.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_port` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/mod.rs:178:21 [INFO] [stdout] | [INFO] [stdout] 177 | if boxed_port.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = boxed_port` [INFO] [stdout] 178 | let _port = boxed_port.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_parse` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/mod.rs:181:20 [INFO] [stdout] | [INFO] [stdout] 180 | if boxed_parse.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_parse` [INFO] [stdout] 181 | port = boxed_parse.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_thread_count` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/mod.rs:192:29 [INFO] [stdout] | [INFO] [stdout] 191 | if boxed_thread_count.is_ok() { [INFO] [stdout] | ----------------------------- help: try: `if let Ok() = boxed_thread_count` [INFO] [stdout] 192 | let _thread_count = boxed_thread_count.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_parse` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/mod.rs:195:28 [INFO] [stdout] | [INFO] [stdout] 194 | if boxed_parse.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_parse` [INFO] [stdout] 195 | thread_count = boxed_parse.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_port` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/mod.rs:213:40 [INFO] [stdout] | [INFO] [stdout] 212 | if boxed_port.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = boxed_port` [INFO] [stdout] 213 | let _request_allocation_size = boxed_port.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_parse` after checking its variant with `is_ok` [INFO] [stdout] --> src/entry_point/mod.rs:216:39 [INFO] [stdout] | [INFO] [stdout] 215 | if boxed_parse.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_parse` [INFO] [stdout] 216 | request_allocation_size = boxed_parse.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/ext/date_time_ext/mod.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 11 | let nanos = DateTimeExt::_system_time_to_unix_nanos(now); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 12 | nanos [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 11 ~ [INFO] [stdout] 12 ~ DateTimeExt::_system_time_to_unix_nanos(now) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/ext/date_time_ext/mod.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 23 | let nanos = boxed_duration.unwrap().as_nanos(); [INFO] [stdout] | ----------------------------------------------- unnecessary `let` binding [INFO] [stdout] 24 | nanos [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 23 ~ [INFO] [stdout] 24 ~ boxed_duration.unwrap().as_nanos() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u128` is unnecessary [INFO] [stdout] --> src/ext/date_time_ext/mod.rs:19:25 [INFO] [stdout] | [INFO] [stdout] 19 | let nanos = 0 as u128; [INFO] [stdout] | ^^^^^^^^^ help: try: `0_u128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:22:25 [INFO] [stdout] | [INFO] [stdout] 22 | let is_inline = self.disposition_type.to_string() == DISPOSITION_TYPE.inline.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.disposition_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:22:62 [INFO] [stdout] | [INFO] [stdout] 22 | let is_inline = self.disposition_type.to_string() == DISPOSITION_TYPE.inline.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `DISPOSITION_TYPE.inline` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/header/content_disposition/mod.rs:35:71 [INFO] [stdout] | [INFO] [stdout] 35 | formatted = format!("{}: {}", Header::_CONTENT_DISPOSITION.to_string(), self.disposition_type); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:38:29 [INFO] [stdout] | [INFO] [stdout] 38 | let is_attachment = self.disposition_type.to_string() == DISPOSITION_TYPE.attachment.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.disposition_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:38:66 [INFO] [stdout] | [INFO] [stdout] 38 | let is_attachment = self.disposition_type.to_string() == DISPOSITION_TYPE.attachment.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `DISPOSITION_TYPE.attachment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/header/content_disposition/mod.rs:50:92 [INFO] [stdout] | [INFO] [stdout] 50 | ... formatted = format!("{}: {}; filename=\"{}\"", Header::_CONTENT_DISPOSITION.to_string(), self.disposition_type, file_name); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/header/content_disposition/mod.rs:52:75 [INFO] [stdout] | [INFO] [stdout] 52 | formatted = format!("{}: {}", Header::_CONTENT_DISPOSITION.to_string(), self.disposition_type); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:56:28 [INFO] [stdout] | [INFO] [stdout] 56 | let is_form_data = self.disposition_type.to_string() == DISPOSITION_TYPE.form_data.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.disposition_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:56:65 [INFO] [stdout] | [INFO] [stdout] 56 | let is_form_data = self.disposition_type.to_string() == DISPOSITION_TYPE.form_data.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `DISPOSITION_TYPE.form_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/header/content_disposition/mod.rs:70:105 [INFO] [stdout] | [INFO] [stdout] 70 | ... formatted = format!("{}: {}; name=\"{}\"; filename=\"{}\"", Header::_CONTENT_DISPOSITION.to_string(), self.disposition_type, f... [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/header/content_disposition/mod.rs:74:88 [INFO] [stdout] | [INFO] [stdout] 74 | ... formatted = format!("{}: {}; name=\"{}\"", Header::_CONTENT_DISPOSITION.to_string(), self.disposition_type, field_name); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_second_element` after checking its variant with `is_some` [INFO] [stdout] --> src/header/content_disposition/mod.rs:110:34 [INFO] [stdout] | [INFO] [stdout] 109 | if boxed_second_element.is_some() { [INFO] [stdout] | --------------------------------- help: try: `if let Some() = boxed_second_element` [INFO] [stdout] 110 | let second_element = boxed_second_element.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_third_element` after checking its variant with `is_some` [INFO] [stdout] --> src/header/content_disposition/mod.rs:130:34 [INFO] [stdout] | [INFO] [stdout] 129 | if boxed_third_element.is_some() { [INFO] [stdout] | -------------------------------- help: try: `if let Some() = boxed_third_element` [INFO] [stdout] 130 | let second_element = boxed_third_element.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/header/content_disposition/mod.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 93 | if parts.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parts.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `parts.get(0)` [INFO] [stdout] --> src/header/content_disposition/mod.rs:97:32 [INFO] [stdout] | [INFO] [stdout] 97 | let disposition_type = parts.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `parts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 98 | if disposition_type.to_string() != DISPOSITION_TYPE.inline.to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*disposition_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:98:44 [INFO] [stdout] | [INFO] [stdout] 98 | if disposition_type.to_string() != DISPOSITION_TYPE.inline.to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `DISPOSITION_TYPE.inline` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 99 | && disposition_type.to_string() != DISPOSITION_TYPE.attachment.to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*disposition_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:99:48 [INFO] [stdout] | [INFO] [stdout] 99 | && disposition_type.to_string() != DISPOSITION_TYPE.attachment.to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `DISPOSITION_TYPE.attachment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:100:16 [INFO] [stdout] | [INFO] [stdout] 100 | && disposition_type.to_string() != DISPOSITION_TYPE.form_data.to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*disposition_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:100:48 [INFO] [stdout] | [INFO] [stdout] 100 | && disposition_type.to_string() != DISPOSITION_TYPE.form_data.to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `DISPOSITION_TYPE.form_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 159 | if disposition_type.to_string() == DISPOSITION_TYPE.form_data.to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*disposition_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/header/content_disposition/mod.rs:159:44 [INFO] [stdout] | [INFO] [stdout] 159 | if disposition_type.to_string() == DISPOSITION_TYPE.form_data.to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `DISPOSITION_TYPE.form_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/header/content_disposition/mod.rs:160:16 [INFO] [stdout] | [INFO] [stdout] 160 | && content_disposition.field_name == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `content_disposition.field_name.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/header/mod.rs:149:63 [INFO] [stdout] | [INFO] [stdout] 149 | let cors_header_list: Vec
= Cors::get_headers(&request); [INFO] [stdout] | ^^^^^^^^ help: change this to: `request` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/language/mod.rs:253:9 [INFO] [stdout] | [INFO] [stdout] 253 | / let mut language_list : Vec = vec![]; [INFO] [stdout] 254 | | [INFO] [stdout] 255 | | language_list.push(Language::AFRIKAANS); [INFO] [stdout] 256 | | language_list.push(Language::AFRIKAANS_SOUTH_AFRICA); [INFO] [stdout] ... | [INFO] [stdout] 492 | | language_list.push(Language::ZULU); [INFO] [stdout] 493 | | language_list.push(Language::ZULU_SOUTH_AFRICA); [INFO] [stdout] | |________________________________________________________^ help: consider using the `vec![]` macro: `let language_list: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mime_type/mod.rs:204:12 [INFO] [stdout] | [INFO] [stdout] 204 | if !boxed_extension.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_extension.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mime_type/mod.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 217 | if !boxed_extension.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_extension.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mime_type/mod.rs:250:12 [INFO] [stdout] | [INFO] [stdout] 250 | if !boxed_extension.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_extension.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mime_type/mod.rs:278:12 [INFO] [stdout] | [INFO] [stdout] 278 | if !boxed_extension.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_extension.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mime_type/mod.rs:291:12 [INFO] [stdout] | [INFO] [stdout] 291 | if !boxed_extension.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_extension.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mime_type/mod.rs:334:12 [INFO] [stdout] | [INFO] [stdout] 334 | if !boxed_extension.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_extension.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mime_type/mod.rs:347:12 [INFO] [stdout] | [INFO] [stdout] 347 | if !boxed_extension.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_extension.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mime_type/mod.rs:360:12 [INFO] [stdout] | [INFO] [stdout] 360 | if !boxed_extension.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_extension.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mime_type/mod.rs:474:12 [INFO] [stdout] | [INFO] [stdout] 474 | if !boxed_extension.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_extension.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_extension` after checking its variant with `is_none` [INFO] [stdout] --> src/mime_type/mod.rs:206:29 [INFO] [stdout] | [INFO] [stdout] 204 | if !boxed_extension.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 205 | let html_suffixes = vec![MimeType::HTML_SUFFIX, MimeType::HTM_SUFFIX]; [INFO] [stdout] 206 | let extension = boxed_extension.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_extension` after checking its variant with `is_none` [INFO] [stdout] --> src/mime_type/mod.rs:219:29 [INFO] [stdout] | [INFO] [stdout] 217 | if !boxed_extension.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 218 | let js_suffixes = vec![MimeType::MJS_SUFFIX, MimeType::JS_SUFFIX]; [INFO] [stdout] 219 | let extension = boxed_extension.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_extension` after checking its variant with `is_none` [INFO] [stdout] --> src/mime_type/mod.rs:252:29 [INFO] [stdout] | [INFO] [stdout] 250 | if !boxed_extension.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 251 | let jpeg_suffixes = vec![MimeType::JPG... [INFO] [stdout] 252 | let extension = boxed_extension.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_extension` after checking its variant with `is_none` [INFO] [stdout] --> src/mime_type/mod.rs:280:29 [INFO] [stdout] | [INFO] [stdout] 278 | if !boxed_extension.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 279 | let ico_suffixes = vec![MimeType::ICO_SUFFIX, MimeType::CUR_SUFFIX]; [INFO] [stdout] 280 | let extension = boxed_extension.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_extension` after checking its variant with `is_none` [INFO] [stdout] --> src/mime_type/mod.rs:293:29 [INFO] [stdout] | [INFO] [stdout] 291 | if !boxed_extension.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 292 | let tiff_suffixes = vec![MimeType::TIF_SUFFIX, MimeType::TIFF_SUFFIX]; [INFO] [stdout] 293 | let extension = boxed_extension.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_extension` after checking its variant with `is_none` [INFO] [stdout] --> src/mime_type/mod.rs:336:29 [INFO] [stdout] | [INFO] [stdout] 334 | if !boxed_extension.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 335 | let mpeg_suffixes = vec![MimeType::MPG_SUFFIX, MimeType::MPEG_SUFFIX]; [INFO] [stdout] 336 | let extension = boxed_extension.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_extension` after checking its variant with `is_none` [INFO] [stdout] --> src/mime_type/mod.rs:349:29 [INFO] [stdout] | [INFO] [stdout] 347 | if !boxed_extension.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 348 | let mp4_suffixes = vec![MimeType::MP4_SUFFIX, MimeType::M4V_SUFFIX, MimeType::M4P_SUFFIX]; [INFO] [stdout] 349 | let extension = boxed_extension.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_extension` after checking its variant with `is_none` [INFO] [stdout] --> src/mime_type/mod.rs:362:29 [INFO] [stdout] | [INFO] [stdout] 360 | if !boxed_extension.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 361 | let ogg_suffixes = vec![MimeType::OGG_SUFFIX, MimeType::OGV_SUFFIX]; [INFO] [stdout] 362 | let extension = boxed_extension.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_extension` after checking its variant with `is_none` [INFO] [stdout] --> src/mime_type/mod.rs:476:29 [INFO] [stdout] | [INFO] [stdout] 474 | if !boxed_extension.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 475 | let midi_suffixes = vec![MimeType::MIDI_SUFFIX, MimeType::MID_SUFFIX]; [INFO] [stdout] 476 | let extension = boxed_extension.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mime_type/mod.rs:645:9 [INFO] [stdout] | [INFO] [stdout] 645 | return MimeType::APPLICATION_OCTET_STREAM.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 645 - return MimeType::APPLICATION_OCTET_STREAM.to_string(); [INFO] [stdout] 645 + MimeType::APPLICATION_OCTET_STREAM.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/range/tests.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 91 | let response_result_body : Vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 100 | response_result_body = [first_body, second_body].concat(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `response_result_body` here [INFO] [stdout] | [INFO] [stdout] 91 ~ [INFO] [stdout] 92 | let first_range = response.content_range_list.get(0).unwrap(); [INFO] [stdout] ... [INFO] [stdout] 99 | [INFO] [stdout] 100 ~ let response_result_body : Vec = [first_body, second_body].concat(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/range/tests.rs:92:23 [INFO] [stdout] | [INFO] [stdout] 92 | let first_range = response.content_range_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/range/tests.rs:180:23 [INFO] [stdout] | [INFO] [stdout] 180 | let first_range = response.content_range_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `content_range_list.get(0)` [INFO] [stdout] --> src/range/tests.rs:204:25 [INFO] [stdout] | [INFO] [stdout] 204 | let content_range = content_range_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/range/tests.rs:438:18 [INFO] [stdout] | [INFO] [stdout] 438 | let string = format!(" some string "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `" some string ".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/range/tests.rs:486:18 [INFO] [stdout] | [INFO] [stdout] 486 | let string = format!(""); [INFO] [stdout] | ^^^^^^^^^^^ help: consider using `String::new()`: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/range/tests.rs:515:5 [INFO] [stdout] | [INFO] [stdout] 515 | assert_eq!(false, boxed_value.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 515 - assert_eq!(false, boxed_value.is_ok()); [INFO] [stdout] 515 + assert!(!boxed_value.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/range/tests.rs:530:5 [INFO] [stdout] | [INFO] [stdout] 530 | assert_eq!(false, boxed_value.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 530 - assert_eq!(false, boxed_value.is_ok()); [INFO] [stdout] 530 + assert!(!boxed_value.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/range/tests.rs:545:5 [INFO] [stdout] | [INFO] [stdout] 545 | assert_eq!(false, boxed_value.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 545 - assert_eq!(false, boxed_value.is_ok()); [INFO] [stdout] 545 + assert!(!boxed_value.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/range/tests.rs:554:18 [INFO] [stdout] | [INFO] [stdout] 554 | let string = format!("abracadabra"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"abracadabra".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/range/tests.rs:556:5 [INFO] [stdout] | [INFO] [stdout] 556 | assert_eq!(false, boxed_value.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 556 - assert_eq!(false, boxed_value.is_ok()); [INFO] [stdout] 556 + assert!(!boxed_value.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `content_range_list.get(0)` [INFO] [stdout] --> src/range/tests.rs:602:23 [INFO] [stdout] | [INFO] [stdout] 602 | let first_range = content_range_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_start` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:87:35 [INFO] [stdout] | [INFO] [stdout] 86 | if boxed_start.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_start` [INFO] [stdout] 87 | range.start = boxed_start.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_end` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:100:33 [INFO] [stdout] | [INFO] [stdout] 99 | if boxed_end.is_ok() { [INFO] [stdout] | -------------------- help: try: `if let Ok() = boxed_end` [INFO] [stdout] 100 | range.end = boxed_end.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_range` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:188:29 [INFO] [stdout] | [INFO] [stdout] 187 | if boxed_range.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_range` [INFO] [stdout] 188 | let range = boxed_range.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_read` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:193:32 [INFO] [stdout] | [INFO] [stdout] 190 | if boxed_read.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = boxed_read` [INFO] [stdout] ... [INFO] [stdout] 193 | let body = boxed_read.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_split` after checking its variant with `is_some` [INFO] [stdout] --> src/range/mod.rs:289:45 [INFO] [stdout] | [INFO] [stdout] 288 | if boxed_split.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = boxed_split` [INFO] [stdout] 289 | let (_filename, path) = boxed_split.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range_list` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:299:38 [INFO] [stdout] | [INFO] [stdout] 298 | if boxed_content_range_list.is_ok() { [INFO] [stdout] | ----------------------------------- help: try: `if let Ok() = boxed_content_range_list` [INFO] [stdout] 299 | content_range_list = boxed_content_range_list.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:351:42 [INFO] [stdout] | [INFO] [stdout] 350 | if boxed_result.is_ok() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = boxed_result` [INFO] [stdout] 351 | let (start, end, size) = boxed_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:404:16 [INFO] [stdout] | [INFO] [stdout] 403 | return if boxed_result.is_ok() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = boxed_result` [INFO] [stdout] 404 | Ok(boxed_result.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/range/mod.rs:403:9 [INFO] [stdout] | [INFO] [stdout] 403 | / return if boxed_result.is_ok() { [INFO] [stdout] 404 | | Ok(boxed_result.unwrap()) [INFO] [stdout] 405 | | } else { [INFO] [stdout] 406 | | let error = boxed_result.err().unwrap(); [INFO] [stdout] 407 | | Err(error) [INFO] [stdout] 408 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 403 ~ if boxed_result.is_ok() { [INFO] [stdout] 404 + Ok(boxed_result.unwrap()) [INFO] [stdout] 405 + } else { [INFO] [stdout] 406 + let error = boxed_result.err().unwrap(); [INFO] [stdout] 407 + Err(error) [INFO] [stdout] 408 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:312:35 [INFO] [stdout] | [INFO] [stdout] 312 | let new_line_char_found = buffer.len() != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:327:43 [INFO] [stdout] | [INFO] [stdout] 327 | let content_range_is_not_parsed = content_range.body.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content_range.body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:335:42 [INFO] [stdout] | [INFO] [stdout] 335 | let content_type_is_not_parsed = content_range.content_type.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content_range.content_type.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:345:43 [INFO] [stdout] | [INFO] [stdout] 345 | let content_range_is_not_parsed = content_range.size.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content_range.size.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:366:16 [INFO] [stdout] | [INFO] [stdout] 366 | if string.trim().len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!string.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:375:39 [INFO] [stdout] | [INFO] [stdout] 375 | let content_range_is_parsed = content_range.size.len() != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content_range.size.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:376:38 [INFO] [stdout] | [INFO] [stdout] 376 | let content_type_is_parsed = content_range.content_type.len() != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content_range.content_type.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/range/mod.rs:415:9 [INFO] [stdout] | [INFO] [stdout] 415 | let start : i64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 442 | start = boxed_start.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `start` here [INFO] [stdout] | [INFO] [stdout] 415 ~ [INFO] [stdout] 416 | let end : i64; [INFO] [stdout] ... [INFO] [stdout] 441 | [INFO] [stdout] 442 ~ let start : i64 = boxed_start.unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/range/mod.rs:416:9 [INFO] [stdout] | [INFO] [stdout] 416 | let end : i64; [INFO] [stdout] | ^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 457 | end = boxed_end.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `end` here [INFO] [stdout] | [INFO] [stdout] 416 ~ [INFO] [stdout] 417 | let size : i64; [INFO] [stdout] ... [INFO] [stdout] 456 | [INFO] [stdout] 457 ~ let end : i64 = boxed_end.unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/range/mod.rs:417:9 [INFO] [stdout] | [INFO] [stdout] 417 | let size : i64; [INFO] [stdout] | ^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 464 | size = boxed_size.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `size` here [INFO] [stdout] | [INFO] [stdout] 417 ~ [INFO] [stdout] 418 | [INFO] [stdout] ... [INFO] [stdout] 463 | [INFO] [stdout] 464 ~ let size : i64 = boxed_size.unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/range/mod.rs:511:9 [INFO] [stdout] | [INFO] [stdout] 503 | / let content_range = ContentRange { [INFO] [stdout] 504 | | unit: Range::BYTES.to_string(), [INFO] [stdout] 505 | | range: Range { start: 0, end: length }, [INFO] [stdout] 506 | | size: length.to_string(), [INFO] [stdout] 507 | | body, [INFO] [stdout] 508 | | content_type: mime_type [INFO] [stdout] 509 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 510 | [INFO] [stdout] 511 | content_range [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 503 ~ [INFO] [stdout] 504 | [INFO] [stdout] 505 ~ ContentRange { [INFO] [stdout] 506 + unit: Range::BYTES.to_string(), [INFO] [stdout] 507 + range: Range { start: 0, end: length }, [INFO] [stdout] 508 + size: length.to_string(), [INFO] [stdout] 509 + body, [INFO] [stdout] 510 + content_type: mime_type [INFO] [stdout] 511 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/range/mod.rs:515:9 [INFO] [stdout] | [INFO] [stdout] 515 | let body: Vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 522 | body = boxed_file.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `body` here [INFO] [stdout] | [INFO] [stdout] 515 ~ [INFO] [stdout] 516 | let boxed_file = FileExt::read_file(filepath); [INFO] [stdout] ... [INFO] [stdout] 521 | [INFO] [stdout] 522 ~ let body: Vec = boxed_file.unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:614:42 [INFO] [stdout] | [INFO] [stdout] 613 | if boxed_result.is_ok() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = boxed_result` [INFO] [stdout] 614 | let (start, end, size) = boxed_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:689:16 [INFO] [stdout] | [INFO] [stdout] 688 | return if boxed_result.is_ok() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = boxed_result` [INFO] [stdout] 689 | Ok(boxed_result.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/range/mod.rs:688:9 [INFO] [stdout] | [INFO] [stdout] 688 | / return if boxed_result.is_ok() { [INFO] [stdout] 689 | | Ok(boxed_result.unwrap()) [INFO] [stdout] 690 | | } else { [INFO] [stdout] 691 | | let error = boxed_result.err().unwrap(); [INFO] [stdout] 692 | | Err(error) [INFO] [stdout] 693 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 688 ~ if boxed_result.is_ok() { [INFO] [stdout] 689 + Ok(boxed_result.unwrap()) [INFO] [stdout] 690 + } else { [INFO] [stdout] 691 + let error = boxed_result.err().unwrap(); [INFO] [stdout] 692 + Err(error) [INFO] [stdout] 693 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:540:35 [INFO] [stdout] | [INFO] [stdout] 540 | let new_line_char_found = buffer.len() != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:562:43 [INFO] [stdout] | [INFO] [stdout] 562 | let content_range_is_not_parsed = content_range.body.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content_range.body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:581:42 [INFO] [stdout] | [INFO] [stdout] 581 | let content_type_is_not_parsed = content_range.content_type.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content_range.content_type.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:608:43 [INFO] [stdout] | [INFO] [stdout] 608 | let content_range_is_not_parsed = content_range.size.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content_range.size.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:640:16 [INFO] [stdout] | [INFO] [stdout] 640 | if string.trim().len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!string.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:660:39 [INFO] [stdout] | [INFO] [stdout] 660 | let content_range_is_parsed = content_range.size.len() != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content_range.size.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:661:38 [INFO] [stdout] | [INFO] [stdout] 661 | let content_type_is_parsed = content_range.content_type.len() != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content_range.content_type.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:816:42 [INFO] [stdout] | [INFO] [stdout] 815 | if boxed_result.is_ok() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = boxed_result` [INFO] [stdout] 816 | let (start, end, size) = boxed_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/range/mod.rs:904:16 [INFO] [stdout] | [INFO] [stdout] 903 | return if boxed_result.is_ok() { [INFO] [stdout] | ----------------------- help: try: `if let Ok() = boxed_result` [INFO] [stdout] 904 | Ok(boxed_result.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/range/mod.rs:903:9 [INFO] [stdout] | [INFO] [stdout] 903 | / return if boxed_result.is_ok() { [INFO] [stdout] 904 | | Ok(boxed_result.unwrap()) [INFO] [stdout] 905 | | } else { [INFO] [stdout] 906 | | let error = boxed_result.err().unwrap(); [INFO] [stdout] 907 | | Err(error) [INFO] [stdout] 908 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 903 ~ if boxed_result.is_ok() { [INFO] [stdout] 904 + Ok(boxed_result.unwrap()) [INFO] [stdout] 905 + } else { [INFO] [stdout] 906 + let error = boxed_result.err().unwrap(); [INFO] [stdout] 907 + Err(error) [INFO] [stdout] 908 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/range/mod.rs:735:9 [INFO] [stdout] | [INFO] [stdout] 735 | bytes_read = bytes_read + bytes_offset as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += bytes_offset as i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:741:35 [INFO] [stdout] | [INFO] [stdout] 741 | let new_line_char_found = buffer.len() != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:757:43 [INFO] [stdout] | [INFO] [stdout] 757 | let content_range_is_not_parsed = content_range.body.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content_range.body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:759:12 [INFO] [stdout] | [INFO] [stdout] 759 | if string.trim().len() != 0 && !is_opening_boundary_read && !string.contains(boundary.as_str()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!string.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:783:42 [INFO] [stdout] | [INFO] [stdout] 783 | let content_type_is_not_parsed = content_range.content_type.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content_range.content_type.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:810:43 [INFO] [stdout] | [INFO] [stdout] 810 | let content_range_is_not_parsed = content_range.size.len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `content_range.size.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:842:16 [INFO] [stdout] | [INFO] [stdout] 842 | if string.trim().len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!string.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:848:39 [INFO] [stdout] | [INFO] [stdout] 848 | let content_range_is_parsed = content_range.size.len() != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content_range.size.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/range/mod.rs:849:38 [INFO] [stdout] | [INFO] [stdout] 849 | let content_type_is_parsed = content_range.content_type.len() != 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!content_range.content_type.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/range/mod.rs:863:17 [INFO] [stdout] | [INFO] [stdout] 863 | bytes_read = bytes_read + _bytes_offset as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += _bytes_offset as i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/request/tests.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | assert_eq!(true, boxed_request.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 103 - assert_eq!(true, boxed_request.is_err()); [INFO] [stdout] 103 + assert!(boxed_request.is_err()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/request/tests.rs:111:5 [INFO] [stdout] | [INFO] [stdout] 111 | assert_eq!(true, boxed_request.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 111 - assert_eq!(true, boxed_request.is_err()); [INFO] [stdout] 111 + assert!(boxed_request.is_err()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/request/tests.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 120 | assert_eq!(true, boxed_request.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 120 - assert_eq!(true, boxed_request.is_err()); [INFO] [stdout] 120 + assert!(boxed_request.is_err()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/request/tests.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 129 | assert_eq!(true, boxed_request.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 129 - assert_eq!(true, boxed_request.is_err()); [INFO] [stdout] 129 + assert!(boxed_request.is_err()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/request/tests.rs:184:5 [INFO] [stdout] | [INFO] [stdout] 184 | assert_eq!(true, boxed_request.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 184 - assert_eq!(true, boxed_request.is_err()); [INFO] [stdout] 184 + assert!(boxed_request.is_err()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/request/tests.rs:344:16 [INFO] [stdout] | [INFO] [stdout] 344 | let body = format!("some=1234&key=5678"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"some=1234&key=5678".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_second_param` after checking its variant with `is_some` [INFO] [stdout] --> src/request/example/mod.rs:162:38 [INFO] [stdout] | [INFO] [stdout] 161 | if boxed_second_param.is_some() { [INFO] [stdout] | ------------------------------- help: try: `if let Some() = boxed_second_param` [INFO] [stdout] 162 | let second_param : &String = boxed_second_param.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/request/mod.rs:228:9 [INFO] [stdout] | [INFO] [stdout] 228 | / return match Request::cursor_read(&mut cursor, iteration_number, &mut request, content_length) { [INFO] [stdout] 229 | | Ok(_) => { [INFO] [stdout] 230 | | Ok(request) [INFO] [stdout] ... | [INFO] [stdout] 235 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 228 ~ match Request::cursor_read(&mut cursor, iteration_number, &mut request, content_length) { [INFO] [stdout] 229 + Ok(_) => { [INFO] [stdout] 230 + Ok(request) [INFO] [stdout] 231 + } [INFO] [stdout] 232 + Err(error_message) => { [INFO] [stdout] 233 + Err(error_message) [INFO] [stdout] 234 + } [INFO] [stdout] 235 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/request/mod.rs:298:39 [INFO] [stdout] | [INFO] [stdout] 298 | let current_string_is_empty = string.trim().len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `string.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/request/mod.rs:285:108 [INFO] [stdout] | [INFO] [stdout] 285 | ...&mut Request, mut content_length: usize) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_content_length` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/request/mod.rs:328:86 [INFO] [stdout] | [INFO] [stdout] 328 | let boxed_read = Request::cursor_read(cursor, iteration_number, request, content_length); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/response/tests.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | assert_eq!(true, is_multipart); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 22 - assert_eq!(true, is_multipart); [INFO] [stdout] 22 + assert!(is_multipart); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/response/tests.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | assert!(!boxed_parse.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_parse.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless call to `as_bytes` [INFO] [stdout] --> src/response/tests.rs:122:18 [INFO] [stdout] | [INFO] [stdout] 122 | end: message_body.as_bytes().len() as u64 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `message_body.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] = note: `#[warn(clippy::needless_as_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless call to `as_bytes` [INFO] [stdout] --> src/response/tests.rs:124:15 [INFO] [stdout] | [INFO] [stdout] 124 | size: message_body.as_bytes().len().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `message_body.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/response/tests.rs:160:50 [INFO] [stdout] | [INFO] [stdout] 160 | assert_eq!(message_body.as_bytes().to_vec(), response.content_range_list.get(0).unwrap().body); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/response/tests.rs:229:26 [INFO] [stdout] | [INFO] [stdout] 229 | assert_eq!(contents, response.content_range_list.get(0).unwrap().body); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `body.get(0)` [INFO] [stdout] --> src/response/example/mod.rs:39:38 [INFO] [stdout] | [INFO] [stdout] 39 | let first_part : &ContentRange = body.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `body.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:394:9 [INFO] [stdout] | [INFO] [stdout] 394 | / return if is_head || is_options { [INFO] [stdout] 395 | | response_without_body.into_bytes() [INFO] [stdout] 396 | | } else { [INFO] [stdout] 397 | | [response_without_body.into_bytes(), body].concat() [INFO] [stdout] 398 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 394 ~ if is_head || is_options { [INFO] [stdout] 395 + response_without_body.into_bytes() [INFO] [stdout] 396 + } else { [INFO] [stdout] 397 + [response_without_body.into_bytes(), body].concat() [INFO] [stdout] 398 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:418:9 [INFO] [stdout] | [INFO] [stdout] 418 | return response; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 418 - return response; [INFO] [stdout] 418 + response [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:471:9 [INFO] [stdout] | [INFO] [stdout] 471 | return Ok((http_version.to_string(), status_code_i16, reason_phrase.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 471 - return Ok((http_version.to_string(), status_code_i16, reason_phrase.to_string())) [INFO] [stdout] 471 + Ok((http_version.to_string(), status_code_i16, reason_phrase.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:453:21 [INFO] [stdout] | [INFO] [stdout] 453 | return x.status_code == &status_code_i16 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 453 - return x.status_code == &status_code_i16 [INFO] [stdout] 453 + x.status_code == &status_code_i16 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_value` after checking its variant with `is_ok` [INFO] [stdout] --> src/response/mod.rs:534:34 [INFO] [stdout] | [INFO] [stdout] 533 | if boxed_value.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_value` [INFO] [stdout] 534 | range_list = boxed_value.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/response/mod.rs:505:39 [INFO] [stdout] | [INFO] [stdout] 505 | let current_string_is_empty = string.trim().len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `string.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/response/mod.rs:524:80 [INFO] [stdout] | [INFO] [stdout] 524 | let is_multipart = Response::_is_multipart_byteranges_content_type(&content_type); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `content_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `eprintln!` args [INFO] [stdout] --> src/response/mod.rs:556:63 [INFO] [stdout] | [INFO] [stdout] 556 | eprintln!("error reading file: {}", reason.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/response/mod.rs:491:13 [INFO] [stdout] | [INFO] [stdout] 491 | mut content_length: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_content_length` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/response/mod.rs:575:90 [INFO] [stdout] | [INFO] [stdout] 575 | Response::_parse_raw_response_via_cursor(cursor, iteration_number, response, content_length); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/response/mod.rs:587:9 [INFO] [stdout] | [INFO] [stdout] 586 | let is_multipart_byteranges = content_type.value.starts_with(&multipart_byteranges); [INFO] [stdout] | ------------------------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 587 | is_multipart_byteranges [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 586 ~ [INFO] [stdout] 587 ~ content_type.value.starts_with(&multipart_byteranges) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_header_list` after checking its variant with `is_some` [INFO] [stdout] --> src/response/mod.rs:598:27 [INFO] [stdout] | [INFO] [stdout] 597 | if boxed_header_list.is_some() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = boxed_header_list` [INFO] [stdout] 598 | header_list = boxed_header_list.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_content_range_list` after checking its variant with `is_some` [INFO] [stdout] --> src/response/mod.rs:603:34 [INFO] [stdout] | [INFO] [stdout] 602 | if boxed_content_range_list.is_some() { [INFO] [stdout] | ------------------------------------- help: try: `if let Some() = boxed_content_range_list` [INFO] [stdout] 603 | content_range_list = boxed_content_range_list.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/response/mod.rs:614:9 [INFO] [stdout] | [INFO] [stdout] 606 | / let response = Response { [INFO] [stdout] 607 | | http_version: VERSION.http_1_1.to_string(), [INFO] [stdout] 608 | | status_code: *status_code_reason_phrase.status_code, [INFO] [stdout] 609 | | reason_phrase: status_code_reason_phrase.reason_phrase.to_string(), [INFO] [stdout] 610 | | headers: header_list, [INFO] [stdout] 611 | | content_range_list [INFO] [stdout] 612 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 613 | [INFO] [stdout] 614 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 606 ~ [INFO] [stdout] 607 | [INFO] [stdout] 608 ~ Response { [INFO] [stdout] 609 + http_version: VERSION.http_1_1.to_string(), [INFO] [stdout] 610 + status_code: *status_code_reason_phrase.status_code, [INFO] [stdout] 611 + reason_phrase: status_code_reason_phrase.reason_phrase.to_string(), [INFO] [stdout] 612 + headers: header_list, [INFO] [stdout] 613 + content_range_list [INFO] [stdout] 614 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:725:9 [INFO] [stdout] | [INFO] [stdout] 725 | return Ok(response); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 725 - return Ok(response); [INFO] [stdout] 725 + Ok(response) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:862:13 [INFO] [stdout] | [INFO] [stdout] 862 | ... return Response::parse_raw_response_via_cursor(cursor, iteration_number, response, content_length, total_bytes, bytes_read ); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 862 - return Response::parse_raw_response_via_cursor(cursor, iteration_number, response, content_length, total_bytes, bytes_read ); [INFO] [stdout] 862 + Response::parse_raw_response_via_cursor(cursor, iteration_number, response, content_length, total_bytes, bytes_read ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:864:13 [INFO] [stdout] | [INFO] [stdout] 864 | return Err("unable to parse".to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 864 - return Err("unable to parse".to_string()); [INFO] [stdout] 864 + Err("unable to parse".to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/response/mod.rs:743:9 [INFO] [stdout] | [INFO] [stdout] 743 | bytes_read = bytes_read + bytes_offset as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += bytes_offset as i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/response/mod.rs:757:39 [INFO] [stdout] | [INFO] [stdout] 757 | let current_string_is_empty = string.trim().len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `string.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/response/mod.rs:782:80 [INFO] [stdout] | [INFO] [stdout] 782 | is_multipart = Response::_is_multipart_byteranges_content_type(&content_type_header); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `content_type_header` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/response/mod.rs:822:17 [INFO] [stdout] | [INFO] [stdout] 822 | bytes_read = bytes_read + bytes_offset as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += bytes_offset as i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/response/mod.rs:732:13 [INFO] [stdout] | [INFO] [stdout] 732 | mut content_length: usize, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_content_length` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/response/mod.rs:862:96 [INFO] [stdout] | [INFO] [stdout] 862 | ... return Response::parse_raw_response_via_cursor(cursor, iteration_number, response, content_length, total_bytes, bytes_read ); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/response/mod.rs:875:73 [INFO] [stdout] | [INFO] [stdout] 875 | let header_value = StringExt::truncate_new_line_carriage_return(&raw_header_value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `raw_header_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/server/tests.rs:74:51 [INFO] [stdout] | [INFO] [stdout] 74 | let request: Request = Request::parse_request(&raw_request.as_bytes()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `raw_request.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/server/tests.rs:87:48 [INFO] [stdout] | [INFO] [stdout] 87 | let response_html_file= fs::read_to_string(response_filepath.to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `response_filepath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/server/tests.rs:109:56 [INFO] [stdout] | [INFO] [stdout] 109 | assert_eq!(response_html_file.as_bytes().to_vec(), response.content_range_list.get(0).unwrap().body); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/server/tests.rs:140:51 [INFO] [stdout] | [INFO] [stdout] 140 | let request: Request = Request::parse_request(&raw_request.as_bytes()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `raw_request.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/server/tests.rs:153:48 [INFO] [stdout] | [INFO] [stdout] 153 | let response_html_file= fs::read_to_string(response_filepath.to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `response_filepath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/server/tests.rs:175:56 [INFO] [stdout] | [INFO] [stdout] 175 | assert_eq!(response_html_file.as_bytes().to_vec(), response.content_range_list.get(0).unwrap().body); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/server/tests.rs:207:51 [INFO] [stdout] | [INFO] [stdout] 207 | let request: Request = Request::parse_request(&raw_request.as_bytes()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `raw_request.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/server/tests.rs:224:48 [INFO] [stdout] | [INFO] [stdout] 224 | let response_html_file= fs::read_to_string(response_filepath.to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&response_filepath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/server/tests.rs:248:49 [INFO] [stdout] | [INFO] [stdout] 248 | assert_eq!(response_html_file.into_bytes(), response.content_range_list.get(0).unwrap().body); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/server/tests.rs:278:51 [INFO] [stdout] | [INFO] [stdout] 278 | let request: Request = Request::parse_request(&raw_request.as_bytes()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `raw_request.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/server/tests.rs:296:48 [INFO] [stdout] | [INFO] [stdout] 296 | let response_html_file= fs::read_to_string(response_filepath.to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&response_filepath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/server/tests.rs:319:56 [INFO] [stdout] | [INFO] [stdout] 319 | assert_eq!(response_html_file.as_bytes().to_vec(), response.content_range_list.get(0).unwrap().body); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/server/tests.rs:349:51 [INFO] [stdout] | [INFO] [stdout] 349 | let request: Request = Request::parse_request(&raw_request.as_bytes()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `raw_request.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/server/tests.rs:367:48 [INFO] [stdout] | [INFO] [stdout] 367 | let response_html_file= fs::read_to_string(response_filepath.to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&response_filepath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/server/tests.rs:390:49 [INFO] [stdout] | [INFO] [stdout] 390 | assert_eq!(response_html_file.into_bytes(), response.content_range_list.get(0).unwrap().body); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/server/tests.rs:420:51 [INFO] [stdout] | [INFO] [stdout] 420 | let request: Request = Request::parse_request(&raw_request.as_bytes()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `raw_request.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/server/tests.rs:438:48 [INFO] [stdout] | [INFO] [stdout] 438 | let response_html_file= fs::read_to_string(response_filepath.to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&response_filepath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/server/tests.rs:461:49 [INFO] [stdout] | [INFO] [stdout] 461 | assert_eq!(response_html_file.into_bytes(), response.content_range_list.get(0).unwrap().body); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/server/tests.rs:491:51 [INFO] [stdout] | [INFO] [stdout] 491 | let request: Request = Request::parse_request(&raw_request.as_bytes()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `raw_request.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/server/tests.rs:509:48 [INFO] [stdout] | [INFO] [stdout] 509 | let response_html_file= fs::read_to_string(response_filepath.to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&response_filepath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/server/tests.rs:532:49 [INFO] [stdout] | [INFO] [stdout] 532 | assert_eq!(response_html_file.into_bytes(), response.content_range_list.get(0).unwrap().body); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/server/tests.rs:567:25 [INFO] [stdout] | [INFO] [stdout] 567 | let response_body = response.content_range_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/server/tests.rs:599:51 [INFO] [stdout] | [INFO] [stdout] 599 | let request: Request = Request::parse_request(&raw_request.as_bytes()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `raw_request.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/server/tests.rs:616:48 [INFO] [stdout] | [INFO] [stdout] 616 | let response_html_file= fs::read_to_string(response_filepath.to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&response_filepath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/server/tests.rs:640:49 [INFO] [stdout] | [INFO] [stdout] 640 | assert_eq!(response_html_file.into_bytes(), response.content_range_list.get(0).unwrap().body); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/server/tests.rs:670:51 [INFO] [stdout] | [INFO] [stdout] 670 | let request: Request = Request::parse_request(&raw_request.as_bytes()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `raw_request.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/server/tests.rs:687:48 [INFO] [stdout] | [INFO] [stdout] 687 | let response_html_file= fs::read_to_string(response_filepath.to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&response_filepath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/server/tests.rs:710:19 [INFO] [stdout] | [INFO] [stdout] 710 | assert_eq!(0, response.content_range_list.get(0).unwrap().range.end); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/server/tests.rs:711:21 [INFO] [stdout] | [INFO] [stdout] 711 | assert_eq!("0", response.content_range_list.get(0).unwrap().size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/server/tests.rs:744:51 [INFO] [stdout] | [INFO] [stdout] 744 | let request: Request = Request::parse_request(&raw_request.as_bytes()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `raw_request.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/server/tests.rs:761:48 [INFO] [stdout] | [INFO] [stdout] 761 | let response_html_file= fs::read_to_string(response_filepath.to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&response_filepath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/server/tests.rs:784:49 [INFO] [stdout] | [INFO] [stdout] 784 | assert_eq!(response_html_file.into_bytes(), response.content_range_list.get(0).unwrap().body); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/server/tests.rs:817:51 [INFO] [stdout] | [INFO] [stdout] 817 | let request: Request = Request::parse_request(&raw_request.as_bytes()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `raw_request.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/server/tests.rs:834:48 [INFO] [stdout] | [INFO] [stdout] 834 | let response_html_file= fs::read_to_string(response_filepath.to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&response_filepath` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/server/tests.rs:857:49 [INFO] [stdout] | [INFO] [stdout] 857 | assert_eq!(response_html_file.into_bytes(), response.content_range_list.get(0).unwrap().body); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/server/tests.rs:923:25 [INFO] [stdout] | [INFO] [stdout] 923 | let content_range = response.content_range_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/server/tests.rs:990:25 [INFO] [stdout] | [INFO] [stdout] 990 | let content_range = response.content_range_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/server/tests.rs:1057:25 [INFO] [stdout] | [INFO] [stdout] 1057 | let content_range = response.content_range_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/server/tests.rs:1124:25 [INFO] [stdout] | [INFO] [stdout] 1124 | let content_range = response.content_range_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/server/tests.rs:1191:25 [INFO] [stdout] | [INFO] [stdout] 1191 | let content_range = response.content_range_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/server/tests.rs:1207:30 [INFO] [stdout] | [INFO] [stdout] 1207 | let range_header_value = format!("bytes=zaksd"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"bytes=zaksd".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/server/tests.rs:1253:25 [INFO] [stdout] | [INFO] [stdout] 1253 | let content_range = response.content_range_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/mod.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | return response; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return response; [INFO] [stdout] 104 + response [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_local_addr` after checking its variant with `is_ok` [INFO] [stdout] --> src/server/mod.rs:248:42 [INFO] [stdout] | [INFO] [stdout] 247 | if boxed_local_addr.is_ok() { [INFO] [stdout] | --------------------------- help: try: `if let Ok() = boxed_local_addr` [INFO] [stdout] 248 | print!("local addr: {}", boxed_local_addr.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `print!` args [INFO] [stdout] --> src/server/mod.rs:260:50 [INFO] [stdout] | [INFO] [stdout] 260 | print!(", peer addr: {}\n", peer_addr.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/server/mod.rs:260:13 [INFO] [stdout] | [INFO] [stdout] 260 | print!(", peer addr: {}\n", peer_addr.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 260 - print!(", peer addr: {}\n", peer_addr.to_string()); [INFO] [stdout] 260 + println!(", peer addr: {}", peer_addr.to_string()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_send` after checking its variant with `is_err` [INFO] [stdout] --> src/thread_pool/mod.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 39 | if boxed_send.is_err() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_send` [INFO] [stdout] ... [INFO] [stdout] 42 | boxed_send.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_lock` after checking its variant with `is_err` [INFO] [stdout] --> src/thread_pool/mod.rs:63:33 [INFO] [stdout] | [INFO] [stdout] 60 | if boxed_lock.is_err() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_lock` [INFO] [stdout] ... [INFO] [stdout] 63 | let boxed_job = boxed_lock.unwrap().recv(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_job` after checking its variant with `is_err` [INFO] [stdout] --> src/thread_pool/mod.rs:67:31 [INFO] [stdout] | [INFO] [stdout] 64 | if boxed_job.is_err() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = boxed_job` [INFO] [stdout] ... [INFO] [stdout] 67 | let job = boxed_job.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_parse` after checking its variant with `is_ok` [INFO] [stdout] --> src/log/mod.rs:46:41 [INFO] [stdout] | [INFO] [stdout] 45 | if boxed_parse.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_parse` [INFO] [stdout] 46 | response_body_length += boxed_parse.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/log/mod.rs:17:16 [INFO] [stdout] | [INFO] [stdout] 17 | if &header.name.chars().count() > &0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 17 - if &header.name.chars().count() > &0 { [INFO] [stdout] 17 + if header.name.chars().count() > 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of both operands [INFO] [stdout] --> src/log/mod.rs:30:16 [INFO] [stdout] | [INFO] [stdout] 30 | if &header.name.chars().count() > &0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] help: use the values directly [INFO] [stdout] | [INFO] [stdout] 30 - if &header.name.chars().count() > &0 { [INFO] [stdout] 30 + if header.name.chars().count() > 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `part_list.get(0)` [INFO] [stdout] --> src/body/multipart_form_data/tests.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | let first_part = part_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `part_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `part_list.get(0)` [INFO] [stdout] --> src/body/multipart_form_data/tests.rs:138:22 [INFO] [stdout] | [INFO] [stdout] 138 | let first_part = part_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `part_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `part_list.get(0)` [INFO] [stdout] --> src/body/multipart_form_data/tests.rs:186:22 [INFO] [stdout] | [INFO] [stdout] 186 | let first_part = part_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `part_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `part_list.get(0)` [INFO] [stdout] --> src/body/multipart_form_data/tests.rs:234:22 [INFO] [stdout] | [INFO] [stdout] 234 | let first_part = part_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `part_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `part_list.get(0)` [INFO] [stdout] --> src/body/multipart_form_data/tests.rs:321:22 [INFO] [stdout] | [INFO] [stdout] 321 | let first_part = part_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `part_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `form.get(0)` [INFO] [stdout] --> src/body/multipart_form_data/tests.rs:589:22 [INFO] [stdout] | [INFO] [stdout] 589 | let first_part = form.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `form.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_sequence` after checking its variant with `is_some` [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:173:42 [INFO] [stdout] | [INFO] [stdout] 171 | if boxed_sequence.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = boxed_sequence` [INFO] [stdout] 172 | current_string_is_boundary = true; [INFO] [stdout] 173 | _boundary_position = boxed_sequence.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | bytes_read = bytes_read + bytes_offset as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += bytes_offset as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | bytes_read = bytes_read + bytes_offset as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += bytes_offset as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:111:39 [INFO] [stdout] | [INFO] [stdout] 111 | current_string_is_empty = string.trim().len() == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `string.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i128` -> `i128`) [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:122:30 [INFO] [stdout] | [INFO] [stdout] 122 | if bytes_read == total_bytes as i128 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `total_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:128:43 [INFO] [stdout] | [INFO] [stdout] 128 | if current_string_is_empty && part.headers.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `part.headers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:164:13 [INFO] [stdout] | [INFO] [stdout] 164 | bytes_read = bytes_read + bytes_offset as i128; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bytes_read += bytes_offset as i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i128` -> `i128`) [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:183:57 [INFO] [stdout] | [INFO] [stdout] 183 | if !current_string_is_boundary && bytes_read == total_bytes as i128 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `total_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i128` -> `i128`) [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:215:26 [INFO] [stdout] | [INFO] [stdout] 215 | if bytes_read == total_bytes as i128 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `total_bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:239:12 [INFO] [stdout] | [INFO] [stdout] 239 | if part.headers.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `part.headers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:246:96 [INFO] [stdout] | [INFO] [stdout] 246 | let formatted = format!("{}{}", header.as_string(), SYMBOL.new_line_carriage_return.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/body/multipart_form_data/mod.rs:264:12 [INFO] [stdout] | [INFO] [stdout] 264 | if part_list.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `part_list.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.prop_f` after checking its variant with `is_some` [INFO] [stdout] --> src/body/example/example_object.rs:94:29 [INFO] [stdout] | [INFO] [stdout] 93 | if self.prop_f.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self.prop_f` [INFO] [stdout] 94 | let array = self.prop_f.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_json` after checking its variant with `is_ok` [INFO] [stdout] --> src/body/example/example_object.rs:97:32 [INFO] [stdout] | [INFO] [stdout] 96 | if boxed_json.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = boxed_json` [INFO] [stdout] 97 | let json = boxed_json.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.prop_g` after checking its variant with `is_some` [INFO] [stdout] --> src/body/example/example_object.rs:105:30 [INFO] [stdout] | [INFO] [stdout] 104 | if self.prop_g.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self.prop_g` [INFO] [stdout] 105 | let object = self.prop_g.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/body/example/example_object.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 67 | if property_name == "prop_a".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_a"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/body/example/example_object.rs:72:29 [INFO] [stdout] | [INFO] [stdout] 72 | if property_name == "prop_b".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_b"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/body/example/example_object.rs:77:29 [INFO] [stdout] | [INFO] [stdout] 77 | if property_name == "prop_c".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_c"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/body/example/example_object.rs:82:29 [INFO] [stdout] | [INFO] [stdout] 82 | if property_name == "prop_d".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_d"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/body/example/example_object.rs:87:29 [INFO] [stdout] | [INFO] [stdout] 87 | if property_name == "prop_e".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_e"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/body/example/example_object.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | / if property_name == "prop_f".to_string() { [INFO] [stdout] 93 | | if self.prop_f.is_some() { [INFO] [stdout] 94 | | let array = self.prop_f.as_ref().unwrap(); [INFO] [stdout] 95 | | let boxed_json = JSONArrayOfObjects::::to_json(array); [INFO] [stdout] ... | [INFO] [stdout] 101 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 92 ~ if property_name == "prop_f".to_string() [INFO] [stdout] 93 ~ && self.prop_f.is_some() { [INFO] [stdout] 94 | let array = self.prop_f.as_ref().unwrap(); [INFO] [stdout] ... [INFO] [stdout] 99 | } [INFO] [stdout] 100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/body/example/example_object.rs:92:29 [INFO] [stdout] | [INFO] [stdout] 92 | if property_name == "prop_f".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_f"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/body/example/example_object.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | / if property_name == "prop_g".to_string() { [INFO] [stdout] 104 | | if self.prop_g.is_some() { [INFO] [stdout] 105 | | let object = self.prop_g.as_ref().unwrap(); [INFO] [stdout] 106 | | let json = object.to_json_string(); [INFO] [stdout] ... | [INFO] [stdout] 109 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 103 ~ if property_name == "prop_g".to_string() [INFO] [stdout] 104 ~ && self.prop_g.is_some() { [INFO] [stdout] 105 | let object = self.prop_g.as_ref().unwrap(); [INFO] [stdout] 106 | let json = object.to_json_string(); [INFO] [stdout] 107 | value.object = Some(json); [INFO] [stdout] 108 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/body/example/example_object.rs:103:29 [INFO] [stdout] | [INFO] [stdout] 103 | if property_name == "prop_g".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_g"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.string` after checking its variant with `is_some` [INFO] [stdout] --> src/body/example/example_object.rs:146:35 [INFO] [stdout] | [INFO] [stdout] 145 | if value.string.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = value.string` [INFO] [stdout] 146 | self.prop_a = value.string.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.bool` after checking its variant with `is_some` [INFO] [stdout] --> src/body/example/example_object.rs:151:35 [INFO] [stdout] | [INFO] [stdout] 150 | if value.bool.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = value.bool` [INFO] [stdout] 151 | self.prop_b = value.bool.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.bool` after checking its variant with `is_some` [INFO] [stdout] --> src/body/example/example_object.rs:157:35 [INFO] [stdout] | [INFO] [stdout] 156 | if value.bool.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = value.bool` [INFO] [stdout] 157 | self.prop_c = value.bool.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.i128` after checking its variant with `is_some` [INFO] [stdout] --> src/body/example/example_object.rs:163:35 [INFO] [stdout] | [INFO] [stdout] 162 | if value.i128.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = value.i128` [INFO] [stdout] 163 | self.prop_d = value.i128.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.f64` after checking its variant with `is_some` [INFO] [stdout] --> src/body/example/example_object.rs:169:35 [INFO] [stdout] | [INFO] [stdout] 168 | if value.f64.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = value.f64` [INFO] [stdout] 169 | self.prop_e = value.f64.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.array` after checking its variant with `is_some` [INFO] [stdout] --> src/body/example/example_object.rs:176:92 [INFO] [stdout] | [INFO] [stdout] 175 | if value.array.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = value.array` [INFO] [stdout] 176 | let boxed_array = JSONArrayOfObjects::::from_json(value.array.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_array` after checking its variant with `is_ok` [INFO] [stdout] --> src/body/example/example_object.rs:178:44 [INFO] [stdout] | [INFO] [stdout] 177 | if boxed_array.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_array` [INFO] [stdout] 178 | self.prop_f = Some(boxed_array.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.object` after checking its variant with `is_some` [INFO] [stdout] --> src/body/example/example_object.rs:187:43 [INFO] [stdout] | [INFO] [stdout] 186 | if value.object.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = value.object` [INFO] [stdout] 187 | let unparsed_object = value.object.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/body/example/example_object.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 144 | / if property.property_name == "prop_a" { [INFO] [stdout] 145 | | if value.string.is_some() { [INFO] [stdout] 146 | | self.prop_a = value.string.unwrap(); [INFO] [stdout] 147 | | } [INFO] [stdout] 148 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 144 ~ if property.property_name == "prop_a" [INFO] [stdout] 145 ~ && value.string.is_some() { [INFO] [stdout] 146 | self.prop_a = value.string.unwrap(); [INFO] [stdout] 147 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/body/example/example_object.rs:149:13 [INFO] [stdout] | [INFO] [stdout] 149 | / if property.property_name == "prop_b" { [INFO] [stdout] 150 | | if value.bool.is_some() { [INFO] [stdout] 151 | | self.prop_b = value.bool.unwrap(); [INFO] [stdout] 152 | | } [INFO] [stdout] 153 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 149 ~ if property.property_name == "prop_b" [INFO] [stdout] 150 ~ && value.bool.is_some() { [INFO] [stdout] 151 | self.prop_b = value.bool.unwrap(); [INFO] [stdout] 152 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/body/example/example_object.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | / if property.property_name == "prop_c" { [INFO] [stdout] 156 | | if value.bool.is_some() { [INFO] [stdout] 157 | | self.prop_c = value.bool.unwrap(); [INFO] [stdout] 158 | | } [INFO] [stdout] 159 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 155 ~ if property.property_name == "prop_c" [INFO] [stdout] 156 ~ && value.bool.is_some() { [INFO] [stdout] 157 | self.prop_c = value.bool.unwrap(); [INFO] [stdout] 158 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/body/example/example_object.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | / if property.property_name == "prop_d" { [INFO] [stdout] 162 | | if value.i128.is_some() { [INFO] [stdout] 163 | | self.prop_d = value.i128.unwrap(); [INFO] [stdout] 164 | | } [INFO] [stdout] 165 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 161 ~ if property.property_name == "prop_d" [INFO] [stdout] 162 ~ && value.i128.is_some() { [INFO] [stdout] 163 | self.prop_d = value.i128.unwrap(); [INFO] [stdout] 164 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/body/example/example_object.rs:167:13 [INFO] [stdout] | [INFO] [stdout] 167 | / if property.property_name == "prop_e" { [INFO] [stdout] 168 | | if value.f64.is_some() { [INFO] [stdout] 169 | | self.prop_e = value.f64.unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 172 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 167 ~ if property.property_name == "prop_e" [INFO] [stdout] 168 ~ && value.f64.is_some() { [INFO] [stdout] 169 | self.prop_e = value.f64.unwrap(); [INFO] [stdout] 170 | [INFO] [stdout] 171 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/body/example/example_object.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 174 | / if property.property_name == "prop_f" { [INFO] [stdout] 175 | | if value.array.is_some() { [INFO] [stdout] 176 | | let boxed_array = JSONArrayOfObjects::::from_json(value.array.unwrap()); [INFO] [stdout] 177 | | if boxed_array.is_ok() { [INFO] [stdout] ... | [INFO] [stdout] 182 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 174 ~ if property.property_name == "prop_f" [INFO] [stdout] 175 ~ && value.array.is_some() { [INFO] [stdout] 176 | let boxed_array = JSONArrayOfObjects::::from_json(value.array.unwrap()); [INFO] [stdout] ... [INFO] [stdout] 180 | [INFO] [stdout] 181 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/body/example/example_nested_object.rs:51:29 [INFO] [stdout] | [INFO] [stdout] 51 | if property_name == "prop_a".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_a"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/body/example/example_nested_object.rs:56:29 [INFO] [stdout] | [INFO] [stdout] 56 | if property_name == "prop_b".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_b"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/body/example/example_nested_object.rs:62:29 [INFO] [stdout] | [INFO] [stdout] 62 | if property_name == "prop_d".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_d"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/body/example/example_nested_object.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 67 | if property_name == "prop_e".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_e"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.string` after checking its variant with `is_some` [INFO] [stdout] --> src/body/example/example_nested_object.rs:107:35 [INFO] [stdout] | [INFO] [stdout] 106 | if value.string.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = value.string` [INFO] [stdout] 107 | self.prop_a = value.string.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.bool` after checking its variant with `is_some` [INFO] [stdout] --> src/body/example/example_nested_object.rs:112:35 [INFO] [stdout] | [INFO] [stdout] 111 | if value.bool.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = value.bool` [INFO] [stdout] 112 | self.prop_b = value.bool.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.i128` after checking its variant with `is_some` [INFO] [stdout] --> src/body/example/example_nested_object.rs:119:35 [INFO] [stdout] | [INFO] [stdout] 118 | if value.i128.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = value.i128` [INFO] [stdout] 119 | self.prop_c = value.i128.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.f64` after checking its variant with `is_some` [INFO] [stdout] --> src/body/example/example_nested_object.rs:125:35 [INFO] [stdout] | [INFO] [stdout] 124 | if value.f64.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = value.f64` [INFO] [stdout] 125 | self.prop_d = value.f64.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/body/example/example_nested_object.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | / if property.property_name == "prop_a" { [INFO] [stdout] 106 | | if value.string.is_some() { [INFO] [stdout] 107 | | self.prop_a = value.string.unwrap(); [INFO] [stdout] 108 | | } [INFO] [stdout] 109 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 105 ~ if property.property_name == "prop_a" [INFO] [stdout] 106 ~ && value.string.is_some() { [INFO] [stdout] 107 | self.prop_a = value.string.unwrap(); [INFO] [stdout] 108 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/body/example/example_nested_object.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 110 | / if property.property_name == "prop_b" { [INFO] [stdout] 111 | | if value.bool.is_some() { [INFO] [stdout] 112 | | self.prop_b = value.bool.unwrap(); [INFO] [stdout] 113 | | } [INFO] [stdout] 114 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 110 ~ if property.property_name == "prop_b" [INFO] [stdout] 111 ~ && value.bool.is_some() { [INFO] [stdout] 112 | self.prop_b = value.bool.unwrap(); [INFO] [stdout] 113 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/body/example/example_nested_object.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | / if property.property_name == "prop_d" { [INFO] [stdout] 118 | | if value.i128.is_some() { [INFO] [stdout] 119 | | self.prop_c = value.i128.unwrap(); [INFO] [stdout] 120 | | } [INFO] [stdout] 121 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 117 ~ if property.property_name == "prop_d" [INFO] [stdout] 118 ~ && value.i128.is_some() { [INFO] [stdout] 119 | self.prop_c = value.i128.unwrap(); [INFO] [stdout] 120 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/body/example/example_nested_object.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | / if property.property_name == "prop_e" { [INFO] [stdout] 124 | | if value.f64.is_some() { [INFO] [stdout] 125 | | self.prop_d = value.f64.unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 128 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 123 ~ if property.property_name == "prop_e" [INFO] [stdout] 124 ~ && value.f64.is_some() { [INFO] [stdout] 125 | self.prop_d = value.f64.unwrap(); [INFO] [stdout] 126 | [INFO] [stdout] 127 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/body/example/mod.rs:62:41 [INFO] [stdout] | [INFO] [stdout] 62 | let response_body : &ContentRange = response.content_range_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/body/example/mod.rs:193:41 [INFO] [stdout] | [INFO] [stdout] 193 | let response_body : &ContentRange = response.content_range_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/body/example/mod.rs:332:41 [INFO] [stdout] | [INFO] [stdout] 332 | let response_body : &ContentRange = response.content_range_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `response.content_range_list.get(0)` [INFO] [stdout] --> src/body/example/mod.rs:372:41 [INFO] [stdout] | [INFO] [stdout] 372 | let response_body : &ContentRange = response.content_range_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response.content_range_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.f64` after checking its variant with `is_some` [INFO] [stdout] --> src/json/property/mod.rs:50:23 [INFO] [stdout] | [INFO] [stdout] 49 | if self.f64.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = self.f64` [INFO] [stdout] 50 | let f64 = self.f64.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.i128` after checking its variant with `is_some` [INFO] [stdout] --> src/json/property/mod.rs:56:29 [INFO] [stdout] | [INFO] [stdout] 55 | if self.i128.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = self.i128` [INFO] [stdout] 56 | let formatted = self.i128.unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.string` after checking its variant with `is_some` [INFO] [stdout] --> src/json/property/mod.rs:61:29 [INFO] [stdout] | [INFO] [stdout] 60 | if self.string.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self.string` [INFO] [stdout] 61 | let formatted = self.string.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.array` after checking its variant with `is_some` [INFO] [stdout] --> src/json/property/mod.rs:66:29 [INFO] [stdout] | [INFO] [stdout] 65 | if self.array.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = &self.array` [INFO] [stdout] 66 | let formatted = self.array.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.object` after checking its variant with `is_some` [INFO] [stdout] --> src/json/property/mod.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 74 | if self.object.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self.object` [INFO] [stdout] 75 | let formatted = self.object.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.bool` after checking its variant with `is_some` [INFO] [stdout] --> src/json/property/mod.rs:80:29 [INFO] [stdout] | [INFO] [stdout] 79 | if self.bool.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = &self.bool` [INFO] [stdout] 80 | let formatted = self.bool.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_f64_parse` after checking its variant with `is_err` [INFO] [stdout] --> src/json/property/mod.rs:149:31 [INFO] [stdout] | [INFO] [stdout] 143 | if boxed_f64_parse.is_err() { [INFO] [stdout] | --------------------------- help: try: `if let Ok() = boxed_f64_parse` [INFO] [stdout] ... [INFO] [stdout] 149 | let f64 = boxed_f64_parse.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_i128_parse` after checking its variant with `is_err` [INFO] [stdout] --> src/json/property/mod.rs:155:28 [INFO] [stdout] | [INFO] [stdout] 141 | if boxed_i128_parse.is_err() { [INFO] [stdout] | ---------------------------- help: try: `if let Ok() = boxed_i128_parse` [INFO] [stdout] ... [INFO] [stdout] 155 | let i128 = boxed_i128_parse.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/json_array_nested_object/some_object.rs:65:29 [INFO] [stdout] | [INFO] [stdout] 65 | if property_name == "prop_a".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_a"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/json_array_nested_object/some_object.rs:70:29 [INFO] [stdout] | [INFO] [stdout] 70 | if property_name == "prop_b".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_b"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/json/array/tests/json_array_nested_object/some_object.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 108 | let json= json_list.join(SYMBOL.new_line_carriage_return); [INFO] [stdout] | ---------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 109 | json [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 108 ~ [INFO] [stdout] 109 ~ json_list.join(SYMBOL.new_line_carriage_return) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `expected.get(0)` [INFO] [stdout] --> src/json/array/tests/json_array_nested_object/mod.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | let json = expected.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `expected.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/json/array/tests/json_array_nested_object/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | assert_eq!(true, obj.prop_b); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 22 - assert_eq!(true, obj.prop_b); [INFO] [stdout] 22 + assert!(obj.prop_b); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.prop_f` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:94:29 [INFO] [stdout] | [INFO] [stdout] 93 | if self.prop_f.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self.prop_f` [INFO] [stdout] 94 | let array = self.prop_f.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_json` after checking its variant with `is_ok` [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:97:32 [INFO] [stdout] | [INFO] [stdout] 96 | if boxed_json.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = boxed_json` [INFO] [stdout] 97 | let json = boxed_json.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.prop_g` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:105:30 [INFO] [stdout] | [INFO] [stdout] 104 | if self.prop_g.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self.prop_g` [INFO] [stdout] 105 | let object = self.prop_g.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 67 | if property_name == "prop_a".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_a"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:72:29 [INFO] [stdout] | [INFO] [stdout] 72 | if property_name == "prop_b".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_b"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:77:29 [INFO] [stdout] | [INFO] [stdout] 77 | if property_name == "prop_c".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_c"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:82:29 [INFO] [stdout] | [INFO] [stdout] 82 | if property_name == "prop_d".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_d"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:87:29 [INFO] [stdout] | [INFO] [stdout] 87 | if property_name == "prop_e".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_e"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | / if property_name == "prop_f".to_string() { [INFO] [stdout] 93 | | if self.prop_f.is_some() { [INFO] [stdout] 94 | | let array = self.prop_f.as_ref().unwrap(); [INFO] [stdout] 95 | | let boxed_json = JSONArrayOfObjects::::to_json(array); [INFO] [stdout] ... | [INFO] [stdout] 101 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 92 ~ if property_name == "prop_f".to_string() [INFO] [stdout] 93 ~ && self.prop_f.is_some() { [INFO] [stdout] 94 | let array = self.prop_f.as_ref().unwrap(); [INFO] [stdout] ... [INFO] [stdout] 99 | } [INFO] [stdout] 100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:92:29 [INFO] [stdout] | [INFO] [stdout] 92 | if property_name == "prop_f".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_f"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | / if property_name == "prop_g".to_string() { [INFO] [stdout] 104 | | if self.prop_g.is_some() { [INFO] [stdout] 105 | | let object = self.prop_g.as_ref().unwrap(); [INFO] [stdout] 106 | | let json = object.to_json_string(); [INFO] [stdout] ... | [INFO] [stdout] 109 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 103 ~ if property_name == "prop_g".to_string() [INFO] [stdout] 104 ~ && self.prop_g.is_some() { [INFO] [stdout] 105 | let object = self.prop_g.as_ref().unwrap(); [INFO] [stdout] 106 | let json = object.to_json_string(); [INFO] [stdout] 107 | value.object = Some(json); [INFO] [stdout] 108 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:103:29 [INFO] [stdout] | [INFO] [stdout] 103 | if property_name == "prop_g".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_g"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.string` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:146:35 [INFO] [stdout] | [INFO] [stdout] 145 | if value.string.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = value.string` [INFO] [stdout] 146 | self.prop_a = value.string.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.bool` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:151:35 [INFO] [stdout] | [INFO] [stdout] 150 | if value.bool.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = value.bool` [INFO] [stdout] 151 | self.prop_b = value.bool.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.bool` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:157:35 [INFO] [stdout] | [INFO] [stdout] 156 | if value.bool.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = value.bool` [INFO] [stdout] 157 | self.prop_c = value.bool.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.i128` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:163:35 [INFO] [stdout] | [INFO] [stdout] 162 | if value.i128.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = value.i128` [INFO] [stdout] 163 | self.prop_d = value.i128.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.f64` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:169:35 [INFO] [stdout] | [INFO] [stdout] 168 | if value.f64.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = value.f64` [INFO] [stdout] 169 | self.prop_e = value.f64.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.array` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:176:92 [INFO] [stdout] | [INFO] [stdout] 175 | if value.array.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = value.array` [INFO] [stdout] 176 | let boxed_array = JSONArrayOfObjects::::from_json(value.array.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_array` after checking its variant with `is_ok` [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:178:44 [INFO] [stdout] | [INFO] [stdout] 177 | if boxed_array.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_array` [INFO] [stdout] 178 | self.prop_f = Some(boxed_array.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.object` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:187:43 [INFO] [stdout] | [INFO] [stdout] 186 | if value.object.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = value.object` [INFO] [stdout] 187 | let unparsed_object = value.object.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 144 | / if property.property_name == "prop_a" { [INFO] [stdout] 145 | | if value.string.is_some() { [INFO] [stdout] 146 | | self.prop_a = value.string.unwrap(); [INFO] [stdout] 147 | | } [INFO] [stdout] 148 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 144 ~ if property.property_name == "prop_a" [INFO] [stdout] 145 ~ && value.string.is_some() { [INFO] [stdout] 146 | self.prop_a = value.string.unwrap(); [INFO] [stdout] 147 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:149:13 [INFO] [stdout] | [INFO] [stdout] 149 | / if property.property_name == "prop_b" { [INFO] [stdout] 150 | | if value.bool.is_some() { [INFO] [stdout] 151 | | self.prop_b = value.bool.unwrap(); [INFO] [stdout] 152 | | } [INFO] [stdout] 153 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 149 ~ if property.property_name == "prop_b" [INFO] [stdout] 150 ~ && value.bool.is_some() { [INFO] [stdout] 151 | self.prop_b = value.bool.unwrap(); [INFO] [stdout] 152 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | / if property.property_name == "prop_c" { [INFO] [stdout] 156 | | if value.bool.is_some() { [INFO] [stdout] 157 | | self.prop_c = value.bool.unwrap(); [INFO] [stdout] 158 | | } [INFO] [stdout] 159 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 155 ~ if property.property_name == "prop_c" [INFO] [stdout] 156 ~ && value.bool.is_some() { [INFO] [stdout] 157 | self.prop_c = value.bool.unwrap(); [INFO] [stdout] 158 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | / if property.property_name == "prop_d" { [INFO] [stdout] 162 | | if value.i128.is_some() { [INFO] [stdout] 163 | | self.prop_d = value.i128.unwrap(); [INFO] [stdout] 164 | | } [INFO] [stdout] 165 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 161 ~ if property.property_name == "prop_d" [INFO] [stdout] 162 ~ && value.i128.is_some() { [INFO] [stdout] 163 | self.prop_d = value.i128.unwrap(); [INFO] [stdout] 164 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:167:13 [INFO] [stdout] | [INFO] [stdout] 167 | / if property.property_name == "prop_e" { [INFO] [stdout] 168 | | if value.f64.is_some() { [INFO] [stdout] 169 | | self.prop_e = value.f64.unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 172 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 167 ~ if property.property_name == "prop_e" [INFO] [stdout] 168 ~ && value.f64.is_some() { [INFO] [stdout] 169 | self.prop_e = value.f64.unwrap(); [INFO] [stdout] 170 | [INFO] [stdout] 171 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example/example_object.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 174 | / if property.property_name == "prop_f" { [INFO] [stdout] 175 | | if value.array.is_some() { [INFO] [stdout] 176 | | let boxed_array = JSONArrayOfObjects::::from_json(value.array.unwrap()); [INFO] [stdout] 177 | | if boxed_array.is_ok() { [INFO] [stdout] ... | [INFO] [stdout] 182 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 174 ~ if property.property_name == "prop_f" [INFO] [stdout] 175 ~ && value.array.is_some() { [INFO] [stdout] 176 | let boxed_array = JSONArrayOfObjects::::from_json(value.array.unwrap()); [INFO] [stdout] ... [INFO] [stdout] 180 | [INFO] [stdout] 181 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example/example_nested_object.rs:51:29 [INFO] [stdout] | [INFO] [stdout] 51 | if property_name == "prop_a".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_a"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example/example_nested_object.rs:56:29 [INFO] [stdout] | [INFO] [stdout] 56 | if property_name == "prop_b".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_b"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example/example_nested_object.rs:62:29 [INFO] [stdout] | [INFO] [stdout] 62 | if property_name == "prop_d".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_d"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example/example_nested_object.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 67 | if property_name == "prop_e".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_e"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.string` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example/example_nested_object.rs:107:35 [INFO] [stdout] | [INFO] [stdout] 106 | if value.string.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = value.string` [INFO] [stdout] 107 | self.prop_a = value.string.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.bool` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example/example_nested_object.rs:112:35 [INFO] [stdout] | [INFO] [stdout] 111 | if value.bool.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = value.bool` [INFO] [stdout] 112 | self.prop_b = value.bool.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.i128` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example/example_nested_object.rs:119:35 [INFO] [stdout] | [INFO] [stdout] 118 | if value.i128.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = value.i128` [INFO] [stdout] 119 | self.prop_c = value.i128.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.f64` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example/example_nested_object.rs:125:35 [INFO] [stdout] | [INFO] [stdout] 124 | if value.f64.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = value.f64` [INFO] [stdout] 125 | self.prop_d = value.f64.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example/example_nested_object.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | / if property.property_name == "prop_a" { [INFO] [stdout] 106 | | if value.string.is_some() { [INFO] [stdout] 107 | | self.prop_a = value.string.unwrap(); [INFO] [stdout] 108 | | } [INFO] [stdout] 109 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 105 ~ if property.property_name == "prop_a" [INFO] [stdout] 106 ~ && value.string.is_some() { [INFO] [stdout] 107 | self.prop_a = value.string.unwrap(); [INFO] [stdout] 108 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example/example_nested_object.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 110 | / if property.property_name == "prop_b" { [INFO] [stdout] 111 | | if value.bool.is_some() { [INFO] [stdout] 112 | | self.prop_b = value.bool.unwrap(); [INFO] [stdout] 113 | | } [INFO] [stdout] 114 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 110 ~ if property.property_name == "prop_b" [INFO] [stdout] 111 ~ && value.bool.is_some() { [INFO] [stdout] 112 | self.prop_b = value.bool.unwrap(); [INFO] [stdout] 113 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example/example_nested_object.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | / if property.property_name == "prop_d" { [INFO] [stdout] 118 | | if value.i128.is_some() { [INFO] [stdout] 119 | | self.prop_c = value.i128.unwrap(); [INFO] [stdout] 120 | | } [INFO] [stdout] 121 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 117 ~ if property.property_name == "prop_d" [INFO] [stdout] 118 ~ && value.i128.is_some() { [INFO] [stdout] 119 | self.prop_c = value.i128.unwrap(); [INFO] [stdout] 120 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example/example_nested_object.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 123 | / if property.property_name == "prop_e" { [INFO] [stdout] 124 | | if value.f64.is_some() { [INFO] [stdout] 125 | | self.prop_d = value.f64.unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 128 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 123 ~ if property.property_name == "prop_e" [INFO] [stdout] 124 ~ && value.f64.is_some() { [INFO] [stdout] 125 | self.prop_d = value.f64.unwrap(); [INFO] [stdout] 126 | [INFO] [stdout] 127 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.string` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:46:35 [INFO] [stdout] | [INFO] [stdout] 45 | if value.string.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = value.string` [INFO] [stdout] 46 | self.prop_a = value.string.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.bool` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:51:35 [INFO] [stdout] | [INFO] [stdout] 50 | if value.bool.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = value.bool` [INFO] [stdout] 51 | self.prop_b = value.bool.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.bool` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:57:35 [INFO] [stdout] | [INFO] [stdout] 56 | if value.bool.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = value.bool` [INFO] [stdout] 57 | self.prop_c = value.bool.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.i128` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:63:35 [INFO] [stdout] | [INFO] [stdout] 62 | if value.i128.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = value.i128` [INFO] [stdout] 63 | self.prop_d = value.i128.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.f64` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:69:35 [INFO] [stdout] | [INFO] [stdout] 68 | if value.f64.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = value.f64` [INFO] [stdout] 69 | self.prop_e = value.f64.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.array` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:76:92 [INFO] [stdout] | [INFO] [stdout] 75 | if value.array.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = value.array` [INFO] [stdout] 76 | let boxed_array = JSONArrayOfObjects::::from_json(value.array.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_array` after checking its variant with `is_ok` [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:78:44 [INFO] [stdout] | [INFO] [stdout] 77 | if boxed_array.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = boxed_array` [INFO] [stdout] 78 | self.prop_f = Some(boxed_array.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.object` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:87:43 [INFO] [stdout] | [INFO] [stdout] 86 | if value.object.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = value.object` [INFO] [stdout] 87 | let unparsed_object = value.object.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | / if property.property_name == "prop_a" { [INFO] [stdout] 45 | | if value.string.is_some() { [INFO] [stdout] 46 | | self.prop_a = value.string.unwrap(); [INFO] [stdout] 47 | | } [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 44 ~ if property.property_name == "prop_a" [INFO] [stdout] 45 ~ && value.string.is_some() { [INFO] [stdout] 46 | self.prop_a = value.string.unwrap(); [INFO] [stdout] 47 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | / if property.property_name == "prop_b" { [INFO] [stdout] 50 | | if value.bool.is_some() { [INFO] [stdout] 51 | | self.prop_b = value.bool.unwrap(); [INFO] [stdout] 52 | | } [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 49 ~ if property.property_name == "prop_b" [INFO] [stdout] 50 ~ && value.bool.is_some() { [INFO] [stdout] 51 | self.prop_b = value.bool.unwrap(); [INFO] [stdout] 52 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | / if property.property_name == "prop_c" { [INFO] [stdout] 56 | | if value.bool.is_some() { [INFO] [stdout] 57 | | self.prop_c = value.bool.unwrap(); [INFO] [stdout] 58 | | } [INFO] [stdout] 59 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 55 ~ if property.property_name == "prop_c" [INFO] [stdout] 56 ~ && value.bool.is_some() { [INFO] [stdout] 57 | self.prop_c = value.bool.unwrap(); [INFO] [stdout] 58 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | / if property.property_name == "prop_d" { [INFO] [stdout] 62 | | if value.i128.is_some() { [INFO] [stdout] 63 | | self.prop_d = value.i128.unwrap(); [INFO] [stdout] 64 | | } [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 61 ~ if property.property_name == "prop_d" [INFO] [stdout] 62 ~ && value.i128.is_some() { [INFO] [stdout] 63 | self.prop_d = value.i128.unwrap(); [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 67 | / if property.property_name == "prop_e" { [INFO] [stdout] 68 | | if value.f64.is_some() { [INFO] [stdout] 69 | | self.prop_e = value.f64.unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 67 ~ if property.property_name == "prop_e" [INFO] [stdout] 68 ~ && value.f64.is_some() { [INFO] [stdout] 69 | self.prop_e = value.f64.unwrap(); [INFO] [stdout] 70 | [INFO] [stdout] 71 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | / if property.property_name == "prop_f" { [INFO] [stdout] 75 | | if value.array.is_some() { [INFO] [stdout] 76 | | let boxed_array = JSONArrayOfObjects::::from_json(value.array.unwrap()); [INFO] [stdout] 77 | | if boxed_array.is_ok() { [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ if property.property_name == "prop_f" [INFO] [stdout] 75 ~ && value.array.is_some() { [INFO] [stdout] 76 | let boxed_array = JSONArrayOfObjects::::from_json(value.array.unwrap()); [INFO] [stdout] ... [INFO] [stdout] 80 | [INFO] [stdout] 81 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.prop_f` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:176:29 [INFO] [stdout] | [INFO] [stdout] 175 | if self.prop_f.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self.prop_f` [INFO] [stdout] 176 | let array = self.prop_f.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `boxed_json` after checking its variant with `is_ok` [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:179:32 [INFO] [stdout] | [INFO] [stdout] 178 | if boxed_json.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = boxed_json` [INFO] [stdout] 179 | let json = boxed_json.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.prop_g` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:187:30 [INFO] [stdout] | [INFO] [stdout] 186 | if self.prop_g.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self.prop_g` [INFO] [stdout] 187 | let object = self.prop_g.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:149:29 [INFO] [stdout] | [INFO] [stdout] 149 | if property_name == "prop_a".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_a"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:154:29 [INFO] [stdout] | [INFO] [stdout] 154 | if property_name == "prop_b".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_b"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:159:29 [INFO] [stdout] | [INFO] [stdout] 159 | if property_name == "prop_c".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_c"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:164:29 [INFO] [stdout] | [INFO] [stdout] 164 | if property_name == "prop_d".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_d"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:169:29 [INFO] [stdout] | [INFO] [stdout] 169 | if property_name == "prop_e".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_e"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | / if property_name == "prop_f".to_string() { [INFO] [stdout] 175 | | if self.prop_f.is_some() { [INFO] [stdout] 176 | | let array = self.prop_f.as_ref().unwrap(); [INFO] [stdout] 177 | | let boxed_json = JSONArrayOfObjects::::to_json(array); [INFO] [stdout] ... | [INFO] [stdout] 183 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 174 ~ if property_name == "prop_f".to_string() [INFO] [stdout] 175 ~ && self.prop_f.is_some() { [INFO] [stdout] 176 | let array = self.prop_f.as_ref().unwrap(); [INFO] [stdout] ... [INFO] [stdout] 181 | } [INFO] [stdout] 182 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:174:29 [INFO] [stdout] | [INFO] [stdout] 174 | if property_name == "prop_f".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_f"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | / if property_name == "prop_g".to_string() { [INFO] [stdout] 186 | | if self.prop_g.is_some() { [INFO] [stdout] 187 | | let object = self.prop_g.as_ref().unwrap(); [INFO] [stdout] 188 | | let json = object.to_json_string(); [INFO] [stdout] ... | [INFO] [stdout] 191 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 185 ~ if property_name == "prop_g".to_string() [INFO] [stdout] 186 ~ && self.prop_g.is_some() { [INFO] [stdout] 187 | let object = self.prop_g.as_ref().unwrap(); [INFO] [stdout] 188 | let json = object.to_json_string(); [INFO] [stdout] 189 | value.object = Some(json); [INFO] [stdout] 190 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_object.rs:185:29 [INFO] [stdout] | [INFO] [stdout] 185 | if property_name == "prop_g".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_g"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.string` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_nested_object.rs:38:35 [INFO] [stdout] | [INFO] [stdout] 37 | if value.string.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = value.string` [INFO] [stdout] 38 | self.prop_a = value.string.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.bool` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_nested_object.rs:43:35 [INFO] [stdout] | [INFO] [stdout] 42 | if value.bool.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = value.bool` [INFO] [stdout] 43 | self.prop_b = value.bool.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.i128` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_nested_object.rs:50:35 [INFO] [stdout] | [INFO] [stdout] 49 | if value.i128.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = value.i128` [INFO] [stdout] 50 | self.prop_c = value.i128.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `value.f64` after checking its variant with `is_some` [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_nested_object.rs:56:35 [INFO] [stdout] | [INFO] [stdout] 55 | if value.f64.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = value.f64` [INFO] [stdout] 56 | self.prop_d = value.f64.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_nested_object.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | / if property.property_name == "prop_a" { [INFO] [stdout] 37 | | if value.string.is_some() { [INFO] [stdout] 38 | | self.prop_a = value.string.unwrap(); [INFO] [stdout] 39 | | } [INFO] [stdout] 40 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 36 ~ if property.property_name == "prop_a" [INFO] [stdout] 37 ~ && value.string.is_some() { [INFO] [stdout] 38 | self.prop_a = value.string.unwrap(); [INFO] [stdout] 39 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_nested_object.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / if property.property_name == "prop_b" { [INFO] [stdout] 42 | | if value.bool.is_some() { [INFO] [stdout] 43 | | self.prop_b = value.bool.unwrap(); [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 41 ~ if property.property_name == "prop_b" [INFO] [stdout] 42 ~ && value.bool.is_some() { [INFO] [stdout] 43 | self.prop_b = value.bool.unwrap(); [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_nested_object.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | / if property.property_name == "prop_d" { [INFO] [stdout] 49 | | if value.i128.is_some() { [INFO] [stdout] 50 | | self.prop_c = value.i128.unwrap(); [INFO] [stdout] 51 | | } [INFO] [stdout] 52 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 48 ~ if property.property_name == "prop_d" [INFO] [stdout] 49 ~ && value.i128.is_some() { [INFO] [stdout] 50 | self.prop_c = value.i128.unwrap(); [INFO] [stdout] 51 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_nested_object.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / if property.property_name == "prop_e" { [INFO] [stdout] 55 | | if value.f64.is_some() { [INFO] [stdout] 56 | | self.prop_d = value.f64.unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 54 ~ if property.property_name == "prop_e" [INFO] [stdout] 55 ~ && value.f64.is_some() { [INFO] [stdout] 56 | self.prop_d = value.f64.unwrap(); [INFO] [stdout] 57 | [INFO] [stdout] 58 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_nested_object.rs:102:29 [INFO] [stdout] | [INFO] [stdout] 102 | if property_name == "prop_a".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_a"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_nested_object.rs:107:29 [INFO] [stdout] | [INFO] [stdout] 107 | if property_name == "prop_b".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_b"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_nested_object.rs:113:29 [INFO] [stdout] | [INFO] [stdout] 113 | if property_name == "prop_d".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_d"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/json/array/tests/example_with_asserts/example_nested_object.rs:118:29 [INFO] [stdout] | [INFO] [stdout] 118 | if property_name == "prop_e".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"prop_e"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `parsed_list.get(0)` [INFO] [stdout] --> src/json/array/tests/example_with_asserts/mod.rs:55:22 [INFO] [stdout] | [INFO] [stdout] 55 | let parsed_obj = parsed_list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `parsed_list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/json/array/tests/example_with_asserts/mod.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | assert_eq!(parsed_obj.prop_b, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 57 - assert_eq!(parsed_obj.prop_b, false); [INFO] [stdout] 57 + assert!(!parsed_obj.prop_b); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/json/array/tests/example_with_asserts/mod.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | assert_eq!(parsed_obj.prop_c, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 58 - assert_eq!(parsed_obj.prop_c, false); [INFO] [stdout] 58 + assert!(!parsed_obj.prop_c); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/json/array/tests/example_with_asserts/mod.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | assert_eq!(parsed_obj.prop_b, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 64 - assert_eq!(parsed_obj.prop_b, true); [INFO] [stdout] 64 + assert!(parsed_obj.prop_b); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/json/array/tests/example_with_asserts/mod.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | assert_eq!(parsed_obj.prop_c, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 65 - assert_eq!(parsed_obj.prop_c, false); [INFO] [stdout] 65 + assert!(!parsed_obj.prop_c); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `list.get(0)` [INFO] [stdout] --> src/json/array/boolean/example_list_bool_with_asserts/mod.rs:15:28 [INFO] [stdout] | [INFO] [stdout] 15 | let element : &bool = list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/json/array/boolean/example_list_bool_with_asserts/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | assert_eq!( *element, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 19 - assert_eq!( *element, false); [INFO] [stdout] 19 + assert!( !(*element)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/boolean/mod.rs:26:43 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn to_json_from_list_bool(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 26 - pub fn to_json_from_list_bool(items : &Vec) -> Result { [INFO] [stdout] 26 + pub fn to_json_from_list_bool(items : &[bool]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `list.get(0)` [INFO] [stdout] --> src/json/array/string/example_list_string_with_asserts/mod.rs:15:30 [INFO] [stdout] | [INFO] [stdout] 15 | let element : &String = list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `starts_with` method [INFO] [stdout] --> src/json/array/string/mod.rs:17:46 [INFO] [stdout] | [INFO] [stdout] 17 | let starts_with_quotation_mark = string.chars().next().unwrap() == '"'; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `string.starts_with('\"')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_next_cmp [INFO] [stdout] = note: `#[warn(clippy::chars_next_cmp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `ends_with` method [INFO] [stdout] --> src/json/array/string/mod.rs:18:44 [INFO] [stdout] | [INFO] [stdout] 18 | let ends_with_quotation_mark = string.chars().last().unwrap() == '"'; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `string.ends_with('\"')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stdout] = note: `#[warn(clippy::chars_last_cmp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/json/array/string/mod.rs:23:63 [INFO] [stdout] | [INFO] [stdout] 23 | let message = format!("not a string: {}", item.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/string/mod.rs:31:45 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn to_json_from_list_string(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 31 - pub fn to_json_from_list_string(items : &Vec) -> Result { [INFO] [stdout] 31 + pub fn to_json_from_list_string(items : &[String]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `list.get(0)` [INFO] [stdout] --> src/json/array/null/example_list_null_with_asserts/mod.rs:16:28 [INFO] [stdout] | [INFO] [stdout] 16 | let element : &Null = list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `list.get(0)` [INFO] [stdout] --> src/json/array/float/example_list_f64_with_asserts/mod.rs:14:27 [INFO] [stdout] | [INFO] [stdout] 14 | let element : f64 = *list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `list.get(0)` [INFO] [stdout] --> src/json/array/float/example_list_f32_with_asserts/mod.rs:14:27 [INFO] [stdout] | [INFO] [stdout] 14 | let element : f32 = *list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/float/mod.rs:30:42 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn to_json_from_list_f64(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 30 - pub fn to_json_from_list_f64(items : &Vec) -> Result { [INFO] [stdout] 30 + pub fn to_json_from_list_f64(items : &[f64]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/float/mod.rs:64:42 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn to_json_from_list_f32(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 64 - pub fn to_json_from_list_f32(items : &Vec) -> Result { [INFO] [stdout] 64 + pub fn to_json_from_list_f32(items : &[f32]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `list.get(0)` [INFO] [stdout] --> src/json/array/integer/example_list_i128_with_asserts/mod.rs:14:28 [INFO] [stdout] | [INFO] [stdout] 14 | let element : i128 = *list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `list.get(0)` [INFO] [stdout] --> src/json/array/integer/example_list_i64_with_asserts/mod.rs:14:27 [INFO] [stdout] | [INFO] [stdout] 14 | let element : i64 = *list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `list.get(0)` [INFO] [stdout] --> src/json/array/integer/example_list_i32_with_asserts/mod.rs:14:27 [INFO] [stdout] | [INFO] [stdout] 14 | let element : i32 = *list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `list.get(0)` [INFO] [stdout] --> src/json/array/integer/example_list_i16_with_asserts/mod.rs:14:27 [INFO] [stdout] | [INFO] [stdout] 14 | let element : i16 = *list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `list.get(0)` [INFO] [stdout] --> src/json/array/integer/example_list_i8_with_asserts/mod.rs:14:26 [INFO] [stdout] | [INFO] [stdout] 14 | let element : i8 = *list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `list.get(0)` [INFO] [stdout] --> src/json/array/integer/example_list_u128_with_asserts/mod.rs:14:28 [INFO] [stdout] | [INFO] [stdout] 14 | let element : u128 = *list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `list.get(0)` [INFO] [stdout] --> src/json/array/integer/example_list_u64_with_asserts/mod.rs:14:27 [INFO] [stdout] | [INFO] [stdout] 14 | let element : u64 = *list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `list.get(0)` [INFO] [stdout] --> src/json/array/integer/example_list_u32_with_asserts/mod.rs:14:27 [INFO] [stdout] | [INFO] [stdout] 14 | let element : u32 = *list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `list.get(0)` [INFO] [stdout] --> src/json/array/integer/example_list_u16_with_asserts/mod.rs:14:27 [INFO] [stdout] | [INFO] [stdout] 14 | let element : u16 = *list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `list.get(0)` [INFO] [stdout] --> src/json/array/integer/example_list_u8_with_asserts/mod.rs:14:26 [INFO] [stdout] | [INFO] [stdout] 14 | let element : u8 = *list.get(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: try: `list.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/integer/mod.rs:63:43 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn to_json_from_list_i128(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 63 - pub fn to_json_from_list_i128(items : &Vec) -> Result { [INFO] [stdout] 63 + pub fn to_json_from_list_i128(items : &[i128]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/integer/mod.rs:93:42 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn to_json_from_list_i64(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 93 - pub fn to_json_from_list_i64(items : &Vec) -> Result { [INFO] [stdout] 93 + pub fn to_json_from_list_i64(items : &[i64]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/integer/mod.rs:123:42 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn to_json_from_list_i32(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 123 - pub fn to_json_from_list_i32(items : &Vec) -> Result { [INFO] [stdout] 123 + pub fn to_json_from_list_i32(items : &[i32]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/integer/mod.rs:153:42 [INFO] [stdout] | [INFO] [stdout] 153 | pub fn to_json_from_list_i16(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 153 - pub fn to_json_from_list_i16(items : &Vec) -> Result { [INFO] [stdout] 153 + pub fn to_json_from_list_i16(items : &[i16]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/integer/mod.rs:183:41 [INFO] [stdout] | [INFO] [stdout] 183 | pub fn to_json_from_list_i8(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 183 - pub fn to_json_from_list_i8(items : &Vec) -> Result { [INFO] [stdout] 183 + pub fn to_json_from_list_i8(items : &[i8]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/integer/mod.rs:213:43 [INFO] [stdout] | [INFO] [stdout] 213 | pub fn to_json_from_list_u128(items : &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 213 - pub fn to_json_from_list_u128(items : &Vec) -> Result { [INFO] [stdout] 213 + pub fn to_json_from_list_u128(items : &[u128]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/json/array/integer/mod.rs:243:42 [INFO] [stdout] | [INFO] [stdout] 243 | pub fn to_json_from_list_u64(items : &Vec) -> Result { [WARN] too many lines in the log, truncating it