[INFO] fetching crate rust-gecko 0.1.0... [INFO] linting rust-gecko-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rust-gecko 0.1.0 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate rust-gecko 0.1.0 [INFO] finished tweaking crates.io crate rust-gecko 0.1.0 [INFO] tweaked toml for crates.io crate rust-gecko 0.1.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rust-gecko 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 164 packages to latest compatible versions [INFO] [stderr] Adding reqwest v0.11.27 (available: v0.13.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c007ddbd347589bc75cba9bad4c89da09202b4472cdf8367f6c13bec05000e03 [INFO] running `Command { std: "docker" "start" "-a" "c007ddbd347589bc75cba9bad4c89da09202b4472cdf8367f6c13bec05000e03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c007ddbd347589bc75cba9bad4c89da09202b4472cdf8367f6c13bec05000e03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c007ddbd347589bc75cba9bad4c89da09202b4472cdf8367f6c13bec05000e03", kill_on_drop: false }` [INFO] [stdout] c007ddbd347589bc75cba9bad4c89da09202b4472cdf8367f6c13bec05000e03 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c35207f885fafb86f6012952b656eb00901802cf9304ee1cae9daa670b6fc111 [INFO] running `Command { std: "docker" "start" "-a" "c35207f885fafb86f6012952b656eb00901802cf9304ee1cae9daa670b6fc111", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking openssl v0.10.76 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking native-tls v0.2.18 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking rust-gecko v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:36:25 [INFO] [stdout] | [INFO] [stdout] 36 | status: status, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:43:25 [INFO] [stdout] | [INFO] [stdout] 43 | status: status, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/macros/coins_m.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | crate::rust_gecko::coins::markets($vs_currency, None, None, None) [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] = note: `#[warn(clippy::crate_in_macro_def)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/macros/coins_m.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | crate::rust_gecko::coins::tickers($id, None, None, None, None, None) [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/macros/simple_m.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | crate::rust_gecko::simple::price($ids, $vs_currencies, None, None, None, None) [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/macros/simple_m.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | crate::rust_gecko::simple::token_price( [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/lib.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | vector_str.push_str(","); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `vector_str.push(',')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:66:16 [INFO] [stdout] | [INFO] [stdout] 66 | if !append_true.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `append_true.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:70:16 [INFO] [stdout] | [INFO] [stdout] 70 | if !append_false.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `append_false.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `append_true` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:67:35 [INFO] [stdout] | [INFO] [stdout] 66 | if !append_true.is_none() { [INFO] [stdout] | --------------------- the check is happening here [INFO] [stdout] 67 | output = [params, append_true.unwrap()].join("&"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `append_false` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:71:35 [INFO] [stdout] | [INFO] [stdout] 70 | if !append_false.is_none() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 71 | output = [params, append_false.unwrap()].join("&"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/asset_platforms.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | let response = gecko::get_request("/asset_platforms", ""); [INFO] [stdout] | ---------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 7 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 6 ~ [INFO] [stdout] 7 ~ gecko::get_request("/asset_platforms", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/categories.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 29 | if !order.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `order.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `order` after checking its variant with `is_none` [INFO] [stdout] --> src/categories.rs:30:36 [INFO] [stdout] | [INFO] [stdout] 29 | if !order.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 30 | params.push_str(&["order", order.unwrap().as_str()].join("=")); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/categories.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 32 | let response = gecko::get_request("/coins/categories", ¶ms); [INFO] [stdout] | ---------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 33 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 32 ~ [INFO] [stdout] 33 ~ gecko::get_request("/coins/categories", ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/categories.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 37 | let response = gecko::get_request("/coins/categories/list", ""); [INFO] [stdout] | ---------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 38 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 37 ~ [INFO] [stdout] 38 ~ gecko::get_request("/coins/categories/list", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/coins.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | !include_platform.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `include_platform.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/coins.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 52 | let response = gecko::get_request("/coins/list", ¶ms); [INFO] [stdout] | ---------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 53 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 52 ~ [INFO] [stdout] 53 ~ gecko::get_request("/coins/list", ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/coins.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | &mut String::from("?"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 47 - &mut String::from("?"), [INFO] [stdout] 47 + &String::from("?"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/coins.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 64 | if !ids.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `ids.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/coins.rs:68:8 [INFO] [stdout] | [INFO] [stdout] 68 | if !category.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `category.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/coins.rs:72:8 [INFO] [stdout] | [INFO] [stdout] 72 | if !order.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `order.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ids` after checking its variant with `is_none` [INFO] [stdout] --> src/coins.rs:65:63 [INFO] [stdout] | [INFO] [stdout] 64 | if !ids.is_none() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 65 | params.push_str(&["&ids", &gecko::vec_str_2_comma_str(ids.unwrap())].join("=")); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `category` after checking its variant with `is_none` [INFO] [stdout] --> src/coins.rs:69:41 [INFO] [stdout] | [INFO] [stdout] 68 | if !category.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 69 | params.push_str(&["&category", &category.unwrap()].join("=")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `order` after checking its variant with `is_none` [INFO] [stdout] --> src/coins.rs:73:38 [INFO] [stdout] | [INFO] [stdout] 72 | if !order.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 73 | params.push_str(&["&order", &order.unwrap().as_str()].join("=")); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/coins.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 76 | let response = gecko::get_request("/coins/markets", ¶ms); [INFO] [stdout] | ------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 77 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 76 ~ [INFO] [stdout] 77 ~ gecko::get_request("/coins/markets", ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/coins.rs:69:40 [INFO] [stdout] | [INFO] [stdout] 69 | params.push_str(&["&category", &category.unwrap()].join("=")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `category.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/coins.rs:73:37 [INFO] [stdout] | [INFO] [stdout] 73 | params.push_str(&["&order", &order.unwrap().as_str()].join("=")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `order.unwrap().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/coins.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 129 | let response = gecko::get_request(&["/coins", id].join("/"), ¶ms); [INFO] [stdout] | ---------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 130 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 129 ~ [INFO] [stdout] 130 ~ gecko::get_request(&["/coins", id].join("/"), ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/coins.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | !exchange_ids.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `exchange_ids.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/coins.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | !page.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `page.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/coins.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | !order.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `order.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/coins.rs:180:5 [INFO] [stdout] | [INFO] [stdout] 179 | let response = gecko::get_request(&["/coins", id, "tickers"].join("/"), ¶ms); [INFO] [stdout] | --------------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 180 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 179 ~ [INFO] [stdout] 180 ~ gecko::get_request(&["/coins", id, "tickers"].join("/"), ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/coins.rs:154:14 [INFO] [stdout] | [INFO] [stdout] 154 | Some(&"include_exchange_logo"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"include_exchange_logo"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/coins.rs:192:5 [INFO] [stdout] | [INFO] [stdout] 191 | let response = gecko::get_request(&["/coins", id, "history"].join("/"), ¶ms); [INFO] [stdout] | --------------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 192 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 191 ~ [INFO] [stdout] 192 ~ gecko::get_request(&["/coins", id, "history"].join("/"), ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/coins.rs:201:8 [INFO] [stdout] | [INFO] [stdout] 201 | if !interval.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `interval.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `interval` after checking its variant with `is_none` [INFO] [stdout] --> src/coins.rs:202:40 [INFO] [stdout] | [INFO] [stdout] 201 | if !interval.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 202 | params.push_str(&["&interval", interval.unwrap()].join("=")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/coins.rs:205:5 [INFO] [stdout] | [INFO] [stdout] 204 | let response = gecko::get_request(&["/coins", id, "market_chart"].join("/"), ¶ms); [INFO] [stdout] | -------------------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 205 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 204 ~ [INFO] [stdout] 205 ~ gecko::get_request(&["/coins", id, "market_chart"].join("/"), ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/coins.rs:218:5 [INFO] [stdout] | [INFO] [stdout] 214 | / let response = gecko::get_request( [INFO] [stdout] 215 | | &["/coins", id, "market_chart", "range"].join("/"), [INFO] [stdout] 216 | | &["?vs_currency", vs_currency, "&from", from, "&to", to].join("="), [INFO] [stdout] 217 | | ); [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 218 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 214 ~ [INFO] [stdout] 215 ~ gecko::get_request( [INFO] [stdout] 216 + &["/coins", id, "market_chart", "range"].join("/"), [INFO] [stdout] 217 + &["?vs_currency", vs_currency, "&from", from, "&to", to].join("="), [INFO] [stdout] 218 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/coins.rs:226:5 [INFO] [stdout] | [INFO] [stdout] 222 | / let response = gecko::get_request( [INFO] [stdout] 223 | | &["/coins", id, "ohlc"].join("/"), [INFO] [stdout] 224 | | &["?vs_currency", vs_currency, "&days", days].join("="), [INFO] [stdout] 225 | | ); [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 226 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 222 ~ [INFO] [stdout] 223 ~ gecko::get_request( [INFO] [stdout] 224 + &["/coins", id, "ohlc"].join("/"), [INFO] [stdout] 225 + &["?vs_currency", vs_currency, "&days", days].join("="), [INFO] [stdout] 226 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/companies.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 21 | let response = gecko::get_request(&url, ""); [INFO] [stdout] | -------------------------------------------- unnecessary `let` binding [INFO] [stdout] 22 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 21 ~ [INFO] [stdout] 22 ~ gecko::get_request(&url, "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/contract.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 7 | let response = gecko::get_request(&url, ""); [INFO] [stdout] | -------------------------------------------- unnecessary `let` binding [INFO] [stdout] 8 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 7 ~ [INFO] [stdout] 8 ~ gecko::get_request(&url, "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/contract.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 19 | let response = gecko::get_request(&url, ¶ms); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 20 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 19 ~ [INFO] [stdout] 20 ~ gecko::get_request(&url, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/contract.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 35 | let response = gecko::get_request(&url, ¶ms); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 36 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 35 ~ [INFO] [stdout] 36 ~ gecko::get_request(&url, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/derivatives.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | !include_tickers.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `include_tickers.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/derivatives.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 52 | let response = gecko::get_request(&url, ¶ms); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 53 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 52 ~ [INFO] [stdout] 53 ~ gecko::get_request(&url, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/derivatives.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 46 - &mut params, [INFO] [stdout] 46 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/derivatives.rs:48:35 [INFO] [stdout] | [INFO] [stdout] 48 | Some(&["include_tickers", &include_tickers.unwrap().as_str()].join("=")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `include_tickers.unwrap().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/derivatives.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | !order.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `order.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/derivatives.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | !per_page.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `per_page.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/derivatives.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | !page.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `page.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/derivatives.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 86 | let response = gecko::get_request(&url, ¶ms); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 87 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 86 ~ [INFO] [stdout] 87 ~ gecko::get_request(&url, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/derivatives.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 66 - &mut params, [INFO] [stdout] 66 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/derivatives.rs:68:25 [INFO] [stdout] | [INFO] [stdout] 68 | Some(&["order", &order.unwrap().as_str()].join("=")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `order.unwrap().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/derivatives.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 73 - &mut params, [INFO] [stdout] 73 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/derivatives.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 80 - &mut params, [INFO] [stdout] 80 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/derivatives.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | !include_tickers.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `include_tickers.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/derivatives.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 101 | let response = gecko::get_request(&url, ¶ms); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 102 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 101 ~ [INFO] [stdout] 102 ~ gecko::get_request(&url, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/derivatives.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 96 - &mut params, [INFO] [stdout] 96 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/derivatives.rs:98:35 [INFO] [stdout] | [INFO] [stdout] 98 | Some(&["include_tickers", &include_tickers.unwrap().as_str()].join("=")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `include_tickers.unwrap().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/derivatives.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 106 | let response = gecko::get_request("/exchanges/list", ""); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 107 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 106 ~ [INFO] [stdout] 107 ~ gecko::get_request("/exchanges/list", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/exchange_rates.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | let response = gecko::get_request("/exchange_rates", ""); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 7 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 6 ~ [INFO] [stdout] 7 ~ gecko::get_request("/exchange_rates", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/exchanges.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | !per_page.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `per_page.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/exchanges.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | !page.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `page.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/exchanges.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 53 | let response = gecko::get_request(&url, ¶ms); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 54 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 53 ~ [INFO] [stdout] 54 ~ gecko::get_request(&url, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/exchanges.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 40 - &mut params, [INFO] [stdout] 40 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/exchanges.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 47 - &mut params, [INFO] [stdout] 47 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/exchanges.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 57 | let response = gecko::get_request("/exchanges/list", ""); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 58 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 57 ~ [INFO] [stdout] 58 ~ gecko::get_request("/exchanges/list", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/exchanges.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 63 | let response = gecko::get_request(&url, ""); [INFO] [stdout] | -------------------------------------------- unnecessary `let` binding [INFO] [stdout] 64 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 63 ~ [INFO] [stdout] 64 ~ gecko::get_request(&url, "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:36:25 [INFO] [stdout] | [INFO] [stdout] 36 | status: status, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:43:25 [INFO] [stdout] | [INFO] [stdout] 43 | status: status, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/exchanges.rs:62:15 [INFO] [stdout] | [INFO] [stdout] 62 | let url = String::from(["/exchanges", id].join("=")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `["/exchanges", id].join("=")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/exchanges.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | !coin_ids.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `coin_ids.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/exchanges.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | !include_exchange_logo.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `include_exchange_logo.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/exchanges.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | !page.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `page.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/exchanges.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | !depth.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `depth.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/exchanges.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | !order.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `order.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/exchanges.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 119 | let response = gecko::get_request(&url, ¶ms); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 120 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 119 ~ [INFO] [stdout] 120 ~ gecko::get_request(&url, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/exchanges.rs:75:15 [INFO] [stdout] | [INFO] [stdout] 75 | let url = String::from(["/exchanges/", id, "/tickers"].join("/")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `["/exchanges/", id, "/tickers"].join("/")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/exchanges.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 79 - &mut params, [INFO] [stdout] 79 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/exchanges.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 86 - &mut params, [INFO] [stdout] 86 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/exchanges.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 99 - &mut params, [INFO] [stdout] 99 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/exchanges.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 106 - &mut params, [INFO] [stdout] 106 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/exchanges.rs:108:25 [INFO] [stdout] | [INFO] [stdout] 108 | Some(&["depth", &depth.unwrap().as_str()].join("=")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `depth.unwrap().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/exchanges.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 113 - &mut params, [INFO] [stdout] 113 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/exchanges.rs:115:25 [INFO] [stdout] | [INFO] [stdout] 115 | Some(&["order", &order.unwrap().as_str()].join("=")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `order.unwrap().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/exchanges.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 126 | let response = gecko::get_request(&url, ¶ms); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 127 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 126 ~ [INFO] [stdout] 127 ~ gecko::get_request(&url, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/exchanges.rs:124:15 [INFO] [stdout] | [INFO] [stdout] 124 | let url = String::from(["/exchanges/", id, "/volume_chart"].join("/")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `["/exchanges/", id, "/volume_chart"].join("/")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/global.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | let response = gecko::get_request("/global", ""); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 7 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 6 ~ [INFO] [stdout] 7 ~ gecko::get_request("/global", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/global.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | let response = gecko::get_request("/global/decentralized_finance_defi", ""); [INFO] [stdout] | ---------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 12 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 11 ~ [INFO] [stdout] 12 ~ gecko::get_request("/global/decentralized_finance_defi", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/indexes.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | !per_page.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `per_page.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/indexes.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | !page.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `page.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/indexes.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 23 | let response = gecko::get_request(&url, ¶ms); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 24 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 23 ~ [INFO] [stdout] 24 ~ gecko::get_request(&url, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/indexes.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 10 - &mut params, [INFO] [stdout] 10 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/indexes.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 17 - &mut params, [INFO] [stdout] 17 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/macros/coins_m.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | crate::rust_gecko::coins::markets($vs_currency, None, None, None) [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] = note: `#[warn(clippy::crate_in_macro_def)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/macros/coins_m.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | crate::rust_gecko::coins::tickers($id, None, None, None, None, None) [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/indexes.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 30 | let response = gecko::get_request(&url, ""); [INFO] [stdout] | -------------------------------------------- unnecessary `let` binding [INFO] [stdout] 31 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 30 ~ [INFO] [stdout] 31 ~ gecko::get_request(&url, "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/macros/simple_m.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | crate::rust_gecko::simple::price($ids, $vs_currencies, None, None, None, None) [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/indexes.rs:28:15 [INFO] [stdout] | [INFO] [stdout] 28 | let url = String::from(["/indexes", market_id, id].join("/")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `["/indexes", market_id, id].join("/")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `crate` references the macro call's crate [INFO] [stdout] --> src/macros/simple_m.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | crate::rust_gecko::simple::token_price( [INFO] [stdout] | ^^^^^ help: to reference the macro definition's crate, use: `$crate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/indexes.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 35 | let response = gecko::get_request("/indexes/list", ""); [INFO] [stdout] | ------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 36 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 35 ~ [INFO] [stdout] 36 ~ gecko::get_request("/indexes/list", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/search.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | let response = gecko::get_request("/search?query=", query); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 7 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 6 ~ [INFO] [stdout] 7 ~ gecko::get_request("/search?query=", query) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/server.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | let response = gecko::get_request(&endpoint, ""); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 9 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 8 ~ [INFO] [stdout] 9 ~ gecko::get_request(&endpoint, "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/simple.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 42 | let response = gecko::get_request(&endpoint, ¶ms); [INFO] [stdout] | ------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 43 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 42 ~ [INFO] [stdout] 43 ~ gecko::get_request(&endpoint, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/simple.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 88 | let response = gecko::get_request(&endpoint, ¶ms); [INFO] [stdout] | ------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 89 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 88 ~ [INFO] [stdout] 89 ~ gecko::get_request(&endpoint, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/simple.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 95 | let response = gecko::get_request(&endpoint, ""); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 96 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 95 ~ [INFO] [stdout] 96 ~ gecko::get_request(&endpoint, "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/simple.rs:95:39 [INFO] [stdout] | [INFO] [stdout] 95 | let response = gecko::get_request(&endpoint, ""); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `endpoint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/trending.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | let response = gecko::get_request("/search/trending", ""); [INFO] [stdout] | ---------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 7 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 6 ~ [INFO] [stdout] 7 ~ gecko::get_request("/search/trending", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/lib.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | vector_str.push_str(","); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `vector_str.push(',')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:66:16 [INFO] [stdout] | [INFO] [stdout] 66 | if !append_true.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `append_true.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:70:16 [INFO] [stdout] | [INFO] [stdout] 70 | if !append_false.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `append_false.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `append_true` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:67:35 [INFO] [stdout] | [INFO] [stdout] 66 | if !append_true.is_none() { [INFO] [stdout] | --------------------- the check is happening here [INFO] [stdout] 67 | output = [params, append_true.unwrap()].join("&"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `append_false` after checking its variant with `is_none` [INFO] [stdout] --> src/lib.rs:71:35 [INFO] [stdout] | [INFO] [stdout] 70 | if !append_false.is_none() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 71 | output = [params, append_false.unwrap()].join("&"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/asset_platforms.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | let response = gecko::get_request("/asset_platforms", ""); [INFO] [stdout] | ---------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 7 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 6 ~ [INFO] [stdout] 7 ~ gecko::get_request("/asset_platforms", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/categories.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 29 | if !order.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `order.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `order` after checking its variant with `is_none` [INFO] [stdout] --> src/categories.rs:30:36 [INFO] [stdout] | [INFO] [stdout] 29 | if !order.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 30 | params.push_str(&["order", order.unwrap().as_str()].join("=")); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/categories.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 32 | let response = gecko::get_request("/coins/categories", ¶ms); [INFO] [stdout] | ---------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 33 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 32 ~ [INFO] [stdout] 33 ~ gecko::get_request("/coins/categories", ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/categories.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 37 | let response = gecko::get_request("/coins/categories/list", ""); [INFO] [stdout] | ---------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 38 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 37 ~ [INFO] [stdout] 38 ~ gecko::get_request("/coins/categories/list", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/coins.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | !include_platform.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `include_platform.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/coins.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 52 | let response = gecko::get_request("/coins/list", ¶ms); [INFO] [stdout] | ---------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 53 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 52 ~ [INFO] [stdout] 53 ~ gecko::get_request("/coins/list", ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/coins.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | &mut String::from("?"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 47 - &mut String::from("?"), [INFO] [stdout] 47 + &String::from("?"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/coins.rs:64:8 [INFO] [stdout] | [INFO] [stdout] 64 | if !ids.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `ids.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/coins.rs:68:8 [INFO] [stdout] | [INFO] [stdout] 68 | if !category.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `category.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/coins.rs:72:8 [INFO] [stdout] | [INFO] [stdout] 72 | if !order.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `order.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ids` after checking its variant with `is_none` [INFO] [stdout] --> src/coins.rs:65:63 [INFO] [stdout] | [INFO] [stdout] 64 | if !ids.is_none() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 65 | params.push_str(&["&ids", &gecko::vec_str_2_comma_str(ids.unwrap())].join("=")); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `category` after checking its variant with `is_none` [INFO] [stdout] --> src/coins.rs:69:41 [INFO] [stdout] | [INFO] [stdout] 68 | if !category.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 69 | params.push_str(&["&category", &category.unwrap()].join("=")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `order` after checking its variant with `is_none` [INFO] [stdout] --> src/coins.rs:73:38 [INFO] [stdout] | [INFO] [stdout] 72 | if !order.is_none() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 73 | params.push_str(&["&order", &order.unwrap().as_str()].join("=")); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/coins.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 76 | let response = gecko::get_request("/coins/markets", ¶ms); [INFO] [stdout] | ------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 77 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 76 ~ [INFO] [stdout] 77 ~ gecko::get_request("/coins/markets", ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/coins.rs:69:40 [INFO] [stdout] | [INFO] [stdout] 69 | params.push_str(&["&category", &category.unwrap()].join("=")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `category.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/coins.rs:73:37 [INFO] [stdout] | [INFO] [stdout] 73 | params.push_str(&["&order", &order.unwrap().as_str()].join("=")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `order.unwrap().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/coins.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 129 | let response = gecko::get_request(&["/coins", id].join("/"), ¶ms); [INFO] [stdout] | ---------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 130 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 129 ~ [INFO] [stdout] 130 ~ gecko::get_request(&["/coins", id].join("/"), ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/coins.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | !exchange_ids.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `exchange_ids.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/coins.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | !page.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `page.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/coins.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | !order.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `order.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/coins.rs:180:5 [INFO] [stdout] | [INFO] [stdout] 179 | let response = gecko::get_request(&["/coins", id, "tickers"].join("/"), ¶ms); [INFO] [stdout] | --------------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 180 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 179 ~ [INFO] [stdout] 180 ~ gecko::get_request(&["/coins", id, "tickers"].join("/"), ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/coins.rs:154:14 [INFO] [stdout] | [INFO] [stdout] 154 | Some(&"include_exchange_logo"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"include_exchange_logo"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/coins.rs:192:5 [INFO] [stdout] | [INFO] [stdout] 191 | let response = gecko::get_request(&["/coins", id, "history"].join("/"), ¶ms); [INFO] [stdout] | --------------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 192 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 191 ~ [INFO] [stdout] 192 ~ gecko::get_request(&["/coins", id, "history"].join("/"), ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/coins.rs:201:8 [INFO] [stdout] | [INFO] [stdout] 201 | if !interval.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `interval.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `interval` after checking its variant with `is_none` [INFO] [stdout] --> src/coins.rs:202:40 [INFO] [stdout] | [INFO] [stdout] 201 | if !interval.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 202 | params.push_str(&["&interval", interval.unwrap()].join("=")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/coins.rs:205:5 [INFO] [stdout] | [INFO] [stdout] 204 | let response = gecko::get_request(&["/coins", id, "market_chart"].join("/"), ¶ms); [INFO] [stdout] | -------------------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 205 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 204 ~ [INFO] [stdout] 205 ~ gecko::get_request(&["/coins", id, "market_chart"].join("/"), ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/coins.rs:218:5 [INFO] [stdout] | [INFO] [stdout] 214 | / let response = gecko::get_request( [INFO] [stdout] 215 | | &["/coins", id, "market_chart", "range"].join("/"), [INFO] [stdout] 216 | | &["?vs_currency", vs_currency, "&from", from, "&to", to].join("="), [INFO] [stdout] 217 | | ); [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 218 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 214 ~ [INFO] [stdout] 215 ~ gecko::get_request( [INFO] [stdout] 216 + &["/coins", id, "market_chart", "range"].join("/"), [INFO] [stdout] 217 + &["?vs_currency", vs_currency, "&from", from, "&to", to].join("="), [INFO] [stdout] 218 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/coins.rs:226:5 [INFO] [stdout] | [INFO] [stdout] 222 | / let response = gecko::get_request( [INFO] [stdout] 223 | | &["/coins", id, "ohlc"].join("/"), [INFO] [stdout] 224 | | &["?vs_currency", vs_currency, "&days", days].join("="), [INFO] [stdout] 225 | | ); [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 226 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 222 ~ [INFO] [stdout] 223 ~ gecko::get_request( [INFO] [stdout] 224 + &["/coins", id, "ohlc"].join("/"), [INFO] [stdout] 225 + &["?vs_currency", vs_currency, "&days", days].join("="), [INFO] [stdout] 226 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/companies.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 21 | let response = gecko::get_request(&url, ""); [INFO] [stdout] | -------------------------------------------- unnecessary `let` binding [INFO] [stdout] 22 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 21 ~ [INFO] [stdout] 22 ~ gecko::get_request(&url, "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/contract.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 7 | let response = gecko::get_request(&url, ""); [INFO] [stdout] | -------------------------------------------- unnecessary `let` binding [INFO] [stdout] 8 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 7 ~ [INFO] [stdout] 8 ~ gecko::get_request(&url, "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/contract.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 19 | let response = gecko::get_request(&url, ¶ms); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 20 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 19 ~ [INFO] [stdout] 20 ~ gecko::get_request(&url, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/contract.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 35 | let response = gecko::get_request(&url, ¶ms); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 36 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 35 ~ [INFO] [stdout] 36 ~ gecko::get_request(&url, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/derivatives.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | !include_tickers.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `include_tickers.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/derivatives.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 52 | let response = gecko::get_request(&url, ¶ms); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 53 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 52 ~ [INFO] [stdout] 53 ~ gecko::get_request(&url, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/derivatives.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 46 - &mut params, [INFO] [stdout] 46 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/derivatives.rs:48:35 [INFO] [stdout] | [INFO] [stdout] 48 | Some(&["include_tickers", &include_tickers.unwrap().as_str()].join("=")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `include_tickers.unwrap().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/derivatives.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | !order.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `order.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/derivatives.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | !per_page.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `per_page.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/derivatives.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | !page.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `page.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/derivatives.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 86 | let response = gecko::get_request(&url, ¶ms); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 87 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 86 ~ [INFO] [stdout] 87 ~ gecko::get_request(&url, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/derivatives.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 66 - &mut params, [INFO] [stdout] 66 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/derivatives.rs:68:25 [INFO] [stdout] | [INFO] [stdout] 68 | Some(&["order", &order.unwrap().as_str()].join("=")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `order.unwrap().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/derivatives.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 73 - &mut params, [INFO] [stdout] 73 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/derivatives.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 80 - &mut params, [INFO] [stdout] 80 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/derivatives.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | !include_tickers.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `include_tickers.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/derivatives.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 101 | let response = gecko::get_request(&url, ¶ms); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 102 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 101 ~ [INFO] [stdout] 102 ~ gecko::get_request(&url, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/derivatives.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 96 - &mut params, [INFO] [stdout] 96 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/derivatives.rs:98:35 [INFO] [stdout] | [INFO] [stdout] 98 | Some(&["include_tickers", &include_tickers.unwrap().as_str()].join("=")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `include_tickers.unwrap().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/derivatives.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 106 | let response = gecko::get_request("/exchanges/list", ""); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 107 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 106 ~ [INFO] [stdout] 107 ~ gecko::get_request("/exchanges/list", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/exchange_rates.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | let response = gecko::get_request("/exchange_rates", ""); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 7 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 6 ~ [INFO] [stdout] 7 ~ gecko::get_request("/exchange_rates", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/exchanges.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | !per_page.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `per_page.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/exchanges.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | !page.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `page.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/exchanges.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 53 | let response = gecko::get_request(&url, ¶ms); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 54 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 53 ~ [INFO] [stdout] 54 ~ gecko::get_request(&url, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/exchanges.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 40 - &mut params, [INFO] [stdout] 40 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/exchanges.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 47 - &mut params, [INFO] [stdout] 47 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/exchanges.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 57 | let response = gecko::get_request("/exchanges/list", ""); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 58 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 57 ~ [INFO] [stdout] 58 ~ gecko::get_request("/exchanges/list", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/exchanges.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 63 | let response = gecko::get_request(&url, ""); [INFO] [stdout] | -------------------------------------------- unnecessary `let` binding [INFO] [stdout] 64 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 63 ~ [INFO] [stdout] 64 ~ gecko::get_request(&url, "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/exchanges.rs:62:15 [INFO] [stdout] | [INFO] [stdout] 62 | let url = String::from(["/exchanges", id].join("=")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `["/exchanges", id].join("=")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/exchanges.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | !coin_ids.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `coin_ids.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/exchanges.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | !include_exchange_logo.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `include_exchange_logo.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/exchanges.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | !page.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `page.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/exchanges.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | !depth.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `depth.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/exchanges.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | !order.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `order.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/exchanges.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 119 | let response = gecko::get_request(&url, ¶ms); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 120 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 119 ~ [INFO] [stdout] 120 ~ gecko::get_request(&url, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/exchanges.rs:75:15 [INFO] [stdout] | [INFO] [stdout] 75 | let url = String::from(["/exchanges/", id, "/tickers"].join("/")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `["/exchanges/", id, "/tickers"].join("/")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/exchanges.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 79 - &mut params, [INFO] [stdout] 79 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/exchanges.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 86 - &mut params, [INFO] [stdout] 86 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/exchanges.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 99 - &mut params, [INFO] [stdout] 99 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/exchanges.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 106 - &mut params, [INFO] [stdout] 106 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/exchanges.rs:108:25 [INFO] [stdout] | [INFO] [stdout] 108 | Some(&["depth", &depth.unwrap().as_str()].join("=")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `depth.unwrap().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/exchanges.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 113 - &mut params, [INFO] [stdout] 113 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/exchanges.rs:115:25 [INFO] [stdout] | [INFO] [stdout] 115 | Some(&["order", &order.unwrap().as_str()].join("=")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `order.unwrap().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/exchanges.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 126 | let response = gecko::get_request(&url, ¶ms); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 127 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 126 ~ [INFO] [stdout] 127 ~ gecko::get_request(&url, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/exchanges.rs:124:15 [INFO] [stdout] | [INFO] [stdout] 124 | let url = String::from(["/exchanges/", id, "/volume_chart"].join("/")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `["/exchanges/", id, "/volume_chart"].join("/")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/global.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | let response = gecko::get_request("/global", ""); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 7 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 6 ~ [INFO] [stdout] 7 ~ gecko::get_request("/global", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/global.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | let response = gecko::get_request("/global/decentralized_finance_defi", ""); [INFO] [stdout] | ---------------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 12 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 11 ~ [INFO] [stdout] 12 ~ gecko::get_request("/global/decentralized_finance_defi", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/indexes.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | !per_page.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `per_page.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/indexes.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | !page.is_none(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `page.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/indexes.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 23 | let response = gecko::get_request(&url, ¶ms); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 24 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 23 ~ [INFO] [stdout] 24 ~ gecko::get_request(&url, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/indexes.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 10 - &mut params, [INFO] [stdout] 10 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `gecko::append_if` doesn't need a mutable reference [INFO] [stdout] --> src/indexes.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | &mut params, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 17 - &mut params, [INFO] [stdout] 17 + ¶ms, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/indexes.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 30 | let response = gecko::get_request(&url, ""); [INFO] [stdout] | -------------------------------------------- unnecessary `let` binding [INFO] [stdout] 31 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 30 ~ [INFO] [stdout] 31 ~ gecko::get_request(&url, "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 37.02s [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/indexes.rs:28:15 [INFO] [stdout] | [INFO] [stdout] 28 | let url = String::from(["/indexes", market_id, id].join("/")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `["/indexes", market_id, id].join("/")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/indexes.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 35 | let response = gecko::get_request("/indexes/list", ""); [INFO] [stdout] | ------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 36 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 35 ~ [INFO] [stdout] 36 ~ gecko::get_request("/indexes/list", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/search.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | let response = gecko::get_request("/search?query=", query); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 7 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 6 ~ [INFO] [stdout] 7 ~ gecko::get_request("/search?query=", query) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/server.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | let response = gecko::get_request(&endpoint, ""); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 9 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 8 ~ [INFO] [stdout] 9 ~ gecko::get_request(&endpoint, "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/simple.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 42 | let response = gecko::get_request(&endpoint, ¶ms); [INFO] [stdout] | ------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 43 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 42 ~ [INFO] [stdout] 43 ~ gecko::get_request(&endpoint, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/simple.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 88 | let response = gecko::get_request(&endpoint, ¶ms); [INFO] [stdout] | ------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 89 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 88 ~ [INFO] [stdout] 89 ~ gecko::get_request(&endpoint, ¶ms) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/simple.rs:96:5 [INFO] [stdout] | [INFO] [stdout] 95 | let response = gecko::get_request(&endpoint, ""); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 96 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 95 ~ [INFO] [stdout] 96 ~ gecko::get_request(&endpoint, "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/simple.rs:95:39 [INFO] [stdout] | [INFO] [stdout] 95 | let response = gecko::get_request(&endpoint, ""); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `endpoint` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/trending.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | let response = gecko::get_request("/search/trending", ""); [INFO] [stdout] | ---------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 7 | response [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 6 ~ [INFO] [stdout] 7 ~ gecko::get_request("/search/trending", "") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "c35207f885fafb86f6012952b656eb00901802cf9304ee1cae9daa670b6fc111", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c35207f885fafb86f6012952b656eb00901802cf9304ee1cae9daa670b6fc111", kill_on_drop: false }` [INFO] [stdout] c35207f885fafb86f6012952b656eb00901802cf9304ee1cae9daa670b6fc111