[INFO] fetching crate rtlola-interpreter 0.11.0... [INFO] linting rtlola-interpreter-0.11.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rtlola-interpreter 0.11.0 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate rtlola-interpreter 0.11.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate rtlola-interpreter 0.11.0 [INFO] tweaked toml for crates.io crate rtlola-interpreter 0.11.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rtlola-interpreter 0.11.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate rtlola-interpreter 0.11.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rtlola-frontend v0.8.0 [INFO] [stderr] Downloaded rtlola-reporting v0.3.1 [INFO] [stderr] Downloaded junit-report v0.8.3 [INFO] [stderr] Downloaded rtlola-macros v0.1.2 [INFO] [stderr] Downloaded string_template v0.2.1 [INFO] [stderr] Downloaded rusttyc v0.5.0 [INFO] [stderr] Downloaded priority-queue v1.4.0 [INFO] [stderr] Downloaded dot v0.1.4 [INFO] [stderr] Downloaded rtlola-hir v0.6.0 [INFO] [stderr] Downloaded rtlola-parser v0.4.0 [INFO] [stderr] Downloaded crossterm v0.25.0 [INFO] [stderr] Downloaded uom v0.31.1 [INFO] [stderr] Downloaded rust_decimal v1.37.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 054b372ea38f9737e5764fa472695f39a00df480acdad254bacb2c8a9482576e [INFO] running `Command { std: "docker" "start" "-a" "054b372ea38f9737e5764fa472695f39a00df480acdad254bacb2c8a9482576e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "054b372ea38f9737e5764fa472695f39a00df480acdad254bacb2c8a9482576e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "054b372ea38f9737e5764fa472695f39a00df480acdad254bacb2c8a9482576e", kill_on_drop: false }` [INFO] [stdout] 054b372ea38f9737e5764fa472695f39a00df480acdad254bacb2c8a9482576e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4a664c1344b49ae2841b8dfd3804bf6ed8beafff8048631c9971bf49f9d7f8ed [INFO] running `Command { std: "docker" "start" "-a" "4a664c1344b49ae2841b8dfd3804bf6ed8beafff8048631c9971bf49f9d7f8ed", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling num-bigint v0.3.3 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling rust_decimal v1.37.1 [INFO] [stderr] Checking num-complex v0.3.1 [INFO] [stderr] Checking fixedbitset v0.2.0 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling priority-queue v1.4.0 [INFO] [stderr] Compiling rustix v1.0.7 [INFO] [stderr] Compiling time-core v0.1.4 [INFO] [stderr] Checking rusttyc v0.5.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling time-macros v0.2.22 [INFO] [stderr] Checking deranged v0.4.0 [INFO] [stderr] Checking vte v0.14.1 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking dot v0.1.4 [INFO] [stderr] Checking clap_builder v4.5.38 [INFO] [stderr] Compiling clap_derive v4.5.32 [INFO] [stderr] Checking strip-ansi-escapes v0.2.1 [INFO] [stderr] Checking string_template v0.2.1 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking petgraph v0.5.1 [INFO] [stderr] Checking ordered-float v3.9.2 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking quick-xml v0.31.0 [INFO] [stderr] Checking bimap v0.6.3 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking dyn-clone v1.0.19 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking pest v2.8.0 [INFO] [stderr] Checking clap v4.5.38 [INFO] [stderr] Checking tempfile v3.20.0 [INFO] [stderr] Compiling pest_meta v2.8.0 [INFO] [stderr] Compiling pest_generator v2.8.0 [INFO] [stderr] Compiling pest_derive v2.8.0 [INFO] [stderr] Compiling rtlola-macros v0.1.2 [INFO] [stderr] Compiling derive-getters v0.3.0 [INFO] [stderr] Checking junit-report v0.8.3 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking csv v1.3.1 [INFO] [stderr] Checking rtlola-reporting v0.3.1 [INFO] [stderr] Checking uom v0.31.1 [INFO] [stderr] Checking num v0.3.1 [INFO] [stderr] Checking rtlola-parser v0.4.0 [INFO] [stderr] Checking rtlola-hir v0.6.0 [INFO] [stderr] Checking rtlola-frontend v0.8.0 [INFO] [stderr] Checking rtlola-interpreter v0.11.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/api/input.rs:86:41 [INFO] [stdout] | [INFO] [stdout] 86 | pub type ValueGetter = Box Result)>; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 86 - pub type ValueGetter = Box Result)>; [INFO] [stdout] 86 + pub type ValueGetter = Box Result>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/api/input.rs:86:41 [INFO] [stdout] | [INFO] [stdout] 86 | pub type ValueGetter = Box Result)>; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 86 - pub type ValueGetter = Box Result)>; [INFO] [stdout] 86 + pub type ValueGetter = Box Result>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/api/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | //! If implemented this traits provides functionality to generate a new value for any input stream from the data structure. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/api/monitor.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | //! If implemented this traits provides functionality to generate a new value for any input stream from the data structure. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/api/queued.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | //! If implemented this traits provides functionality to generate a new value for any input stream from the data structure. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/evaluator.rs:1274:57 [INFO] [stdout] | [INFO] [stdout] 1274 | pub(crate) fn with_new_instance<'a>(&'a self, inst: &'a Vec) -> EvaluationContext<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1274 - pub(crate) fn with_new_instance<'a>(&'a self, inst: &'a Vec) -> EvaluationContext<'a> { [INFO] [stdout] 1274 + pub(crate) fn with_new_instance<'a>(&'a self, inst: &'a [Value]) -> EvaluationContext<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/api/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | //! If implemented this traits provides functionality to generate a new value for any input stream from the data structure. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/api/monitor.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | //! If implemented this traits provides functionality to generate a new value for any input stream from the data structure. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/storage/instance_aggregations.rs:1007:12 [INFO] [stdout] | [INFO] [stdout] 1007 | if count % 100 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `count.is_multiple_of(100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/api/monitor.rs:595:10 [INFO] [stdout] | [INFO] [stdout] 595 | ) -> ( [INFO] [stdout] | __________^ [INFO] [stdout] 596 | | Instant, [INFO] [stdout] 597 | | Monitor< [INFO] [stdout] 598 | | ArrayFactory, [INFO] [stdout] ... | [INFO] [stdout] 602 | | >, [INFO] [stdout] 603 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/api/queued.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | //! If implemented this traits provides functionality to generate a new value for any input stream from the data structure. [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/api/queued.rs:761:10 [INFO] [stdout] | [INFO] [stdout] 761 | ) -> ( [INFO] [stdout] | __________^ [INFO] [stdout] 762 | | Instant, [INFO] [stdout] 763 | | QueuedMonitor< [INFO] [stdout] 764 | | ArrayFactory, [INFO] [stdout] ... | [INFO] [stdout] 768 | | >, [INFO] [stdout] 769 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/storage/window.rs:583:12 [INFO] [stdout] | [INFO] [stdout] 583 | if relative_to_window % self.bucket_duration == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `relative_to_window.is_multiple_of(self.bucket_duration)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/storage/window.rs:599:25 [INFO] [stdout] | [INFO] [stdout] 599 | let period = if (current_time - self.start_time) % self.total_duration == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(current_time - self.start_time).is_multiple_of(self.total_duration)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/evaluator.rs:1274:57 [INFO] [stdout] | [INFO] [stdout] 1274 | pub(crate) fn with_new_instance<'a>(&'a self, inst: &'a Vec) -> EvaluationContext<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1274 - pub(crate) fn with_new_instance<'a>(&'a self, inst: &'a Vec) -> EvaluationContext<'a> { [INFO] [stdout] 1274 + pub(crate) fn with_new_instance<'a>(&'a self, inst: &'a [Value]) -> EvaluationContext<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/evaluator.rs:1561:54 [INFO] [stdout] | [INFO] [stdout] 1561 | peek_assert_eq!(eval, start, 0, vec![], Bool(!false)); [INFO] [stdout] | ^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/evaluator.rs:1562:54 [INFO] [stdout] | [INFO] [stdout] 1562 | peek_assert_eq!(eval, start, 1, vec![], Bool(!true)); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/evaluator.rs:1569:54 [INFO] [stdout] | [INFO] [stdout] 1569 | peek_assert_eq!(eval, start, 8, vec![], Bool(false || false)); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/evaluator.rs:1570:54 [INFO] [stdout] | [INFO] [stdout] 1570 | peek_assert_eq!(eval, start, 9, vec![], Bool(false || true)); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/evaluator.rs:1571:55 [INFO] [stdout] | [INFO] [stdout] 1571 | peek_assert_eq!(eval, start, 10, vec![], Bool(true || false)); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/evaluator.rs:1572:55 [INFO] [stdout] | [INFO] [stdout] 1572 | peek_assert_eq!(eval, start, 11, vec![], Bool(true || true)); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/evaluator.rs:1573:55 [INFO] [stdout] | [INFO] [stdout] 1573 | peek_assert_eq!(eval, start, 12, vec![], Bool(false && false)); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/evaluator.rs:1574:55 [INFO] [stdout] | [INFO] [stdout] 1574 | peek_assert_eq!(eval, start, 13, vec![], Bool(false && true)); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/evaluator.rs:1575:55 [INFO] [stdout] | [INFO] [stdout] 1575 | peek_assert_eq!(eval, start, 14, vec![], Bool(true && false)); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/evaluator.rs:1576:55 [INFO] [stdout] | [INFO] [stdout] 1576 | peek_assert_eq!(eval, start, 15, vec![], Bool(true && true)); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f64` is unnecessary [INFO] [stdout] --> src/evaluator.rs:1993:59 [INFO] [stdout] | [INFO] [stdout] 1993 | accept_input_timed!(eval, in_ref, Value::try_from(1 as f64).unwrap(), time); [INFO] [stdout] | ^^^^^^^^ help: try: `1_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f64` is unnecessary [INFO] [stdout] --> src/evaluator.rs:2020:59 [INFO] [stdout] | [INFO] [stdout] 2020 | accept_input_timed!(eval, in_ref, Value::try_from(2 as f64).unwrap(), time); [INFO] [stdout] | ^^^^^^^^ help: try: `2_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f64` is unnecessary [INFO] [stdout] --> src/evaluator.rs:2047:59 [INFO] [stdout] | [INFO] [stdout] 2047 | accept_input_timed!(eval, in_ref, Value::try_from(3 as f64).unwrap(), time); [INFO] [stdout] | ^^^^^^^^ help: try: `3_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `v` is only used to index `input_val` [INFO] [stdout] --> src/evaluator.rs:2286:22 [INFO] [stdout] | [INFO] [stdout] 2286 | for v in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 2286 - for v in 0..n { [INFO] [stdout] 2286 + for in input_val.iter().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `v` is only used to index `input_val` [INFO] [stdout] --> src/evaluator.rs:2394:22 [INFO] [stdout] | [INFO] [stdout] 2394 | for v in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 2394 - for v in 0..n { [INFO] [stdout] 2394 + for in input_val.iter().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> tests/api_e2e.rs:216:25 [INFO] [stdout] | [INFO] [stdout] 216 | ) -> Result Result)>, Self::Error> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 216 - ) -> Result Result)>, Self::Error> { [INFO] [stdout] 216 + ) -> Result Result >, Self::Error> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/storage/instance_aggregations.rs:1007:12 [INFO] [stdout] | [INFO] [stdout] 1007 | if count % 100 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace with: `count.is_multiple_of(100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/storage/instance_aggregations.rs:1047:9 [INFO] [stdout] | [INFO] [stdout] 1047 | Value::try_from(Decimal::try_from(f).unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `Decimal` to `Value` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 1047 - Value::try_from(Decimal::try_from(f).unwrap()).unwrap() [INFO] [stdout] 1047 + Value::from(Decimal::try_from(f).unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/storage/instance_aggregations.rs:1064:34 [INFO] [stdout] | [INFO] [stdout] 1064 | for (idx, val) in values.into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `clone` can be replaced with `std::slice::from_ref` [INFO] [stdout] --> src/storage/instance_aggregations.rs:1066:33 [INFO] [stdout] | [INFO] [stdout] 1066 | res.create_instance(&[parameter.clone()]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `std::slice::from_ref(¶meter)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_ref_to_slice_refs [INFO] [stdout] = note: `#[warn(clippy::cloned_ref_to_slice_refs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/storage/instance_aggregations.rs:1081:34 [INFO] [stdout] | [INFO] [stdout] 1081 | for (idx, val) in values.into_iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/storage/window.rs:583:12 [INFO] [stdout] | [INFO] [stdout] 583 | if relative_to_window % self.bucket_duration == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `relative_to_window.is_multiple_of(self.bucket_duration)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/storage/window.rs:599:25 [INFO] [stdout] | [INFO] [stdout] 599 | let period = if (current_time - self.start_time) % self.total_duration == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(current_time - self.start_time).is_multiple_of(self.total_duration)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `Iterator::fold` on a type that implements `Try` [INFO] [stdout] --> tests/api_e2e.rs:168:18 [INFO] [stdout] | [INFO] [stdout] 168 | .fold(Some(0u32), |val, (pos, c)| { [INFO] [stdout] | __________________^ [INFO] [stdout] 169 | | val.and_then(|val| { [INFO] [stdout] 170 | | c.to_digit(10) [INFO] [stdout] 171 | | .map(|c| val + c * (10u32.pow(8 - pos as u32))) [INFO] [stdout] 172 | | }) [INFO] [stdout] 173 | | }) [INFO] [stdout] | |__________________^ help: use `try_fold` instead: `try_fold(0u32, |val, (pos, c)| ...)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold [INFO] [stdout] = note: `#[warn(clippy::manual_try_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> tests/api_e2e.rs:327:35 [INFO] [stdout] | [INFO] [stdout] 327 | .position(|h| h == &name) [INFO] [stdout] | ^^^^^----- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> tests/api_e2e.rs:370:41 [INFO] [stdout] | [INFO] [stdout] 370 | let actual = HashSet::from_iter(actual.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/collect.rs:152:20 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 370 - let actual = HashSet::from_iter(actual.into_iter()); [INFO] [stdout] 370 + let actual = HashSet::from_iter(actual); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 32.73s [INFO] running `Command { std: "docker" "inspect" "4a664c1344b49ae2841b8dfd3804bf6ed8beafff8048631c9971bf49f9d7f8ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4a664c1344b49ae2841b8dfd3804bf6ed8beafff8048631c9971bf49f9d7f8ed", kill_on_drop: false }` [INFO] [stdout] 4a664c1344b49ae2841b8dfd3804bf6ed8beafff8048631c9971bf49f9d7f8ed