[INFO] fetching crate rsw 0.8.0... [INFO] linting rsw-0.8.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate rsw 0.8.0 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate rsw 0.8.0 [INFO] finished tweaking crates.io crate rsw 0.8.0 [INFO] tweaked toml for crates.io crate rsw 0.8.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate rsw 0.8.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate rsw 0.8.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded which v4.3.0 [INFO] [stderr] Downloaded filetime v0.2.15 [INFO] [stderr] Downloaded net2 v0.2.38 [INFO] [stderr] Downloaded clap_derive v3.0.14 [INFO] [stderr] Downloaded anyhow v1.0.53 [INFO] [stderr] Downloaded indexmap v1.8.0 [INFO] [stderr] Downloaded serde_derive v1.0.136 [INFO] [stderr] Downloaded serde v1.0.136 [INFO] [stderr] Downloaded once_cell v1.10.0 [INFO] [stderr] Downloaded quote v1.0.15 [INFO] [stderr] Downloaded clap v3.0.14 [INFO] [stderr] Downloaded syn v1.0.86 [INFO] [stderr] Downloaded tokio v1.18.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5608e38005bd1fdc436bf7434867c3807e89c8d977f26d56d35cbee2d957be73 [INFO] running `Command { std: "docker" "start" "-a" "5608e38005bd1fdc436bf7434867c3807e89c8d977f26d56d35cbee2d957be73", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5608e38005bd1fdc436bf7434867c3807e89c8d977f26d56d35cbee2d957be73", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5608e38005bd1fdc436bf7434867c3807e89c8d977f26d56d35cbee2d957be73", kill_on_drop: false }` [INFO] [stdout] 5608e38005bd1fdc436bf7434867c3807e89c8d977f26d56d35cbee2d957be73 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 04841a0f60e2b082cf96a1a7a27b5426a3ab5a03b6fe55b40eb8e5f725921c89 [INFO] running `Command { std: "docker" "start" "-a" "04841a0f60e2b082cf96a1a7a27b5426a3ab5a03b6fe55b40eb8e5f725921c89", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Compiling anyhow v1.0.53 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking path-clean v0.1.0 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.38 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking filetime v0.2.15 [INFO] [stderr] Checking which v4.3.0 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking inotify v0.7.1 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking notify v4.0.17 [INFO] [stderr] Checking globset v0.4.8 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking ignore v0.4.18 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling clap_derive v3.0.14 [INFO] [stderr] Checking tokio v1.18.0 [INFO] [stderr] Checking clap v3.0.14 [INFO] [stderr] Checking rsw v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/config.rs:9:23 [INFO] [stdout] | [INFO] [stdout] 9 | pub static RSW_FILE: &'static str = "rsw.toml"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/config.rs:10:22 [INFO] [stdout] | [INFO] [stdout] 10 | pub static RSW_DIR: &'static str = ".rsw"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/config.rs:11:25 [INFO] [stdout] | [INFO] [stdout] 11 | pub static RSW_CRATES: &'static str = "rsw.crates"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/config.rs:12:23 [INFO] [stdout] | [INFO] [stdout] 12 | pub static RSW_INFO: &'static str = "rsw.info"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/config.rs:13:22 [INFO] [stdout] | [INFO] [stdout] 13 | pub static RSW_ERR: &'static str = "rsw.err"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/config.rs:9:23 [INFO] [stdout] | [INFO] [stdout] 9 | pub static RSW_FILE: &'static str = "rsw.toml"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/config.rs:10:22 [INFO] [stdout] | [INFO] [stdout] 10 | pub static RSW_DIR: &'static str = ".rsw"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/config.rs:11:25 [INFO] [stdout] | [INFO] [stdout] 11 | pub static RSW_CRATES: &'static str = "rsw.crates"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/config.rs:12:23 [INFO] [stdout] | [INFO] [stdout] 12 | pub static RSW_INFO: &'static str = "rsw.info"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/config.rs:13:22 [INFO] [stdout] | [INFO] [stdout] 13 | pub static RSW_ERR: &'static str = "rsw.err"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/core/build.rs:63:16 [INFO] [stdout] | [INFO] [stdout] 63 | if !scope.is_none() && !scope.unwrap().is_empty() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `scope.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `scope` after checking its variant with `is_none` [INFO] [stdout] --> src/core/build.rs:65:27 [INFO] [stdout] | [INFO] [stdout] 63 | if !scope.is_none() && !scope.unwrap().is_empty() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 64 | args.push("--scope"); [INFO] [stdout] 65 | args.push(scope.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/core/build.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/core/build.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | / match status.code() { [INFO] [stdout] 83 | | Some(code) => { [INFO] [stdout] 84 | | if code == 0 { [INFO] [stdout] 85 | | print(RswInfo::CrateOk( [INFO] [stdout] ... | [INFO] [stdout] 109 | | _ => {} [INFO] [stdout] 110 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 82 ~ if let Some(code) = status.code() { [INFO] [stdout] 83 + if code == 0 { [INFO] [stdout] 84 + print(RswInfo::CrateOk( [INFO] [stdout] 85 + name.into(), [INFO] [stdout] 86 + rsw_type.into(), [INFO] [stdout] 87 + metadata["package"]["version"].to_string(), [INFO] [stdout] 88 + )); [INFO] [stdout] 89 + } else { [INFO] [stdout] 90 + let output = Command::new("wasm-pack") [INFO] [stdout] 91 + .args(&args) [INFO] [stdout] 92 + .stderr(std::process::Stdio::piped()) [INFO] [stdout] 93 + .output() [INFO] [stdout] 94 + .unwrap(); [INFO] [stdout] 95 + [INFO] [stdout] 96 + let err = std::str::from_utf8(&output.stderr).unwrap(); [INFO] [stdout] 97 + let info_content = format!( [INFO] [stdout] 98 + "[RSW::ERR]\n[RSW::NAME] :~> {}\n[RSW::BUILD] :~> wasm-pack {}", [INFO] [stdout] 99 + name, [INFO] [stdout] 100 + &args.join(" ") [INFO] [stdout] 101 + ); [INFO] [stdout] 102 + rsw_watch_file(info_content.as_bytes(), err.as_bytes(), "err".into()).unwrap(); [INFO] [stdout] 103 + print(RswInfo::CrateFail(name.into(), rsw_type.into())); [INFO] [stdout] 104 + [INFO] [stdout] 105 + is_ok = false; [INFO] [stdout] 106 + } [INFO] [stdout] 107 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/core/clean.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new(config: RswConfig) { [INFO] [stdout] 15 | | let mut crates: Vec = Vec::new(); [INFO] [stdout] 16 | | let mut path_map: HashMap = HashMap::new(); [INFO] [stdout] ... | [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/core/cli.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | / pub fn new() { [INFO] [stdout] 49 | | match &Cli::parse().command { [INFO] [stdout] 50 | | Commands::Init => Cli::rsw_init(), [INFO] [stdout] 51 | | Commands::Clean => Cli::rsw_clean(), [INFO] [stdout] ... | [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/core/cli.rs:79:19 [INFO] [stdout] | [INFO] [stdout] 79 | callback: Option>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/core/cli.rs:116:52 [INFO] [stdout] | [INFO] [stdout] 116 | crate_out.clean().to_string_lossy().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/core/create.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 54 | if !arg_tpl.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `arg_tpl.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/core/create.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if !arg_mode.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `arg_mode.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/core/create.rs:66:38 [INFO] [stdout] | [INFO] [stdout] 66 | if arg_use == "wasm-pack" || !arg_tpl.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `arg_tpl.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `arg_tpl` after checking its variant with `is_none` [INFO] [stdout] --> src/core/create.rs:56:23 [INFO] [stdout] | [INFO] [stdout] 54 | if !arg_tpl.is_none() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 55 | args.push("--template"); [INFO] [stdout] 56 | args.push(arg_tpl.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `arg_mode` after checking its variant with `is_none` [INFO] [stdout] --> src/core/create.rs:62:23 [INFO] [stdout] | [INFO] [stdout] 60 | if !arg_mode.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 61 | args.push("--mode"); [INFO] [stdout] 62 | args.push(arg_mode.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/core/create.rs:116:38 [INFO] [stdout] | [INFO] [stdout] 116 | let template = Template::new(&root); [INFO] [stdout] | ^^^^^ help: change this to: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/create.rs:124:40 [INFO] [stdout] | [INFO] [stdout] 124 | write_file(root, "Cargo.toml", &cargo.as_bytes())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `cargo.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/core/init.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn new() -> std::io::Result<()> { [INFO] [stdout] 17 | | if !path_exists(Path::new(config::RSW_FILE)) { [INFO] [stdout] 18 | | File::create(config::RSW_FILE)?.write_all(template::RSW_TOML)?; [INFO] [stdout] 19 | | print(RswInfo::RswTomlOk); [INFO] [stdout] ... | [INFO] [stdout] 24 | | Ok(()) [INFO] [stdout] 25 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/core/watch.rs:18:15 [INFO] [stdout] | [INFO] [stdout] 18 | callback: Arc, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/core/watch.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 24 | callback: Arc, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/core/watch.rs:93:46 [INFO] [stdout] | [INFO] [stdout] 93 | if gitignore.matched(&project_path, false).is_ignore() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `eprint!()` with a format string that ends in a single newline [INFO] [stdout] --> src/utils.rs:23:17 [INFO] [stdout] | [INFO] [stdout] 23 | eprint!("{}\n", e); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `eprintln!` instead [INFO] [stdout] | [INFO] [stdout] 23 - eprint!("{}\n", e); [INFO] [stdout] 23 + eprintln!("{}", e); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/utils.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 51 | let value = content.parse::().unwrap(); [INFO] [stdout] | ---------------------------------------------- unnecessary `let` binding [INFO] [stdout] 52 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 51 ~ [INFO] [stdout] 52 ~ content.parse::().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/utils.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | if caps.get(2) != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `caps.get(2).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/utils.rs:151:43 [INFO] [stdout] | [INFO] [stdout] 151 | Level::Info | Level::Error => format!(""), [INFO] [stdout] | ^^^^^^^^^^^ help: consider using `String::new()`: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/core/build.rs:63:16 [INFO] [stdout] | [INFO] [stdout] 63 | if !scope.is_none() && !scope.unwrap().is_empty() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `scope.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `scope` after checking its variant with `is_none` [INFO] [stdout] --> src/core/build.rs:65:27 [INFO] [stdout] | [INFO] [stdout] 63 | if !scope.is_none() && !scope.unwrap().is_empty() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] 64 | args.push("--scope"); [INFO] [stdout] 65 | args.push(scope.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/core/build.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/core/build.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | / match status.code() { [INFO] [stdout] 83 | | Some(code) => { [INFO] [stdout] 84 | | if code == 0 { [INFO] [stdout] 85 | | print(RswInfo::CrateOk( [INFO] [stdout] ... | [INFO] [stdout] 109 | | _ => {} [INFO] [stdout] 110 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 82 ~ if let Some(code) = status.code() { [INFO] [stdout] 83 + if code == 0 { [INFO] [stdout] 84 + print(RswInfo::CrateOk( [INFO] [stdout] 85 + name.into(), [INFO] [stdout] 86 + rsw_type.into(), [INFO] [stdout] 87 + metadata["package"]["version"].to_string(), [INFO] [stdout] 88 + )); [INFO] [stdout] 89 + } else { [INFO] [stdout] 90 + let output = Command::new("wasm-pack") [INFO] [stdout] 91 + .args(&args) [INFO] [stdout] 92 + .stderr(std::process::Stdio::piped()) [INFO] [stdout] 93 + .output() [INFO] [stdout] 94 + .unwrap(); [INFO] [stdout] 95 + [INFO] [stdout] 96 + let err = std::str::from_utf8(&output.stderr).unwrap(); [INFO] [stdout] 97 + let info_content = format!( [INFO] [stdout] 98 + "[RSW::ERR]\n[RSW::NAME] :~> {}\n[RSW::BUILD] :~> wasm-pack {}", [INFO] [stdout] 99 + name, [INFO] [stdout] 100 + &args.join(" ") [INFO] [stdout] 101 + ); [INFO] [stdout] 102 + rsw_watch_file(info_content.as_bytes(), err.as_bytes(), "err".into()).unwrap(); [INFO] [stdout] 103 + print(RswInfo::CrateFail(name.into(), rsw_type.into())); [INFO] [stdout] 104 + [INFO] [stdout] 105 + is_ok = false; [INFO] [stdout] 106 + } [INFO] [stdout] 107 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/core/clean.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new(config: RswConfig) { [INFO] [stdout] 15 | | let mut crates: Vec = Vec::new(); [INFO] [stdout] 16 | | let mut path_map: HashMap = HashMap::new(); [INFO] [stdout] ... | [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/core/cli.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | / pub fn new() { [INFO] [stdout] 49 | | match &Cli::parse().command { [INFO] [stdout] 50 | | Commands::Init => Cli::rsw_init(), [INFO] [stdout] 51 | | Commands::Clean => Cli::rsw_clean(), [INFO] [stdout] ... | [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/core/cli.rs:79:19 [INFO] [stdout] | [INFO] [stdout] 79 | callback: Option>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/core/cli.rs:116:52 [INFO] [stdout] | [INFO] [stdout] 116 | crate_out.clean().to_string_lossy().to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/core/create.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 54 | if !arg_tpl.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `arg_tpl.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/core/create.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if !arg_mode.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `arg_mode.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/core/create.rs:66:38 [INFO] [stdout] | [INFO] [stdout] 66 | if arg_use == "wasm-pack" || !arg_tpl.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `arg_tpl.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `arg_tpl` after checking its variant with `is_none` [INFO] [stdout] --> src/core/create.rs:56:23 [INFO] [stdout] | [INFO] [stdout] 54 | if !arg_tpl.is_none() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 55 | args.push("--template"); [INFO] [stdout] 56 | args.push(arg_tpl.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `arg_mode` after checking its variant with `is_none` [INFO] [stdout] --> src/core/create.rs:62:23 [INFO] [stdout] | [INFO] [stdout] 60 | if !arg_mode.is_none() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 61 | args.push("--mode"); [INFO] [stdout] 62 | args.push(arg_mode.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/core/create.rs:116:38 [INFO] [stdout] | [INFO] [stdout] 116 | let template = Template::new(&root); [INFO] [stdout] | ^^^^^ help: change this to: `root` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/create.rs:124:40 [INFO] [stdout] | [INFO] [stdout] 124 | write_file(root, "Cargo.toml", &cargo.as_bytes())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `cargo.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/core/init.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn new() -> std::io::Result<()> { [INFO] [stdout] 17 | | if !path_exists(Path::new(config::RSW_FILE)) { [INFO] [stdout] 18 | | File::create(config::RSW_FILE)?.write_all(template::RSW_TOML)?; [INFO] [stdout] 19 | | print(RswInfo::RswTomlOk); [INFO] [stdout] ... | [INFO] [stdout] 24 | | Ok(()) [INFO] [stdout] 25 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/core/watch.rs:18:15 [INFO] [stdout] | [INFO] [stdout] 18 | callback: Arc, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/core/watch.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 24 | callback: Arc, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/core/watch.rs:93:46 [INFO] [stdout] | [INFO] [stdout] 93 | if gitignore.matched(&project_path, false).is_ignore() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `eprint!()` with a format string that ends in a single newline [INFO] [stdout] --> src/utils.rs:23:17 [INFO] [stdout] | [INFO] [stdout] 23 | eprint!("{}\n", e); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `eprintln!` instead [INFO] [stdout] | [INFO] [stdout] 23 - eprint!("{}\n", e); [INFO] [stdout] 23 + eprintln!("{}", e); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/utils.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 51 | let value = content.parse::().unwrap(); [INFO] [stdout] | ---------------------------------------------- unnecessary `let` binding [INFO] [stdout] 52 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 51 ~ [INFO] [stdout] 52 ~ content.parse::().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/utils.rs:65:8 [INFO] [stdout] | [INFO] [stdout] 65 | if caps.get(2) != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `caps.get(2).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/utils.rs:151:43 [INFO] [stdout] | [INFO] [stdout] 151 | Level::Info | Level::Error => format!(""), [INFO] [stdout] | ^^^^^^^^^^^ help: consider using `String::new()`: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/utils.rs:252:28 [INFO] [stdout] | [INFO] [stdout] 252 | assert_eq!(get_pkg("@rsw/test".into()), ("test".into(), "rsw".into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"@rsw/test"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/utils.rs:257:28 [INFO] [stdout] | [INFO] [stdout] 257 | assert_eq!(get_pkg("wasm123".into()), ("wasm123".into(), "".into())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"wasm123"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `&str` [INFO] [stdout] --> src/utils.rs:263:21 [INFO] [stdout] | [INFO] [stdout] 263 | get_pkg("@rsw-org/my_wasm".into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"@rsw-org/my_wasm"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use rsw; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use rsw; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.20s [INFO] running `Command { std: "docker" "inspect" "04841a0f60e2b082cf96a1a7a27b5426a3ab5a03b6fe55b40eb8e5f725921c89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "04841a0f60e2b082cf96a1a7a27b5426a3ab5a03b6fe55b40eb8e5f725921c89", kill_on_drop: false }` [INFO] [stdout] 04841a0f60e2b082cf96a1a7a27b5426a3ab5a03b6fe55b40eb8e5f725921c89